[Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #45257|0   |1
is obsolete||

--- Comment #7 from Alex Arnaud  ---
Created attachment 46018
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46018=edit
Bug 15188 - remove_unused_authorities.pl dies if zebra server is not running

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14638] Update serials help files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14638

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
  Attachment #46019|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358

Beda Szukics  changed:

   What|Removed |Added

 CC||b...@kollegium-sarnen.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15439] New: Current Location incorrect when item in transit

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15439

Bug ID: 15439
   Summary: Current Location incorrect when item in transit
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

When filling a hold request at library A for pickup at library B, while the
item is in transit to library B, the current location shows as library B.  This
should show library A until it reaches library B and is scanned.  At the very
least, there should be a preference for this behavior.

Christopher

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14638] Update serials help files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14638

--- Comment #5 from Brendan Gallagher  ---
Created attachment 46019
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46019=edit
Bug 14638: Update Serials Help

The serials help file was out of date for 3.18+

To test:

* apply patch
* Go to serials > new subscription
* Click help
* Confirm help correct

Signed-off-by: Aleisha 

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15438] New: Checking out an on-hold item sends holder's borrowernumber in AF (screen message) field.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

Bug ID: 15438
   Summary: Checking out an on-hold item sends holder's
borrowernumber in AF (screen message) field.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

Replicated in master.

Description: Let's say that 'Holding Patron' puts a hold on title 'ASDF'. If
'SIP  Patron' then tries to check out ASDF, Holding Patron's card number
appears in the AF (i.e. Screen Message) field. This only occurs if the hold has
*not* yet been finalized -- If ASDF is waiting for Holding Patron, the screen
message will read "Item is on hold shelf for another patron."

The screen message containing only the Holding Patron's borrowernumber is
confusing because a) It contains no context as to the nature of the number
showing on the screen b) SIP devices work with borrower card numbers, so the
number being returned has the wrong context. Furthermore, we're leaking patron
information in a place where we probably would never check.

Replicating the problem:

Set up instance with two patrons, as well as a bib/item to put on hold/check
out.
Make sure that circ rules allow holds.
Set up SIPconfig.xml to allow checkouts on the IP/port of your choice.
Start SIP2. Make sure that authentication, checkin and check out work for the
'SIP Patron'.
Ensure that AllowItemsOnHoldCheckout is set to "Don't Allow".

In the steps to replicate, the Title/barcode of the item on hold/being checked
out will be 'asdf'. The Holding Patron will be referred to as 'holder' and the
checkout patron will be referred to as 'sipper'. Let's say that sipper's
borrowernumber is 52.

1/ Place a biblio level hold for asdf, with holder as the holding patron.
2/ Start `sudo tail -f /var/log/syslog | grep sip`
3/ Attempt to check out asdf to sipper. You will see the sip checkout message
'11...' followed by a '120...|AF52|...' sip checkout response. This indicates
that the checkout has failed (which we would expect), and that the screen
message is '52'.

Example using ./misc/sip_cli_emulator.pl

$ ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su staff -sp staff -l CPL
--patron 23529001223636
--password 1234 --item 1234 -m checkout
Attempting socket connection to 127.0.0.1:6001...connected!
SEND: 9300CNstaff|COstaff|CPCPL|
READ: 941

Trying 'checkout'
SEND: 11YN2015122905321120151229   
053211AOCPL|AA23529001223636|AB1234|ACstaff|AD1234|BON|BIN|
READ: 120NUN20151229053211AOCPL|AA23529001223636|AB1234|AJTheories of human
development :|AH|AF52|BLY|BV5.00|BHUSD|BT06|

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188

--- Comment #8 from Alex Arnaud  ---
(In reply to Jonathan Druart from comment #6)
> Have a look at about.pl
>  94 my $errZebraConnection = C4::Context->Zconn("biblioserver",0)->errcode();
> 
> This could do the trick correctly.

My apologies

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #17 from Brendan Gallagher  ---
Pushed to master - thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15224] Typo: Leave empty to add via item search (itemnunber).

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15224

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #6 from Brendan Gallagher  ---
pushed to master 
thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15224] Typo: Leave empty to add via item search (itemnunber).

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15224

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15224] Typo: Leave empty to add via item search (itemnunber).

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15224

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45155|0   |1
is obsolete||

--- Comment #5 from Brendan Gallagher  ---
Created attachment 46049
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46049=edit
Bug 15224: Label creator - fix tiny typo 'itemnunber'

To test:
- Go to Tools > Label creator > New > Label batch
- Check text displayed in grey next to the text input
  field

Signed-off-by: Hector Castro 

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #4 from Katrin Fischer  ---
Thx a lot!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15411] "Non fiction" is incorrect

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from M. Tompsett  ---
$ git grep -i "non fiction" | grep -v "\/po\/"

Please correct Italian, Polish, and Staff client catalogue help files.

koha qa test tools passed.
Currently does all that is described.
However, because of the three files which still need updating, marking Failed
QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15237] Quote of the day: Better translatibility for editor and help

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15237

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45160|0   |1
is obsolete||

--- Comment #6 from Brendan Gallagher  ---
Created attachment 46044
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46044=edit
Bug 15237: Quote of the day: Better translatibility for editor and help

This patch moves  html markup out of explanatory text in Quote of the day
editor and help
for better translatibility (Home > Tools > Quote Editor).

To test:
- Apply patch
- Go to Home > Tools > Quote Editor and related Help
- Verify that text changes make sense.

Signed-off-by: Hector Castro 
Rewording Ok for translation purposes

Signed-off-by: Jonathan Druart 
Amended patch: Make consistent space after "Note:" (inside the br tag)

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15237] Quote of the day: Better translatibility for editor and help

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15237

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #7 from Brendan Gallagher  ---
Pushed to master - Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15373] Zip should be ZIP

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373

M. Tompsett  changed:

   What|Removed |Added

  Attachment #45872|0   |1
is obsolete||

--- Comment #9 from M. Tompsett  ---
Created attachment 46046
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46046=edit
Bug 15373: More changes of Zip to ZIP on intranet

To test:

- Log in to Staff Interface, go to Administration, Libraries and Groups
(cgi-bin/koha/admin/branches.pl). Click 'New library' and confirm that it says
'ZIP/Postal Code:' in the form.
- Go back to Administration, Cities and towns (cgi-bin/koha/admin/cities.pl).
Confirm it says 'ZIP/Postal code' in table heading. Click 'New city' and
confirm it says 'ZIP/Postal code:' in form
- Go back to Administration, Global system preferences, I18L/L10N
(cgi-bin/koha/admin/preferences.pl?tab=i18n_l10n). Under AddressFormat, confirm
all available options say '[ZIP/Postal Code]'
- Go to Reports, Patrons (cgi-bin/koha/reports/borrowers_stats.pl). Confirm it
says 'ZIP/Postal code' under Title
- Go to Tools, Batch patron modification (cgi-bin/koha/tools/modborrowers.pl),
enter any card number and click 'Continue'. Confirm it says 'ZIP/Postal code'
in the table of patron details, and in the form to edit

Signed-off-by: Mark Tompsett 
NOTE: Tested together with first patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15373] Zip should be ZIP

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373

M. Tompsett  changed:

   What|Removed |Added

  Attachment #45727|0   |1
is obsolete||

--- Comment #8 from M. Tompsett  ---
Created attachment 46045
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46045=edit
Bug 15373: Changing Zip to ZIP on OPAC and Intranet

To test:

1) Login to OPAC --> You personal details.
2) Ensure it says 'ZIP/Postal Code' under Main Address, Alternate Address and
Alternate Contact
3) Login to Staff interface --> Go to a member's page (ie
koha/members/memberentry.pl) --> Details.
4) Ensure it says 'ZIP/Postal Code' under Alternate address and Alternative
contact
5) Click Edit
6) Ensure it says 'ZIP/Postal Code' under Main Address, Alternate Address and
Alternate Contact

Signed-off-by: Barry Cannon 
Signed-off-by: Mark Tompsett 
NOTE: Tested together with second patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15373] Zip should be ZIP

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15238] Better translatability for Installer Step 1

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15238

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45312|0   |1
is obsolete||

--- Comment #8 from Brendan Gallagher  ---
Created attachment 46047
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46047=edit
Bug 15238: Better translatability for Installer Step 1

This Bug streamlines html in installer/step1.tt for better translatibility.

To test:
Reviwe code and verify that changes in text make sense.

Signed-off-by: Hector Castro 
To reproduce in Debian environment, remove a required module with
dpkg -r. Rewording Ok for translation purposes

Bug 15238: (followup) Remove word 'Note:'

'Note: ' removed as requested in comment #3

Signed-off-by: Hector Castro 
Word 'Note' removed

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15238] Better translatability for Installer Step 1

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15238

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #9 from Brendan Gallagher  ---
pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15220] typo in circ rules help

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15220

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #8 from Brendan Gallagher  ---
Pushed to master - thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15220] typo in circ rules help

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15220

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45040|0   |1
is obsolete||

--- Comment #7 from Brendan Gallagher  ---
Created attachment 46048
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46048=edit
Bug 15220: Fix typo in circ rules help

MaxFinesystem should be MaxFine system

To test:

* visit circ & fine rules
* click help
* confirm typo fixed

Signed-off-by: Thomas Misilo 

Signed-off-by: Katrin Fischer 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15220] typo in circ rules help

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15220

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45208|0   |1
is obsolete||

--- Comment #5 from Brendan Gallagher  ---
Created attachment 46056
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46056=edit
Bug 15217 Remove redundant duplicate var declaration

remove superfluous second declaration of template, borrowernumber and
cookie which are never used

Also removed the variables @results and @results_array which are
declared but not used

Signed-off-by: Frédéric Demians 
  As suggested by Colin, perl -wc catalogue/search.pl doesn't complain
  anymore after applying the patch. perlcritic confirms the 2 variables
  were unused.

Signed-off-by: Katrin Fischer 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #6 from Brendan Gallagher  ---
pushed to master - thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15232] Advanced Cataloging Editor: Fix translation issues

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #9 from Brendan Gallagher  ---
Pushed to master - thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15232] Advanced Cataloging Editor: Fix translation issues

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45143|0   |1
is obsolete||

--- Comment #8 from Brendan Gallagher  ---
Created attachment 46040
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46040=edit
Bug 15232: Advanced Cataloging Editor: Fix translation issues

This patch makes
koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc to comply with
Coding guidlines to avoid translation issues: "JS3: Avoid strings which
mix text and markup Text mustn't contain HTML tags."

To test:
- Apply patch
- Verify that code changes are correct (html markup moved out of
  function _(...) )
- Bonus test: Enable syspref 'EnableAdvancedCatalogingEditor' and verify
  that it works as before

With type fix from: Hector Castro 

Signed-off-by: Frédéric Demians 

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15232] Advanced Cataloging Editor: Fix translation issues

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45443|0   |1
is obsolete||

--- Comment #16 from Brendan Gallagher  ---
Created attachment 46042
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46042=edit
Bug 15233: (followup) Remove 2 sentences.

This patch removes 2 sentences (see comment #8)

Signed-off-by: Hector Castro 

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45442|0   |1
is obsolete||

--- Comment #15 from Brendan Gallagher  ---
Created attachment 46041
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46041=edit
Bug 15233: Cataloging subfield editors: Clean up html and streamline text for
better translatability

This patch removes bold markup from explanatory text in
auth_subfields_structure.tt
and makes it the same as in marc_subfields_structure.tt for better
translatibility.

To test:
- Apply patch
- Verify that string changes make sense and that the explanatory text is the
same in both files.

Signed-off-by: Hector Castro 
Rewording Ok for translation purposes

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15229] Tiny typo: This patrons is ...

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15229

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45158|0   |1
is obsolete||

--- Comment #6 from Brendan Gallagher  ---
Created attachment 46051
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46051=edit
Bug 15229: Same fix for circulation.tt template (normal checkouts)

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15229] Tiny typo: This patrons is ...

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15229

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45157|0   |1
is obsolete||

--- Comment #5 from Brendan Gallagher  ---
Created attachment 46050
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46050=edit
Bug 15229: Fix tiny typos in error messages of batch checkout page

Patch fixes some small spelling errors on the batch checkouts
page. Also switches 'reserves' to 'holds'.

To test:
- Read the patch and verify that the changes are correct.

Signed-off-by: Hector Castro 
Changes are correct, patch fixes capitalization and typo

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15229] Tiny typo: This patrons is ...

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15229

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15229] Tiny typo: This patrons is ...

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15229

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #7 from Brendan Gallagher  ---
pushed to master - thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15332] ModMember not interpreting dates (Batch patron modification)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45980|0   |1
is obsolete||

--- Comment #9 from Brendan Gallagher  ---
Created attachment 46057
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46057=edit
Bug 15332: Sent DateTime object to DBIx::Class, not formatted dates

If formatted dates are sent to DBIx::Class on update/insert, the date
will be set as -00-00 (except if the format is -mm-dd).

Test plan:
Use the batch patron modification tools to update the dateenrolled or
dateexpiry values for at least 1 patron.
Without this patch, the modified value will be updated to -00-00,
with this patch, the correct value will be set.

Signed-off-by: Nick Clemens 
Signed-off-by: Marcel de Rooy 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15332] ModMember not interpreting dates (Batch patron modification)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15332] ModMember not interpreting dates (Batch patron modification)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #10 from Brendan Gallagher  ---
Pushed to master - thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #38362|0   |1
is obsolete||

--- Comment #33 from Brendan Gallagher  ---
Created attachment 46022
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46022=edit
Bug 11084 [QA Followup]

Signed-off-by: Katrin Fischer 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #38363|0   |1
is obsolete||

--- Comment #34 from Brendan Gallagher  ---
Created attachment 46023
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46023=edit
Bug 11084 [QA Followup] - Suppress userenv warning

Signed-off-by: Katrin Fischer 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #38364|0   |1
is obsolete||

--- Comment #35 from Brendan Gallagher  ---
Created attachment 46024
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46024=edit
Bug 11084 [QA Followup] - Document limitations of test mode

Signed-off-by: Katrin Fischer 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #38361|0   |1
is obsolete||

--- Comment #32 from Brendan Gallagher  ---
Created attachment 46021
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46021=edit
Bug 11084 - Delete biblios on Leader 05 == d

Position 05 of the leader in MARC 21 indicates the record's status.
A lower case 'd' indicates that the record is to be deleted
(http://www.loc.gov/marc/authority/adleader.html).

This patch adds a cronjob script that may be run nightly to delete
records where position 05 of the leader is set to 'd'.

Test Plan:
1) Edit one or more records, and set the leader position 05 to 'd'.
2) Run misc/cronjobs/delete_records_via_leader.pl -c -v
3) Those records should either be deleted, or an error message should
   state why they were not.

Signed-off-by: Magnus Enger 

Works as advertised. Edited a record with an item to have leader05 = d,
then ran delete_records_via_leader.pl with -c and got a message that
the record could not be deleted because of the item. Removed the item
and the script deleted the record. Tried with another record with an
item, this time with the -i option and the record was deleted.

Signed-off-by: Katrin Fischer 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
Hi Srdjan, I am a bit worried about translatability - did you check by chance
if the moved strings show up in updated po files?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15361] Translatability: Fix issue on Administration Columns settings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15361

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45684|0   |1
is obsolete||

--- Comment #4 from Brendan Gallagher  ---
Created attachment 46030
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46030=edit
Bug 15361: Translatability: Fix issue on Administration Columns settings

This patch rewords the following sentence that is not correctly translatable
due to
splitting b tags:
Changes made below will only apply to item subfields that are mapped to the
items table.

To test:
- Apply patch
- Verify that the rewording makes sese and that no sentences are split by tags.

Signed-off-by: Hector Castro 
Rewording message displayed Ok for translation purpose

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15361] Translatability: Fix issue on Administration Columns settings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15361

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #5 from Brendan Gallagher  ---
Pushed to master - Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15361] Translatability: Fix issue on Administration Columns settings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15361

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15363] Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #9 from Brendan Gallagher  ---
Pushed to master - thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45092|0   |1
is obsolete||

--- Comment #8 from Brendan Gallagher  ---
Created attachment 46037
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46037=edit
Bug 15301: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence

The file intranet-tmpl/prog/en/modules/circ/branchtransfers.tt contains two
ambiguous words 'to' and a sentence splitted up by html tags, leading to weird
translations. Example in German: "Sie können keine Exemplare aus itemtype
transferieren BK für: Airfield"

To test:
- Apply patch

- Set up transfer policies for item types and collection codes in
  Home > Administration > Set library checkin and transfer policy
  Make sure that you have rules that deny and others that allow transfers

- Verify that syspref 'UseBranchTransferLimits' is set to 'Enforce'

- Set 'BranchTransferLimitTypes' to 'item type'

- Go to Home > Circulation > Transfers
- Transfer an item that is allowed for item type
  - Verify that the table of transferred items displays information
about Item type, Collection code and Destination

- Transfer an item that is not allowed for the item type
  - Verify that the information about not allowing the transfer displays
properly and is meaningfull

- Set 'BranchTransferLimitTypes' to 'collection code'

- Repeat the transfer steps above for allowed / not allowed collection code

(Amended to add ids to table and 8 columns, see comment #2)
(Amended for comment #5)
Followup for comment #8

Signed-off-by: Frédéric Demians 

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45346|0   |1
is obsolete||

--- Comment #9 from Brendan Gallagher  ---
Created attachment 46038
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46038=edit
Bug 15231 - Import patrons: Remove string splitting by html tags to avoid weird
translations

Some of the strings in Home > Tools > Import patrons contain html tags and
therefore are
splitted in the translation tool. This makes it nearly impossible to create
correct translations
from the partial strings.
Additinally, the notes for Extended patron attributes never displayed (due to a
bug).

To test:
- Apply patch
- Enable Syspref 'ExtendedPAtronAttributes'
- Go to Home > Tools > Import patrons and verify, that the Notes at the right
of the
  screen make sense

Signed-off-by: Hector Castro 
Split html tags removed, notes at right side it displayed correctly

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231

--- Comment #10 from Brendan Gallagher  ---
Created attachment 46039
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46039=edit
Bug 15231: (followup) Remove stray  tag

This patch removes a stray  tag (see comment #4) and a superfluous blank.

Signed-off-by: Hector Castro 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587

--- Comment #26 from Katrin Fischer  ---
Hi, we have a new feature now that will allow to add new fields to
subscriptions - I wonder if this development is still needed or could be
covered by the new feature. I just tested it by defining a new field 'serial
lifespan'. It shows on the subscription details and on the edit form.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15237] Quote of the day: Better translatibility for editor and help

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15237

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15101] Don't display system preference AllowPkiAuth under heading CAS Authentication

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15101

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45165|0   |1
is obsolete||

--- Comment #7 from Brendan Gallagher  ---
Created attachment 46053
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46053=edit
Bug 15101: Correct typo AllowPkiAuth vs AllowPKIAuth

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15101] Don't display system preference AllowPkiAuth under heading CAS Authentication

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15101

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45164|0   |1
is obsolete||

--- Comment #6 from Brendan Gallagher  ---
Created attachment 46052
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46052=edit
Bug 15101: Don't display sys pref AllowPkiAuth under CAS heading

The system preference AllowPkiAuth display under the heading
CAS authentication, but is actually a separate authentication
option. Patch creates a separate heading for it.

To test:
- Go to Administration > System preferences > Tab Administration
- Verify that AllowPkiAuth is now displayed separately

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #3 from Srdjan Jankovic  ---
Right, I can see a problem with separating "phrase". Will rework.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15236] Better translatibility in "Connect biblio.biblionumber to a MARC subfield"

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15236

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15411] "Non fiction" is incorrect

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411

M. Tompsett  changed:

   What|Removed |Added

   Severity|enhancement |trivial
   Patch complexity|--- |String patch
   Assignee|gmcha...@gmail.com  |aleishaamo...@hotmail.com
 CC||mtomp...@hotmail.com

--- Comment #2 from M. Tompsett  ---
This is a simple patch, not an enhancement. Changed report settings
accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15236] Better translatibility in "Connect biblio.biblionumber to a MARC subfield"

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15236

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #6 from Brendan Gallagher  ---
Pushed to master - Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15236] Better translatibility in "Connect biblio.biblionumber to a MARC subfield"

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15236

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45159|0   |1
is obsolete||

--- Comment #5 from Brendan Gallagher  ---
Created attachment 46043
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46043=edit
Bug 15236: Better translatibility in "Connect biblio.biblionumber to a MARC
subfield"

This patch moves html markup out of explanatory sentence in koha2marclinks.tt
("Connect
biblio.biblionumber to a MARC subfield") for better translatability.

To test:

- Apply patch
- Go to Home > Administration < Koha to MARC mapping
  and edit a tag
- Verify that text change makes sense

Signed-off-by: Hector Castro 
Rewording Ok for translation purposes

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15373] Zip should be ZIP

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373

M. Tompsett  changed:

   What|Removed |Added

   Severity|enhancement |minor
   Assignee|oleon...@myacpl.org |aleishaamo...@hotmail.com
 CC||mtomp...@hotmail.com
   Patch complexity|--- |String patch

--- Comment #7 from M. Tompsett  ---
This is not an enhancement. It is annoying that enhancement is the default, and
we sometimes forget to check for it. This is a string correction. Simple enough
to check.

I have confirmed that all instances seem to be dealt with. Now to follow test
plan.

Aleisha, if you are submitting the patch, please remember to take the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15101] Don't display system preference AllowPkiAuth under heading CAS Authentication

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15101

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #8 from Brendan Gallagher  ---
Pushed to master - Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15101] Don't display system preference AllowPkiAuth under heading CAS Authentication

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15101

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15228] Patron card batches - Improve translatability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45166|0   |1
is obsolete||

--- Comment #7 from Brendan Gallagher  ---
Created attachment 46054
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46054=edit
Bug 15228: Patron card batches - Improve translatability

This patch removes the \n\n from a translatable string
as those don't translate correctly to new lines.

It also switches 'item' for 'patron' to avoid confusion
with catalog items.

To test:
1) Trigger changed error message
- Create a new batch with 1 patron entry
- Select patron in list using the checkbox
- Click 'Remove selected patrons' in toolbar
- Verify alert displays correctly

2) Verify that the page no longer uses "items" but
   patrons instead.

Signed-off-by: Hector Castro 
Works as advertised

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15228] Patron card batches - Improve translatability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #9 from Brendan Gallagher  ---
Pushed to Master - Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15228] Patron card batches - Improve translatability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45167|0   |1
is obsolete||

--- Comment #8 from Brendan Gallagher  ---
Created attachment 46055
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46055=edit
Bug 15228: Switch "Items in batch number"

Yet another line to switch "Items in batch number" to
"Patrons in batch number"

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15228] Patron card batches - Improve translatability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288

--- Comment #26 from Aleisha Amohia  ---
(In reply to Héctor Eduardo Castro Avalos from comment #25)
> Hi Marc you can use the paragraphs from bug 14573, like Aleisha proposes.
> What do you think about it, Marcel and Aleisha?
> 
> Regards

I think it is a good idea to use the messages from Bug 14573 because then they
will be consistent with the Intranet error messages (see Bug 14574)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14480] Warns when modifying patron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #45796|0   |1
is obsolete||

--- Comment #10 from Aleisha Amohia  ---
Created attachment 46025
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46025=edit
Bug 14480: Silences warn from editing patron

To test:
1) Go to any patron (ie this link
http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=1369)
2) Click Edit
3) Notice the warn appears
4) Apply patch and reload page
5) Notice warns are gone but page still works correctly
6) Add restriction and save, then go back to Edit
7) Confirm restriction shows as it should
8) Remove restriction and save, then go back to Edit
9) Confirm it says "Patron is currently unrestricted".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15346] Translatability: fix sentence splitting issue in memberentrygen.tt

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15346

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45562|0   |1
is obsolete||

--- Comment #4 from Brendan Gallagher  ---
Created attachment 46029
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46029=edit
Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt

Fix sentences in memberentrygen.tt that are split by  tags, leading to
wrong capitalization in German (because it can not be decided if a string is
part
of a sentence or a standalone sentence).
Example: Es sind Keine Bibliotheken definiert.

To test:
- Apply patch
- To trigger the messages, you have to edit a patron in a system where
  no libraries and no patron categories are defined
- Alternatively, carefully review the changes in
  koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt

Signed-off-by: Hector Castro 
Sentences fixed for translation purposes

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15346] Translatability: fix sentence splitting issue in memberentrygen.tt

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15346

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15366] Fix breadcrumbs and html page title in guided reports

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15366

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45803|0   |1
is obsolete||

--- Comment #4 from Brendan Gallagher  ---
Created attachment 46034
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46034=edit
Bug 15366 - Fix breadcrumbs and html page title in guided reports

This patch fixes following issues with breadcrumbs and html page title
in Home > Reports > Guided reports wizard:

- Sometimes, breadcrumbs display a stray > at the end

- While creating a report, steps are not displayed in breadcrumbs and
  do not appear in html page title
- html page title is divided by newlines

To test:
- Apply patch
- Go to Home > Reports > Guided reports wizard
- Go to all pages including the steps for creating a new report and
  verify
  - that the breadcrumbs display properly and make sense
  - in html source, the page title makes sense and displays on one line.

Signed-off-by: Hector Castro 
Works as descrived

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15366] Fix breadcrumbs and html page title in guided reports

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15366

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15366] Fix breadcrumbs and html page title in guided reports

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15366

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #5 from Brendan Gallagher  ---
Pushed to master - Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #15 from Brendan Gallagher  ---
Pushed to master - thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45516|0   |1
is obsolete||

--- Comment #14 from Brendan Gallagher  ---
Created attachment 46036
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46036=edit
Bug 15301: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence

The file intranet-tmpl/prog/en/modules/circ/branchtransfers.tt contains two
ambiguous words 'to' and a sentence splitted up by html tags, leading to weird
translations. Example in German: "Sie können keine Exemplare aus itemtype
transferieren BK für: Airfield"

To test:
- Apply patch

- Set up transfer policies for item types and collection codes in
  Home > Administration > Set library checkin and transfer policy
  Make sure that you have rules that deny and others that allow transfers

- Verify that syspref 'UseBranchTransferLimits' is set to 'Enforce'

- Set 'BranchTransferLimitTypes' to 'item type'

- Go to Home > Circulation > Transfers
- Transfer an item that is allowed for item type
  - Verify that the table of transferred items displays information
about Item type, Collection code and Destination

- Transfer an item that is not allowed for the item type
  - Verify that the information about not allowing the transfer displays
properly and is meaningfull

- Set 'BranchTransferLimitTypes' to 'collection code'

- Repeat the transfer steps above for allowed / not allowed collection code

(Amended to add ids to table and 8 columns, see comment #2)
(Amended for comment #5)
Followup for comment #8

Signed-off-by: Frédéric Demians 

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15433] Self checkout software error on checkout

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15433

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15429
Version|unspecified |master

--- Comment #1 from Katrin Fischer  ---
Hi Derryn, this sounds somewhat similar to a behaviour in batch checkout that
is resolved by bug 15429 - could you check if this also fixes your problem?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15429] sub _parseletter should not change referenced values

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15429

Katrin Fischer  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15433

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231

--- Comment #11 from Brendan Gallagher  ---
Pushed to Master - thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15346] Translatability: fix sentence splitting issue in memberentrygen.tt

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15346

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #5 from Brendan Gallagher  ---
Pushed to Master - Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15300] Translatability: Replace ambiguous 'From' and 'To' in members-update.tt

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15300

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45436|0   |1
is obsolete||

--- Comment #4 from Brendan Gallagher  ---
Created attachment 46035
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46035=edit
Bug 15300: Translatability: Replace ambiguous 'From' and 'To' in
members-update.tt

This patch replaces semantically ambigous words "From" and "To" in
koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt
for better translatability.

To test:
- Apply patch
- Make sure that patrons can request detail changes in OPAC
  (sysprefs opacuserlogin, OPACPatronDetails)
- Log in to OPAC, request a change of personal details
  (cgi-bin/koha/opac-memberentry.pl)
- Log in to staff client
- Click link 'Patrons requesting modifications' or go to
  Home > Patrons > Update patron records
- Verify that table headers make sense

Signed-off-by: Hector Castro 
Rewording Ok for translation purpose

Signed-off-by: Katrin Fischer 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15300] Translatability: Replace ambiguous 'From' and 'To' in members-update.tt

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15300

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #5 from Brendan Gallagher  ---
Pushed to master - Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15300] Translatability: Replace ambiguous 'From' and 'To' in members-update.tt

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15300

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457

--- Comment #15 from David Cook  ---
Comment on attachment 45967
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45967
Bug 14457: Integrate LIBRIS spellchecking

Review of attachment 45967:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14457=45967)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref
@@ +222,5 @@
>no: "don't search"
>  - on all variations of the ISBN. Note that this preference has 
> no effect if UseQueryParser is on.
> +API Keys:
> +-
> +- LIBRIS Spellcheking API key

There is a typo here, but perhaps QA can fix it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
  Attachment #45441|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #46037|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14480] Warns when modifying patron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

--- Comment #36 from Brendan Gallagher  ---
Pushed to master - Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #43294|0   |1
is obsolete||

--- Comment #9 from Brendan Gallagher  ---
Created attachment 46026
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46026=edit
Bug 14515: Add biblioitems to messages in C4/Reserves.pm

http://bugs.koha-community.org/show_bug.cgi?id=14515

Signed-off-by: Danielle Aloia 

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #43295|0   |1
is obsolete||

--- Comment #10 from Brendan Gallagher  ---
Created attachment 46027
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46027=edit
Bug 14515 (QA Followup) fix letter.pl available fields.

Add bibliotiems to the 'available fields' list for
module 'Holds' (aka reserves).

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #11 from Brendan Gallagher  ---
Pushed to Master - Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15440] New: Warns in Members/Messaging.pm

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15440

Bug ID: 15440
   Summary: Warns in Members/Messaging.pm
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

To reproduce, go to any patron page (ie
/cgi-bin/koha/members/moremember.pl?borrowernumber=19)

moremember.pl: Use of uninitialized value in concatenation (.) or string at
/home/vagrant/kohaclone/C4/Members/Messaging.pm line 216.
moremember.pl: Use of uninitialized value in concatenation (.) or string at
/home/vagrant/kohaclone/C4/Members/Messaging.pm line 216.
moremember.pl: Use of uninitialized value in concatenation (.) or string at
/home/vagrant/kohaclone/C4/Members/Messaging.pm line 216.
moremember.pl: Use of uninitialized value in concatenation (.) or string at
/home/vagrant/kohaclone/C4/Members/Messaging.pm line 216.
moremember.pl: Use of uninitialized value in concatenation (.) or string at
/home/vagrant/kohaclone/C4/Members/Messaging.pm line 216.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15345] Translatability: fix issue in facets (Availability')

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15345

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45624|0   |1
is obsolete||

--- Comment #4 from Brendan Gallagher  ---
Created attachment 46028
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46028=edit
Bug 15345: Translatability: fix issue in facets (Availability')

This patch fixes an issue with a splitted sentence in facets (Avalability)
that leads to weird translations e.g.:
German: 'Zeige nur Verfügbar Exemplare'
French: 'Montrer seulement disponible exemplaires'

Additionally, the link "Show all items" gets it's own li tags to display
nicely like the other links in the facets column and it removes superfluous
dots.

To test in OPAC and Staff client:
- Apply patch
- Do a search that results in more than one available items
- In column "Refine your search", click on "Limit to currently available
  items"
- Verify that the message "Showing only available items" and the link
  "Show all items" display nicely.

Signed-off-by: Hector Castro 
use_zebra_facets set to 0 in koha-conf.xml to test. Works as described

Signed-off-by: Katrin Fischer 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15362] Translatability: Fix issue on Administration 'Did you mean?'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15362

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45804|0   |1
is obsolete||

--- Comment #4 from Brendan Gallagher  ---
Created attachment 46031
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46031=edit
Bug 15362: Translatability: Fix issue on Administration 'Did you mean?'

Fix sentence splitting by tags on didyoumean.tt leading to odd translations.

To test:
- Apply patch
- Go to Home > Administration > Did you mean?
- Verify that the information below the title displays properly and makes
sense.
- Disable Javascript, reload page
- Verify that the warning about missing Javascript displays properly and makes
sense.

Signed-off-by: Hector Castro 
Works as descrived. Removed em tags for translation purpose

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15362] Translatability: Fix issue on Administration 'Did you mean?'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15362

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/