date:20151230

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #6 from Srdjan Jankovic  ---
Template translations are a monster. Tried to add support for translations in
assignments/function calls within [% %] tags, but gave up when the pain became
unbearable.
Chickened out and used javascript, _() is clean and easy. The only thing that I
don't like is the fact that I had to put all strings in opac-bottom.inc. Please
comment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #46017|0   |1
is obsolete||

--- Comment #5 from Srdjan Jankovic  ---
Created attachment 46103
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46103=edit
Bug 15434: Search criteria definition table

Collected search criteria and limit labels in opac-bottom.inc, so it
can be used for both making search criteria selects and displaying back
selections on the result screen.

*-opac-bootstrap.po translation files need to be changed:
* references to opac-advanced-search.tt need to be updated to
  opac-bottom.inc
* messages and translations need -s removed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15363] Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #10 from Julian Maurice  ---
Patch pushed in 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15365] Translatability: Fix issue on Administration > Circulation and fine rules

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15365

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #8 from Julian Maurice  ---
Patch pushed in 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15232] Advanced Cataloging Editor: Fix translation issues

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||julian.maur...@biblibre.com

--- Comment #10 from Julian Maurice  ---
Patch pushed in 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||julian.maur...@biblibre.com

--- Comment #12 from Julian Maurice  ---
Patch pushed in 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11569] Typo in userpermissions.sql

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11569

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #4 from Kyle M Hall  ---
Pushed to master, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13967] Add package for System preferences

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15446


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446
[Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict
with column name
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15446] New: Koha::Object[s]->type should be renamed to _type to avoid conflict with column name

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446

Bug ID: 15446
   Summary: Koha::Object[s]->type should be renamed to _type to
avoid conflict with column name
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: major
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 13967

In a few case (at least systempreferences and export_format (csv profiles), the
type method of Koha::Object and Koha::Objects can be in conflict with the
column names.
Indeed systempreferences.type exists and so the method will return
'Systempreference' (the name of the module) instead of the value of the row in
DB.

I have found at least 1 place where it can cause issue:
In C4::Context->set_preference:
 601 my $syspref = Koha::Config::SysPrefs->find( $var );
 602 my $type = $syspref ? $syspref->type() : undef;
 603 
 604 $value = 0 if ( $type && $type eq 'YesNo' && $value eq '' );

type will always be 'Systempreference' and the YesNo pref will be set to an
empty string '' instead of 0.


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967
[Bug 13967] Add package for System preferences
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15409] Plugins section missing from Admin menu sidebar

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15409

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Brendan Gallagher  ---
Pushed to master - Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15345] Translatability: fix issue in facets (Availability')

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15345

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #6 from Julian Maurice  ---
Patch pushed in 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15300] Translatability: Replace ambiguous 'From' and 'To' in members-update.tt

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15300

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||julian.maur...@biblibre.com

--- Comment #6 from Julian Maurice  ---
Patch pushed in 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752

Nick Clemens  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752

--- Comment #1 from Nick Clemens  ---
Created attachment 46093
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46093=edit
Bug 14752 - Add multiple copies to a basket at once

This patch add an 'Add multiple copies' button on the new order page in
acquisitions.  While processing the multiple copies a modal is
displayed.

To test:
1 - Add an order to an acquisitions basket
2 - Choose to add multiple items
3 - A modal shouold warn about ignoring UniqueItemFields from syspref
4 - When submitting the modal should popup until all items are processed.
5 - The modal should disappear after items are added.
6 - Items should be cloned, minus unique fields

Sponsored by: Middletown Township Public Library (http://www.mtpl.org)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9819] stopwords related code should be removed

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #35 from Kyle M Hall  ---
Pushed to master, thanks Tomas and Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15237] Quote of the day: Better translatibility for editor and help

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15237

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||julian.maur...@biblibre.com

--- Comment #8 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15432] t/db_dependent/Letters.t depends on external data/configuration

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15432

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master, thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446

--- Comment #3 from Jonathan Druart  
---
Created attachment 46097
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46097=edit
Bug 15446: Update systempreferences rows where type=YesNo and value=''

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446

--- Comment #1 from Jonathan Druart  
---
Created attachment 46095
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46095=edit
Bug 15446: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446

--- Comment #2 from Jonathan Druart  
---
Created attachment 46096
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46096=edit
Bug 15446: Rename Koha::Object[s]->type with _type

In a few case (at least systempreferences and export_format (csv profiles),
the type method of Koha::Object and Koha::Objects can be in conflict with the
column names.
Indeed systempreferences.type exists and so the method will return
'Systempreference' (the name of the module) instead of the value of the row in
DB.

I have found at least 1 place where it can cause issue:
In C4::Context->set_preference:
 601 my $syspref = Koha::Config::SysPrefs->find( $var );
 602 my $type = $syspref ? $syspref->type() : undef;
 603
 604 $value = 0 if ( $type && $type eq 'YesNo' && $value eq '' );

type will always be 'Systempreference' and the YesNo pref will be set to an
empty string '' instead of 0.

I am not sure about the consequences of this, but it is preferable to
fix it ASAP.

To reproduce:
0/ Do not apply this patch
1/ Edit a YesNo prefs, AutoEmailOpacUser for instance
2/ Set it to "Don't sent"
3/ Check the value in DB, it should be set to an empty string, instead
of 0
4/ Apply this patch and try again. Now the value should be 0

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 813] OPAC lists should store comments

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=813

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15391] Some tests in HoldsQueue.t should not pass

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391

--- Comment #2 from Kyle M Hall  ---
FYI, this is still on my radar, I just haven't gotten to it yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected"

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748

Bouzid  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
 CC||bouzid.ferg...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected"

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748

--- Comment #12 from Bouzid  ---
Created attachment 46091
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46091=edit
Bug 12748 - Add test for step 7 and 8 and rename findSerialByStatus

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected"

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748

Bouzid  changed:

   What|Removed |Added

   Assignee|remi.mayrand-provencher@inL |bouzid.ferg...@inlibro.com
   |ibro.com|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13385] RDA: 508 display in XSLT

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13385

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||15444


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444
[Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15346] Translatability: fix sentence splitting issue in memberentrygen.tt

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15346

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #6 from Julian Maurice  ---
Patch pushed in 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator)

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||13385


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13385
[Bug 13385] RDA: 508 display in XSLT
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15366] Fix breadcrumbs and html page title in guided reports

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15366

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #6 from Julian Maurice  ---
Patch pushed in 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022

--- Comment #26 from Kyle M Hall  ---
> I would like to see a comment from Tomas before these patches are pushed.

I should have noted Tomas gave his blessing to have this pushed to master in a
pm. I think we can all agree that the best long term solution is to index these
values instead of calculating them for each search, but this is at least a
decent stop-gap measure until such changes can be made.

I will ask Tomas to confirm our conversation here before pushing this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15220] typo in circ rules help

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15220

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||julian.maur...@biblibre.com

--- Comment #9 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15238] Better translatability for Installer Step 1

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15238

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||julian.maur...@biblibre.com

--- Comment #10 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15373] Zip should be ZIP

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #12 from Kyle M Hall  ---
Pushed to master, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15361] Translatability: Fix issue on Administration Columns settings

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15361

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #6 from Julian Maurice  ---
Patch pushed in 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15362] Translatability: Fix issue on Administration 'Did you mean?'

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15362

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Pushed to Master|Pushed to Stable
   Severity|enhancement |trivial

--- Comment #6 from Julian Maurice  ---
Patch pushed in 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15101] Don't display system preference AllowPkiAuth under heading CAS Authentication

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15101

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||julian.maur...@biblibre.com

--- Comment #9 from Julian Maurice  ---
Patches pushed to 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15446


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446
[Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict
with column name
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||13019


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019
[Bug 13019] Add base classes on which to build Koha objects
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15382] 245$a visibility constraints not respected in opac-MARCdetail.pl

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15382

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #6 from Kyle M Hall  ---
Pushed to master, thanks Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752

Nick Clemens  changed:

   What|Removed |Added

   Assignee|jwea...@bywatersolutions.co |n...@bywatersolutions.com
   |m   |
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15224] Typo: Leave empty to add via item search (itemnunber).

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15224

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #7 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15229] Tiny typo: This patrons is ...

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15229

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||julian.maur...@biblibre.com

--- Comment #8 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15099] Fix file name: categorie.pl should be either category.pl or categories.pl

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099

--- Comment #10 from Kyle M Hall  ---
Created attachment 46094
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46094=edit
Bug 15099 [QA Followup] - Make bug pass koha-qa.pl

Cleaned up additional tab characters and such well. This is a very
good time to take care of these.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

--- Comment #51 from Eric Bégin  ---
Howdy !

> There is no need to ask for a signoff, it will fail QA.
The latest commit by Bouzid fixed the problem from accessing the page when
disabled (BTW, I asked him to change the code to have a single IF / ELSE
statement in the .tt and change the pref name for
EnhancedMessagingPreferencesOPAC which he will commit soon).

Concerning bug 9254, it basically add another option to the
EnhancedMessagingPreferencesOPAC, so, from my understanding it's not quite a
duplicate, but an enhancement of this one, as Francois pointed out.

@Jonathan : Just want to check with you that this bug will move forward if we
fix the behaviour when accessing the URL and changing the pref name.

Cheers !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15447] New: log4perl.conf does not have __LOG_DIR__ replaced when installing

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15447

Bug ID: 15447
   Summary: log4perl.conf does not have __LOG_DIR__ replaced when
installing
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: blocker
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Since the introduction of Koha::Logger, it appears that the log4perl.conf
config file has been broken. The references to __LOG_DIR__ is not being
replaced.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15447] log4perl.conf does not have __LOG_DIR__ replaced when installing

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15447

Kyle M Hall  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15448] New: Suppressed items show in OPAC when patron places a hold on a specific item

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448

Bug ID: 15448
   Summary: Suppressed items show in OPAC when patron places a
hold on a specific item
 Change sponsored?: ---
   Product: Koha
   Version: 3.18
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: jza...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 46100
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46100=edit
Suppressed items shown

When a patron places a hold on a specific item in the copiesrow table,
suppressed items show in the OPAC.

System preference for OPACSuppression is set to Hide. System preference for
OPAC Hidden Items is set to hide is suppressed items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1"

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #7 from Nick Clemens  ---
Internal sign-off - still needs community sign-off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1"

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277

Nick Clemens  changed:

   What|Removed |Added

  Attachment #45783|0   |1
is obsolete||

--- Comment #6 from Nick Clemens  ---
Created attachment 46098
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46098=edit
Bug 14277 add zebra indexes for lexile that respect 521 indicator 1.

Added the following indexes:

Interest-age-level | 591$a ind1=1
Interest-grade-level | 591$a ind1=2
lexile-number | 591$a ind1=8
Reading-grade-level | 591$a ind1=0

Moved 'lex' from a zebra index to a ccl alias to lexile-number.

Changed the handling of st-numeric in C4/Search.pm to allow for search ranges.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15447] log4perl.conf does not have __LOG_DIR__ replaced when installing

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15447

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15396] MARC21 Leader plugin label '1-4 Record size' is wrong

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15396

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #5 from Brendan Gallagher  ---
Pushed to Master - Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
  Attachment #45945|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15447] log4perl.conf does not have __LOG_DIR__ replaced when installing

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15447

--- Comment #1 from Kyle M Hall  ---
Created attachment 46099
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46099=edit
Bug 15447 - log4perl.conf does not have __LOG_DIR__ replaced when installing

Since the introduction of Koha::Logger, it appears that the
log4perl.conf config file has been broken. The references to __LOG_DIR__
is not being replaced.

Test Plan:
1) Apply this patch
2) Run 'perl Makefile.PL'
3) Run 'make'
4) Open blib/KOHA_CONF_DIR/log4perl.conf with a text editor
5) Note the log file paths are correctly set, and do not have
   __LOG_DIR__ in them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15340] Translatability: fix issue with 'or choose' splitted by

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15340

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Brendan Gallagher  ---
Pushed to Master - Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14853] Change "Fund" to "Shipping fund" where appropriate

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14853

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #7 from Brendan Gallagher  ---
Pushed to Master - Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15383] Opac: Autority details: Fix translation issues with a tags

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15383

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #4 from Brendan Gallagher  ---
Marc how do you feel about "Number of records used in:" instead of Usage in
records: ?

-Brendan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #28 from Bouzid  ---
Created attachment 46101
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46101=edit
Bug 11879 - Update BDIx schema and show main contact method in moremember.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Jesse Weaver  changed:

   What|Removed |Added

 CC||jwea...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #285 from Jesse Weaver  ---
(Assuming we still set the status for this bug. Feel free to correct if I'm
wrong.)

Pushed to master, thanks for your contribution!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #45832|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15258] Prevent unused declared variables

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15258

Jesse Weaver  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||jwea...@bywatersolutions.co
   ||m

--- Comment #12 from Jesse Weaver  ---
Pushed to master. Thanks for your contribution!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15383] Opac: Autority details: Fix translation issues with a tags

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15383

--- Comment #5 from Marc Véron  ---
(In reply to Brendan Gallagher from comment #4)
> Marc how do you feel about "Number of records used in:" instead of Usage in
> records: ?
> 
> -Brendan

Hi Brendan, that would be fine for me. 
The most important thing is that we do not have splitted sentences :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Christopher Brannon  changed:

   What|Removed |Added

 CC|cbran...@cdalibrary.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10988] Allow login via Google OAuth2

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

--- Comment #58 from David Cook  ---
Comment on attachment 46016
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46016
Bug 10988 - Allow for Google OAuth2 logins Combined all of the patches above
into one, making them apply to master again.

Review of attachment 46016:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=10988=46016)
-

I hadn't realized that this was OpenID Connect until Martin pointed it out and
until I saw the "openid" value in the scope of the Authorization Request. 

I actually wrote an OpenID Connect feature for Koha for a client in 2014, but
due to a lack of time and an incorrectly implemented third party OpenID Connect
server, I never got around to upstreaming it to the community codebase. Perhaps
I should try and remedy that one day. In any case, I've included some comments
in the code review below based on my experience.

Nicholas, what documentation did you use for this patch? When I look at
https://developers.google.com/identity/protocols/OpenIDConnect, it specifies
different endpoints than you've used here. I'd recommend consulting that
webpage and http://openid.net/specs/openid-connect-core-1_0.html. The latter is
what I used for making an OpenID Connect compliant server app.

::: opac/svc/auth/googleoauth2
@@ +53,5 @@
> +# protocol is assumed in OPACBaseURL see bug 5010.
> +my $redirecturl  = $host . '/cgi-bin/koha/svc/auth/googleoauth2';
> +my $issuer   = 'accounts.google.com';
> +my $clientid = C4::Context->preference('GoogleOAuth2ClientID');
> +my $clientsecret = C4::Context->preference('GoogleOAuth2ClientSecret');

Alternatively, you could put the ClientID and the ClientSecret in
koha-conf.xml. While it would give less control to libraries, it would keep
this information on a more "need to know" basis.

@@ +86,5 @@
> +elsif ( defined $query->param('code') ) {
> +my $code= $query->param('code');
> +my $ua  = LWP::UserAgent->new();
> +my $request = POST(
> +'https://accounts.google.com/o/oauth2/token',

How did you choose this endpoint? Both
https://developers.google.com/identity/protocols/OpenIDConnect?hl=en#discovery
and https://accounts.google.com/.well-known/openid-configuration provide
versioned endpoints.

@@ +99,5 @@
> +);
> +my $response = $ua->request($request)->decoded_content;
> +my $json = decode_json($response);
> +if ( exists( $json->{'id_token'} ) ) {
> +$request = POST( 'https://www.googleapis.com/oauth2/v1/tokeninfo',

tokeninfo isn't a standard OpenID Connect endpoint. It's a debugging tool that
Google has available, but they discourage its use in production:
https://developers.google.com/identity/protocols/OpenIDConnect?hl=en#validatinganidtoken

Use of tokeninfo also makes it harder for the rest of us to read the code since
a decrypted token has a standard layout, but I haven't found what a tokeninfo
response contains.

@@ +105,5 @@
> +$response = $ua->request($request)->decoded_content;
> +$json = decode_json($response);
> +
> +# Confirm (as google suggests) that the issuer and audience are what we 
> expect them to be
> +if (   ( $json->{'issuer'} eq $issuer )

As noted above, a standard response should be $json->{'iss'}, but otherwise
this is good as per #2 at
http://openid.net/specs/openid-connect-core-1_0.html#IDTokenValidation.

@@ +106,5 @@
> +$json = decode_json($response);
> +
> +# Confirm (as google suggests) that the issuer and audience are what we 
> expect them to be
> +if (   ( $json->{'issuer'} eq $issuer )
> +&& ( $json->{'audience'} eq $clientid )

As noted in #3 at
http://openid.net/specs/openid-connect-core-1_0.html#IDTokenValidation,
$json->{'aud'} (the standard claim), "may" be an array. I'm not familiar with
Google's responses... it might always return a string, but the spec points out
that you should check for either a string or an array (and to reject the token
if it doesn't contain the expected audience or if it includes untrusted
audiences).

@@ +107,5 @@
> +
> +# Confirm (as google suggests) that the issuer and audience are what we 
> expect them to be
> +if (   ( $json->{'issuer'} eq $issuer )
> +&& ( $json->{'audience'} eq $clientid )
> +&& exists( $json->{'email'} ) )

This is bizarre... the token shouldn't contain the email. That must be for
debugging purposes in tokeninfo. You should have to get it from
https://www.googleapis.com/oauth2/v3/userinfo or a similar endpoint, which also
need its "sub" claim to be validated.

@@ +108,5 @@
> +# Confirm (as google suggests) that the issuer and audience are what we 
> expect them to be
> +if (   ( $json->{'issuer'} eq $issuer )
> +&& ( $json->{'audience'} eq $clientid )
> +&& exists( $json->{'email'} ) )
>

[Koha-bugs] [Bug 10468] Add pending holds to summary print

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468

Jesse Weaver  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||jwea...@bywatersolutions.co
   ||m

--- Comment #8 from Jesse Weaver  ---
Pushed to master. Fixed a bit of inconsistent indentation, please take note for
the future.

Thanks for your contribution!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629

--- Comment #1 from Nick Clemens  ---
Created attachment 46102
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46102=edit
Bug 14629 - Add aggressive ISSN matching feature equivalent to the aggressive
ISBN matcher

This patch adds a syspref "AggressiveMatchOnISSN" allowing for a match
of ISSNs with or without hyphens. It uses Business::ISSN in order to
follow the use of Business::ISBN and allow for validation of ISSNs

To test:
1 - Find a record in your system with an ISSN (or add one)
2 - Stage a record containing the same ISSN but lacking a hyphen
3 - Matching on ISSN should find 0 matches
4 - Repeat with no hyphen ISSN in system and hyphen ISSN in import
5 - Matching should find 0
6 - Apply patch
7 - Update datbase and install Business::ISSN
8 - Leave AggressiveMatchOnISSN as don't and repeat original tests- no
change
9 - Set AggressiveMatchOnISSN as do and repeat original test
10 - You should find a match
11 - prove t/Koha.t - all tests pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629

Nick Clemens  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |n...@bywatersolutions.com
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629

Nick Clemens  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12544] Send scheduled reports as an attachment

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12544

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #8 from Brendan Gallagher  ---
Pushed to master - thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15080] ./translate-tool should tell if xgettext-executable is missing

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15080

Jesse Weaver  changed:

   What|Removed |Added

 CC||jwea...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Jesse Weaver  ---
Pushed to master. Thanks for your contribution!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #30 from Brendan Gallagher  ---
pushed to master - thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517

Jesse Weaver  changed:

   What|Removed |Added

 CC||jwea...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #33 from Jesse Weaver  ---
Pushed to master. Thanks for your contribution!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #16 from Brendan Gallagher  ---
Pushed to master - Knuckles

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15099] Fix file name: categorie.pl should be either category.pl or categories.pl

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #45627|0   |1
is obsolete||

--- Comment #9 from Jonathan Druart  
---
Created attachment 46090
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46090=edit
Bug 15099: Move admin/categorie.pl to admin/categories.pl

This patch fixes the filename categorie.pl correcting it by categories.pl
The plurial is usually used for script names in the admin module.

Test plan:
Navigate to the patron categories page.

Signed-off-by: Frédéric Demians 
  No reference to categorie.pl anywhere in the code

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9819] stopwords related code should be removed

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819

--- Comment #34 from Kyle M Hall  ---
Created attachment 46092
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46092=edit
Bug 9819 [QA Followup] - Removed missed stopwords refs, remove Schema file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14638] Update serials help files

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14638

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #8 from Julian Maurice  ---
Patch pushed in 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15236] Better translatibility in "Connect biblio.biblionumber to a MARC subfield"

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15236

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||julian.maur...@biblibre.com

--- Comment #7 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
   Severity|enhancement |trivial
 Status|Pushed to Master|Pushed to Stable

--- Comment #18 from Julian Maurice  ---
Patches pushed to 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15099] Fix file name: categorie.pl should be either category.pl or categories.pl

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #11 from Kyle M Hall  ---
Pushed to master, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13136] No documentation for Home > Tools > Labels home > Manage label Layouts

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13136

Jesse Weaver  changed:

   What|Removed |Added

 CC||jwea...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #12 from Jesse Weaver  ---
Pushed to master. Thanks for your contribution!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12289] stage_file.pl does not allow control of nomatch options

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12289

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #10 from Brendan Gallagher  ---
pushed to master - thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #7 from Marc Véron  ---
Hi Srdjan, I like this feature.

One question:
If I search for "test" I get as breadcrumb:
Results of search for 'Keyword: test'
(As expected)

Then I click on: Did you mean: Search also for broader subjects
The breadcrumb is now:
Results of search for 'Keyword: su-br=test'

Similar for related / narrower subjects

Is that intended? I see su-br, su-na, su-rl in the JavaScript, though.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15429] sub _parseletter should not change referenced values

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15429

Katrin Fischer  changed:

   What|Removed |Added

 CC||derr...@gmail.com

--- Comment #5 from Katrin Fischer  ---
*** Bug 15433 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15433] Self checkout software error on checkout

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15433

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #3 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 15429 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10988] Allow login via Google OAuth2

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10988] Allow login via Google OAuth2

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

--- Comment #57 from Martin Renvoize  ---
Comment on attachment 46016
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46016
Bug 10988 - Allow for Google OAuth2 logins Combined all of the patches above
into one, making them apply to master again.

Review of attachment 46016:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=10988=46016)
-

In general I feel this is a good start, but it's just that.. a start.  We need
a more thorough handling of login fallbacks and we need to add state tokens
into the mix to protect our users from CRSF attacks.

::: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
@@ +65,5 @@
>  [% IF some_private_shelves > 10 
> %]
>   href="/cgi-bin/koha/opac-shelves.pl?op=listcategory=1" tabindex="-1" 
> role="menuitem" class="listmenulink">View All
>  [% END %]
> +[% ELSIF ( 
> Koha.Preference('GoogleOAuth2') == 1 ) %]
> + href="/cgi-bin/koha/svc/auth/googleoauth2" tabindex="-1" 
> class="menu-inactive" role="menuitem">Log in to create your own lists

I disagree with this change. A) it looks to me like it won't do what your
expecting (it looks like it's a level too deep in the nested IF's) but B) I
don't feel adding a login link here is appropriate unless your going to add it
for all available authentication mechanisms.. it's just make the interface
inconsistent.

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt
@@ +138,2 @@
>  
>  [% END # / IF casAuthentication %]

There's not enough added to this file.  There should be a 'login with your
google id' block somewhere which appears to be missing.

@@ +139,5 @@
>  [% END # / IF casAuthentication %]
>  
> +[% IF ( invalidOAuth2Login ) %]
> +Automatic login
> +Sorry, your automatic login failed.  class="error">[% invalidOAuth2Login %]

I think this needs rewording, it's a Google Login.. it's not automagic.. it's a
shared login using the email claim from a google openid connect id token.  I
feel the text is a little misleading.

::: opac/svc/auth/googleoauth2
@@ +147,5 @@
> +}
> +
> +}
> +else {
> +my $prompt = $query->param('reauthenticate') // q{};

I'm not seeing an state tokens in use anywhere in this Flow.. without them we
are wide open to cross-site request forgery (CSRF) attacks.. we likely need to
create a nice randomised string and store it between invocations of the script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14153] Noisy warns in admin/transport-cost-matrix.pl

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14153

--- Comment #8 from Jonathan Druart  
---
(In reply to Brendan Gallagher from comment #6)
> Signed-off-by: Jonathan Druart 
> Amended patch: Init a $op variable, if it must be reused later.

Note that I have not made this change finally.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15373] Zip should be ZIP

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373

--- Comment #11 from Jonathan Druart  
---
Created attachment 46069
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46069=edit
Bug 15373: More changes of Zip to ZIP on intranet

To test:

- Log in to Staff Interface, go to Administration, Libraries and Groups
(cgi-bin/koha/admin/branches.pl). Click 'New library' and confirm that it says
'ZIP/Postal Code:' in the form.
- Go back to Administration, Cities and towns (cgi-bin/koha/admin/cities.pl).
Confirm it says 'ZIP/Postal code' in table heading. Click 'New city' and
confirm it says 'ZIP/Postal code:' in form
- Go back to Administration, Global system preferences, I18L/L10N
(cgi-bin/koha/admin/preferences.pl?tab=i18n_l10n). Under AddressFormat, confirm
all available options say '[ZIP/Postal Code]'
- Go to Reports, Patrons (cgi-bin/koha/reports/borrowers_stats.pl). Confirm it
says 'ZIP/Postal code' under Title
- Go to Tools, Batch patron modification (cgi-bin/koha/tools/modborrowers.pl),
enter any card number and click 'Continue'. Confirm it says 'ZIP/Postal code'
in the table of patron details, and in the form to edit

Signed-off-by: Mark Tompsett 
NOTE: Tested together with first patch.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11280] Change Withdrawn toggle to drop down selection of authorized values

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11280

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
The patch works as expected, but I am wondering if you should not take into
account the values which could not exist in the AV.
This could cause data lost.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15433] Self checkout software error on checkout

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15433

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
(In reply to Derryn from comment #2)
> You are correct, that patch fixed it! Thanks.

Could you signoff the patch please?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #62 from Kyle M Hall  ---
Patches pushed to master!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

--- Comment #43 from Jonathan Druart  
---
Actually, this bug is a duplicate of bug 12528, sorry not to have see that
before.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9254

--- Comment #44 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #43)
> Actually, this bug is a duplicate of bug 12528, sorry not to have see that
> before.

Read bug 9254.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

--- Comment #45 from Jonathan Druart  
---
See Kyle's followup bug 9254 comment 4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9254] New option to block patrons from changing messaging preferences in OPAC

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12528

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #46 from Jonathan Druart  
---
Another issue is that there is no check in the opac/opac-messaging.pl script to
forbid the user to modify the messaging changes, see my quick patch on bug 9254
comment 16.

The correct way to continue here would be to mark this one as a duplicate of
bug 9254 and work on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15373] Zip should be ZIP

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15373] Zip should be ZIP

2015-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #46045|0   |1
is obsolete||
  Attachment #46046|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  
---
Created attachment 46068
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46068=edit
Bug 15373: Changing Zip to ZIP on OPAC and Intranet

To test:

1) Login to OPAC --> You personal details.
2) Ensure it says 'ZIP/Postal Code' under Main Address, Alternate Address and
Alternate Contact
3) Login to Staff interface --> Go to a member's page (ie
koha/members/memberentry.pl) --> Details.
4) Ensure it says 'ZIP/Postal Code' under Alternate address and Alternative
contact
5) Click Edit
6) Ensure it says 'ZIP/Postal Code' under Main Address, Alternate Address and
Alternate Contact

Signed-off-by: Barry Cannon 
Signed-off-by: Mark Tompsett 
NOTE: Tested together with second patch.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 191 matches

Mail list logo