[Koha-bugs] [Bug 15170] Add 264 field to MARC21*DC.xsl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170

--- Comment #15 from Katrin Fischer  ---
Thx Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP authentication.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807

Chris Cormack  changed:

   What|Removed |Added

  Attachment #25526|0   |1
is obsolete||

--- Comment #6 from Chris Cormack  ---
Created attachment 46182
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46182=edit
Bug 11807 : Add support for categorycode conversions when updating an user
using a LDAP server.

To test

1/ Apply both patches

2/ This patch lets you easily configure mappings for categorycode values.
These mapping will be used when updating the user's account after a successful
LDAP login.

Here is an example configuration :


  STU
  ...



  STUDENT
  EMPLOYEE

  


3/ With this configuration, LDAP users with the usertype value "EMP" on the
LDAP server should have the "EMPLOYEE" categorycode in Koha.

Signed-off-by: Chris 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP authentication.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP authentication.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807

Chris Cormack  changed:

   What|Removed |Added

  Attachment #42105|0   |1
is obsolete||

--- Comment #7 from Chris Cormack  ---
Created attachment 46183
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46183=edit
Bug 11807: (follow-up) remove date conversions

To test

1/ Apply both patches

2/ This patch lets you easily configure mappings for categorycode values.
These mapping will be used when updating the user's account after a successful
LDAP login.

Here is an example configuration :


  STU
  ...



  STUDENT
  EMPLOYEE

  


3/ With this configuration, LDAP users with the usertype value "EMP" on the
LDAP server should have the "EMPLOYEE" categorycode in Koha.

Signed-off-by: Chris 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #286 from Chris Cormack  ---
Created attachment 46178
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46178=edit
Bug 7143 : Adding releases and fixing some missing tabs

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Chris Cormack  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #8 from Srdjan Jankovic  ---
As far as I can see it is a bug either in
* modules/svc/suggestion.tt, line 37, that composes query as q=[indexed query],
or in
* C4::Search::parseQuery() that cannot deal with that kind of query

I think that buildQuery() actually builds an invalid query, but I'd certainly
need an authoritative opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #43 from Chris Cormack  ---
Falling back to patching base and 3-way merge...
Auto-merging reports/issues_stats.pl
CONFLICT (content): Merge conflict in reports/issues_stats.pl
Failed to merge in the changes.


Not a simple conflict

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14751] Allow C4::Context->interface to be set to 'sip' or 'commandline'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751

Chris Cormack  changed:

   What|Removed |Added

  Attachment #42061|0   |1
is obsolete||

--- Comment #2 from Chris Cormack  ---
Created attachment 46181
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46181=edit
Bug 14751 - Allow C4::Context->interface to be set to 'sip' or 'commandline'

Koha::Logger allows us to split up logging to separate files based on
the interface. However, right now the interface is limited to just
'opac' or 'intranet'.

We should extend this to allow the interface to also be set to 'sip'
for SIP server logging, and to 'commandline' for cronjobs and all other
command line scripts.

Signed-off-by: Chris 

Does what it says on the tin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14751] Allow C4::Context->interface to be set to 'sip' or 'commandline'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081

Katrin Fischer  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com,
   ||katrin.fisc...@bsz-bw.de
   Keywords||dependency

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9316] Add Nginx install options with plack

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #56 from Chris Cormack  ---
With the plack in production as of 3.22.0 this bug needs a rethink, the patches
as they stand will duplicate a lot of stuff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Chris Cormack  changed:

   What|Removed |Added

  Attachment #41235|0   |1
is obsolete||

--- Comment #6 from Chris Cormack  ---
Created attachment 46180
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46180=edit
Bug13572 - Changed "borrowers-force-messaging-defaults" --help parameter's
result to better explain the new functionality

New test plan (well, a clearer version):

1) Apply both patches
2) Create a new patron with random values, except for it expiration date, make
it expired (Patrons > New Patron > Student)
3) Enable the system preference called “EnhancedMessagingPreferences”
4) In “Administration" > "Patron categories" > Student, modify the "days in
advance", then click "Save"
5) run the script "./misc/maintenance/borrowers-force-messaging-defaults --doit
--onlyactives"
6) Validate that the student created in step 2 hasn't changed (Patrons >
search)
7) Validate that any other student that isn't expired has changed.

Signed-off-by: Chris 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Chris Cormack  changed:

   What|Removed |Added

  Attachment #35164|0   |1
is obsolete||

--- Comment #5 from Chris Cormack  ---
Created attachment 46179
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46179=edit
Bug 13572 - Add onlyactives parameter to force_borrower_messaging_defaults
script

1) Apply both patches
2) Create a new patron with random values, except for it expiration date, make
it expired (Patrons > New Patron > Student)
3) Enable the system preference called “EnhancedMessagingPreferences”
4) In “Administration" > "Patron categories" > Student, modify the "days in
advance", then click "Save"
5) run the script "./misc/maintenance/borrowers-force-messaging-defaults --doit
--onlyactives"
6) Validate that the student created in step 2 hasn't changed (Patrons >
search)
7) Validate that any other student that isn't expired has changed.

Signed-off-by: Chris 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

M. Tompsett  changed:

   What|Removed |Added

  Attachment #39251|0   |1
is obsolete||

--- Comment #46 from M. Tompsett  ---
Created attachment 46185
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46185=edit
Bug 7679: Followup: circulation statistics wizard improvements

Signed-off-by: Brendan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

M. Tompsett  changed:

   What|Removed |Added

  Attachment #39253|0   |1
is obsolete||

--- Comment #48 from M. Tompsett  ---
Created attachment 46187
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46187=edit
Bug 7679: Group different case values in the same row/column

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

M. Tompsett  changed:

   What|Removed |Added

  Attachment #39250|0   |1
is obsolete||

--- Comment #45 from M. Tompsett  ---
Created attachment 46184
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46184=edit
Bug 7679: circulation statistics wizard improvements

- Add patron branch to the list of possible rows, columns, and filters
- Add extended patron attributes to the list of possible rows, columns,
  and filters
- Allow to group period by hour
- Allow to translate filter names

NOTE: Removed signed off, since I believe I have dealt with the conflicts.
  Retesting required.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

M. Tompsett  changed:

   What|Removed |Added

  Attachment #39252|0   |1
is obsolete||

--- Comment #47 from M. Tompsett  ---
Created attachment 46186
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46186=edit
Bug 7679: Fix criteria display

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

M. Tompsett  changed:

   What|Removed |Added

  Attachment #39254|0   |1
is obsolete||

--- Comment #49 from M. Tompsett  ---
Created attachment 46188
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46188=edit
Bug 7679: Fix several bugs in circulation statistics wizard

- Display values in NULL columns/rows
- Display columns/rows that contain values only in NULL rows/columns
- "To" filter in period row should be inclusive (-MM-DD should be
  -MM-DD 23:59:59)
- Make it possible to use only the "To" filter in period row (actually
  it results in DBI error (2 bind variables instead of 1))

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

M. Tompsett  changed:

   What|Removed |Added

  Attachment #39255|0   |1
is obsolete||

--- Comment #50 from M. Tompsett  ---
Created attachment 46189
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46189=edit
Bug 7679: Fix two SQL queries when using patron attributes

and remove some Perl warnings

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

M. Tompsett  changed:

   What|Removed |Added

  Attachment #39257|0   |1
is obsolete||

--- Comment #52 from M. Tompsett  ---
Created attachment 46191
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46191=edit
Bug 7679: Display all table headers (case and accent sensitive)

It appears that we can't assume that a lowercase word is equivalent to
the same word in uppercase (or a mix of lowercase and uppercase
letters). And this is also true about accented words.
So display all values even if they differ only by case or by their
accents.
This means that:
- "foobar" and "Foobar" will be in two separate rows/columns
- "Etudiant" and "Étudiant" (french) will be in two separate
  rows/columns too

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

M. Tompsett  changed:

   What|Removed |Added

  Attachment #39256|0   |1
is obsolete||

--- Comment #51 from M. Tompsett  ---
Created attachment 46190
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46190=edit
Bug 7679: Various fixes for circulation statistics wizard

- use SQL TRIM functions to avoid having '' and ' ' considered as
  different values
- use Text::Unaccent to remove accents from columns or rows values when
  accessing %table. This is required as MySQL consider as equals two
  strings that differ only by their accents when using GROUP BY clause.
- Exclude '' values from the list of columns or rows. Otherwise we could
  have a row 'UNKNOWN VALUE' and a row 'NULL' which both have the same
  values in their cells.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||julian.maur...@biblibre.com

--- Comment #29 from Julian Maurice  ---
Patches pushed to 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

M. Tompsett  changed:

   What|Removed |Added

  Attachment #39085|0   |1
is obsolete||

--- Comment #28 from M. Tompsett  ---
Created attachment 46203
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46203=edit
Bug 14097: Rollback issue and warning corrected

The rollback issue came from '_count' testing.
It used a 'DROP TABLE' and 'CREATE TABLE' which implicitly do autocommit.
That's why the final rollback could not be.

This patch no longer uses t::lib::TestBuilder either because it was the cause
of the warning on Comment #1 :
"DBIx::Class::Storage::txn_rollback(): A txn_rollback
in nested transaction is ineffective! (depth 1) at
t/lib/TestBuilder.pm line 308"

Signed-off-by: Bernardo Gonzalez Kriegel 
Now data is preserved, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

M. Tompsett  changed:

   What|Removed |Added

  Attachment #38946|0   |1
is obsolete||

--- Comment #25 from M. Tompsett  ---
Created attachment 46200
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46200=edit
Bug 14097: Testing C4::UsageStats

DESCRIPTION
---

Add unit tests to C4::UsageStats
Subroutine :
(V : tested, X : Not tested)

V  NeedUpdate
V  BuiltReport
X  ReportToCommunity
V  _count

TEST PLAN
-

1. Apply patch
2. prove -v t/db_dependent/UsageStats.t
-- All tests should run successfully

/!\ I have 1 warning but I don't know where it can come /!\
(in cleanup) DBIx::Class::Storage::txn_rollback(): A txn_rollback
in nested transaction is ineffective! (depth 1) at
t/lib/TestBuilder.pm line 308

TEST PLAN OPTIONAL
--

Go check bug 13899 to see the coverage of this module.

Coverage BEFORE this patch :
Statement  :  40,5%
Branch :   0,0%
Condition  :   0,0%
Subroutine :  55,6%

Coverage AFTER this patch :
Statement  :  81,0%
Branch : 100,0%
Condition  : 100,0%
Subroutine :  88,8%

Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

M. Tompsett  changed:

   What|Removed |Added

  Attachment #38947|0   |1
is obsolete||

--- Comment #26 from M. Tompsett  ---
Created attachment 46201
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46201=edit
Bug 14097: Delete table issues before testing

If we delete all biblio DB, we could have some troubles with foreign keys

Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

M. Tompsett  changed:

   What|Removed |Added

  Attachment #38948|0   |1
is obsolete||

--- Comment #27 from M. Tompsett  ---
Created attachment 46202
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46202=edit
Bug 14097: changing verif_systempreferences_values subroutine

It's saving a large number of lines

Signed-off-by: Bernardo Gonzalez Kriegel 
All tests run, no koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

M. Tompsett  changed:

   What|Removed |Added

  Attachment #41844|0   |1
is obsolete||

--- Comment #31 from M. Tompsett  ---
Created attachment 46206
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46206=edit
Bug 14097 : Changing AddReserve prototype call

In response of Joubu comment #19

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

M. Tompsett  changed:

   What|Removed |Added

  Attachment #39435|0   |1
is obsolete||

--- Comment #29 from M. Tompsett  ---
Created attachment 46204
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46204=edit
Bug 14097 - Correct noise under Debian

The first four patches do not create any noise under Ubuntu 14.04 LTS.

Running on Debian Jessie:
[SNIP]
keys on reference is experimental at t/db_dependent/UsageStats.t line 88.
keys on reference is experimental at t/db_dependent/UsageStats.t line 106.
keys on reference is experimental at t/db_dependent/UsageStats.t line 119.
keys on reference is experimental at t/db_dependent/UsageStats.t line 136.
keys on reference is experimental at t/db_dependent/UsageStats.t line 153.
keys on reference is experimental at t/db_dependent/UsageStats.t line 162.
keys on reference is experimental at t/db_dependent/UsageStats.t line 587.
[SNIP]

Instead of having 'keys $foo->{bar}', 'keys %{$foo->{bar}}' was used.

TEST PLAN
-
1) On a DEBIAN system (Jessie gives above messages)
   apply the first 4 patches interactively.
2) $ prove t/db_dependent/UsageStats.t
   -- trigger noise like above.
3) apply this patch
4) $ prove t/db_dependent/UsageStats.t
   -- no noise triggered.
5) koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

M. Tompsett  changed:

   What|Removed |Added

  Attachment #41843|0   |1
is obsolete||

--- Comment #30 from M. Tompsett  ---
Created attachment 46205
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46205=edit
Bug 14097 : Avoid issue if the number of syspref shared is modified

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

--- Comment #32 from M. Tompsett  ---
Created attachment 46207
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46207=edit
Bug 14097: Fixed missing test cases

Fixed AllowPkiAuth issue caused by 15101.
Added missing AudioAlerts

TEST PLAN
-
1) prove -v t/db_dependent/UsageStats.t
   -- should pass after applying patch
2) Run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #2 from Chris Cormack  ---
Another one I can't sign off on, could someone please test this

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46189|0   |1
is obsolete||

--- Comment #58 from M. Tompsett  ---
Created attachment 46197
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46197=edit
Bug 7679: Fix two SQL queries when using patron attributes

and remove some Perl warnings

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46190|0   |1
is obsolete||

--- Comment #59 from M. Tompsett  ---
Created attachment 46198
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46198=edit
Bug 7679: Various fixes for circulation statistics wizard

- use SQL TRIM functions to avoid having '' and ' ' considered as
  different values
- use Text::Unaccent to remove accents from columns or rows values when
  accessing %table. This is required as MySQL consider as equals two
  strings that differ only by their accents when using GROUP BY clause.
- Exclude '' values from the list of columns or rows. Otherwise we could
  have a row 'UNKNOWN VALUE' and a row 'NULL' which both have the same
  values in their cells.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46188|0   |1
is obsolete||

--- Comment #57 from M. Tompsett  ---
Created attachment 46196
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46196=edit
Bug 7679: Fix several bugs in circulation statistics wizard

- Display values in NULL columns/rows
- Display columns/rows that contain values only in NULL rows/columns
- "To" filter in period row should be inclusive (-MM-DD should be
  -MM-DD 23:59:59)
- Make it possible to use only the "To" filter in period row (actually
  it results in DBI error (2 bind variables instead of 1))

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46184|0   |1
is obsolete||

--- Comment #53 from M. Tompsett  ---
Created attachment 46192
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46192=edit
Bug 7679: circulation statistics wizard improvements

- Add patron branch to the list of possible rows, columns, and filters
- Add extended patron attributes to the list of possible rows, columns,
  and filters
- Allow to group period by hour
- Allow to translate filter names

NOTE: Removed signed off, since I believe I have dealt with the conflicts.
  Retesting required. Found some comments C4::Date that I missed.
  line prepatch 194/ postpatch 233 seems to be where the major
  conflict is.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46187|0   |1
is obsolete||

--- Comment #56 from M. Tompsett  ---
Created attachment 46195
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46195=edit
Bug 7679: Group different case values in the same row/column

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46186|0   |1
is obsolete||

--- Comment #55 from M. Tompsett  ---
Created attachment 46194
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46194=edit
Bug 7679: Fix criteria display

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

M. Tompsett  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46185|0   |1
is obsolete||

--- Comment #54 from M. Tompsett  ---
Created attachment 46193
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46193=edit
Bug 7679: Followup: circulation statistics wizard improvements

Signed-off-by: Brendan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46191|0   |1
is obsolete||

--- Comment #60 from M. Tompsett  ---
Created attachment 46199
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46199=edit
Bug 7679: Display all table headers (case and accent sensitive)

It appears that we can't assume that a lowercase word is equivalent to
the same word in uppercase (or a mix of lowercase and uppercase
letters). And this is also true about accented words.
So display all values even if they differ only by case or by their
accents.
This means that:
- "foobar" and "Foobar" will be in two separate rows/columns
- "Etudiant" and "Étudiant" (french) will be in two separate
  rows/columns too

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

--- Comment #44 from M. Tompsett  ---
(In reply to Chris Cormack from comment #43)
> Falling back to patching base and 3-way merge...
> Auto-merging reports/issues_stats.pl
> CONFLICT (content): Merge conflict in reports/issues_stats.pl
> Failed to merge in the changes.
> 
> 
> Not a simple conflict

Most of it seemed to be whitespace indentation issues.
I'll upload a fix, and then do a comparison to make sure nothing seems lost.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||15358


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358
[Bug 15358] merge.pl does not populate values to merge
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||11315


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315
[Bug 11315] Add support for subfield deletion when doing authority merges.
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46203|0   |1
is obsolete||

--- Comment #36 from M. Tompsett  ---
Created attachment 46211
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46211=edit
Bug 14097: Rollback issue and warning corrected

The rollback issue came from '_count' testing.
It used a 'DROP TABLE' and 'CREATE TABLE' which implicitly do autocommit.
That's why the final rollback could not be.

This patch no longer uses t::lib::TestBuilder either because it was the cause
of the warning on Comment #1 :
"DBIx::Class::Storage::txn_rollback(): A txn_rollback
in nested transaction is ineffective! (depth 1) at
t/lib/TestBuilder.pm line 308"

Signed-off-by: Bernardo Gonzalez Kriegel 
Now data is preserved, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #4 from Chris Cormack  ---
Can we get a sign off on this please, I can't sign it off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15138] typo in reports/borrowers_out.pl - issues.timestamap

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15138

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #6 from Frédéric Demians  ---
This patch has been pushed to 3.20.x, will be in 3.20.8.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46207|0   |1
is obsolete||

--- Comment #40 from M. Tompsett  ---
Created attachment 46215
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46215=edit
Bug 14097: Fixed missing test cases

Fixed AllowPkiAuth issue caused by 15101.
Added missing AudioAlerts

TEST PLAN
-
1) prove -v t/db_dependent/UsageStats.t
   -- should pass after applying patch
2) Run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46200|0   |1
is obsolete||

--- Comment #33 from M. Tompsett  ---
Created attachment 46208
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46208=edit
Bug 14097: Testing C4::UsageStats

DESCRIPTION
---

Add unit tests to C4::UsageStats
Subroutine :
(V : tested, X : Not tested)

V  NeedUpdate
V  BuiltReport
X  ReportToCommunity
V  _count

TEST PLAN
-

1. Apply patch
2. prove -v t/db_dependent/UsageStats.t
-- All tests should run successfully

/!\ I have 1 warning but I don't know where it can come /!\
(in cleanup) DBIx::Class::Storage::txn_rollback(): A txn_rollback
in nested transaction is ineffective! (depth 1) at
t/lib/TestBuilder.pm line 308

TEST PLAN OPTIONAL
--

Go check bug 13899 to see the coverage of this module.

Coverage BEFORE this patch :
Statement  :  40,5%
Branch :   0,0%
Condition  :   0,0%
Subroutine :  55,6%

Coverage AFTER this patch :
Statement  :  81,0%
Branch : 100,0%
Condition  : 100,0%
Subroutine :  88,8%

Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46205|0   |1
is obsolete||

--- Comment #38 from M. Tompsett  ---
Created attachment 46213
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46213=edit
Bug 14097 : Avoid issue if the number of syspref shared is modified

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46204|0   |1
is obsolete||

--- Comment #37 from M. Tompsett  ---
Created attachment 46212
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46212=edit
Bug 14097 - Correct noise under Debian

The first four patches do not create any noise under Ubuntu 14.04 LTS.

Running on Debian Jessie:
[SNIP]
keys on reference is experimental at t/db_dependent/UsageStats.t line 88.
keys on reference is experimental at t/db_dependent/UsageStats.t line 106.
keys on reference is experimental at t/db_dependent/UsageStats.t line 119.
keys on reference is experimental at t/db_dependent/UsageStats.t line 136.
keys on reference is experimental at t/db_dependent/UsageStats.t line 153.
keys on reference is experimental at t/db_dependent/UsageStats.t line 162.
keys on reference is experimental at t/db_dependent/UsageStats.t line 587.
[SNIP]

Instead of having 'keys $foo->{bar}', 'keys %{$foo->{bar}}' was used.

TEST PLAN
-
1) On a DEBIAN system (Jessie gives above messages)
   apply the first 4 patches interactively.
2) $ prove t/db_dependent/UsageStats.t
   -- trigger noise like above.
3) apply this patch
4) $ prove t/db_dependent/UsageStats.t
   -- no noise triggered.
5) koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46202|0   |1
is obsolete||

--- Comment #35 from M. Tompsett  ---
Created attachment 46210
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46210=edit
Bug 14097: changing verif_systempreferences_values subroutine

It's saving a large number of lines

Signed-off-by: Bernardo Gonzalez Kriegel 
All tests run, no koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46201|0   |1
is obsolete||

--- Comment #34 from M. Tompsett  ---
Created attachment 46209
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46209=edit
Bug 14097: Delete table issues before testing

If we delete all biblio DB, we could have some troubles with foreign keys

Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46206|0   |1
is obsolete||

--- Comment #39 from M. Tompsett  ---
Created attachment 46214
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46214=edit
Bug 14097 : Changing AddReserve prototype call

In response of Joubu comment #19

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||julian.maur...@biblibre.com

--- Comment #17 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Chris Cormack  changed:

   What|Removed |Added

  Attachment #45943|0   |1
is obsolete||

--- Comment #77 from Chris Cormack  ---
Created attachment 46216
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46216=edit
Bug 7677 [Follow-up]: New areas in subscriptions and new functions when
receiving.

- Various fixes.

Test plan:

Once the makePreviousSerialAvailable syspref is enabled, receive a serial, and
then another, then check that:

 - the first received itemtype has been set to the "previous item type" value
(set in the subscription).

 - the first received has been made available.

 - the last received serial itemtype has been set to the "item type" value (set
in the subscription).

 - 995$l is automatically prefilled.

Configure the serialsFieldsToAV syspref. When creating or editing a
subscription, check that:

 - the domain and/or origin and/or support fields are correctly displaying the
authorized values configured in the syspref.

Signed-off-by: Chris 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15170] Add 264 field to MARC21*DC.xsl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #14 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15170] Add 264 field to MARC21*DC.xsl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170

Julian Maurice  changed:

   What|Removed |Added

   Severity|enhancement |normal

--- Comment #13 from Julian Maurice  ---
(In reply to Katrin Fischer from comment #12)
> Hi Julian, I think this is in a grey area - for libraries using RDA it means
> that the publication year, publisher etc. is missing from the export formats
> - which is quite important information.

Sorry, I didn't see comment 8.
So, switching to 'normal' severity again, and I will push it into 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15316] Use Bootstrap modal for authority Z39.50 search results preview

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
   Severity|minor   |enhancement

--- Comment #9 from Julian Maurice  ---
Switching severity to 'enhancement' as the patch does not fix any bug

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15383] Opac: Authority details: Fix translation issues with tags

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15383

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||julian.maur...@biblibre.com

--- Comment #8 from Julian Maurice  ---
Patches pushed to 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15447] log4perl.conf does not have __LOG_DIR__ replaced when installing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15447

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||julian.maur...@biblibre.com

--- Comment #5 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14397] Typo 'foriegn' in table comments

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14397

Julian Maurice  changed:

   What|Removed |Added

   Severity|enhancement |trivial
 CC||julian.maur...@biblibre.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #6 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14034] User logged out on refresh after Shibboleth authentication

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #7 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15317] Use Bootstrap modal for MARC and Card preview when ordering from staged files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15317

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
   Severity|minor   |enhancement

--- Comment #7 from Julian Maurice  ---
Switching severity to 'enhancement' as the patch does not fix any bug

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15320] Use Bootstrap modal for MARC preview when ordering from an existing record

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15320

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
   Severity|minor   |enhancement

--- Comment #6 from Julian Maurice  ---
Switching severity to 'enhancement' as the patch does not fix any bug

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15318] Use Bootstrap modal for MARC and Card preview when ordering an external source

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15318

Julian Maurice  changed:

   What|Removed |Added

   Severity|minor   |enhancement
 CC||julian.maur...@biblibre.com

--- Comment #6 from Julian Maurice  ---
Switching severity to 'enhancement' as the patch does not fix any bug

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6845] Add default date (today) to view log

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6845

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #1 from Marc Véron  ---
Is this bug still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/