date:20160105

[Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |critical
Version|3.22|master
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 Depends on||13790
 Status|NEW |ASSIGNED
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
This is critical.
It looks like a bad side effect of bug 13790. Still investigating...


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790
[Bug 13790] Add unique id issue_id to issues and old_issues tables
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344

--- Comment #19 from Julian Maurice  ---
(In reply to Kyle M Hall from comment #18)
> Third patch has been pushed to master!

Pushed to 3.22.x as well

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15462


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462
[Bug 15462] Unable to renew books via circ/renew.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462

Marc Véron  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462

--- Comment #3 from Marc Véron  ---
Created attachment 46242
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46242=edit
Bug 15462 - Unable to renew books via circ/renew.pl

To verify: Got to circ/circulation.pl and try to renew an item.
Result: Can't call method "single" without a package or
object reference at /usr/share/kohaclone/circ/renew.pl
line 57

To test:
- Apply patch
- Try to renow items that are or are not checked out. Error
  no longer occurs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462

--- Comment #2 from Marc Véron  ---
Found soultion, patch follows.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #46242|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 46243
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46243=edit
Bug 15462 - Unable to renew books via circ/renew.pl

To verify: Got to circ/circulation.pl and try to renew an item.
Result: Can't call method "single" without a package or
object reference at /usr/share/kohaclone/circ/renew.pl
line 57

To test:
- Apply patch
- Try to renow items that are or are not checked out. Error
  no longer occurs.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15466] Suggestions.t is failing

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15466

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15466] Suggestions.t is failing

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15466

Marc Véron  changed:

   What|Removed |Added

  Attachment #46244|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 46246
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46246=edit
Bug 15466: Do not assume $values_in is a hashref

It could be undefined.
Test plan:
prove t/db_dependent/Suggestions.t
should return green.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15466] Suggestions.t is failing

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15466

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15467] AuthoritiesMarc.t is failing

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15467

--- Comment #1 from Jonathan Druart  
---
Created attachment 46247
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46247=edit
Bug 15467: If authtypecode is not defined, do not explode

The test t/db_dependent/AuthoritiesMarc.t fails because one test expect
the BuildSummary subroutine to not crash if the authtypecode passed in
parameter does not exist in the DB.

Test plan:
prove t/db_dependent/AuthoritiesMarc.t
should return green.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15467] AuthoritiesMarc.t is failing

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15467

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15468] New: Search links on callnumber fails on opac results page

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15468

Bug ID: 15468
   Summary: Search links on callnumber fails on opac results page
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: jefk...@dias.ie
QA Contact: testo...@bugs.koha-community.org

Similar to Bug 12405, but for the OPAC.

Freshly migrated from Heritage to Koha: https://library.celt.dias.ie

If a call number contains "(" or ")", the "q=callnum" query doesn't work in the
Debian packaged version 3.22

Example:
https://library.celt.dias.ie/cgi-bin/koha/opac-search.pl?q=callnum:891.6205%20ITS%20(43iii)

Solution is similar to Bug 12405, is to introduce %22 into the search query
https://library.celt.dias.ie/cgi-bin/koha/opac-search.pl?q=callnum:%22891.6205%20ITS%20(43iii)%22


This can be done by changing:

/usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/modules/opac-results.tt on
line 405:
[% IF ( available_items_loo.itemcallnumber ) %][[%
available_items_loo.itemcallnumber %]][% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135

--- Comment #14 from Martin Renvoize  ---
I agree adding another workaround is bad, doing it 'properly' is better.

So, am I reading it right that basically we also need IsDebarred also renaming
and then this patch could stand.. or have I misunderstood something?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15465] New: README for github

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465

Bug ID: 15465
   Summary: README for github
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: About
  Assignee: neng...@gmail.com
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

This doesn't really fit in here, but I couldn't see a better category for it.

We have a github presence in the form of a git mirror, and that presence is
getting the odd pull request through. We aught to have a README.md for github
display to direct developer who find Koha via github to the main resources and
explicitly state that pull requests are not accepted via github.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15467


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15467
[Bug 15467] AuthoritiesMarc.t is failing
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15467] New: AuthoritiesMarc.t is failing

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15467

Bug ID: 15467
   Summary: AuthoritiesMarc.t is failing
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 15381

Since bug 15381.


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381
[Bug 15381] Move the authority types related code to Koha::Authority::Type[s] -
part 2
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462

--- Comment #4 from Jonathan Druart  
---
For the record, it has been introduced by 

commit 3cab4d1efd25268441c88ce74d5a4b568773c8aa
Bug 14978: (RM followup) DBIx update

Bug 14978 introduced a unique on items.itemnumber to get the constraint we had
before bug 13790.

With adding this constraint, DBIx::Class::Schema::Loader renamed the has_many
issues RS with a might_have issue.

+__PACKAGE__->might_have(
+  "issue",
-__PACKAGE__->has_many(
-  "issues",

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14978] issues.itemnumber should be a unique key

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15462


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462
[Bug 15462] Unable to renew books via circ/renew.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||14978


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978
[Bug 14978] issues.itemnumber should be a unique key
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

--- Comment #41 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #40)
> Pushed to master, thanks Philippe!

Please regenerate the Schema files, some tests are failing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15466] Suggestions.t is failing

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15466

--- Comment #1 from Jonathan Druart  
---
Created attachment 46244
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46244=edit
Bug 15466: Do not assume $values_in is a hashref

It could be undefined.
Test plan:
prove t/db_dependent/Suggestions.t
should return green.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15466] New: Suggestions.t is failing

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15466

Bug ID: 15466
   Summary: Suggestions.t is failing
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 15429


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15429
[Bug 15429] sub _parseletter should not change referenced values
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15429] sub _parseletter should not change referenced values

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15429

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15466


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15466
[Bug 15466] Suggestions.t is failing
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206

Marc Véron  changed:

   What|Removed |Added

  Attachment #46228|0   |1
is obsolete||

--- Comment #37 from Marc Véron  ---
Created attachment 46245
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46245=edit
Bug 15206 - Show patron's age under date of birth in memberentry.pl

Test plan:

Create or edit a patron (members/memberentry.pl),
enter a date of birth (for a new patron),
patron'a age should be shown under

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015

--- Comment #21 from Marc Véron  ---
I can still reprduce the error on current master.
Patch still applies.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15463] view_holdsqueue.tt uses a search for cardnumber instead of borrowernumber direct link

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15463

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
I don't understand what is the problem here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337

--- Comment #2 from Jonathan Druart  
---
Created attachment 46258
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46258=edit
Bug 15337: Make itemtypes retrieved with GetItemTypes ordered by descriptions

Prior to this patch, the itemtypes were displayed ordered by the code
(itemtypes.itemtype DB column).
This patch will make them displayed by the description displayed (the
translated description).

Test plan:
0/ Do not apply this patch set
1/ Confirm that the itemtypes are displayed ordered by code (when adding
an item, cataloguing/additem.pl)
2/ Confirm that t/db_dependent/Koha.t does not pass
3/ Apply the test patch
4/ Confirm that t/db_dependent/Koha.t pass
5/ Confirm that the itemtypes are not displayed by description (on
additem.pl)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285

Julian Maurice  changed:

   What|Removed |Added

 Blocks||15471


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471
[Bug 15471] Add column settings and filters to Holds queue table
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15353] patron image disappears when on fines tab

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s]

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451

--- Comment #11 from Jonathan Druart  
---
(In reply to Bernardo Gonzalez Kriegel from comment #10)
> I'm testing in order, all patches applied. First 3 Ok.

I add a test plan on each patch to explain what I do, but to test them, you
have to apply the entire patch set (well, in a dream world you should not, but
I am not perfect :p).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #44632|0   |1
is obsolete||

--- Comment #34 from Alex Arnaud  ---
Created attachment 46263
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46263=edit
Bug 11999: Check for age restriction in CanBookBeReserved

+ improve t/db_dependent/Reserves.t to make tests pass on UNIMARC
installation

Maxreserves and alreadyreserved works on ILSDI
Maxreserves works also on staff and opac
Already reserves works also on staff and opac
tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using
koha_ut db)

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15472] Do not display links to circulation.pl if remaining_permissions is not set

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472

--- Comment #1 from Marc Véron  ---
Created attachment 46265
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46265=edit
Bug 15472: Do not display links to circulation.pl if remaining_permissions is
not set

If permission 'circulate_remaining_permissions' is not set, links to
'Circulation'
(/circ/circulation-home.pl) on the intranet home page lead to an error
message: "Error: You do not have permission to access this page."

This patch hides the links if the permission is not set.

To test:
- Apply patch
- Log in to the intranet (staff client) with a patron who has the permission
  'circulate_remaining_pernissions' not set
- Verify that no links to Circulation appear on the intranet start page
  (menu top left and menu in main page area)
- Log in as a user who has the permission set.
- Verify that te links appear as appropriate.

http://bugs.koha-community.org/show_bug.cgi?id=15442

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15398] Batch patron deletion/anonymization issue page: Restricted dropdown menu

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15398

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15398] Batch patron deletion/anonymization issue page: Restricted dropdown menu

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15398

--- Comment #1 from Jonathan Druart  
---
Created attachment 46270
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46270=edit
Bug 15398: Hide Staff members only in the patron deletion/anonymization tool

On bug 9076 (commit 568a4c1230ee9a4002181fcab2c083faf6c323a9), the plan
was to hide the Staff members from the tool.
But the test was wrong, it was done on the category_code instead of the
category_type value.

Test plan:
1/ Create a category 'Student' which is not part of the Staff
(category_code=S, category_type!=S)
2/ Create a staff category (category_type=S)
3/ Go on the deletion/anonymization tool (tools/cleanborrowers.pl) and
confirm that the category Student category is displayed in the dropdown
list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #10 from Marc Véron  ---
(In reply to Jonathan Druart from comment #8)
> (In reply to Katrin Fischer from comment #7)
> > Looking at the pref or doing a count of the branches in Auth.pm? Trying to
> > understand :)
> 
> Count the branches from Auth and remove the pref everywhere.
> $template->param( singleBranchMode => Koha::Branches->search->count );

Yes, that makes sense.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6625] Allow Koha to use Openlibrary subject api

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6625

Marc Véron  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=6624

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #2 from Marc Véron  ---
(In reply to Katrin Fischer from comment #1)
> Created attachment 8794 [details]
> screenshot
> 
> I tried retesting this on current master, what I did:
> 
> 1) New definition
> 2) Module: patrons
> 3) Registration date
> 4) Nothing shows up for the 4th step
> 
> For other dates like 'Expiry date' the 4th step shows up correctly and shows
> the wrong behaviour Nicole described.

With current master 'Expiry date' displays on current master, but the bug as
such is still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15353] patron image disappears when on fines tab

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353

Marc Véron  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3607] Lost item returned credit to borrower - but can't resolve credit

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3607

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #3 from Marc Véron  ---
Still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8373] opacheader should not show in print layout

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8373

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #1 from Marc Véron  ---
Tested on current master with opac-shelves.pl:

If I use the browser's print preview, it looks OK. If I use the icon 'print',
the whole page is printed, including the contents of the opacheader system
preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360

--- Comment #3 from Ian Palko  ---
Perhaps this would qualify as an "enhancement", but would it be possible to
restore the older behavior as well?

Previously the "New from z39.50" button did exactly that. It generated a new
record from a z39.50 authorities search. There was never a "Replace" function
or button.

The replace feature is great, and allowing replacement as this patch does is a
good idea, but perhaps we should also allow the creation of a new record as
before.

That would require a new "New from z39.50" button which would actually generate
a new record, in addition to the "Replace from z39.50".

Being on vacation, I'm not in front of my test server, else I'd work up a quick
and dirty solution, since it seems easy and straight-forward. Perhaps if
someone else has a few minutes ...

Thanks for the work to fix and clarify this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471

--- Comment #3 from Marc Véron  ---
Oh, sorry, I was not aware of the dependency: Bug 15285.
Patch seems to work, though, behalve of the QA tools complaining (see comment
#2)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15398] Batch patron deletion/anonymization issue page: Restricted dropdown menu

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15398

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #46270|0   |1
is obsolete||

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Created attachment 46272
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46272=edit
[SIGNED-OFF] Bug 15398: Hide Staff members only in the patron
deletion/anonymization tool

On bug 9076 (commit 568a4c1230ee9a4002181fcab2c083faf6c323a9), the plan
was to hide the Staff members from the tool.
But the test was wrong, it was done on the category_code instead of the
category_type value.

Test plan:
1/ Create a category 'Student' which is not part of the Staff
(category_code=S, category_type!=S)
2/ Create a staff category (category_type=S)
3/ Go on the deletion/anonymization tool (tools/cleanborrowers.pl) and
confirm that the category Student category is displayed in the dropdown
list.

Signed-off-by: Bernardo Gonzalez Kriegel 
Work as described, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15398] Batch patron deletion/anonymization issue page: Restricted dropdown menu

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15398

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |ASSIGNED
   Assignee|paul.poul...@biblibre.com   |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624

Marc Véron  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=6625
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #3 from Marc Véron  ---
Testing:
Without patches: 
 - Order in dropdown list of Koha item types is wrong (not alphabetically).
 - t/db_dependent/Koha.t passes green

With first patch (tests):
 - t/db_dependent/Koha.t does not pass (not ok 10 - GetItemTypes test)
   (as expected)

With second patch applied:
 - Order in dropdown is alphabetically
   (as expected)
 - t/db_dependent/Koha.t passes green
   (as expected)

Going to sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15353] patron image disappears when on fines tab

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15353] patron image disappears when on fines tab

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353

Marc Véron  changed:

   What|Removed |Added

  Attachment #46260|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 46276
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46276=edit
Bug 15353: Display the patron image where needed

On the 3 following pages, the patron image was not displayed:
   members/discharge.pl
   members/pay.pl
   members/paycollect.pl

Test plan:
Apply this patch and confirm the image is now displayed

Followed test plan, image displays as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360

Marc Véron  changed:

   What|Removed |Added

  Attachment #46261|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 46273
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46273=edit
Bug 15360: Rename "New from Z39.50" with "Replace with Z39.50"

If the record exist, the button text should not be "New from", but
"Replace".

Test plan:
Go on the authority home page (authorities/authorities-home.pl)
You should see a "New from Z39.50" button.
Edit an authority
You should now see "Replace with Z39.50"

Followed test plan, displays as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337

Marc Véron  changed:

   What|Removed |Added

  Attachment #46257|0   |1
is obsolete||

--- Comment #4 from Marc Véron  ---
Created attachment 46274
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46274=edit
Bug 15337: Add tests to ensure that GetItemTypes will return element ordered by
desc

See comment #3
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #2 from Marc Véron  ---
QA tools say:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
   FAIL   forbidden patterns
forbidden pattern: console.log (line 25)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Tom Misilo  changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337

Marc Véron  changed:

   What|Removed |Added

  Attachment #46258|0   |1
is obsolete||

--- Comment #5 from Marc Véron  ---
Created attachment 46275
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46275=edit
Bug 15337: Make itemtypes retrieved with GetItemTypes ordered by descriptions

Prior to this patch, the itemtypes were displayed ordered by the code
(itemtypes.itemtype DB column).
This patch will make them displayed by the description displayed (the
translated description).

Test plan:
0/ Do not apply this patch set
1/ Confirm that the itemtypes are displayed ordered by code (when adding
an item, cataloguing/additem.pl)
2/ Confirm that t/db_dependent/Koha.t does not pass
3/ Apply the test patch
4/ Confirm that t/db_dependent/Koha.t pass
5/ Confirm that the itemtypes are not displayed by description (on
additem.pl)

See comment #3
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7017] override_renewals permission confusing

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7017

Marc Véron  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14713

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15354

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15353] patron image disappears when on fines tab

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15353] patron image disappears when on fines tab

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353

--- Comment #1 from Jonathan Druart  
---
Created attachment 46260
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46260=edit
Bug 15353: Display the patron image where needed

On the 3 following pages, the patron image was not displayed:
   members/discharge.pl
   members/pay.pl
   members/paycollect.pl

Test plan:
Apply this patch and confirm the image is now displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360

--- Comment #1 from Jonathan Druart  
---
Created attachment 46261
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46261=edit
Bug 15360: Rename "New from Z39.50" with "Replace with Z39.50"

If the record exist, the button text should not be "New from", but
"Replace".

Test plan:
Go on the authority home page (authorities/authorities-home.pl)
You should see a "New from Z39.50" button.
Edit an authority
You should now see "Replace with Z39.50"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #44631|0   |1
is obsolete||

--- Comment #33 from Alex Arnaud  ---
Created attachment 46262
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46262=edit
Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved

- Check if borrower already has reserved the same biblio (or item).
- Check if borrower has reached the maximum number of holds allowed
  (syspref maxreserves)

The goal of this patch is to do these checks also when using ILS-DI
services HoldTitle and HoldItem

Test plan:
--
Before patch:
1/ Set syspref maxreserves to 1
2/ Place some holds through ILS-DI and note that you can place more than
   1 hold for a borrower
3/ Try to hold the same biblio/item with the same borrower through
   ILS-DI and note that you can

Apply the patch
4/ Place some holds through ILS-DI, you shouldn't be able to place more
   than 1 hold for a borrower
5/ Try to hold the same biblio/item with the same borrower through
   ILS-DI. You shouldn't be able to do that.
6/ Try to place holds on staff interface and OPAC. The behaviour must be
   identical than before the patch.

Maxreserves and alreadyreserved works on ILSDI
Maxreserves works also on staff and opac
Already reserves works also on staff and opac
tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using
koha_ut db)

Signed-off-by: Alex Sassmannshausen 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15442] Checkouts table will not display due to javascript error

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15442

--- Comment #8 from Marc Véron  ---
Created attachment 46264
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46264=edit
Bug 15472: Do not display links to circulation.pl if remaining_permissions is
not set

If permission 'circulate_remaining_permissions' is not set, links to
'Circulation'
(/circ/circulation-home.pl) on the intranet home page lead to an error
message: "Error: You do not have permission to access this page."

This patch hides the links if the permission is not set.

To test:
- Apply patch
- Log in to the intranet (staff client) with a patron who has the permission
  'circulate_remaining_pernissions' not set
- Verify that no links to Circulation appear on the intranet start page
  (menu top left and menu in main page area)
- Log in as a user who has the permission set.
- Verify that te links appear as appropriate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15473


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473
[Bug 15473] Koha::Objects->find should find if the key is an empty string
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15473] New: Koha::Objects->find should find if the key is an empty string

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473

Bug ID: 15473
   Summary: Koha::Objects->find should find if the key is an empty
string
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: major
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 15381

This bug has been found after bug 15381 was pushed:
If you go on authorities/authorities.pl, you expect a form to create a
authorities with a "Default" authority type.
Now, it explodes:
Can't call method "authtypetext" on an undefined value at
/home/koha/src/authorities/authorities.pl line 665.

Koha::Objects->find does not want to search if the key does not exist (undef,
'', 0). But actually it should only be a coward if it is not defined.

Moreover this is the default behavior of the DBIx::Class find method.


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381
[Bug 15381] Move the authority types related code to Koha::Authority::Type[s] -
part 2
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15470] Error when adding new authority with Default framework

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15470

--- Comment #4 from Jonathan Druart  
---
Frédéric,

Sorry I have noticed before but actually it's a duplicate of bug 15473 (I have
just filled).
With your patch, we are loosing the 'Default' authtypetext.

I am marking this one as a duplicate as I am pretty sure it's the way to go.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15473] Koha::Objects->find should find if the key is an empty string

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473

Jonathan Druart  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #2 from Jonathan Druart  
---
*** Bug 15470 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15470] Error when adding new authority with Default framework

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15470

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|Signed Off  |RESOLVED

--- Comment #5 from Jonathan Druart  
---


*** This bug has been marked as a duplicate of bug 15473 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7017] override_renewals permission confusing

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7017

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #1 from Marc Véron  ---
As far as I understand it, overdues_report, force_checkout, manage_restrictions
work only if circulate_remaining_permissions is set. (Hmm, what about
self_checkout?)

Maybe we could re-word the descriptions to make it clear? 

Something like:

[] circulate_remaining_permissions Basic circulation permissions

[] overdues_report Execute overdue items report (needs basic permissions)

[] force_checkout Force checkout if a limitation exists (needs basic
permissions)

[] manage_restrictions Manage restrictions for accounts (needs basic
permissions)

[] override_renewals Override blocked renewals (needs basic permissions)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15472] Do not display links to circulation.pl if remaining_permissions is not set

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472

Marc Véron  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15473] Koha::Objects->find should find if the key is an empty string

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15473] Koha::Objects->find should find if the key is an empty string

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473

--- Comment #1 from Jonathan Druart  
---
Created attachment 46266
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46266=edit
Bug 15473: Make Koha::Objects->find accepts 0 and '' as a key

This bug has been found after bug 15381 was pushed:
If you go on authorities/authorities.pl, you expect a form to create a
 authorities with a "Default" authority type.
Now, it explodes:
Can't call method "authtypetext" on an undefined value at
/home/koha/src/authorities/authorities.pl line 665.

Koha::Objects->find does not want to search if the key does not exist
(undef, '', 0). But actually it should only be a coward if it is not defined.

Moreover this is the default behavior of the DBIx::Class find method.

Test plan:
  prove t/db_dependent/Koha/Objects.t
should return green
and
  GET /cgi-bin/koha/authorities/authorities.pl
should not make everything explode.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15470] Error when adding new authority with Default framework

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15470

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15398] Batch patron deletion/anonymization issue page: Restricted dropdown menu

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15398

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
Version|3.18|master
   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator)

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444

Winona Salesky  changed:

   What|Removed |Added

 CC||wsale...@gmail.com

--- Comment #2 from Winona Salesky  ---
Sorry, Using git bz, and something is going wrong. 
Troubleshooting. Will have something up by the end of the day. 

-Winona

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15354] item types aren't showing in default hold policies

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15337

--- Comment #7 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #6)
> Not that C4::Koha::GetItemTypes should be fixed for a global fix.
> It will be easy to do on top of bug 14828.

Finally done on bug 15337

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15442] Checkouts table will not display due to javascript error

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15442

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #46264|0   |1
is obsolete||

--- Comment #9 from Marc Véron  ---
Comment on attachment 46264
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46264
Bug 15472: Do not display links to circulation.pl if remaining_permissions is
not set

Mistaked with the bug number, sorry for the noise...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15323] ./t/Prices.t fails without a valid database

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15323

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |WORKSFORME
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---
t/Prices.t is not data-related:

% sudo service mysql stop
[ ok ] Stopping MariaDB database server: mysqld.

% prove t/Prices.t
t/Prices.t .. ok 
All tests successful.
Files=1, Tests=16,  2 wallclock secs ( 0.02 usr  0.00 sys +  1.40 cusr  0.04
csys =  1.46 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator)

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444

Winona Salesky  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator)

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444

--- Comment #3 from Katrin Fischer  ---
Thx! 
If it won't work at all: 'git format-patch' will create a file you can attach.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471

--- Comment #1 from Julian Maurice  ---
Created attachment 46259
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46259=edit
Bug 15471: Add column settings and filters to Holds queue table

Add column visibility menu using DataTables Buttons
Add a text filter on top of each column
Also extend page width so that the large table is better centered

Depends on bug 15285

Test plan
1. Go to Holds queue page (circ/view_holdsqueue.pl)
2. Check that table sorting and filtering work well and that you can
   hide each column
3. Go to Admin > Configure columns and change the settings for this
   table (Circulation > view_holdsqueue > holds-table). Verify that the
   settings work by going again to the Holds queue page
4. Check that filters continue to work after hiding some columns

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15472] Do not display links to circulation.pl if remaining_permissions is not set

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472

Marc Véron  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15470] Error when adding new authority with Default framework

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15470

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #46250|0   |1
is obsolete||

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Created attachment 46267
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46267=edit
[SIGNED-OFF] Bug 15470: Error when adding new authority with Default framework

TO TEST:
1. Authorities > New authority > Default
2. You get:
   Can't call method "authtypetext" on an undefined value at
3. Apply the patch and repeat 1

Signed-off-by: Bernardo Gonzalez Kriegel 
Bug reproduced, now fixed.
No koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15398

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9076] Add ability to delete borrowers by expiration date and category code to cleanborrowers.pl

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15398

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15398] Batch patron deletion/anonymization issue page: Restricted dropdown menu

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15398

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11352,
   ||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9076

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s]

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451

--- Comment #14 from Bernardo Gonzalez Kriegel  ---
(In reply to Jonathan Druart from comment #13)
> (In reply to Bernardo Gonzalez Kriegel from comment #12)
> 
> Sorry Bernardo, I tested on my local branch, which was not updated.
> I have attached new patch on bug 15446, some occurrences of 'sub type' have
> been pushed in the meanwhile.

With all patches from 15446 and this, exporting a range of biblios to
marc/xml/cvs, with/without ExportWithCsvProfile

Inside the file (marc/xml/csv)

Software error:
Can't locate object method export_format_id via package
Koha::CsvProfiles at /home/bgkriegel/kohaclone/tools/export.pl line
196.


On logs
export.pl: Can't locate object method "export_format_id" via package
"Koha::CsvProfiles"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15473] Koha::Objects->find should find if the key is an empty string

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #46266|0   |1
is obsolete||

--- Comment #3 from Bernardo Gonzalez Kriegel  ---
Created attachment 46269
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46269=edit
[SIGNED-OFF] Bug 15473: Make Koha::Objects->find accepts 0 and '' as a key

This bug has been found after bug 15381 was pushed:
If you go on authorities/authorities.pl, you expect a form to create a
 authorities with a "Default" authority type.
Now, it explodes:
Can't call method "authtypetext" on an undefined value at
/home/koha/src/authorities/authorities.pl line 665.

Koha::Objects->find does not want to search if the key does not exist
(undef, '', 0). But actually it should only be a coward if it is not defined.

Moreover this is the default behavior of the DBIx::Class find method.

Test plan:
  prove t/db_dependent/Koha/Objects.t
should return green
and
  GET /cgi-bin/koha/authorities/authorities.pl
should not make everything explode.

Signed-off-by: Bernardo Gonzalez Kriegel 
Find this after signing 15470 :)
Test pass, new auth (Default) created, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15473] Koha::Objects->find should find if the key is an empty string

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15470] Error when adding new authority with Default framework

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15470

--- Comment #6 from Frédéric Demians  ---
(In reply to Jonathan Druart from comment #4)
> Frédéric,
> 
> Sorry I have noticed before but actually it's a duplicate of bug 15473 (I
> have just filled).
> With your patch, we are loosing the 'Default' authtypetext.
> 
> I am marking this one as a duplicate as I am pretty sure it's the way to go.

I agree

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135

--- Comment #15 from Jonathan Druart  
---
(In reply to Martin Renvoize from comment #14)
> I agree adding another workaround is bad, doing it 'properly' is better.
> 
> So, am I reading it right that basically we also need IsDebarred also
> renaming and then this patch could stand.. or have I misunderstood something?

No, you got it.
Renaming them could work, but otoh it would make sense to keep the same name:
the subroutines only call the corresponding subroutine/method.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s]

2016-01-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451

--- Comment #13 from Jonathan Druart  
---
(In reply to Bernardo Gonzalez Kriegel from comment #12)

Sorry Bernardo, I tested on my local branch, which was not updated.
I have attached new patch on bug 15446, some occurrences of 'sub type' have
been pushed in the meanwhile.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 3 >

1 - 100 of 209 matches

Mail list logo