[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358

--- Comment #17 from Katrin Fischer  ---
Failed QA last night because of Josef's comment. Glad to see this move forward,
hope remaining problems can be solved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240

--- Comment #13 from Jonathan Druart  
---
Hi Chris,
Thanks for testing!
Did you compare the execution times before and after the patches?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15469] Authority header search is broken

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469

--- Comment #8 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #7)
> Almost there - just one small inconsistency - the last tab shows the
> 'chronological term' preselected, while all others show 'default'.
> Can you take a quick look if that's an easy fix?

I have Default preselected for the 4 tabs.
Are you sure it comes from this patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15469] Authority header search is broken

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469

--- Comment #9 from Katrin Fischer  ---
Hm not sure what else it could, but will retest.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15523] Move a number of sysprefs to circulation rules

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
We will certainly need 1 bug report per pref.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15522] New interface for revamped circulation rules

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299

--- Comment #10 from Jonathan Druart  
---
(In reply to Liz Rea from comment #9)
> Actually sorry I was wrong, it works fine on the show page.

I have tested all others and they worked, please confirm you don't get the warn
somewhere.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464

--- Comment #16 from Patfrat  ---
And this error again
Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a ->
try at /usr/share/perl5/MARC/File/XML.pm line 568.

If i set macflavour to MARC21, all my document's title are not visible
If i set macflvaour to UNIMARC, default value for my instance, titles are
visible but this error appears for these items i have saved with addbiblio
default grid !

I will try first to remove manually wrong items, then, trying to see what's
wrong with addbiblio.pl overloading my CPU when i submit via Fast Add !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15376] Edit invoices: Can not change Shipping cost.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15376

--- Comment #9 from Marc Véron  ---
The error no longer appears on current master.

I had a look at the database: When I filed the bug, the error occured with
records where shipmentdate = NULL.

The current behaviour is that a record with shipmentdate = NULL has now
shipmentdate = -00-00 after saving with an empty field 'shipmentdate'.

More testing:
If I receive a shipment and save with an empty shipmentdate, the shipmentdate
gets a NULL in the database (and billingdate / closedate as well).

Additionally: If I edit this record and save it without changing any values
(leaving shipmentdate and billingdate empty), shipmentdate turns to -00-00
but billingdate is still NULL. I would expect that both dates behave the same.

(BTW: While saving I get a log entry 'invoice.pl: Use of uninitialized value in
concatenation (.) or string at .../invoice.tt line 79)

So we have two different values for "empty date" in the table aqinvoices: NULL
and -00-00.

@Jonathan: What dou you think about -00-00 vs NULL? If I look at Bugzilla I
see a couple of Bugs regarding -00-00.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13762] biblionumber field and subfield can be called once in authorities merge

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||11700


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
[Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED
 Depends on||13762

--- Comment #58 from Katrin Fischer  ---
Setting this to BLOCKED because of bug 13762


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762
[Bug 13762] biblionumber field and subfield can be called once in authorities
merge
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #46241|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 46453
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46453=edit
Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt

To verify patch, run `git diff -w HEAD^' and note that the only changes
shown are where [% IF %] statements are expanded/unexpanded onto
multiple lines to match the prevailing style.

Signed-off-by: Bernardo Gonzalez Kriegel 
Looks like refactoring :)
No regressions, no koha-qa errors

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15512] Minor regression caused by Bug 7369 - warn on deleting item not triggered

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15512

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #46437|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 46451
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46451=edit
Bug 15512 - Minor regression caused by Bug 7369 - warn on deleting item not
triggered

To test:
1 - Delete an item using the Action menu
2 - There is a js error and no warning box
3 - Apply patch
4 - Delete an item using the action menu
5 - You should get a confirmation box as expected

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15512] Minor regression caused by Bug 7369 - warn on deleting item not triggered

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15512

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #46167|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall  ---
Created attachment 46452
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46452=edit
Bug 14133: Print notices should be generated with the print template

If the overdue notice to send is an email or a SMS and the patron does
not provided such information, a print notice is generated.
But it will be generated with the email or sms template, which is not
useful, especially in the SMS case.

The template to use should be the print one.

Test plan:
0/ Does not apply this patch and Correctly define the overdue rules to generate
an overdue notice to the message_queue table.
Check email + SMS
1/ Define an email address and a SMS number for a patron
2/ Generate the overdue notices (misc/cronjobs/overdue_notices.pl [-t])
3/ 2 notices should have been generated:
mtt=email with the email template used
mtt=sms   with the sms template used
4/ Truncate the message_queue table
5/ Remove the email address and repeat 2
6/ Only 1 notice should have been generated:
mtt=print with the email template used
7/ Truncate the message_queue table
8/ Remove the sms alert number and repeat 2
9/ 2 notices should have been generated:
mtt=print with the email template used (or sms I suppose)

10/ Apply this patch and repeat previous steps.
The print notices should be generated with the print template.

IMPORTANT NOTE: This test plan does not take into account the notices
generated for the staff ("These messages were not sent directly to the
patrons."). However the behavior will also change, the print template
will be used in all cases. Is it what we want?

Signed-off-by: Chris 

Seems fine by me

Signed-off-by: Kyle M Hall 

The IMPORTANT NOTE change makes sense to me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #168 from Kyle M Hall  ---
I don't think C4::Passwordrecovery is a good namespace. Should this not be
something like Koha::Patron::Password::Recovery or
Koha::Borrower::Password::Recovery? We should not be adding modules to the C4
namespace at this point.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #5 from Frédéric Demians  ---
It doesn't work for me when your stylesheet is in opac-tmpl/xsl/. I have to put
it in opac-tmpl directly, and modify Repository.pm file to make it works. Could
you try on your side? I've seen in your screenshot you're working with
'localhost' as your server URL. It may come from there.

A remark: you introduce a new syspref OAI-PMH:CustomStylesheet. I think that
this kind of parameter belongs to the 'Extended Mode'. The YAML config file
could be used to link to a local stylesheet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15531] New: Add support for standing orders

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531

Bug ID: 15531
   Summary: Add support for standing orders
 Change sponsored?: Sponsored
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: jwea...@bywatersolutions.com
  Reporter: jwea...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: nic...@bywatersolutions.com

A new kind of standing order basket, with the following behavior:

  * Items can be received without the basket being closed.
  * Items can be received without their price being known in advance.
  * Creation of items upon receive customizable per-basket

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15398] Batch patron deletion/anonymization issue page: Restricted dropdown menu

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15398

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #46272|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 46450
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46450=edit
Bug 15398: Hide Staff members only in the patron deletion/anonymization tool

On bug 9076 (commit 568a4c1230ee9a4002181fcab2c083faf6c323a9), the plan
was to hide the Staff members from the tool.
But the test was wrong, it was done on the category_code instead of the
category_type value.

Test plan:
1/ Create a category 'Student' which is not part of the Staff
(category_code=S, category_type!=S)
2/ Create a staff category (category_type=S)
3/ Go on the deletion/anonymization tool (tools/cleanborrowers.pl) and
confirm that the category Student category is displayed in the dropdown
list.

Signed-off-by: Bernardo Gonzalez Kriegel 
Work as described, no errors.

Signed-off-by: Kyle M Hall 

http://bugs.koha-community.org/show_bug.cgi?id=15308

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15398] Batch patron deletion/anonymization issue page: Restricted dropdown menu

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15398

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352

Kyle M Hall  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8034

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8034] Enable server print queue selection

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034

Kyle M Hall  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8352
 CC||k...@bywatersolutions.com

--- Comment #40 from Kyle M Hall  ---
This work will certainly conflict with Bug 8352.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

  Attachment #46454|0   |1
is obsolete||

--- Comment #2 from Nick Clemens  ---
Created attachment 46455
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46455=edit
Bug 14576 - Allow arbitrary automatic update of location on checkin

This patch adds a new syspref "UpdateItemLocationOnCheckin" which
accepts pairs of shelving locations.  On check-in the items location is
compared ot the location on the left and, if it matches, is updated to
the location on the left.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Set the new system preference UpdateitemLocationOnCheckin
   to the following (assuming sample data):
   NEW: FIC
   FIC: GEN
4) Create an item, set its location to NEW
5) Check in the item, note its location is now FIC
6) Check in the item again, note its location is now GEN
7) Check in the item again, note its location remains GEN

Sponsored by:
Arcadia Public Library (http://library.ci.arcadia.ca.us/)
Middletown Township Public Library (http://www.mtpl.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

--- Comment #3 from Nick Clemens  ---
Created attachment 46456
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46456=edit
Bug 14576 - Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

--- Comment #1 from Nick Clemens  ---
Created attachment 46454
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46454=edit
Bug 14576 - Allow arbitrary automatic update of location on checkin

This patch adds a new syspref "UpdateItemLocationOnCheckin" which
accepts pairs of shelving locations.  On check-in the items location is
compared ot the location on the left and, if it matches, is updated to
the location on the left.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Set the new system preference UpdateitemLocationOnCheckin
   to the following (assuming sample data):
   NEW: FIC
   FIC: GEN
4) Create an item, set its location to NEW
5) Check in the item, note its location is now FIC
6) Check in the item again, note its location is now GEN
7) Check in the item again, note its location remains GEN

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com
   Assignee|jwea...@bywatersolutions.co |n...@bywatersolutions.com
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464

--- Comment #18 from Patfrat  ---
After searching a lot, i have decided to delete my fast add unimarc framework.
I have also deleted two bad documents that zebra rebuild indocicates me with
error on item numbers 1030, 1034

I have deleted them via mysql
Then, i have updated all biblio records setting frameworkcode to '' instead of
FA

And now, it works !
But i have no more Fast Add framework !
DO you provide one for Unimarc in fr-FR language ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206

--- Comment #45 from Jonathan Druart  
---
I don't understand your issue, what about something like:

function CalculateAge(date) {
// Caculate age
return (years, months);
}

onchange(
age = CalculateAge(date);
add_age_string_to_the_div
);

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #8 from Frédéric Demians  ---
(In reply to Tomás Cohen Arazi from comment #6)

> I'm using kohadevbox:ansible. I think the permissions (apache ones) on a
> regular dev/normal install have diverged from the packages. I'll take a look.

This part in apache conf is the culprit:


   Order deny,allow
   Deny from all


I will propose a patch fixing that, and using OAI server conf file to define
custom XSLT for web view.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8034] Enable server print queue selection

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #10 from Frédéric Demians  ---
Created attachment 46460
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46460=edit
Bug 15527 Custom stylesheet in extended mode

Add a parameter to YAML config file in order to specify a local XSLT
used style the XML returned by OAI Server. Some doc.

Move default XSLT from /opac-tmpl/xslt to
/opac-tmpl/bootstrap/css/OAI.xslt.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Frédéric Demians  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #46434|0   |1
is obsolete||
  Attachment #46435|0   |1
is obsolete||
  Attachment #46438|0   |1
is obsolete||

--- Comment #9 from Frédéric Demians  ---
Created attachment 46459
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46459=edit
Bug 15527: Add a stylesheet for OAI-PMH to aid usability

This patch introduces an XSLT file grabbed from DSpace and a couple
css files.

To test:

- Point to your dev Koha's oai endpoint. For example:
  http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListMetadataFormats
=> FAIL: Look how ugly it is for humans.
- Apply this patch
- Reload
=> SUCCES: It is styled and provides really useful links to interact with
  the OAI server verbs.
- Sign off :-D

Sponsored-by: Universidad Empresarial Siglo 21

Signed-off-by: Frédéric Demians 
  Works as described. Nice looking.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #6 from Tomás Cohen Arazi  ---
(In reply to Frédéric Demians from comment #5)
> It doesn't work for me when your stylesheet is in opac-tmpl/xsl/. I have to
> put it in opac-tmpl directly, and modify Repository.pm file to make it
> works. Could you try on your side? I've seen in your screenshot you're
> working with 'localhost' as your server URL. It may come from there.

I'm using kohadevbox:ansible. I think the permissions (apache ones) on a
regular dev/normal install have diverged from the packages. I'll take a look.


> A remark: you introduce a new syspref OAI-PMH:CustomStylesheet. I think that
> this kind of parameter belongs to the 'Extended Mode'. The YAML config file
> could be used to link to a local stylesheet.

That's probably a good idea. I'll dig into it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15517] deleted tables differ again

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #46403|0   |1
is obsolete||

--- Comment #3 from Héctor Eduardo Castro Avalos  ---
Created attachment 46457
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46457=edit
[SIGNED-OFF]Bug 15517: Resync borrowers and deletedborrowers tables

The 2 columns password and userid are not sync and could cause errors
when deleting patrons.

Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15517] deleted tables differ again

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||hector.hecax...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15517] deleted tables differ again

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #46404|0   |1
is obsolete||

--- Comment #4 from Héctor Eduardo Castro Avalos  ---
Created attachment 46458
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46458=edit
[SIGNED-OFF]Bug 15517: deleted* tables won't never differ anymore!

These tests will ensure that the 4 deleted* tables won't never differ
anymore.

Test plan:
0/ Do not execute the update DB entry
1/ prove t/db_dependent/db_structure.t
should fail
2/ Execute the update DB entry and update the schema with
misc/devel/update_dbix_class_files.pl
3/ prove t/db_dependent/db_structure.t
should now be happy

Signed-off-by: Hector Castro 
Test pass successfuly. Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163

--- Comment #11 from Jonathan Druart  
---
Jesse, yes it should be the way to go but..
I have already tried something and was stuck. I have a wip branch but I don't
remember what was wrong.

Looking at the diff it seems that I have tried to add a
DeleteBorrowerAttributes subroutines and the code looks quite complicated:

+sub DeleteBorrowerAttributes {
+my $borrowernumber = shift;
+my $no_branch_limit = @_ ? shift : 0;
+my $branch_limit = $no_branch_limit
+? 0
+: C4::Context->userenv ? C4::Context->userenv->{"branch"} : 0;
+
+my $dbh = C4::Context->dbh;
+my $query = q{
+DELETE FROM borrower_attributes
+};
+$query .= q{
+LEFT JOIN borrower_attribute_types_branches ON bat_code = code
+WHERE b_branchcode = ? OR b_branchcode IS NULL
+} if $branch_limit;
+$query .= q{
+WHERE borrowernumber = ?
+};
+
+$dbh->do( $query, undef, $branch_limit ? $branch_limit : (),
$borrowernumber );
+}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163

--- Comment #12 from Jonathan Druart  
---
Created attachment 46416
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46416=edit
Bug 15163: Wip - stuck

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163

--- Comment #13 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #12)
> Created attachment 46416 [details] [review]
> Bug 15163: Wip - stuck

Jesse, here is my start.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658

--- Comment #17 from Jonathan Druart  
---
(In reply to Jesse Weaver from comment #16)
> Created attachment 46352 [details] [review]
> Bug 14658: (followup) fix issue with list context on DBIC call
> 
> While working on bug 14659, it was discovered that the call to
> ...->guarantor in list context will cause the hash to be misaligned
> (thus causing hidden => ... to not actually be sent to the template).

Could you move that to another bug report, to make it backportable to stable
branches?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15481] Remove dead code in datatables.js

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15481

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15481] Remove dead code in datatables.js

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15481

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #46331|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 46417
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46417=edit
Bug 15481: Remove dead code in datatables.js

This removes the following functions that are not used anywhere:
- dt_add_rangedate_filter
- dt_overwrite_string_sorting_localeCompare
- replace_html
- replace_html_date

Test plan:
1. Search for calls to the above functions in the code. There should be
   none.
2. Check that existing tables using DataTables are not broken.

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

--- Comment #13 from Jonathan Druart  
---
Created attachment 46420
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46420=edit
Bug 14571 - More switching of Amazon image source URL to https

modified:   modules/opac-opensearch.tt
   modified:   modules/opac-results-grouped.tt
   modified:   modules/opac-shelves.tt
   modified:   modules/opac-showreviews-rss.tt
   modified:   modules/opac-showreviews.tt

Basically, just inspect these places and make sure the Amazon images are
using https://images-na instead of http://images

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

--- Comment #15 from Jonathan Druart  
---
(In reply to Liz Rea from comment #10)
> Can we get these ones through first though? I'll make a different bug for
> the intranet detail.
> 
> Cheers,
> Liz

I have embedded it in this patch set.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

--- Comment #12 from Jonathan Druart  
---
Created attachment 46419
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46419=edit
Bug 14571: HTTPS Amazon images [follow up]

I found a couple more places where we should be using images-na, so I
updated them

* in the shelf browser
* in XISBN related works (honestly not sure how to test this one, but
  changing from the http:// url won't hurt anything.)

To test:

* Turn on the shelf browser, and browse for an item that has an amazon
  image,
* inspect it, it should be using https://images-na... url.

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

--- Comment #14 from Jonathan Druart  
---
Created attachment 46421
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46421=edit
Bug 14571 - Intranet detail needs ssl sources for Amazon images

To test:

Enable Amazon images for the staff client - syspref:  AmazonCoverImages -> Show
Go to a record detail in the intranet that has an Amazon image, inspect it, and
make sure that it

1. Shows
2. has https://images-na. and not http://images.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #46229|0   |1
is obsolete||
  Attachment #46230|0   |1
is obsolete||
  Attachment #46231|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart  
---
Created attachment 46418
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46418=edit
Bug 14571: using_https check for ssl connections doesn't work in some
situations

To test:

* turn on Amazon images for result and detail in the OPAC
* do a search that will result in an Amazon image being displayed on the
  result page
* inspect the cover image that is returned on the result page, it should
  be using a https://images-na... Amazon URL.
* click through to the detail for that item
* inspect the cover image that is returned on the detail page, it should
  be using a https://images-na... Amazon URL.

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15518] Intranet detail needs ssl sources for Amazon images

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15518

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Needs Signoff   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Jonathan Druart  
---


*** This bug has been marked as a duplicate of bug 14571 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

--- Comment #16 from Jonathan Druart  
---
*** Bug 15518 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15526] New: Drop nozebra database table

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15526

Bug ID: 15526
   Summary: Drop nozebra database table
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Database
  Assignee: gmcha...@gmail.com
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

All Code related to nozbra was removed, but it looks like the table was never
dropped from older existing installations.

New installations won't have the table, as it has been removed from
kohastructure.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14816] Item search returns no results with multiple values selected for one field

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816

Marc Véron  changed:

   What|Removed |Added

  Attachment #46395|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 46436
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46436=edit
Bug 14816: Fix multiple selection in item search

Send each selected value as a separate parameter. Otherwise DataTables
(or jQuery ?) joins all values with a comma

Tested / compared with several combinations, e.g. "All libraries" vs
all libraries checked. With patch result is the same (without, all
libraries checked had zero result).
Works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15523] Move a number of sysprefs to circulation rules (Omnibus)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com
Summary|Move a number of sysprefs   |Move a number of sysprefs
   |to circulation rules|to circulation rules
   ||(Omnibus)

--- Comment #2 from Nicole C. Engard  ---
Once we have finished the dependencies we will split this bug report for the
multiple patches.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #46413|0   |1
is obsolete||

--- Comment #11 from Kyle M Hall  ---
Created attachment 46428
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46428=edit
Bug 15299: Ask for confirmation when deleting a report from second page

Some link are hidden when loading the page, by DataTables, we need to
use the delegate jQuery method to attach a handler to the click event
for all delete links (the ones existing when loading the page, and the
ones displayed in the future).

Test plan:
Have more than 20 reports defined
Go on the report list view, then change the number of elements
displayed, click "action>delete". You should get a warn.

Signed-off-by: Liz Rea 
Confirm that there is now a confirmation on delete from the list -> action menu

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #45216|0   |1
is obsolete||

--- Comment #10 from Alex Arnaud  ---
Created attachment 46432
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46432=edit
Bug 15261: Verify if checkouts/reserves requests periods overlap...

... with existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

A user place an hold from opac whose requested period overlap an
existing reserve period => prevent reserve,

A librarian place an hold from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation),

A librarian make a checkout from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation).

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture

1 (staff side):
Place a hold on title (which has only one items) level with start date
and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are warned about an existing reserve

2 (staff side):
Place a hold on title (which has more than one items) level with start
date and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.

3 (staff side):
Place a hold on item level with start date and expiration date.
Place another hold on item level with period overlaping this reserve.
Check you are warned about an existing reserve.

4 (opac side):
Do the same than for staff side. Instead of a warn, reserve is
prevented.

5:
Place a hold on title (which has only one items) level with start date
and expiration date.
Try to checkout the unique item from this title with period overlaping
the reserve period.
Check you are warned about an existing reserve

6:
Place a hold on title (which has more than one items) level with start
date and expiration date.
Checkout an item from this title with period overlaping the reserve
period.
Check you are NOT warned about an existing reserve.

7:
Place a hold on item level with start date and expiration date.
Checkout this item period overlaping the reserve period.
Check you are warned about an existing reserve

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #14 from Kyle M Hall  ---
Pre patch:

time misc/cronjobs/overdue_notices.pl -t -itemscontent
title,author,itemcallnumber,barcode,replacementprice

real2m9.252s
user2m5.492s
sys 0m0.108s

Post Patch:

time misc/cronjobs/overdue_notices.pl -t -itemscontent
title,author,itemcallnumber,barcode,replacementprice

real1m19.965s
user1m12.437s
sys 0m0.192s

mysql> select COUNT(*) from issues where date_due > now();
+--+
| COUNT(*) |
+--+
|  480 |
+--+
1 row in set (0.01 sec)

mysql> select COUNT(*) from issues where date_due <= now();
+--+
| COUNT(*) |
+--+
|65218 |
+--+
1 row in set (0.01 sec)

I found it quite striking how much of a time difference there was even though
the number of checkouts not due yet is quite low so I ran the tests again with
very similar results!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15519] Warns when creating a basket

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15519

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15519] Warns when creating a basket

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15519

Marc Véron  changed:

   What|Removed |Added

  Attachment #46407|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 46431
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46431=edit
Bug 15519: Warns when creating a basket

To test:
1) Reproduce warn following steps above
2) Apply patch
3) Create a new basket and click Save. Do not add any items
4) Notice warn is gone
5) Click 'Delete this basket' and confirm that the validation message reads:
"Are you sure you want to delete this basket?" Click cancel.
6) Add an order to the basket, then click 'Delete this basket'. Confirm the
validation message gives more information and more delete options.

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15528] New: Updating the authorised value for a report subgroup removes the previous value assigned from all report

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15528

Bug ID: 15528
   Summary: Updating the authorised value for a report subgroup
removes the previous value assigned from all report
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: gmcha...@gmail.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To recreate:
1 - Create some reports and assign/create groups and subgroups
2 - Change the authorised value for one of the subgroups
3 - Note that rather than the previous value being left behind (expected) or
updated (ideal behavior) the subgroup data is stripped from the report

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15512] Minor regression caused by Bug 7369 - warn on deleting item not triggered

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15512

Marc Véron  changed:

   What|Removed |Added

  Attachment #46378|0   |1
is obsolete||

--- Comment #3 from Marc Véron  ---
Created attachment 46437
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46437=edit
Bug 15512 - Minor regression caused by Bug 7369 - warn on deleting item not
triggered

To test:
1 - Delete an item using the Action menu
2 - There is a js error and no warning box
3 - Apply patch
4 - Delete an item using the action menu
5 - You should get a confirmation box as expected

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15512] Minor regression caused by Bug 7369 - warn on deleting item not triggered

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15512

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464

--- Comment #17 from Patfrat  ---
I have modified this file /usr/share/perl5/MARC/File/XML.pm row 568 to not die
and return UTF-8 instead to be allow to retrieve my test items and not throwing
Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a ->
try at /usr/share/perl5/MARC/File/XML.pm line 568.

Then i have deleted concerned items ... but i have always some bugs.

Fast cataloguing not working
Having some javascript files timeout (browser.js, basket.js)
And saving via default grid use MARC21 and not UNIMARC !!!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15529] New: Process Message Queue may send duplicate emails if process is launched twice

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529

Bug ID: 15529
   Summary: Process Message Queue may send duplicate emails if
process is launched twice
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Neither process_message_queue.pl nor C4::Letters::SendQueuedMessages have any
method of ensuring that duplicate emails are not sent if two or more instances
of process_message_queue.pl are running concurrently.

This seems to have caused issues on a server which was re-running cron jobs
because the system clock was re-set by NTP, but it could also cause issues if
process_message_queue.pl took a very long time to process.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15501] Planned Irregularities are deleted when modifying subscription

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #46411|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall  ---
Created attachment 46422
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46422=edit
Bug 15501 - Planned Irregularities are deleted when modifying subscription

Add a warning to avoid saving a subscription whitout testing prediction pattern
when there are planned no published issues

Signed-off-by: Liz Rea 
Ran through test plan, looks all good.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15501] Planned Irregularities are deleted when modifying subscription

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #8 from Nick Clemens  ---
Hi Liz,

I tested in Firefox and Chrome and could not recreate this issue, can you check
again?

Moving back to Needs Signoff

-Nick

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446

--- Comment #15 from Kyle M Hall  ---
Created attachment 46425
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46425=edit
Bug 15446: Rename Koha::Object[s]->type with _type

In a few case (at least systempreferences and export_format (csv profiles),
the type method of Koha::Object and Koha::Objects can be in conflict with the
column names.
Indeed systempreferences.type exists and so the method will return
'Systempreference' (the name of the module) instead of the value of the row in
DB.

I have found at least 1 place where it can cause issue:
In C4::Context->set_preference:
 601 my $syspref = Koha::Config::SysPrefs->find( $var );
 602 my $type = $syspref ? $syspref->type() : undef;
 603
 604 $value = 0 if ( $type && $type eq 'YesNo' && $value eq '' );

type will always be 'Systempreference' and the YesNo pref will be set to an
empty string '' instead of 0.

I am not sure about the consequences of this, but it is preferable to
fix it ASAP.

To reproduce:
0/ Do not apply this patch
1/ Edit a YesNo prefs, AutoEmailOpacUser for instance
2/ Set it to "Don't sent"
3/ Check the value in DB, it should be set to an empty string, instead
of 0
4/ Apply this patch and try again. Now the value should be 0

Followed test plan, value is now 0 as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446

--- Comment #16 from Kyle M Hall  ---
Created attachment 46426
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46426=edit
Bug 15446: Update systempreferences rows where type=YesNo and value=''

Signed-off-by: Marc Véron 

Amended to fix typo in sql statement.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446

--- Comment #17 from Kyle M Hall  ---
Created attachment 46427
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46427=edit
Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type

Some occurrences have been pushed in the meantime.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #46104|0   |1
is obsolete||
  Attachment #46105|0   |1
is obsolete||
  Attachment #46107|0   |1
is obsolete||
  Attachment #46268|0   |1
is obsolete||

--- Comment #14 from Kyle M Hall  ---
Created attachment 46424
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46424=edit
Bug 15446: Add tests

Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15473] Koha::Objects->find should find if the key is an empty string

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #46269|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 46423
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46423=edit
Bug 15473: Make Koha::Objects->find accepts 0 and '' as a key

This bug has been found after bug 15381 was pushed:
If you go on authorities/authorities.pl, you expect a form to create a
 authorities with a "Default" authority type.
Now, it explodes:
Can't call method "authtypetext" on an undefined value at
/home/koha/src/authorities/authorities.pl line 665.

Koha::Objects->find does not want to search if the key does not exist
(undef, '', 0). But actually it should only be a coward if it is not defined.

Moreover this is the default behavior of the DBIx::Class find method.

Test plan:
  prove t/db_dependent/Koha/Objects.t
should return green
and
  GET /cgi-bin/koha/authorities/authorities.pl
should not make everything explode.

Signed-off-by: Bernardo Gonzalez Kriegel 
Find this after signing 15470 :)
Test pass, new auth (Default) created, no errors.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15473] Koha::Objects->find should find if the key is an empty string

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] New: OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Bug ID: 15527
   Summary: OAI-PMH should have a stylesheet to aid usability
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 46429
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46429=edit
Original style

Both EPrints and DSpace projects ship XSLT stylesheets that are included in the
OAI response so using a web browser to navigate the repository. We should add
one ourselves.

See the attached screenshots for better understanding this enhancement
proposal.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 46430
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46430=edit
Proposed style

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #45841|0   |1
is obsolete||

--- Comment #11 from Alex Arnaud  ---
Created attachment 46433
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46433=edit
Bug 15261: remove Date::Range and Date::Simple dependencies

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 46435
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46435=edit
Bug 15527: (followup) Allow using custom stylesheets

This patch introduces a syspref to let users choose their own
XSLT stylesheets for the OAI-PMH front end.

Regards

Sponsored-by: Universidad Empresarial Siglo 21

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 46434
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46434=edit
Bug 15527: Add a stylesheet for OAI-PMH to aid usability

This patch introduces an XSLT file grabbed from DSpace and a couple
css files.

To test:

- Point to your dev Koha's oai endpoint. For example:
  http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListMetadataFormats
=> FAIL: Look how ugly it is for humans.
- Apply this patch
- Reload
=> SUCCES: It is styled and provides really useful links to interact with
  the OAI server verbs.
- Sign off :-D

Sponsored-by: Universidad Empresarial Siglo 21

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #14 from sandbo...@biblibre.com  ---
Created attachment 46442
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46442=edit
Bug 15261: remove Date::Range and Date::Simple dependencies

Signed-off-by: delaye 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #13 from sandbo...@biblibre.com  ---
Created attachment 46441
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46441=edit
Bug 15261: Verify if checkouts/reserves requests periods overlap...

... with existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

A user place an hold from opac whose requested period overlap an
existing reserve period => prevent reserve,

A librarian place an hold from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation),

A librarian make a checkout from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation).

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture

1 (staff side):
Place a hold on title (which has only one items) level with start date
and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are warned about an existing reserve

2 (staff side):
Place a hold on title (which has more than one items) level with start
date and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.

3 (staff side):
Place a hold on item level with start date and expiration date.
Place another hold on item level with period overlaping this reserve.
Check you are warned about an existing reserve.

4 (opac side):
Do the same than for staff side. Instead of a warn, reserve is
prevented.

5:
Place a hold on title (which has only one items) level with start date
and expiration date.
Try to checkout the unique item from this title with period overlaping
the reserve period.
Check you are warned about an existing reserve

6:
Place a hold on title (which has more than one items) level with start
date and expiration date.
Checkout an item from this title with period overlaping the reserve
period.
Check you are NOT warned about an existing reserve.

7:
Place a hold on item level with start date and expiration date.
Checkout this item period overlaping the reserve period.
Check you are warned about an existing reserve

Signed-off-by: delaye 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11324] "Delete All Items" fails except on "Normal Tab"

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11324

Ian Palko  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|Failed QA   |RESOLVED

--- Comment #5 from Ian Palko  ---
(In reply to Aleisha Amohia from comment #4)
> I could not reproduce this bug in version 3.23. Must have been fixed? Can
> someone else test if this bug is still valid?

I can confirm, the code seems to have been either copied as Owen suggested, or
other fixes have fixed this.

Marking as Resolved:Invalid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15209] C4::Koha routines expecting a MARC::Record object should check it is defined

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15209

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15209] C4::Koha routines expecting a MARC::Record object should check it is defined

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15209

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #46007|0   |1
is obsolete||
  Attachment #46008|0   |1
is obsolete||
  Attachment #46009|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall  ---
Created attachment 46447
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46447=edit
Bug 15209 Validate passed MARC::Record objs in C4::Koha

Ensure that a passed MARC::Record is defined before calling
its methods. Otherwise you are open to occurences of the
error 'Can't call method "field" on an undefined value'
In a CGI environment you can live with such sloppiness but
in a persistent environment the error can cause the instance
to abort.
Made all routines passed a MARC::Record validate it before calling
its methods. Changed the parameter name from the meaningless
record to marcrecord to indicate its content. Added an explicit return
for all cases where no valid data returned. Cleaned up some logic for
clarity. I think we can assume that GetNormalizedOCLCNumber meant to
look at all 035s till it found an OCLC number not just the first.

Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15209] C4::Koha routines expecting a MARC::Record object should check it is defined

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15209

--- Comment #6 from Kyle M Hall  ---
Created attachment 46448
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46448=edit
Bug 15209: Add tests

Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15522] New interface for revamped circulation rules

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15472] Do not display links to circulation.pl if remaining_permissions is not set

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472

Marc Véron  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 46438
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46438=edit
Bug 15527: (followup) Avoid replacing spaces for non-breaking spaces

This causes the template not to wrap long lines correctly,

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752

--- Comment #3 from Nick Clemens  ---
Created attachment 46439
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46439=edit
Bug 14752 - (QA Followup) Use input type="number" and small update to error
modal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358

--- Comment #18 from Ian Palko  ---
(In reply to Jonathan Druart from comment #15)
> (In reply to Ian Palko from comment #13)
> > I've manually edited the relevant files in accordance with Julian's patches
> > here.
> 
> Please, help yourself, don't do that :)
> git is your friend and can help you.

I know...

Eventually that will happen. For now, I need a backup server at the ready "just
in case", as we have had some issues with the production server. It will be
replaced (fingers crossed) thus summer when we move to a new building with a
new server waiting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530

--- Comment #4 from Kyle M Hall  ---
Created attachment 46446
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46446=edit
Bug 15530 - Editing a course item via a disabled course disables it even if it
is on other enabled courses

It appears that if the course item is edited by clicking the edit link
from an active course, the course item will be set to enabled and the
fields will be swapped, if the same course item is edited from a course
that is *not* active, the course item will be set to *not* enabled, and
the original fields will be swapped back in!

The short term work-around is to only edit course items from an enabled
course if the item has a course that is enabled. If all the courses it
is on are disabled, it doesn't matter what course the item is edited
from.

Test Plan:
1) Create two courses, 1 enabled and 1 disabled
2) Add an item as a course reserve to both courses
3) Edit the course reserve data for the item via the enabled course
4) Note the course item is enabled ( easy way is to check the database )
5) Edit the same course reserve data, but via the disabled course
6) Note the course item is now disabled even though it is part of
   an enabled course!
7) Apply this patch
8) Repeat steps 1 through 5
9) Note the course item is still enabled

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/