[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358

--- Comment #28 from Jonathan Druart  
---
(In reply to Nick Clemens from comment #27)
> A test plan would be appreciated (even if as simple as 'Merge two
> authorities')
> 
> I get this error when merging authorities:
> Software error:
> 
> Subfields are only for data fields (generally, just tags >= 010) at
> /home/vagrant/kohaclone/C4/AuthoritiesMarc.pm line 1488.

I had a very quick look at the code and I'd say that it existed prior to bug
8064, could you test on a 3.20 release and confirm that the bug already
existed?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #3 from Marcel de Rooy  ---
Created attachment 46688
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46688=edit
Bug 15545: Optionally require notes when placing a hold

This report adds three cases where you could want to require a note when
placing a hold. Each of these cases may be enabled separately via the
system preference HoldNoteReasons. (The hold note itself is triggered
by OpacHoldNotes.)

These three cases are:
[1] serial indication in the leader (called LEADER_SERIAL)
[2] collection indication in the leader (LEADER_COLLECTION)
[3] MARC 300$a contains an indication of multiple parts/volumes, as
identified by a regular expression (MARC300A_PARTS).

The new sub IsHoldNoteRequired in Reserves.pm handles these cases. And will
be easily extensible.
Also this patch removes some unused code in the reserves template for
mandatory hold notes reasons.

Test plan:
[1] Enable OpacHoldNotes. Set HoldNoteReasons to LEADER_SERIAL.
[2] In OPAC, place a hold on a serial record (with correct leader).
Verify that the hold notes are required.
[3] Set HoldNoteReasons to MARC300A_PARTS.
Verify that the hold notes are no longer required for the record in
the preceding step. (This actually depends on your 300$a..)
Cancel the hold you placed.
[4] Add "2 vols" to MARC 300$a in the same record.
Try to place the hold again. The hold notes should be required again.
[5] Place a multiple hold request with the same record and another one.
Click Place Hold while more-options is collapsed (blank notes).
Is the correct hold note made visible?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11557] Collector bug for Academy bootstrap3 upgrading work

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11557

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||15581


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581
[Bug 15581] Add a circ rule to limit the auto renewals given a delay
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15581] New: Add a circ rule to limit the auto renewals given a delay

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581

Bug ID: 15581
   Summary: Add a circ rule to limit the auto renewals given a
delay
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
Blocks: 11557

A new column issuingrules.no_auto_renewal_after will allow to restrict the auto
renewals based on a delay.
For instance, if the issue date is 10 days before today, and
no_auto_renewal_after is set to 10, tomorrow the issue won't be auto renewed.


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11557
[Bug 11557] Collector bug for Academy bootstrap3 upgrading work
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581

Jonathan Druart  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285

--- Comment #13 from Jonathan Druart  
---
(In reply to Marc Véron from comment #11)
> Created attachment 46683 [details]
> Screenshots table 'All funds'
> 
> With patch the table "All funds" looks weird.

Thanks, good catch!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568

Jonathan Druart  changed:

   What|Removed |Added

 Depends on|14295   |15295


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14295
[Bug 14295] Add creation time, size and owner for uploaded files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295
[Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431

Zeno Tajoli  changed:

   What|Removed |Added

  Text to go in the|This bug appears only in|This bug appears only in
  release notes|3.20.7 version and is very  |3.20.7 version and is very
   |visible (or invisible) and  |visible (or invisible). It
   |disturbing. It has been |has been discussed several
   |discussed several times on  |times on Koha mailing list:
   |Koha mailing list: after a  |after a package upgrade to
   |package upgrade to the 3.20 |the 3.20 branch last
   |branch last version, the|version, the check-out
   |check-out screen doesn't|screen doesn't display
   |display anymore the |anymore the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #183 from Jonathan Druart  
---
(In reply to Blou from comment #176)
> Of course, we're now at 180 comments and counting, so there's a side of me
> that would like to see that keep increasing and beat a record of some sort. 
> ;-)

Don't worry about that, we won't reach it (there are 247 comments on bug 7167
and it as been abandoned, there is another one with more than 500 comments
iirc).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14834] Add range parameters to membership_expiry cronjob

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14834

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #4 from Marcel de Rooy  ---
Does not apply anymore. Rebasing this soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581

--- Comment #2 from Jonathan Druart  
---
Created attachment 46691
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46691=edit
Bug 15581: Display the latest auto renew date possible when renewing manually

If an issue marked as auto_renew is renewed manually, we want to display
the latest auto renew date possible.

Test plan:
1/ Define circ rules as in the previous patch.
2/ Check a item out, mark it as an auto renewal
3/ Back date the issuedate and make sure it will be too late to renew it
4/ Use the Circulation > renew page (circ/renew.pl) to manually renew
this issue.
You should get a warning "You barcode has been scheduled for automatic renewal
and cannot be renewed anymore since DATE."
If the pref AllowRenewalLimitOverride is set, you will be allowed to
renew it anyway.

Sponsored-by: University of the Arts London

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581

--- Comment #3 from Jonathan Druart  
---
Created attachment 46692
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46692=edit
Bug 15581: [DO NOT PUSH] Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581

--- Comment #1 from Jonathan Druart  
---
Created attachment 46690
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46690=edit
Bug 15581: Add a circ rule to limit the auto renewals given a delay

This patch adds a new circulation rule (no_auto_renewal_after) to block/allow
auto renewals after a given delay.
For instance, if the issue date is 10 days before today, and
no_auto_renewal_after is set to 10, tomorrow the issue won't be auto
renewed.

Test plan:
0/ Execute the update DB entry
Note: You will have to manually change data in your DB, make sure you
have access to the sql cli.
1/ Define a rule with no_auto_renewal_after (10 for instance) and
norenewalbefore (5 for instance).
(This new rule will behave the same as norenewalbefore: the unit depends
on the lengthunit value).
The automatic renewals will be done from 5 to 10 days ahead.
2/ Modify the issues.issuedate, to simulate a checkout in the past:
UPDATE issues
SET issuedate = "-mm-dd hh:mm:ss"
WHERE itemnumber = YOUR_ITEMNUMBER;
with issuedate = 2 days before for instance
3/ Execute the automatic renewals cronjob script
(misc/cronjobs/automatic_renewals.pl)
Confirm that the issue has not been renewed (too soon)
4/ Repeat step 2 with a due date set as 11 days before
5/ Execute the automatic renewals cronjob script
(misc/cronjobs/automatic_renewals.pl)
Confirm that the issue has not been renewed (too late)
6/ Repeat step 2 with a due date set as 7 days before
7/ Execute the automatic renewals cronjob script
(misc/cronjobs/automatic_renewals.pl)
Confirm that the issue has been renewed (issues.renewals has been
incremented and date_due has been updated according your circ rules).

Sponsored-by: University of the Arts London

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15582] Ability to block auto renewals if the max outstanding balance is reached

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582

--- Comment #1 from Jonathan Druart  
---
Created attachment 46693
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46693=edit
Bug 15582: Ability to block auto renewals if the max outstanding balance is
reached

If a patron owes more than the max outstanding balance (defined in the
maxoutstanding syspref), the issue won't be auto renewed anymore (driven
by the new pref MaxOutstandingBlockAutoRenew).

Test plan:
Note: You will have to manually change data in your DB, make sure you
have access to the sql cli.
1/ Set the maxoutstanding to 5 (for instance)
2/ Set MaxOutstandingBlockAutoRenew to block
3/ Check an item out to a patron and mark is as an auto renewal
4/ Make sure the patron does not have any fees or charges.
5/ Execute the automatic renewals cronjob script
(misc/cronjobs/automatic_renewals.pl)
Confirm that the issue has been renewed
6/ Create an invoice for this patron with a amount > maxoustanding (6
for instance)
7/ Execute the automatic renewals cronjob script
(misc/cronjobs/automatic_renewals.pl)
Confirm that the issue has not been renewed.
8/ Set MaxOutstandingBlockAutoRenew to allow
9/ Execute the automatic renewals cronjob script
(misc/cronjobs/automatic_renewals.pl)
Confirm that the issue has been renewed

Sponsored-by: University of the Arts London

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15582] Ability to block auto renewals if the max outstanding balance is reached

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582

--- Comment #2 from Jonathan Druart  
---
Created attachment 46694
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46694=edit
Bug 15582: DB changes - add new pref MaxOutstandingBlockAutoRenew

Sponsored-by: University of the Arts London

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15582] Ability to block auto renewals if the max outstanding balance is reached

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572

--- Comment #16 from Jonathan Druart  
---
The patches are for master, 3.22.x, 3.20.x and 3.18.x
It would be good to have it into the next stable releases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431

Frédéric Demians  changed:

   What|Removed |Added

  Text to go in the|This bug appears only in|This bug appears only in
  release notes|3.20.7 version and is very  |3.20.7 version and is very
   |visible (or invisible) and  |visible (or invisible) and
   |disturbing. It has been |disturbing. It has been
   |discussed several times on  |discussed several times on
   |Koha mailing list: after a  |Koha mailing list: after a
   |package upgrade to the 3.20 |package upgrade to the 3.20
   |branch last version, the|branch last version, the
   |check-out screen doesn't|check-out screen doesn't
   |display anymore the |display anymore the

--- Comment #6 from Frédéric Demians  ---
> Hi Frederic, it looks like the text of the new release notes field might
> been cut off?

Yes. Chris is investigating...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569

--- Comment #6 from Marc Véron  ---
(In reply to Jonathan Druart from comment #5)
> (In reply to Marc Véron from comment #4)
> > Question: When renewals are not possible, should the form field "Renewal due
> > date: ..." be removed as well?
> 
> At the bottom of the table, that's it (not auto renewal related)?

Yes, at the bottom of the table. It was just a question - I think this should
have it's own bug (if we decide to remove it).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11557] Collector bug for Academy bootstrap3 upgrading work

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11557

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||15582


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582
[Bug 15582] Ability to block auto renewals if the max outstanding balance is
reached
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15582] New: Ability to block auto renewals if the max outstanding balance is reached

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582

Bug ID: 15582
   Summary: Ability to block auto renewals if the max outstanding
balance is reached
 Change sponsored?: Sponsored
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
Blocks: 11557

If a patron owes more than the max outstanding balance (defined in the
maxoutstanding syspref), the issue won't be auto renewed anymore (driven by a
new syspref).


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11557
[Bug 11557] Collector bug for Academy bootstrap3 upgrading work
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431

Zeno Tajoli  changed:

   What|Removed |Added

  Text to go in the|This bug appears only in|This bug appears only in
  release notes|3.20.7 version and is very  |3.20.7 version and is very
   |visible (or invisible) and  |visible (or invisible) and
   |disturbing. It has been |disturbing. It has been
   |discussed several times on  |discussed several times on
   |Koha mailing list: after a  |Koha mailing list: after a
   |package upgrade to the 3.20 |package upgrade to the 3.20
   |branch last version, the|branch last version, the
   |check-out screen doesn't|check-out screen doesn't
   |display anymore the |display anymore the problem
 CC||z.taj...@cineca.it

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #129 from Jonathan Druart  
---
I think we need to talk together when a developer wants to introduce a new
practice.
On comment 79, I have suggested to have this discussion during the next (?) dev
meeting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #2 from Frédéric Demians  ---
I can't make it work on master. Commit 347d12c41f9ebe may have broken
Koha::Logger on master. For me, the logger is never instantiated. After
modifying Koha::Logger to bypass conf file checking, I get a result in the OPAC
log file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431

Zeno Tajoli  changed:

   What|Removed |Added

  Text to go in the|This bug appears only in|This bug appears only in
  release notes|3.20.7 version and is very  |3.20.7 version and is very
   |visible (or invisible). It  |visible (or invisible) and
   |has been discussed several  |disturbing. It has been
   |times on Koha mailing list: |discussed several times on
   |after a package upgrade to  |Koha mailing list: after a
   |the 3.20 branch last|package upgrade to the 3.20
   |version, the check-out  |branch last version, the
   |screen doesn't display  |check-out screen doesn't
   |anymore the problem.|display anymore the
   ||problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #130 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #129)
> I think we need to talk together when a developer wants to introduce a new
> practice.
> On comment 79, I have suggested to have this discussion during the next (?)
> dev meeting.

Jonathan, again, this is *not* a new practice! As I wrote previously, the
following scripts use this same methodology:
modrequest.pl
placerequest.pl
modrequest_suspendall.pl
add_message.pl
deletemem.pl
mod_debarment.pl
setstatus.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15582] Ability to block auto renewals if the max outstanding balance is reached

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||15581


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581
[Bug 15581] Add a circ rule to limit the auto renewals given a delay
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15570] circ/renew.pl is broken

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15570

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15581


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581
[Bug 15581] Add a circ rule to limit the auto renewals given a delay
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Kyle M Hall  changed:

   What|Removed |Added

 Status|ASSIGNED|In Discussion

--- Comment #184 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #182)
> Kyle, can we imagine to make an exception for this one, open a new bug
> report to move the new module to the Koha namespace and ask for the author
> to commit to submit a patch?

Yes! I set this bug to in discussion while we were actually discussing the
issue. I purposefully did not set it to failed qa.

My fear is that if this is pushed as is, there is no impetus for the namespace
to be fixed. All I'd like to see is a commitment from someone that the patches
to move this to a better namespace *will be submitted*, preferably before the
next major release if possible. So far I haven't seen anyone make that
commitment. I should have written that more clearly than I had.

Philippe, if you can vouch that Charles or someone will submit the patch to
move this module to a new namespace, I have no problem with it proceeding as
is. Now would be the time to file the followup bug report and assign it to the
proper person. If this works for you please go ahead and reset the status to
Signed Off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15582


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582
[Bug 15582] Ability to block auto renewals if the max outstanding balance is
reached
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||15568, 15570


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568
[Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15570
[Bug 15570] circ/renew.pl is broken
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15581


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581
[Bug 15581] Add a circ rule to limit the auto renewals given a delay
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569

--- Comment #5 from Jonathan Druart  
---
(In reply to Marc Véron from comment #4)
> Question: When renewals are not possible, should the form field "Renewal due
> date: ..." be removed as well?

At the bottom of the table, that's it (not auto renewal related)?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #2 from Marcel de Rooy  ---
Created attachment 46687
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46687=edit
Bug 15545: Database revision for HoldNoteReasons pref

Adds a new preference.

Test plan:
Run the db revision.
Check the pref in the interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #4 from Marcel de Rooy  ---
Created attachment 46689
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46689=edit
Bug 15545: Unit test for IsHoldNoteRequired

Adds unit test.

Test plan:
Run the test t/db../Reserves/IsHoldNoteRequired.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #182 from Jonathan Druart  
---
Kyle, can we imagine to make an exception for this one, open a new bug report
to move the new module to the Koha namespace and ask for the author to commit
to submit a patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15568


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568
[Bug 15568] Circ rules are not displayed anymore
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14295] Add creation time, size and owner for uploaded files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14295

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|15568   |


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568
[Bug 15568] Circ rules are not displayed anymore
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15583] New: List of lists in the staff client should have a default sort

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15583

Bug ID: 15583
   Summary: List of lists in the staff client should have a
default sort
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Lists
  Assignee: gmcha...@gmail.com
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

The list of lists in the staff client seems to default to a sort by
shelfnumber. While it may make sense to sort lists by creation date, I think in
that case the DataTable should be configured to explicitly sort by creation
date rather than have there be no visible sense to the default sort.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #188 from Katrin Fischer  ---
While I have put coding guideline additions on the agenda a lot of times in the
past, I don't believe that we can ever have a complete set of rules that will
fit every situation and possible question.

Another common practice we QA has used where they haven't been sure about
something is asking for more opinions - I think this has helped in a lot of
cases to get more views and a better picture of the problem and possible
solutions.

That said, I am happy with the 2 step approach here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14935] waiting and in transit items cannot be reserved

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14935

--- Comment #2 from Katrin Fischer  ---
Hi Team Lyon - please prefer the older bug if there are patches/discussion on
it, unless there is a need to start over, when resolving a bug as a duplicate.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
Version|unspecified |master

--- Comment #2 from Owen Leonard  ---
I don't think this is the right solution for what is currently a messy problem. 

As I understand it, the current "allow on shelf holds" feature will let you
place a hold if *any* of multiple items is unavailable. I understand that this
is The Way It Has Been, but the description of the option in and the
documentation do NOT make it explicit that this is the behavior.

My initial reaction to this patch is that it's trying to make "allow on shelf
holds" work the way it is actually described rather than how it really works.
Do libraries who use the "allow on shelf holds" feature *want* it to work that
way, or do they use it because it's better than nothing?

I think having two settings, "allow on shelf holds" and "allow hold if others
available" is needlessly confusing. On the face of it they both look like they
do exactly the same thing, and I have no idea how they're supposed to work in
conjunction with each other.

In my test of this patch I set a global all item types/all patron categories
rule with both "allow on shelf holds" and "allow hold if others available" set
to "no." However, I was able to place a hold on a title which has one
checked-out item and three available. I don't think that's right.

There have been other discussions of this issue too which should be taken into
account: Bug 6837 and Bug 9190. If we bring it all together is there a single
solution which can accommodate everyone's needs?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979

Alex Arnaud  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |alex.arn...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Blou  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

--- Comment #185 from Blou  ---
This is not a problem for us.  To be sure, just create the new bug and assign
it to me immediately.  I assure you you'll get a patch within a week after this
has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #186 from Kyle M Hall  ---
(In reply to Blou from comment #185)
> This is not a problem for us.  To be sure, just create the new bug and
> assign it to me immediately.  I assure you you'll get a patch within a week
> after this has been pushed to master.

Thanks! I'll go ahead and take care of that!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8964] AllowHoldsOnDamagedItems and AllowOnShelfHolds don't work with Professional category type

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8964

--- Comment #2 from Owen Leonard  ---
Is this bug still valid now that the AllowOnShelfHolds system preferences is in
circulation and fine rules? (Bug 5786)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11321] "On hold" items can't be placed on hold with allowonshelfholds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11321

Owen Leonard  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979

--- Comment #13 from Alex Arnaud  ---
Created attachment 46698
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46698=edit
Bug 6979 - Handle multiple branches in non-auth_by_bin

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting items cannot be reserved

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Katrin Fischer  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting items cannot be reserved

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Owen Leonard  changed:

   What|Removed |Added

   Attachment #4329|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15403] Confirm messages in intranet lists interface strangely worded

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15403

Owen Leonard  changed:

   What|Removed |Added

  Attachment #46627|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 46695
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46695=edit
[SIGNED-OFF] Bug 15403: Tidy up error messages in Staff lists

To test:
1) Create a list on the intranet, observe the message
2) Create another list with the same name, observe the message
3) Delete a list, observe the message
4) Check the patch itself for typos

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15403] Confirm messages in intranet lists interface strangely worded

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15403

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295

Nick Clemens  changed:

   What|Removed |Added

  Attachment #46684|0   |1
is obsolete||

--- Comment #32 from Nick Clemens  ---
Created attachment 46696
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46696=edit
[SIGNED-OFF] Bug 15295: (follow-up) Koha::Libraries - Remove GetBranchesCount

Fix conflict with bug 11625

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568

Nick Clemens  changed:

   What|Removed |Added

  Attachment #46685|0   |1
is obsolete||

--- Comment #11 from Nick Clemens  ---
Created attachment 46697
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46697=edit
[SIGNED-OFF] Bug 15568: Fix display default circ rules

To reproduce:
Go on the admin circ rules page (admin/smart-rules.pl), switch the
dropdown list from specific to "all libraries".
The rules are not displayed anymore.

Test plan:
Apply this patch and confirm that the rules are now displayed correctly.
Make sure the enh introduced by bug 11625 is not broken.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #11 from Nicole C. Engard  ---
That new patch doesn't apply either :(

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 15434: Search criteria definition table
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
error: The following untracked working tree files would be overwritten by
merge:
koha-tmpl/opac-tmpl/bootstrap/js/search.js
Please move or remove them before you can merge.
Aborting
Failed to merge in the changes.
Patch failed at 0001 Bug 15434: Search criteria definition table
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-15434-Search-criteria-definition-table-K9mxpF.patch
08:10 ~/kohaclone (bug15434-qa %|AM u=)$

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837

--- Comment #23 from Owen Leonard  ---
Is this bug invalid since the AllowOnShelfHolds system preferences is now in
circulation and fine rules? (Bug 5786)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9190] Problem with holds - allow place a hold without all items checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9190

--- Comment #9 from Owen Leonard  ---
What is the status of this bug since Bug 5786 has moved the AllowOnShelfHolds
system preferences to circulation and fine rules?

How does this relate to Bug 15534?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7970] Allow OPAC holds per library policy without default rule

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7970

Owen Leonard  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #187 from Kyle M Hall  ---
(In reply to Chris Cormack from comment #179)
> Hopefully this new super strict QA standard will be across the board and I
> won't see people pushing patches they wrote skipping qa steps anymore.

I'd like to address this. I'm not in favor of super strict QA standards. What
I'm in favor of are transparent, standardized, and consistently applied QA
rules.

My experience as a developer has informed my work as a QA team member. I have
had to rewrite C4 modules as Koha modules, I've asked others to rewrite C4
modules as Koha modules. Code quality guidelines should be completely divorced
from the necessity or popularity of a bugfix or feature.

I think our coding guidelines need a bit of a revamp to make sure all of the
things we've taken for granted as being necessary to pass QA are actually in
the coding guidelines. If a QA team member fails QA on a patch, the QA'er
should be able to link directly to the reason and explanation for it failing
QA. If the QA'er believes the patch should fail QA but the reason is not part
of the coding guidelines, then a meeting should be called, a vote should be
made, and a new rule added to the guidelines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||8753


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753
[Bug 8753] Add forgot password link to OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||15585


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585
[Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15585] New: Move C4::Passwordrecovery to Koha::Patron::Password::Reset

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585

Bug ID: 15585
   Summary: Move C4::Passwordrecovery to
Koha::Patron::Password::Reset
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Bug 8753 introduces a new C4 module. This module should be moved to the Koha
namespace. It looks like Koha::Patron::Password::Reset would be the most
appropriate namespace, as the feature allows for password resets rather than
being able to recover the original password.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #189 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #188)
> While I have put coding guideline additions on the agenda a lot of times in
> the past, I don't believe that we can ever have a complete set of rules that
> will fit every situation and possible question.
> 
> Another common practice we QA has used where they haven't been sure about
> something is asking for more opinions - I think this has helped in a lot of
> cases to get more views and a better picture of the problem and possible
> solutions.

That simply highlights the problem. With this methodology, a developer will not
know if code will pass qa or not until it has been written and submitted.

I agree, we will never have a complete set of rules, but we can build that set
as we go. The more we have written down for developers to be aware in advance,
the better. We need documented guidelines. The approach of "this doesn't feel
right to me" just doesn't work any more. It can only lead to future frustration
for developers. We can't have one set of rules for bug A and another set of
rules for bug B.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837

--- Comment #24 from Katrin Fischer  ---
Yes, the behaviour has not changed with the move - but I think Kyle is working
on something that will resolve this on another bug report. I will try to dig it
up later.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8372] Move AllowOnShelfHolds at granular level

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8372

Owen Leonard  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14935] waiting and in transit items cannot be reserved

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14935

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 4319 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979

Alex Arnaud  changed:

   What|Removed |Added

   Priority|PATCH-Sent (DO NOT USE) |P1 - high
 Status|Failed QA   |Needs Signoff
Version|3.4 |master

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting items cannot be reserved

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #26 from Katrin Fischer  ---
*** Bug 14935 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #5 from Owen Leonard  ---
Would the need for this feature be eliminated if it was possible to limit
item-level holds to the types of records defined in this patch? That is,
serials, titles with volumes, etc?

If so, shouldn't we be solving that problem instead?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15584] New: Staff client list errors are incorrectly styled

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584

Bug ID: 15584
   Summary: Staff client list errors are incorrectly styled
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Lists
  Assignee: gmcha...@gmail.com
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

When an error is triggered by the lists system in the staff client the "dialog"
 has the wrong class. It has  but the correct
class is 

The message or alert class is a template variable, so the script will have to
be modified.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #190 from Katrin Fischer  ---
I think we are actually not in disagreement - I just want to warn about wanting
to solve everything with rules. That will be trying for the impossible. And a
20 pages catalog of guidelines... is kind of scaring away devs too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15576] Link in OPAC redirects to the wrong page

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15576

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15577] Link in OPAC doesn't redirect anywhere

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15577

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15576] Link in OPAC redirects to the wrong page

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15576

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #46669|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 46708
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46708=edit
Bug 15576: Fix for incorrect link redirect

To test:

1) Edit a user to have an uncertain address (gone no address)
2) Log in as that user on OPAC
3) Click 'online update form' link in the yellow message
4) Confirm you are taken to opac-memberentry.pl

Signed-off-by: Hector Castro 
Works as described

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13177] Add help pages for Rotating collections

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13177

--- Comment #9 from Kyle M Hall  ---
Created attachment 46710
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46710=edit
Bug 13177: Accidental copy/paste error fix

Confirm it now says Rotating Collections instead of Patron Import in the last
line, and the link is correct.

Signed-off-by: Nicole Engard 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13177] Add help pages for Rotating collections

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13177

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #4|0   |1
is obsolete||
  Attachment #46667|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall  ---
Created attachment 46709
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46709=edit
Bug 13177: Help page for Rotating Collections

To test:

Go to Tools -> Rotating Collections and click Help in the top-right. Confirm
the Help page shows and gives correct accurate instructions with no typos or
grammatical errors.

Help displays as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Nicole Engard 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13177] Add help pages for Rotating collections

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13177

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

--- Comment #4 from Owen Leonard  ---
This looks useful. I'm not crazy about additions to Koha which require the user
to set configurations in this manner because I think it's no very friendly. A
better choice, I think, would be to build a separate page as a front-end for
the preference, displaying a form with paired dropdown menus listing existing
shelving locations.

I see a couple of problems with the functionality as it is here:

1. I think there are bound to be conflicts with the  InProcessingToShelvingCart
and ReturnToShelvingCart system preferences. I'm guessing the functionality of
those preferences can be fully replaced by that of this patch, but a migration
system will have to be built.

2. If this patch is approved without an improved interface like I describe, it
needs to be made clear what empty values are meant to do. For instance:

PROC:

or

:PROC

Should that work?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15550] Authority type pull down in OPAC authority search is empty

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #46561|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 46714
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46714=edit
Bug 15550: Fix authority search and detail at the OPAC

The author of Bug 15381 (me!) has mismatch the objects he was
manipulating and forgotten to update a template.
for the opac-aythorities-home, the variable is named authority_types,
not authtypesloop.
In opac-authoritiesdetail.pl, the $record is a MARC::Record and there is
no authtypecode method. We need to retrieve the authtypecode using
the new Koha::Authorities module.

Test plan:
Search for authorities at the OPAC and click on the detail link to go to
the detail page.
Without this patch, you will get errors.
With this patch, the errors should have gone and everything should work
as before bug 15381.

Signed-off-by: Hector Castro 
Works as described. Pull down for choosing the auth_type displayed again

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15550] Authority type pull down in OPAC authority search is empty

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15323] ./t/Prices.t fails without a valid database

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15323

Larry Baerveldt  changed:

   What|Removed |Added

 CC||la...@bywatersolutions.com

--- Comment #5 from Larry Baerveldt  ---
I've seen this error too when attempting to build a package. Version tested was
3.20.06. Here's the test failure message:

DBI connect('dbname=koha;host=localhost;port=3306','kohaadmin',...) failed:
Can't connect to local MySQL server through socket
'/var/run/mysqld/mysqld.sock' (2) at /usr/share/perl5/DBIx/Connector.pm line
32.
Can't call method "do" on unblessed reference at
/tmp/buildd/koha-3.20.06+20160114144139.2d762685/blib/PERL_MODULE_DIR/C4/Context.pm
line 793.
# Child (Configuration 1: 0 0) exited without calling finalize()

#   Failed test 'Configuration 1: 0 0'
#   at /usr/share/perl/5.20/Test/Builder.pm line 276.
# Looks like you planned 16 tests but ran 5.
# Looks like you failed 1 test of 5 run.
# Looks like your test exited with 255 just after 5.
t/Prices.t .. 
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 12/16 subtests 
t/Print.t ... ok

...
Test Summary Report
---
t/Prices.t(Wstat: 65280 Tests: 5 Failed: 1)
  Failed test:  5
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 16 tests but ran 5.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #46494|0   |1
is obsolete||
  Attachment #46495|0   |1
is obsolete||

--- Comment #18 from Kyle M Hall  ---
Created attachment 46717
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46717=edit
Bug 15542: Always display the patron's info the same way.

The patron's information displayed in the member module
(includes/circ-menu.inc and includes/member-display-address-style-*.inc)
are not always displayed the same way.
Sometimes the streetnumber is missing, sometimes it's the streettype.
Sometimes the streettype is after the address, sometimes before...

Test plan:
Go on a patron detail page, and open all the tabs on the left (Check
out, Fines, Notices, etc.)
Without this patch, the patron's info displayed will differ from one page to
another.
With this patch, they will be displayed the same everywhere.

Followed test plan, works as expected. (Tested both patches together.)
Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542

--- Comment #20 from Kyle M Hall  ---
Created attachment 46719
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46719=edit
Bug 15542 [QA Followup] - Fix code error

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542

--- Comment #19 from Kyle M Hall  ---
Created attachment 46718
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46718=edit
Bug 15542: Change for the German style address format

Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #46720|0   |1
is obsolete||

--- Comment #22 from Kyle M Hall  ---
Created attachment 46721
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46721=edit
Bug 15542 [QA Followup] - Tidy member-password.pl

No other patches in process modify member-password.pl, now would be
a great time to tidy it!

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542

--- Comment #21 from Kyle M Hall  ---
Created attachment 46720
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46720=edit
Bug 15542 [QA Followup] - Tidy member-password.pl

No other patches in process modify member-password.pl, now would be
a great time to tidy it!

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #9 from Kyle M Hall  ---
Still waiting for QAM's opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15526] Drop nozebra database table

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15526

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #46506|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 46722
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46722=edit
Bug 15526: drop table nozebra

This table is not used anymore and can be removed.

Test plan:
In your sql cli:
  SHOW TABLES;
should return nozebra if your DB has been created before bug 7440.

Apply this patch and execute the update DB entry.
Now the table should have been dropped.

Signed-off-by: Aleisha 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15526] Drop nozebra database table

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15526

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13534] Deleting staff patron will delete tags approved by this patron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13534

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #11 from Owen Leonard  ---
(In reply to Nick Clemens from comment #1)
> 8 - Register a patron with a password, your password should be used

At this step I'm getting an error:

DBIx::Class::Row::store_column(): No such column 'password2' on
Koha::Schema::Result::BorrowerModification at
/home/oleonard/kohaclone/Koha/Borrower/Modifications.pm line 65

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15458] Marc21 leader 07 error in translation: "a- Serial component" part is not in format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15458

Frédéric Demians  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #6 from Frédéric Demians  ---
Patch for bug 14201 hasn't been pushed to stable (3.22). That's the reason why
it hasn't been examined to be pushed to 3.20. It's Julian responsibility to
push or not this patch to its branch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658

--- Comment #19 from Owen Leonard  ---
(In reply to Jesse Weaver from comment #16)
> Created attachment 46352 [details] [review]
> Bug 14658: (followup) fix issue with list context on DBIC call

Is this bug set to 'needs signoff' because of this follow-up? If so, is there a
test plan for the follow-up?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #29611|0   |1
is obsolete||

--- Comment #11 from Kyle M Hall  ---
Created attachment 46715
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46715=edit
Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves
is off

If the user knows the URL for OPAC lists they can access them even with
the virtualshelves preference turned off. This patch copies the solution
added to opac-topissues.pl by Bug 10595 and applies it to OPAC lists
pages.

To test, apply the patch and set the virtualshelves system preference to
"don't allow."

- Navigate to /cgi-bin/koha/opac-shelves.pl. You should be redirected to
  an Error 404 page.
- Also check:
  - /cgi-bin/koha/opac-shareshelf.pl.
  - /cgi-bin/koha/opac-downloadshelf.pl
  - /cgi-bin/koha/opac-sendshelf.pl
  - /cgi-bin/koha/opac-addbybiblionumber.pl
- Turn virtualshelves back on. Access to lists and list sharing should
  be restored.

Signed-off-by: Aleisha 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/