[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

--- Comment #25 from Mirko Tietgen  ---
Created attachment 46742
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46742=edit
Bug 15303 Use --staging during development to circumvent limits

The --staging parameter uses the LE test server. This is only for testing,
not supposed to go into master, no signoff needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15533] Allow patrons and librarians to select itemtype when placing hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #4 from Kyle M Hall  ---
I'm having no trouble applying the patch. Did you apply it's dependency ( Bug
15532 ) first?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

Mirko Tietgen  changed:

   What|Removed |Added

 Blocks||15587


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15587
[Bug 15587] Unstable letsencrypt_x.x.x-x_all.deb testing
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15587] Unstable letsencrypt_x.x.x-x_all.deb testing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15587

Mirko Tietgen  changed:

   What|Removed |Added

 Depends on||15303


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303
[Bug 15303] Letsencrypt option for Debian package installations
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15587] Unstable letsencrypt_x.x.x-x_all.deb testing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15587

Mirko Tietgen  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13552] Added: debarredcomment and debarreddate in batch patrons modification

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15587] Unstable letsencrypt_x.x.x-x_all.deb testing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15587

--- Comment #1 from Mirko Tietgen  ---
Created attachment 46743
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46743=edit
Bug 15587 Unstable letsencrypt_x.x.x-x_all.deb testing

Apply on top of bug 15303!

* only one commandline parameter left:
** --letsencrypt replaces --force-https: use LE
** old --letsencrypt (folder path) obsolete
* dependency: letsencrypt debian package

Test plan:

- apply bug 15303
- apply this patch
- enable debian unstable repository
- install package letsencrypt and dependencies
- remove debian unstable repository
- create koha instance
  koha-create --create-db --letsencrypt 
- follow test plan on bug 15303 where applicable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534

--- Comment #3 from Kyle M Hall  ---
(In reply to Owen Leonard from comment #2)

I think we can establish right now that we can't change the shelf holds
behavior. It has been this way so long that it is a fundamental part of how
Koha works. We can however, add an alternative.

I think the basic issue is that shelfholds = no and
allow_hold_if_items_available are fundamentally at odss with each other and
should be mutually exclusive. I had though to somehow extend shelfholds, but
it's inner workings are completely different than what is needed for
allow_hold_if_items_available.

It *would* be possible for an additional option in on shelf holds allowed, so
the choices would be:
Yes
Only if at least one item is unavailable
Only if all itmes are unavailble

This would require a bit more code, changing all the shelfhold checks from if
$shelfholds to if $shelfholds == 1, but that isn't too onerous a change.

Then I could remove my new rule and use the existing shelfholds rule for the
new logic code.

How does that sound Owen?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15587] New: Unstable letsencrypt_x.x.x-x_all.deb testing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15587

Bug ID: 15587
   Summary: Unstable letsencrypt_x.x.x-x_all.deb testing
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: gmcha...@gmail.com
  Reporter: mi...@abunchofthings.net
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

This bug is to test bug 15303 with the Debian package for letsencrypt.

It is only available in unstable so far. To test this, you need to mix Jessie
and unstable sources.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15533] Allow patrons and librarians to select itemtype when placing hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533

Kyle M Hall  changed:

   What|Removed |Added

 Status|In Discussion   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #46747|0   |1
is obsolete||

--- Comment #32 from Mirko Tietgen  ---
Created attachment 46750
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46750=edit
Bug 15303 Workaround to use git ckeckout

The Debian package letsencrypt is only available in unstable at the moment.

To test without letsencrypt package:

- apply this patch before you build the package
- on the test vm/server:
-- get letsencrypt via git
   git clone https://github.com/letsencrypt/letsencrypt
-- create a symlink from /usr/bin/letsencrypt to letsencrypt-auto
   sudo ln -s /path/to/letsencrypt/letsencrypt-auto /usr/bin/letsencrypt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941

Chris Cormack  changed:

   What|Removed |Added

  Attachment #46313|0   |1
is obsolete||

--- Comment #19 from Chris Cormack  ---
Created attachment 46757
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46757=edit
Bug 4941: Remove the singleBranchMode system preference

The singleBranchMode system preference does not make sense.
Either the install has only 1 library defined or several. In both case,
we can easily guess the behavior to follow.

So the idea of this patch is to replace the fetch of this syspref with a
call to count the number of libraries defined in DB.

Test plan:
1/ From a fresh Koha install, execute the DB entry to remove the pref.
2/ Define only 1 library
3/ Confirm that Koha behaves the same as before (try to change your
library, look at the facets)
4/ Create another library (or more) and reinsert the pref and set it:
  insert into systempreferences (variable, value)
values('singleBranchMode', 1);
5/ Execute the DB entry
You should get a warning message.
6/ Repeat 3.

Signed-off-by: Chris Cormack 

Does what it says, but will change behaviour for any Koha install that
has 2 branches defined, One circulation, and this preference set.
If that is an acceptable change, we might need to make sure this is noted well
in the
release notes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

--- Comment #34 from Mirko Tietgen  ---
Created attachment 46752
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46752=edit
Bug 15303 Followup: apache port 80 servername/alias and typo

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15587] Unstable letsencrypt_x.x.x-x_all.deb testing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15587

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #46743|0   |1
is obsolete||

--- Comment #2 from Mirko Tietgen  ---
Created attachment 46744
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46744=edit
Bug 15587 Unstable letsencrypt_x.x.x-x_all.deb testing

Apply on top of bug 15303!

* only one commandline parameter left:
** --letsencrypt replaces --force-https: use LE
** old --letsencrypt (folder path) obsolete
* dependency: letsencrypt debian package

Test plan:

- apply bug 15303
- apply this patch
- build a package
- test in disposable vm, we're mixing releases
- install koha-common unstable and dependencies
- enable debian unstable repository
- install package letsencrypt and dependencies
- remove debian unstable repository
- create koha instance
  koha-create --create-db --letsencrypt 
- follow test plan on bug 15303 where applicable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

--- Comment #27 from Mirko Tietgen  ---
Created attachment 46745
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46745=edit
Bug 15303 LE production server

Deletes the --staging option of the letsencrypt command to get
real certificates. Rate limits apply.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15587] Unstable letsencrypt_x.x.x-x_all.deb testing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15587

Mirko Tietgen  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |MOVED

--- Comment #3 from Mirko Tietgen  ---
Merged into bug 15303

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

--- Comment #26 from Mirko Tietgen  ---
Bug 15587 changes the commandline parameter. I will merge both bugs together,
otherwise it's confusing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #46745|0   |1
is obsolete||

--- Comment #30 from Mirko Tietgen  ---
Created attachment 46748
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46748=edit
Bug 15303 LE production server

Deletes the --staging option of the letsencrypt command to get
real certificates. Rate limits apply.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #46617|0   |1
is obsolete||

--- Comment #28 from Mirko Tietgen  ---
Created attachment 46746
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46746=edit
Bug 15303 Letsencrypt option for Debian package installations

New option koha-create --letsencrypt

- installs the letsencrypt package if needed
- creates 
- generates letsencrypt certificates for 
- sets up a https-only website for 
- redirects http to https for 

! letsencrypt and dependencies are only available in debian unstable right now
! but koha-common does not work in debian unstable, so you cannot test there
! apply the "Workaround" patch to test without letsencrypt package

! this patch uses the letsencrypt staging server
! to create real certificates, apply thy "LE production server" patch

Test plan:
- build a debian package with patch applied
- use apache mod_ssl
  sudo a2enmod ssl
- make sure the machine is accessible on 80 (needed for letsencrypt) and 443
from the internet
- install koha with your new package
- Put your (existing) domain options in /etc/koha/koha-sites.conf
- use koha-create with the new options:
  sudo koha-create --create-db --letsencrypt 
- if you do not have the letsencrypt package installed, you will be prompted to
do that
  [ as long as there is no package available, a symlink to the git checkout
will work ]
- wait until setup is finished, check that you got a working OPAC and staff
client with certificates
- check that http redirects to https

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #46742|0   |1
is obsolete||

--- Comment #29 from Mirko Tietgen  ---
Created attachment 46747
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46747=edit
Bug 15303 Workaround to use git ckeckout

The Debian package letsencrypt is only available in unstable at the moment.

To test without letsencrypt package:

- apply this patch before you build the package
- on the test vm/server:
-- get letsencrypt via git
   git clone https://github.com/letsencrypt/letsencrypt
-- create a symlink from /usr/bin/letsencrypt to letsencrypt-auto
   sudo ln -s /path/to/letsencrypt/letsencrypt-auto /usr/bin/letsencrypt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #46746|0   |1
is obsolete||

--- Comment #31 from Mirko Tietgen  ---
Created attachment 46749
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46749=edit
Bug 15303 Letsencrypt option for Debian package installations

New option koha-create --letsencrypt

- installs the letsencrypt package if needed
- creates 
- generates letsencrypt certificates for 
- sets up a https-only website for 
- redirects http to https for 

! letsencrypt and dependencies are only available in debian unstable right now
! but koha-common does not work in debian unstable, so you cannot test there
! apply the "Workaround" patch to test without letsencrypt package

! this patch uses the letsencrypt staging server
! to create real certificates, apply thy "LE production server" patch

Test plan:
- build a debian package with patch applied
- use apache mod_ssl
  sudo a2enmod ssl
- make sure the machine is accessible on 80 (needed for letsencrypt) and 443
from the internet
- install koha with your new package
- Put your (existing) domain options in /etc/koha/koha-sites.conf
- use koha-create with the new options:
  sudo koha-create --create-db --letsencrypt 
- if you do not have the letsencrypt package installed, you will be prompted to
do that
  [ as long as there is no package available, a symlink to the git checkout
will work ]
- wait until setup is finished, check that you got a working OPAC and staff
client with certificates
- check that http redirects to https

Bug 15303 Recreate accidentally deleted C4/Auth_cas_servers.yaml.orig

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #46748|0   |1
is obsolete||

--- Comment #33 from Mirko Tietgen  ---
Created attachment 46751
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46751=edit
Bug 15303 LE production server

Deletes the --staging option of the letsencrypt command to get
real certificates. Rate limits apply.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15533] Allow patrons and librarians to select itemtype when placing hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533

--- Comment #5 from Héctor Eduardo Castro Avalos  ---
(In reply to Kyle M Hall from comment #4)
> I'm having no trouble applying the patch. Did you apply it's dependency (
> Bug 15532 ) first?

You're right, patch apply without trouble

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #46461|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 46753
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46753=edit
[SIGNED-OFF]Bug 15532: Add ability to allow only items whose home/holding
branch matches the hold's pickup branch to fill a given hold

Some libraries would like to be able to limit hold filling to items that
match the pickup library for a hold based on the item's home or holding
library. The patron's home library should not affect whether a patron
can place the hold, instead the hold will only be fillable when an item
matching the pickup location becomes available.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Note the new "Hold pickup library match" rules for "checkout, hold,
   and return policy" and for "holds policy by item type"
4) Set the policy to "item's holding library"
5) Place a hold where the item's holding branch does not match
   the pickup branch
6) Check in the item
7) Note it is not trapped for the hold
8) Update the item's holding branch to match the pickup branch
8) Check in the item
9) Note the item is trapped for the hold
10) Repeat steps 4-9 but for home branch instead

Signed-off-by: Hector Castro 
Works as described

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9754] koha-remove optionally includes var/lib and var/spool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9754] koha-remove optionally includes var/lib and var/spool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754

Chris Cormack  changed:

   What|Removed |Added

  Attachment #46648|0   |1
is obsolete||

--- Comment #7 from Chris Cormack  ---
Created attachment 46754
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46754=edit
Bug 9754: koha-remove optionally includes var/lib and var/spool

Currently, the files in the folder /var/lib/koha/[instance] and also
in /var/spool/koha/[instance] are not removed.
This patch adds the option -p|--purge-all to include those two
directories when removing files.

Note: There was a small bug in the for loop. On the -k line the extra
shift statement is one too much.

NOTE: Verify that you use the adjusted koha-remove in the test plan
and not accidentally an older version of this script.

Test plan:
[1] Create an instance test.
[2] Run koha-remove and verify that /var/lib/koha/test still exists.
[3] Create an instance test2.
[4] Run koha-remove -k -p and verify that the sql database still exists
but the two instance folders in var/lib/koha and var/spool/koha are
gone.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941

Chris Cormack  changed:

   What|Removed |Added

  Attachment #46312|0   |1
is obsolete||

--- Comment #18 from Chris Cormack  ---
Created attachment 46756
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46756=edit
Bug 4941: DB Changes

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941

Chris Cormack  changed:

   What|Removed |Added

  Attachment #46311|0   |1
is obsolete||

--- Comment #17 from Chris Cormack  ---
Created attachment 46755
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46755=edit
Bug 4941: Make tests non DB dependent

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

Chris Cormack  changed:

   What|Removed |Added

  Attachment #46668|0   |1
is obsolete||

--- Comment #9 from Chris Cormack  ---
Created attachment 46758
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46758=edit
Bug 1983: Checkout: Hold repquest when checking out an item already on loan or
reserved

This patch allows to put a hold on an item that is already checked out or
reserved.

To test:

- Check out an item A
- Put a hold on an item B
- Verify that the staff user has permission to put holds
- Check out item A to a patron X
- Try to checkout item A to a patron Y
- Verify that you see underneath the buttons for Checkin/Checkout a link
  with following text: "Click here to place hold for [Patron X' name]"
- Verify that the link is stylable (div class circ-scheckoutplacehold)
- Verify that the link takes you to the page to place a hold on this biblio
  for patron Y
- Do the same for item B and verify that it works for reserved items as well.
- Repeat steps above for a patron who has restrictions, verify that the link
  does not appear
- Log in with a staff member who has no permission to place holds
- Repeat steps above for a patron without restrictions, verify that the link
  does not appear.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

Chris Cormack  changed:

   What|Removed |Added

  Attachment #46589|0   |1
is obsolete||

--- Comment #2 from Chris Cormack  ---
Created attachment 46759
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46759=edit
Bug 14849: Add foreign key on uploaded_files.owner

uploaded_files.owner refers to a borrowernumber, the DB structure should
reflect this constraint.

Test plan:
0/ Do not execute the update DB entry
1/ Add a new patron
2/ Use this patron to upload a new file
3/ In the uploaded_files you should see that the owner value is the
borrowernumber of the newly created patron
4/ Execute the DB entry
5/ The uploaded_files.owner value should have been set to NULL
6/ Repeat 1, 2 and 3
7/ Delete the patron
5/ The uploaded_files.owner value should have been set to NULL

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/