[Koha-bugs] [Bug 15687] Syntax errors in misc/translator/xgettext.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Julian Mauricechanged: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #11 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15718] Need more information for items that don't successfully batch checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15718 --- Comment #2 from Heather Braum--- Johnathan, what about something as simple as adding a table title for that screen, "items that didn't check out" or in the information column for each item, "item didn't check out?" Is that possible? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15741] New: Incorrect rounding in total fines calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15741 Bug ID: 15741 Summary: Incorrect rounding in total fines calculations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: a...@biblos.pk.edu.pl QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Our librarians discovered recently that recording payments for some specific fine amounts (64.60, for example) are not working properly - they are getting errors like: You must pay a value less than or equal to 64.60 It's not just 64.60, same thing happens for: 1.14 1.36 1.39 1.57 1.59 1.61 1.64 1.66 1.68 1.82 1.84 1.86 1.89 1.91 1.93 2.01 2.03 2.28 2.47 2.53 2.72 2.78 2.97 ... 32.30 64.10 64.60 65.10 128.20 128.70 129.20 129.70 130.20 130.70 ... and so on. This error seems to be caused by incorrect rounding in C4::Members::GetMemberAccountRecords(). To replicate: 1) Create manual invoice for 64.60 (or 1.14, 1.36, ...) 2) Try to pay it using "Pay amount" or "Pay selected" buttons As a temporary workaround, one may: - pay such amount in 2+ steps (eg. 64.00 + 0.60) - pay individual fines using 'Pay' button[s] on the left but, at first glance at least, an underlying problem for this error may possibly have some more severe consequences than just minor troubles with making payments - eg., if patron has 12+ fines (or credits) of such kind, total account balance calculation may be wrong as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15578] Authority tests skip and hide a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 --- Comment #12 from Julian Maurice--- Original patches don't apply well on 3.22.x, so here are the patches for 3.22. If someone else can test and signoff them, that would be great :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #46 from Julian Maurice--- Created attachment 47640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47640=edit [3.22.x] Bug 15358: Fix authorities merge Bug 8064 (Merge several biblio records) change some code used in both biblios and authorities merge tool without updating the authorities merge tool. This patch fixes that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3166] Fines are summing off by 1 penny due to rounding issue when summing.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3166 Jacek Ablewiczchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15741 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15578] Authority tests skip and hide a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Julian Mauricechanged: What|Removed |Added Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3379] Rounding error for fines total in C4::Members::GetMemberAccountRecords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3379 Jacek Ablewiczchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15741 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15578] Authority tests skip and hide a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Julian Mauricechanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15578] Authority tests skip and hide a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Julian Mauricechanged: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #9 from Julian Maurice --- Actually those patches are needed for bug 15358. Reopening... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15741] Incorrect rounding in total fines calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15741 Jacek Ablewiczchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=3166 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15578] Authority tests skip and hide a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Julian Mauricechanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15741] Incorrect rounding in total fines calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15741 Jacek Ablewiczchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=3379 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Bug 15358 depends on bug 15578, which changed state. Bug 15578 Summary: Authority tests skip and hide a bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15578] Authority tests skip and hide a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Julian Mauricechanged: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #47 from Julian Maurice--- Patch for 3.22.x is slightly different from original patch. I would like to see it tested on 3.22 before I push it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15578] Authority tests skip and hide a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 --- Comment #11 from Julian Maurice--- Created attachment 47639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47639=edit [3.22.x] Bug 15578: Make sure all params will be taken into account when instantiating The tests in t/db_dependent/Koha_Authority.t expects at least 1 authority record in the DB to run them, otherwise they are skipped. On our integration server, the DB does not contain any records, and the tests are skipped. Unfortunately these tests were testing the authid method of Koha::MetadataRecord::Authority. Test plan: Apply the first patch, launch tests => Fail Apply the second patch, launch tests => \o/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15578] Authority tests skip and hide a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 --- Comment #10 from Julian Maurice--- Created attachment 47638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47638=edit [3.22.x] Bug 15578: Insert authority records before processing tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15736] Add a preference to control whether all items should be shown in checked-in items list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 Owen Leonardchanged: What|Removed |Added Summary|Items should be shown in|Add a preference to control |checked-in items list |whether all items should be |regardless of whether |shown in checked-in items |checked out |list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #48 from Julian Maurice--- Note that it requires [3.22.x] patches from bug 15578 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15733] Audio Alerts issues in master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 Jonathan Druartchanged: What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 15734 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hallchanged: What|Removed |Added Depends on||15734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 [Bug 15734] Audio Alerts broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15734] Audio Alerts broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Kyle M Hallchanged: What|Removed |Added Blocks||15735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hallchanged: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15734] Audio Alerts broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Jonathan Druartchanged: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #3 from Jonathan Druart --- *** Bug 15733 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15684] Fix encoding issues with quote upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15684 Julian Mauricechanged: What|Removed |Added CC||julian.maur...@biblibre.com Status|Pushed to Master|Pushed to Stable --- Comment #10 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 Julian Mauricechanged: What|Removed |Added CC||julian.maur...@biblibre.com Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Aleisha Amohiachanged: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #23 from Aleisha Amohia --- (In reply to Marc Véron from comment #22) > Hi Aleisha, > > I just re-tested. PThe patch applies fine on top of Bug 14930. Oops I completely forgot to apply the dependency (silly me). Will retest -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Aleisha Amohiachanged: What|Removed |Added Attachment #47659|0 |1 is obsolete|| --- Comment #59 from Aleisha Amohia --- Created attachment 47660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47660=edit [SIGNED-OFF] Bug 7957: Routing lists enhancements - Manage several routing list per subscription - Export a routing list as CSV Test plan: Run the updatedatabase.pl script Existing routing lists should have been imported in a routing list named 'import' >From the serials-home.pl page: 1 Make a search, in the results list you have a column 'Actions' that should contain a "New/Edit routing list" link" (if not, consider setting RoutingSerials syspref). If the subscription doesn't have a routing list, you should have a 'New routing list' link. Otherwise you have an 'Edit routing lists (X)' link, where X is the number of routing lists. 2 Choose a subscription which have no routing lists and click on 'New routing list' 3 You are on the routing list creation page. Enter a title for the routing list and click on 'Save'. 4 The routing list has been created and now you are on the routing list modification page. The behaviour of this page is quite the same as before. A sensible change is that reordering borrowers doesn't reload the page each time you make a change. 5 Click on 'Save' to finish routing list modifications. 6 Now you are on the routing lists management page. You can edit a routing list by clicking on its title, preview it, export it, and delete it by clicking on the corresponding link. 7 Click on 'Preview'. 8 You will be asked to choose a serial. Pick the one you want to print the routing list for and click on 'Continue'. 9 If RoutingListAddReserves is OFF, the routing list is displayed and you just have to click on 'Print'. If the syspref is ON, you will have to click on 'Confirm and print', an alert will show telling you that holds will be placed on the serial you chose. Click 'OK' and you will be able to print the slip. Now check if the holds have been placed. (It works only if an item is attached to this serial). 10 Go back to the routing lists management page (routinglists.pl) and click on 'Export'. Download the CSV and check that it contains correct data. >From serials-collection.pl page: 11 In the serials list, click on 'Print list'. 12 You will be asked to choose a routing list. Pick one and click on 'Continue'. 13 ... (same behaviour as above) Try to add and delete routing lists to show if links are correctly updated in serials-home.pl, serials-collection.pl and subscription-detail.pl Signed-off-by: Paola Rossi Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Aleisha Amohiachanged: What|Removed |Added Attachment #47661|0 |1 is obsolete|| --- Comment #62 from Aleisha Amohia --- Created attachment 47663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47663=edit [SIGNED-OFF] Bug 7957: Add unit tests for new subroutines Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15742] Unnecessary loop in j2a cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15742 --- Comment #3 from M. Tompsett--- Comment on attachment 47642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47642 Bug 15742: Remove unnecessary loop in j2a cronjob Review of attachment 47642: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15742=47642) - ::: misc/cronjobs/j2a.pl @@ -178,4 @@ > } else { print "Updated $res patrons\n"; } > } else { # branch was not supplied, processing all branches > $verbose and print "Looking in all branches for patrons to > update from $fromcat to $tocat that were born before $itsyourbirthday\n"; > - foreach my $branchcode (@branches) { What's scarier is I added: print "PROCESSING $branchcode\n"; "PROCESSING HASH(0x3645b50)" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Aleisha Amohiachanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Aleisha Amohiachanged: What|Removed |Added Attachment #47633|0 |1 is obsolete|| --- Comment #58 from Aleisha Amohia --- Created attachment 47659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47659=edit [SIGNED-OFF] Bug 7957: Routing lists enhancements - Manage several routing list per subscription - Export a routing list as CSV Test plan: Run the updatedatabase.pl script Existing routing lists should have been imported in a routing list named 'import' >From the serials-home.pl page: 1 Make a search, in the results list you have a column 'Actions' that should contain a "New/Edit routing list" link" (if not, consider setting RoutingSerials syspref). If the subscription doesn't have a routing list, you should have a 'New routing list' link. Otherwise you have an 'Edit routing lists (X)' link, where X is the number of routing lists. 2 Choose a subscription which have no routing lists and click on 'New routing list' 3 You are on the routing list creation page. Enter a title for the routing list and click on 'Save'. 4 The routing list has been created and now you are on the routing list modification page. The behaviour of this page is quite the same as before. A sensible change is that reordering borrowers doesn't reload the page each time you make a change. 5 Click on 'Save' to finish routing list modifications. 6 Now you are on the routing lists management page. You can edit a routing list by clicking on its title, preview it, export it, and delete it by clicking on the corresponding link. 7 Click on 'Preview'. 8 You will be asked to choose a serial. Pick the one you want to print the routing list for and click on 'Continue'. 9 If RoutingListAddReserves is OFF, the routing list is displayed and you just have to click on 'Print'. If the syspref is ON, you will have to click on 'Confirm and print', an alert will show telling you that holds will be placed on the serial you chose. Click 'OK' and you will be able to print the slip. Now check if the holds have been placed. (It works only if an item is attached to this serial). 10 Go back to the routing lists management page (routinglists.pl) and click on 'Export'. Download the CSV and check that it contains correct data. >From serials-collection.pl page: 11 In the serials list, click on 'Print list'. 12 You will be asked to choose a routing list. Pick one and click on 'Continue'. 13 ... (same behaviour as above) Try to add and delete routing lists to show if links are correctly updated in serials-home.pl, serials-collection.pl and subscription-detail.pl Signed-off-by: Paola Rossi Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 --- Comment #22 from Marc Véron--- Hi Aleisha, I just re-tested. PThe patch applies fine on top of Bug 14930. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc Véronchanged: What|Removed |Added Attachment #46564|0 |1 is obsolete|| --- Comment #20 from Marc Véron --- Created attachment 47656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47656=edit Bug 15374 - Translatability: Fix issues on OPAC summary page Fix several issues on opac-user.tt with sentences splitted by tags, leading to odd translations. Additionally, fix a broken link that should point to opac-account.pl To test: - Apply patch - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information - with user who has got a circulation message (from checkout page) - with user who has a OPAC note - Verify that information is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions (Amended to add price formatting in fines tab label) Can see the warning message now :) signing off Signed-off-by: Aleisha (Amended to make patches apply, see comment #12) Signed-off-by: Aleisha (Amended to make it apply and to fix BORROWER.INF -> BORROWER->INFO. Needs new sign-off. / MV) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15628] Remove get_branchinfos_of vestiges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15628 Julian Mauricechanged: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||julian.maur...@biblibre.com --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15743] Allow plugins to embed Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15743 M. Tompsettchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15742] Unnecessary loop in j2a cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15742 M. Tompsettchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc Véronchanged: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15638] spelling mistake in ~/Koha/reserve/placerequest.pl:4: writen ==> written
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15638 Julian Mauricechanged: What|Removed |Added CC||julian.maur...@biblibre.com Status|Pushed to Master|Pushed to Stable --- Comment #11 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15743] Allow plugins to embed Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15743 M. Tompsettchanged: What|Removed |Added Attachment #47651|0 |1 is obsolete|| --- Comment #3 from M. Tompsett --- Created attachment 47657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47657=edit [SIGNED-OFF] Bug 15743: Allow plugins to embed Perl modules This patch allows plugins to embed Perl modules by ignoring Perl modules in plugins directory that don't inherit from Koha::Plugins::Base TEST PLAN - 1) Edit koha-conf.xml to have enable_plugins set to 1, and the pluginsdir set to a particular path. 2) Create a dummy plugin file. (e.g. {that path}/Koha/Plugin/Kaboom.pm) --- BEGIN Kaboom.pm --- package Koha::Plugin::Kaboom; use Modern::Perl; our $VERSION = '1'; 1; --- END Kaboom.pm --- 3) Sign in to staff client 4) Reports -> Report plugins -- commented line version explodes. 5) Apply patch 6) Reports -> Report plugins -- commented line version works. -- the ?method= portion in the address bar prevents you from seeing that the plugin is actually considered, because various methods are not defined. Delete that portion of the URL, and you should see a thin empty second row appear. 7) run koha qa tests Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Aleisha Amohiachanged: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #21 from Aleisha Amohia --- Applying: Bug 15374 - Translatability: Fix issues on OPAC summary page fatal: sha1 information is lacking or useless (opac/opac-user.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 15374 - Translatability: Fix issues on OPAC summary page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 Julian Mauricechanged: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #16 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15742] Unnecessary loop in j2a cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15742 M. Tompsettchanged: What|Removed |Added Attachment #47642|0 |1 is obsolete|| --- Comment #4 from M. Tompsett --- Created attachment 47658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47658=edit [SIGNED-OFF] Bug 15742: Remove unnecessary loop in j2a cronjob If no branchcode is given, all the libraries are retrieved and the same query (so without using the libraries loop) is executed for each library. Test plan: Use the j2a.pl cronjob to change the category of a child patron If a branchcode is passed to the script, only the children from this branchcode should be updated. But if it is not passed, all children of the DB should be updated. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Aleisha Amohiachanged: What|Removed |Added Attachment #47635|0 |1 is obsolete|| --- Comment #63 from Aleisha Amohia --- Created attachment 47664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47664=edit [SIGNED-OFF] Bug 7957: Redirect after creating a new routing list This avoids creating the same list multiple times when reloading the page Signed-off-by: Aleisha Have made a couple of small changes to your patch. 1) "There is no routing lists for this subscription" -> changed to "There are no" 2) When I click Preview and choose a serial (up to Step 9 in test plan), there is a link to another system preference which I assume$ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Aleisha Amohiachanged: What|Removed |Added Attachment #47634|0 |1 is obsolete|| --- Comment #60 from Aleisha Amohia --- Created attachment 47661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47661=edit [SIGNED-OFF] Bug 7957: Add unit tests for new subroutines Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Aleisha Amohiachanged: What|Removed |Added Attachment #47660|0 |1 is obsolete|| --- Comment #61 from Aleisha Amohia --- Created attachment 47662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47662=edit [SIGNED-OFF] Bug 7957: Routing lists enhancements - Manage several routing list per subscription - Export a routing list as CSV Test plan: Run the updatedatabase.pl script Existing routing lists should have been imported in a routing list named 'import' >From the serials-home.pl page: 1 Make a search, in the results list you have a column 'Actions' that should contain a "New/Edit routing list" link" (if not, consider setting RoutingSerials syspref). If the subscription doesn't have a routing list, you should have a 'New routing list' link. Otherwise you have an 'Edit routing lists (X)' link, where X is the number of routing lists. 2 Choose a subscription which have no routing lists and click on 'New routing list' 3 You are on the routing list creation page. Enter a title for the routing list and click on 'Save'. 4 The routing list has been created and now you are on the routing list modification page. The behaviour of this page is quite the same as before. A sensible change is that reordering borrowers doesn't reload the page each time you make a change. 5 Click on 'Save' to finish routing list modifications. 6 Now you are on the routing lists management page. You can edit a routing list by clicking on its title, preview it, export it, and delete it by clicking on the corresponding link. 7 Click on 'Preview'. 8 You will be asked to choose a serial. Pick the one you want to print the routing list for and click on 'Continue'. 9 If RoutingListAddReserves is OFF, the routing list is displayed and you just have to click on 'Print'. If the syspref is ON, you will have to click on 'Confirm and print', an alert will show telling you that holds will be placed on the serial you chose. Click 'OK' and you will be able to print the slip. Now check if the holds have been placed. (It works only if an item is attached to this serial). 10 Go back to the routing lists management page (routinglists.pl) and click on 'Export'. Download the CSV and check that it contains correct data. >From serials-collection.pl page: 11 In the serials list, click on 'Print list'. 12 You will be asked to choose a routing list. Pick one and click on 'Continue'. 13 ... (same behaviour as above) Try to add and delete routing lists to show if links are correctly updated in serials-home.pl, serials-collection.pl and subscription-detail.pl Signed-off-by: Paola Rossi Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14406] When adding messages in patron account, only first name is shown in pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14406 Julian Mauricechanged: What|Removed |Added CC||julian.maur...@biblibre.com Status|Pushed to Master|Pushed to Stable --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15574] Better wording for error message when adding tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15574 Julian Mauricechanged: What|Removed |Added CC||julian.maur...@biblibre.com Status|Pushed to Master|Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15742] Unnecessary loop in j2a cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15742 --- Comment #2 from M. Tompsett--- Comment on attachment 47642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47642 Bug 15742: Remove unnecessary loop in j2a cronjob Review of attachment 47642: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15742=47642) - YIKES! Good catch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #64 from Aleisha Amohia--- (In reply to Aleisha Amohia from comment #63) > Created attachment 47664 [details] [review] > [SIGNED-OFF] Bug 7957: Redirect after creating a new routing list > > This avoids creating the same list multiple times when reloading the > page > > Signed-off-by: Aleisha > > Have made a couple of small changes to your patch. > 1) "There is no routing lists for this subscription" -> changed to "There > are no" > 2) When I click Preview and choose a serial (up to Step 9 in test plan), > there is a link to another system preference which I assume$ ...which I assume is where the text comes from. Have changed this in syspref.sql to take the tags out around the syspref because html tags won't show up nicely in a sql file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 --- Comment #10 from Héctor Eduardo Castro Avalos--- I will send the OPAC's patch afterwards -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 --- Comment #25 from Marc Véron--- Hmm, testing... Seems OK to me... - Syspref OpacRenewalAllowed: Allow - Syspref OPACFineNoRenewals: 2 - Patron has fines: Total due: 5.01 - Log-in to Opac with patron, go to 'your summary' Result: "Please note: You cannot renew your books online. Reason: Your fines exceed 2.00. Please pay your fines if you wish to renew your books. Go to your account page" OK - Syspref OPACFineNoRenewals: 10 - Patron has fines: Total due: 5.01 - Refresh 'your summary' Result: No message OK - Syspref OPACFineNoRenewals: 10 - Add manual fine for patron (10). Now total due is:15.01 - Refresh 'your summary' Result: "Please note: You cannot renew your books online. Reason: Your fines exceed 10.00. Please pay your fines if you wish to renew your books. Go to your account page" OK - Syspref OPACFineNoRenewals: 0 - Patron has fines: Total due: 15.01 - Refresh 'your summary' Result: "Please note: You cannot renew your books online. Reason: You have fines. Please pay your fines if you wish to renew your books. Go to your account page" OK - Syspref OPACFineNoRenewals: (empty) - Refresh 'your summary' Result: No message OK - Syspref OPACFineNoRenewals: xyndjeksfjasdf (non-numeric, is not validated by syspref form) - Refresh 'your summary' Result: No message OK - Syspref OPACFineNoRenewals: (one space char) (non-numeric, is not validated by syspref form) - Refresh 'your summary' Result: No message OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc Véronchanged: What|Removed |Added Attachment #47656|0 |1 is obsolete|| --- Comment #26 from Marc Véron --- Created attachment 47678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47678=edit Bug 15374 - Translatability: Fix issues on OPAC summary page Fix several issues on opac-user.tt with sentences splitted by tags, leading to odd translations. Additionally, fix a broken link that should point to opac-account.pl To test: - Apply patch - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information - with user who has got a circulation message (from checkout page) - with user who has a OPAC note - Verify that information is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions (Amended to add price formatting in fines tab label) Can see the warning message now :) signing off Signed-off-by: Aleisha (Amended to make patches apply, see comment #12) Signed-off-by: Aleisha (Amended to make it apply and to fix BORROWER.INF -> BORROWER->INFO. Needs new sign-off. / MV) (Amended to fix typo from comment #24 / mv) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15311] Let libraries set text to display when OpacMaintenance = on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 --- Comment #12 from Aleisha Amohia--- (In reply to Mirko Tietgen from comment #11) > (In reply to Aleisha Amohia from comment #10) > > > Sponsored-by: Catalyst IT > > Was that on purpose? Claiming a patch somebody else wrote to be sponsored by > Catalyst because you fixed a conflict does not seem like a nice move. In > fact support companies do not really put that line in for their own stuff, > just for things sponsored by third parties. No I'm sorry that was a complete accident! I was trying to get in to the habit of adding it and did it without thinking! Sorry it looks so bad I did not mean to claim the patch :( I'll remove it when I get in to work on Tuesday -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 Héctor Eduardo Castro Avaloschanged: What|Removed |Added Attachment #42178|0 |1 is obsolete|| --- Comment #9 from Héctor Eduardo Castro Avalos --- Created attachment 47677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47677=edit Bug 14304: RDA: Intranet display link in XSLT for 264 field to reflect Zebra indexing This patch add display link in XSLT for 264 for bug 14198 and reflect the Zebra indexing 'Provider' in detail page for Intranet. Test plan 1) Update zebra index if no Provider: index exist 2) Do a search by Provider: 3) Goto detail page for a record with 264 4) Look that there no display link for 264 field. 5) Apply the patch 6) Reload the page, notice about the link, click the link an confirm the new index Provider works fine 7) Test with multiple records with 260 and 264, if you prefer follow test plan for bug 14734 8) Access an RCAA2 record just with 260 field 9) Notice that 260 has been updated with Provider index too. NOTE: The intention of Provider index -according with documentation- is to collect multiples fields including 260, 264, 270, and 257 Sponsored-by: Universidad de El Salvador -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc Véronchanged: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #27 from Marc Véron --- Hi Aleisha, Thank you very much for continuous testing. I could not reproduce your issue from comment #24, see my tests in comment #25. If I missed something, please provide information on how you got your result. I attached a patch with fixed wording. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Aleisha Amohiachanged: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #24 from Aleisha Amohia --- There are a couple of problems with the patch. When the user has too many fines, there is no message on the summary page to say the user is blocked from check outs. Also, small typo: When the account has a restriction, the message says "If shows your account to be clear", which doesn't make sense. Perhaps change to "If your account is shown to be clear"? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 Aleisha Amohiachanged: What|Removed |Added CC||aleishaamo...@hotmail.com Status|Needs Signoff |Failed QA --- Comment #3 from Aleisha Amohia --- t/db_dependent/HoldsQueue.t .. 1/27 # Failed test 'Holds queue giving priority to patron who's home library matches item's home library' # at t/db_dependent/HoldsQueue.t line 333. # got: 'cdoBnBl' # expected: 'pkSI5p' # Failed test 'Holds queue giving priority to patron who's home library matches item's holding library' # at t/db_dependent/HoldsQueue.t line 350. # got: 'cdoBnBl' # expected: 'pkSI5p' # Failed test 'Holds queue giving priority to patron who's home library matches item's holding library' # at t/db_dependent/HoldsQueue.t line 367. # got: 'cdoBnBl' # expected: 'pkSI5p' # Failed test 'Holds queue giving priority to patron who's home library matches item's holding library' # at t/db_dependent/HoldsQueue.t line 384. # got: 'cdoBnBl' # expected: 'pkSI5p' # Failed test 'Bug 15062 - Holds queue with Transport Cost Matrix will transfer item even if transfers disabled' # at t/db_dependent/HoldsQueue.t line 492. # got: '1' # expected: '0' # Looks like you failed 5 tests of 27. t/db_dependent/HoldsQueue.t .. Dubious, test returned 5 (wstat 1280, 0x500) Failed 5/27 subtests Test Summary Report --- t/db_dependent/HoldsQueue.t (Wstat: 1280 Tests: 27 Failed: 5) Failed tests: 22-25, 27 Non-zero exit status: 5 Files=1, Tests=27, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.13 cusr 0.09 csys = 1.26 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohiachanged: What|Removed |Added Attachment #47669|0 |1 is obsolete|| --- Comment #25 from Aleisha Amohia --- Created attachment 47671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47671=edit Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohiachanged: What|Removed |Added Attachment #47558|0 |1 is obsolete|| --- Comment #27 from Aleisha Amohia --- Created attachment 47673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47673=edit [SIGNED-OFF] Bug 14272: Show single news item (OPAC) This change makes the news shown on opac-main-pl have clickable headings which shows just that news item in isolation. This is to allow further patches that adds commentary functions. Sponsored-By: Halland County Library Test plan: * Apply this patch. * Go to OPAC main, you should see multiple news items by default. * If you do not see any, go to Staff interface and add a few. * Each nees item heading should be clickable. * When clicked only that item should be shown. * When 'news_id' is present, only a single news item should show. * The breadcrumb should say 'News item' after 'Home'. Updates: * Renamed URL parameter and local variables with 'news_' prefix. * Fixed Search-And-Replace error; 'news_news_id' => 'news_id' * Added breadcrumb for viewing single news item. * Updated OPAC to use new GetNewsToDisplay parameters * Fixed template formatting and calling of GetNewsToDisplay Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohiachanged: What|Removed |Added Attachment #47670|0 |1 is obsolete|| --- Comment #26 from Aleisha Amohia --- Created attachment 47672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47672=edit [SIGNED-OFF] Bug 14272: Show single news item (backend) Updates: * Date formatting added to get_opac_new() * Proper filtering by way of GetNewsToDisplay Sponsored-by: Halland County Library Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohiachanged: What|Removed |Added Attachment #47667|0 |1 is obsolete|| --- Comment #22 from Aleisha Amohia --- Created attachment 47668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47668=edit Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohiachanged: What|Removed |Added Attachment #47668|0 |1 is obsolete|| --- Comment #23 from Aleisha Amohia --- Created attachment 47669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47669=edit Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohiachanged: What|Removed |Added Attachment #47557|0 |1 is obsolete|| --- Comment #24 from Aleisha Amohia --- Created attachment 47670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47670=edit [SIGNED-OFF] Bug 14272: Show single news item (backend) Updates: * Date formatting added to get_opac_new() * Proper filtering by way of GetNewsToDisplay Sponsored-by: Halland County Library Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #28 from Aleisha Amohia--- Sorry for all the comments, git kept timing out >.< so annoying! Won't change this to Signed Off as those tests don't pass, but will sign off once they're fixed to pass! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Aleisha Amohiachanged: What|Removed |Added Status|Needs Signoff |Failed QA CC||aleishaamo...@hotmail.com --- Comment #26 from Aleisha Amohia --- This didn't work properly for me - I selected the pipe | as my CSV separator and copied your data from step 2 but the CSV file did not separate my files on pipes and separated on commas instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15531] Add support for standing orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 Aleisha Amohiachanged: What|Removed |Added Status|Needs Signoff |Failed QA CC||aleishaamo...@hotmail.com --- Comment #5 from Aleisha Amohia --- Tests failed: StandingOrders.t CancelReceipt.t OrderUsers.t Also I can still see the quantity field there, just can't change it Otherwise everything else seems to work well and will be happy to sign off once those few things are fixed up :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Aleisha Amohiachanged: What|Removed |Added CC||aleishaamo...@hotmail.com Status|Needs Signoff |Failed QA --- Comment #4 from Aleisha Amohia --- I don't get any kind of message after checking in the book at step 5/6. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohiachanged: What|Removed |Added CC||aleishaamo...@hotmail.com --- Comment #18 from Aleisha Amohia --- (In reply to M. Tompsett from comment #14) > Created attachment 47556 [details] [review] > Bug 14272: Show single news item (tests) > > Updates tests to match the modified NewsChannels module. > > Sponsored-by: Halland County Library The tests fail: t/db_dependent/NewsChannels.t .. 1/12 # Category CAT1 not found, inserting # Borrower BRWR1 not found, inserting # Failed test 'got back expected news item via get_opac_new - ID 1' # at t/db_dependent/NewsChannels.t line 131. # Structures begin differing at: # $got->{newdate} = Does not exist # $expected->{newdate} = '01/01/2000' # Failed test 'got back expected news item via get_opac_new - ID 2' # at t/db_dependent/NewsChannels.t line 158. # Structures begin differing at: # $got->{newdate} = Does not exist # $expected->{newdate} = '01/01/2000' # Looks like you failed 2 tests of 12. t/db_dependent/NewsChannels.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/12 subtests Test Summary Report --- t/db_dependent/NewsChannels.t (Wstat: 512 Tests: 12 Failed: 2) Failed tests: 8-9 Non-zero exit status: 2 Files=1, Tests=12, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.59 cusr 0.04 csys = 0.65 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohiachanged: What|Removed |Added Attachment #47666|0 |1 is obsolete|| --- Comment #21 from Aleisha Amohia --- Created attachment 47667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47667=edit Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohiachanged: What|Removed |Added Attachment #47556|0 |1 is obsolete|| --- Comment #19 from Aleisha Amohia --- Created attachment 47665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47665=edit Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohiachanged: What|Removed |Added Attachment #47665|0 |1 is obsolete|| --- Comment #20 from Aleisha Amohia --- Created attachment 47666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47666=edit Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15385] News archive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15385 Aleisha Amohiachanged: What|Removed |Added Attachment #47559|0 |1 is obsolete|| --- Comment #7 from Aleisha Amohia --- Created attachment 47674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47674=edit [SIGNED-OFF] Bug 15385: News archive Adds ability to new old, expired news items in an archive. Test plan: * Add several news items, some of which should have an expired date. * Go to Global system preferences, Enable 'NewsArchiveEnabled'. * Go to the OPAC main page. The non-expired news should be shown. * A link should be shown in the lower right-hand side of the page, "Archived news". Click it. ALL news items should be shown. * Go back to Global system preferences, Disable 'NewsArchiveEnabled'. * No 'Archived news' link should be shown on the OPAC main page. * If you manually add '?id=all' to the OPAC main page URL, the standard page should be shown and the parameter ignored. Updates: * Renamed 'id' to 'news_id' (from update in 14272) * Added breadcrumbs Sponsored-By: Halland County Library Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15385] News archive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15385 Aleisha Amohiachanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15742] New: Unnecessary loop in j2a cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15742 Bug ID: 15742 Summary: Unnecessary loop in j2a cronjob Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org If no branchcode is given, all the libraries are retrieved and the same query (so without using the libraries loop) is executed for each library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 --- Comment #4 from Kyle M Hall--- (In reply to Mirko Tietgen from comment #3) > fatal: sha1 information is lacking or useless > (koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc). Forgot to mark this bug as dependent on 15734! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15742] Unnecessary loop in j2a cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15742 --- Comment #1 from Jonathan Druart--- Created attachment 47642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47642=edit Bug 15742: Remove unnecessary loop in j2a cronjob If no branchcode is given, all the libraries are retrieved and the same query (so without using the libraries loop) is executed for each library. Test plan: Use the j2a.pl cronjob to change the category of a child patron If a branchcode is passed to the script, only the children from this branchcode should be updated. But if it is not passed, all children of the DB should be updated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15734] Audio Alerts broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Héctor Eduardo Castro Avaloschanged: What|Removed |Added Attachment #47621|0 |1 is obsolete|| --- Comment #4 from Héctor Eduardo Castro Avalos --- Created attachment 47644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47644=edit [SIGNED-OFF]Bug 15734: Audio Alerts broken In master there is a JSON error thrown when AudioAlerts are enabled. This is caused by changes in master from bug 13618. Test Plan: 1) Enable audio alerts 2) Note audio alerts don't work 3) Apply this patch 4) Note audio alerts now work Signed-off-by: Hector Castro Works as described -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15734] Audio Alerts broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Héctor Eduardo Castro Avaloschanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Héctor Eduardo Castro Avaloschanged: What|Removed |Added Attachment #47623|0 |1 is obsolete|| --- Comment #5 from Héctor Eduardo Castro Avalos --- Created attachment 47645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47645=edit [SIGNED-OFF]Bug 15735: Audio Alerts editor broken by use of of single quotes in editor Single quotes audio selector break ability to edit an alert Test Plan: 1) Enable audio alerts 2) Add new a alert with a select containing single quotes such as: input[name*='test'] 3) Note you cannot edit the alert 4) Apply this patch 5) Reload the page 6) You should now be able to edit the alert Signed-off-by: Hector Castro Bug 15734 applied on top. Works as advertised -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Héctor Eduardo Castro Avaloschanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Josef Moravecchanged: What|Removed |Added Attachment #47641|[Signed-off] Bug 15358: Fix |[Signed-off] [3.22.x] Bug description|authorities merge |15358: Fix authorities ||merge -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15731] C4::Reports::Guided::build_authorised_value_list is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 Héctor Eduardo Castro Avaloschanged: What|Removed |Added Attachment #47603|0 |1 is obsolete|| --- Comment #2 from Héctor Eduardo Castro Avalos --- Created attachment 47643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47643=edit [SIGNED-OFF]Bug 15731: Remove C4::Reports::Guided::build_authorised_value_list This subroutine has been added by commit 42acfbf75b7bb4ee53c6a6f035e258a0b522ce10 Bug 7993: Save reports with Group/Subgroup hierarchy But it has never been used (or git grep cheats me). Test plan: 1/ git grep build_authorised_value_list should not return any result 2/ Create a report, execute it Everything should work fine. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15731] C4::Reports::Guided::build_authorised_value_list is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 Héctor Eduardo Castro Avaloschanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Josef Moravecchanged: What|Removed |Added Attachment #47640|0 |1 is obsolete|| --- Comment #49 from Josef Moravec --- Created attachment 47641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47641=edit [Signed-off] Bug 15358: Fix authorities merge Bug 8064 (Merge several biblio records) change some code used in both biblios and authorities merge tool without updating the authorities merge tool. This patch fixes that. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15742] Unnecessary loop in j2a cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15742 Jonathan Druartchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 --- Comment #8 from Héctor Eduardo Castro Avalos--- Hi All I will try to work in this patch as soon as possible. I need to do a little of time. Thank you for keep testing, Mason. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238 David Cookchanged: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- Hey Kyle, I've had the same issue when doing matching. Since it has no documentation, I've left it in Koha, but I've created a "none" or "raw" normalizer which skips C4::Matcher::_normalize, as it was butchering URLs... You can see the signed off patch at: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15745] New: C4::Matcher gets CCL parsing error if term contains ? (question mark)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 Bug ID: 15745 Summary: C4::Matcher gets CCL parsing error if term contains ? (question mark) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcha...@gmail.com Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org I was using C4::Matcher via the record matching rules during an import, and I kept getting the following error: "CCL parsing error (10014) Embedded truncation not supported ZOOM". Query: id-other,st-urx=http://www.skovdenyheter.se?p=38004 I wondered why it was trying to do "embedded truncation" when it shouldn't have been doing any truncation by default... so I thought about wrapping the whole term in double quotation marks. Sure enough, the following worked and didn't produce an error: id-other,st-urx="http://www.skovdenyheter.se?p=38004; You can notice this same problem elsewhere when using CCL. Most noticeably directly with yaz-client: Z> find ti=test? CCL ERROR: Right truncation not supported Z> find ti="test?" Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 4, setno 2 SearchResult-1: term=test cnt=4 records returned: 0 Elapsed: 0.000816 Also consider the following: Z> find kw,rt=tes* CCL ERROR: Right truncation not supported Z> find kw="tes*" Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 0, setno 23 SearchResult-1: term=tes cnt=0 records returned: 0 Elapsed: 0.000679 Z> find kw,rt="tes*" Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 6, setno 24 SearchResult-1: term=tes cnt=6 records returned: 0 Elapsed: 0.001049 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? (question mark)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 David Cookchanged: What|Removed |Added Assignee|gmcha...@gmail.com |dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cookchanged: What|Removed |Added Attachment #44792|0 |1 is obsolete|| --- Comment #64 from David Cook --- Created attachment 47675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47675=edit Bug 10662 - Build OAI-PMH Harvesting Client _QUICK AND TENTATIVE TEST PLAN_ In the following steps replace "/home/user" with whatever your Koha dev install is _CONFIGURATION_ 1) Add something like the following to your koha-conf.xml after and before unix:/home/user/koha-dev/var/run/icarus.sock /home/user/koha-dev/var/run/icarus.pid /home/user/koha-dev/var/log/icarus.log Koha::Icarus::Task::Enqueue::OAIPMH::Biblio Koha::Icarus::Task::Dequeue::OAIPMH::Biblio Koha::Icarus::Task::Test 30 2) Apply Bugzilla patches 1, 15541, 15745, then 10662 3) Upgrade your Koha dev install so that it uses new Zebra configuration files; try something like the following: perl Makefile.PL --prev-install-log "$INSTALL_LOG" make make test make upgrade 4) Run upgrade database: perl installer/data/mysql/updatedatabase.pl 4) Set PERL5LIB to include /home/user/koha (i.e. path to your C4 and Koha module directories) export PERL5LIB=/home/user/koha 5) Activate Icarus using the following command: perl /home/user/koha/misc/bin/icarusd.pl -f /home/user/koha-dev/etc/koha-conf.xml NOTE: It will send output to your terminal window. To write to the log file, you can daemonize by adding the "-d" or "--daemon" options. 6) In Koha, create a record matching rule: Code = OAI Match threshold = 100 Record type = Bibliographic Search index = control-number Score = 100 Tag = 001 Search index = id-other,st-urx Score = 100 Tag = 024 Subfields = a Normalization rule = raw _USER DOWNLOAD TASK_ 7a) Go to http://KOHA/cgi-bin/koha/admin/saved_tasks.pl 7b) Click "New saved task" 7c) Leave it on "Koha::Icarus::Task::Enqueue::OAIPMH::Biblio" and click "Next" 7d) Choose a "Start time" in the past using the calendar pop-up 7e) Choose a "Repeat interval" of at least 30 seconds (for initial troubleshooting purposes) 7f) Choose a URL of an OAI-PMH repository that you want to harvest (also include a username, password, and realm if necessary) 7g) Fill out your OAI-PMH repositories as you like 7h) Fill out "Queue" with something like file:///home/user/koha/icarus_test 7i) Click "Save" 8a) Check that the Icarus dashboard has a "Status" of "Online" 8b) Click "Send to Icarus" next to your new saved task entry 8c) A task should now appear under "Active Icarus tasks"; click "Start" 8d) Go back to your terminal to check the Icarus server output (or 'tail -f' the log if you daemonized) 8e) You should notice activity; you can also check /home/user/koha/icarus_test to see if records are being downloaded and stored there _USER IMPORT TASK_ 9a) Go back to http://KOHA/cgi-bin/koha/admin/saved_tasks.pl 9b) Click "New saved task" 9c) Choose Koha::Icarus::Task::Dequeue::OAIPMH::Biblio, and click "Next" 9d) Repeat the same steps for "Start time" and "Repeat interval" as these are common to all tasks 9e) "Queue" should be the same as before, so try your path of file:///home/user/koha/icarus_test 9f) Provide a username and password for the API authentication; you should be able to use the default URL 9g) You should be able to trust the "Import target parameters" URL 9h) Write "OAI" for "Record matching rule code", if you added it earlier in the configuration steps 9i) Leave the "Action..." defaults... 9j) Change "Filter" to "file:///home/user/koha/koha-tmpl/intranet-tmpl/prog/en/xslt/OAI2MARC21slim.xsl" 9k) Follow the same steps as above for sending the task to Icarus and telling Icarus to start it 9l) You can either watch Icarus's server output, or look at http://KOHA/cgi-bin/koha/tools/manage-marc-import.pl, or look directly at your database's "import_oai" and "biblio" tables to see how records are imported to Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #65 from David Cook--- Hi all: Here's a rough draft of what I've been working on. It still needs some fixes, some improvements, and quite a bit of polishing. I'm hoping to do most of that over the next couple of weeks, but I thought I'd post this now as my wife is 35 weeks pregnant, and you never know when babies will be born... In terms of bare bones functionality, it should all be there. Feel free to add comments about things you'd like to see (like parameters or names for Active Icarus Tasks), and I'll hopefully incorporate that feedback into my finishing work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 vimal kumarchanged: What|Removed |Added Status|NEW |In Discussion CC||vimal0...@gmail.com --- Comment #5 from vimal kumar --- "Always show checkouts immediately" is an annoying feature for library professionals in circulation desk. This feature is against the "Five Laws of Library Science" Save the Time of the reader!! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cookchanged: What|Removed |Added Attachment #44793|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? (question mark)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 David Cookchanged: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? (question mark)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 --- Comment #2 from David Cook--- I'll write a better description and test plan next week when I have more time... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? (question mark)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 --- Comment #1 from David Cook--- Created attachment 47676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47676=edit Bug 15745 - C4::Matcher gets CCL parsing error if term contains ? (question mark) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15311] Let libraries set text to display when OpacMaintenance = on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Mirko Tietgenchanged: What|Removed |Added Status|Needs Signoff |Failed QA CC||mi...@abunchofthings.net --- Comment #11 from Mirko Tietgen --- (In reply to Aleisha Amohia from comment #10) > Sponsored-by: Catalyst IT Was that on purpose? Claiming a patch somebody else wrote to be sponsored by Catalyst because you fixed a conflict does not seem like a nice move. In fact support companies do not really put that line in for their own stuff, just for things sponsored by third parties. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marjorie Barry-Vilachanged: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/