date:20160217

[Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809

--- Comment #13 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #12)
> (In reply to Galen Charlton from comment #10)
> 
> I totally agree with the "what to do next" part, but what about now? My
> patch seems to match your requirements.

Jonathan, I am reading: "I am not keen about monkey patching a core module",
which imo does not seem to translate to "match your requirements" :)
I would not opt for a complete Koha::CGI at this point. But I would (slightly)
prefer the Koha::CGI::multi_param above "*CGI::multi_param = \::param". It
will make any developer immediately aware of our "interception". The switchover
to the real multi_param at some point in time will be completely painless.

Also note the different handling of the LIST_CONTEXT_WARN var.

> It could be very easy and quick to replace the different occurrences. I
> would like to avoid a temporary solution. Even if we need one, something
> different than "FIXME bug 2505" would be better ;)
Agreed, altough some code is temporary in any solution for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Allow the use of emojis as tags on records

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

--- Comment #3 from M. Tompsett  ---
P.S. DataTables may not be as unicode friend as we would like for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714

--- Comment #21 from David Cook  ---
(In reply to Marcel de Rooy from comment #20)
> This is an interesting topic but really outside the scope of this tiny
> change.
> The percentage of Debian users of Koha will probably be quite substantial
> due to the tools developed for it. (We eventually switched from Fedora to
> Debian for such reasons.)
> The various install modes (default, single, dev), Debian packaging,
> gitified, having possibly different directory structures etc., imo really
> beg for being simplified and brough together. But realizing that is hard. In
> the meantime the Debian percentage will keep growing?

I think you're right. I think it's a worthwhile change :).

I admit that I think about switching away from openSUSE to Debian for this
reason as well, although we also run a few different versions of Koha on the
same server, and that's something that the packages can't cope with I think.

I would love if the different installation streams could use the same tools,
but it is hard, and the Debian percentage probably is growing (and with good
reason). 

Thanks for taking the time to reply :).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context"

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747

--- Comment #25 from David Cook  ---
(In reply to Marcel de Rooy from comment #24)
> Misunderstanding? He talks about calling it without arguments (and without
> warning). You mean calls with an argument (and warnings dependent on
> context).

Certainly a misunderstanding I think.

Generates no warning:
my @parameter_names = CGI->param();

Generates no warning:

my $name = CGI->param("foo");

Generates a warning:
my @name = CGI->param("foo");

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Allow the use of emojis as tags on records

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

--- Comment #2 from M. Tompsett  ---
https://dev.mysql.com/doc/refman/5.7/en/charset-unicode-utf8mb4.html

Hope these point in a useful direction.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Allow the use of emojis as tags on records

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #1 from M. Tompsett  ---
mysql> show variables like '%char%';
+--++
| Variable_name| Value  |
+--++
| character_set_client | utf8   |
| character_set_connection | utf8   |
| character_set_database   | latin1 |
| character_set_filesystem | binary |
| character_set_results| utf8   |
| character_set_server | latin1 |
| character_set_system | utf8   |
| character_sets_dir   | /usr/share/mysql/charsets/ |
+--++
8 rows in set (0.00 sec)

mysql> set character_set_database=utf8mb4;
Query OK, 0 rows affected (0.00 sec)

mysql> set character_set_connection=utf8mb4;
Query OK, 0 rows affected (0.00 sec)

mysql> set character_set_client=utf8mb4;
Query OK, 0 rows affected (0.00 sec)

mysql> set character_set_results=utf8mb4;
Query OK, 0 rows affected (0.00 sec)

mysql> show variables like '%char%';
+--++
| Variable_name| Value  |
+--++
| character_set_client | utf8mb4|
| character_set_connection | utf8mb4|
| character_set_database   | utf8mb4|
| character_set_filesystem | binary |
| character_set_results| utf8mb4|
| character_set_server | latin1 |
| character_set_system | utf8   |
| character_sets_dir   | /usr/share/mysql/charsets/ |
+--++
8 rows in set (0.00 sec)

mysql> drop database test_unicode;
Query OK, 1 row affected (0.01 sec)

mysql> CREATE DATABASE test_unicode DEFAULT CHARACTER SET utf8 DEFAULT COLLATE
utf8_general_ci;
Query OK, 1 row affected (0.00 sec)

mysql> use test_unicode;
Database changed
mysql> create table simple_table (text varchar(100)) collate utf8_unicode_ci;
Query OK, 0 rows affected (0.01 sec)

mysql> INSERT INTO simple_table VALUES ('');
Query OK, 1 row affected, 1 warning (0.00 sec)

mysql> show warnings;
+-+--+---+
| Level   | Code | Message 
 |
+-+--+---+
| Warning | 1366 | Incorrect string value: '\xF0\x9F\x92\xA9' for column 'text'
at row 1 |
+-+--+---+
1 row in set (0.00 sec)

mysql> delete from simple_table;
Query OK, 1 row affected (0.00 sec)

mysql> drop table simple_table;
Query OK, 0 rows affected (0.00 sec)

mysql> create table simple_table (text varchar(100)) collate
utf8mb4_unicode_ci;
Query OK, 0 rows affected (0.02 sec)

mysql> INSERT INTO simple_table VALUES ('');
Query OK, 1 row affected (0.01 sec)

mysql> select * from simple_table;
+--+
| text |
+--+
|  |
+--+
1 row in set (0.00 sec)

mysql>

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15071] In OPAC search results, "checked out" status should be more visible

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071

--- Comment #10 from Owen Leonard  ---
Created attachment 48202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48202=edit
Bug 15071 - In OPAC search results, "checked out" status should be more visible

Compiled CSS file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15071] In OPAC search results, "checked out" status should be more visible

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071

--- Comment #9 from Owen Leonard  ---
Created attachment 48201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48201=edit
Bug 15071 - In OPAC search results, "checked out" status should be more visible

The prog template in the OPAC designated a color for the "unavailable"
class associated with items in search results which are checked out.
This class never made it into the Bootstrap theme. This patch adds it to
the Bootstrap theme's LESS file.

To test, apply the patch and search the OPAC for terms that will return
checked out items. In the list of search results, on the "availability"
line, the "Checked out" text should now be red. The change is visible
with XSLT on or off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15071] In OPAC search results, "checked out" status should be more visible

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15071] In OPAC search results, "checked out" status should be more visible

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071

Owen Leonard  changed:

   What|Removed |Added

Summary|red color on check outs |In OPAC search results,
   ||"checked out" status should
   ||be more visible

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15835] Koha::Object does not save changes

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15835

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #2 from Srdjan Jankovic  ---
Well I cannot make it happen now myself. Who knows what was going on...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15071] red color on check outs

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071

--- Comment #8 from Owen Leonard  ---
I suspect this was an omission during the prog -> bootstrap conversion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15071] red color on check outs

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15535] can't call method "default-privacy" on an undefined value /usr/share/koha/lib/c4/members.pm line 753

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15535

Owen Leonard  changed:

   What|Removed |Added

   Hardware|PC  |All
 OS|Linux   |All
  Component|OPAC|System Administration
 CC||gmcha...@gmail.com
   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15672] Show descriptions instead of codes on the hold ratios report

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15672

--- Comment #1 from Owen Leonard  ---
Created attachment 48200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48200=edit
Bug 15672 - Show descriptions instead of codes on the hold ratios report

This patch revises the hold ratios report so that it uses template
plugins to display descriptions instead of codes for item holding
branch, item home branch, item type, and library name.

To test you should have multiple items on the hold ratio report (set the
ratio to a small number to increase the number of results). It should
include one or more items which have a shelving location set.

View the hold ratios report and confirm that library names, shelving
location descriptions, and item type descriptions are shown instead of
codes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15672] Show descriptions instead of codes on the hold ratios report

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15672

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624

--- Comment #16 from Srdjan Jankovic  ---
Just curious, this test does not test any part of Koha. What if it fails?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15671] Show branch name instead of branch code in checkout history

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15671

--- Comment #1 from Owen Leonard  ---
Created attachment 48199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48199=edit
Bug 15671 - Show branch name instead of branch code in checkout history

When viewing the checkout history for a title the branchcode is
displayed. This patch alters the template to show the library name
instead.

To test, apply the patch and locate a title in the staff client which
has been checked out at least once. From the detail page, click
"Checkout history" in the sidebar. The "Checked out from" column of the
checkout history table should show the library name instead of the
branchcode.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15671] Show branch name instead of branch code in checkout history

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15671

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15671] Show branch name instead of branch code in checkout history

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15671

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15853] Add author and link columns to opac course reserves table

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15853

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 CC||nic...@bywatersolutions.com
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15853] New: Add author and link columns to opac course reserves table

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15853

Bug ID: 15853
   Summary: Add author and link columns to opac course reserves
table
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Course reserves
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To be done:

1 - Add an author column to the opac course reserves table
2 - Add a 'link' column to the opac course reserves table, populated from the
856$u field

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909

Jason Robb  changed:

   What|Removed |Added

 CC||jr...@sekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15852] New: 3M selfCheck do not connect

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15852

Bug ID: 15852
   Summary: 3M selfCheck do not connect
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: hblanc...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

Created attachment 48198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48198=edit
3m selfcheckout machines.

I have not idea but i before update to 3.22 have some errors  (every minute)in
connection  (attached image) in the log /var/log/koha/catalogo/sip-output.log 

SIP Timed Out!
SIP Timed Out!
LDAP bind failed as kohauser bibecsd1: LDAP error #49: LDAP_INVALID_CREDENTIALS
# The wrong password was supplied or the SASL credentials could not be
processed

I believe that the error its (SIP Timed Out!) but i do know how to solve this.
NOTE: the users, passwords an d branches are OK but the problem was imn
migration. 
The server has iptables but the policy its accept all; we have RAW
implementation no telnet

my configuration file its 
http://openncip.org/acs-config/1.0/;>

  


  

  







  




 
 
 



 
 


 






  


  


   





really appreciate your help.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics.

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
There are 2 ways in Koha to manage analytical records - one is EasyAnalytics,
which I think you are referring to. The other is using the "New child record"
option and is based on the bibliographic record only, without involving the
items. If you are using EasyAnalytics you could probably just hide the link
with CSS as it should not be needed. 

The basic problem is, that the parent record doesn't know in the MARC if it has
children... so we can't solve that only with XSLT, we need another way of
checking for children.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15851] New: "Analytics: Show analytics" showing regardless of whether they have analytics.

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851

Bug ID: 15851
   Summary: "Analytics: Show analytics" showing regardless of
whether they have analytics.
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: ed.v...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

All of records where position 7 of the leader indicates serial automatically
display "Analytics: Show analytics" -- regardless of whether they have
analytics. To confirm, we linked numerous items to host records in the case
where monographic volumes were bound together via the "Link to Host Item"
feature, automatically creating 773s. These are not in question and we do not
want to make any changes that would affect them. The request is to remove the
display "Analytics: Show analytics" for periodical records that do not have
analytics.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809

--- Comment #12 from Jonathan Druart  
---
(In reply to Galen Charlton from comment #10)

I totally agree with the "what to do next" part, but what about now? My patch
seems to match your requirements.

It could be very easy and quick to replace the different occurrences. I would
like to avoid a temporary solution. Even if we need one, something different
than "FIXME bug 2505" would be better ;)
Defining the CGi->multi_param method for < 4.08 and use CGI->param instead
looks, to me, the easiest and cleanest solution.
We will just need to remove it when >= 4.08 will be widely used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15847] Correct JSHint errors in basket.js in the staff client

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15847] Correct JSHint errors in basket.js in the staff client

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #48195|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 48197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48197=edit
[SIGNED-OFF]Bug 15847: Correct JSHint errors in basket.js in the staff client

This patch corrects minor errors in the staff client's basket.js
according to warnings raised by JSHint.

To test, apply the patch and run JSHint on basket.js. No warnings
should be raised.

To confirm that the behavior of the JS is not changed, clear your
browser cache if necessary and:

- Test adding multiple titles to the Cart from staff client search
  results.
- Confirm that adding titles to the Cart triggers a message by the Cart
  link.
- Test clicking the "Cart" link in the header menu when the Cart popup
  is open but behind the main window.
- Testing emptying the Cart.

Signed-off-by: Hector Castro 
Works as described. No warnigns raised with jshint tool

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10616] hold warning needs design work

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10616

Owen Leonard  changed:

   What|Removed |Added

  Attachment #19804|0   |1
is obsolete||

--- Comment #5 from Owen Leonard  ---
Created attachment 48196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48196=edit
Screenshot in current master

> Revert waiting status & Check out
> Cancel hold & Check out
> No, don't check out

Thos options would be more accurate too since the current interface suggests
that 'Cancel hold' and 'Revert waiting status' are settings which apply to
/all/ the buttons, as if you could select 'cancel hold' and click 'Don't check
out' and have both happen. That's not the way it works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block"

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666

--- Comment #18 from bondiurbano  ---
(In reply to bondiurbano from comment #17)
> Holger,
> 
> I have made a second test (including bug 14101) on my local virtual machine 
> and the problem persists. 
> 
> - Release 3.22.3 + bug 14101
> - Automatic renewal cronjob was executed manually by me
> - Same parameters in issuing rules that were set in the first test 
> 
> Tell me how can I help from now on please.



Sorry, 14101 (pushed to master) and 14395 (passed QA) bugs were included.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block"

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666

--- Comment #17 from bondiurbano  ---
Holger,

I have made a second test (including bug 14101) on my local virtual machine 
and the problem persists. 

- Release 3.22.3 + bug 14101
- Automatic renewal cronjob was executed manually by me
- Same parameters in issuing rules that were set in the first test 

Tell me how can I help from now on please.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15349] Problem with email pattern check on forms

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15349

--- Comment #1 from Owen Leonard  ---
Koha is inconsistent about where an email formatted that way is acceptable. I
think before we could solve this we would need to either enable it everywhere
or at least identify where it is and isn't possible. See bug 9815 -
"<> can't contain "The Library" "

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15738] Summary page says item has no fines, but Fines tab says otherwise

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15738

Owen Leonard  changed:

   What|Removed |Added

   Severity|enhancement |normal
Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15738] Summary page says item has no fines, but Fines tab says otherwise

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15738

--- Comment #2 from Owen Leonard  ---
I'm pretty sure the "fines" column in the OPAC only shows overdue fines. What
you're describing sounds like a rental charge. Perhaps this bug should be be
"Show a rental charges column in the OPAC summary table."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #53 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.4

Thanks Jonathan and Josef

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15578] Authority tests skip and hide a bug

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #18 from Julian Maurice  ---
Patches pushed to 3.22.x, will be in 3.22.4

Thanks Jonathan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12239] Errors loading script under https in chrome

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12239

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8373] opacheader should not show in print layout

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8373

--- Comment #2 from Owen Leonard  ---
(In reply to Marc Véron from comment #1)
> Tested on current master with opac-shelves.pl:
> 
> If I use the browser's print preview, it looks OK. If I use the icon
> 'print', the whole page is printed, including the contents of the opacheader
> system preference.

I can't reproduce this bug either way. The opacheader  is contained within
the #header-region  which has a class of "noprint." Seems like you'd have
to have a display property applied to #opacheader to override the "noprint"
class to make it show up in a printout.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15669] alphabetize marc modification pulldowns

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15669

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15850] New: Correct JSHint errors in cataloging.js

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15850

Bug ID: 15850
   Summary: Correct JSHint errors in cataloging.js
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: koha-bugs@lists.koha-community.org,
m.de.r...@rijksmuseum.nl,
testo...@bugs.koha-community.org

Following coding guideline JS8: "Follow guidelines set by JSHint," some errors
should be corrected in cataloging.js

koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 43, col 31, The array
literal notation [] is preferable.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 49, col 72, Use '!==' to
compare with ''.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 99, col 13, 'i' is
already defined.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 116, col 17, 'id_input'
is already defined.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 182, col 37, 'olddiv' is
already defined.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 183, col 37,
'oldcontrol' is already defined.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 108, col 18, 'j' used
out of scope.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 108, col 26, 'j' used
out of scope.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 108, col 46, 'j' used
out of scope.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 109, col 27, 'j' used
out of scope.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 109, col 59, 'j' used
out of scope.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 110, col 28, 'j' used
out of scope.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 220, col 21, 'inputs' is
already defined.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 226, col 25, 'anchors'
is already defined.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 227, col 30, 'j' is
already defined.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 176, col 21,
'CloneButtonPlus' used out of scope.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 280, col 13, 'i' is
already defined.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 280, col 17, 'len' is
already defined.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 287, col 13, 'i' is
already defined.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 287, col 17, 'len' is
already defined.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 296, col 13,
'oldcontrol' is already defined.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 315, col 21, 'i' is
already defined.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 409, col 15, 'line' used
out of scope.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 425, col 34, 'line' used
out of scope.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 465, col 13, 'i' is
already defined.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 465, col 17, 'len' is
already defined.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 471, col 13, 'i' is
already defined.
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 471, col 17, 'len' is
already defined.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15849] New: Correct JSHint errors in additem.js

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15849

Bug ID: 15849
   Summary: Correct JSHint errors in additem.js
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: hector.hecax...@gmail.com,
koha-bugs@lists.koha-community.org,
testo...@bugs.koha-community.org

Following coding guideline JS8: "Follow guidelines set by JSHint," some errors
should be corrected in acq.js

koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 5, col 41, Use '!==' to
compare with '0'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 10, col 76, Use '===' to
compare with '0'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 19, col 17, Bad line
breaking before '||'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 35, col 97, Use '===' to
compare with '0'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 51, col 9, Bad line
breaking before '+'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 53, col 9, Bad line
breaking before '+'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 54, col 9, Bad line
breaking before '+'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 57, col 9, Creating global
'for' variable. Should be 'for (var i ...'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 68, col 25, Use '===' to
compare with 'undefined'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 88, col 41, Use '!==' to
compare with '0'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 95, col 24, Use '===' to
compare with '0'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 99, col 67, Use '===' to
compare with '0'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 103, col 31, Use '===' to
compare with '0'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 103, col 73, Use '===' to
compare with '0'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 113, col 37, The array
literal notation [] is preferable.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 115, col 13,
'dont_copy_fields' is already defined.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 116, col 13, Creating
global 'for' variable. Should be 'for (var i ...'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 122, col 58, Missing
semicolon.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 174, col 17, Use '===' to
compare with 'null'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 195, col 26, The object
literal notation {} is preferable.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 196, col 9, ['field'] is
better written in dot notation.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 196, col 30, The array
literal notation [] is preferable.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 197, col 9, ['value'] is
better written in dot notation.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 197, col 30, The array
literal notation [] is preferable.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 202, col 11, Creating
global 'for' variable. Should be 'for (var field ...'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 204, col 23, Use '===' to
compare with ''.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 207, col 31, The array
literal notation [] is preferable.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 212, col 21, ['field'] is
better written in dot notation.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 213, col 21, ['value'] is
better written in dot notation.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 208, col 69, Don't make
functions within a loop.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 222, col 21, Bad line
breaking before '+'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 223, col 21, Bad line
breaking before '+'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 230, col 18, Use '===' to
compare with 'false'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 241, col 18, Creating
global 'for' variable. Should be 'for (var field ...'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 247, col 25, Bad line
breaking before '+'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 248, col 29, Bad line
breaking before '||'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 249, col 25, Bad line
breaking before '+'.
koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 256, col 18, Use '===' to
compare with 'false'.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org

[Koha-bugs] [Bug 15848] New: Correct JSHint errors in acq.js

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15848

Bug ID: 15848
   Summary: Correct JSHint errors in acq.js
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: hector.hecax...@gmail.com,
testo...@bugs.koha-community.org

Following coding guideline JS8: "Follow guidelines set by JSHint," some errors
should be corrected in acq.js

koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 5, col 17, Do not use Number as
a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 11, col 21, Do not use Number
as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 25, col 24, Use '===' to
compare with '0'.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 40, col 13, Do not use Number
as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 44, col 18, Use '===' to
compare with '0'.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 44, col 32, Use '===' to
compare with ''.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 73, col 17, Use '===' to
compare with 'null'.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 74, col 17, Use '===' to
compare with 'null'.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 75, col 23, The array literal
notation [] is preferable.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 110, col 14, Do not use Number
as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 114, col 24, Use '===' to
compare with '0'.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 129, col 24, Do not use Number
as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 129, col 28, Missing '()'
invoking a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 134, col 15, Do not use Number
as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 134, col 19, Missing '()'
invoking a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 136, col 31, The array literal
notation [] is preferable.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 140, col 27, Use '===' to
compare with '0'.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 147, col 19, Do not use Number
as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 148, col 16, Do not use Number
as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 150, col 14, 'i' is already
defined.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 179, col 20, Do not use Number
as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 180, col 20, Do not use Number
as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 181, col 24, Do not use Number
as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 182, col 20, Do not use String
as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 183, col 25, Do not use Number
as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 186, col 17, Do not use Number
as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 189, col 17, Do not use Number
as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 191, col 18, Do not use Number
as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 220, col 13, Use '===' to
compare with 'null'.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 220, col 28, Use '===' to
compare with ''.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 258, col 24, eval can be
harmful.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 267, col 6, Missing semicolon.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 287, col 50, Missing semicolon.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 287, col 52, Unnecessary
semicolon.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 288, col 66, Missing semicolon.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 288, col 67, Unnecessary
semicolon.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 302, col 18, eval can be
harmful.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 336, col 18, eval can be
harmful.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15847] Correct JSHint errors in basket.js in the staff client

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15847] Correct JSHint errors in basket.js in the staff client

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847

--- Comment #1 from Owen Leonard  ---
Created attachment 48195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48195=edit
Bug 15847 - Correct JSHint errors in basket.js in the staff client

This patch corrects minor errors in the staff client's basket.js
according to warnings raised by JSHint.

To test, apply the patch and run JSHint on basket.js. No warnings
should be raised.

To confirm that the behavior of the JS is not changed, clear your
browser cache if necessary and:

- Test adding multiple titles to the Cart from staff client search
  results.
- Confirm that adding titles to the Cart triggers a message by the Cart
  link.
- Test clicking the "Cart" link in the header menu when the Cart popup
  is open but behind the main window.
- Testing emptying the Cart.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809

--- Comment #11 from Galen Charlton  ---
Yet another way to do it would be to make Koha::CGI be a full (but thin) OO
wrapper around CGI.pm.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809

Galen Charlton  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #10 from Galen Charlton  ---
So, ->param() starts displaying warnings when evaluated in list context as of
CGI.pm 4.05.  ->multi_param() was added in 4.08 as a way of saying "I really
want multiple parameter values, don't make me do { $CGI::LIST_CONTEXT_WARN = 0;
@f = $q->param('foo'); } just to quell the warning."

To deal with the most common exploit scenario, "git grep '=>.*->param'" turns
up ~270 cases where we most likely *don't* want multi_param(); rather, we want
to wrap ->param in scalar(...).  I think that should be the first priority.

"git grep '@.*->param'" turns up 332 places in 120 files where a parameter is
intentionally being fed into a list.  I'm not keen about monkey-patching a core
module, though I recognize the expediency of it; but if we go that route so
that we can start using ->multi_param() across the board, I think we
*shouldn't* set $CGI::LIST_CONTEXT_WARN.  An alternative would be adding a
bunch of "local $CGI::LIST_CONTEXT_WARN = 0;" and making a note to ourselves to
replace that with ->multi_param() once we're past the point where stable Linux
distros ship CGI.pm older than 4.08.  We could also do it like this:

Change:

   @f = $cgi->param('foo');

To:

  @f = Koha::CGI::multi_param($cgi, 'foo');

where Koha::CGI::multi_param looks something like this:

sub multi_param {
my ($cgi, $param) = @_;
local $CGI::LIST_CONTEXT_WARN = 0;
return $cgi->param($param);  
}

That way, we're not monkey-patching a core module and we get something that we
can mechanically translate to $cgi->multi_param once we're assured of having a
recent enough version of CGI.pm.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15847] Correct JSHint errors in basket.js in the staff client

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847

Owen Leonard  changed:

   What|Removed |Added

Summary|Correct JSHint errors in|Correct JSHint errors in
   |basket.js   |basket.js in the staff
   ||client

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15847] New: Correct JSHint errors in basket.js

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847

Bug ID: 15847
   Summary: Correct JSHint errors in basket.js
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: hector.hecax...@gmail.com,
testo...@bugs.koha-community.org

Following coding guideline JS8: "Follow guidelines set by JSHint," some errors
should be corrected in basket.js

basket.js: line 53, col 36, Use '===' to compare with '0'.
basket.js: line 85, col 42, Missing semicolon.
basket.js: line 210, col 5, Implied eval. Consider passing a function instead
of a string.
basket.js: line 219, col 44, Missing semicolon.
basket.js: line 243, col 46, Missing semicolon.
basket.js: line 251, col 29, Use '===' to compare with '0'.
basket.js: line 270, col 13, 'valCookie' is already defined.
basket.js: line 305, col 13, Use '===' to compare with 'undefined'.
basket.js: line 409, col 25, The array literal notation [] is preferable.
basket.js: line 416, col 25, Use '===' to compare with '0'.
basket.js: line 432, col 33, Missing semicolon.
basket.js: line 1, col 11, Missing semicolon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15846] Move MARC Framework JavaScript into separate file

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15846

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #48193|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 48194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48194=edit
[SIGNED-OFF]Bug 15846: Move MARC Framework JavaScript into separate file

The JavaScript embedded in the MARC framework template is not
dependent on template processing to such an extent that it can't
be safely moved to a separate file. This patch does so, adding
definition of a few translatable strings to the template.

To test, apply the patch and go to Administration -> MARC frameworks.

- The table of existing frameworks should be sortable.
- The "Export" link should trigger the export modal.
- The "Import" link should trigger the import modal.
  -- Clicking "Import" without selecting a file should trigger an alert.
  -- Selecting the wrong file type should trigger an alert.
  -- Importing a file of the correct type should trigger an overwrite
 warning ("Do you really want to import...?").
  -- A progress indicator should show during the import, with correct
 values for "Importing from" and "Importing to".
  -- Importing an incorrectly-formatted file of a correct type should
 trigger an alert, "Error importing the framework..."

Signed-off-by: Hector Castro 
Works as advertised. Export and Import options work properly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15846] Move MARC Framework JavaScript into separate file

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15846

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15846] Move MARC Framework JavaScript into separate file

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15846

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15846] Move MARC Framework JavaScript into separate file

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15846

--- Comment #1 from Owen Leonard  ---
Created attachment 48193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48193=edit
Bug 15846 - Move MARC Framework JavaScript into separate file

The JavaScript embedded in the MARC framework template is not
dependent on template processing to such an extent that it can't
be safely moved to a separate file. This patch does so, adding
definition of a few translatable strings to the template.

To test, apply the patch and go to Administration -> MARC frameworks.

- The table of existing frameworks should be sortable.
- The "Export" link should trigger the export modal.
- The "Import" link should trigger the import modal.
  -- Clicking "Import" without selecting a file should trigger an alert.
  -- Selecting the wrong file type should trigger an alert.
  -- Importing a file of the correct type should trigger an overwrite
 warning ("Do you really want to import...?").
  -- A progress indicator should show during the import, with correct
 values for "Importing from" and "Importing to".
  -- Importing an incorrectly-formatted file of a correct type should
 trigger an alert, "Error importing the framework..."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840

--- Comment #8 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #7)
> What is meant by 'still used' - can you explain?

s/still/already !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15846] Move MARC Framework JavaScript into separate file

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15846

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15846] New: Move MARC Framework JavaScript into separate file

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15846

Bug ID: 15846
   Summary: Move MARC Framework JavaScript into separate file
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: hector.hecax...@gmail.com,
testo...@bugs.koha-community.org

Coding guideline JS1
(https://wiki.koha-community.org/wiki/Coding_Guidelines#JS1:_Embedding_JavaScript_blocks_in_templates)
says "Whenever possible JavaScript should be placed in a separate file."

The JavaScript embedded in admin/biblio_framework.tt is not so dependent on
template processing that it can't be safely moved to a separate file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14616] Introducing Koha::Object subclasses

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14616

--- Comment #10 from M. Tompsett  ---
Comment on attachment 41532
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41532
Bug 14616 - Introducing Koha::Object subclasses

Review of attachment 41532:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14616=41532)
-

::: Koha/Biblio.pm
@@ -44,5 @@
>  }
>  
> -=head1 AUTHOR
> -
> -Kyle M Hall 

Why is this being removed? I don't think Biblio.pm shouldn't even be in this
patch.

::: Koha/Biblios.pm
@@ +1,3 @@
>  package Koha::Biblios;
>  
> +# Copyright Open Source Freedom Fighters

This is an addition, not a replacement!

@@ +36,5 @@
>  }
>  
> +sub _get_castable_unique_columns {
> +return ['biblionumber'];
> +}

This is an addition, which is fine.

@@ -55,5 @@
>  
> -=head1 AUTHOR
> -
> -Kyle M Hall 
> -

Again, why is this removed?

::: Koha/Item.pm
@@ +1,4 @@
>  package Koha::Item;
>  
>  # Copyright ByWater Solutions 2014
> +# Copyright Open Source Freedom Fighters

Why add a copyright for nothing added?

::: Koha/Items.pm
@@ +61,5 @@
>  =cut
>  
> +sub _get_castable_unique_columns {
> +return ['itemnumber', 'barcode'];
> +}

Like this! Nice, sharing credit, with a functionality addition.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840

--- Comment #6 from Jonathan Druart  
---
Ok, got it.
I almost have a patch, what should we do if the userid is still used?
1/ Generate a new one, insert the patron and display a warning
or
2/ Do not insert the patron and display an error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840

--- Comment #7 from Katrin Fischer  ---
What is meant by 'still used' - can you explain?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15844] Correct JSHint errors in staff-global.js

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15844

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15844] Correct JSHint errors in staff-global.js

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15844

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #48188|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 48192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48192=edit
Bug 15844 - Correct JSHint errors in staff-global.js

This patch corrects minor errors in staff-global.js according to
warnings raised by JSHint.

To test, apply the patch and run JSHint on staff-global.js. No warnings
should be raised.

To confirm that the behavior of the JS is not changed, clear your
browser cache if necessary and:

- Confirm that the "Help" link opens the help window.
- Confirm that audio alerts work with local and remote sound files
- Confirm that the format() method is still working correctly by, for
  instance, opening the detail page for a bibliographic record with
  multiple items and choosing 'Edit -> Delete record' from the menu. The
  error message should read like "2 item(s) are attached to this
  record..."

Signed-off-by: Hector Castro 
Works as described. No errors with JSHint CLI (6 errors fixed)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15843] Move MARC subfields structure JavaScript into separate file

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15843

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #48185|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 48191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48191=edit
[SIGNED-OFF]Bug 15843: Move MARC subfields structure JavaScript into separate
file

The JavaScript embedded in the MARC subfields structure template is not
dependent on template processing and can safely be moved to a separate
file. This patch does so. Removed in the process is some lines which
were commented out.

To test, apply the patch and go to Administration -> MARC framworks.

 - Click 'MARC structure' for a framework you can edit.
 - Click 'subfields' for a tag you can edit.
 - Click 'Edit' for a subfield you can edit.
 - Confirm that tabs and accordian sections work correctly.
 - Make changes under Advanced constraints -> Visibility and confirm
   that they are saved correctly.

Signed-off-by: Hector Castro 
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15843] Move MARC subfields structure JavaScript into separate file

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15843

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15842] Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15824] 'Done' button is unclear on batch item modification and deletion

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
After modifying items (from the catalogue/detail.pl), I get a screen with:

5 item(s) modified (with 5 fields modified).
Return to where you were 
[TABLE]
Done button

If I click on the done button, I am not redirected to the detail page but the
still on the batch tool with the same screen "item(s) modified (with fields
modified)."

The submit button you have added is in a form, the window.location.href does
not work and the form is submitted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15842] Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842

Kyle M Hall  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15842] Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842

--- Comment #1 from Kyle M Hall  ---
Created attachment 48190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48190=edit
Bug 15842 - Cannot import patrons if the csv file does not contain
privacy_guarantor_checkouts

When importing patrons with a csv file which does not contain the
privacy_guarantor_checkouts column in the header, you will get
DBIx::Class::Storage::DBI::_dbh_execute(): Column 'privacy_guarantor_checkouts'
cannot be null at /home/koha/src/C4/Members.pm line 768

The same issue seems to occur for sms_provider_id.

Test Plan:
1) Attempt to import patron csv file with no privacy_guarantor_checkouts column
2) Note the error
3) Apply this patch
4) Repeat step 1
5) The error should no longer occur

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15845] Renewal date in circulation.pl is not always correct and not even used

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15845

Marcel de Rooy  changed:

   What|Removed |Added

Version|unspecified |master
   Patch complexity|--- |Trivial patch
   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |
   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15822] STAFF Advanced search error date utils

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822

--- Comment #12 from Héctor Eduardo Castro Avalos  
---
Your records look good, Humberto.

I could see that in my records I don't have biblioitems.cn_sort with any data
populated on it. And you got 340_110 in all records

Maybe Jonathan knows more about it, He got a lot of experience in Koha

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15822] STAFF Advanced search error date utils

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822

--- Comment #11 from Jonathan Druart  
---
I am sorry but I don't have enough information to help you.
On a test server, you could try to modify Koha::DateUtils::output_pref with:

+++ b/Koha/DateUtils.pm
@@ -220,6 +220,7 @@ sub output_pref {
 return unless defined $dt;

 # FIXME: see bug 13242 => no TZ for dates 'infinite'
+use Data::Dumper;warn Dumper caller;
 if ( $dt->ymd !~ /^/ ) {
 my $tz = $dateonly ? DateTime::TimeZone->new(name => 'floating') :
C4::Context->tz;
 $dt->set_time_zone( $tz );

Looking at the logs, you will know which routines has called it just before
crashing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15845] Renewal date in circulation.pl is not always correct and not even used

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15845

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15845] Renewal date in circulation.pl is not always correct and not even used

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15845

--- Comment #1 from Marcel de Rooy  ---
Created attachment 48189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48189=edit
Bug 15845: Renewal date in circulation.pl is not always correct and not even
used

If you have a patron category with a hard renewal date, the enrolllment
period will be zero. You cannot calculate the renewal date as is done
in the script currently.

Even more, the renewaldate template var is not even used.

Test plan:
[1] Verify that checkin/checkout works as expected.
[2] Git grep on renewaldate
[3] Check the code in circulation.pl for "$renew"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15844] Correct JSHint errors in staff-global.js

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15844

--- Comment #1 from Owen Leonard  ---
Created attachment 48188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48188=edit
Bug 15844 - Correct JSHint errors in staff-global.js

This patch corrects minor errors in staff-global.js according to
warnings raised by JSHint.

To test, apply the patch and run JSHint on staff-global.js. No warnings
should be raised.

To confirm that the behavior of the JS is not changed, clear your
browser cache if necessary and:

- Confirm that the "Help" link opens the help window.
- Confirm that audio alerts work with local and remote sound files
- Confirm that the format() method is still working correctly by, for
  instance, opening the detail page for a bibliographic record with
  multiple items and choosing 'Edit -> Delete record' from the menu. The
  error message should read like "2 item(s) are attached to this
  record..."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15844] Correct JSHint errors in staff-global.js

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15844

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #48177|Squashed followups into |Bug 14610 - Add ability to
description|main patch set for ease of  |place article requests in
   |reading.|Koha - Update database

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15845] New: Renewal date in circulation.pl is not always correct and not even used

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15845

Bug ID: 15845
   Summary: Renewal date in circulation.pl is not always correct
and not even used
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15820] suggestion.pl maximum internal redirects

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15820

--- Comment #5 from Jonathan Druart  
---
Are you using the default Koha Apache configuration file?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15822] STAFF Advanced search error date utils

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822

--- Comment #10 from Humberto Blanco  ---
This morning i have the same error when do this search
http://catalogo.urosario.edu.co/cgi-bin/koha/opac-search.pl?idx=kw=vivo=80_by=relevance_dsc
 

and get the error 
Software error:

Can't locate object method "ymd" via package "dateonly" (perhaps you forgot to
load "dateonly"?) at /usr/share/koha/lib/Koha/DateUtils.pm line 223.


In the QueryWeightFields KOHA preferences set to disabled.

and the query works fine.

but in the staff i have the same error in advanced search.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15820] suggestion.pl maximum internal redirects

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15820

--- Comment #4 from Humberto Blanco  ---
 (In reply to Jonathan Druart from comment #3)
> Could you confirm that the error still exists after you have modified the
> sql_mode mysql variable?

yes, now I see in the log

[Wed Feb 17 08:19:32.283271 2016] [core:error] [pid 817] [client
10.10.11.192:4002] AH00124: Request exceeded the limit of 10 internal redirects
due to probable configuration error. Use 'LimitInternalRecursion' to increase
the limit if necessary. Use 'LogLevel debug' to get a backtrace., referer:
http://catalogo.urosario.edu.co:8080/cgi-bin/koha/suggestion/suggestion.pl

ANd get 500 error

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15821] Use Font Awesome icons in confirmation dialogs - Circulation

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15818] OPAC search with utf-8 characters and without results generates encoding error

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15818

--- Comment #4 from Jonathan Druart  
---
% dpkg -l | grep libencode-perl

Does not return anything and 

% pmpath Encode
/usr/lib/i386-linux-gnu/perl/5.20/Encode.pm
% pmvers Encode
2.60

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809

--- Comment #9 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #8)
> (In reply to Jonathan Druart from comment #7)
> > The goal was to remove the warnings for production installs using CGI < 
> > 4.08.
> > As a developer, I am using > 4.08 and will see the warnings in my logs.
> 
> Older CGI versions do not have this warning. I am not sure about the exact
> version, but it could well be that the introduction of multi_param also
> added this warning.

You might be right. In this case, we could remove $CGI::LIST_CONTEXT_WARN = 0;
from the patch.

> How does your solution differentiate production from other installs?

It does not

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088

M. Tompsett  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #10 from M. Tompsett  ---
If you could test and sign off, Liz, I would be glad to have this set to signed
off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088

M. Tompsett  changed:

   What|Removed |Added

  Attachment #44347|0   |1
is obsolete||

--- Comment #8 from M. Tompsett  ---
Created attachment 48186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48186=edit
[SIGNED-OFF] Bug 15088 - notice when koha has been installed with --request-db
instead of --create-db

Patch does 2 major things -

* creates an options file during koha-create that lets us know what database
option was used when the instance was created
/etc/koha/sites/$name/createoptions
* when an instance is removed, we assume we can do things to the database, per
usual. If we have a createoptions, we'll read it and find out if our instance
was created with create-db or request-db.
If it was requested, we don't do anything with the database because we assume
we don't have rights to, and print a message.
If it was created, we do the same thing we've always done - remove the database
and users (unless we've specified --keep-mysql)

To test:

create a throwaway instance with --create-db
remove that instance, all should happen as normal.
your instance should have an /etc/koha/sites/$name/createoptions file with
REQUEST_DB=0 in it.

create another throwaway instance with --request-db
remove that instance, you should see a message alerting you to the fact that
you may still have database work to do after Koha is removed.
your instance should have an /etc/koha/sites/$name/createoptions file with
REQUEST_DB=1 in it.

NOTE: Only works in conjuction with my patch.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088

M. Tompsett  changed:

   What|Removed |Added

  Attachment #48184|0   |1
is obsolete||

--- Comment #9 from M. Tompsett  ---
Created attachment 48187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48187=edit
Bug 15088 - Follow for koha-create

Logic in the koha-create was requiring a DEFAULTSQL to trigger.
This patch moves it, such that --create-db will be registered
all the time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15844] New: Correct JSHint errors in staff-global.js

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15844

Bug ID: 15844
   Summary: Correct JSHint errors in staff-global.js
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

Following coding guideline JS8: "Follow guidelines set by JSHint," some errors
should be corrected in staff-global.js

staff-global.js: line 7, col 73, Missing semicolon.
staff-global.js: line 7, col 75, Missing semicolon.
staff-global.js: line 16, col 2, Unnecessary semicolon.
staff-global.js: line 103, col 13, 'newin' is already defined.
staff-global.js: line 125, col 39, Use '===' to compare with '0'.
staff-global.js: line 125, col 73, Use '===' to compare with '0'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15662] String and translatability fix to Label Creator

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15842] Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15840

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15842

--- Comment #5 from Jonathan Druart  
---
I don't reproduce, because the import patron tool is broken at the moment, by
bug 15842.
But looking at the code, I don't understand how it could happen, there is:

 733 $data{'userid'} = Generate_Userid( $data{'borrowernumber'},
$data{'firstname'}, $data{'surname'} )
 734   if ( $data{'userid'} eq '' || !Check_Userid( $data{'userid'} ) );

in C4::Members::AddMember which should avoid that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15843] Move MARC subfields structure JavaScript into separate file

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15843

--- Comment #1 from Owen Leonard  ---
Created attachment 48185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48185=edit
Bug 15843 - Move MARC subfields structure JavaScript into separate file

The JavaScript embedded in the MARC subfields structure template is not
dependent on template processing and can safely be moved to a separate
file. This patch does so. Removed in the process is some lines which
were commented out.

To test, apply the patch and go to Administration -> MARC framworks.

 - Click 'MARC structure' for a framework you can edit.
 - Click 'subfields' for a tag you can edit.
 - Click 'Edit' for a subfield you can edit.
 - Confirm that tabs and accordian sections work correctly.
 - Make changes under Advanced constraints -> Visibility and confirm
   that they are saved correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15843] Move MARC subfields structure JavaScript into separate file

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15843

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15843] New: Move MARC subfields structure JavaScript into separate file

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15843

Bug ID: 15843
   Summary: Move MARC subfields structure JavaScript into separate
file
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

Coding guideline JS1
(https://wiki.koha-community.org/wiki/Coding_Guidelines#JS1:_Embedding_JavaScript_blocks_in_templates)
says "Whenever possible JavaScript should be placed in a separate file."

The JavaScript embedded in admin/marc_subfields_structure.tt is not dependent
on template processing, so it can be safely moved to a separate file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15818] OPAC search with utf-8 characters and without results generates encoding error

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15818

--- Comment #3 from Dobrica Pavlinusic  ---
Jonathan, I'm wondering do you have libencode-perl package installed or are you
using Encode which ships with perl (and which version?).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15842


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842
[Bug 15842] Cannot import patrons if the csv file does not contain
privacy_guarantor_checkouts
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15842] New: Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842

Bug ID: 15842
   Summary: Cannot import patrons if the csv file does not contain
privacy_guarantor_checkouts
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: k...@bywatersolutions.com
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 9303

When importing patrons with a csv file which does not contain the
privacy_guarantor_checkouts column in the header, you will get

DBIx::Class::Storage::DBI::_dbh_execute(): Column 'privacy_guarantor_checkouts'
cannot be null at /home/koha/src/C4/Members.pm line 768


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303
[Bug 9303] relative's checkouts in the opac
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088

--- Comment #7 from M. Tompsett  ---
Created attachment 48184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48184=edit
Bug 15088 - Follow for koha-create

Logic in the koha-create was requiring a DEFAULTSQL to trigger.
This patch moves it, such that --create-db will be registered
all the time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809

--- Comment #8 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #7)
> The goal was to remove the warnings for production installs using CGI < 4.08.
> As a developer, I am using > 4.08 and will see the warnings in my logs.

Older CGI versions do not have this warning. I am not sure about the exact
version, but it could well be that the introduction of multi_param also added
this warning.
How does your solution differentiate production from other installs?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

2016-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #153 from Kyle M Hall  ---
Created attachment 48181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48181=edit
Bug 14610 - Update Schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 182 matches

Mail list logo