date:20160219

[Koha-bugs] [Bug 14893] Separate temporary storage per instance in Upload.pm

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #13 from Frédéric Demians  ---
Marcel, from my perspective, this patch is an enhancement, and as so shouldn't
enter into 3.20 branch. Am I wrong?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870

M. Tompsett  changed:

   What|Removed |Added

  Attachment #48260|0   |1
is obsolete||

--- Comment #3 from M. Tompsett  ---
Created attachment 48261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48261=edit
Bug 15870: MARC Filter to exclude fields/subfields lacking visibility

TEST PLAN
-
0) Apply 15777 and 15871 as required.
1) Apply patch
2) prove -v t/db_dependpent/RecordProcessor_ViewPolicy.t
   -- all should pass.
3) koha qa test tools.
BONUS
4) perlcritic -1 t/db_dependpent/RecordProcessor_ViewPolicy.t
   -- using the koha qa test tools perlcriticrc, it should pass
  though I am excluding checking print return values.
  (see bug 15646)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870

M. Tompsett  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870

--- Comment #2 from M. Tompsett  ---
Created attachment 48260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48260=edit
Bug 15870: MARC Filter to exclude fields/subfields lacking visibility

TEST PLAN
-
1) Apply patch
2) prove -v t/db_dependpent/RecordProcessor_ViewPolicy.t
   -- all should pass.
3) koha qa test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

  Attachment #46455|0   |1
is obsolete||

--- Comment #5 from Nick Clemens  ---
Created attachment 48258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48258=edit
Bug 14576 - Allow arbitrary automatic update of location on checkin

This patch adds a new syspref "UpdateItemLocationOnCheckin" which
accepts pairs of shelving locations.  On check-in the items location is
compared ot the location on the left and, if it matches, is updated to
the location on the left.

This preference replaces ReturnToShelvingCart and
InProcessingToShelvingCart preferences.  The update statement should
insert values that replciate these functions.  Note existing
functionality of all items in PROC location being returned to
permanent_location is preserved by default.  Also, any items issued from
CART location will be returned to their permanent location on issue (if
it differs)

Special values for this pref are:
_ALL_ - used on left side only to affect all items
_BLANK_ - used on either side to match on/set to blank (actual blanks
will work, but this is an easier to read option)
_PERM_ - used on right side only to return items to permanent location

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Set the new system preference UpdateitemLocationOnCheckin
   to the following (assuming sample data):
   NEW: FIC
   FIC: GEN
4) Create an item, set its location to NEW
5) Check in the item, note its location is now FIC
6) Check in the item again, note its location is now GEN
7) Check in the item again, note its location remains GEN
8) Test using _ALL_, _BLANK_ and _PERM_ for updates

Sponsored by:
Arcadia Public Library (http://library.ci.arcadia.ca.us/)
Middletown Township Public Library (http://www.mtpl.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

  Attachment #46456|0   |1
is obsolete||

--- Comment #6 from Nick Clemens  ---
Created attachment 48259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48259=edit
Bug 14576 - Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871

M. Tompsett  changed:

   What|Removed |Added

 Depends on||15777


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777
[Bug 15777] Refactor loop in which Record::Processor does not initialize
parameters
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777

M. Tompsett  changed:

   What|Removed |Added

 Blocks||15871


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871
[Bug 15871] Improve perl critic of t/RecordProcessor.t
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871

M. Tompsett  changed:

   What|Removed |Added

  Attachment #48255|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 48257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48257=edit
Bug 15871: Improve PerlCritic level for t/RecordProcessor.t

perlcritic -5 failed.
Attempt to clean up to a higher level:
-- use English to address use of $@ variable
-- perltidy on the code
-- substitute q{} for ''
-- expand out single line hacky goodness (... s/\.pm$//) to more code
-- remove parenthesis on functions that don't need it
-- add x, s, and m as needed to regexps
-- change double quotes to single quotes where no variable involved
-- tweaked eval destroy test to check return value and use $EVAL_ERROR
-- renamed $processor to $record_processor in the subtest to avoid
   lexical warnings

TEST PLAN
-

$ perlcritic -5 t/RecordProcessor.t
Don't modify $_ in list functions at line 43, column 25.  See page 114 of PBP. 
(Severity: 5)

$ perlcritic -2 t/RecordProcessor.t
No package-scoped "$VERSION" variable found at line 1, column 1.  See page 404
of PBP.  (Severity: 2)
Quotes used with a string containing no non-whitespace characters at line 34,
column 36.  See page 53 of PBP.  (Severity: 2)
Quotes used with a string containing no non-whitespace characters at line 34,
column 39.  See page 53 of PBP.  (Severity: 2)
Quotes used with a string containing no non-whitespace characters at line 36,
column 33.  See page 53 of PBP.  (Severity: 2)
Quotes used with a string containing no non-whitespace characters at line 36,
column 36.  See page 53 of PBP.  (Severity: 2)
Don't modify $_ in list functions at line 43, column 25.  See page 114 of PBP. 
(Severity: 5)
Regular expression without "/s" flag at line 43, column 33.  See pages 240,241
of PBP.  (Severity: 2)
Regular expression without "/x" flag at line 43, column 33.  See page 236 of
PBP.  (Severity: 3)
Regular expression without "/m" flag at line 43, column 33.  See page 237 of
PBP.  (Severity: 2)
Regular expression without "/s" flag at line 43, column 66.  See pages 240,241
of PBP.  (Severity: 2)
Regular expression without "/x" flag at line 43, column 66.  See page 236 of
PBP.  (Severity: 3)
Regular expression without "/m" flag at line 43, column 66.  See page 237 of
PBP.  (Severity: 2)
Expression form of "grep" at line 47, column 8.  See page 169 of PBP. 
(Severity: 4)
Expression form of "grep" at line 50, column 20.  See page 169 of PBP. 
(Severity: 4)
Regular expression without "/s" flag at line 50, column 26.  See pages 240,241
of PBP.  (Severity: 2)
Regular expression without "/m" flag at line 50, column 26.  See page 237 of
PBP.  (Severity: 2)
Return value of eval not tested at line 73, column 1.  You can't depend upon
the value of $@/$EVAL_ERROR to tell whether an eval failed.  (Severity: 3)
Magic punctuation variable $@ used at line 78, column 5.  See page 79 of PBP. 
(Severity: 2)
Reused variable name in lexical scope: $processor at line 84, column 5.  Invent
unique variable names.  (Severity: 3)
Subroutine "new" called using indirect syntax at line 87, column 18.  See page
349 of PBP.  (Severity: 4)
Subroutine "new" called using indirect syntax at line 93, column 18.  See page
349 of PBP.  (Severity: 4)
Quotes used with a string containing no non-whitespace characters at line 96,
column 40.  See page 53 of PBP.  (Severity: 2)
Subroutine "new" called using indirect syntax at line 99, column 18.  See page
349 of PBP.  (Severity: 4)
Subroutine "new" called using indirect syntax at line 106, column 18.  See page
349 of PBP.  (Severity: 4)
$ prove -v t/RecordProcessor.t
t/RecordProcessor.t .. ok
All tests successful.
Files=1, Tests=13,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.22 cusr  0.02
csys =  0.25 CPU)
Result: PASS

$ prove -v t/RecordProcessor.t
...
$ git bz apply 15871

Repeat perlcritic level 2, and only $VERSION warning should exist.
Retest with the prove.
Run koha qa test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870

M. Tompsett  changed:

   What|Removed |Added

 Blocks||11592


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
[Bug 11592] opac detail scripts do not respect MARC tag visibility
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15870

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

M. Tompsett  changed:

   What|Removed |Added

 Depends on||15870


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870
[Bug 15870] Add Filter for MARC to respect visibility settings
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=11592

--- Comment #1 from M. Tompsett  ---
Correction, this will ONLY be the filter, and tests for the filter. OPAC stuff
will go on bug 11592.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871

M. Tompsett  changed:

   What|Removed |Added

 Blocks||15870


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870
[Bug 15870] Add Filter for MARC to respect visibility settings
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777

M. Tompsett  changed:

   What|Removed |Added

 Blocks||15870


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870
[Bug 15870] Add Filter for MARC to respect visibility settings
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870

M. Tompsett  changed:

   What|Removed |Added

 Depends on||15871


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871
[Bug 15871] Improve perl critic of t/RecordProcessor.t
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15872] Rancor: Ctrl-Shift-X has incorrect description in "Keyboard shortcuts"

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15872

Jesse Weaver  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871

M. Tompsett  changed:

   What|Removed |Added

 Blocks|15870   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870
[Bug 15870] Add Filter for MARC to respect visibility settings
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870

M. Tompsett  changed:

   What|Removed |Added

 Depends on|15871   |15777


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777
[Bug 15777] Refactor loop in which Record::Processor does not initialize
parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871
[Bug 15871] Improve perl critic of t/RecordProcessor.t
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15872] Rancor: Ctrl-Shift-X has incorrect description in "Keyboard shortcuts"

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15872

--- Comment #1 from Jesse Weaver  ---
Created attachment 48256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48256=edit
Bug 15872: Rancor: Ctrl-Shift-X has incorrect description in "Keyboard
shortcuts"

Should be "Delete current subfield."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15872] New: Rancor: Ctrl-Shift-X has incorrect description in "Keyboard shortcuts"

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15872

Bug ID: 15872
   Summary: Rancor: Ctrl-Shift-X has incorrect description in
"Keyboard shortcuts"
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Cataloging
  Assignee: jwea...@bywatersolutions.com
  Reporter: jwea...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Should be "Delete current subfield".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870

M. Tompsett  changed:

   What|Removed |Added

 Depends on||15871


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871
[Bug 15871] Improve perl critic of t/RecordProcessor.t
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871

M. Tompsett  changed:

   What|Removed |Added

 Blocks||15870


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870
[Bug 15870] Add Filter for MARC to respect visibility settings
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15871

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=6679

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871

--- Comment #1 from M. Tompsett  ---
Created attachment 48255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48255=edit
Bug 15871: Improve PerlCritic level for t/RecordProcessor.t

perlcritic -5 failed.
Attempt to clean up to a higher level:
-- use English to address use of $@ variable
-- perltidy on the code
-- substitute q{} for ''
-- expand out single line hacky goodness (... s/\.pm$//) to more code
-- remove parenthesis on functions that don't need it
-- add x, s, and m as needed to regexps
-- change double quotes to single quotes where no variable involved
-- tweaked eval destroy test to check return value and use $EVAL_ERROR
-- renamed $processor to $record_processor in the subtest to avoid
   lexical warnings

TEST PLAN
-

$ perlcritic -5 t/RecordProcessor.t
Don't modify $_ in list functions at line 43, column 25.  See page 114 of PBP. 
(Severity: 5)

$ perlcritic -2 t/RecordProcessor.t
No package-scoped "$VERSION" variable found at line 1, column 1.  See page 404
of PBP.  (Severity: 2)
Quotes used with a string containing no non-whitespace characters at line 34,
column 36.  See page 53 of PBP.  (Severity: 2)
Quotes used with a string containing no non-whitespace characters at line 34,
column 39.  See page 53 of PBP.  (Severity: 2)
Quotes used with a string containing no non-whitespace characters at line 36,
column 33.  See page 53 of PBP.  (Severity: 2)
Quotes used with a string containing no non-whitespace characters at line 36,
column 36.  See page 53 of PBP.  (Severity: 2)
Don't modify $_ in list functions at line 43, column 25.  See page 114 of PBP. 
(Severity: 5)
Regular expression without "/s" flag at line 43, column 33.  See pages 240,241
of PBP.  (Severity: 2)
Regular expression without "/x" flag at line 43, column 33.  See page 236 of
PBP.  (Severity: 3)
Regular expression without "/m" flag at line 43, column 33.  See page 237 of
PBP.  (Severity: 2)
Regular expression without "/s" flag at line 43, column 66.  See pages 240,241
of PBP.  (Severity: 2)
Regular expression without "/x" flag at line 43, column 66.  See page 236 of
PBP.  (Severity: 3)
Regular expression without "/m" flag at line 43, column 66.  See page 237 of
PBP.  (Severity: 2)
Expression form of "grep" at line 47, column 8.  See page 169 of PBP. 
(Severity: 4)
Expression form of "grep" at line 50, column 20.  See page 169 of PBP. 
(Severity: 4)
Regular expression without "/s" flag at line 50, column 26.  See pages 240,241
of PBP.  (Severity: 2)
Regular expression without "/m" flag at line 50, column 26.  See page 237 of
PBP.  (Severity: 2)
Return value of eval not tested at line 73, column 1.  You can't depend upon
the value of $@/$EVAL_ERROR to tell whether an eval failed.  (Severity: 3)
Magic punctuation variable $@ used at line 78, column 5.  See page 79 of PBP. 
(Severity: 2)
Reused variable name in lexical scope: $processor at line 84, column 5.  Invent
unique variable names.  (Severity: 3)
Subroutine "new" called using indirect syntax at line 87, column 18.  See page
349 of PBP.  (Severity: 4)
Subroutine "new" called using indirect syntax at line 93, column 18.  See page
349 of PBP.  (Severity: 4)
Quotes used with a string containing no non-whitespace characters at line 96,
column 40.  See page 53 of PBP.  (Severity: 2)
Subroutine "new" called using indirect syntax at line 99, column 18.  See page
349 of PBP.  (Severity: 4)
Subroutine "new" called using indirect syntax at line 106, column 18.  See page
349 of PBP.  (Severity: 4)
$ prove -v t/RecordProcessor.t
t/RecordProcessor.t .. ok
All tests successful.
Files=1, Tests=13,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.22 cusr  0.02
csys =  0.25 CPU)
Result: PASS

$ prove -v t/RecordProcessor.t
...
$ git bz apply 15871

Repeat perlcritic level 2, and only $VERSION warning should exist.
Retest with the prove.
Run koha qa test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871

M. Tompsett  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15871] New: Improve perl critic of t/RecordProcessor.t

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871

Bug ID: 15871
   Summary: Improve perl critic of t/RecordProcessor.t
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: mtomp...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

perlcritic -5 t/RecordProcessor fails with:
Don't modify $_ in list functions at line 43, column 25.  See page 114 of PBP. 
(Severity: 5)
This is because of a hacky good single line of code.

While correcting this for improved readability, attempt to get this to a higher
level of perl critic.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15870] New: Add Filter for MARC to respect visibility settings

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870

Bug ID: 15870
   Summary: Add Filter for MARC to respect visibility settings
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: mtomp...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

There needs to be a new filter for MARC::Records such that when a record is
processed a cloned record with hidden fields and sub-fields excluded.

This will only affect MARC::Records, and as such will leave some visibility
gaps still. This will only attempt to implement this filter on OPAC pages,
though the filter should be usable for the staff client as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870

M. Tompsett  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752

--- Comment #18 from Nick Clemens  ---
Okay, I attached a patch that 'works'

I used C4::Barcodes for generating the next barcode, however, this is
apparently broken for annual and hbyymmdd and the latter indicates it is
deprecated

Do we patch C4::Barcodes, or use ValueBuilder.pm basically copying code from
value_builder.pl?

Opinions?


(In reply to Jonathan Druart from comment #15)
> Ha yes ok, got it!
> You the previous item is not inserted, then the barcode cannot be generated.
> Maybe we could display a value in the barcode field to tell the user it will
> be auto-generated on saving.
> I would like to avoid a JS function to calculate the next barcode, we
> already have perl subroutines to do this job.
> 
> Katrin, could I get your opinion please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752

--- Comment #17 from Nick Clemens  ---
Created attachment 48254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48254=edit
Bug 14752 - [QA followup] Auto-Generate barcode if left blank and autoBarcode
is set

Adds a warning/notice to item form and modal that barcodes will be
auto-filled using syspref if autoBarcode is turned on

Fills in barcodes if passed in blank

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752

Nick Clemens  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15869] New: change framework on overlay

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869

Bug ID: 15869
   Summary: change framework on overlay
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

When you stage files for import you can choose how to handle matches.  One
option is to replace the existing record.  The problem is that many libraries
use this option to load a fuller record over a quick or fast record and the
framework doesn't change.  So you can choose the framework before importing but
that framework only applies to new records, it doesn't update records that are
being replaced or overlaid.  We should fix that to update the framework for all
items, not just new ones.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12561] Omnibus: Deprecate non-XSLT detail and result views

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15868] Ask for confirmation before deleting MARC modification template action

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15868

Owen Leonard  changed:

   What|Removed |Added

Summary|Ask for confirmation before |Ask for confirmation before
   |deleting MARC modification  |deleting MARC modification
   |template|template action

--- Comment #1 from Owen Leonard  ---
Sorry, I mean a MARC modification template action.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15868] New: Ask for confirmation before deleting MARC modification template

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15868

Bug ID: 15868
   Summary: Ask for confirmation before deleting MARC modification
template
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/tools/marc_modification_templates.pl
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

There is no client side or server side confirmation before deleting a MARC
modification template.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #48241|0   |1
is obsolete||

--- Comment #13 from Héctor Eduardo Castro Avalos  
---
Comment on attachment 48241
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48241
[SIGNED-OFF]Bug 15600: System preferences broken toolbar looks broken

(In reply to Owen Leonard from comment #12)
> No we don't need both patches. I think mine is the correct solution.

It's right, doing obsolete Chloe's patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15867] Move MARC modification templates JavaScript into separate file

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15867

--- Comment #1 from Owen Leonard  ---
Created attachment 48253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48253=edit
Bug 15867 - Move MARC modification templates JavaScript into separate file

The JavaScript embedded in the MARC modification templates template is
not dependent on template processing to such an extent that it can't
be safely moved to a separate file. This patch does so, adding
definition of a some translatable strings to the template.

Other minor changes: A couple of JSHint warnings corrected, a couple of
missing semicolons added to template markup.

To test, apply the patch and go to Tools -> MARC modification templates

- Confirm that The add/update form works normally with various actions
  (Add/update,Delete,Move, etc.).
- Confirm that template switching works correctly.
- Confirm that template deletion confirmation works correctly.
- Confirm that cancelling an edit works correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15867] Move MARC modification templates JavaScript into separate file

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15867

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15867] New: Move MARC modification templates JavaScript into separate file

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15867

Bug ID: 15867
   Summary: Move MARC modification templates JavaScript into
separate file
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org

Coding guideline JS1
(https://wiki.koha-community.org/wiki/Coding_Guidelines#JS1:_Embedding_JavaScript_blocks_in_templates)
says "Whenever possible JavaScript should be placed in a separate file."

The JavaScript embedded in tools/marc_modification_templates.tt is not so
dependent on template processing that it can't be safely moved to a separate
file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15866] New: No warning when deleting a rotating collection using the toolbar button

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15866

Bug ID: 15866
   Summary: No warning when deleting a rotating collection using
the toolbar button
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

If you are viewing the contents of or adding items to a rotating collection
(Tools › Rotating collections › Collection › Add or remove items) clicking the
"Delete" button in the toolbar will delete the collection without any
client-side or server-side warning.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15865] New: Standard header search form missing from SMS cellular providers page

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15865

Bug ID: 15865
   Summary: Standard header search form missing from SMS cellular
providers page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: System Administration
  Assignee: k...@bywatersolutions.com
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Administration pages which do not have their own special header search form
should use cat-search.inc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15864] New: SMS cellular providers link missing from administration sidebar menu

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15864

Bug ID: 15864
   Summary: SMS cellular providers link missing from
administration sidebar menu
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: System Administration
  Assignee: k...@bywatersolutions.com
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Even with SMS cellular provider management enabled, the link to SMS cellular
providers doesn't appear in the administration sidebar menu.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600

--- Comment #12 from Owen Leonard  ---
No we don't need both patches. I think mine is the correct solution.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15863] When creating a dictionary for date column, date range selection should be hidden if all dates is selected

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15863

Marc Véron  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15863] When creating a dictionary for date column, date range selection should be hidden if all dates is selected

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15863

Marc Véron  changed:

   What|Removed |Added

  Attachment #48251|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 48252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48252=edit
Bug 15863: Show/hide date range selection if not needed - dictionnary

When creating a dictionary for a date column, there is a "date range" /
"all dates" radio buttons and 2 inputs to select the date range. These
inputs should be hidden if "all dates" is selected.

Test plan:
1/ Create a new dictionary on reports/dictionary.pl
2/ Select a date column (borrowers.dateofbirth of instance)
3/ On step 4, the start/end of the date range inputs should be
hidden/shown depending of the radio buttons.

Works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15856

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15856] Serials Software error when saving new subscription

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15856

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=7728

--- Comment #1 from Marc Véron  ---
It crashes because of the invalid subscription end date .

It does not crash with current version 3.22 and with current master.

Workaround for 3.18: Leave empty or enter a valid date for end date.

BTW: It seems that the end date should be empty while the subscription is
running, see Bug 7728

More related bugs: Bug 15484, Bug 15149

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13873] Lenghty tables do not properly print in Firefox

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13873

Marc Véron  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #1 from Marc Véron  ---
Can no longer reproduce with current Firefox version 44.0.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #11 from Jonathan Druart  
---
Do we need both patches?
With both patches applied, the button does not look disabled if nothing has
been changed, it's a bit confusing (and the cursor is the cursor is a pointer).

With only the following change, I get what is (I think) is expected:

diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
index b35e6be..06c39c2 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
@@ -422,7 +422,7 @@ dd {
font-weight : normal;
 }

-.btn-toolbar {
+div#toolbar, .btn-toolbar {
background-color : #EDF4F6;
  padding: 5px 5px 5px 5px;
   border-radius: 5px 5px 0 0;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14941] Subfield defaults: Add information about substitutable values

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14941

Marc Véron  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |neng...@gmail.com
  Component|Cataloging  |Documentation

--- Comment #1 from Marc Véron  ---
Changed to 'Documentation'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15863] When creating a dictionary for date column, date range selection should be hidden if all dates is selected

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15863

--- Comment #1 from Jonathan Druart  
---
Created attachment 48251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48251=edit
Bug 15863: Show/hide date range selection if not needed - dictionnary

When creating a dictionary for a date column, there is a "date range" /
"all dates" radio buttons and 2 inputs to select the date range. These
inputs should be hidden if "all dates" is selected.

Test plan:
1/ Create a new dictionary on reports/dictionary.pl
2/ Select a date column (borrowers.dateofbirth of instance)
3/ On step 4, the start/end of the date range inputs should be
hidden/shown depending of the radio buttons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15863] When creating a dictionary for date column, date range selection should be hidden if all dates is selected

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15863

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13835] Popup "Search for budget owner" should not display language menu in footer

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13835

Marc Véron  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

--- Comment #1 from Marc Véron  ---
Language selection is part of intranet-bottom.inc

A fix of this rather cosmetic issue would need to create a separate
'bottom.inc' for such popups.

Setting to RESOLVED WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13837] Popup "Search for garantor" should not display language menu in footer

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13837

Marc Véron  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #1 from Marc Véron  ---
Language selection is part of intranet-bottom.inc

A fix of this rather cosmetic issue would need to create a separate
'bottom.inc' for such popups.

Setting to RESOLVED WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15863

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15863] When creating a dictionary for date column, date range selection should be hidden if all dates is selected

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15863

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=2669

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15863] New: When creating a dictionary for date column, date range selection should be hidden if all dates is selected

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15863

Bug ID: 15863
   Summary: When creating a dictionary for date column, date range
selection should be hidden if all dates is selected
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

When creating a dictionary for a date column, there is a "date range" / "all
dates" radio buttons and 2 inputs to select the date range. These inputs should
be hidden if "all dates" is selected.

See bug 2669 comment 10 for the request.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13041] Can't add user as manager of basket if name includes a single quote

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15721] About page does not display Apache version

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721

Marc Véron  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #9 from Marc Véron  ---
I think the followup needs a sign-off. For test plan see comment #2.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15721] About page does not display Apache version

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721

--- Comment #8 from Marc Véron  ---
Created attachment 48250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48250=edit
Bug 15721: (followup) Add apache2ctl to C4::Context::get_versions

See comment #6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15718] Need more information for items that don't successfully batch checkout

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15718

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |In Discussion
 CC||katrin.fisc...@bsz-bw.de,
   ||neng...@gmail.com,
   ||oleon...@myacpl.org

--- Comment #3 from Jonathan Druart  
---
(In reply to Heather Braum from comment #2)
> Johnathan, what about something as simple as adding a table title for that
> screen, "items that didn't check out" or in the information column for each
> item, "item didn't check out?"
> 
> Is that possible?

(almost) Everything is possible :)
I agree there is an ergonomic issue, the different screens are not obvious
about what has been done and what will be done on the next screen.

I have cced Katrin, Nicole and Owen to get more ideas.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757

--- Comment #5 from Jonathan Druart  
---
I would consider it more an enhancement than as a blocker

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809

--- Comment #17 from Jonathan Druart  
---
(In reply to Galen Charlton from comment #16)
> (In reply to Jonathan Druart from comment #14)
> > Is anyone ready to submit a counter-patch?
> 
> Working on one that is intended to actually fix at least some of the
> potential vulnerabilities.  I feel that this bug's title is not ideal, as
> the focus should be on resolving potential misuse of CGI parameters, not
> merely on quelling noisy warnings in the logs.

The purpose of this first patch was to provide a quick fix to allow the use of
multi_param anywhere else.
The second step will be to get rid of the misuses of CGI->param

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15463] view_holdsqueue.tt uses a search for cardnumber instead of borrowernumber direct link

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15463

--- Comment #3 from Jonathan Druart  
---
circ/circulation.pl expects a cardnumber:

246 if ($findborrower) {
247 my $borrower = C4::Members::GetMember( cardnumber => $findborrower );
248 if ( $borrower ) {
249 $borrowernumber = $borrower->{borrowernumber};
250 } else {

If not found, the script will try and search the $findborrower using the
C4::Utils::DataTables::Members::search subroutine.

We will have to change all occurrences if we want to change this behavior, not
only view_holdsqueue.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15376] Edit invoices: Can not change Shipping cost.

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15376

Marc Véron  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|Failed QA   |RESOLVED

--- Comment #10 from Marc Véron  ---
Re-tested on current master, I can no longer reproduce the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15774] Additional fields for baskets

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #4 from Jonathan Druart  
---
The tablename is not saved when I create a new field for aqbasket.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15774] Additional fields for baskets

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jwea...@bywatersolutions.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15774] Additional fields for baskets

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #5 from Jonathan Druart  
---
Note that I would prefer to this patch based on top of bug 11844.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15774] Additional fields for baskets

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=11844

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11844] Additional fields for order lines

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15774

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404

--- Comment #7 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #5)
> QA Comment:
> I am not sure if this really is a better solution.
> I also doubt about the remark in comment 1 "Apparently older versions of
> Koha considered a MARC subfield in the frameworks that had a code longer
> than one character to be reserved for internal use". To me it just seems to
> be a trick to skip the internal fields lib, tab, mandatory and repeatable
> (all length>1).
> 
> In terms of design it would have been easier to put all subfields a level
> deeper instead of on the same level as lib, etc.
> 
> I understand about not changing the design of the structure here.

Yes, that would be a next step.

> But now we move the test length<>1 from a subroutine into the code and check
> if it is a ref or not.
> I probably would like to still have the test in the subroutine (with all
> benefits of a subroutine); another name would be fine.

Not sure it's needed, as the test is very simple.
Where would you move this subroutine?

> If someone wants to add some other property to the structure and suppose
> that is an arrayref or a hashref or an object, your test would fail.

Yes but it works for the moment :) The structure has not changed for years.

> I would propose to test (in the sub):
> [a] skip if the field name matches lib|tab|mandatory|repeatable

Imo, that would make the test less strong and too specific.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #48243|0   |1
is obsolete||

--- Comment #24 from Kyle M Hall  ---
Created attachment 48244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48244=edit
Bug 15635: Koha::Patron::Images - Add new classes

There are 3 subroutines in C4::Members to get, add and delete patron
images:
- GetPatronImage
- PutPatronImage
- RmPatronImage

By creating these 2 Koha::Patron::Image[s] classes, we could remove them
easily.

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635

--- Comment #29 from Kyle M Hall  ---
Created attachment 48249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48249=edit
Bug 15635 [QA Followup] - Fix number of unit tests

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635

--- Comment #27 from Kyle M Hall  ---
Created attachment 48247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48247=edit
Bug 15635: Koha::Patron::Images - Remove GetPatronImage

To retrieve a patron image, we can call Koha::Patron::Images->find or
Koha::Patrons->find->image
Both will return a Koha::Patron::Image object.

Test plan:
1/ From the patron/member module, open all tabs on the left (Checkouts,
detail, fines, etc.)
The image should be correctly displayed.
2/ At the OPAC, on the patron details page (opac-memberentry.pl) the
image should be displayed as well.
3/ Same on the sco module.

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635

--- Comment #25 from Kyle M Hall  ---
Created attachment 48245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48245=edit
Bug 15635: Koha::Patron::Images - Remove PutPatronImage

The C4::Members::PutPatronImage inserted/updated the image of a patron.
This can be done easily with ->find->set->store or ->new->store

Test plan:
1/ Modify the image of a patron from the patron detail page
2/ Add an image to a new patron
3/ Use the "Upload patron images" tools (tools/picture-upload.pl) to add
or modify the image of a patron
4/ Use the "Upload patron images" tools (tools/picture-upload.pl) to add
or modify the image of several patrons, using a zip file.
Stress the script trying to get as many errors as possible (wrong
cardnumber, wrong mimetype, file does not exist, etc.)
With this patch, if the cardnumber does not exist, you will get a
specific error "Image not imported because this patron does not exist in
the database"

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635

--- Comment #26 from Kyle M Hall  ---
Created attachment 48246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48246=edit
Bug 15635: Koha::Patron::Images - Remove RmPatronImage

The C4::Members::RmPatronImage just removed a row in patronimage.
This can be accomplished using the delete method of Koha::Patron::Image.

Test plan:
>From the patron defail page, try to delete the image of a patron.

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635

--- Comment #28 from Kyle M Hall  ---
Created attachment 48248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48248=edit
Bug 15635: Change method type to _type for bug 15446

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #48136|0   |1
is obsolete||
  Attachment #48137|0   |1
is obsolete||
  Attachment #48138|0   |1
is obsolete||
  Attachment #48139|0   |1
is obsolete||
  Attachment #48140|0   |1
is obsolete||

--- Comment #23 from Kyle M Hall  ---
Created attachment 48243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48243=edit
Bug 15635: Koha::Patron::Images - Add new classes

There are 3 subroutines in C4::Members to get, add and delete patron
images:
- GetPatronImage
- PutPatronImage
- RmPatronImage

By creating these 2 Koha::Patron::Image[s] classes, we could remove them
easily.

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #46962|0   |1
is obsolete||

--- Comment #9 from Héctor Eduardo Castro Avalos  ---
Created attachment 48241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48241=edit
[SIGNED-OFF]Bug 15600: System preferences broken toolbar looks broken

To test:

1-see without patch the toolbar looks transparent and "broken"
2-apply patch, with this the toolbar is solid and has new colours (including
the hover) -see screenshots for examples
3-try scrolling on different tabs to the left eg "OPAC" and that the style
continues with them

Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #48211|0   |1
is obsolete||

--- Comment #10 from Héctor Eduardo Castro Avalos  
---
Created attachment 48242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48242=edit
[SIGNED-OFF]Bug 15600: System preferences broken toolbar looks broken

This patch reverts some deletions made to staff-global.css in Bug 11559.
The deletions broke the appearance of the floating toolbar in system
preferences.

To test, apply the patch and clear your browser cache if necessary.

- Go to Administration -> System preferences and view a tab with enough
  content to allow you to scroll and test the appearance of the floating
  toolbar. Confirm that it looks correct.
- Open the advanced cataloging editor and confirm that its toolbar looks
  correct.
- Open the normal cataloging editor and confirm that the floating
  toolbar looks correct and works correctly.

Signed-off-by: Hector Castro 
Works as advertised. Tollbar looks correct

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15862] New: Cataloging editor should gracefully handle unknown biblionumbers

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15862

Bug ID: 15862
   Summary: Cataloging editor should gracefully handle unknown
biblionumbers
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

If you try to open a record in the basic MARC editor by passing bad or deleted
biblionumber you get an error:

Can't call method "title" on an undefined value at
/usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl line 827.

We should show a friendlier error message to the user.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15859] Move some basic MARC editor controls into settings menu

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15859

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15859] Move some basic MARC editor controls into settings menu

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15859

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #48234|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 48238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48238=edit
[SIGNED-OFF]Bug 15859: Move some basic MARC editor controls into settings menu

This patch moves the following options into a "Settings" menu inspired
by the one in the advanced editor:

- Switch to advanced editor
- Show MARC tag documentation links
- Show tags
- Change framework

To test, apply the patch and open a new or existing record in the
standard MARC editor.

- Test that the 'Switch to advanced editor' button option works.
- Test that the 'Show MARC tag documenation links' option works (and
  that your choice persists across sessions).
- Test that the initial settings for 'Show tags' respects the
  'hide_marc' system preference.
- Test that the 'Show tags' option works (and that your choice persists
  across sessions).
- Test that framework switching works correctly and that the menu
  correctly reflects your choice.
- Confirm that other toolbar functions work as expected, both in regular
  editing mode and Fast Cataloging.

Signed-off-by: Hector Castro 
Works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457

--- Comment #21 from Eivin Giske Skaaren  ---
Hi,

It seems like they have changed the url to http://api.libris.kb.se/bibspell/ so
perhaps some way of changing it without committing code would be good. Please
advise on the preferred solution.

As Katrin already said this is a specific API for the Swedish libraries so it
might not be useful for search in other languages. I also think it is very
specific to what is in their catalog, it is not a generic spell-checker but a
specialized one for existing library items.


PS.

Nice typo yes, thats what you get from coding on a laptop late at night :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15071] In OPAC search results, "checked out" status should be more visible

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #48202|0   |1
is obsolete||

--- Comment #12 from Nicole C. Engard  ---
Created attachment 48237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48237=edit
[SIGNED-OFF] Bug 15071 - In OPAC search results, "checked out" status should be
more visible

Compiled CSS file.

Signed-off-by: Nicole C Engard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15071] In OPAC search results, "checked out" status should be more visible

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #48201|0   |1
is obsolete||

--- Comment #11 from Nicole C. Engard  ---
Created attachment 48236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48236=edit
[SIGNED-OFF] Bug 15071 - In OPAC search results, "checked out" status should be
more visible

The prog template in the OPAC designated a color for the "unavailable"
class associated with items in search results which are checked out.
This class never made it into the Bootstrap theme. This patch adds it to
the Bootstrap theme's LESS file.

To test, apply the patch and search the OPAC for terms that will return
checked out items. In the list of search results, on the "availability"
line, the "Checked out" text should now be red. The change is visible
with XSLT on or off.

Signed-off-by: Nicole C Engard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15071] In OPAC search results, "checked out" status should be more visible

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15855] Disabling multiple submission on search form

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15855

--- Comment #1 from Arthur Suzuki  ---
Here is the code designed by Olivier :

// multi soumission Enter
var submitted;
$('#translControl1').bind('keyup',function() {
submitted = false;
});  
$('#translControl1').bind('keydown',function(event) {
   code = event.keyCode||event.which||event.charCode||event.char||0;
   if(code == 13) {
   if (submitted == false) {
   submitted = true;   
   $('#searchform').submit();
   } else {
   event.preventDefault();
   event.returnValue = false;
   return false;
   }
   }
});

The use of keyCode permits to submit form only once, and only uppon key down
event.
It prevents the users to fire multiple searches while holding the "Return" key
down (a behavior which is still possible with previously shared code).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15861] New: No chance to correctly translate an isolated word "The"

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15861

Bug ID: 15861
   Summary: No chance to correctly translate an isolated word
"The"
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

English: The
German: Der? Die? Das?

Locations:
intranet-tmpl/prog/en/modules/help/reports/reports-home.tt:11 
intranet-tmpl/prog/en/modules/help/reports/reports-home.tt:12 
intranet-tmpl/prog/en/modules/help/rotating_collections/rotatingCollections.tt:7

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15860] New: Alias missing for /plugin on packages

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15860

Bug ID: 15860
   Summary: Alias missing for /plugin on packages
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

Created attachment 48235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48235=edit
Broken image

There is an alias missing on the packages-shipped apache templates. It prevents
some things to show on the UI.

To test:
- Enable the plugins
- Install libmarc-lint-perl
- Install the MARC checker plugin
(https://github.com/bywatersolutions/koha-plugin-marc-checker)
- Run the plugin
=> FAIL: There's a broken image link (see attachment)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15859] Move some basic MARC editor controls into settings menu

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15859

--- Comment #1 from Owen Leonard  ---
Created attachment 48234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48234=edit
Bug 15859 - Move some basic MARC editor controls into settings menu

This patch moves the following options into a "Settings" menu inspired
by the one in the advanced editor:

- Switch to advanced editor
- Show MARC tag documentation links
- Show tags
- Change framework

To test, apply the patch and open a new or existing record in the
standard MARC editor.

- Test that the 'Switch to advanced editor' button option works.
- Test that the 'Show MARC tag documenation links' option works (and
  that your choice persists across sessions).
- Test that the initial settings for 'Show tags' respects the
  'hide_marc' system preference.
- Test that the 'Show tags' option works (and that your choice persists
  across sessions).
- Test that framework switching works correctly and that the menu
  correctly reflects your choice.
- Confirm that other toolbar functions work as expected, both in regular
  editing mode and Fast Cataloging.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15859] Move some basic MARC editor controls into settings menu

2016-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15859

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 142 matches

Mail list logo