[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #85 from Katrin Fischer  ---
Created attachment 49767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49767=edit
[PASSED QA] Bug 10612 [Follow-up] Combine and clarify menu items

This follow-up patch for Bug 10612 moves all list operations into one
menu while (hopefully) clarifying the labels for each.

Also in this patch: Changed datatables sorting configuration to use the
"nosort" attribute.

To test, apply the patch and go to Tools -> Patron lists.

- On a patron list with no patrons, confirm that the "Actions"
  menu lists "Add patrons," "Edit list," and "Delete list."
- On a patron list containing one or more patrons, confirm that the
  "Actions" menu /also/ has these options: "Print patron cards," "Batch
  edit patrons," and "Batch delete patrons."
- Confirm that the "actions" column is not sortable.
- Test logging in as a user who has various combinations of permission
  to batch edit and batch delete.

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #88 from Katrin Fischer  ---
Created attachment 49770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49770=edit
[PASSED QA] Bug 10612: (QA followup)

Rename not_borrowered_since to not_borrowed_since

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #87 from Katrin Fischer  ---
Created attachment 49769
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49769=edit
[PASSED QA] Bug 10612 - Unit tests

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #86 from Katrin Fischer  ---
Created attachment 49768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49768=edit
[PASSED QA] Bug 10612: Follow-up - correcting icon to be Font Awesome

- check print icon on the patron list summary page is correct

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #49596|0   |1
is obsolete||
  Attachment #49597|0   |1
is obsolete||
  Attachment #49607|0   |1
is obsolete||
  Attachment #49740|0   |1
is obsolete||
  Attachment #49741|0   |1
is obsolete||

--- Comment #84 from Katrin Fischer  ---
Created attachment 49766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49766=edit
[PASSED QA] Bug 10612 - Add ability to delete patrons with batch patron
deletion tool

This patch adds the ability to select a patron list for deletetion
when using the Batch patron deletion/anonymization tool. It also adds
buttons to the the patron lists table to access both the batch deletion
and batch modification directly from the lists view.

This is a squash of previous patches but now adds a patron_list_id
parameter to C4::Members::GetBorrowersToExpunge and uses that routine to
fetch patrons from a list.

Test Plan:
1) Apply this patch
2) Create a list of patrons with the new Patron Lists feature
3) Try using the batch edit link form the lists table
4) Try using the batch delete link from the lists table
5) Verify previous functionality has not changed

Signed-off-by: Owen Leonard 

Patron batches are correctly passed to the edit and delete pages.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669

--- Comment #11 from M. Tompsett  ---
Comment on attachment 49716
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49716
Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron
toolbar

Review of attachment 49716:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=3669=49716)
-

::: circ/add_message.pl
@@ +51,4 @@
>  }
>  )->store;
>  
> +my $url = $input->referer();

http://perldoc.perl.org/CGI.html
"referer()
Return the URL of the page the browser was viewing prior to fetching your
script. Not available for all browsers."
-- might be a good idea to // "/cgi...$borrowernumber";

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16177] Tests for ColumnsSettings are failing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16177

M. Tompsett  changed:

   What|Removed |Added

  Attachment #49727|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 49765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49765=edit
Bug 16177: Fix tests for ColumnsSsettings.t

This failure has been introduced by
  commit 243b797dd11bc0ac1f475195ab765ffbf2220f8b
Bug 15285: Update common files

This is because the cannot_be_modified key is not always created by
C4::Utils::DataTables::ColumnsSettings subroutines

Test plan:
  prove t/db_dependent/ColumnsSettings.t
should return green
And you can also test a table where the feature is set and a column
cannot be modified from the admin page.

NOTE: Works as described. I was pondering this potential
  solution when I found it in bugzilla.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16177] Tests for ColumnsSettings are failing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16177

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184

M. Tompsett  changed:

   What|Removed |Added

  Attachment #49760|0   |1
is obsolete||

--- Comment #6 from M. Tompsett  ---
Created attachment 49764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49764=edit
Bug 16184 - Report bor_issues_top shows incorrect number of rows

TEST PLAN
-
1) Have at least 6 patrons with checkouts and some checkins.
2) Reports -> Patrons with the most checkouts
3) Click 'Submit' (default is 5)
   -- more than 5 entries listed.
4) Apply patch
5) Refresh page
   -- only 5 entries listed.
6) Run koha qa test tools

NOTE: While this works, I'd be much happier with a refactor
  as it would also speed up the report. See comment #5.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #5 from M. Tompsett  ---
I'm not sure whether this patch is the best way to do it.
The whole query issues and old_issues via Perl seems like the wrong way to
handle the logic. I'm sure a better SQL query could be built with a UNION that
way the LIMIT and GROUP BY would be handled by MySQL instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
URL|http://staff-atz.dev.kohali |
   |brary.com/cgi-bin/koha/repo |
   |rts/bor_issues_top.pl   |

--- Comment #9 from M. Tompsett  ---
URL deleted as it links to the WRONG location.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750

M. Tompsett  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750

M. Tompsett  changed:

   What|Removed |Added

  Attachment #49762|0   |1
is obsolete||

--- Comment #8 from M. Tompsett  ---
Created attachment 49763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49763=edit
Bug 1750 - Report bor_issues_top erroneous and truncated results.

Signed-off-by: Mason James 

TEST PLAN
-
1) Ensure you have some checkouts
2) Home -> Reports
-> Patrons with the most checkouts
3) Click 'Submit'
   -- you get a list
4) Click a patron name.
5) Note the borrower number.
6) In MySQL run something like:
   > UPDATE borrower SET firstname=NULL WHERE borrowernumber=
7) Refresh the report page
   -- name goes totally blank
8) apply patch
9) Refresh the report page
   -- only first name is lost
10) run koha qa test tools

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750

--- Comment #7 from M. Tompsett  ---
Comment on attachment 49762
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49762
Bug 1750 - Report bor_issues_top erroneous and truncated results.

Review of attachment 49762:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=1750=49762)
-

::: reports/bor_issues_top.pl
@@ +279,4 @@
>  my $strcalc ;
>  
>  # Processing average loanperiods
> +$strcalc .= "SELECT  CONCAT_WS('', borrowers.surname , \",\\t\", 
> borrowers.firstname),  COUNT(*) AS RANK, borrowers.borrowernumber AS ID";

http://dev.mysql.com/doc/refman/5.7/en/string-functions.html#function_concat-ws
Nice! CONCAT_WS skips NULL entries, but still concat's, while CONCAT gives up
and returns NULL.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184

Mason James  changed:

   What|Removed |Added

 Depends on|1750|


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750
[Bug 1750] Report bor_issues_top erroneous and truncated results.
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750

Mason James  changed:

   What|Removed |Added

 Blocks|16184   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184
[Bug 16184] Report bor_issues_top shows incorrect number of rows
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184

Mason James  changed:

   What|Removed |Added

 Depends on||1750


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750
[Bug 1750] Report bor_issues_top erroneous and truncated results.
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750

Mason James  changed:

   What|Removed |Added

 Blocks||16184


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184
[Bug 16184] Report bor_issues_top shows incorrect number of rows
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184

Mason James  changed:

   What|Removed |Added

Summary|Bug 1750 - Report   |Report bor_issues_top shows
   |bor_issues_top shows|incorrect number of rows
   |incorrect number of rows|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750

Mason James  changed:

   What|Removed |Added

  Attachment #49758|0   |1
is obsolete||

--- Comment #6 from Mason James  ---
Created attachment 49762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49762=edit
Bug 1750 - Report bor_issues_top erroneous and truncated results.

Signed-off-by: Mason James 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184

--- Comment #3 from Mason James  ---
Created attachment 49761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49761=edit
before/after pic

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184

--- Comment #4 from Mason James  ---
A report with a LIMIT of 5 rows, will incorrectly return 10 rows (bad!)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184

Mason James  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184

--- Comment #2 from Mason James  ---
Created attachment 49760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49760=edit
Bug 16184 - Report bor_issues_top shows incorrect number of rows

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16184] Bug 1750 - Report bor_issues_top shows incorrect number of rows

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184

--- Comment #1 from Mason James  ---
This report always returns double the number of rows requested

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16184] New: Bug 1750 - Report bor_issues_top shows incorrect number of rows

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184

Bug ID: 16184
   Summary: Bug 1750 - Report bor_issues_top shows incorrect
number of rows
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: gmcha...@gmail.com
  Reporter: m...@kohaaloha.com
QA Contact: testo...@bugs.koha-community.org

Bug 1750 - Report bor_issues_top shows incorrect number of rows

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750

--- Comment #5 from Mason James  ---
FYI: the way this bug can be revealed is to have a borrower in the report with
either a NULL 'surname'  or 'firstname' value

If this occurs, CONCAT() makes the borrower.name value NULL (bad!)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750

Mason James  changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

--- Comment #4 from Mason James  ---
sorry, no test plan provided

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750

--- Comment #3 from Mason James  ---
Created attachment 49759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49759=edit
before/after pic

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750

--- Comment #2 from Mason James  ---
Created attachment 49758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49758=edit
Bug 1750 - Report bor_issues_top erroneous and truncated results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com
 Resolution|REMIND  |---
 Status|CLOSED  |REOPENED

--- Comment #1 from Mason James  ---
Woah, i think just hit this bug in 2016?!

I'll reopen this now..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16174] Problems in icondirectories.t and tt_valid.t due to bug 15527

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174

M. Tompsett  changed:

   What|Removed |Added

  Attachment #49737|0   |1
is obsolete||

--- Comment #7 from M. Tompsett  ---
Created attachment 49757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49757=edit
Bug 16174: (QA followup) Fix remaining tests

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16176] t/db_dependent/UsageStats.t is failing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16176

M. Tompsett  changed:

   What|Removed |Added

  Attachment #49726|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 49756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49756=edit
Bug 16176: Fix a test about OpenLibrarySearch

Introduced by bug 6624: When C4::UsageStats::BuildReport is modified,
the tests should be too.

Test plan:
  prove t/db_dependent/UsageStats.t
should return green

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16176] t/db_dependent/UsageStats.t is failing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16176

M. Tompsett  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16178] Tests for xt/single_quotes.t are failing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16178

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
  Attachment #49728|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #42240|0   |1
is obsolete||
  Attachment #42425|0   |1
is obsolete||

--- Comment #83 from Srdjan Jankovic  ---
Created attachment 49755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49755=edit
bug_11213: Check for $item->{itype} presence to avoid warning

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #42239|0   |1
is obsolete||

--- Comment #82 from Srdjan Jankovic  ---
Created attachment 49754
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49754=edit
bug_11213: Added XSLTParse4Display() to Items test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #42237|0   |1
is obsolete||
  Attachment #42238|0   |1
is obsolete||

--- Comment #81 from Srdjan Jankovic  ---
Created attachment 49753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49753=edit
bug_11213: GetItemsInfo() test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #42236|0   |1
is obsolete||

--- Comment #80 from Srdjan Jankovic  ---
Created attachment 49752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49752=edit
bug_11213: Include XSLT processing for searchResults() test

* Added template paths to temp test dir, so XSLT templates can be picked
  up

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #42235|0   |1
is obsolete||

--- Comment #79 from Srdjan Jankovic  ---
Created attachment 49751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49751=edit
bug_11213: whitespace correction

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #42234|0   |1
is obsolete||

--- Comment #78 from Srdjan Jankovic  ---
Created attachment 49750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49750=edit
bug_11213: Changed XSLTParse4Display() interface

The list of biblio items is passed on now, instead of GetItemsInfo() being
called. This is because the callers already have the list ready, so the
GetItemsInfo() call is being duplicated unnecessarily.
Search::searchResults() builds items list from XML, and that one is
passed instead.

* XSLT::XSLTParse4Display()
- supply the items list as input param
- removed hidden items list param - hidden should not be in the items
  list
- changed buildKohaItemsNamespace() accordingly

* Items
- removed GetItemsLocationInfo()
- added sort_by input param to GetItemsInfo()
- VirtualShelves::Page::shelfpage() - replaced GetItemsLocationInfo() call
  with GetItemsInfo() call, passing order_by "cn_sort"

* catalogue/detail.pl, opac/opac-detail.pl, shelfpage()
- added items list to the XSLTParse4Display() call

* Search::searchResults()
- include all available info when building items lists
- added combined items list (available, on loan, other) to the
  XSLTParse4Display() call

To test:
This change is a noop, so following screens need to be checked against
any changes:
* Intranet:
- catalogue/search.pl (results)
- catalogue/detail.pl
- virtualshelves/shelves.pl
* Opac
- opac-search.pl (results, hidelostitems syspref on and off)
- opac-detail.pl
- opac-shelves.pl

The display should stay the same before and after patch. The speed
should increase though.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15889] Login with LDAP deletes extended attributes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15889

Jesse Weaver  changed:

   What|Removed |Added

 CC||jwea...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #6 from Jesse Weaver  ---
Pushed to master, will be in the May 2016 release. Thanks for your work!

I had to manually apply this using git apply --reject, please make sure
everything is okay. Passed tests and QA tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16183] Add confirm message for deleting patron messages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16183

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16183] Add confirm message for deleting patron messages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16183

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16183] Add confirm message for deleting patron messages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16183

--- Comment #1 from Aleisha Amohia  ---
Created attachment 49749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49749=edit
Bug 16183: Confirm message upon deleting patron messages

To test:
1) Go to a patron circulation page and add a message
2) Click '[Delete]'
3) Confirm that a confirm dialog shows up and 'Cancel' and 'OK' do what is
expected.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16183] New: Add confirm message for deleting patron messages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16183

Bug ID: 16183
   Summary: Add confirm message for deleting patron messages
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16162] Making dictionary 'Delete' a font awesome button

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16162

Aleisha Amohia  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16162] Making dictionary 'Delete' a font awesome button

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16162

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #49715|0   |1
is obsolete||

--- Comment #6 from Aleisha Amohia  ---
Created attachment 49748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49748=edit
Bug 16162: Making dictionary 'Delete' a button

EDIT: This patch should have gotten rid of those tabs
EDIT2: Will now apply with patch on Bug 16161

To test:
1) Apply Bug 16161 first
2) Go to Reports -> View dictionary
3) Confirm that the 'Delete definition' button now just says 'Delete' and is
styled as a font awesome button.
4) Confirm that the button does not wrap on narrower browsers.
5) Confirm that column heading is now 'Action'.
6) Confirm that button deletes as expected. (If you're wondering about the
missing confirm message upon delete, see Bug 16161.)

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16182] Make phone number clickable to call

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16182] Make phone number clickable to call

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182

--- Comment #1 from Aleisha Amohia  ---
Created attachment 49747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49747=edit
Bug 16182: Make phone number clickable to call

To test:

1) Go to a patron detail page
2) Confirm that all available phone numbers can be clicked and allow you to
call this number from your device
a) in the top left circ-menu.inc
b) primary/secondary/other/organisation/mobile phone numbers
c) alternate address phone number
d) alternate contact phone number
e) enable the EnhancedMessagingPreferences system preference. check the
SMS number under Patron messaging preferences (back on the detail page) is
clickable
3) Check to see if there are any phone numbers I have missed.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16182] Make phone number clickable to call

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9259] batch delete marc batches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16182] New: Make phone number clickable to call

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182

Bug ID: 16182
   Summary: Make phone number clickable to call
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Email addresses are clickable on member detail pages. It would be good to have
phone numbers clickable in the same way.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9259] batch delete marc batches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259

Liz Rea  changed:

   What|Removed |Added

  Attachment #49609|0   |1
is obsolete||

--- Comment #2 from Liz Rea  ---
Created attachment 49746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49746=edit
Bug 9259: Ability to delete a staged file once it has been cleaned

To test:
1) Go to Tools -> Staged MARC Management and clean a file. If you have no files
to clean, go to 'Stage MARC for import' and upload one to clean following the
necessary steps.
2) Confirm that once the file has been cleaned, the Action column now shows a
Delete button. Confirm this button only shows for cleaned files.
3) Click the Delete button.
4) Confirm that clicking Cancel exits the pop-up message and does not delete
the file.
5) Confirm that clicking OK refreshes the list of staged records and the one
you just deleted is no longer on it (has been deleted). You can confirm this by
checking for the file in mysql (SELECT * FROM import_batches WHERE
import_batch_id = X;)

Sponsored-by: Catalyst IT
Signed-off-by: Liz Rea 
Catalyst sign off, so needs another one but YAY this is great.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16181] Limit number of tags loaded initially for tag cloud

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16181

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16181] New: Limit number of tags loaded initially for tag cloud

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16181

Bug ID: 16181
   Summary: Limit number of tags loaded initially for tag cloud
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

When a patron has an large number of tags (say 3,421) the tag cloud takes an
inordinately long time to load.

Maybe we could enforce a limit on initial load and then allow user to load more
or paginate through all?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/checking in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172

Liz Rea  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=14668

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/checking in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #10 from Liz Rea  ---
Is this duplicate in functionality to 14668?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14668] Show serial enumeration in the checkin page and the patron's opac checkout summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668

Liz Rea  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15172

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #14 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16041] StaffAuthorisedValueImages & AuthorisedValueImages preferences - impact on search performace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16041

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #4 from Liz Rea  ---
SUGGEST_FORMAT authorised values in the sample data come with image urls by
default, do we care about this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14512] Add support for AV field to Koha's SIP2 Server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14512

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #11 from Brendan Gallagher  ---
Pushed to master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16094] error editing (borrowers, reports) with mysql enterprise

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16094

--- Comment #4 from Humberto Blanco  ---
Jonathan, 
disabling those parameters do not work. Now the variable name sql_mode is empty
but the error is the same.

I modify the database structure for some of those errors,   from example in
addorder.pl when creating appear the following error:
DBIx::Class::Storage::DBI::_dbh_execute(): Field "budget_group_id" doesn´t have
a default value at /usr/share/koha/lib/

In mysql community i dont have those error but yes in enterprise.then i modify
the database structure.

ALTER TABLE aqorders ALTER COLUMN budgetgroup_id  SET DEFAULT 0;

I believe that is needle put this in the update database scripts.

Best regards!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Patch doesn't apply

--- Comment #15 from Brendan Gallagher  ---
Didn't apply cleanly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15931] If Authority is not used by any records, remove link to cataloguing search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15931

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #10 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16058] Add a button to delete an individual news item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16058

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #8 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16140] Only clear L1 cache when needed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140

--- Comment #23 from Jacek Ablewicz  ---
Some more benchmarks :), test setup: CGI, L2 = memcached, medium dataset (130K
biblio records, 300K items), one test run = log in + staff catalogue search for
'z' term (like in comment #5), XSLT processing enabled, numSearchResults = 100
(i.e 100 results / page), maxRecordsForFacets = 200, StaffAuthorisedValueImages
disabled (Bug 16041).

# master
146.05 (14.52+14.63+14.63+14.73+14.81+14.71+14.16+14.65+14.60+14.61)

# master + Bug 16166
90.7 (9.15+9.10+9.16+8.41+9.19+9.19+9.11+9.19+9.02+9.18)

# master + 2nd patch from Bug 16140 (aka don't clone framework/authvals)
71.61 (7.22+7.19+7.13+7.16+7.13+7.10+7.27+7.18+7.05+7.18)

# master + 2nd patch from Bug 16140 + Bug 16166
71.15 (7.11+7.10+7.20+7.22+7.19+6.52+7.24+7.28+7.10+7.19)

Shell test script from comment #5 does not quite work for me for some reasons

> % for i in {1..10}; do {time perl test.t > /dev/null} 2>> /tmp/time;done;
> echo $((`perl -pe 's/.*cpu ([^s]*) total/$1/' /tmp/time| tr '\n' '+'|sed > 
> 's/+$//'`)

looks like 'time' used in it is an internal shell subroutine of some kind,
specific for a given UX shell (which one - ?); instead, I used '/usr/bin/time
-n', and postproceesed timing results throug this simple perl script:


#!/usr/bin/perl

use Modern::Perl;

my @timings;
while (<>) {
chomp;
/^real ([\d\.]+)/ || next;
push(@timings, $1);
}

my $total = 0;
map { $total += $_; } @timings;
print $total." (".join('+', @timings).")\n";

Note that I'm measuring so-called "real" (wall clock) timings in here; I have
no idea what exactly is being measured in comment #5 - hopefully someting
similar?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16070] Empty (undef) system preferences may cause some issues in combination with memcache

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16070

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #9 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Webinstaller fails on MySQL 5.6

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Humberto Blanco  changed:

   What|Removed |Added

 CC||hblanc...@gmail.com

--- Comment #5 from Humberto Blanco  ---
Tomás, 
I have similar problem with mysql enterprise end i need to modify the database
structure.so:

ALTER TABLE aqorders ALTER COLUMN budgetgroup_id  SET DEFAULT 0;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663

--- Comment #25 from Nick Clemens  ---
Created attachment 49745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49745=edit
Bug 12663: (QA followup)

Insert SCOUserCSS/JS 'after' OPACUserCSS/JS rather than 'instead of'
i.e. Remove IF/ELSE and use 2 IF

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16092] Fix error dialog and use Font Awesome Icons when deleting branch group

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #8 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16152] Rename label management table column to Actions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16152

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16153] Adding "actions" class to Label Creator table actions so the buttons dont wrap

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16153

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Brendan Gallagher  ---
Pushed to Master - should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16178] Tests for xt/single_quotes.t are failing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16178

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16178] Tests for xt/single_quotes.t are failing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16178

--- Comment #2 from Nick Clemens  ---
Created attachment 49744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49744=edit
Bug 16178: Fix tests for xt/single_quotes.t

Caused by
  commit 9c5c1bc9f104b125e06b3805ce510024e6ad34ac
Bug 15206: Make strings translatable

Test plan:
  prove xt/single_quotes.t
should return green

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16129] Remove URL::Encode dependency

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16129

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||n...@bywatersolutions.com

--- Comment #3 from Nick Clemens  ---
Worked as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16129] Remove URL::Encode dependency

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16129

Nick Clemens  changed:

   What|Removed |Added

  Attachment #49419|0   |1
is obsolete||

--- Comment #2 from Nick Clemens  ---
Created attachment 49743
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49743=edit
Bug 16129: Remove URL::Encode dependency

This patch makes the PayPal integration feature independent from the
URL::Encode library, which is absent in some supported distributions.

It uses the URI package which is already a Koha dependency.

To test:
- Apply the patch
- Notice there are no deps for URL::Encode
- Follow the steps from the original patch
=> SUCCESS: It works as expected
- Sign-off :-D

Note: I deleted the line in which $amount_to_pay was url-encoded, because
that's
one of the things query_form does (and the variable is only used as a parameter
to it).

Sponsored-by: ByWater Solutions

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16163] Show message if there are no dictionary definitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16163

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16180] New: Receiving items with duplicate barcodes from import (addorderiso2709.pl) causes internal error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16180

Bug ID: 16180
   Summary: Receiving items with duplicate barcodes from import
(addorderiso2709.pl) causes internal error
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P3
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jwea...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

DBD::mysql::st execute failed: Duplicate entry 'O' for key 'itembarcodeidx' at
/usr/share/koha/lib/C4/Items.pm line 2171.
addorderiso2709.pl: DBD::mysql::st execute failed: Column 'itemnumber' cannot
be null at /usr/local/share/perl/5.10.1/DBIx/Class/Storage/DBI.pm line 1834.
DBIx::Class::Storage::DBI::_dbh_execute(): Column 'itemnumber' cannot be null
at /usr/share/koha/lib/Koha/Acquisition/Order.pm line 65

(Where "O" was the duplicate barcode in question)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11498] Prevent bypassing sco timeout with print dialog

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11498

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #8 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13132] Adding confirm message for deleting a report from the reports toolbar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #11 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15323] ./t/Prices.t fails without a valid database

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15323

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #17 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16103] Remove FK constraint for sms_provider_id in deletedborrowers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16103

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #49312|0   |1
is obsolete||

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 49742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49742=edit
Bug 16103: Remove FK sms_provider_id in deletedborrowers

This patch removes the FK constraint for sms_provider_id in table
deletedborrowers. (We do not need FKs in that table.)
It just corrects a newly added db revision in updatedatabase.
If this is pushed before releasing master, no need to do anything more.

Note that this key was not found in kohastructure and the DBIx schema.

Edit:

To test:
- With master DB run
  $ prove t/db_dependent/TestBuilder.t
=> SUCCESS: Tests pass
- Create a clean 3.22.00 DB
- Run the upgrade process
  $ perl installer/data/mysql/updatedatabase.pl
- Run
  $ prove t/db_dependent/TestBuilder.t
=> FAIL: Tests fail due to discrepancies in DB structure
- Re-create teh clean 3.22.00 DB
- Apply the patch
- Run the upgrade process
  $ perl installer/data/mysql/updatedatabase.pl
- Run
  $ prove t/db_dependent/TestBuilder.t
=> SUCCESS: Tests now pass

Signed-off-by: Marcel de Rooy 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16103] Remove FK constraint for sms_provider_id in deletedborrowers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16103

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Needs Signoff   |RESOLVED
 Resolution|--- |FIXED
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #2 from Brendan Gallagher  ---
Fixed in Master! (just pushed update)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13621] OpacTopissue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13621

Magnus Enger  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED
 CC||mag...@libriotech.no

--- Comment #2 from Magnus Enger  ---
No activity for a year ad then some - closing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15793] UX of circulation patron search with long lists of returned borrowers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15793

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #26 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16004] Replace items.new with items.new_status

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks  (schema upgraded
too)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16172] OAI Server tests broken by bug 15946

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16172

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #5 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16179] New: Clicking Rate me button in OPAC without selecting rating produces error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16179

Bug ID: 16179
   Summary: Clicking Rate me button in OPAC without selecting
rating produces error
 Change sponsored?: ---
   Product: Koha
   Version: 3.20
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: jyo...@esilibrary.com
QA Contact: testo...@bugs.koha-community.org

When a patron clicks on Rate me button on the detail screen without selecting a
rating option, the following error is produced:

Software error:

DBIx::Class::ResultSet::create(): Column 'rating_value' cannot be null at
/usr/share/koha/lib/C4/Ratings.pm line 208

For help, please send mail to the webmaster ([no address given]), giving this
error message and the time and date of the error

Related to this, patrons who are not logged in, can still click the Rate me
button, but are unable to make a rating selection and will get the error
message as a result.

Ideally, in either case, they would receive a more user-friendly message rather
than the error above.

Steps to reproduce:
0) Do not log in
1) Search the catalog for a title
2) View one of the search results
3) Click on the Rate me button

OR

0) Log in
1) Search the catalog for a title
2) View one of the search results
3) Click on the Rate me button

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16166] Improve L1 cache performance

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166

--- Comment #9 from Jacek Ablewicz  ---
(In reply to Jonathan Druart from comment #7)
> (In reply to Jonathan Druart from comment #6)
> > Created attachment 49730 [details] [review] [review]
> > Bug 16166: Try to add readability
> 
> I tried to add readability to the Koha::Cache method, but not sure I did it.

Some parts of it certainly look good to me, thanks. I skipped some parts
because:
- wrapping scalars in { value => ... } makes it a bit slower for caching small
scalars (like system preferences) - not much slower, but measurably slower, and
this patch set is supposed to be as speed-neutral as possible even in the
"worst case scenarios"
- I think that we need to keep a separatelly thawed structure in L1 for a sole
purpose of unsafe => 1 calls; if not, the "feature" described in comment #4
would be broken; also, there is no need to do 2nd thaw immediately / in
advance, it may be never used e.g. if all get_from_cache() calls for a given
key are of the "safe" kind (and a lot of scripts are doing just one single
call) - it's more optimal to delay 2nd thaw to the moment when the 1st "unsafe"
call is being made;
if the 1st call is "unsafe", there would be only one thaw
- I did s/{value}/{thawed}/ - there are too many $value variables in that code,
it's hard to distiguish what is what

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16007] Correction of 'Remove columns branchcode, categorytype from table overduerules_transport_types'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #23 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #83 from Nick Clemens  ---
Created attachment 49741
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49741=edit
Bug 10612: (QA followup)

Rename not_borrowered_since to not_borrowed_since

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

  Attachment #49694|0   |1
is obsolete||

--- Comment #82 from Nick Clemens  ---
Created attachment 49740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49740=edit
Bug 10612 - Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16171] Show many media (856) in html5media tab

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16171

--- Comment #5 from Alex Arnaud  ---
Thanks Mirko for testing and test plan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16166] Improve L1 cache performance

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166

Jacek Ablewicz  changed:

   What|Removed |Added

  Attachment #49730|0   |1
is obsolete||

--- Comment #8 from Jacek Ablewicz  ---
Created attachment 49739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49739=edit
Bug 16166: Try to improve code readability

Test plan addendum #2:

6) Don't forget to flush L2 cache (restart mecached deameon) after
testing as well - if you just return to master branch without this
step, all sorts of weird things would happen

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16171] Show many media (856) in html5media tab

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16171

Mirko Tietgen  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

--- Comment #4 from Mirko Tietgen  ---
I have been meaning to fix this, but nobody complained, so it was not high on
the list. Thanks Alex.

To test:
- Enable HTML5MediaEnabled
- Catalogue a record with two 856 fields, both having a video link in subfield
u (and mime type in subfield q)

Without the patch, you get only one video in the detail view in OPAC and staff
client. With patch applied, you see both videos.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/