[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #76 from David Cook  ---
1) Active Icarus tasks are now sorted by Task id
2) Fixed "Send to Icarus" blank page when Icarus offline
3) Changed "Enqueue" and "Dequeue" to "Download" and "Upload" respectively to
make it more clear what the tasks do. 
4) Uploading a Dublin Core record will no longer result in an empty MARC
record. It just won't create a new record at all.
--
5) There's now a tool at "tools/manage-oai-import.pl" which allows you to
manually fix deletion errors when a record is deleted upstream but it is unable
to be deleted automatically in Koha due to items, holds, etc.
6) Updated koha-conf.xml, rewrite-config.PL, and Makefile.PL, so now you can
use the standard install/upgrade process to configure Icarus without manual
changes to the file.
7) Some minor fixes to the logging readability
8) "deleted" OAI-PMH records should delete records in Koha, so long as there
are no normal obstacles to a user deleting the record in Koha.

--

TODO: 
a) Add paging to the "tools/manage-oai-imports" interface
b) Improve handling of import errors... 
c) Update kohastructure.sql and other structural files
d) Need to remove unhelpful logging
e) Need to improve the data validation when adding/updating saved tasks
f) Complete the navigation menus

Those are my current priorities. I have a list of other things I could do, but
I'll privilege tester feedback over that list.

--

It's a bit of a mammoth patch... in the end, it might be necessary to split it
into an "Icarus patch" and an "OAI-PMH patch".

Icarus itself is a background job manager, and the saved_task.pl page allows
user interaction with that. The only existing tasks for it right now are
OAI-PMH tasks, but the tasks can do anything. We could replace the existing
"Task scheduler" report emailer thing an Icarus plugin. 

The OAI-PMH patch is a web service and some hacking of Koha's existing MARC
import system.

While both are integral to Andreas's project, these two sets of functionality
can actually be tested independently.

I'm mostly interested in feedback about the OAI-PMH side of things. Icarus
itself is a bit rough, but it can be refined over time, or even replaced with a
different job manager. I'm mostly interested in how people want records to be
imported via OAI-PMH.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #95 from Srdjan Jankovic  ---
(In reply to Owen Leonard from comment #92)
> I'm having a problem with item information on two pages: opac-shelves.pl and
> opac-search.pl.

I have no probs with either of them. Changes in searchResults() are minor, the
main change is in buildKohaItemsNamespace(). I've tried opac-search.pl with
both XSLT on and off.

Can we please ask someone to check this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16268] Add confirm message when deleting circ and fines rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16268

--- Comment #1 from Aleisha Amohia  ---
Created attachment 50253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50253=edit
Bug 16268: Add confirm message for deleting circ and fines rules

To test:
1) Apply 16267
2) Go to Admin -> Circ and fines rules
3) Try clicking on Delete and Unset buttons
4) Confirm a confirm message pops up and works as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16268] Add confirm message when deleting circ and fines rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16268

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16267] Making circ and fines rules actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16267

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #50251|0   |1
is obsolete||

--- Comment #2 from Aleisha Amohia  ---
Created attachment 50252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50252=edit
Bug 16267: Making circ and fines rules actions buttons

To test:
1) Go to Admin -> Circulation and fines rules
2) Fines rules
a) Confirm that buttons Edit, Delete, Save, and Clear all show as font
awesome buttons and work as expected
2) Default checkout, hold and return policy
a) Confirm that column heading is now Actions
b) Confirm that actions Save and Unset show as font awesome buttons and
work as expected
3) Checkout limit by patron category AND holds policy by item type
a) Confirm that buttons Add and Delete show as font awesome buttons and
work as expected (you may need to add a rule to see the Delete button)
4) Confirm that none of the buttons wrap on a narrower browser

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16268] New: Add confirm message when deleting circ and fines rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16268

Bug ID: 16268
   Summary: Add confirm message when deleting circ and fines rules
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16267] Making circ and fines rules actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16267

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||16268


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16268
[Bug 16268] Add confirm message when deleting circ and fines rules
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16268] Add confirm message when deleting circ and fines rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16268

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com
   |ity.org |
 Depends on||16267


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16267
[Bug 16267] Making circ and fines rules actions buttons
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16267] Making circ and fines rules actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16267

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16267] Making circ and fines rules actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16267

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16267] Making circ and fines rules actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16267

--- Comment #1 from Aleisha Amohia  ---
Created attachment 50251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50251=edit
Bug 16267: Making circ and fines rules actions buttons

To test:
1) Go to Admin -> Circulation and fines rules
2) Default checkout, hold and return policy
a) Confirm that column heading is now Actions
b) Confirm that actions Save and Unset show as font awesome buttons and
work as expected
3) Checkout limit by patron category AND holds policy by item type
a) Confirm that buttons Add and Delete show as font awesome buttons and
work as expected (you may need to add a rule to see the Delete button)
4) Confirm that none of the buttons wrap on a narrower browser

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16267] New: Making circ and fines rules actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16267

Bug ID: 16267
   Summary: Making circ and fines rules actions buttons
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16266] Making patron types actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16266

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com
   |ity.org |
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16266] Making patron types actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16266

--- Comment #1 from Aleisha Amohia  ---
Created attachment 50250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50250=edit
Bug 16266: Making patron types actions buttons

To test:
1) Go to Admin -> Patron types & Categories
2) Confirm the actions Edit and Delete show as font awesome buttons and work as
expected
3) Confirm that the buttons do not wrap on a narrower browser

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16266] Making patron types actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16266

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #69 from Katrin Fischer  ---
Hi Julian,

there are a couple of problems here noted by he QA script:
- tabs
- license
- Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: possible typo (can
be ignored)

>From looking at the code:

1) This is a translation issue - please take a look at how other CSV exports
solve the problem.
+my @headers = ("Subscription title", "Routing list", qw(Surname Firstname
Notes));

2) Little typo: 
There is no borrowers in this routing list.
There are no... :)

3) How can you edit a routing list description? I tried to change the routing
lists created by the update - but failed to find a link.

4) I can add patrons to the subscription list, but the borrowers don't save.
Could you please check?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16266] New: Making patron types actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16266

Bug ID: 16266
   Summary: Making patron types actions buttons
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16265] Making item types actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16265

--- Comment #1 from Aleisha Amohia  ---
Created attachment 50249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50249=edit
Bug 16265: Making item types actions buttons

To test:
1) Go to Admin -> Item types
2) Confirm Edit and Delete show as font awesome buttons and work as expected
3) Confirm the buttons do not wrap with a narrower browser

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16265] Making item types actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16265

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16265] Making item types actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16265

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16265] New: Making item types actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16265

Bug ID: 16265
   Summary: Making item types actions buttons
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16264] New: Confirm message on deleting an authority framework subfield

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16264

Bug ID: 16264
   Summary: Confirm message on deleting an authority framework
subfield
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Authority data support
  Assignee: gmcha...@gmail.com
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

Just using this as an example because it appears in many places on the intranet

Is there a reason that we navigate to a new page to confirm or cancel a delete
rather than just using a Javascript confirm message? A JS message would use
much less code. I realise that in the past we had a rule that everything had to
work without JS enabled but a lot of stuff on the intranet wouldn't work at all
without JS so I'm not sure how much that applies anymore. Anyway, just
wondering if these extra pages for confirm or cancelling a delete are still
necessary or if we can do this via JS now :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263

--- Comment #1 from Aleisha Amohia  ---
Created attachment 50248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50248=edit
Bug 16263: making authority tags and subfields actions buttons

To test:
1) Go to Admin -> Authority types
2) Click the dropdown for one of the frameworks and click MARC structure
3) Confirm the actions subfields, edit and delete all show in the dropdown and
work as expected
4) Click subfields
5) Confirm the action delete on this page shows as a font awesome button and
works as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |aleishaamo...@hotmail.com
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16263] New: Making authority tags and subfields actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263

Bug ID: 16263
   Summary: Making authority tags and subfields actions buttons
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Authority data support
  Assignee: gmcha...@gmail.com
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

Moving the actions for authority framework tags into a drop down menu
Making the Delete action for subfields a font awesome button

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16235] Making borrower account actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #50137|0   |1
is obsolete||

--- Comment #5 from Aleisha Amohia  ---
Created attachment 50247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50247=edit
Bug 16235: Making borrower account actions buttons

EDIT: Fixing some indenting and adding actions class to the cells so the
buttons don't wrap

To test:
1) Go to a borrower's account page who has paid fines before
a) Confirm column heading is now 'Actions' and covers both Reverse
column and Print column
b) Confirm Reverse and Print show as buttons and work as expected
2) Go to a borrower's account page who has never paid fines (or create a new
borrower)
a) Create a manual credit (just to put something in their account)
b) Go back to their account page
c) Confirm the Reverse column does not show as the column heading for
Print is  (since there is only one action in this column and it's written
on every button)
d) Confirm Print shows as a button and works as expected

Sponsored-by: Catalyst IT

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16235] Making borrower account actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #236 from Chris Cormack  ---
Created attachment 50246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50246=edit
Bug 12478 Increasing test Coverage for
Koha::SearchEngine::Elasticsearch::Search

Before this patch it was 24.6%, after it is 64%

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #47663|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #47664|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #47662|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #235 from Chris Cormack  ---
With the 3 test files we have

Koha::ElasticSearch61.3% statement coverage
Koha::ElasticSearch::Indexer   56.9% statement coverage
Koha::SearchEngine::Elasticsearch::Search  24.6% statement coverage


I'll work now on increasing the coverage of them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Chris Cormack  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Chris Cormack  changed:

   What|Removed |Added

  Attachment #50213|0   |1
is obsolete||
  Attachment #50214|0   |1
is obsolete||

--- Comment #234 from Chris Cormack  ---
Created attachment 50245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50245=edit
Bug 12478 Shifting tests and adding copyright headers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14574] Correcting messages on intranet error pages so they make more sense

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14574

Sarah  changed:

   What|Removed |Added

 CC||sflo...@roseville.ca.us

--- Comment #5 from Sarah  ---
Just wanted to comment and say that on the demo, I am seeing that the 404
message reads "You tried to access a page that needs 'authentification'," which
is a typo. Should be authentication.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 906] ISBN Check

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=906

--- Comment #16 from Marjorie Barry-Vila  ---
Is anyone planning on following up on this bug?

Regards,

Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16208] Can't delete a library EAN if the EAN value is empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208

Katrin Fischer  changed:

   What|Removed |Added

 Blocks|7736|
 Depends on||7736


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736
[Bug 7736] Edifact QUOTE and ORDER functionality
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Katrin Fischer  changed:

   What|Removed |Added

 Depends on|16208   |
 Blocks||16208


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208
[Bug 16208] Can't delete a library EAN if the EAN value is empty
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498

Mirko Tietgen  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #3 from Mirko Tietgen  ---
>Wende an: Bug 15498: Let the user choose the CSV profile to export circ history
>fatal: sha1 information is lacking or useless (Koha/Exporter/Record.pm).
>Dem Repository fehlen notwendige Blobs um auf einen 3-Wege-Merge 
>zurückzufallen.
>Kann nicht zu 3-Wege-Merge zurückfallen.
>Anwendung des Patches fehlgeschlagen bei 0001 Bug 15498: Let the user choose 
>the CSV profile to export circ history
>Die Kopie des fehlgeschlagenen Patches befindet sich in:
>   /home/mirko/koha/.git/rebase-apply/patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15801] Move the framework related code to Koha::BiblioFramework[s] - part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||mi...@abunchofthings.net

--- Comment #9 from Mirko Tietgen  ---
Can't apply.

>fatal: sha1 information is lacking or useless (C4/Koha.pm).
>Dem Repository fehlen notwendige Blobs um auf einen 3-Wege-Merge 
>zurückzufallen.
>Kann nicht zu 3-Wege-Merge zurückfallen.
>Anwendung des Patches fehlgeschlagen bei 0001 Bug 15801: 
>Koha::BiblioFrameworks - Remove C4::Koha::getframeworkinfo

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16105] Cache::Memory is loaded even if memcache is used

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16105

Mirko Tietgen  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

--- Comment #2 from Mirko Tietgen  ---
(In reply to Jonathan Druart from comment #1)

> Correctly configure a memcache server and confirm that the memory cache
> is not initialize.

How do I do that (the second part)?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16262] Remove the use of "onclick" from acquisitions basket template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16262

--- Comment #1 from Owen Leonard  ---
Created attachment 50244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50244=edit
Bug 16262 - Remove the use of "onclick" from acquisitions basket template

In order to bring the acquisitions basket template into compliance with
coding guideline JS9, this patch changes with way some JavaScript events
are handled by moving JS handling out of the HTML markup.

Also changed: Replaced the use of [% script_name %] (which is
undefined), with the actual script path.

To test, apply the patch and locate an open basket in Acquisitions which
has more than one order in it.

- Test the "Managed by: Add user" button and verify that it triggers a
  popup where you can search for patrons.
  - Select two or more patrons to be managers for the basket.
  - Close the search windows and confirm that your choices appear on the
basket page.
  - Click "Delete user" next to one of the patrons. The patron should be
removed.
  - Click "Save changes" and verify that your choices are correctly
saved.
  - Click "Delete user" next to one of the remaining patrons. The patron
should be removed.
  - Click "Save changes" and verify that the patron stays deleted.
- In the list of orders, click the "Transfer" link and confirm that the
  correct pop-up window is triggered.
- Test the "Delete this basket" button in the toolbar. A modal window
  should be triggered.
  - In a basket with orders:
- The "Delete basket and orders" button should do what it says,
  leaving associated bibliographic records intact.
- The "Delete basket, orders, and records" button should do what it
  says, deleting any bibliographic records associated with orders.
  - In a basket with no orders:
- The "Delete basket" button should work correctly.
- Test the "Create edifact order" button.
  - Click "Send EDI order" on the resulting page.
  - In the resulting dialog, "Are you sure you want to generate an
edifact order," verify that both the "Yes" and "No" options work
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16262] Remove the use of "onclick" from acquisitions basket template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16262

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (testable without SIP server)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956

--- Comment #15 from Marcel de Rooy  ---
(In reply to Bernardo Gonzalez Kriegel from comment #14)
> Signed-off-by: Bernardo Gonzalez Kriegel 

Thx Bernardo!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16231] Correct permission handling in subscription edit menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16231

--- Comment #4 from Owen Leonard  ---
(In reply to Katrin Fischer from comment #3)

> If you follow 'cannotedit' through the code

That whole menu is wrapped in "[% UNLESS ( cannotedit ) %]," so I concluded
that the checks on "cannotedit" inside the menu were redundant. Does that sound
correct?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16206] Corrections to templates related new EDI feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206

Owen Leonard  changed:

   What|Removed |Added

 Blocks||16262


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16262
[Bug 16262] Remove the use of "onclick" from acquisitions basket template
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16262] Remove the use of "onclick" from acquisitions basket template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16262

Owen Leonard  changed:

   What|Removed |Added

 Depends on||16206


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206
[Bug 16206] Corrections to templates related new EDI feature
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16262] New: Remove the use of "onclick" from acquisitions basket template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16262

Bug ID: 16262
   Summary: Remove the use of "onclick" from acquisitions basket
template
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/acqui/basket.pl
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

There are many place where an "onclick" attribute is used in acqui/basket.tt.
These should be rewritten so that JS functionality can be separate from the
markup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14917] RDA: 700/710/711 fix path for icon in XSLT

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14917

Danielle Elder  changed:

   What|Removed |Added

 CC||danielle@bywatersolutions.c
   ||om

--- Comment #9 from Danielle Elder  ---
Hi, Winona, 

Yes, the marc I copied in my original comment was straight from the record. I
copy/pasted.

Dani

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

--- Comment #60 from Winona Salesky  ---
Ahh, I see. Well, this could be handled more easily by using apply-templates
rather then call-template. That would retain subfield order and allow different
treatment where needed for subfields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

--- Comment #59 from Katrin Fischer  ---
Hi Winona - take a look at the changes from bug 15100.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

--- Comment #58 from Winona Salesky  ---
I don't see dates being treated any differently, no spans or classes? (In the
master branch).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

--- Comment #57 from Katrin Fischer  ---
I think the problem is when we need additional formatting (wrap subfields in
links, spans etc) and that makes it harder to keep the catalogued sequenence
for output. - I am not sure how to solve that. My guess is that the $d is stuck
at the end currently because I wrapped it into span for being able to hide the
dates in the OPAC. *hidesherself*

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

--- Comment #56 from Winona Salesky  ---
Output of subfields should follow the order they appear in the MARC record. If
you are finding this is not the case perhaps you can share your record? (In
MARCXML)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

Alex Sassmannshausen  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

Alex Sassmannshausen  changed:

   What|Removed |Added

  Attachment #50128|0   |1
is obsolete||

--- Comment #24 from Alex Sassmannshausen 
 ---
Created attachment 50243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50243=edit
Post-QA revised patch

This revised patch includes all feedback from QA, plus a consistent renaming of
the feature away from checkprevissue to checkprevcheckout.

- The functionality is now exposed as methods to Patron.
- The unit tests test CanBookBeIssued.
- I have renamed references to loans/loan and issues.
- I have added `after`clauses to the atomicupdate.

Let me know if there are any outstanding issues.

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

--- Comment #55 from Danielle Elder  ---
Katrin, 

Do you mean the order of data input or the order of the tags in the editor? 

I tried data input order, and that didn't change anything.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

--- Comment #54 from Katrin Fischer  ---
Just saying... it's a lot trickier.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

--- Comment #53 from Katrin Fischer  ---
Hi Danielle, alphabetic order is not always correct with MARC21 - it should
depend on the order you catalog them in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16261] New: System preference noissuecharge should take account of the amount "greater than or equal to"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16261

Bug ID: 16261
   Summary: System preference noissuecharge should take account of
the amount "greater than or equal to"
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: marjorie.barry-v...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Hi,

Noissuecharge takes into account the amounts of fines "greater than" to what is
written in the preference system.

Example:

noissuecharge filled with 5

Patron has $ 5 in fines, it will not be blocked to check-out.

We have to write 4.99 to block patron with 5 $ in fines.


Noissuecharge should take account of the amount "greater than or equal to"

Regards,

Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

--- Comment #52 from Danielle Elder  ---
Hello, the subfields are out of order.

Marc is: 

  700 1# - ADDED ENTRY--PERSONAL NAME

  a Personal name Caspary, Vera,

  d Dates associated with a name 1899-1987.

  t Title of a work Laura.

Displays as such:

   700, a,t,d

from catalog Normal View:

   Caspary, Vera, Laura 1899-1987. 

Can the subfields be ordered alphabetically?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

Danielle Elder  changed:

   What|Removed |Added

 CC||danielle@bywatersolutions.c
   ||om

--- Comment #51 from Danielle Elder  ---
Hello, the subfields are out of order.

Marc is: 

  700 1# - ADDED ENTRY--PERSONAL NAME

  a Personal name Caspary, Vera,

  d Dates associated with a name 1899-1987.

  t Title of a work Laura.

Displays as such:

   700, a,t,d

from catalog Normal View:

   Caspary, Vera, Laura 1899-1987. 

Can the subfields be ordered alphabetically?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16260] New: Moderate the impact of AllowHoldsOnPatronsPossessions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16260

Bug ID: 16260
   Summary: Moderate the impact of AllowHoldsOnPatronsPossessions
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: marjorie.barry-v...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Hi,

System preference AllowHoldsOnPatronsPossessions is too restrictive.

Test plan:
-AllowHoldsOnPatronsPossessions : Don't allow


-notice with 2 items (X and Y)

-one of items is check-out by borrower A (item X)

-other items is check-out by borrower B (item Y)

If Borrower A wants to hold item Y, he can not because of the system
preference.

If system preference is Allow, Borrower A can hold item Y but he can hold item
X too, and we don't want that he can.


Is there something I do not understand in the configuration ?

Regards,
Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (testable without SIP server)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #48666|0   |1
is obsolete||

--- Comment #14 from Bernardo Gonzalez Kriegel  ---
Created attachment 50242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50242=edit
[SIGNED-OFF] Bug 15956: New unit test SIP/Message.t

This patch adds a unit test for the handlers of Patron Status
and Patron Info requests. It can be extended with test for the
other handlers later (hopefully).

Note: The tests have been written for SIP protocol version 2.

Test plan:
Run t/db_dependent/SIP/Message.t.

Note: If bug 13871 has not yet been pushed, test 12 (subtest 1) should fail
with something like 'Code AF not found'. Same for test 15 of subtest 2.
That is no problem; after that push, all tests should pass.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Bernardo Gonzalez Kriegel 

All tests pass
t/db_dependent/SIP/ILS.t .. ok
t/db_dependent/SIP/Message.t .. ok
t/db_dependent/SIP/Patron.t ... ok
t/db_dependent/SIP/Transaction.t .. ok
All tests successful.

No errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (testable without SIP server)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (testable without SIP server)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #48664|0   |1
is obsolete||

--- Comment #12 from Bernardo Gonzalez Kriegel  ---
Created attachment 50240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50240=edit
[SIGNED-OFF] Bug 15956: Remove warn from handle_patron_status

Removes a warn and some commented warns.

Test plan:
Nothing to do here. Will be covered later by additional unit test.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (testable without SIP server)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #48665|0   |1
is obsolete||

--- Comment #13 from Bernardo Gonzalez Kriegel  ---
Created attachment 50241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50241=edit
[SIGNED-OFF] Bug 15956: Move SIPILS.t to SIP/ILS.t

Move the file. Some trivial (cosmetic) edits: whitespace, comments.

Test plan:
Run SIP/ILS.t

Signed-off-by: Marcel de Rooy 
Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (testable without SIP server)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #48663|0   |1
is obsolete||

--- Comment #11 from Bernardo Gonzalez Kriegel  ---
Created attachment 50239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50239=edit
[SIGNED-OFF] Bug 15956: Rearranging some SIP unit tests

The original SIP_ILS.t is split up into SIP/Patron.t and
SIP/Transaction.t.
The assumption on a hardcoded existing and non-existing card number is
replaced by adding and deleting a card number (:patron) with TestBuilder.

Test plan:
Run SIP/Patron.t
Run SIP/Transaction.t

Signed-off-by: Marcel de Rooy 
Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16229] Koha::Cache should be on the safe side

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16229

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 50238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50238=edit
Bug 16229: (QA) POD fixes

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16229] Koha::Cache should be on the safe side

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16229

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16229] Koha::Cache should be on the safe side

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16229

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #50199|0   |1
is obsolete||

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 50235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50235=edit
Bug 16229: Deep copy on first L2 fetch

When a value exists in L2 cache but not in L1 cache, it should be deep
copied if needed (i.e. not a scalar). Otherwise the calling code is able
to modify the value in cache.
Note that is theoretical, it's possible that no code does that.

Signed-off-by: Jacek Ablewicz 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16229] Koha::Cache should be on the safe side

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16229

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #50201|0   |1
is obsolete||

--- Comment #10 from Tomás Cohen Arazi  ---
Created attachment 50237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50237=edit
Bug 16229: Add the unsafe flag to set_in_cache

Could be useful later.

Signed-off-by: Jacek Ablewicz 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16229] Koha::Cache should be on the safe side

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16229

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #50200|0   |1
is obsolete||

--- Comment #9 from Tomás Cohen Arazi  ---
Created attachment 50236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50236=edit
Bug 16229: Deep copy on setting in cache

Koha::Cache->set_in_cache should deep copy (if needed) to avoid the
value which has been set in cache to be unintentionally modified later.

Signed-off-by: Jacek Ablewicz 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15928] Show unlinked guarantor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15928

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #11 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15928] Show unlinked guarantor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15928

--- Comment #10 from Julian Maurice  ---
Created attachment 50234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50234=edit
[3.22.x] Bug 15928 - Show unlinked guarantor

Patch for 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11371] Add a new report : Orders by budget

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

--- Comment #43 from Bouzid  ---
Created attachment 50233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50233=edit
Bug 11371 - Add option show or no inactive budget and more options

Use subroutine GetBudgetHierarchy fir return all budgets
 Delete subroutine GetBudgetPeriodDescription and theire tests
 Use Price TT plugin
 Correct name of column and capitalization the first letter
 Add  checkbox for show inactive budgets, default the drop down list containt a
active budget
 Not use [i] for inactive budgets, i add (inactive) at the end of inactive
budget
 Add vendor note in the list of show attribute

 Test case:
Go to Home > Reports > Orders by budget
Select one or all budgets
You can show the inactive budget, default the drop down list containt a
active budget
Choose output to screen ou csv file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

Jonathan Druart  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c
   |y.org   |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15962] Currency deletion doesn't correctly identify currencies in use

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15962

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||julian.maur...@biblibre.com

--- Comment #15 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11371] Add a new report : Orders by budget

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

Bouzid  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15962] Currency deletion doesn't correctly identify currencies in use

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15962

--- Comment #14 from Julian Maurice  ---
Created attachment 50232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50232=edit
[3.22.x] Bug 15962: Block the currency deletion if used

Patch for 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11371] Add a new report : Orders by budget

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

Bouzid  changed:

   What|Removed |Added

  Attachment #50230|0   |1
is obsolete||

--- Comment #42 from Bouzid  ---
Created attachment 50231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50231=edit
Bug 11371 - Add a new report : Orders by budget

Use subroutine GetBudgetHierarchy fir return all budgets
 Delete subroutine GetBudgetPeriodDescription and theire tests
 Use Price TT plugin
 Correct name of column and capitalization the first letter
 Add  checkbox for show inactive budgets, default the drop down list containt a
active budget
 Not use [i] for inactive budgets, i add (inactive) at the end of inactive
budget
 Add vendor note in the list of show attribute

 Test case:
Go to Home > Reports > Orders by budget
Select one or all budgets
You can show the inactive budget, default the drop down list containt a
active budget
Choose output to screen ou csv file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11371] Add a new report : Orders by budget

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

Bouzid  changed:

   What|Removed |Added

  Attachment #45982|0   |1
is obsolete||

--- Comment #41 from Bouzid  ---
Created attachment 50230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50230=edit
Bug 11371 - Add a new report : Orders by budget

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #94 from Owen Leonard  ---
(In reply to Srdjan Jankovic from comment #93)

> On kc/master I get the list, with all entries "No title ". 

I don't have the problem of entries appearing with "No title" in master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16154] Replace CGI->param with CGI->multi_param in list context

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154

Owen Leonard  changed:

   What|Removed |Added

 Blocks||16259


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16259
[Bug 16259] More: Replace CGI->param with CGI->multi_param in list context
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809

Owen Leonard  changed:

   What|Removed |Added

 Blocks||16259


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16259
[Bug 16259] More: Replace CGI->param with CGI->multi_param in list context
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16259] New: More: Replace CGI->param with CGI->multi_param in list context

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16259

Bug ID: 16259
   Summary: More: Replace CGI->param with CGI->multi_param in list
context
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: hblanc...@gmail.com,
jonathan.dru...@bugs.koha-community.org,
testo...@bugs.koha-community.org
Depends on: 15809, 16154

In my testing of Bug 16154 I found some scripts which are still leaving errors
in the log:

admin/branches.pl
admin/categories.pl
admin/patron-attr-types.pl
admin/preferences.pl
catalogue/itemsearch.pl
catalogue/image.pl
circ/circulation.pl
patroncards/add_user_search.pl
serials/add_user_search.pl
virtualshelves/shelves.pl


Copied from Bug 16154:

  my @foo = $cgi->param('foo');

must be replaced with

  my @foo = $cgi->multi_param('foo');

and

  $template->param( foo => $cgi->param('foo') );

must be replaced with

  $template->param( foo => scalar $cgi->param('foo') );


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809
[Bug 15809] versions of CGI < 4.08 do not have multi_param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154
[Bug 16154] Replace CGI->param with CGI->multi_param in list context
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16154] Replace CGI->param with CGI->multi_param in list context

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154

Owen Leonard  changed:

   What|Removed |Added

  Attachment #50207|0   |1
is obsolete||

--- Comment #17 from Owen Leonard  ---
Created attachment 50229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50229=edit
[SIGNED-OFF] Bug 16154: Fix some other occurrences

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

--- Comment #67 from Julian Maurice  ---
Created attachment 50227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50227=edit
Bug 7957: Add unit tests for new subroutines

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

--- Comment #68 from Julian Maurice  ---
Created attachment 50228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50228=edit
Bug 7957: Redirect after creating a new routing list

This avoids creating the same list multiple times when reloading the
page

Signed-off-by: Aleisha 

Have made a couple of small changes to your patch.
1) "There is no routing lists for this subscription" -> changed to "There are
no"
2) When I click Preview and choose a serial (up to Step 9 in test plan), there
is a link to another system preference which I assume$

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

--- Comment #66 from Julian Maurice  ---
Created attachment 50226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50226=edit
Bug 7957: Routing lists enhancements

- Manage several routing list per subscription
- Export a routing list as CSV

Test plan:

Run the updatedatabase.pl script
Existing routing lists should have been imported in a routing list named
'import'

>From the serials-home.pl page:
  1 Make a search, in the results list you have a column 'Actions' that
should contain a "New/Edit routing list" link" (if not, consider
setting RoutingSerials syspref). If the subscription doesn't have a
routing list, you should have a 'New routing list' link. Otherwise
you have an 'Edit routing lists (X)' link, where X is the number of
routing lists.
  2 Choose a subscription which have no routing lists and click on 'New
routing list'
  3 You are on the routing list creation page. Enter a title for the
routing list and click on 'Save'.
  4 The routing list has been created and now you are on the routing
list modification page. The behaviour of this page is quite the same
as before. A sensible change is that reordering borrowers doesn't
reload the page each time you make a change.
  5 Click on 'Save' to finish routing list modifications.
  6 Now you are on the routing lists management page. You can edit a
routing list by clicking on its title, preview it, export it, and
delete it by clicking on the corresponding link.
  7 Click on 'Preview'.
  8 You will be asked to choose a serial. Pick the one you want to print
the routing list for and click on 'Continue'.
  9 If RoutingListAddReserves is OFF, the routing list is displayed and
you just have to click on 'Print'. If the syspref is ON, you will
have to click on 'Confirm and print', an alert will show telling you
that holds will be placed on the serial you chose. Click 'OK' and
you will be able to print the slip. Now check if the holds have been
placed. (It works only if an item is attached to this serial).
 10 Go back to the routing lists management page (routinglists.pl) and
click on 'Export'. Download the CSV and check that it contains
correct data.

>From serials-collection.pl page:
 11 In the serials list, click on 'Print list'.
 12 You will be asked to choose a routing list. Pick one and click on
'Continue'.
 13 ... (same behaviour as above)

Try to add and delete routing lists to show if links are correctly
updated in serials-home.pl, serials-collection.pl and
subscription-detail.pl

Signed-off-by: Paola Rossi 
Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705

--- Comment #17 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #14)
> I would be great to see some tests to cover this new module (even if it's
> not new code).
How can we test code that should modify the Zebra index, without really
modifying it ? Should we create another Zebra instance for tests purpose ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705

--- Comment #16 from Julian Maurice  ---
(In reply to Katrin Fischer from comment #15)
> Just a general question: why C4 and not Koha?
The first version of this patch was written in 2012 (for bug 7419), that's why
:)
Should we move the code to Koha::ZebraIndex ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705

--- Comment #15 from Katrin Fischer  ---
Just a general question: why C4 and not Koha?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483

--- Comment #49 from Katrin Fischer  ---
Should we move this out of the list for now? "In Discussion" or "Failed QA"?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Julian Maurice  changed:

   What|Removed |Added

  Attachment #46263|0   |1
is obsolete||

--- Comment #41 from Julian Maurice  ---
Created attachment 50225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50225=edit
Bug 11999: Check for age restriction in CanBookBeReserved

+ improve t/db_dependent/Reserves.t to make tests pass on UNIMARC
installation

Maxreserves and alreadyreserved works on ILSDI
Maxreserves works also on staff and opac
Already reserves works also on staff and opac
tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using
koha_ut db)

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Julian Maurice  changed:

   What|Removed |Added

  Attachment #46262|0   |1
is obsolete||

--- Comment #40 from Julian Maurice  ---
Created attachment 50224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50224=edit
Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved

- Check if borrower already has reserved the same biblio (or item).
- Check if borrower has reached the maximum number of holds allowed
  (syspref maxreserves)

The goal of this patch is to do these checks also when using ILS-DI
services HoldTitle and HoldItem

Test plan:
--
Before patch:
1/ Set syspref maxreserves to 1
2/ Place some holds through ILS-DI and note that you can place more than
   1 hold for a borrower
3/ Try to hold the same biblio/item with the same borrower through
   ILS-DI and note that you can

Apply the patch
4/ Place some holds through ILS-DI, you shouldn't be able to place more
   than 1 hold for a borrower
5/ Try to hold the same biblio/item with the same borrower through
   ILS-DI. You shouldn't be able to do that.
6/ Try to place holds on staff interface and OPAC. The behaviour must be
   identical than before the patch.

Maxreserves and alreadyreserved works on ILSDI
Maxreserves works also on staff and opac
Already reserves works also on staff and opac
tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using
koha_ut db)

Signed-off-by: Alex Sassmannshausen 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15564] Display "print slip" option when returning an item which is in a rotating collection

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #11 from Jonathan Druart  
---
(In reply to Benjamin Rokseth from comment #10)
> Why patch doesn't apply? Applies cleanly for me on master ref
> 2a8c68936dd7fd5c82af339db968eb67cb93a082

Yes, sorry about that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15564] Display "print slip" option when returning an item which is in a rotating collection

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564

--- Comment #10 from Benjamin Rokseth  ---
Why patch doesn't apply? Applies cleanly for me on master ref
2a8c68936dd7fd5c82af339db968eb67cb93a082

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/