date:20160504

[Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258

Colin Campbell  changed:

   What|Removed |Added

  Attachment #51185|0   |1
is obsolete||

--- Comment #8 from Colin Campbell  ---
Created attachment 51228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51228=edit
Proposed patch

make an import explicit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone"

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669

--- Comment #35 from David Cook  ---
(In reply to Colin Campbell from comment #33)
> I wonder if we could use utc internally and just use the local timezone to
> convert user input and to present the date externally. We'd need to be
> fairly vigorous in cleaning up the various vaguely different ways we
> currently treat dates, cetainly when we're doing calculations we probably
> want to do them in a common base as otherwise there's too many opportunities
> to fall into a given timezone's black hole

Agreed. I think we could use UTC internally and just use the local timezone to
convert user input and convert output for users.

We would need to be vigorous in cleaning up how we've currently treating dates
though, yeah :/. Generally speaking, we're not recording super precise datetime
data, so I don't see why we couldn't use floating timezones for calculations. I
suppose it depends on the calculations being done, but that's really the only
way of doing it with our current holiday checking code without causing invalid
local times. 

We might be able to use UTC for some calculations, but... I don't think so  in
the holiday case because we'd be interested in local days and obviously UTC
doesn't always correspond with the same day. You might have 2 UTC timestamps
for the same day in UTC, but they'd actually correspond to different days in
local time. If you truncated that for the sake of date checking, you'd be
skipping one of the local days, which would be really bad.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone"

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669

--- Comment #34 from David Cook  ---
(In reply to Marcel de Rooy from comment #32)
> David: I recall falling back to floating timezone for making calculations
> with far future dates like an expiry in  or so.
> If you would use a normal timezone, you will have major performance issues.

Yeah, that's an unrelated issue I believe.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #35 from David Cook  ---
(In reply to Srdjan Jankovic from comment #34)
> I could have done it both ways, but these days I prefer client side.
> * As a sever side dude, I prefer that clients use their cycles

I think client capabilities really range a lot, so as a server side dude I'd
rather present as consistent a baseline as possible. 

> * Tomorrow we decide to make search an api call, this still works
> 

Your API call would still need to return the text for you to replace, so that
doesn't really make sense. The API call could return translated text. You'd
just need a locale parameter. 

> And a personal, not a valid reason: I find that translations are easier
> (cleaner) in js

I haven't done much with translations, but I believe you with that one. That
said, if we used resource files for certain strings as I've suggested
elsewhere, translations would be simple. In a persistent environment, you only
load the file once, so there's not much overhead. 

But that's just my 2 cents. I'm not offering up any alternative patches, so I'm
mostly just curious about the rationale. Thanks for taking the time to respond
:).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #34 from Srdjan Jankovic  ---

> We build the breadcrumbs... so why are we doing this client-side? Why aren't
> we doing this server-side?

I could have done it both ways, but these days I prefer client side.
* As a sever side dude, I prefer that clients use their cycles
* Tomorrow we decide to make search an api call, this still works

And a personal, not a valid reason: I find that translations are easier
(cleaner) in js

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16446] New: Allow librarians to add borrowers to lists by borrowernumber or cardnumber

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16446

Bug ID: 16446
   Summary: Allow librarians to add borrowers to lists by
borrowernumber or cardnumber
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Lists
  Assignee: gmcha...@gmail.com
  Reporter: l...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

It would be nice to be able to add borrowers to lists based on a supplied list
of cardnumbers or borrowernumbers (that they could get from a report, for
example).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #245 from Srdjan Jankovic  ---
Also, with my version of elastic, I had to do following changes:

diff --git a/Koha/ElasticSearch.pm b/Koha/ElasticSearch.pm
index d56c344..22bc064 100644
--- a/Koha/ElasticSearch.pm
+++ b/Koha/ElasticSearch.pm
@@ -171,11 +171,6 @@ sub get_elasticsearch_mappings {
 include_in_all => JSON::false,
 type   => "string",
 },
-'_all.phrase' => {
-search_analyzer => "analyser_phrase",
-index_analyzer  => "analyser_phrase",
-type=> "string",
-},
 }
 }
 };
@@ -195,15 +190,12 @@ sub get_elasticsearch_mappings {
   ? 'boolean'
   : 'string';
 $mappings->{data}{properties}{$name} = {
-search_analyzer => "analyser_standard",
-index_analyzer  => "analyser_standard",
+analyzer  => "analyser_standard",
 type=> $es_type,
 fields  => {
 phrase => {
-search_analyzer => "analyser_phrase",
-index_analyzer  => "analyser_phrase",
+analyzer  => "analyser_phrase",
 type=> "string",
-copy_to => "_all.phrase",
 },
 raw => {
 "type" => "string",
@@ -222,22 +214,19 @@ sub get_elasticsearch_mappings {
 if ($suggestible) {
 $mappings->{data}{properties}{ $name . '__suggestion' } = {
 type => 'completion',
-index_analyzer => 'simple',
-search_analyzer => 'simple',
+analyzer => 'simple',
 };
 }
 # Sort may be true, false, or undef. Here we care if it's
 # anything other than undef.
 if (defined $sort) {
 $mappings->{data}{properties}{ $name . '__sort' } = {
-search_analyzer => "analyser_phrase",
-index_analyzer  => "analyser_phrase",
+analyzer  => "analyser_phrase",
 type=> "string",
 include_in_all  => JSON::false,
 fields  => {
 phrase => {
-search_analyzer => "analyser_phrase",
-index_analyzer  => "analyser_phrase",
+analyzer  => "analyser_phrase",
 type=> "string",
 },
 },
diff --git a/installer/data/mysql/updatedatabase.pl
b/installer/data/mysql/updatedatabase.pl
index 9e6d390..e092704 100755
--- a/installer/data/mysql/updatedatabase.pl
+++ b/installer/data/mysql/updatedatabase.pl
@@ -12332,13 +12332,13 @@ my $indexes = LoadFile( $mappings_yaml );

 while ( my ( $index_name, $fields ) = each %$indexes ) {
 while ( my ( $field_name, $data ) = each %$fields ) {
-my $field_type = $data->{type};
+my $field_type = $data->{type} || 'string';
 my $field_label = $data->{label};
 my $mappings = $data->{mappings};
 my $search_field = Koha::SearchFields->find_or_create({ name =>
$field_name, label => $field_label, type => $field_type }, { key => 'name' });
 for my $mapping ( @$mappings ) {
 my $marc_field = Koha::SearchMarcMaps->find_or_create({
index_name => $index_name, marc_type => $mapping->{marc_type}, marc_field =>
$mapping->{marc_field} });
-$search_field->add_to_search_marc_maps($marc_field, { facet =>
$mapping->{facet}, suggestible => $mapping->{suggestible}, sort =>
$mapping->{sort} } );
+$search_field->add_to_search_marc_maps($marc_field, { facet =>
$mapping->{facet} || 0, suggestible => $mapping->{suggestible} || 0, sort =>
$mapping->{sort} || undef } );
 }
 }
 }

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16445] Bug 12478 has added an unnecessary line to Koha/Database.pm

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16445

Chris Cormack  changed:

   What|Removed |Added

  Attachment #51224|0   |1
is obsolete||

--- Comment #2 from Chris Cormack  ---
Created attachment 51227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51227=edit
Bug 16445: Revert changes made by bug 12478 to Koha/Database.pm

These changes were a mistake, let's revert them.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16445] Bug 12478 has added an unnecessary line to Koha/Database.pm

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16445

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

--- Comment #15 from Danielle Elder  ---
I tested the css classes and ordering in Intranet and OPAC. Looked great. I
signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

Danielle Elder  changed:

   What|Removed |Added

  Attachment #51225|0   |1
is obsolete||

--- Comment #14 from Danielle Elder  ---
Created attachment 51226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51226=edit
Bug 16343: 7XX XSLT subfields displaying out of order

This patch respect previous css classes
.authordates and .relatorcode but also include .titleportion

.authordates {display: none;}
.titleportion {display: none;}
.relatorcode {display: none;}

To test:
- Stage the two record attached with titles:
  - Surface & coatings technology.
  - Women crime writers.
- Reindex zebra (necessary to Opac and Itranet results)
- Leave empty the OPACUserCSS and IntranetUserCSS sysprefs
- Go to the new records in OPAC and Intranet detail page
- See the wrong display of dates
- Apply patch and refresh the page
- Test in OPACUserCSS and IntranetUserCSS the css stated before
- Play deleting or adding the classes
- Test with multiple records with 700 (with and without dates, etc;
  710 and 711)

NOTE: dates in 710 and 711 can be hidden with .titleportion class;
dates in this kind of heading go with another data for example:
Catholic Church. Plenary Council of Baltimore (2nd : 1866)
Patch rebased some typos fixed in comments

Signed-off-by: Dani Elder 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

Danielle Elder  changed:

   What|Removed |Added

  Attachment #51190|0   |1
is obsolete||

--- Comment #13 from Danielle Elder  ---
Created attachment 51225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51225=edit
Bug 16343: 7XX XSLT subfields displaying out of order

This patch respect previous css classes
.authordates and .relatorcode but also include .titleportion

.authordates {display: none;}
.titleportion {display: none;}
.relatorcode {display: none;}

To test:
- Stage the two record attached with titles:
  - Surface & coatings technology.
  - Women crime writers.
- Reindex zebra (necessary to Opac and Itranet results)
- Leave empty the OPACUserCSS and IntranetUserCSS sysprefs
- Go to the new records in OPAC and Intranet detail page
- See the wrong display of dates
- Apply patch and refresh the page
- Test in OPACUserCSS and IntranetUserCSS the css stated before
- Play deleting or adding the classes
- Test with multiple records with 700 (with and without dates, etc;
  710 and 711)

NOTE: dates in 710 and 711 can be hidden with .titleportion class;
dates in this kind of heading go with another data for example:
Catholic Church. Plenary Council of Baltimore (2nd : 1866)
Patch rebased some typos fixed in comments

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976

Bouzid  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||bouzid.ferg...@inlibro.com
 Resolution|FIXED   |---

--- Comment #14 from Bouzid  ---
Hi all,
The borrow permission is removed, but it existing in this files: 

opac/opac-idref.pl:40:flagsrequired   => { borrow => 1 },
opac/opac-news-rss.pl:37:flagsrequired   => { borrow => 1 },
opac/opac-restrictedpage.pl:43:flagsrequired   => { borrow => 1 },
opac/svc/login:46  checkauth( $query, 1,  { borrow => 1 }, 'opac',
$decoded_json->{'email'} );

I think, it's a bug.

Bouzid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16445] Bug 12478 has added an unnecessary line to Koha/Database.pm

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16445

--- Comment #1 from Jonathan Druart  
---
Created attachment 51224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51224=edit
Bug 16445: Revert changes made by bug 12478 to Koha/Database.pm

These changes were a mistake, let's revert them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16445] Bug 12478 has added an unnecessary line to Koha/Database.pm

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16445

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16445] New: Bug 12478 has added an unnecessary line to Koha/Database.pm

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16445

Bug ID: 16445
   Summary: Bug 12478 has added an unnecessary line to
Koha/Database.pm
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 12478

>From commit 95dabf4bfd15f6aed149c17546c00083063a01c1
  Bug 12478 - add some base objects that the ES code will depend on

+our $schema; # the schema is a singleton

This is not needed


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478
[Bug 12478] Elasticsearch support for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16445


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16445
[Bug 16445] Bug 12478 has added an unnecessary line to Koha/Database.pm
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15333] Use Koha::Cache for caching all holidays

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||7172
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
Note that we won't add any performance gain with this patch (on the contrary),
but at least we will get rid of possible weird behaviors.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172
[Bug 7172] Omnibus for Plack variable scoping problems
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||15333


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333
[Bug 15333] Use Koha::Cache for caching all holidays
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15333] Use Koha::Cache for caching all holidays

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333

--- Comment #3 from Jonathan Druart  
---
Created attachment 51223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51223=edit
Bug 15333: Use Koha::Cache to cache exception_holidays instead of a package
variable

On the same way as bug 14522, we should use Koha::Cache to cache
exception_holidays.
It's not safe to use a package variable if running under Plack.

There is not test plan, just make sure the changes make sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15333] Use Koha::Cache for caching all holidays

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16393] mysql error 1171 in Web installer Step 3

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16393

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
Can you continue the web installer after this warning?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #9 from Jonathan Druart  
---
(In reply to Mason James from comment #8)
> Update: A new bug has been created, that contains a patch for this problem...
> 
>   http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

So can we close this one?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16444] C4::Tags is not plack safe

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16444] C4::Tags is not plack safe

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444

--- Comment #1 from Jonathan Druart  
---
Created attachment 51222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51222=edit
Bug 16444: Make C4::Tags plack safe

C4::Tags use a package variable to cache the pref
TagsExternalDictionary, it's not needed and not safe.

There is not test plan, just make sure the changes are consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16444


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444
[Bug 16444] C4::Tags is not plack safe
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16444] New: C4::Tags is not plack safe

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444

Bug ID: 16444
   Summary: C4::Tags is not plack safe
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 7172

C4::Tags use a package variable to cache the pref TagsExternalDictionary, it's
not needed and not safe.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172
[Bug 7172] Omnibus for Plack variable scoping problems
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16442] C4::Ris is not plack safe

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #51219|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  
---
Created attachment 51221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51221=edit
Bug 16442: Make C4::Ris plack safe

C4::Ris incorrectly uses 4 package variables:
- $utf: not used, can be removed
- $intype: set to marcflavour once, but later it assumes that it is
  usmarc if not defined
- $marcprint: always 0, so set it to 0
- $protoyear: only used in 1 subroutine, let's define it at this
  level

Test plan:
Just make sure the RIS export works as before this patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16443] C4::Members::Statistics is not plack safe

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16443

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16443] C4::Members::Statistics is not plack safe

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16443

--- Comment #1 from Jonathan Druart  
---
Created attachment 51220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51220=edit
Bug 16443: Make C4::Members::Statistics plack safe

If the prefs is updated, the fields won't be.
To make sure we already fetch updated values, we should remove the
package variable and define it in the subroutine.

There is not test plan, just make sure the changes are consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||16443


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16443
[Bug 16443] C4::Members::Statistics is not plack safe
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16443] New: C4::Members::Statistics is not plack safe

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16443

Bug ID: 16443
   Summary: C4::Members::Statistics is not plack safe
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: major
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Blocks: 7172

If the prefs is updated, the fields won't be.
To make sure we already fetch updated values, we should remove the package
variable and define it in the subroutine.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172
[Bug 7172] Omnibus for Plack variable scoping problems
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16442] C4::Ris is not plack safe

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442

--- Comment #1 from Jonathan Druart  
---
Created attachment 51219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51219=edit
Bug 16442: C4::Ris is not plack safe

C4::Ris incorrectly uses 4 package variables:
- $utf: not used, can be removed
- $intype: set to marcflavour once, but later it assumes that it is
  usmarc if not defined
- $marcprint: always 0, so set it to 0
- $protoyear: only used in 1 subroutine, let's define it at this
  level

Test plan:
Just make sure the RIS export works as before this patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15816] Timeout login redirects to home page

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15816

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16442] C4::Ris is not plack safe

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16393] mysql error 1171 in Web installer Step 3

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16393

g.me...@esgbonn.de changed:

   What|Removed |Added

   Severity|normal  |major
   Priority|P3  |P2

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||16442


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442
[Bug 16442] C4::Ris is not plack safe
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16442] New: C4::Ris is not plack safe

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442

Bug ID: 16442
   Summary: C4::Ris is not plack safe
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Blocks: 7172

C4::Ris incorrectly uses 4 package variables:
- $utf: not used, can be removed
- $intype: set to marcflavour once, but later it assumes that it is usmarc if
not defined
our $marcprint: always 0, so set it to 0
our $protoyear: only used in 1 subroutine, let's define it at this level


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172
[Bug 7172] Omnibus for Plack variable scoping problems
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074

--- Comment #4 from Bernardo Gonzalez Kriegel  ---
(In reply to Bernardo Gonzalez Kriegel from comment #3)
> Hi,
> found a fail in t/db_dependent/Items.t, subtest 4 of test 10

What I found is that I need more sleep, forget dependency again. Sorry

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16441] C4::Letters::getletter is not plack safe

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441

--- Comment #1 from Jonathan Druart  
---
Created attachment 51218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51218=edit
Bug 16441: Do not use a package variable to cache C4::Letters::getletter

C4::Letters::getletter use a package variable (%letter) to cache letter
returned by the subroutine.
I have not found any direct issues caused by that but it is safer to
remove it.
It won't be a big deal to hit the DBMS to get a valid letter when
needed.

No test plan here, just confirm that the changes make sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16441] C4::Letters::getletter is not plack safe

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #3 from Bernardo Gonzalez Kriegel  ---
Hi,
found a fail in t/db_dependent/Items.t, subtest 4 of test 10

not ok 4 - items.barcode is not mapped anymore, so the DB column has not
been updated

#   Failed test 'items.barcode is not mapped anymore, so the DB column has
not been updated'
#   at t/db_dependent/Items.t line 661.
#  got: undef
# expected: 'a barcode'
# Looks like you failed 1 test of 4.
not ok 10 - C4::Items::_build_default_values_for_mod_marc

Something in my data?
Does not fail in master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16441] New: C4::Letters::getletter is not plack safe

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441

Bug ID: 16441
   Summary: C4::Letters::getletter is not plack safe
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 9452
Blocks: 7172

C4::Letters::getletter use a package variable (%letter) to cache letter
returned by the subroutine.
I have not found any direct issues caused by that but it is safer to remove it.
It won't be a big deal to hit the DBMS to get a valid letter when needed.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172
[Bug 7172] Omnibus for Plack variable scoping problems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452
[Bug 9452] C4::Letters does not function under Plack
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||16441


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441
[Bug 16441] C4::Letters::getletter is not plack safe
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9452] C4::Letters does not function under Plack

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16441


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441
[Bug 16441] C4::Letters::getletter is not plack safe
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16440] New: Update report parameters

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16440

Bug ID: 16440
   Summary: Update report parameters
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: gmcha...@gmail.com
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

Created attachment 51217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51217=edit
Placement of report parameters on report results.

Let's say you have a report that asks you for parameters.  You run the report,
get the results, and then you want to run the report again with different
parameters.  Or maybe you made a mistake and need to change it.  Yes, you could
back up and change things and run it again.  But what if the parameters were
showing over on the left of the report under the "Useful resources" section? 
You could see what you set, and change whatever you needed and then click
update.  Perhaps the row setting and update button could also be on the left of
the report.

Just a thought.  I was able to change a parameter up in the URL, and hit
update, and it worked.  It was nice because I set the report to show more than
20 records, and I didn't have to repeat that step after updating.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16439] Allow styling to button for upload local cover images (Font Awesome Icons)

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Depends on||16438


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438
[Bug 16438] Use Font Awesome icons in batch templates
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Blocks||16439


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439
[Bug 16439] Allow styling to button for upload local cover images (Font Awesome
Icons)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16439] Allow styling to button for upload local cover images (Font Awesome Icons)

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439

--- Comment #1 from Héctor Eduardo Castro Avalos  ---
Created attachment 51216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51216=edit
Bug 16439: Allow styling to button for upload local cover images (Font Awesome
Icons)

Improve button for upload local cover image with Font Awesome Icon

To test:
-Set syspref LocalCoverImages and OPACLocalCoverImages to Allow
-A new tab 'Images' appear in bib record detail on Intranet.
-Notice about the button upload.
-Apply the patch and reload the page.
-The button is changed for class=btn btn-mini like the button "edit"
 used in items in the tab Holdings
-Also added the Font Awesome icon upload "fa fa-upload" class.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16439] Allow styling to button for upload local cover images (Font Awesome Icons)

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16439] New: Allow styling to button for upload local cover images (Font Awesome Icons)

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439

Bug ID: 16439
   Summary: Allow styling to button for upload local cover images
(Font Awesome Icons)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: hector.hecax...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Improve button for upload local cover image with Font Awesome Icon

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #51171|0   |1
is obsolete||
  Attachment #51213|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  
---
Created attachment 51214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51214=edit
Bug 16438: Use Font Awesome icons in batch templates

Add Font Awesome icons in tables in authorities and bib records
in batch item/record deletion, modification templates

To test:
1- Go to Tools > Batch item/record deletion/modification
2- Try to delete/modify itmes/bib and authorities records
3- Look all tables presented and notice about the new icons in Select all
   Clear all, etc.
4- Apply patch and repeat step 1 to 3

Signed-off-by: Bernardo Gonzalez Kriegel 
Work, nice view.
No Errors

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

--- Comment #14 from Jonathan Druart  
---
Created attachment 51215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51215=edit
Bug 16438: (followup) remove item where no single icon exist for options

Remove the double icon in options where double icons don't work well

To test: follow the previous commit

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again.

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Owen Leonard  changed:

   What|Removed |Added

  Attachment #51212|0   |1
is obsolete||

--- Comment #12 from Owen Leonard  ---
Created attachment 51213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51213=edit
[SIGNED-OFF] Bug 16438: (followup) remove item where no single icon exist for
options

Remove the double icon in options where double icons don't work well

To test: follow the previous commit

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

--- Comment #11 from Héctor Eduardo Castro Avalos  
---
Hi Owen

I've deleted the icons for options where icon doesn't fit well with
description.

Feel free to change and/or close the bug if you think this isn't the right way.
No biggie.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #51211|0   |1
is obsolete||

--- Comment #10 from Héctor Eduardo Castro Avalos  
---
Created attachment 51212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51212=edit
Bug 16438: (followup) remove item where no single icon exist for options

Remove the double icon in options where double icons don't work well

To test: follow the previous commit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16159] guarantor section missing ID on patron add form

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159

Jonathan Druart  changed:

   What|Removed |Added

Version|3.22|unspecified

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #17 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #13)
> On http://www.jacksasylum.eu/ContentFlow/ I only see changelogs until 2010?
> If there is no further development(?), this might be a risk.

I can see that as blocker, Mason, would it be easy to update the plugin you
used?

(In reply to Frédéric Demians from comment #14)
> I don't see the advantage of this implementation against Bywater plugin. I
> can
> rather see disadvantages, including ContentFlow.js obsolescence (not updated
> since 2010, when jQuery Flipster used by ByWater plugin is actively
> maintained). Reading the code, I don't understand how GetRecentBibs generates
> the list of 'recent' bibs. Why a new table (carousel)? Is it necessary to
> read/re-read this table each time the OPAC main page is loaded?

Same for me, it's not conceivable to call this subroutine for each get of the
opac main page. Could you please detail what is the purpose of this subroutine?
Why do you need a new table, cache of the image url that's it?

Additional comments:
- kohastructure.sql changes are missing
- Amazon lookup should be optional
- We have several subroutines in C4::Koha to deal with ISBNs, I am sure you
could reuse
- What are the 150 and 300 hardcoded limits?
- It would be better to use Koha::Object
- It would be great to remove all the debug variables, it will ease the
readability

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #9 from Héctor Eduardo Castro Avalos  ---
(In reply to Owen Leonard from comment #8)
> My vote is still for no icon.

For all options or just for those icons which don't work well?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

--- Comment #8 from Owen Leonard  ---
My vote is still for no icon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com,
   ||oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

--- Comment #7 from Héctor Eduardo Castro Avalos  ---
Hi Owen and Jonathan

Please look if this is Ok

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #51210|0   |1
is obsolete||

--- Comment #6 from Héctor Eduardo Castro Avalos  ---
Created attachment 51211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51211=edit
Bug 16438: (followup) change icons to one icon

Change the two icons to just one: "fa fa-minus-square"

To test: follow the previous commit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

--- Comment #5 from Héctor Eduardo Castro Avalos  ---
Created attachment 51210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51210=edit
Bug 16438: (followup) change icons to one icon

Change the two icons to just one: "fa fa-minus-square"

To test: follow the previous commit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15823] Can still access patron discharge slip without having the syspref on - Permissions breach

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #17 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #10)
> 10/ Yes I see the message, but the discharge has been requested anyway.
> You have to redirect to a 404 in case of opac-discharge.pl is called with
> the op parameter set.

And what about the redirect at the OPAC?
Switch to signoff when you will submit a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16415] Layout problem on staff client detail page if local cover images are enabled

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #51109|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 51209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51209=edit
Bug 16415 - Layout problem on staff client detail page if local cover images
are enabled

This patch fixes a layout problem which appears on the staff client
bibliographic detail page if local covers are enabled but Amazon covers
are not.

To test, apply the patch and turn off AmazonCoverImages.

- Enable the LocalCoverImages system preference and locate or create a
  record which has a local cover image associated with it.
- View the bibliographic detail page. The bibliographic details should
  display in two columns, with text on the left and local cover image on
  the right.
- Test with AmazonCoverImages and LocalCoverImages enabled.
- Test with AmazonCoverImages enabled and LocalCoverImages disabled.

All combinations are OK.
Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16415] Layout problem on staff client detail page if local cover images are enabled

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Jonathan Druart  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com,
   ||katrin.fisc...@bsz-bw.de,
   ||tomasco...@gmail.com

--- Comment #9 from Jonathan Druart  
---
Adding Aleisha, Tomas and Katrin to the discussion.

What are your thoughts about the 2 displays/behaviors?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16159] guarantor section missing ID on patron add form

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16159] guarantor section missing ID on patron add form

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #51178|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 51208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51208=edit
Bug 16159 - guarantor section missing ID on patron add form

In the patron entry form template most  and  tags have
unique ids. This patch adds ids to fieldsets and legends which lack
them.

To test apply the patch and view the patron entry form. There should be
no visual changes. There should be no HTML validation errors triggered
by this change.

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7540] Add ids to the legend elements to make it easier to tweak with javascript

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7540

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16159

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16159] guarantor section missing ID on patron add form

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=7540

--- Comment #6 from Jonathan Druart  
---
(In reply to Owen Leonard from comment #5)
> (In reply to Jonathan Druart from comment #4)
> > Why do we need an id on the legend elements?
> 
> I don't know. I assume that the IDs were added at some time in the past in
> order to facilitate some kind of customization. My patch simply makes them
> consistent.

Added by bug 7540.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16431] Marc subfield structure should be cached using Koha::Cache

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #3 from Bernardo Gonzalez Kriegel  ---
Sorry, forgot the dependency.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #48289|0   |1
is obsolete||

--- Comment #33 from Jonathan Druart  
---
Created attachment 51206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51206=edit
Bug 15839: Koha::Reviews - Remove savereview

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #48287|0   |1
is obsolete||

--- Comment #31 from Jonathan Druart  
---
Created attachment 51204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51204=edit
Bug 15839: Koha::Reviews - Remove getnumberofreviews

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #48290|0   |1
is obsolete||

--- Comment #34 from Jonathan Druart  
---
Created attachment 51207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51207=edit
Bug 15839: Koha::Reviews - Remove C4::Review residue

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #48288|0   |1
is obsolete||

--- Comment #32 from Jonathan Druart  
---
Created attachment 51205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51205=edit
Bug 15839: Koha::Reviews - Remove updatereview

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #48284|0   |1
is obsolete||

--- Comment #28 from Jonathan Druart  
---
Created attachment 51201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51201=edit
Bug 15839: Koha::Reviews - Change default value for approved to 0

The reviews.approved column had a default value set to NULL.
It does not make sense, the default value should be 0, this will avoid
to have to specify the approved value when creating a new review.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #48286|0   |1
is obsolete||

--- Comment #30 from Jonathan Druart  
---
Created attachment 51203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51203=edit
Bug 15839: Koha::Reviews - Remove getreview

Note that this (biblionumber, borrowernumber) pair should be defined as
a unique key at the DB level (FIXME added)

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #48285|0   |1
is obsolete||

--- Comment #29 from Jonathan Druart  
---
Created attachment 51202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51202=edit
Bug 15839: Koha::Reviews - Remove deletereview

Note that a future enhancement should take into account the possible
error returned by ->approve, ->unapprove and ->delete

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #48283|0   |1
is obsolete||

--- Comment #27 from Jonathan Druart  
---
Created attachment 51200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51200=edit
Bug 15839: Koha::Reviews - Remove approvereview & unapprovereview

This patch adds 2 new methods to Koha::Review: approve and unapprove.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #48282|0   |1
is obsolete||

--- Comment #26 from Jonathan Druart  
---
Created attachment 51199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51199=edit
Bug 15839: Koha::Reviews - Remove getallreviews

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #48280|0   |1
is obsolete||

--- Comment #24 from Jonathan Druart  
---
Created attachment 51197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51197=edit
Bug 15839: Koha::Reviews - Add Koha::Review[s] classes

The subroutines in C4::Reviews are only doing CRUD operations.
This patch set moves them to 2 new Koha::Review[s] classes.

Test plan for the whole patch set:
0/ Set the reviewson syspref
1/ At the OPAC, create a couple of reviews for a record
Try and create a review without html tags different that br b i em big
small strong: You should get a warning.
2/ Edit a review
3/ On the Staff interface, you should see a "Comments pending approval"
link on the mainpage
4/ Approve 1 review and delete the other
5/ At the OPAC you should only see 1 review (the approved one) in the
"Comments" tab
6/ Modify the review
7/ The review should appear again in the "comments awaiting moderation"
tab.
Note that even the comment has not been changed, it will have to be
reapproved (FIXME later). This behavior already existed prior to this
patch.

Tested all patches together (with database updated)
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #48281|0   |1
is obsolete||

--- Comment #25 from Jonathan Druart  
---
Created attachment 51198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51198=edit
Bug 15839: Koha::Reviews - Remove getreviews

The C4::Reviews::getreviews subroutine retrieved the reviews for a given
record, depending on their status.
This can be achieve with a call to Koha::Reviews->search.
There were 2 calls to this subroutine. The one from opac-ISBDdetail.pl
does not look in used: the reviews are not display on this page. It
certainly comes from an old copy/paste from opac-detail.pl.
The one from opac-detail only asked for the approved reviews. So the
logged in user does not see its own review if it is pending approval.
Actually this pending approval review is only displayed when the user
submits it (because of a unecessary complex text replacement done in
JS).
With this patch, the approved reviews AND the unaproved review from the
logged in user will be displayed.
It will allow a future enhancement to add a way to delete our own
reviews.

Moreover, the reviews were retrieved even if they were not displayed (if
reviewson is off), it's now fixed.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16315] OPAC Shelfbrowser doesn't display the full title

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16315

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16315] OPAC Shelfbrowser doesn't display the full title

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16315

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #51163|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 51196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51196=edit
Bug 16315 - OPAC Shelfbrowser doesn't display the full title

This patch adds subtitle information to the display of titles in the
OPAC's shelf browser.

To test, apply the patch and make sure OPACShelfBrowser is enabled.

- View the detail page for any title in the OPAC which has items.
- Click the "Browse shelf" link next to any item in the holdings table.
- The titles in the shelf browser should display with all subtitle
  information as defined in Keywords to MARC mapping.

Signed-off-by: Bernardo Gonzalez Kriegel 
Adding 245a and c as 'subtitle' in Keywords to Marc make them
show on shelf browser.
No errors.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16431] Marc subfield structure should be cached using Koha::Cache

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||bgkrie...@gmail.com

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Master is moving fast

fatal: sha1 information is lacking or useless (admin/biblio_framework.pl).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 16431: Use Koha::Cache to cache marc subfield
structure

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16429] Going to circulation from notice triggers may change logged in branch

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

--- Comment #11 from Jonathan Druart  
---
Created attachment 51195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51195=edit
Bug 16429 - Fix root problem

The root of this issue is old code in circulation.pl that is no longer
needed and leaves the affected scripts open to future regressions.

Signed-off-by: Marc Véron 

Signed-off-by: Heather Braum 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

--- Comment #4 from Owen Leonard  ---
I would prefer that we use no icon if there is no single icon which works well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16429] Going to circulation from notice triggers may change logged in branch

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #10 from Jonathan Druart  
---
Good catch Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16429] Going to circulation from notice triggers may change logged in branch

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16429] Going to circulation from notice triggers may change logged in branch

2016-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #51141|0   |1
is obsolete||
  Attachment #51142|0   |1
is obsolete||

--- Comment #9 from Jonathan Druart  
---
Created attachment 51194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51194=edit
Bug 16429 - Going to circulation from notice triggers may change logged in
branch

If you edit notice triggers and then use the "Checko out" tab from the
top bar, you may change your logged in library by accident!

Test Plan:
1) Disable the system preference CircAutocompl
2) Go to the notice triggers
3) Select the triggers for a library other than the one you logged in as
4) Use the "Check out" tab at the top to check out to a patron
5) Note your logged in branch has changed ( you'll need to refresh the
page if the check out search took you directly to one patron ).
6) Apply this patch
7) Repeat steps 2-4
8) Note the branch no longer changes

Tested with both patches applied. Works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Heather Braum 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 172 matches

Mail list logo