[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

Nicholas van Oudtshoorn  changed:

   What|Removed |Added

  Attachment #51812|0   |1
is obsolete||

--- Comment #19 from Nicholas van Oudtshoorn  ---
Created attachment 51813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51813=edit
New patch, with silly typo fixed


Test plan:
0) Back up your databse
1) Apply this patch
2) In your mysql client use your Koha database and execute:
> DELETE FROM systempreferences;
> SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql;
-- Should be no errors.
> SELECT * FROM systempreferences WHERE
variable='SelfCheckAllowByIPRanges';
-- Should see 1 entry
> QUIT;
3) Restore your database
4) Run installer/data/mysql/atomicupdate/selfcheckallowbyiprange.sql
5) In your mysql client, using your Koha database, execute:
> SELECT * FROM systempreferences WHERE
variable='SelfCheckAllowByIPRanges';
-- should see the same entry as above
6) Try access the Self-checkout, self-checkout help, and self-checkout patron
images. It should work.
7) Log into the staff client
8) Home -> Koha administration -> Global system preferences
9) -> CIRCULATION
Make sure that SelfCheckAllowByIPRanges is set to a computer you can
test on
10) Try access the Self-checkout, self-checkout help, and self-checkout patron
images from a computer with an IP in the range above. It should work.
11) Try access the Self-checkout, self-checkout help, and self-checkout patron
images from a computer with an IP outside of the range above. It should *not*
work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

Nicholas van Oudtshoorn  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

Nicholas van Oudtshoorn  changed:

   What|Removed |Added

  Attachment #45899|0   |1
is obsolete||

--- Comment #18 from Nicholas van Oudtshoorn  ---
Created attachment 51812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51812=edit
Bug 14407 - rebased to latest git

Realised that this had bitrotted a bit. New patch that applies to the latest
git

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16565] additional_fields and additional_field_values are not dropped in kohastructure.sql

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16565] additional_fields and additional_field_values are not dropped in kohastructure.sql

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565

M. Tompsett  changed:

   What|Removed |Added

  Attachment #51717|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 51811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51811=edit
Bug 16565: Drop additional_fields and additional_field_values before creating
them

These 2 tables should be dropped before trying to create them

Test plan:
>From the SQL CLI, source the kohastructure.sql file
source it again
=> Without this patch you get 2 warnings
ERROR 1050 (42S01) at line 3580 in file:
'installer/data/mysql/kohastructure.sql': Table
'additional_fields' already exi
sts
ERROR 1050 (42S01) at line 3596 in file:
'installer/data/mysql/kohastructure.sql': Table
'additional_field_values' alrea
dy exists

=> With this patch, you won't get them

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #10 from M. Tompsett  ---
(In reply to Tomás Cohen Arazi from comment #7)
> If you write a patch, I write regression tests for it :-)

There's a patch. Where are the regression tests, Tomás? ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10459] borrowers should have a timestamp

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

M. Tompsett  changed:

   What|Removed |Added

  Attachment #51807|0   |1
is obsolete||

--- Comment #43 from M. Tompsett  ---
Created attachment 51810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51810=edit
Bug 10459 renamed timestamp to updated_on

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10459] borrowers should have a timestamp

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

M. Tompsett  changed:

   What|Removed |Added

  Attachment #50481|0   |1
is obsolete||

--- Comment #42 from M. Tompsett  ---
Created attachment 51809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51809=edit
Bug 10459: Follow up to update to atomic update methodology

Signed-off-by: Bernardo Gonzalez Kriegel 
New column created, no errors.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10459] borrowers should have a timestamp

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

M. Tompsett  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #44 from M. Tompsett  ---
Okay, Joy, go sign off crazy. ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10459] borrowers should have a timestamp

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

M. Tompsett  changed:

   What|Removed |Added

  Attachment #50480|0   |1
is obsolete||

--- Comment #41 from M. Tompsett  ---
Created attachment 51808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51808=edit
Bug 10459: Borrowers should have a timestamp

This patch adds a timestamp column to the borrowers table in kohastructure
and updatedatabase. (And also to the deletedborrowers table.)
A timestamp may be useful in synchronizing with external systems (among other
reasons).

Test plan:
Run updatestructure on an existing database, or install a new one.
Verify that the borrowers table has a timestamp now.

Signed-off-by: Marcel de Rooy 
Tested updatestructure and running kohastructure.sql.
Passed t/db_dependent/Members.t.

updatedatabase.pl did not apply. I edited and then run it. Columns were added
as expected.
Signed-off-by: Marc Veron 

Signed-off-by: Bernardo Gonzalez Kriegel 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10459] borrowers should have a timestamp

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

--- Comment #40 from M. Tompsett  ---
Created attachment 51807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51807=edit
Bug 10459 renamed timestamp to updated_on

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10459] borrowers should have a timestamp

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

--- Comment #39 from M. Tompsett  ---
(In reply to Joy Nelson from comment #38)
> I appreciate the discussion on this issue to standardize the naming.  Is
> this ticket now about renaming all timestamps or still adding a timestamp on
> the borrower table?  Do we need to split this ticket into two issues?

Yes, it can be split into two issues. The current two patches should be
standardized to created_on instead of timestamp with a third patch.


> I will be at the Hackfest in Greece and happy to help write a patch,
> test...whatever it takes to get this in!

Give me a bit... I'll add a third commit to meet standard.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #51714|0   |1
is obsolete||

--- Comment #9 from Srdjan Jankovic  ---
Created attachment 51806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51806=edit
[SIGNED-OFF] Bug 16502: Replace a few other ok-calls by is-calls

Trivial changes that speak for themselves..

Signed-off-by: Marcel de Rooy 
Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #51713|0   |1
is obsolete||

--- Comment #8 from Srdjan Jankovic  ---
Created attachment 51805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51805=edit
[SIGNED-OFF] Bug 16502: Adjust test for GetPlugins

The current test assumes that GetPlugins will return the test plugin
as the first one in the array. This is not correct.
This patch adjusts the test to a grep.

Test plan:
Run the test.
Bonus: Add additional plugins. Run the test again.

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #51545|0   |1
is obsolete||

--- Comment #7 from Srdjan Jankovic  ---
Created attachment 51804
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51804=edit
[SIGNED-OFF] Bug 16502: Add additional test to Plugins.t

In order to verify if the delete now really works, we add one test
in Plugins.t.

Test plan:
[1] Run the test.
[2] Bonus: Comment line 63 in Plugins.t where delete is called.
Run the test again. It should fail now.

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11606] Novelist Select in Staff Client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606

Nick Clemens  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|oleon...@myacpl.org |n...@bywatersolutions.com
 CC||n...@bywatersolutions.com

--- Comment #1 from Nick Clemens  ---
Work to be done:
1) Add new system preferences:
a) NovelistSelectStaffEnabled
b) NovelistSelectStaffProfile
c) NovelistSelectStaffPassword
2) Modify catalogue/detail.pl ( when NovelistSelectStaffEnabled is enabled ) to
a) Include https://imageserver.ebscohost.com/novelistselect/ns2init.js
b) Create a new tab titled "Novelist Select" in the list of tabs
c) Populate the div connected to this tab with the html needed for ns2init.js
to function correctly
d) Call novSelect.loadContentForQuery using the jQuery method $().ready to
trigger the call as soon as that part of the DOM is loaded.
3) Update the Koha OPAC code to use loadContentForQuery rather than the
deprecated loadContentForISBN

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10459] borrowers should have a timestamp

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #38 from Joy Nelson  ---
I appreciate the discussion on this issue to standardize the naming.  Is this
ticket now about renaming all timestamps or still adding a timestamp on the
borrower table?  Do we need to split this ticket into two issues?

Having a date (of any name) in the borrowers table will be game changing for
those of us who troubleshoot patron data day in and day out.   I'd love to see
this move forward with a resolution.

I vote for created_on/updated_on as a good path unless the majority wants
timestamp. Then I vote for timestamp.   I just want the field added.  :-)

I will be at the Hackfest in Greece and happy to help write a patch,
test...whatever it takes to get this in!

Cheers,
Joy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15333] Use Koha::Cache for caching all holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #8 from Brendan Gallagher  ---
Pushed to master - Should be in the May 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16323] Make dropdowns in header open on hover

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16323

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #7 from Jonathan Druart  
---
Aleisha,
I think these 2 links are good candidates for using an id (instead of a class).
We could have elements with a class named "more" or "branch", the selector is
not enough specific. (Note that I have not found any in current code)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16532] Libraries and groups showing empty tables if nothing defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16532] Libraries and groups showing empty tables if nothing defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #51767|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 51803
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51803=edit
Bug 16532: Groups showing empty tables if no groups defined

EDIT: Same change for libraries

To test:
1) Go to Admin -> Libraries and Groups
2) Notice empty tables if nothing defined
3) Apply patch and refresh page
4) Empty tables should not show
5) Add a new group
6) Confirm table shows correctly

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16532] Libraries and groups showing empty tables if nothing defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16507] show play media tab first

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
It seems weird to me to change the order of the tabs depending on the existence
of items. Would not it better to select the tab by default?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16465] OPAC discharge page has no title tag

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16465

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |jonathan.dru...@bugs.koha-c
   ||ommunity.org
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #51786|0   |1
is obsolete||

--- Comment #9 from Jonathan Druart  
---
Created attachment 51802
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51802=edit
Bug 16525: Have cancel button when adding new aq budget

At the moment you only see the cancel button on the form if editing an
existing budget. This patch adds a cancel button to the form which adds
a budget. Also changes the wording of the save button from 'Save
changes' to just 'Save' so it makes more sense when adding a new budget

To test:
1) Go to Admin -> Budgets -> New budget
2) Notice 'Save changes' button and no cancel
3) Apply patch and refresh page
4) Notice 'Save' button and 'cancel' link
5) Click 'cancel' - should be taken to Budgets administration page
6) Edit an existing budget
7) Click 'cancel' - should be taken to the funds page for that budget

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard 

Signed-off-by: Sabine Liebmann 

Signed-off-by: Jonathan Druart 
Still an issue: If edit a budget fron aqbudgets.pl, then cancel, you get
aqbudgets.pl?budget_period_id=XX. But existed before this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168

--- Comment #31 from Mirko Tietgen  ---
*** Bug 15964 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15964] Cannot view detail bib record because missing perl module WWW::YouTube::Download

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15964

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #6 from Mirko Tietgen  ---


*** This bug has been marked as a duplicate of bug 14168 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16594] Orders by fund report has wrong link to css and other issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

Summary|Orders by fund has wrong|Orders by fund report has
   |link to css and other   |wrong link to css and other
   |issues  |issues
 Depends on||11371


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371
[Bug 11371] Add a new report : Orders by budget
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11371] Add a new report : Orders by budget

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Blocks||16594


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594
[Bug 16594] Orders by fund report has wrong link to css and other issues
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16594] New: Orders by fund has wrong link to css and other issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594

Bug ID: 16594
   Summary: Orders by fund has wrong link to css and other issues
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Templates
  Assignee: hector.hecax...@gmail.com
  Reporter: hector.hecax...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Orders by fund has wrong link to css and other issues

-> The example in the wiki is wrong:



  [% INCLUDE 'datatables.inc' %]

-> Must be:


NOTE: Wiki needs to be updated

-> Missing  in  tag

-> Wrong word used "Date deceived" should be "Date received"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16578] Wide character warning in opac-export.pl when utf8 chosen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16578] Wide character warning in opac-export.pl when utf8 chosen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578

--- Comment #3 from Jonathan Druart  
---
Created attachment 51798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51798=edit
Bug 16578: Same fix for the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with warning_like

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
I get 3 without the patch and 1 remains with the patch applied, is it expected?

t/db_dependent/TestBuilder.t .. 1/9 Violation of unique constraint in Branch at
t/lib/TestBuilder.pm line 201.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16531] Circ overdues report is showing an empty table if no overdues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #5 from Jonathan Druart  
---
With this patch, the noreport variable becomes useless.
However it seems that it's useful in case of FilterBeforeOverdueReport is set.
Please double check.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16492] Checkouts ( and possibly checkins and other actions ) will use the patron home branch as the logged in library

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16492

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #11 from Jonathan Druart  
---
Should not we just set a correct userenv instead of not creating at all?
There are several places where an error could occur if not set.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16492] Checkouts ( and possibly checkins and other actions ) will use the patron home branch as the logged in library

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16492

--- Comment #10 from Jonathan Druart  
---
Created attachment 51797
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51797=edit
Bug 16492: Test that no_set_userenv will not set userenv if not exist yet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16592] New: Use Bootstrap modal for MARC and Card preview on acquisitions receipt summary page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592

Bug ID: 16592
   Summary: Use Bootstrap modal for MARC and Card preview on
acquisitions receipt summary page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/acqui/parcel.pl?invoiceid=x
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
Blocks: 8290

On the acquisitions receipt summary page the "MARC" and "Card" links should
trigger a preview in a Bootstrap modal instead of a Greybox modal.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290
[Bug 8290] Replace usage of Greybox modals with Bootstrap modals
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8290] Replace usage of Greybox modals with Bootstrap modals

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290

Owen Leonard  changed:

   What|Removed |Added

 Depends on||16592


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592
[Bug 16592] Use Bootstrap modal for MARC and Card preview on acquisitions
receipt summary page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16592] Use Bootstrap modal for MARC and Card preview on acquisitions receipt summary page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16569] Message box for "too many checked out" is empty if AllowTooManyOverride is not enabled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16569

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16519] Do not use global variables in [opac-]addbybiblionumbers.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16519

--- Comment #4 from Jonathan Druart  
---
Shame on me, sorry about that.
I have decided to rename the $bib var after my tests, but I have missed one!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16519] Do not use global variables in [opac-]addbybiblionumbers.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16519

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #51484|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 51796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51796=edit
Bug 16519: Replace 'our' with 'my' in [opac-]addbybiblionumbers.pl

To avoid bug like bug 16518 and to ease the readability/maintainability
of these scripts, this patch replaces the use of 'our' with 'my' to
avoid the use of global variables.

Basically the code has been moved from subroutines to the appropriate places.

Test plan:
At the intranet and OPAC sides
1/ Add items to a list
2/ Add items to a list using an existing name
3/ Add items to a list you don't have right on it (by modifying the
biblionumber in the url)
4/ At the OPAC, use the opac-addbybiblionumber.pl without being logged
in to add items to a list

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16519] Do not use global variables in [opac-]addbybiblionumbers.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16519

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16462] Change default sorting of circulation patron search results to patron name

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16462

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16462] Change default sorting of circulation patron search results to patron name

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16462

--- Comment #1 from Owen Leonard  ---
Created attachment 51792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51792=edit
Bug 16462 - Change default sorting of circulation patron search results to
patron name

This patch changes the default sort of patron quick search results from
the circulation header search or when searching for a patron during the
hold process.

To test:

In Circulation:
- Perform a search by name for a patron which will
  return multiple search results.
- Confirm that the results are sorted by patron name.

In the catalog:
- Locate and place a hold on a title.
- When prompted to select a patron to place the hold for, perform a
  search by name which will return multiple results.
- Confirm that the results are sorted by patron name.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16582] t/Price.t test should pass if Test::DBIx::Class is not available

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16567] RSS feeds show issues in W3C validator and can't be read by some aggregators (Chimpfeedr, feedbucket)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16567

--- Comment #1 from Owen Leonard  ---
This may be fixed by Bug 16111.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16566] 'Print slip' button formatting inconsistent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16336] UX of holds patron search with long lists of results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336

--- Comment #6 from Owen Leonard  ---
(In reply to Jonathan Druart from comment #5)

> I am wondering why branchcode and categorycode are displayed, instead of
> their description, on these 2 tables. Any valid reasons?

It is probably simply a remnant of the old version which displayed the list in
a  and required a more compact display.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href=

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|oleon...@myacpl.org |dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16566] 'Print slip' button formatting inconsistent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566

--- Comment #2 from Owen Leonard  ---
Created attachment 51791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51791=edit
Bug 16566 - 'Print slip' button formatting inconsistent

This patch modifies the style of some "print slip" links on the checkin
page to make them consistent with other buttons shown in dialogs.

This patch also removes the use of "onclick" in some places in favor of
defining events in the JavaScript.

To test apply the patch and go to Circulation -> Check in.

- Check in an item which belongs at another branch. You should see a
  dialog which asks the user to transfer the item. Confirm that the
  "Print slip" button looks correct and works correctly.

- Check in the same item again. You should see a different dialog which
  has both a "Print transfer slip" and "Cancel transfer" button. The
  "Print transfer slip" button should look correct and work correctly.

- Check in an item which is part of a rotating collection. (Or, if Bug
  16570 is still open, check in any item) You should see a dialog which
  notifies you that the item is part of a rotating collection. The
  "Print slip" button in this dialog should look correct and work
  correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16589] Quote of the day: Can not upload csv file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589

--- Comment #1 from Owen Leonard  ---
I've tried my own CSV file and those on Bug 15684 and I get no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16541] Make edit and delete links styled buttons in cities administration

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16541

--- Comment #1 from Owen Leonard  ---
Created attachment 51790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51790=edit
Bug 16541 - Make edit and delete links styled buttons in cities administration

This patch modifies the cities administration page, converting edit and
delete links to Bootstrap buttons with Font Awesome icons.

To test, apply the patch and go to Administration -> Cities and towns.
The 'Edit' and 'Delete' buttons should look correct and work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16541] Make edit and delete links styled buttons in cities administration

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16541

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16579] Use separate memached namespace for caching koha-conf.xml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

s.paltine...@berlin.bard.edu changed:

   What|Removed |Added

 CC||s.paltine...@berlin.bard.ed
   ||u

--- Comment #26 from s.paltine...@berlin.bard.edu ---
DBIx::Class::Schema::source(): Can't find source for HouseboundProfile at
/home/sandbox1/src/Koha/Objects.pm line 253

I got this error when clicking on the "Housebound" tab, in a new patron's
profile. (testing in a sandbox)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16541] Make edit and delete links styled buttons in cities administration

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16541

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16543] Make edit and delete links styled buttons in patron attribute types administration

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16543

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16543] Make edit and delete links styled buttons in patron attribute types administration

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16543

--- Comment #1 from Owen Leonard  ---
Created attachment 51789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51789=edit
Bug 16543 - Make edit and delete links styled buttons in patron attribute types
administration

This patch modifies the Patron attribute types page, converting edit and
delete links to Bootstrap buttons with Font Awesome icons.

To test, apply the patch and go to Administration -> Patron attribute
types. The 'Edit' and 'Delete' buttons should look correct and work
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16513] Improvements and fixes for quote upload process

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16513

--- Comment #2 from Marc Véron  ---
Can not test upload (with and without patch), see Bug 16589

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16589] Quote of the day: Can not upload csv file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16513

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #25 from Alex Sassmannshausen 
 ---

New module to handle management of circulation to Housebound readers.

- Ability to create housebound profiles & scheduled visits for patrons.
- Ability to record users as Deliverers or Choosers (or both), using
  extended patron attributes.
- Ability to link choosers and deliverers to individual delivery runs.
- 'Delivery Frequencies' are customizable through authorised
  values ('Frequency' category respectively).

* C4/Auth.pm: Add check: useHouseboundModule.
* koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc: add
  Housebound menu if appropriate.
* Koha/Patron.pm (housebound_profile): New method.
* Koha/Patron.pm (housebound_choosers, housebound_deliverers): New
  methods.
* Koha/Patron/Housebound.pm: New File.
* Koha/Patron/HouseboundProfile.pm: New File.
* Koha/Patron/HouseboundProfiles.pm: New File.
* Koha/Patron/HouseboundVisits.pm: New File.
* Koha/Patron/HouseboundVisit.pm: New File.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: New file.
* members/housebound.pl: New file.
* installer/data/mysql/kohastructure.sql: Add housebound_* tables.
* installer/data/mysql/sysprefs.sql: Add HouseboundModule syspref.
* koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref:
  Add HouseboundModule syspref.
* installer/data/mysql/atomicupdate/housebound_tables.sql: New file.
* t/db_dependent/Patron/Housebound.t: New file.
* t/db_dependent/Patron/HouseboundProfiles.t: New file.
* t/db_dependent/Patron/HouseboundVisits.t: New file.

Test plan:
- Apply patch.
- Run atomic update script.
- Run Unit Tests (t/db_dependent/Patron/Housebound*)
- Optionally, add additional authorised values of 'Frequency'
  categories.
- Verify 'HouseboundModule', and 'ExtendedPatronAttributes sysprefs are
  on.
- Ona patron page, the Housebound menu should have been added.
  - create housebound profile
+ ensure Frequency values are from correct authorised values.
  - create 'housebound visits' (deliveries)
+ ensure chooser/deliverer lists are populated with patrons that
have the Chooser or Deliverer Attribute type (none by default: you
will have to grant some users those attributes).
  - edit the profile/instances.
  - delete the instances.
- Switch off 'HouseboundModule'
  - the Housebound menu should disappear

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16579] Use separate memached namespace for caching koha-conf.xml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jesse Weaver  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz,
   ||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16590] New: error log recording

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16590

Bug ID: 16590
   Summary: error log recording
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: PC
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: mj...@reitoria.ulisboa.pt
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Hi!

I needed to know what kind of error is this:

"
Software error:

Can't call method "fields" on an undefined value at
/usr/share/koha/lib/C4/Biblio.pm line 2438.

For help, please send mail to the webmaster (
 bibliote...@reitoria.utl.pt), giving this
error message and the time and date of the error. 

Título da dissertação: Efeito da administração da hormona PGF2α nos problemas
pós-parto, mais concretamente na retenção placentária em bovinos leiteiros

Autor: Francisco Maria Pereira Leitão de Freitas Formigal

2 - The record you requested does not exist (503962).
"

I'm working with an old version of Koha, from 2012 the 3.08.05.000 version.

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16579] Use separate memached namespace for caching koha-conf.xml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jesse Weaver  changed:

   What|Removed |Added

 CC||jwea...@bywatersolutions.co
   ||m

--- Comment #1 from Jesse Weaver  ---
I'd like to suggest that we either:

 a) drop the caching for the koha-conf.xml entirely (in my testing, this adds
about .14 seconds to an average CGI load) or
 b) just hardcode the server/namespace for caching the koha-conf.xml and use
the filename of the .xml as the cache key
(kohaconf-/etc/koha/sites/SITE/koha-conf.xml). Using localhost:11211 will work
for 99.9% of setups, and if memcached isn't running there, Koha will still work
(just a tiny bit slower under CGI).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16513] Improvements and fixes for quote upload process

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16513

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16589

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16589] New: Quote of the day: Can not upload csv file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589

Bug ID: 16589
   Summary: Quote of the day: Can not upload csv file
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org

Upload a valid CSV file to QOD results in error message.

Uploads limited to csv. Incorrect filetype: application/vnd.sun.xml.calc

Tested with a valid sample file from Bug 15684 - Fix encoding issues with quote
upload
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47405

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16519] Do not use global variables in [opac-]addbybiblionumbers.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16519

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |Failed QA

--- Comment #2 from Marc Véron  ---
Sorry, QA tools complain:
 FAIL   opac/opac-addbybiblionumber.pl
   FAIL   valid
Global symbol "$bib" requires explicit package name 
opac/opac-addbybiblionumber.pl had compilation errors.
Found = in conditional, should be == 
Can't modify scalar in scalar assignment

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

PTFS Europe Sandboxes  changed:

   What|Removed |Added

  Attachment #51784|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

--- Comment #8 from PTFS Europe Sandboxes  ---
Created attachment 51786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51786=edit
Bug 16525: Have cancel button when adding new aq budget

At the moment you only see the cancel button on the form if editing an
existing budget. This patch adds a cancel button to the form which adds
a budget. Also changes the wording of the save button from 'Save
changes' to just 'Save' so it makes more sense when adding a new budget

To test:
1) Go to Admin -> Budgets -> New budget
2) Notice 'Save changes' button and no cancel
3) Apply patch and refresh page
4) Notice 'Save' button and 'cancel' link
5) Click 'cancel' - should be taken to Budgets administration page
6) Edit an existing budget
7) Click 'cancel' - should be taken to the funds page for that budget

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard 

Signed-off-by: Sabine Liebmann 

Signed-off-by: Sabine Liebmann 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 CC||sandbo...@ptfs-europe.com

--- Comment #7 from PTFS Europe Sandboxes  ---
Patch tested with a sandbox, by Sabine Liebmann 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #24 from Alex Sassmannshausen 
 ---
New module to handle management of circulation to Housebound readers.

- Ability to record users as housebound (HB category), volunteers
  (combined deliverers and choosers, VOL category), deliverers (DELIV
  category) choosers (CHO category).
- Ability to link users to individual delivery runs.
- Ability to check on issuing to housebound users flagging
  if title has previously been issued to this user, to aid choosers.
- 'Delivery Days' and 'Delivery Frequencies' are customizable through
  authorised values ('Day' and 'Frequency' categories respectively.

Sponsored by Halton Borough Council

* C4/Auth.pm: Add check: useHouseboundModule.
* C4/Circulation.pm: use Housebound to check for previous issue.
* koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc: add
  Housebound menu if appropriate.
* koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: add
  'previous checkout' warning.
* C4/Housebound.pm: new.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: new.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/houseboundedit.tt: new.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/houseboundinstances.tt: new.
* members/housebound.pl: new.
* members/houseboundedit.pl: new.
* members/houseboundinstances.pl: new.
* installer/data/mysql/atomicupdate/housebound_tables.sql: new.
  - create 'housebound', 'housebound_instance' tables,
  - create 'HB', 'VOL', 'DELIV', 'CHO' borrower categories,
  - create sample 'Day', 'Frequency' authorised values,
  - add 'useHouseboundModule', 'useHouseboundCheckPrevious' syspref.
* t/Housebound.t: new.

Test plan:
- Apply patch.
- Run atomic update script.
- Optionally, run Unit Tests (t/Housebound.t)
- Create at least 1 of each: 'HB', 'VOL', 'DELIV', 'CHO' borrower.
- Optionally, add additional authorised values of 'Day' and
  'Frequency' categories.
- Verify 'useHouseboundModule' & 'useHouseboundCheckPrevious' sysprefs
  are on.
- On the page of the 'HB' borrower, open the new 'Housebound' menu.
  - create housebound profile
+ ensure Day and Frequency values are from correct authorised
  values
  - create 'housebound instances' (deliveries)
+ ensure chooser/deliverer lists are populated with VOL, DELIV,
  CHO borrowers
  - edit the profile/instances.
  - delete the profile/instances.
- For a borrower with a housebound profile, issue an item, then
  - return that item
  - attempt to re-issue that item (you should get a warning)
- Switch off 'useHouseboundCheckPrevious', repeat last test
  - the warning should not appear
- Switch off 'useHouseboundModule'
  - the Housebound menu should disappear
  - the issue warnings should no longer appear.

Largely based on prior work from Mark Gavillet and Colin Campbell.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #51772|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

--- Comment #6 from sandbo...@biblibre.com  ---
Created attachment 51784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51784=edit
Bug 16525: Have cancel button when adding new aq budget

At the moment you only see the cancel button on the form if editing an
existing budget. This patch adds a cancel button to the form which adds
a budget. Also changes the wording of the save button from 'Save
changes' to just 'Save' so it makes more sense when adding a new budget

To test:
1) Go to Admin -> Budgets -> New budget
2) Notice 'Save changes' button and no cancel
3) Apply patch and refresh page
4) Notice 'Save' button and 'cancel' link
5) Click 'cancel' - should be taken to Budgets administration page
6) Edit an existing budget
7) Click 'cancel' - should be taken to the funds page for that budget

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard 

Signed-off-by: Sabine Liebmann 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

sandbo...@biblibre.com  changed:

   What|Removed |Added

 CC||sandbo...@biblibre.com

--- Comment #5 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Sabine Liebmann 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16588] New: libreadonly-perl (and libreadonly-xs-perl) need to be added as dependencies

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588

Bug ID: 16588
   Summary: libreadonly-perl (and libreadonly-xs-perl) need to be
added as dependencies
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ro...@kallisti.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

Doing a build in a clean environment:

#   Failed test 'use C4::Overdues;'
#   at t/00-load.t line 47.
# Tried to use 'C4::Overdues'.
# Error:  Can't locate Readonly.pm in @INC (you may need to install the
Readonly module) (@INC contains:
/build/koha-3.23~git+20160525154303.188b3b5b/blib/PERL_MODULE_DIR
/build/koha-3.23~git+20160525154303.188b3b5b/blib/arch /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.22.1 /usr/local/share/perl/5.22.1
/usr/lib/x86_64-linux-gnu/perl5/5.22 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.22 /usr/share/perl/5.22
/usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base .) at
/build/koha-3.23~git+20160525154303.188b3b5b/blib/PERL_MODULE_DIR/Koha/SearchEngine.pm
line 22.

It should have been added in bug 7893, but apparently went missing some time
later.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #179 from Kyle M Hall  ---
Created attachment 51779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51779=edit
Bug 14610 - Add and update modules

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #183 from Kyle M Hall  ---
Created attachment 51783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51783=edit
Bug 14610 - Update Schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #182 from Kyle M Hall  ---
Created attachment 51782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51782=edit
Bug 14610 - Update opac.css via less

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530

Jan Kissig  changed:

   What|Removed |Added

 CC||jan.kis...@th-wildau.de

--- Comment #4 from Jan Kissig  ---
tested in sandbox. layout was okay and not messed up while showing error
messages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #181 from Kyle M Hall  ---
Created attachment 51781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51781=edit
Bug 14610 - Add unit tests

Signed-off-by: Kyle M Hall 

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #180 from Kyle M Hall  ---
Created attachment 51780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51780=edit
Bug 14610 - Add and update scripts

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #51527|0   |1
is obsolete||
  Attachment #51528|0   |1
is obsolete||
  Attachment #51529|0   |1
is obsolete||
  Attachment #51530|0   |1
is obsolete||
  Attachment #51531|0   |1
is obsolete||
  Attachment #51532|0   |1
is obsolete||
  Attachment #51533|0   |1
is obsolete||
  Attachment #51534|0   |1
is obsolete||

--- Comment #178 from Kyle M Hall  ---
Created attachment 51778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51778=edit
Bug 14610 - Add ability to place article requests in Koha - Update database

Article Requests are somewhat similar to holds, but are not requests for
an item to check out. Instead, article requests are requests for a
photocopy of a particular section of a book ( most often ). This is very
common in academic libraries where researchers may request a copy of a
single article found in a journal.

This patch set adds the ability to place article requests in Koha. It
allows the control of what can be requested via the circulation rules.
Since article requests of electronic resources are not outside the realm
of possibility, the feature will check not only the items for
requstability, but the record itself as well ( i.e. both items.itype and
biblio.itemtype ).

Article requests can be placed for patrons from the opac and staff
intranet and can be viewed in most areas where holds are viewed ( e.g.
patron details, record details, etc ).

There is a script to view article requests in progress within the
circulation module. Article requests can be Open ( i.e. new ), In
Processing, Completed, or Canceled. The status of a given request can be
updated from this script.

Test Plan:
1) Apply the patch set
2) Run updatedatabase.pl
3) Enable the system preference ArticleRequests
4) Set up some required fields in:
ArticleRequestsMandatoryFields
ArticleRequestsMandatoryFieldsItemsOnly
ArticleRequestsMandatoryFieldsRecordOnly
5) Edit your circ rules, set article requests to 'yes' for something
6) Test the ability to add an article request from the opac ( required fields
enforced )
7) Test the ability to add an article request from the staff interface (
required fields no enforced )
8) Note you can choose item level or record level requests
9) Change the rule to "record only"
10) Repeat 6 and 7
11) Note you cannot choose items
12) Change the rule to "item only"
13) Repeat 6 and 7
14) Note you must choose an item
15) Note that the 'new request' message is queued for each new request
16) Browse to /cgi-bin/koha/circ/article-requests.pl
17) Note requests are split by pickup branch
18) Test slip printing via the "Print slip" action
19) Process request vai "Process request" action
20) Note an email notice is queued for patron
21) Refresh /cgi-bin/koha/circ/article-requests.pl
22) Note request has moved to "processing" tab.
23) Complete request with "Complete request" action
24) Note message is queued for patron
25) Cancel a request, add cancelation note.
26) Note message is queued for patron

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as default

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

--- Comment #13 from Tomás Cohen Arazi  ---
(In reply to Julian Maurice from comment #12)
> It doesn't look like a bugfix (severity = normal), can someone confirm this
> is an enhancement ?

Well, it might be. Because bug 11096 introduced XML as exchange format for DOM
setups, to allow bigger records to get indexed, and we then deprecated GRS-1.
To me this is something we just forgot to tweak after 11096. But it is really
up to you to include it in 3.22 as it supposes a behaviour change for people
using the cronjob to update their indexes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530

PTFS Europe Sandboxes  changed:

   What|Removed |Added

  Attachment #51555|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530

--- Comment #3 from PTFS Europe Sandboxes  ---
Created attachment 51777
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51777=edit
Bug 16530: Adding a circ sidebar navigation menu

This adds a sidebar to
circ/branchoverdues.tt
circ/circulation.tt (I also fixed up some of the indentation in this file to
make it easier to see where the divs started and ended)
circ/renew.tt
circ/returns.tt
circ/selectbranchprinter.tt
circ/transferstoreceive.tt
circ/view_holdsqueue.tt
circ/waitingreserves.tt
offline_circ/list.tt
offline_circ/process_koc.tt

To test:
1) Go to all of the above pages and confirm the sidebar menu shows up.
2) Trigger any error messages you can possibly think of (i.e. on renew.pl:
barcode does not exist). Confirm that this does not mess up the layout of the
page
3) Go to a user account page, Check out tab. (Since this is a
circ/circulation.pl page). Ensure the circ nav sidebar doesn't show up (confirm
it looks as it usually does)
4) Decide if you like how things look or not!

Sponsored-by: Catalyst IT

Signed-off-by: Jan Kissig 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 CC||sandbo...@ptfs-europe.com
 Status|Needs Signoff   |Signed Off

--- Comment #2 from PTFS Europe Sandboxes  ---
Patch tested with a sandbox, by Jan Kissig 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16540] Translatability in opac-auth.tt (tag-splitted sentences)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540

Marc Véron  changed:

   What|Removed |Added

  Attachment #51735|0   |1
is obsolete||

--- Comment #3 from Marc Véron  ---
Created attachment 51776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51776=edit
Bug 16540: Translatability in opac-auth.tt (tag-splitted sentences)

This patch removes tag-splitting from 2 sentences in pac-auth.tt

To test:
- Review code changes and verify that following sentences
  are no longer splitted by -tags:
  "Logout and try again with a different user"
  "Try to log in using a different Google account"

UPDATE: Amended to fix a tiny typo

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is passed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

--- Comment #13 from Tomás Cohen Arazi  ---
(In reply to Julian Maurice from comment #11)
> This is weird, bug 16506 depends on the first patch of this bug, but the 2nd
> patch of this bug depends on bug 16506. They have been pushed to master in
> this order: 16505 (1st) -> 16506 (all) -> 16505 (2nd).
> I think the 2nd patch here belongs to bug 16506.

I take the blame for the circular bug dependency :-D
And you are right about Jonathan's followup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16323] Make dropdowns in header open on hover

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16323

--- Comment #6 from PTFS Europe Sandboxes  ---
Created attachment 51775
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51775=edit
Bug 16323: Make dropdowns in header open in hover

To test:
1) Go to staff client
2) Hover over 'More' menu and confirm that menu opens
3) Hover over the user dropdown on the right ("username | branch") and confirm
that menu opens

Sponsored-by: Catalyst IT

Signed-off-by: Sinziana Paltineanu 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16323] Make dropdowns in header open on hover

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16323

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 CC||sandbo...@ptfs-europe.com
 Status|Needs Signoff   |Signed Off

--- Comment #5 from PTFS Europe Sandboxes  ---
Patch tested with a sandbox, by Sinziana Paltineanu


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16323] Make dropdowns in header open on hover

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16323

PTFS Europe Sandboxes  changed:

   What|Removed |Added

  Attachment #50546|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16578] Wide character warning in opac-export.pl when utf8 chosen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16578] Wide character warning in opac-export.pl when utf8 chosen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578

Marc Véron  changed:

   What|Removed |Added

  Attachment #51743|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 51774
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51774=edit
Bug 16578: Fix wide character errors in opac-export.pl

This simple patch fixes wide character warning raised by opac-export.pl when
'MARC (Unicode/UTF-8)' and 'MARC (Unicode/UTF-8, Standard)' formats are chosen
for downloading records.

To test:
- Have records indexed
- Open your OPAC logs:
  $ tail -f /var/log/koha/kohadev/opac-error.log
- Open the detail page in the opac for a record
- Choose Save record > MARC (Unicode/UTF-8)
=> FAIL: opac-export.pl: Wide character in print at
/home/vagrant/kohaclone/opac/opac-export.pl line 116., referer:
http://localh...
- Choose Save record > MARC (Unicode/UTF-8, Standard)
=> FAILE opac-export.pl: Wide character in print...
- Apply the patch
- Choose Save record > MARC (Unicode/UTF-8)
=> SUCCESS: No warnings raised.
- Choose Save record > MARC (Unicode/UTF-8, Standard)
=> SUCCESS: No warnings raised.
- Sign off :-D

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16442] C4::Ris is not plack safe

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442

Chris Cormack  changed:

   What|Removed |Added

  Attachment #51221|0   |1
is obsolete||

--- Comment #3 from Chris Cormack  ---
Created attachment 51773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51773=edit
Bug 16442: Make C4::Ris plack safe

C4::Ris incorrectly uses 4 package variables:
- $utf: not used, can be removed
- $intype: set to marcflavour once, but later it assumes that it is
  usmarc if not defined
- $marcprint: always 0, so set it to 0
- $protoyear: only used in 1 subroutine, let's define it at this
  level

Test plan:
Just make sure the RIS export works as before this patch

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16442] C4::Ris is not plack safe

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16585] Update Italian installer sample files for 16.05

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

--- Comment #1 from Zeno Tajoli  ---
To test:
- Start with an empty database
- Install it-IT
- Run the web installer in it-IT/Italian
- Verify all files, especially sample notices, sample_frequencies,
sample_numberpatterns load without any problems.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/