[Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896

Florent Mara  changed:

   What|Removed |Added

 CC||florent.m...@gmail.com

--- Comment #6 from Florent Mara  ---
I have not had time to fully validate this patch but started to write some
tests for Koha::Account module. (I hope these tests won't be causing trouble) 

There would preferably be more tests but the method is ~150+ lines which makes
it difficult to get started.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896

--- Comment #5 from Florent Mara  ---
Created attachment 51920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51920=edit
bug 15896 - A few tests for Koha::Account

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15541] Prevent normalization during matching/import process

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

--- Comment #21 from David Cook  ---
(In reply to Marcel de Rooy from comment #20)
> I understand your point hopefully :)
> If we start using this field: Since it was meant to add a Normalize class, I
> think you should create at least a rudimentary one now.
> Moving the _normalize code and add your none/raw normalizations.

I'm not sure that I understand your point, unfortunately :(.

I think using normalization during matching is a bad idea, as Zebra already
normalizes the query before processing it. Here's the problem:

Custom normalization: Strip hyphens
Zebra normalization: Strip colons

Data: "Mont-Royal: it's a mountain"

Zebra would index it as "Mont-Royal it's a mountain".
You'd retrieve that exact phrase with the query "Mont-Royal: it's a mountain",
which would be transformed into "Mont-Royal it's a mountain" by Zebra.

However, with the custom normalization, your query would be "MontRoyal: it's a
mountain" before going to Zebra, and then it would be "MontRoyal it's a
mountain" when processed by Zebra.

If you're doing an exact search, your search will fail, even though that same
data in the regular Koha search would work.

We need to normalize indexing/retrieval consistently, and the way to do that is
with Zebra alone.

If there needs to be extra normalization, I think it should be done before the
record even makes it to Koha...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href=

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575

--- Comment #5 from David Cook  ---
(In reply to Srdjan Jankovic from comment #4)
> I think you should have included js removal with the patch, not used so
> should go.
> What's the story with the intranet basket?

Good points. It looks like the intranet has the same issue as the OPAC basket,
so I should change that...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16619] Installer stuck in infinite loop

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16619

Florent Mara  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #2 from Florent Mara  ---
I reset the Version value to 16.05, applied this patch to master and ran the
web installer. 

The web installer correctly updated the version number to 16.060 and the
web installer correctly re-directed to the Koha login page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16619] Installer stuck in infinite loop

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16619

Florent Mara  changed:

   What|Removed |Added

 CC||florent.m...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16619] Installer stuck in infinite loop

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16619

Liz Rea  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16619] Installer stuck in infinite loop

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16619

--- Comment #1 from Liz Rea  ---
Created attachment 51919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51919=edit
Bug 16619 - installer stuck in infinite loop

To test: run the web installer on master, it should not get stuck in an
infinite loop.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16619] New: Installer stuck in infinite loop

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16619

Bug ID: 16619
   Summary: Installer stuck in infinite loop
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: blocker
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: l...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

updatedatabase tries to update to 16.056 when the kohaversion in koha.pm is
set to 16.06. We need to set the updatedatabase version to match.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16609] Catch warning from Koha::Hold in Hold.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16609

--- Comment #4 from Srdjan Jankovic  ---
Oh yes, definitely fails for me on the master branch, nothing to do with the
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16582] t/Price.t test should pass if Test::DBIx::Class is not available

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

M. Tompsett  changed:

   What|Removed |Added

  Attachment #51913|0   |1
is obsolete||

--- Comment #11 from M. Tompsett  ---
Comment on attachment 51913
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51913
Bug 16582 [DO NOT PUSH] 'prove t' failure on 00-load.t

While similar to bug 9054, regular expressions like this don't actually show
the real problem of missing dependencies. And if those dependencies are
completely optional, we shouldn't even test. This is handled better on bug
16618 now. No need to keep this first patch around. The second can be tested
directly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16618] 00-load.t prematurely stops all testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16618

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16582

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16582] t/Price.t test should pass if Test::DBIx::Class is not available

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16618

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16618] 00-load.t prematurely stops all testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16618

M. Tompsett  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16618] 00-load.t prematurely stops all testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16618

--- Comment #1 from M. Tompsett  ---
Created attachment 51918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51918=edit
Bug 16618: 00-load.t prematurely stops all testing

Rather than add/remove regular expressions to skip modules (like bug 9054),
encapsulate the decision logic into a separate function.

Currently there are three libraries which trigger halts:
Koha::NorwegianDB (which was already there)
Koha::ElasticSearch::Indexer
Koha::SearchEngine::Elasticsearch::Search

TEST PLAN
-
1) prove t/00-load.t
   -- should barf horribly on Catmandu stuff
  if not: sudo apt-get remove libcatmandu-marc-perl
  then repeat step.
2) apply patch
3) prove t/00-load.t
   -- should not barf horribly
4) run koha qa test tools

NOTE: The four optional modules for Koha::NorwegianDB are
  listed in the PerlDependencies.pm, while there is
  no mention of Catmandu libraries at all there.
  This may be another bug which needs fixing.

TECH NOTES (for ideas of how to tinker around):
These three things should trigger the three module cases:
sudo apt-get remove libcatmandu-marc-perl
sudo apt-get remove libcatmandu-store-elasticsearch-perl
sudo apt-get remove libconvert-basen-perl

You probably had koha-perldeps installed before, so the following wil mostly
fix:
sudo apt-get install koha-perldeps libcatmandu-marc-perl

And in case you didn't have elastic search stuff installed:
echo deb http://packages.elastic.co/elasticsearch/1.7/debian stable main | sudo
tee /etc/apt/sources.list.d/elasticsearch.list
wget -O- https://packages.elastic.co/GPG-KEY-elasticsearch | sudo apt-key add -
sudo apt-get update

cd ~
wget
http://debian.koha-community.org/koha/otherthings/elasticsearch_deps.tar.gz
tar xvf elasticsearch_deps.tar.gz
cd es_deps
sudo dpkg i lib*
sudo apt-get install -f

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16618] 00-load.t prematurely stops all testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16618

M. Tompsett  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16618] New: 00-load.t prematurely stops all testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16618

Bug ID: 16618
   Summary: 00-load.t prematurely stops all testing
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: mtomp...@hotmail.com
QA Contact: gmcha...@gmail.com

Rather than add/remove regular expressions to skip modules (like bug 9054),
encapsulate the decision logic into a separate function.

Currently there are three libraries which trigger halts:
Koha::NorwegianDB (which was already there)
Koha::ElasticSearch::Indexer
Koha::SearchEngine::Elasticsearch::Search

This number should always be relatively small, if not 0.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16618] 00-load.t prematurely stops all testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16618

M. Tompsett  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16617] debian/control is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #5 from Brendan Gallagher  ---
Pushed to Master - Should be in the November 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16617] debian/control is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #51916|0   |1
is obsolete||

--- Comment #4 from Jesse Weaver  ---
Created attachment 51917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51917=edit
Bug 16617 - fix issues with debian/control

Signed-off-by: Chris Cormack 

Signed-off-by: Jesse Weaver 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16617] debian/control is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

Jesse Weaver  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16617] debian/control is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

Chris Cormack  changed:

   What|Removed |Added

  Attachment #51915|0   |1
is obsolete||

--- Comment #3 from Chris Cormack  ---
Created attachment 51916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51916=edit
Bug 16617 - fix issues with debian/control

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16617] debian/control is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16617] debian/control is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

Robin Sheat  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #2 from Robin Sheat  ---
This allows the package to start building, which is progress.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16617] debian/control is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

--- Comment #1 from Robin Sheat  ---
Created attachment 51915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51915=edit
Bug 16617 - fix issues with debian/control

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16617] debian/control is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

Robin Sheat  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |ro...@kallisti.net.nz
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16617] New: debian/control is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

Bug ID: 16617
   Summary: debian/control is broken
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: Sun
OS: Linux
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ro...@kallisti.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

A blind regeneration of the debian/control file currently is unlikely to
succeed due to missing dependencies and errors in a declaration.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

--- Comment #22 from Oliver Bock  ---
(In reply to Jonathan Druart from comment #21)
> Would you please open a new bug report (and link it to this one) to attach
> your patch?
> This one is marked as "pushed to master" and new patches should go on their
> own bug report.

Done: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5534] Koha does not ignore punctuation when searching

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5534

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export Data screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #10 from Brendan Gallagher  ---
Pushed to Master - Should be in the November 2016 release.  Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16569] Message box for "too many checked out" is empty if AllowTooManyOverride is not enabled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16569

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #4 from Brendan Gallagher  ---
Pushed to Master - Should be in the November 2016 release.  Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16582] t/Price.t test should pass if Test::DBIx::Class is not available

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

--- Comment #10 from M. Tompsett  ---
As per comment #6's PS, first one is renamed.

As per comment #5: "I don't understand why use_ok are in the BEGIN block?"
-- I wondered the same thing.

"A BEGIN code block is executed as soon as possible, that is, the moment it is
completely defined, even before the rest of the containing file (or string) is
parsed. You may have multiple BEGIN blocks within a file (or eval'ed string);
they will execute in order of definition. Because a BEGIN code block executes
immediately, it can pull in definitions of subroutines and such from other
files in time to be visible to the rest of the compile and run time. Once a
BEGIN has run, it is immediately undefined and any code it used is returned to
Perl's memory pool."

So, perhaps a memory optimization?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16582] t/Price.t test should pass if Test::DBIx::Class is not available

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

M. Tompsett  changed:

   What|Removed |Added

  Attachment #51910|0   |1
is obsolete||

--- Comment #9 from M. Tompsett  ---
Created attachment 51914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51914=edit
Bug 16582 t/Price.t test should pass if Test::DBIx::Class is not available

TEST PLAN
-
1) prove t/Prices.t
   -- failure
2) apply patch
3) prove t/Prices.t
   -- nicely skipped when Test::DBIx::Class is not available.

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16582] t/Price.t test should pass if Test::DBIx::Class is not available

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

M. Tompsett  changed:

   What|Removed |Added

  Attachment #51909|0   |1
is obsolete||

--- Comment #8 from M. Tompsett  ---
Created attachment 51913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51913=edit
Bug 16582 [DO NOT PUSH] 'prove t' failure on 00-load.t

This patch makes it so 00-load.t doesn't cause 'prove t' to
prematurely die before reaching other tests.

TEST PLAN
-
1) prove t
   -- dies on 00-load.t
2) apply patch
3) prove t
   -- now t/Prices.t should be the failure.

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15541] Prevent normalization during matching/import process

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

--- Comment #20 from Marcel de Rooy  ---
(In reply to David Cook from comment #19)
> While the matchpoint_component_norms.norm_routine isn't currently used in
> the code, I add some code that does use it for the sole purpose of detecting
> a "none" or "raw" normalization (ie no normalization).
> 
> Sorry, but I'm still not sure what you're asking, Marcel. Honestly, there
> should probably be no normalization at this step. I would remove the
> "Normalization rule" from the code, but it affects too many existing
> systems. The patch I have here is the lightest change while also providing
> the desired functionality. I'm not sure what else a person could do to skip
> the normalization in a way that is backwards compatible.

I understand your point hopefully :)
If we start using this field: Since it was meant to add a Normalize class, I
think you should create at least a rudimentary one now.
Moving the _normalize code and add your none/raw normalizations.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16582] t/Price.t test should pass if Test::DBIx::Class is not available

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

--- Comment #7 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #6)
> We should fix the tests or put some conditional skip in those tests.
> I don't favor the regexs in load.t.
Well probably not possible,,

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16582] t/Price.t test should pass if Test::DBIx::Class is not available

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #6 from Marcel de Rooy  ---
(In reply to Srdjan Jankovic from comment #5)
> Just a couple of generic questions/musings not entirely to do with this
> patch:
> 
> * Wouldn't it be better to rename tests that we don't want to
> .t.NOT_READY_YET or similar instead of doing those regexes in load.t?

We should fix the tests or put some conditional skip in those tests.
I don't favor the regexs in load.t.

PS A new name for the first patch would be helpful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15630] Make Edifact module pluggable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #14 from Marcel de Rooy  ---
(In reply to David Cook from comment #13)

> > +use Module::Pluggable search_path => ['Koha::Plugin'], except => 
> > qr/::Edifact(|::Line|::Message|::Order|::Segment|::Transport)$/;
> 
> This seems suboptimal... since any plugin with additional packages would
> need an exception.

Have the same feeling when I see these lines..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16595] Concurrent search between ISBN-10 and ISBN-13 in staff client and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16595

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=13528

--- Comment #1 from Magnus Enger  ---
See bug 13528. This is possible if you
- enable SearchWithISBNVariations and
- disable UseQueryParser

Should we close this as a duplicate, or keep it open as a reminder that it
would be nice to be able to do this without disabling QueryParser?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13528] Ability to search on the different isbn variations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528

Magnus Enger  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16595

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16609] Catch warning from Koha::Hold in Hold.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16609

--- Comment #3 from Marcel de Rooy  ---
Srdjan,
Thx for testing. Strange that it fails. You seem to fail already before
reaching my adjustment.  Should fail without my patch too?
I am not having any problem:

t/db_dependent/Hold.t .. ok
All tests successful.
Files=1, Tests=32,  2 wallclock secs ( 0.04 usr  0.01 sys +  1.38 cusr  0.10
csys =  1.53 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when referencing external resources

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

Oliver Bock  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=14571

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

Oliver Bock  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16615

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16615] New: Full-site SSL: always use SSL when referencing external resources

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

Bug ID: 16615
   Summary: Full-site SSL: always use SSL when referencing
external resources
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oliver.b...@aei.mpg.de
QA Contact: testo...@bugs.koha-community.org

Created attachment 51912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51912=edit
Patch: Open Library API via SSL

When running Koha in a full-site-SSL configuration accessing external resources
like Open Library cover images via HTTP doesn't work (mixed SSL/non-SSL
content). It thus breaks a core feature of Koha. Referencing such resources
always via HTTPS resolves the problem and also enhances privacy as a
side-effect.

Previous tickets took care of Amazon resources. This ticket is supposed to
address the remaining external resource providers, starting with Open Library.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15630] Make Edifact module pluggable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630

--- Comment #13 from David Cook  ---
Comment on attachment 49788
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49788
Bug 15630 - Make Edifact module pluggable

Review of attachment 49788:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15630=49788)
-

::: Koha/Plugins.pm
@@ +20,4 @@
>  use Modern::Perl;
>  
>  use Module::Load::Conditional qw(can_load);
> +use Module::Pluggable search_path => ['Koha::Plugin'], except => 
> qr/::Edifact(|::Line|::Message|::Order|::Segment|::Transport)$/;

This seems suboptimal... since any plugin with additional packages would need
an exception.

Wouldn't it make more sense to use "only" to only find plugins like
^Koha::Plugin::Com::CompanyName::PluginName$.

I suppose it might be too late for that now as there's any number of plugins
that can be allowed so perhaps one does have to only use exceptions from now
on... 

I'm thinking of making a plugin, but I'll probably just use a different
namespace like Local::PluginName::Submodules...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16540] Translatability in opac-auth.tt (tag-splitted sentences)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #51776|0   |1
is obsolete||

--- Comment #4 from Srdjan Jankovic  ---
Created attachment 51911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51911=edit
[SIGNED-OFF] Bug 16540: Translatability in opac-auth.tt (tag-splitted
sentences)

This patch removes tag-splitting from 2 sentences in pac-auth.tt

To test:
- Review code changes and verify that following sentences
  are no longer splitted by -tags:
  "Logout and try again with a different user"
  "Try to log in using a different Google account"

UPDATE: Amended to fix a tiny typo
Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16540] Translatability in opac-auth.tt (tag-splitted sentences)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/