[Koha-bugs] [Bug 16726] Text in Preferences search box does not clear
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hm, I am not sure I agree. For example when you do a simple search in the OPAC we also keep the search term showing, as it allows you to check what you searched for and change your search if nothing was found etc. I like that feature of the system preference editor - as I can spot a typo that might have caused me finding nothing. If this was to be removed, it might be nice to show what was searched for in another way. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Frédéric Demianschanged: What|Removed |Added CC||frede...@tamil.fr --- Comment #29 from Frédéric Demians --- I'm undecided whether to push this enhancement to 16.05 branch. CONS: As a enhancement, it should be reserved to November release. PRO: It's not that big. It impacts portions of code (returns.tt) that may have to be modified later by bugfixes that would be difficult to apply if master diverges too much from stable. Any advice? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Karl Holtenchanged: What|Removed |Added CC||khol...@switchinc.org --- Comment #30 from Karl Holten --- Our institutions are happy to see this issue is getting worked on! We're a consortium and it's pretty confusing to see 5 or 6 expected issues, all with different dates. Thanks for working on this! Karl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Edie Discherchanged: What|Removed |Added CC||edisc...@cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16740] New: EDIFACT on Basket Groups leads to 500 error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16740 Bug ID: 16740 Summary: EDIFACT on Basket Groups leads to 500 error Change sponsored?: --- Product: Koha Version: master Hardware: All URL: cgi-bin/koha/acqui/basketgroup.pl?booksellerid=1 OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org On the basket group page you can see the generate edifact button for all baskets (even if edi isn't set up) and it goes to a 500 error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15974] Rancor - 942c is always displaying first in the list.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974 Karl Holtenchanged: What|Removed |Added CC||khol...@switchinc.org --- Comment #1 from Karl Holten --- This is also the case for 008 dropdown on the top. It seems like both of the dropdowns automatically default to the first alphabetical option. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 Jacek Ablewiczchanged: What|Removed |Added Attachment #50797|0 |1 is obsolete|| --- Comment #2 from Jacek Ablewicz --- Created attachment 52409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52409=edit Bug 16365: Selectivelly introduce GetMarcStructure() "unsafe" variant for better performance GetMarcStructure() currently uses Koha::Cache in the "safe" mode (returning deep copy of the result data structure by default), which causes numerous performance issues in many Koha scripts. Switching it to the "unsafe" mode globally (2nd patch from Bug 16140) resolves those issues, but ensuring that it is regression-free (and that it will stay that way in the future) is far from easy. This patch proposes a bit more manageable solution, it introduces a possibility to use "unsafe" variant selectivelly (only in those places in the code where GetMarcStructure() is called repetively). That way, amount of the code that needs to be audited for possible problems gets vastly reduced, without any performance trade-offs. Test plan: 1) Have a look at the code and audit the parts affected by this patch for possible regressions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16738] Improve EDIFACT messages template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16738 --- Comment #1 from Owen Leonard--- Created attachment 52408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52408=edit Bug 16738 - Improve EDIFACT messages template This patch makes several improvements to the EDIFACT messages template to make it more consistent with similar interfaces in Koha. Changes to edimsg.tt are made to simplify the display of the data in a modal. This patch also corrects a couple of markup errors. To test you must have multiple rows of data in the edifact_messages table. I tested with dummy data I inserted manually. Should should have some rows which use 'QUOTE' and 'ORDERS' as the message_type. To test deletions you may need to apply the patch for Bug 16737. - Apply the patch and go to Acquisitions -> EDIFACT messages. - In the table of messages, the date should be displayed according to your system preference. - Sorting by date should work correctly regardless of date format setting. - The 'Actions' column should contain 'View message' and 'Delete' Bootstrap-style buttons with Font Awesome icons. The column should be unsorted. - Clicking the 'Delete' button should prompt you to confirm. - Clicking the 'View message' button should trigger a modal which loads the message data. - Test the page with no messages or when all messages have been deleted. The page should display a standard message dialog instead of an empty table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16738] Improve EDIFACT messages template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16738 Owen Leonardchanged: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16648] Add Content system preferences for all CSS and XSLT sysprefs that accept a URL.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16648 --- Comment #3 from Barton Chittenden--- (In reply to Tomás Cohen Arazi from comment #2) > Barton, as far as I can tell, XSLT's can be URLs and that is handled in > XSLT_Handler.pm Tomás, Yes -- I'm relying on the ability to use URLs for either CSS or XSLT. My idea is that the 'content' system preference would provide a resource at a given URL, and then the standard system preferences for CSS or XSLT would use that URL... I think this might have been clearer if bugzilla hadn't decided to re-format my ascii art table ;-). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hallchanged: What|Removed |Added Attachment #52402|0 |1 is obsolete|| Attachment #52403|0 |1 is obsolete|| --- Comment #10 from Kyle M Hall --- Created attachment 52406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52406=edit Bug 14570 - Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #11 from Kyle M Hall--- Created attachment 52407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52407=edit Bug 14570 - Update Schema -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hallchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16738] New: Improve EDIFACT messages template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16738 Bug ID: 16738 Summary: Improve EDIFACT messages template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/edifactmsgs.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org I am working on several improvements to the EDIFACT messages page: - Show a standard dialog if there are no messages - Make actions links Bootstrap buttons with Font Awesome icons - Show EDIFACT message contents inside modal instead of in separate window - Correct DataTables configuration - Format dates according to system preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16737] Error when deleting EDIFACT message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16737 Owen Leonardchanged: What|Removed |Added Attachment #52404|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 52405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52405=edit [SIGNED-OFF] Bug 16737 - Error when deleting EDIFACT message If you try to delete an EDIFACT message it triggers an error: Can't use string ("2") as a subroutine ref while "strict refs" in use at /acqui/edifactmsgs.pl line 43. Test Plan: 1) Attempt to delete an EDIFACT message 2) Note the error 3) Apply this patch 4) Attempt to delete an EDIFACT message again 5) Note it succeeds Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16737] Error when deleting EDIFACT message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16737 Owen Leonardchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hallchanged: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #9 from Kyle M Hall --- Working on unit tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16737] Error when deleting EDIFACT message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16737 --- Comment #1 from Kyle M Hall--- Created attachment 52404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52404=edit Bug 16737 - Error when deleting EDIFACT message If you try to delete an EDIFACT message it triggers an error: Can't use string ("2") as a subroutine ref while "strict refs" in use at /acqui/edifactmsgs.pl line 43. Test Plan: 1) Attempt to delete an EDIFACT message 2) Note the error 3) Apply this patch 4) Attempt to delete an EDIFACT message again 5) Note it succeeds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16737] Error when deleting EDIFACT message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16737 Kyle M Hallchanged: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16737] New: Error when deleting EDIFACT message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16737 Bug ID: 16737 Summary: Error when deleting EDIFACT message Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/edifactmsgs.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Acquisitions Assignee: k...@bywatersolutions.com Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org If you try to delete an EDIFACT message it triggers an error: Can't use string ("2") as a subroutine ref while "strict refs" in use at /acqui/edifactmsgs.pl line 43. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10459] borrowers should have a timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 Tomás Cohen Arazichanged: What|Removed |Added Status|Signed Off |Passed QA --- Comment #73 from Tomás Cohen Arazi --- Guys, push the followup! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10459] borrowers should have a timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 Tomás Cohen Arazichanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10459] borrowers should have a timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 Tomás Cohen Arazichanged: What|Removed |Added Status|Pushed to Master|ASSIGNED --- Comment #72 from Tomás Cohen Arazi --- Moving back to the @RM queue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10459] borrowers should have a timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 Tomás Cohen Arazichanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hallchanged: What|Removed |Added Attachment #52400|0 |1 is obsolete|| Attachment #52401|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 52402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52402=edit Bug 14570 - Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #8 from Kyle M Hall--- Created attachment 52403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52403=edit Bug 14570 - Update Schema -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #6 from Kyle M Hall--- Test plan will be forthcoming. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #4 from Kyle M Hall--- Created attachment 52400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52400=edit Bug 14570 - Make it possible to add multiple guarantors to a record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #5 from Kyle M Hall--- Created attachment 52401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52401=edit Bug 14570 - Update Schema -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hallchanged: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16640] Move actions on acquisitions receipt summary page into menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16640 Marc Véronchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16640] Move actions on acquisitions receipt summary page into menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16640 Marc Véronchanged: What|Removed |Added Attachment #52371|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 52399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52399=edit Bug 16640 - Move actions on acquisitions receipt summary page into menu This patch moves two groups of links into two menus: MARC and Card preview into one, Receive, transfer, cancel, etc. into another. Also changed: The transfer order pop-up window has been sized down to be more consistent with other similar pop-ups. Baskets and basket group links now include the whole name rather than just the number to make it easier to click. To test you must have a basket or baskets with multiple titles on order, both received and pending. - Apply the patch and go to Acquisitions -> Vendor -> Receive shipment -> Receive a new shipment (or open an existing invoice). - In the list of pending orders: - Test the 'View' menu for multiple titles. The 'MARC' and 'Card' menu items should work correctly. - Test the 'Actions' menu for the following actions: - Receive - Transfer - Cancel order - Cancel order and delete catalog record - Confirm that under some circumstances the 'Cancel order' and 'Cancel order and delete catalog record' items are disabled. In these cases hovering over the menu items should trigger a tooltip. An explanation should be displayed in red at the bottom of the menu. Clicking the menu item should trigger an alert with the explanation. Followed test plan, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15485] Allow choosing different XSLTs for lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485 Tomás Cohen Arazichanged: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15485] Allow choosing different XSLTs for lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485 --- Comment #9 from Tomás Cohen Arazi--- Created attachment 52398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52398=edit Bug 15485: (QA followup) Fix behaviour and default values Jonathan noticed the current behaviour is that the lists rendering falls back to the XSLTResults, and if not defined (i.e. != 'default' and != some_path) it falls back to a legacy display (non-XSLT). The patchset changed this behaviour because 'default' is not a valid value for the lists. So it should fallback to the current behaivour (i.e. Results XSLT configuration) if not defined. This patch fixes this by adding || C4::Context->preference('XSLTResultsDisplay') (and the OPAC counterpart). It also fixes minor glitches on the update message (oops) and bad default value in sysprefs.sql for 'XSLTListsDisplay'. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 Marc Véronchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16730 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16730] Use member-display-address-style*-includes in moremember-brief.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16730 Marc Véronchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=4041 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760 Marc Véronchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=4041 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 Marc Véronchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=10760 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734 Jonathan Druartchanged: What|Removed |Added Attachment #52390|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 52397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52397=edit Bug 16734: getLanguages() in opac-search.pl should be called only if needed There is no need to always call getLanguages() in opac/opac-search.pl (especially not if it's an actual search), it's output is used only in opac-advsearch.tt template. This patch moves it into 'if ( ... $template_type eq 'advsearch' )' block. Speed gain is rather moderate (40 - 80 msec, if the mysql server is no too busy, and the results are already in query cache), but it eliminates a lot of small DBI calls, making a further profiling of OPAC searches a bit easier. Test plan: just ensure that language selection is still available on OPAC advanced search page, and that it still works like intended. Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16693] reserve/renewscript.pl is not used and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16693 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16693] reserve/renewscript.pl is not used and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16693 Jonathan Druartchanged: What|Removed |Added Attachment #52346|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 52396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52396=edit Bug 16693: Remove reserve/renewscript.pl It is not used since bug 11703 Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16736] Keep branch filter when changing suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16736 Marc Véronchanged: What|Removed |Added Attachment #52381|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 52395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52395=edit Bug 16736 - Keep branch filter when changing suggestion When changing suggestion, the selected tab is kept. The same should be done with the selected branch. Test plan: - Go to suggestions table : /cgi-bin/koha/suggestion/suggestion.pl - Select a branch in Acquisition information > For - Select a pending suggestion - Change status as accepted - Click on Submit => without patch, the table is no longer filtered by branch => with patch, the table is filtered by branch Works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16736] Keep branch filter when changing suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16736 Marc Véronchanged: What|Removed |Added Status|Needs Signoff |Signed Off CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16720] DBIx ActionLogs.pm should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16720 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16720] DBIx ActionLogs.pm should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16720 Jonathan Druartchanged: What|Removed |Added Attachment #52345|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 52394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52394=edit Bug 16720: Remove DBIx ActionLogs.pm The update_dbix_class_files.pl script generates ActionLog.pm instead, which is already on the source tree. To test: - Apply the patch => SUCCESS: Koha/Schema/Result/ActionLogs.pm is removed - Run: $ mysql -uroot > CREATE DATABASE dbic; \q $ mysql -uroot dbic < kohaclone/installer/data/mysql/kohastructure.sql $ misc/devel/update_dbix_class_files.pl --db_name dbic --db_user root => SUCCESS: Koha/Schema/Result/ActionLogs.pm is not re-generated - Run: $ git grep ActionLogs => SUCCESS: There's no code using it - Sign off Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hallchanged: What|Removed |Added Status|Signed Off |Failed QA --- Comment #153 from Kyle M Hall --- (In reply to Benjamin Daeuber from comment #152) > (In reply to Benjamin Daeuber from comment #151) > > > I had not considered that a bug. If you do let me know and I'll change > > > that > > > behavior. > > > > If I allow item > > level holds for certain item types and then have a global preference > > override that, it may be a problem. > > If I *disallowed* item level holds for a certain item type that should say. Yes, I think I need to deal with that in the code. Setting to Failed QA for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11606] Novelist Select in Staff Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606 Nicole C. Engardchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11606] Novelist Select in Staff Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606 Nicole C. Engardchanged: What|Removed |Added Attachment #52386|0 |1 is obsolete|| --- Comment #6 from Nicole C. Engard --- Created attachment 52392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52392=edit Bug 11606: Add Novelist client to staff To test: 1 - Apply patches 2 - Update database 3 - View detail pages for some records and ensure no changes have been made 4 - Enable NovelistSelectStaffEnabled (and enter or have info in the Profile and password) 5 - Set NovelistSelectStaffView to 'above' 6 - View detail pages for some records, verify that if novelist info is available it is displyaed and nothign is displayed if not 7 - Repeat with all staff view options Sponsored by: Walla Walla Public Library (http://www.wallawallapubliclibrary.org/) Los Gatos Library (http://www.losgatosca.gov/42/Los-Gatos-Library) Signed-off-by: Jesse Weaver Internal signoff. Signed-off-by: Alexis Rodegerdts Signed-off-by: Dwayne Nance -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11606] Novelist Select in Staff Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606 Nicole C. Engardchanged: What|Removed |Added Attachment #52387|0 |1 is obsolete|| --- Comment #7 from Nicole C. Engard --- Created attachment 52393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52393=edit Bug 11606: (followup) minor typos Signed-off-by: Jesse Weaver Internal signoff. Signed-off-by: Alexis Rodegerdts Signed-off-by: Dwayne Nance -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16641] Update Novelist in opac to use updated call to fetch content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Nicole C. Engardchanged: What|Removed |Added Attachment #52388|0 |1 is obsolete|| --- Comment #3 from Nicole C. Engard --- Created attachment 52391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52391=edit Bug 16641: Update Novelist in OPAC to use updated call to fetch content To test: 1 - Enable novelistselect content in the opac 2 - Find a record with novelist content, confirm it displays in tabs ro above or below accoring to pref 3 - Find a record without novelist content, note you get an empty tab 4 - Apply patch 5 - Ensure results have not changed for items with content 6 - Ensure tab does not display for item with no content Sponsored by: Walla Walla Public Library (http://www.wallawallapubliclibrary.org/) Los Gatos Library (http://www.losgatosca.gov/42/Los-Gatos-Library) Signed-off-by: Jesse Weaver Internal signoff. Signed-off-by: Dwayne Nance Signed-off-by: Alexis Rodegerdts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16641] Update Novelist in opac to use updated call to fetch content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Nicole C. Engardchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12599] IndependentBranches Holes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12599 Kyle M Hallchanged: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #5 from Kyle M Hall --- (In reply to M. Tompsett from comment #4) > I suspect that bug 15707 is a step towards fixing independent branch > permissions for consortia. Indeed, I have a general endgame that involves being able to set permissions on a per library or per group basis. It will require an under the hood revamp of the permissions system. It's on my todo list ; ) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734 Marc Véronchanged: What|Removed |Added CC||ve...@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734 Marc Véronchanged: What|Removed |Added Attachment #52374|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 52390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52390=edit Bug 16734: getLanguages() in opac-search.pl should be called only if needed There is no need to always call getLanguages() in opac/opac-search.pl (especially not if it's an actual search), it's output is used only in opac-advsearch.tt template. This patch moves it into 'if ( ... $template_type eq 'advsearch' )' block. Speed gain is rather moderate (40 - 80 msec, if the mysql server is no too busy, and the results are already in query cache), but it eliminates a lot of small DBI calls, making a further profiling of OPAC searches a bit easier. Test plan: just ensure that language selection is still available on OPAC advanced search page, and that it still works like intended. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 Jonathan Druartchanged: What|Removed |Added Blocks||16729 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16729 [Bug 16729] Use member-display-address-style*-includes when printing user summary -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16729] Use member-display-address-style*-includes when printing user summary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16729 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Version|3.22|master Depends on||4041 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 [Bug 4041] Address Format as a I18N/L10N system preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16729] Use member-display-address-style*-includes when printing user summary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16729 Jonathan Druartchanged: What|Removed |Added Attachment #52372|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 52389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52389=edit Bug 16729: Use member-display-address-style*-includes when printing user summary This patch replaces the address part in moremember-print.tt to print identical address information as displayed on the screen (including street numer, formatted as required by syspref 'AddressFormat' To test: - Apply patch - Search for a user with all address information filled - Verify that 'Print summmary' displays the same information as displayed on the screen. - Change value of syspref 'AdressFormat' - Verify that address format on 'Print summary' changes as appropriate Signed-off-by: mehdi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16729] Use member-display-address-style*-includes when printing user summary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16729 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16641] Update Novelist in opac to use updated call to fetch content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Jesse Weaverchanged: What|Removed |Added Attachment #51967|0 |1 is obsolete|| --- Comment #2 from Jesse Weaver --- Created attachment 52388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52388=edit Bug 16641: Update Novelist in OPAC to use updated call to fetch content To test: 1 - Enable novelistselect content in the opac 2 - Find a record with novelist content, confirm it displays in tabs ro above or below accoring to pref 3 - Find a record without novelist content, note you get an empty tab 4 - Apply patch 5 - Ensure results have not changed for items with content 6 - Ensure tab does not display for item with no content Sponsored by: Walla Walla Public Library (http://www.wallawallapubliclibrary.org/) Los Gatos Library (http://www.losgatosca.gov/42/Los-Gatos-Library) Signed-off-by: Jesse Weaver Internal signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11606] Novelist Select in Staff Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606 --- Comment #5 from Jesse Weaver--- Created attachment 52387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52387=edit Bug 11606: (followup) minor typos Signed-off-by: Jesse Weaver Internal signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11606] Novelist Select in Staff Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606 Jesse Weaverchanged: What|Removed |Added Attachment #51966|0 |1 is obsolete|| --- Comment #4 from Jesse Weaver --- Created attachment 52386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52386=edit Bug 11606: Add Novelist client to staff To test: 1 - Apply patches 2 - Update database 3 - View detail pages for some records and ensure no changes have been made 4 - Enable NovelistSelectStaffEnabled (and enter or have info in the Profile and password) 5 - Set NovelistSelectStaffView to 'above' 6 - View detail pages for some records, verify that if novelist info is available it is displyaed and nothign is displayed if not 7 - Repeat with all staff view options Sponsored by: Walla Walla Public Library (http://www.wallawallapubliclibrary.org/) Los Gatos Library (http://www.losgatosca.gov/42/Los-Gatos-Library) Signed-off-by: Jesse Weaver Internal signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15485] Allow choosing different XSLTs for lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #8 from Jonathan Druart --- (In reply to Jonathan Druart from comment #7) > Comment on attachment 52321 [details] [review] > Bug 15485: Use lists-specific XSLT sysprefs > > Review of attachment 52321 [details] [review]: > - > > ::: opac/opac-shelves.pl > @@ +248,4 @@ > > > > my $borrower = GetMember( borrowernumber => $loggedinuser ); > > > > +my $xslfile = C4::Context->preference('OPACXSLTListsDisplay'); > > it seems that || 'default' is missing here, could you confirm? Actually no, it's not. But the other one should not default to 'default' (...), otherwise the non-XSLT view will never be used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15485] Allow choosing different XSLTs for lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16648] Add Content system preferences for all CSS and XSLT sysprefs that accept a URL.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16648 Tomás Cohen Arazichanged: What|Removed |Added CC||tomasco...@gmail.com --- Comment #2 from Tomás Cohen Arazi --- Barton, as far as I can tell, XSLT's can be URLs and that is handled in XSLT_Handler.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 --- Comment #13 from Jonathan Druart--- Created attachment 52385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52385=edit Bug 16148: Fix submit button text The text of the submit button should be init getting the val(), and not the text(). Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Jonathan Druartchanged: What|Removed |Added Attachment #51977|0 |1 is obsolete|| Attachment #52080|0 |1 is obsolete|| Attachment #52373|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 52382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52382=edit Bug 16148 - Revised layout and behavior of marc modification template management This patch makes changes to the layout and behavior of the marc modification template management page to make it adhere better to common interaction patterns in Koha. - The initial view shows a list of templates rather than pre-selecting the first available template for editing. - A toolbar has been added with a "New template" button. - The initial view of existing templates has an actions menu containing menu items for 'Edit actions,' 'Duplicate,' and 'Delete.' It doesn't appear to be possible to edit an existing template's name. - The "Create template" form is no longer shown all the time. - Clicking the "New template" toolbar button triggers a modal with the form for creating a template. An existing template can be chosen to duplicate. - Choosing "Duplicate" from one of the template menus triggers the "New template" modal and preselects the corresponding template in the "duplicate" . - When editing actions for a template: - The breadcrumbs menu now reflects that a template is being modified. - The template name has been added as a heading. - A "New action" button appears in the toolbar - The "Edit" and "Delete" links now have a Bootstrap button style. - The add/edit form is now hidden by default. - Clicking "New action" or "edit" shows the add or edit form. - Clicking "Cancel" in the add/edit form hides the form. To test, apply the patch and clear your cache if necessary. - Got to Tools -> MARC modification templates - Test the "New template" button. - Confirm that new template creation works. - Confirm that duplicating a template works. - Test the menu items in the "Actions" menu: - "Duplicate" should trigger the new template modal and preselect the template you chose to duplicate. Confirm that the template is successfully duplicated. - "Delete" should prompt you to confirm the deletion. Test both cancelling and confirming this operation. - "Edit actions" should load the page for adding or editing actions to a template. Test the operations on this page: New action, edit, delete, changing action order. Note that this patch does not fix Bug 15814, so action descriptions must still not contain single quotes. Signed-off-by: Filippos Kolovos Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 --- Comment #12 from Jonathan Druart--- Created attachment 52384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52384=edit Bug 16148 [Follow-up] Revised layout and behavior of marc modification template management This follow-up corrects a JavaScript error by using jQuery, which is is more forgiving when selecting elements which may not exist on the page. Also changed: Corrected a duplicate class attribute and fixed a jshint error. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 --- Comment #11 from Jonathan Druart--- Created attachment 52383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52383=edit Bug 16148: Add preventDefault to avoid the scrollbar to move to the top .. when click on buttons Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #9 from Lari Taskula--- The patches above with Bug 16212 is my proposal for splitting the Swagger spec. This passes online.swagger.io/validator validations and passes all current REST tests in master. I think it is essential to split the specification yet also maintain its validity against the swagger.io-validator. I'm open to ideas and criticism :) I will soon provide the patch for defining the required permissions in Swagger paths spec. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16736] Keep branch filter when changing suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16736 --- Comment #1 from Fridolin SOMERS--- Created attachment 52381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52381=edit Bug 16736 - Keep branch filter when changing suggestion When changing suggestion, the selected tab is kept. The same should be done with the selected branch. Test plan: - Go to suggestions table : /cgi-bin/koha/suggestion/suggestion.pl - Select a branch in Acquisition information > For - Select a pending suggestion - Change status as accepted - Click on Submit => without patch, the table is no longer filtered by branch => with patch, the table is filtered by branch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16736] Keep branch filter when changing suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16736 Fridolin SOMERSchanged: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #72 from Kyle M Hall--- (In reply to Jonathan Druart from comment #70) > The discussion about the modal should be brought at the next dev meeting I > think: > Is everybody (i.e. the majority) agrees on this change, who is going to > implement it to the other pages, etc. That sounds good to me. I think we should vote to add this behavior as the preferred "one page" viewer/editor style, deprecating the older "hide/show" style in preference to it. Once that is voted on, we can identify pages that use the "hide/show" style and file bugs to replace each one. I'd be happy to work on those bugs. I think using the modal is great ux improvement and it would be worthwhile to make that change throughout Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16736] Keep branch filter when changing suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16736 Fridolin SOMERSchanged: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16736] New: Keep branch filter when changing suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16736 Bug ID: 16736 Summary: Keep branch filter when changing suggestion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org When changing suggestion, the selected tab is kept. The same should be done with the selected branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hallchanged: What|Removed |Added Blocks||16735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Kyle M Hallchanged: What|Removed |Added Depends on||15707 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 [Bug 15707] Add ability to define hierarchical groups of libraries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16735] New: Replace existing library search groups functionality with the new hierarchical groups system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Bug ID: 16735 Summary: Replace existing library search groups functionality with the new hierarchical groups system Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org We should replace the existing library search groups with the use of the new hierarchical groups system so that old system can be removed completely. General outline: 1) Add the option to each group for it to be a "search" group 2) Port over existing groups by creating a new group for each "categorycode" in the branchrelations table 3) Re-implement the group search using the new system, remove the old system -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #8 from Lari Taskula--- Created attachment 52380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52380=edit Bug 16699: Move Swagger-related files to api/v1/swagger This patch separates Swagger-specifications and the minifySwagger.pl from other api-files by moving specifications & minifier into api/v1/swagger. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #7 from Lari Taskula--- Created attachment 52379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52379=edit Bug 16699: Reference new x-primitives in currently defined objects Since we have defined some basic x-primitives in x-primitives.json, we can now start to reuse them in our currently defined objects. To test: 1. Apply patch 2. Run minifySwagger.pl 3. Validate your Swagger specifications 4. Observe that validation passes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #5 from Lari Taskula--- Created attachment 52377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52377=edit Bug 16699: Fix mixed-up indentation from 2-4 spaces to 2 spaces These definitions had indentation of 4 spaces, while rest of the specification uses 2 spaces. This patch simply maintains the consistency in indentations and provides no other modifications to code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #6 from Lari Taskula--- Created attachment 52378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52378=edit Bug 16699: Support multiple types in primitive definitions Currently it is not possible to define multiple types for primitive definitions in /definitions/*. If you try to use the following "firstname": { "type": ["string", "null"], "description": "patron's first name" } in definitions.json, online.swagger.io validator will not validate it: {"messages":["attribute definitions.firstname.type is not of type `string`"]} One way to get around this issue is to extend definitions with custom "x-primitives" object, where we will define all reusable primitive definitions. To test: 1. Add the "firstname" example above to definitions.json 2. Run minifySwagger.pl 3. Validate your specification 4. Observe that error with description mentioned above is given 5. Apply patch 6. Repeat step 2 and 3 7. Observe that validation passes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #4 from Lari Taskula--- Created attachment 52376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52376=edit Bug 16699: Add borrowernumberQueryParam for reusability The borrowernumber as a query parameter should be defined in parameters.json in order to allow its reusability. To test: 1. Apply patch 2. Run minifySwagger.pl 3. Validate swagger.min.json in online.swagger.io/validator/debug?url=url_to+ _your_swagger_min_json or your local swagger-api/validator-badge validator 4. Observe that validation passes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #3 from Lari Taskula--- Created attachment 52375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52375=edit Bug 16699: Split parameters and paths in Swagger Parameters and paths should be split in our Swagger specification, because otherwise swagger.json would become messy with all the paths and their further specification in the same file. Also parameters should be split for the same reason. Instead of using index.json for definitions, parameters and paths, we define new files "definitions.json", "parameters.json" and "paths.json" in order to simplify the references. If we kept using index.json and try to reference "/definitions/error.json" from "/paths/holds.json", reference would be "../definitions/index.json#/error" instead of now simplified version, "../definitions.json#/error". Here is the proposed structure: . ├── swagger.json ├── definitions.json ├── paths.json ├── parameters.json ├── definitions │ └── error.json │ └── patron.json ├── parameters │ └── patron.json ├── paths │ └── patrons.json ├── minifySwagger.pl └── swagger.min.js The swagger.json paths, definitions and parameters will look as follows: ... "paths": { "$ref": "paths.json" }, "definitions": { "$ref": "definitions.json" }, "parameters": { "$ref": "parameters.json" } ... A problem with splitting specification into multiple files directly from swagger.json (e.g. "paths": { "$ref": "paths.json" }) is that it is not following the Swagger specification and an error will be thrown by the Swagger-UI default validator (online.swagger.io/validator). To overcome this problem, we use the minifySwagger.pl script from Bug 16212. This allows the developers to work with the structure introduced in this patch thus allowing developers to split the specification nicely, and still have a valid Swagger specification in the minified swagger.min.json. To test: -2: Apply the minifier-patch in Bug 16212. -1: Make sure you can validate your specification with Swagger2 validator at online.swagger.io/validator/debug?url=url_to_swaggerjson, or install it locally from https://github.com/swagger-api/validator-badge. 1. Don't apply this patch yet, but first validate swagger.json with swagger.io-validator (or your local version, if you installed it) 2. Observe that validation errors are given 3. Run minifySwagger.pl 4. Validate swagger.min.json with the validator you used in step 1 5. Observe that validation passes and we overcame the invalid specification problem in swagger.min.json 6. Apply this patch 7. Run minifySwagger.pl 8. Repeat step 4 9. Observe that validation passes with new structure 10. Run REST tests at t/db_dependents/api/v1 (11. Study the new structure of our Swagger specifications :)) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734 Jonathan Druartchanged: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16720] DBIx ActionLogs.pm should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16720 --- Comment #3 from Tomás Cohen Arazi--- Just for the record, I confirmed this is the only schema file in this situation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |In Discussion --- Comment #70 from Jonathan Druart --- The discussion about the modal should be brought at the next dev meeting I think: Is everybody (i.e. the majority) agrees on this change, who is going to implement it to the other pages, etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #71 from Kyle M Hall--- (In reply to Owen Leonard from comment #69) > (In reply to Kyle M Hall from comment #63) > > > I agree. It is confusing to have two menu items on the administration > > > page, > > > "Libraries and groups" and "Library groups." I think we should think of a > > > way to manage all this functionality in one section. > > > > These two sub-systems are completely unrelated. > > Do you not plan to replace the existing library groups functionality with > this? I had not thought about it, but it would make a log of sense! That should definitely be a separate bug to limit scope creep, but I think it's an excellent idea. After that we could do away with the existing groups functionality altogether. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734 Jacek Ablewiczchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=12017 Assignee|gmcha...@gmail.com |a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Jacek Ablewiczchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16734 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 Jacek Ablewiczchanged: What|Removed |Added Depends on||16734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734 [Bug 16734] getLanguages() in opac-search.pl should be called only if needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734 Jacek Ablewiczchanged: What|Removed |Added Blocks||15262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 [Bug 15262] Run Koha Run. Koha search should be fast again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734 --- Comment #1 from Jacek Ablewicz--- Created attachment 52374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52374=edit Bug 16734: getLanguages() in opac-search.pl should be called only if needed There is no need to always call getLanguages() in opac/opac-search.pl (especially not if it's an actual search), it's output is used only in opac-advsearch.tt template. This patch moves it into 'if ( ... $template_type eq 'advsearch' )' block. Speed gain is rather moderate (40 - 80 msec, if the mysql server is no too busy, and the results are already in query cache), but it eliminates a lot of small DBI calls, making a further profiling of OPAC searches a bit easier. Test plan: just ensure that language selection is still available on OPAC advanced search page, and that it still works like intended. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734 Jacek Ablewiczchanged: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Owen Leonardchanged: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16734] New: getLanguages() in opac-search.pl should be called only if needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734 Bug ID: 16734 Summary: getLanguages() in opac-search.pl should be called only if needed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: a...@biblos.pk.edu.pl QA Contact: testo...@bugs.koha-community.org There is no need to always call getLanguages() in opac/opac-search.pl (especially not if it's an actual search), it's output is used only in opac-advsearch.tt template. This patch moves it into 'if ( ... $template_type eq 'advsearch' )' block. Speed gain is rather moderate (40 - 80 msec, if the mysql server is no too busy, and the results are already in query cache), but it eliminates a lot of small DBI calls, making a further profiling of OPAC searches a bit easier. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 --- Comment #9 from Owen Leonard--- Created attachment 52373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52373=edit Bug 16148 [Follow-up] Revised layout and behavior of marc modification template management This follow-up corrects a JavaScript error by using jQuery, which is is more forgiving when selecting elements which may not exist on the page. Also changed: Corrected a duplicate class attribute and fixed a jshint error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16733] Adjust or make flexible some paths in debian scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Marcel de Rooychanged: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/