[Koha-bugs] [Bug 16812] Remove multiple onclick events for all z3950_search.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #52872|0   |1
is obsolete||

--- Comment #4 from Héctor Eduardo Castro Avalos  ---
Created attachment 52873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52873=edit
Bug 16812: Remove multiple onclick events for all z3950_search.tt

z3950_auth_search.tt has various onclick events used in links.
Also fix: acqui/z3950_search.tt and cataloguing/z3950_search.tt

This patch propose to triger event via JQuery .on()
Also add Font Awesome Icons to "Select/Clear all" and "Clear search form"
links

To test:
1-Apply bug 16600 on top
2-Apply patch
3-Go to Authorities > click New from Z39.50
4-Fill some fields and click in "Clear search form" link
5-Search under "Dalton" or another author that launch too many headings
6-Clic in some heading and notice the dialog open, test to "Import" and close
 the dialog "X". Use the "Import" from table too.

Go to Cataloging > New from Z39.50/SRU
Repeat steps 3 to 6. But this time with bib records.

Go to Adquisition > Open or Create a basket and choose to "Add to basket"
button. A modal appear, chose the option "Order from external source"
Repeat steps 3 to 6. But this thime with bib records.

NOTE: The icon trash for "Clear search form" has been selected according
with module "Advanced search" there is an icon trash with link "Clear fields"
that has the same fuctionality.

Sponsored-by: Universidad de El Salvador

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16812] Remove multiple onclick events for all z3950_search.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #52871|0   |1
is obsolete||

--- Comment #3 from Héctor Eduardo Castro Avalos  ---
Created attachment 52872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52872=edit
Bug 16812: Remove multiple onclick events for all z3950_search.tt

z3950_auth_search.tt has various onclick events used in links.
Also fix: acqui/z3950_search.tt and cataloguing/z3950_search.tt

This patch propose to triger event via JQuery .on()
Also add Font Awesome Icons to "Select/Clear all" and "Clear search form"
links

To test:
1-Apply bug 1660 on top
2-Apply patch
3-Go to Authorities > click New from Z39.50
4-Fill some fields and click in "Clear search form" link
5-Search under "Dalton" or another author that launch too many headings
6-Clic in some heading and notice the dialog open, test to "Import" and close
 the dialog "X". Use the "Import" from table too.

Go to Cataloging > New from Z39.50/SRU
Repeat steps 3 to 6. But this time with bib records.

Go to Adquisition > Open or Create a basket and choose to "Add to basket"
button. A modal appear, chose the option "Order from external source"
Repeat steps 3 to 6. But this thime with bib records.

NOTE: The icon trash for "Clear search form" has been selected according
with module "Advanced search" there is an icon trash with link "Clear fields"
that has the same fuctionality.

Sponsored-by: Universidad de El Salvador

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16812] Remove multiple onclick events for all z3950_search.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

Summary|Remove multiple onclick |Remove multiple onclick
   |events from |events for all
   |z3950_auth_search.tt|z3950_search.tt
 CC||oleon...@myacpl.org,
   ||ve...@veron.ch
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16812] Remove multiple onclick events from z3950_auth_search.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #52868|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 52871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52871=edit
Bug 16812: Remove multiple onclick events for all z3950_search.tt

z3950_auth_search.tt has various onclick events used in links.
Also fix: acqui/z3950_search.tt and cataloguing/z3950_search.tt

This patch propose to triger event via JQuery .on()
Also add Font Awesome Icons to "Select/Clear all" and "Clear search form"
links

To test:
1-Apply patch
2-Go to Authorities > click New from Z39.50
3-Fill some fields and click in "Clear search form" link
4-Search under "Dalton" or another author that launch too many headings
5-Clic in some heading and notice the dialog open, test to "Import" and close
 the dialog "X". Use the "Import" from table too.

Go to Cataloging > New from Z39.50/SRU
Repeat steps 1 to 5. But this time with bib records.

Go to Adquisition > Open or Create a basket and choose to "Add to basket"
button. A modal appear, chose the option "Order from external source"
Repeat steps 1 to 5. But this thime with bib records.

NOTE: The icon trash for "Clear search form" has been selected according
with module "Advanced search" there is an icon trash with link "Clear fields"
that has the same fuctionality.

Sponsored-by: Universidad de El Salvador

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16812] Remove multiple onclick events from z3950_auth_search.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16746] Can not find duplicated authorities cataloguing a new one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746

M. Tompsett  changed:

   What|Removed |Added

  Attachment #52869|0   |1
is obsolete||

--- Comment #6 from M. Tompsett  ---
Created attachment 52870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52870=edit
Bug 16746: Proposed start of counter-patch

This is the beginning of a counter patch.
Feel free to apply it and test it, Juan Romay Sieira.
However, please expand the test plan to be more
detailed:

-- type X into field Y
-- click button Z
-- click downdrop W
-- select item V
-- enter 'text' into text box labelled A

"Add a new authority that exists in your
 authority server, Koha will now find none."
is not detailed enough for a person unfamiliar with the
interface.

Feel free to apply 16809 first. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16746] Can not find duplicated authorities cataloguing a new one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16746] Can not find duplicated authorities cataloguing a new one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746

--- Comment #5 from M. Tompsett  ---
Created attachment 52869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52869=edit
Bug 16746: Proposed start of counter-patch

This is the beginning of a counter patch.
Feel free to apply it and test it, Juan Romay Sieira.
However, please expand the test plan to be more
detailed:

-- type X into field Y
-- click button Z
-- click downdrop W
-- select item V
-- enter 'text' into text box labelled A

"Add a new authority that exists in your
 authority server, Koha will now find none."
is not detailed enough for a person unfamiliar with the
interface.

Feel free to apply 16809 first. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16812] Remove multiple onclick events from z3950_auth_search.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

Summary|Remove multiple onclick |Remove multiple onclick
   |event from  |events from
   |z3950_auth_search.tt|z3950_auth_search.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16812] Remove multiple onclick event from z3950_auth_search.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812

--- Comment #1 from Héctor Eduardo Castro Avalos  ---
Created attachment 52868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52868=edit
Bug 16812: Remove multiple onclick event from z3950_auth_search.tt

z3950_auth_search.tt has various onclick events used in links.

This patch propose to triger event via JQuery .on()
Also add Font Awesome Icons to "Select/Clear all" links

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16600] Remove some obsolete references to Greybox in some templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Blocks||16812


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812
[Bug 16812] Remove multiple onclick event from z3950_auth_search.tt
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16812] New: Remove multiple onclick event from z3950_auth_search.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812

Bug ID: 16812
   Summary: Remove multiple onclick event from
z3950_auth_search.tt
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: trivial
  Priority: P5 - low
 Component: Templates
  Assignee: hector.hecax...@gmail.com
  Reporter: hector.hecax...@gmail.com
QA Contact: testo...@bugs.koha-community.org
Depends on: 16600

z3950_auth_search.tt has various onclick events used in links.

This patch propose to triger event via JQuery .on()


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600
[Bug 16600] Remove some obsolete references to Greybox in some templates
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16811] New: Remove multiple onclick event from z3950_auth_search.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16811

Bug ID: 16811
   Summary: Remove multiple onclick event from
z3950_auth_search.tt
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: hector.hecax...@gmail.com
  Reporter: hector.hecax...@gmail.com
QA Contact: testo...@bugs.koha-community.org
Depends on: 16600

z3950_auth_search.tt has various onclick events used in links.

This patch propose to triger event via JQuery .on()


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600
[Bug 16600] Remove some obsolete references to Greybox in some templates
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16600] Remove some obsolete references to Greybox in some templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Blocks||16811


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16811
[Bug 16811] Remove multiple onclick event from z3950_auth_search.tt
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15023] Allow patron anonymize/bulk delete tool to be limited by branch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15023

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15023] Allow patron anonymize/bulk delete tool to be limited by branch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15023

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de,
   ||kyle.m.h...@gmail.com,
   ||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15023] Allow patron anonymize/bulk delete tool to be limited by branch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15023

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
   Assignee|kyle.m.h...@gmail.com   |tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16600] Remove some obsolete references to Greybox in some templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||hector.hecax...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16600] Remove some obsolete references to Greybox in some templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #51839|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 52867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52867=edit
[SIGNED-OFF]Bug 16600: Remove some obsolete references to Greybox in some
templates

This patch removes unused Greybox markup from two templates.

To test, apply the patch and go to Authorities.

- Perform an authority search which will return multiple results.
- Select two records to merge.
- On the "merging records" page, an earlier version used Greybox to show
  a preview of the selected authority records. Confirm that authority
  number link for the two records triggers a pop-up window instead.

- From the authorities home page, choose 'New from Z39.50'
- Perform a search which will return multiple results.
- Confirm that there is only a 'MARC' preview link. A
  forever-commented-out 'Card' link has been removed.

Signed-off-by: Hector Castro 
Works as advertised. Obsolete comment on 'Card' removed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14902] Add qualifier menu to staff side "Search the Catalog"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14902

--- Comment #10 from Nick Clemens  ---
Created attachment 52866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52866=edit
Bug 14902 (QA Followup)

Remove unnecessary [% USE Koha %]

Any remaining were tested and needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14902] Add qualifier menu to staff side "Search the Catalog"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14902

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16538] Improve the style of progress bars

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #3 from Héctor Eduardo Castro Avalos  ---
Hi Owen

Applying: Bug 16538 - Improve the style of progress bars
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/process_koc.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/css/staff-global.css
Failed to merge in the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/checking in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172

--- Comment #11 from Héctor Eduardo Castro Avalos  
---
(In reply to Liz Rea from comment #10)
> Is this duplicate in functionality to 14668?

This patch still applies.

QA should decide if close this bug as duplicated of bug 14668 or keep it open.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16810] Fines note not showing on checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #1 from Nick Clemens  ---
Appears to be a regression from bug 14497 - the entire block is inside this if:
[% IF NoIssuesCharge && fines > NoIssuesCharge %]

So you don't get the warning about having any fines unless you have fines over
the NoIssuesCharge

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16810] New: Fines note not showing on checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810

Bug ID: 16810
   Summary: Fines note not showing on checkout
 Change sponsored?: ---
   Product: Koha
   Version: 16.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Created attachment 52865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52865=edit
no fines warning

This screenshot from an earlier manual :
http://manual.koha-community.org/3.22/en/images/circ/patronnotes.png shows the
fines note to the right of the checkout box, but I don't see it anymore in
master.  

My patron owes over $10 but I'm not seeing the note.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16746] Can not find duplicated authorities cataloguing a new one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #4 from M. Tompsett  ---
I have something which does this problem, but there seems to be a larger issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16166] Improve L1 cache performance and safety

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52509|0   |1
is obsolete||
  Attachment #52510|0   |1
is obsolete||

--- Comment #27 from Kyle M Hall  ---
Created attachment 52863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52863=edit
Bug 16166: Improve L1 cache performance and safety

Bug 16044 introduced two-level caching mechanism to Koha::Cache. By
default, get_from_cache() returns a deep copy of the data structures
stored in L1 cache (aka "safe mode"). For extremely big and/or complex
data structures (like MARC framework hash-of-hashes-of-hashes returned
by GetMarcStructure() ), deep-cloning is currently sub-optimal;
this patch addresses that particular issue. It also provides an
ability to intermix "safe" and "unsafe" cache feches, in such
way that they don't interfere with each other (i.e., eliminating
the risk involved with "unsafe" calls possibly compromising
further "safe" calls).

Test plan:

1) apply patch
2) flush L2 cache if necessary (restart memcached daemon)
3) profile GetMarcStructure() calls before / after patch, e.g. by
running some script which calls it often (like catalogue search
w/ XSLT processing turned on, etc.) - GetMarcStructure() should be
faster than before, in all possible circumstances (eg. 18 msec
per call -> 10 msec p/call)
4) after testing, before returning to the master branch, flush L2 cache
again (restart memcached daemon) - otherwise all system preferences
returned from L2 cache would be suffixed with '-CF0'

Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16166] Improve L1 cache performance and safety

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166

--- Comment #28 from Kyle M Hall  ---
Created attachment 52864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52864=edit
Bug 16166: Fix t/Cache.t tests

Thou shalt not forget to include changes made in the t/Cache.t
in the patch set.

Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16166] Improve L1 cache performance and safety

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16271] Allow more filters on /api/v1/holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16213] Allow to select hold's itemtype when using API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16213

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Signed Off  |Failed QA

--- Comment #4 from Kyle M Hall  ---
prove t/db_dependent/api/v1/holds.t
t/db_dependent/api/v1/holds.t .. 1/39
#   Failed test '200 OK'
#   at t/db_dependent/api/v1/holds.t line 135.
#  got: '404'
# expected: '200'

#   Failed test '201 Created'
#   at t/db_dependent/api/v1/holds.t line 145.
#  got: '404'
# expected: '201'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16271] Allow more filters on /api/v1/holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #51320|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall  ---
Created attachment 52862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52862=edit
Bug 16271: Allow more filters on /api/v1/holds

borrowernumber parameter is no longer required and you can filter on
every column of reserves table

Some example requests
- GET /api/v1/holds
- GET /api/v1/holds?biblionumber=123
- GET /api/v1/holds?borrowernumber=456
- GET /api/v1/holds?priority=0=W

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16507] show play media tab first

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Signed Off  |Failed QA

--- Comment #6 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #5)
> It seems weird to me to change the order of the tabs depending on the
> existence of items. Would not it better to select the tab by default?

I agree with Jonathan, I don't think it's good for ui elements to jump around.
It's better for consistency if the tab remains where it always has been but is
now the selected tab when the page loads.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16677] Use abbr for authorities linked headings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16677

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52441|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 52861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52861=edit
Bug 16677 - Use abbr for authorities linked headings

In authorities search results, UNIMARC flavour, linked headings are displayed
with a link type : BT, NT, UF, RT.

This patch adds a abbr tag around those acronyms to know there meaning :
BT = Broader Term
NT = Narrower Term
UF = Used For
RT = Related Term

Acronyms are used because there can be a lot of linked headings, using abbr
will display the complete text on mouse over.

Test plan :

- Use UNIMARC database
- Create an authority with :
250 $a Heading250a
450 $a Heading450a
550 $5 a $a Heading550a
550 $5 g $a Heading550g
550 $5 h $a Heading550h
- Save an index zebraqueue
- Go to intranet authorities search
- Search for "Heading250a"
- You see :
Heading250a
Heading250a
UF: Heading450a
RT: Heading550a ; BT: Heading550g ; NT: Heading550h
- Move your mouse over the acronyms, you see a tip with the complete text
- Same with opac authorities search

Signed-off-by: Frédéric Demians 
  Works as described. Translatable.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16677] Use abbr for authorities linked headings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16677

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||k...@bywatersolutions.com

--- Comment #18 from Kyle M Hall  ---
Just a couple very minor things. If those get fixed this should Pass QA!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #17 from Kyle M Hall  ---
Comment on attachment 51303
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51303
Bug 13895: Add API routes for checkouts retrieval and renewal

Review of attachment 51303:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=13895=51303)
-

::: Koha/REST/V1/Checkout.pm
@@ +71,5 @@
> +my $checkout = Koha::Issues->find($checkout_id);
> +
> +if (!$checkout) {
> +return $c->$cb({
> +error => "Checkout doesn't exists"

Should be "Checkout doesn't exist"

@@ +76,5 @@
> +}, 404);
> +}
> +
> +$checkout = $checkout->unblessed;
> +my ($borrowernumber, $itemnumber) = @$checkout{qw(borrowernumber 
> itemnumber)};

This seems slower than
my $borrowernumber = $checkout->borrowernumber;
my $itemnumber = $checkout->itemnumber;

am I wrong?

::: api/v1/definitions/checkout.json
@@ +29,5 @@
> +"lastreneweddate": {
> +"description": "Date the item was last renewed"
> +},
> +"return": {
> +"description": "?"

Looks to be unused. Maybe we should file a bug report to remove it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16086] Add Koha::Issue objects.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16086

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #8 from Kyle M Hall  ---
Shouldn't this have been named Koha::Checkouts according to our terminology
page?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16566] 'Print slip' button formatting inconsistent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16566] 'Print slip' button formatting inconsistent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52694|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall  ---
Created attachment 52860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52860=edit
Bug 16566 [Revised] 'Print slip' button formatting inconsistent

This patch modifies the style of some "print slip" links on the checkin
page to make them consistent with other buttons shown in dialogs.

This patch also removes the use of "onclick" in some places in favor of
defining events in the JavaScript.

To test apply the patch and go to Circulation -> Check in.

- Check in an item which belongs at another branch. You should see a
  dialog which asks the user to transfer the item. Confirm that the
  "Print slip" button looks correct and works correctly.

- Check in the same item again. You should see a different dialog which
  has both a "Print transfer slip" and "Cancel transfer" button. The
  "Print transfer slip" button should look correct and work correctly.

- Check in an item which is part of a rotating collection. (Or, if Bug
  16570 is still open, check in any item) You should see a dialog which
  notifies you that the item is part of a rotating collection. The
  "Print slip" button in this dialog should look correct and work
  correctly.

Followed test plan. Buttons appear as expected.
Signed-off-by: Marc Véron 

Revision following QA: Removed redundant class attribute from the print
button tested in step 1.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16640] Move actions on acquisitions receipt summary page into menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16640

Owen Leonard  changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion

--- Comment #5 from Owen Leonard  ---
I think based on Jonathan's comment 3 that this needs some more opinions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16640] Move actions on acquisitions receipt summary page into menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16640

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52399|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 52859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52859=edit
Bug 16640 - Move actions on acquisitions receipt summary page into menu

This patch moves two groups of links into two menus: MARC and Card
preview into one, Receive, transfer, cancel, etc. into another.

Also changed: The transfer order pop-up window has been sized down to be
more consistent with other similar pop-ups. Baskets and basket
group links now include the whole name rather than just the number to
make it easier to click.

To test you must have a basket or baskets with multiple titles on order,
both received and pending.

- Apply the patch and go to Acquisitions -> Vendor -> Receive shipment
  -> Receive a new shipment (or open an existing invoice).
- In the list of pending orders:
  - Test the 'View' menu for multiple titles. The 'MARC' and 'Card' menu
items should work correctly.
  - Test the 'Actions' menu for the following actions:
- Receive
- Transfer
- Cancel order
- Cancel order and delete catalog record
  - Confirm that under some circumstances the 'Cancel order' and 'Cancel
order and delete catalog record' items are disabled. In these cases
hovering over the menu items should trigger a tooltip. An
explanation should be displayed in red at the bottom of the menu.
Clicking the menu item should trigger an alert with the explanation.

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16640] Move actions on acquisitions receipt summary page into menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16640

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16730] Use member-display-address-style*-includes in moremember-brief.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16730

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52412|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 52858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52858=edit
Bug 16730 - Use member-display-address-style*-includes in moremember-brief.tt

To test:
- Apply patch
- Create a new patron with the same first and last name as an existing
  patron. This should trigger a duplicate warning message. Click the
  "View existing record" link to trigger a pop-up window with a patron
  detail brief view.
- Verify that the address information displays the same way as on the
  patron details screen (moremember.pl).
- Change syspref 'AddressFormat' and verify that the address displays
  as appropriate.

Signed-off-by: Frédéric Demians 
  Works as described: AddressFormat is taken into account on 'view exiting
  record' dialog box.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16730] Use member-display-address-style*-includes in moremember-brief.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16730

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||16764


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764
[Bug 16764] Update printers administration page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16764] Update printers administration page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Depends on||8352

--- Comment #4 from Kyle M Hall  ---
Bug 8352 revamps the printer administration as well.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352
[Bug 8352] Add automatic printing of 'hold to pull' notices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16801] Include Font Awesome Incons to check/unchek all in Administration > Library transfer limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16801

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52702|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 52857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52857=edit
Bug 16801 - Include Font Awesome Incons to check/unchek all in Administration >
Library transfer limits

For purpose to uniformity and leave just one entry in .po files,
this patch change: Check all/Uncheck all -> to -> Select all/Clear all.
Also added Font Awesome icons.

To test:
-Go to Administration > Library transfer limits
-Notice about Check all/Uncheck all for "For all items types" and
 "Policy for:"
-Apply patch and refresh the screen
-Notice about the new Select all/Clear all links with their icons
-Confirm that all links work as expected

Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

--- Comment #7 from Héctor Eduardo Castro Avalos  ---
Created attachment 52856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52856=edit
Bug 16794: (follow up) Change scope header to col only

Fix copy and paste according with QA comment 6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16801] Include Font Awesome Incons to check/unchek all in Administration > Library transfer limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16801

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16778] Use Bootstrap modal for card printing on patron lists page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16778

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52613|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall  ---
Created attachment 52855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52855=edit
Bug 16778: Replace usage of Greybox modals with Bootstrap modals

This patch is a proof-of-concept for replacing Greybox modals in
situations where in-modal page transitions happen. This one addresses
patron card export from the patron lists page.

To test you must have at least one patron lists containing patrons.

- Apply the patch and go to Patrons -> Patron lists.
- In the 'Actions' menu associated with your list, choose 'Print patron
  cards.' A modal window should be triggered.
- In the modal window, change settings as necessary and click the
  "Export" button.
- The modal should reload and display a link to download a PDF. Confirm
  that the PDF download works correctly and that the correct patron
  batch was processed.
- Repeat the process and confirm at each step that clicking the 'X'
  button or the 'Cancel' link dismisses the modal window.

To confirm that changes to the patron card print template has not
adversely affected printing patron cards from the patron card creator
page:

- Go to Tools -> Patron card creator.
- Choose Manage -> Card batches.
- Click 'Export' for any batch.
- Confirm that the Greybox modal still works correctly for patron card
  export.

Signed-off-by: Hector Castro 
Works as advertised

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16778] Use Bootstrap modal for card printing on patron lists page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16778

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13807] SIPServer Input loop not checking for closed connections reliably

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807

--- Comment #5 from Kyle M Hall  ---
Passing QA provisionally, we should deal with the interaction with bug 13807
before anything is pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #35 from Kyle M Hall  ---
Marcell, would you be able to rebase these patches on top of bug 13807?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||13807


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807
[Bug 13807] SIPServer Input loop not checking for closed connections reliably
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13807] SIPServer Input loop not checking for closed connections reliably

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||15006


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006
[Bug 15006] Need to distinguish client timeout from login timeout
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13807] SIPServer Input loop not checking for closed connections reliably

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13807] SIPServer Input loop not checking for closed connections reliably

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807

--- Comment #4 from Kyle M Hall  ---
Created attachment 52854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52854=edit
Bug 13807 Rework main input loop in SIPServer

Debugging various problems in SIPServer and control of it, found it
could loop on unread buffers (e.g. the LF of a CRLF if it was only
expecting CR) making it unresponsive to signals.
Reworked the input loop with an eye to removing unnecessary whiles
and replacing the while(1) by a while( connection valid)
Enhanced the timeout code by wapping in an eval.
Moved the logic from SIP_read_packet into the server itself
Hopefully this makes the already baroque code easier to navigate
and it did seem the server was the logical place for this
Removed no longer iused SIP_read_packet from Sip.pm

Signed-off-by: Srdjan 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13807] SIPServer Input loop not checking for closed connections reliably

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #3 from Kyle M Hall  ---
Colin, how does this patch work with bug 15006? At the moment they seem to have
merge conflicts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #34 from Kyle M Hall  ---
I like this proposal, but I think we should get Colin's testing and input
before setting it to Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #33 from Kyle M Hall  ---
Created attachment 52853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52853=edit
Bug 15006: [COUNTERPATCH] Timeout logic in sip_protocol_loop

Instead of adding yet another client timeout, I propose to use the
policy timeout that we also communicate in send_acs_status.
Although I agree that we perhaps better move it from institution to
account/login level, this c/should be done on another report. We
may have issues with existing configurations.

In order to find a compromise between bug 13432 and the originally
proposed 15006 patch, this patch allows you to put a zero in the
policy timeout entry in the SIPconfig.

The timeout logic is moved to a Sip.pm subroutine. Will add a test :)

Test plan:
[1] Check timeout after login with policy/timeout > 0.
[2] Check timeout after login with policy/timeout = 0. (No timeout!)
[3] Check timeout after login with no policy timeout. Fallback to service.
[4] Check timeout after login with no policy and service timeout.
Should fallback to 30 seconds for both login process and after login.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52477|0   |1
is obsolete||
  Attachment #52478|0   |1
is obsolete||
  Attachment #52786|0   |1
is obsolete||
  Attachment #52787|0   |1
is obsolete||

--- Comment #29 from Kyle M Hall  ---
Created attachment 52849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52849=edit
Bug 15006: [QA Follow-up] Indentation for two subroutines

Remove tabs from telnet_transport and sip_protocol_loop. Correct
indentation.

Test plan:
Compare files before and after without whitespace (diff -b).
Notice only two split lines.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #32 from Kyle M Hall  ---
Created attachment 52852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52852=edit
Bug 15006: [COUNTERPATCH] Add timeout and strikes to raw_transport

The code in raw_transport includes setting a $SIG{ALRM}, but did not
use it. For consistency, we add an alarm statement here.

Similarly, we add the "three strikes" to raw_transport just as
telnet_transport does. Note that raw_transport still responds to other
requests, but will exit if there is no valid login within three
attempts. (If we want more restrictions, add them later?)

Test plan:
[1] Start sip session with telnet on raw port 6001.
Wait until it times out (probably the default 60 seconds).
[2] Change SIPconfig.xml: set timeout=5 for service port 6001.
Restart SIP and start another telnet 6001 session.
Did it timeout within 5 seconds?
[3] Start another 6001 session. Give three wrong requests or false
login attempts. Does the connection close?

Signed-off-by: Marcel de Rooy 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52849|0   |1
is obsolete||

--- Comment #30 from Kyle M Hall  ---
Created attachment 52850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52850=edit
Bug 15006: [QA Follow-up] Indentation for two subroutines

Remove tabs from telnet_transport and sip_protocol_loop. Correct
indentation.

Test plan:
Compare files before and after without whitespace (diff -b).
Notice only two split lines.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #31 from Kyle M Hall  ---
Created attachment 52851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52851=edit
Bug 15006 Sip separate global from login timeouts

Timeout logic has been added to the main sip loop
However the timeout parameter was initially for the login process which
requires a short duration applying such a brief timeout to
the main sip loop causes instability in many selfcheck units

Most selfchecks have persistent connections and send a
periodic status request at intervals (approx every 5mins appears
the norm) The timeout was dropping connections by default every 30secs
which for the client appears as a very flakey network

This patch adds a separate parameter client_timeout that can be
used if you do want to force a disconnect if the client sends
no requests for a period. By not defining it you can switch off
the timeout in the main loop, I recommend this unless you
have a good reason not too. If you do want this behaviour you can
at least now set it to a more realistic value (see sample config
file)

Removed the commented out html entry in the config file, this was
dead code born of a misconception and was just a source
of confusion for users

Signed-off-by: Frederic Demians 
Signed-off-by: Jonathan Druart 
Signed-off-by: Marcel de Rooy 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14642] Add logging of hold modifications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52825|0   |1
is obsolete||

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 52848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52848=edit
Bug 14642: Add logging for Holds

This patch adds logging for several holds actions. Specifically for:

- CREATE
- CANCEL
- SUSPEND
- RESUME

To test:
- Enable the HoldsLog syspref
- Add a hold on a record/item
=> SUCCESS: The log view shows the CREATE action
- Click on the  button
=> SUCCESS: The log view shows the SUSPEND action
- Click on the  button
=> SUCCESS: The log view shows the RESUME action
- Click on the red cross, to delete the hold
=> SUCCESS: The log view shows the CANCEL action

Note: This is WIP, as there are several other actions missing from the logs.

Sponsored-by: NEKLS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16805] Log in with database admin user breaks OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16805

--- Comment #8 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #4)
> I'd not recommend to give such info on the public interface (You never know
> what might happen with students).
> Of course Koha is open source and we could trace back the error message,
> but... just in case :)

Valid point, but who is going to hand out their database admin account to
students?! This is more likely to be administrators (like me) being unwise and
logging in with the database admin account. This, however, will be a huge
security issue if some administrator somewhere has done this or will do this.
So, I could understand QA wanting to revert the opac file changes in the third
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16805] Log in with database admin user breaks OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16805

M. Tompsett  changed:

   What|Removed |Added

  Attachment #52764|0   |1
is obsolete||

--- Comment #7 from M. Tompsett  ---
Created attachment 52847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52847=edit
Bug 16805: Log in with database admin user breaks OPAC

TEST PLAN
-
1) Apply Jonathan's test patch
2) prove t/db_dependent/Letters.t
   -- dies before finishing tests
3) Apply second test patch
4) prove t/db_dependent/Letters.t
   -- says 'getalert'
   -- fails on one test, but keeps going.
5) Log into OPAC with database admin user.
   -- see error given in comment #0
6) Apply this patch
7) prove t/db_dependent/Letters.t
   -- says 'getalert'
   -- all tests pass.
8) Log into OPAC with database admin user.
   -- logs in, but gives warning with a nice logout button.
9) run koha qa test tools.

Signed-off-by: Hector Castro 
No kaha qa errors
In debian display diferent error:
Can't use an undefined value as an ARRAY reference at /usr/lib/perl5/DBI.pm
line 2054.
Works as advertised

NOTE: Revised test plan, as Jonathan added useful test case.
  Works as I've tested above.
  Hector tested older test plan which was steps
  5,6,8 and 9.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16805] Log in with database admin user breaks OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16805

--- Comment #6 from M. Tompsett  ---
Created attachment 52846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52846=edit
Bug 16805: Tweak new test message to say getalert

It said 'addalert', which is likely a cut-paste typo.
Plus, let's keep running the other tests if that one
goes bad.

TEST PLAN
-
1) Apply Jonathan's test patch
2) prove t/db_dependent/Letters.t
   -- dies before finishing tests
3) Apply this test patch
4) prove t/db_dependent/Letters.t
   -- says 'getalert'
   -- fails on one test, but keeps going.
5) run koha qa test tools.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16805] Log in with database admin user breaks OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16805

M. Tompsett  changed:

   What|Removed |Added

  Attachment #52827|0   |1
is obsolete||

--- Comment #5 from M. Tompsett  ---
Created attachment 52845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52845=edit
Bug 16805: Add test to getalert (no param passed)

TEST PLAN
-
1) apply patch
2) prove t/db_dependent/Letters.t
   -- fails
3) run koha qa test tools

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14642] Add logging of hold modifications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|kyle.m.h...@gmail.com   |tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

--- Comment #6 from Owen Leonard  ---
Comment on attachment 52703
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52703
Bug 16794: Revise layout for Admistration > Patron categories

Review of attachment 52703:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=16794=52703)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt
@@ +318,4 @@
>  [% END %]
>  Branches limitations
>  Default privacy
> + colspan="1" rowspan="1" class="sorting_disabled">Actions

This looks like a copy and paste from DataTables-generated markup. I don't
think we need anything more than 'Actions' in the
template.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c
   |y.org   |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14902] Add qualifier menu to staff side "Search the Catalog"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14902

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #9 from Jonathan Druart  
---
Nick,
Why do you add [% USE Koha %] in some templates?
The Koha TT plugin is loaded in doc-head-open.inc and should then be everywhere
else.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #71 from Tomás Cohen Arazi  ---
Patches rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52756|0   |1
is obsolete||

--- Comment #69 from Tomás Cohen Arazi  ---
Created attachment 52843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52843=edit
Bug 14048: (QA followup) Fix typo on syspref value

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52757|0   |1
is obsolete||

--- Comment #70 from Tomás Cohen Arazi  ---
Created attachment 52844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52844=edit
Bug 14048: (followup) Use the original holding branch

This patch picks the item's holding branch *before* it gets fixed
by using the checkin library instead. This way the RefundLostOnReturnControl
syspref set to ItemHoldingBranch is respected (otherwise, as Nick explained
this behaves just like if CheckinLibrary was set)

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52753|0   |1
is obsolete||

--- Comment #66 from Tomás Cohen Arazi  ---
Created attachment 52840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52840=edit
Bug 14048: Add syspref and atomic update

This patch introduces the changes to the sysprefs and the atomic update
that creates the new table.

It picks the syspref value for RefundLostItemFeeOnReturn and uses it to
create a default (branchcode='*') rule on the new table.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52755|0   |1
is obsolete||

--- Comment #68 from Tomás Cohen Arazi  ---
Created attachment 52842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52842=edit
Bug 14048: (QA followup) Update syspref name for HEA

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52754|0   |1
is obsolete||

--- Comment #67 from Tomás Cohen Arazi  ---
Created attachment 52841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52841=edit
Bug 14048 [QA Followup] - Delete only the removed system preference

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52752|0   |1
is obsolete||

--- Comment #65 from Tomás Cohen Arazi  ---
Created attachment 52839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52839=edit
Bug 14048: [QA Followup]

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52750|0   |1
is obsolete||

--- Comment #63 from Tomás Cohen Arazi  ---
Created attachment 52837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52837=edit
Bug 14048: Add a refund rules setting form in smart-rules

This patch introduces the CRUD UI for managing the refund lost item fee
rules on the general 'Circulation and fines rules' page.

Verify that rules can be added and changed.

Rules are correctly associated to the chosen branch (or the
general default rule).

To test:
- Apply the patch
- Open smart-rules.pl
=> SUCCESS: The text and refund rules section correctly refers to default
global rules.
   The policy can be set to Yes and No, and works as expected.
- Pick a specific branch
=> SUCCESS: The rule refers to the specific branch
=> SUCCESS: It detects the default rule is picked
=> SUCCESS: On changing the rules values are correctly retrieved if entering
   again to the page.
=> SUCCESS: The 'Use default' text is suffixed with the correct value set by
the user
   in the 'All libraries' scenario.
=> Sign off :-D

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52751|0   |1
is obsolete||

--- Comment #64 from Tomás Cohen Arazi  ---
Created attachment 52838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52838=edit
Bug 14048: Hook new rules into C4::Circulation

This patch makes AddIssue and AddReturn use the new implementation

The behaviour should respect the specification.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52749|0   |1
is obsolete||

--- Comment #62 from Tomás Cohen Arazi  ---
Created attachment 52836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52836=edit
Bug 14048: Unit tests

This patch introduces unit tests for the feature.
To test:
- Have all patches from this bug applied
- Run:
  $ prove -v t/db_dependent/RefundLostItemFeeRule.t
=> SUCCESS: All tests pass!

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52748|0   |1
is obsolete||

--- Comment #61 from Tomás Cohen Arazi  ---
Created attachment 52835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52835=edit
Bug 14048: Add RefundLostItemFeeRule table and classes

This patch introduces new classes for handling refund lost item fee
rules. It introduces a new table for storing this rules.

It is designed so it is possible to define a global rule, and then
branch-specific ones. The specific is prefered if available.

This behaviour is fully tested by unit tests introduced by the following
patches.

This cannot be tested on its own.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16807] Frameworks unordered in dropdown when adding/editing a biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52808|0   |1
is obsolete||
  Attachment #52828|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall  ---
Created attachment 52833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52833=edit
Bug 16807: Frameworks unordered in dropdown when adding/editing a biblio

To test:
Start to add or edit a biblio
Open the dropdown to change framework
Notice the order
Refresh the page - notice the order changes
Apply patch
Order is alphabetical
Refresh the page
Order does not change

Signed-off-by: Hector Castro 
Works as described

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16807] Frameworks unordered in dropdown when adding/editing a biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807

--- Comment #7 from Kyle M Hall  ---
Created attachment 52834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52834=edit
Bug 16807 - Use Koha::BiblioFrameworks instead of GetFrameWorkLoop

Refactor code to use work from 14889

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16807] Frameworks unordered in dropdown when adding/editing a biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16746] Can not find duplicated authorities cataloguing a new one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16809

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16809] Silence authority warnings C4::Biblio::TransformHtmlToMarc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16746

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16809] Silence authority warnings C4::Biblio::TransformHtmlToMarc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809

--- Comment #1 from M. Tompsett  ---
Created attachment 52832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52832=edit
Bug 16809: Silence authority warnings C4::Biblio::TransformHtmlToMarc

Most of the floodiness is caused by accessing the cgi parameters
in a context which is hard to determine. By purposefully saving
the value to a scalar variable and using the variable, the issue
disappears, and it will likely be a tiny tad faster as variable
access is faster than multiple function calls.

TEST PLAN
-
 1) Back up your intranet error log
-- for example:
   cp ~/koha-dev/var/log/koha-error-log ~/koha-error-log.backup
 2) Blank your intranet error log
-- for example:
   echo > ~/koha-dev/var/log/koha-error-log
 3) Log into your staff client
 4) Click 'Authorities'
 5) Click 'New from Z39.50'
 5) Type 'Seuss' into 'Name (any):' and press enter
 6) Click 'Import' beside the first link
 7) Click 'Save'
 8) Check your koha-error-log
-- floody!
 9) Apply patch
10) repeat steps 2-8
-- blank!
11) restore your intranet error log
   -- for example:
  mv ~/koha-error-log.backup ~/koha-dev/var/log/koha-error-log
12) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16809] Silence authority warnings C4::Biblio::TransformHtmlToMarc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

--- Comment #15 from Kyle M Hall  ---
Created attachment 52830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52830=edit
Bug 10760: Alternate Address: Display street number and street type

This patch displays alternate streetnumber and street type on patron's
detail page.

To test:
- Apply patch
- Verify that the alternate address information displays follwing the
  setting in syspref AddressFormat and contains street type and
  street number (as appropriate)

Signed-off-by: Owen Leonard 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

--- Comment #16 from Kyle M Hall  ---
Created attachment 52831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52831=edit
Bug 10760: (followup) Move street type after address

As of comment #7

Signed-off-by: Owen Leonard 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52598|0   |1
is obsolete||
  Attachment #52599|0   |1
is obsolete||
  Attachment #52600|0   |1
is obsolete||

--- Comment #14 from Kyle M Hall  ---
Created attachment 52829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52829=edit
Bug 10760: Alternate Address: Make street number and street type editable

Table 'borrowers' contain columns B_streetnumber and B_streettype.
This patch makes them editable for alternate address.

To test:
- Apply patch
- Edit a patron's details
- Verify that in edit mode for Alternate address, the fields 'street type' and
'street number' appear
  and follow the settings in sysprefs AddressFormat, BorrowerMandatoryField,
BorrowerUnwantedField
- Verify that the values are saved correctly.

Note: A second patch will follow to manage the display of street number and
street type
Signed-off-by: Owen Leonard 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16809] New: Silence authority warnings C4::Biblio::TransformHtmlToMarc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809

Bug ID: 16809
   Summary: Silence authority warnings
C4::Biblio::TransformHtmlToMarc
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: mtomp...@hotmail.com
  Reporter: mtomp...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

While trying to test another bug. I was annoyed by the floody nature of
TransformHtmlToMarc in C4/Biblio.pm

To reproduce:
 1) Back up your intranet error log
-- for example:
   cp ~/koha-dev/var/log/koha-error-log ~/koha-error-log.backup
 2) Blank your intranet error log
-- for example:
   echo > ~/koha-dev/var/log/koha-error-log
 3) Log into your staff client
 4) Click 'Authorities'
 5) Click 'New from Z39.50'
 5) Type 'Seuss' into 'Name (any):' and press enter
 6) Click 'Import' beside the first link
 7) Click 'Save'
 8) Check your koha-error-log
-- floody!
 9) Apply patch
10) repeat steps 2-8
-- blank!
11) restore your intranet error log
   -- for example:
  mv ~/koha-error-log.backup ~/koha-dev/var/log/koha-error-log
12) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16805] Log in with database admin user breaks OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16805

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
I'd not recommend to give such info on the public interface (You never know
what might happen with students).
Of course Koha is open source and we could trace back the error message, but...
just in case :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/