[Koha-bugs] [Bug 16812] Remove multiple onclick events for all z3950_search.tt

2016-06-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16780] Specify due date always sets time as AM when using 12 hour time format

2016-06-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16780] Specify due date always sets time as AM when using 12 hour time format

2016-06-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780

Claire Gravely  changed:

   What|Removed |Added

  Attachment #52781|0   |1
is obsolete||

--- Comment #6 from Claire Gravely  ---
Created attachment 52884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52884=edit
Bug 16780 - Specify due date always sets time as AM when using 12 hour time
format

This regression is occurs because the time format for the checkout
date/time widget is only meant to be given in 24 hour format. The time
due should not be converted to 12 hr time even if the library has 12
hour set as their preferred time format.

Test Plan:
1) Performat a backdated checkout with a date due that has a PM time
2) Note the date/time picker on the confirmition screen shows the time
   in AM/PM
2) Note the time is not stored correctly
3) Apply this patch
4) Repeate step 1
5) Note the confirmation date/time picker now show the time in 24hr
   format
6) Note the time was stored correctly

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16716] Invalid SQL GROUP BY clauses in GetborCatFromCatType and GetAuthorisedValues

2016-06-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16716

--- Comment #5 from Jonathan Druart  
---
(In reply to Srdjan Jankovic from comment #4)
> Ok, I can either drop that one now or wait for 15407 to be merged. The thing
> is anyone installing on a newer version of MySql may find this a quick fix.
> What about the authorised values?

I think you are right. It should be pushed before bug 15407 or at least a
version for 16.05 will have to be provided.
The AV change looks good to me.
Waiting for QAing it!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16559] [%% ... %%] should not be picked for translation

2016-06-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16559

--- Comment #3 from Jonathan Druart  
---
No idea, did you try it?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14628] Anonymization of circulation data prevents lost item refunds

2016-06-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14628

Jonathan Druart  changed:

   What|Removed |Added

   Severity|critical|normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2016-06-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #124 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #123)
> What you are doing is just initializing them, so you can do that in the
> constructor (new).

Florent, let me know if you need more info about how to do it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2016-06-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #123 from Jonathan Druart  
---
(In reply to Florent Mara from comment #122)
> I agree with most of it - also I can't reproduce the failed tests - but I
> can fail other tests so some of these need to be reconsidered. 
> $headerrow_0 shouldn't be there. Namespace uniformity sounds like an
> excellent idea, any suggestion/guidance? 

Actually it was added by bug 14722 which is already pushed.
I have added the topic to the next dev meeting, just in case
(https://wiki.koha-community.org/wiki/Development_IRC_meeting_13_July_2016).
I have already talked about this to someone, but I don't find anything.

> The part that confuses me is around Moo usage and I assume the comment
> refers to Koha::Patrons::Import. The module has 2 attributes ('today_iso'
> and 'text_csv'), can these exist without importing Moo?

Yes of course.
What you are doing is just initializing them, so you can do that in the
constructor (new).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #76 from Jonathan Druart  
---
(In reply to Tomás Cohen Arazi from comment #73)
> (In reply to Jonathan Druart from comment #72)
> > I have squashed the patches for the review, so I won't use the splinter:
> > 
> > 1/ my $item_holding_branch = $item->{ holdingbranch };
> > => would be good to have a comment here to explain the last patch.
> 
> I thought the commit message would be enough. Do u require a comment on the
> code?

Would be good, but not required. Forget it

> > 2/ Koha::Config::SysPrefs->find should not be used, C4::Context->preference
> > should continue to be used everywhere, to take advantage of the syspref
> > cache.
> 
> Ok, followup coming.

I added one also to fix the tests.

> > 3/ $schema->resultset('RefundLostItemFeeRule')->search()->delete;
> > should use Koha::RefundLostItemFeeRules
> 
> This is done on the tests, instead of the usual DELETE FROM ... The problem
> with Koha::RefundLostItemFeeRules is that it explicitly forbis deleting the
> default rule. I'd leave it as it is.

Correct, and I was wondering if it would not be easier to assume that default
is 1 if no rule exist.
It will permit to remove the sql file in the mysql/mandatory dir (and then no
need to manage it from the installer) and no need to overwrite delete. Why do
you think?

> > 4/ Tests only cover RefundLostOnReturnControl = 'CheckinLibrary'
> 
> This is incorrect:
> 
> subtest 'Koha::RefundLostItemFeeRules::_choose_branch() tests'
> => Tries the three possible values
> 
> subtest 'Koha::RefundLostItemFeeRules::should_refund() tests'
> => Tries the three possible values

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #75 from Jonathan Druart  
---
Created attachment 52883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52883=edit
Bug 14048: Use mock_preference in tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16805] Log in with database admin user breaks OPAC

2016-06-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16805

--- Comment #15 from Jonathan Druart  
---
Created attachment 52882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52882=edit
Bug 16805: Log in with database admin user breaks OPAC

TEST PLAN
-
1) Apply Jonathan's test patch
2) prove t/db_dependent/Letters.t
   -- dies before finishing tests
3) Apply second test patch
4) prove t/db_dependent/Letters.t
   -- dies before finishing tests
   -- 'addalert' is changed to 'getalert'
5) Log into OPAC with database admin user.
   -- see error given in comment #0
6) Apply this patch
7) prove t/db_dependent/Letters.t
   -- says 'getalert'
   -- all tests pass.
8) Log into OPAC with database admin user.
   -- logs in, but gives warning with a nice logout button.
9) run koha qa test tools.

Signed-off-by: Hector Castro 
No kaha qa errors
In debian display diferent error:
Can't use an undefined value as an ARRAY reference at /usr/lib/perl5/DBI.pm
line 2054.
Works as advertised

NOTE: Revised test plan, as Jonathan added useful test case.
  Works as I've tested above.
  Hector tested older test plan which was steps
  5,6,8 and 9.

  Revised test plan again while tweaking to address comment #9.

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16805] Log in with database admin user breaks OPAC

2016-06-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16805

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16805] Log in with database admin user breaks OPAC

2016-06-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16805

--- Comment #14 from Jonathan Druart  
---
Created attachment 52881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52881=edit
Bug 16805: Tweak new test message to say getalert

It said 'addalert', which is likely a cut-paste typo.
Plus, let's keep running the other tests if that one
goes bad.

TEST PLAN
-
1) Apply Jonathan's test patch
2) prove t/db_dependent/Letters.t
   -- dies before finishing tests
3) Apply this test patch
4) prove t/db_dependent/Letters.t
   -- still dies before finished tests,
  'addalert' now is 'getalert' in message.
5) run koha qa test tools.

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16805] Log in with database admin user breaks OPAC

2016-06-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16805

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52877|0   |1
is obsolete||
  Attachment #52878|0   |1
is obsolete||
  Attachment #52879|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  
---
Created attachment 52880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52880=edit
Bug 16805: Add test to getalert (no param passed)

TEST PLAN
-
1) apply patch
2) prove t/db_dependent/Letters.t
   -- fails
3) run koha qa test tools

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/