date:20160713

[Koha-bugs] [Bug 16488] UNIMARC to MARC21 xslt to be used in z39.50 import sources

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16488

--- Comment #10 from Theodoros Theodoropoulos  ---
Andy, you obviously search BNF.

I've added some debugging and for title 'vatican', BNF returns for example this
tag in the RAW (UNIMARC) data:


<88>Die <89>vaticanische Handschrift der Chronik des
Mathias von Neuenburg, von Ludwig Weiland. Vorgelegt in der Sitzung der k.
Gesellschaft der Wissenschaften am 28 Mai. 1892
Texte imprimé


This produces the following error during the transformation:
parser error : StartTag: invalid element name
<88>Die <89>vaticanische Handschrift der Chronik des
Math
^
Which means that it's probably an issue with the encoding of the data returned
by BNF through yaz.
Unfortunately I couldn't use the BNF TOUT-UTF8 database (that returns utf8
encoded records) because it timed out.

I've tested the xsl with several Greek UNIMARC databases that return utf8
records and it works. If you know any other useful UNIMARC database (ideally
with utf8 support), I could give them a try.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16921] New: Authority Linking doesn't match to proper record

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16921

Bug ID: 16921
   Summary: Authority Linking doesn't match to proper record
 Change sponsored?: ---
   Product: Koha
   Version: 16.05
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: MARC Authority data support
  Assignee: gmcha...@gmail.com
  Reporter: vano...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 53394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53394=edit
New Linker Module: BestMatch

We've had some trouble here linking our records to their proper authority
records. The zebra search seems to be giving back results that match only on
the first word. 
Copied from an email to the devel list:
-
...I'm in the process of trying to relink all of our biblios to the right
authority files. Somehow, they were an /incredible/ mess. I've created the
authority records okay, but when trying to run link_bibs_to_authorities.pl, it
links them to the wrong places.

Investigating, it seems like zebra isn't giving the right search results back.

I can confirm this in yaz-client using the query that is created by koha.
Searching for "Bentley, Peter, Ed." returns 4 results, only two of which are
close. Actually, the record I'm trying to match is "Bentley, Peter, (Ed.)" -
the last option.

Interestingly enough, if I search for "Bentley,
3432531531532513985735981" it will also show me 
the same four results.So does searching for "Bentley 513513531513515151".But
searching for "Bentleyr435435151551251" shows no results, as I would expect.

-

Not sure what's going on here - but in desperation, I wrote a new Linker
Module. It's called the "BestMatch" linker. Basically, it gets all the
authorities back from the search, and then searches through them all to find
the one that matches perfectly. If there is no perfect match, it tries to find
a match that differs only in whitespace/punctuation.

The only problem - it is understandably very SLOW

It's possible that I've completely missed the point here. But the BestMatch
linker seems to be doing the job for us.

Note: To do a successful match, the authority data was exported from
bibliographic records using koha-auth, then imported into the authorities
table, and then the link_bibs_to_authorities.pl script run with the BestMatch
linker selected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

--- Comment #4 from M. Tompsett  ---
Please provide a sample patron CSV that triggers issue.
I attempted with checkprevcheckout deleted, and then set to 'null'.
I tried both new and overwrite.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

--- Comment #3 from M. Tompsett  ---
Tracing down failures:
t/db_dependent/Circulation.t
t/db_dependent/DecreaseLoanHighHolds.t
t/db_dependent/Reserves.t
These all fail on master too, so I'll fall back to the provided test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

--- Comment #20 from Nicholas van Oudtshoorn  ---
Pinging anyone interested in looking at gettting this signed off! :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16920] sysprefs.sql - missing comma for MaxOpenSuggestions

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16920

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16920] sysprefs.sql - missing comma for MaxOpenSuggestions

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16920

Nick Clemens  changed:

   What|Removed |Added

  Attachment #53392|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 53393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53393=edit
Bug 16920: sysprefs.sql - missing comma for MaxOpenSuggestions

TEST PLAN
-
1) back up DB
2) drop database koha_library;
3) create database koha_library;
4) run web browser install, choose ALL defaults
   -- notice the SQL syntax warning.
5) apply patch
6) repeat steps 2-4
   -- notice SQL syntax warning is gone.
7) run koha qa test tools
8) restore db

Signed-off-by: Chris Cormack 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16920] sysprefs.sql - missing comma for MaxOpenSuggestions

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16920

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16920] sysprefs.sql - missing comma for MaxOpenSuggestions

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16920

Chris Cormack  changed:

   What|Removed |Added

  Attachment #53391|0   |1
is obsolete||

--- Comment #2 from Chris Cormack  ---
Created attachment 53392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53392=edit
Bug 16920: sysprefs.sql - missing comma for MaxOpenSuggestions

TEST PLAN
-
1) back up DB
2) drop database koha_library;
3) create database koha_library;
4) run web browser install, choose ALL defaults
   -- notice the SQL syntax warning.
5) apply patch
6) repeat steps 2-4
   -- notice SQL syntax warning is gone.
7) run koha qa test tools
8) restore db

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16920] sysprefs.sql - missing comma for MaxOpenSuggestions

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16920

--- Comment #1 from M. Tompsett  ---
Created attachment 53391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53391=edit
Bug 16920: sysprefs.sql - missing comma for MaxOpenSuggestions

TEST PLAN
-
1) back up DB
2) drop database koha_library;
3) create database koha_library;
4) run web browser install, choose ALL defaults
   -- notice the SQL syntax warning.
5) apply patch
6) repeat steps 2-4
   -- notice SQL syntax warning is gone.
7) run koha qa test tools
8) restore db

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16920] sysprefs.sql - missing comma for MaxOpenSuggestions

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16920

M. Tompsett  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16920

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16920] sysprefs.sql - missing comma for MaxOpenSuggestions

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16920

M. Tompsett  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |mtomp...@hotmail.com
   |ity.org |
 Status|NEW |ASSIGNED
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15128

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16920] New: sysprefs.sql - missing comma for MaxOpenSuggestions

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16920

Bug ID: 16920
   Summary: sysprefs.sql - missing comma for MaxOpenSuggestions
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mtomp...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Bug 15128 accidentally missed a comma on MaxOpenSuggestions.

diff --git a/installer/data/mysql/sysprefs.sql
b/installer/data/mysql/sysprefs.sql
index 29ef9c8..c9a7c7e 100644
--- a/installer/data/mysql/sysprefs.sql
+++ b/installer/data/mysql/sysprefs.sql
@@ -236,6 +236,7 @@ INSERT INTO systempreferences ( `variable`, `value`,
`options`, `explanation`, `
 ('MaxItemsToDisplayForBatchDel','1000',NULL,'Display up to a given number of
items in a single item deletionbatch.','Integer'),
 ('MaxItemsToProcessForBatchMod','1000',NULL,'Process up to a given number of
items in a single item modification batch.','Integer'),
 ('maxItemsInSearchResults','20',NULL,'Specify the maximum number of items to
display for each result on a page of results','free'),
+('MaxOpenSuggestions','',NULL,'Limit the number of open suggestions a patron
can have at once','Integer')
 ('maxoutstanding','5','','maximum amount withstanding to be able make
holds','Integer'),
 ('maxRecordsForFacets','20',NULL,NULL,'Integer'),
 ('maxreserves','50','','Define maximum number of holds a patron can
place','Integer'),

This just adds it in.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #2 from M. Tompsett  ---
I added a line:
 die "TRIGGER!" if !$new_member->{checkprevcheckout};
into C4::Members just above the change, and then ran prove t/db_dependent.

TRIGGERED: t/db_dependent/Budgets.t
TRIGGERED: t/db_dependent/Circulation.t
  RELATED: t/db_dependent/DecreaseLoanHighHolds.t
TRIGGERED: t/db_dependent/Holds.t
TRIGGERED: t/db_dependent/Letters.t
TRIGGERED: t/db_dependent/Members.t
TRIGGERED: t/db_dependent/Ratings.t
TRIGGERED: t/db_dependent/Reserves.t
TRIGGERED: t/db_dependent/Serials_2.t
TRIGGERED: t/db_dependent/Suggestions.t

So, now to remove that line of code and run these tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848

--- Comment #7 from Srdjan Jankovic  ---
I think so, unless Jonathan fiercely objects, in which case I'll remove the
line that I've added.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16744] new records not indexed if using a customize Koha Framework

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16744

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Severity|enhancement |critical

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16744] new records not indexed if using a customize Koha Framework

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16744

--- Comment #5 from Tomás Cohen Arazi  ---
(In reply to Hugo Agud from comment #3)
> Good morning
> 
> Further investigation shows thats behaivour is produced only when we
> apply'USE_INDEXER_DAEMON="yes"' 
> 
> No problem adding new records using the old rebuild procedure of
> /etc/cron.d/koha-common

Both use the same script (rebuild_zebra.pl) it is just that INDEXER_DAEMON=yes
makes it run in daemonized way. That's hwy I think it might be related to
caching.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15268] Patron search differs between 'Check out' search and 'Patron' search on two-word surnames like 'St. Claire'

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15268

Edie Discher  changed:

   What|Removed |Added

 CC||edisc...@cityoffargo.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor search template

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450

Edie Discher  changed:

   What|Removed |Added

 CC||edisc...@cityoffargo.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945

Edie Discher  changed:

   What|Removed |Added

 CC||edisc...@cityoffargo.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715

Edie Discher  changed:

   What|Removed |Added

 CC||edisc...@cityoffargo.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180

Edie Discher  changed:

   What|Removed |Added

 CC||edisc...@cityoffargo.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don' t block bulk hold action on search results if some items can' t be placed on hold

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #33 from Katrin Fischer  ---
In my testing it allowed me ot place a hold on an a record without items... can
you please take a look?

I marked 2 records, one with items and one without. 
I used the 'place hold' button on top of the result list.
Both records showed the same in the screen - both holds were placed.
One record has no items... and a hold now (obviously :) ).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16576] Remove the use of "onclick" from label templates

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16576

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16576] Remove the use of "onclick" from label templates

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16576

Owen Leonard  changed:

   What|Removed |Added

  Attachment #51901|0   |1
is obsolete||

--- Comment #4 from Owen Leonard  ---
Created attachment 53390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53390=edit
Bug 16576 [Revised] Remove the use of "onclick" from label templates

This patch updates several label creator templates to remove the use of
"onclick" in favor of defining click events in JavaScript.

Also changed:
 - Replaced the non-existant element  with 
 - Removed the use of  and 'align="center"';
 - In the item search results template:
   - The use of the checkboxes jQuery plugin has been replaced with
 straight jQuery for simplicity's sake.
   - Output of table headers has been modified so that translatable
 strings are in the template instead of having English strings
 passed from the script.
   - Moved the 'Add checked' and 'Done' buttons into a floating toolbar.

To test, apply the patch and go to Tools -> Label creator.

- Choose New -> Label batch
  - Click 'Add items'
- Perform a search for items.
- Confirm that 'select all' and 'clear all' links work.
- Confirm that clicking an individual 'Add' button works.
- Select multiple items and click the 'Add checked' button. Confirm
  that the selected items were added to your batch.
  - Click 'Add items' again to save the selected items to your batch.
  - Test that the 'Delete' and 'Export' buttons next to any item work
correctly.
- Choose Manage -> Label batches
  - Test that the 'Delete' button works correctly.
  - Select one or more batches and test that the 'Export selected'
button works correctly.

Revision: Removed changes to pagination in the item search results
template since it didn't work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
Jonathan, Srdjan, is this ready for QA?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16687] Translatability: Fix issues in Administration preferences

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16687

--- Comment #11 from Marc Véron  ---
(In reply to Katrin Fischer from comment #10)
> This seems like a step back to how the old system preference editor worked -
> having the choice separate from the sentence and at the end of each. The
> translation of the system preference file was designed to keep the strings
> in sequence, so you can 'see' the sentence strings together - but it doesn't
> allow to change the sequence of sentence parts.
> 
> I am not sure if this will work better in all possible scenarios and it will
> require translators to retranslate the whole file - and even more files if
> we decide to use this pattern for the other preferences as well. 
> 
> I'd like to get another translator's view on this.

Note: The problem with the sequence of the sentence parts is described in Bug
16669 - Options in pref.po should be expressed in %s to allow translatability:$

From bug description:
misc/translator/po/*-pref.po lacks translatability because the position of
options are fixed.

For example, admin.pref#casAuthentication consists of three entries.
# CAS for login authentication.
# Don't use
# Use
It is used to construct the following sentence with a drop-down list.
 "[Don't use/Use] CAS for login authentication."
The Japanese translation of this would look like the following.
"CASをログイン認証に使用[しない/する]"
However, it is impossible to use this translation because the position of the
drop-down list is fixed.
This could be solved by expressing options as %s and allow the translator to
modify the position. The following is an example.
# %s CAS for login authentication.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16344] Add a circ rule to limit the auto renewals given a specific date

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Owen Leonard  changed:

   What|Removed |Added

Version|unspecified |master
 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16687] Translatability: Fix issues in Administration preferences

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16687

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16687] Translatability: Fix issues in Administration preferences

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16687

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #10 from Katrin Fischer  ---
This seems like a step back to how the old system preference editor worked -
having the choice separate from the sentence and at the end of each. The
translation of the system preference file was designed to keep the strings in
sequence, so you can 'see' the sentence strings together - but it doesn't allow
to change the sequence of sentence parts.

I am not sure if this will work better in all possible scenarios and it will
require translators to retranslate the whole file - and even more files if we
decide to use this pattern for the other preferences as well. 

I'd like to get another translator's view on this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16538] Improve the style of progress bars

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538

Owen Leonard  changed:

   What|Removed |Added

  Attachment #51583|0   |1
is obsolete||

--- Comment #5 from Owen Leonard  ---
Created attachment 53389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53389=edit
Bug 16538 - Improve the style of progress bars

This patch updates the style of progress bars to make them a little
nicer. Progress bars in the staff client are not built in a consisten
way. Some have been updated to use the  element and some have
not. This patch improves some styling common to both kinds.

Other changes:

- Redundant in-page CSS has been removed from many pages.
- An invalid "min" attribute has been removed from several instances of
  .
- Corrected capitalization.
- Fixed incorrectly quoted attributes.
- Added missing form "action" attributes.

To test, clear your browser cache if necessary. Apply the patch and
test uploads on the following pages:

- Circulation -> Offline circulation file upload
- Tools -> Batch item modification
- Tools -> Batch record modification
- Tools -> Stage MARC records for import
- Tools -> Manage staged MARC records
- Tools -> Upload local cover image
- Tools -> Upload

In all cases, progress bars should look improved and work correctly.

Test Tools -> Batch item deletion. Unused background job handling markup
has been removed. Deletion processing should work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16538] Improve the style of progress bars

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16913] C4::Members::GetBorrowersNamesAndLatest is not used

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16913

Marc Véron  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16913] C4::Members::GetBorrowersNamesAndLatest is not used

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16913

Marc Véron  changed:

   What|Removed |Added

  Attachment #53344|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 53388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53388=edit
Bug 16913: Koha::Patrons - Remove GetBorrowersNamesAndLatestIssue

This subroutine has been added by
  commit 5904681faca77c87ff8071414d66e123a2d3baa9
  Date:   Wed Mar 19 10:11:12 2008 -0500
CleanBorrowers fixing.
but has never been used.
It can be removed safely.

Test plan:
  git grep GetBorrowersNamesAndLatestIssue
should not return any results.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16744] new records not indexed if using a customize Koha Framework

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16744

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Tomás Cohen Arazi  ---
Adding Jonathan, as this looks like a caching problem with the frameworks, as
the indexer daemon is a long-living process.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16919] New: Problems with cart

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16919

Bug ID: 16919
   Summary: Problems with cart
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The cart deletion does not seem to always delete the cart. Users have reported
that after adding items to a cart, clearing the cart (from the results screen)
and then adding an item from the results all previous items reappear.

I have recreated this, but not with steps I can recreate.  Basically if you add
and remove items enough from cart you start to see oddities. Try various
combintations of adding/removing and going forward/backward in browser and new
results.

I also noted in testing I ended up with two cookies, one pointing to the base
URL and one pointing to baseurl/cgi-bin/opac-main.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16918] opacmain.pl is not running under plack

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16918

Barton Chittenden  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |jwea...@bywatersolutions.co
   ||m
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16918] New: opacmain.pl is not running under plack

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16918

Bug ID: 16918
   Summary: opacmain.pl is not running under plack
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The default redirect rules that launch pages under plack do not cover
opacmain.pl.

This is bad, because system preferences don't update on opacmain.pl unless
memcache is restarted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs)

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #15 from Owen Leonard  ---
Tested successfully in a gitified package installation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs)

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733

Owen Leonard  changed:

   What|Removed |Added

  Attachment #52465|0   |1
is obsolete||

--- Comment #12 from Owen Leonard  ---
Created attachment 53385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53385=edit
[SIGNED-OFF] Bug 16733: Adjust koha-indexer

[1] Add a call to the new adjust_paths_dev_install
[2] Differentiate location of rebuild_zebra.pl

NOTE: The scripts assume koha-functions.sh to be in /usr/share/koha/bin.
Finding a better location for this shell library may be hard.

Test plan:
Run koha-indexer for a regular package install or a dev install.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||k...@bywatersolutions.com

--- Comment #46 from Kyle M Hall  ---
perl -c reports/issues_stats.pl
Global symbol "@patron_categories" requires explicit package name at
reports/issues_stats.pl line 155.
Global symbol "@patron_categories" requires explicit package name at
reports/issues_stats.pl line 326.
Global symbol "@patron_categories" requires explicit package name at
reports/issues_stats.pl line 400.
Bareword "GetBorrowercategoryList" not allowed while "strict subs" in use at
reports/issues_stats.pl line 79

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs)

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733

Owen Leonard  changed:

   What|Removed |Added

  Attachment #52466|0   |1
is obsolete||

--- Comment #13 from Owen Leonard  ---
Created attachment 53386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53386=edit
[SIGNED-OFF] Bug 16733: Adjust koha-rebuild-zebra

[1] Add a call to the new adjust_paths_dev_install
[2] Differentiate location of rebuild_zebra.pl
[3] Replace a hardcoded path by $PERL5LIB

Test plan:
Adjust a biblio record in package or dev install.
Run koha-rebuild-zebra -b -z for same instance.
Verify that the change has been indexed.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs)

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733

Owen Leonard  changed:

   What|Removed |Added

  Attachment #52560|0   |1
is obsolete||

--- Comment #14 from Owen Leonard  ---
Created attachment 53387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53387=edit
[SIGNED-OFF] Bug 16733: Adjust other debian scripts using PERL5LIB

This patch makes the following changes:

koha-foreach, koha-upgrade-schema (shell scripts):
[1] Read default file
[2] Include helper functions
[3] Add call to adjust_paths_dev_install
[4] Replace hardcoded path by $PERL5LIB

koha-shell (perl script):
[1] Remove hardcoded lib path
[2] Add a sub that reads PERL5LIB from default or koha-conf, just as the
shell scripts do.

koha-plack (shell script), plack.psgi:
[1] Add call to adjust_paths_dev_install
[2] Remove hardcoded lib path
[3] Add installer path to PERL5LIB, remove it from plack.pgsi

koha-sitemap (shell script):
[1] Add call to adjust_paths_dev_install
[2] Remove hardcoded lib path
[3] Add installer path to PERL5LIB
[4] Adjust path for call to sitemap cron job

koha-start-sip (shell script):
[1] Read default file
[2] Include helper functions
[3] Add call to adjust_paths_dev_install
[4] Adjust path to C4/SIP

koha-stop-sip (shell script):
[1] Remove KOHA_CONF and PERL5LIB (not needed to stop the daemon)
[2] Same for paths in daemon client options

NOTE: Script debian/scripts/koha-upgrade-to-3.4 has been left out
intentionally.

Test plan:
[1] Regular install:
Run koha-foreach echo Hi
Run koha-upgrade-schema yourinstance
Run koha-shell yourinstance
If you have plack, run koha-plack --start|--stop yourinstance
Run koha-sitemap --generate yourinstance
Run koha-start-sip yourinstance
Run koha-stop-sip yourinstance

[2] Dev install [yourinstance] with  in koha-conf.xml:
Run koha-upgrade-schema yourinstance
Run koha-shell yourinstance
If you have plack: koha-plack --start|--stop yourinstance
Run koha-sitemap --generate yourinstance
Run koha-start-sip yourinstance
Run koha-stop-sip yourinstance

[3] Git grep on koha/lib
You should no longer see occurrences in debian/scripts except:
koha-translate: see report 16749
koha-upgrade-to-3.4: left out intentionally

[4] Git grep on koha/bin
You should only see hits for lines with koha-functions in the
debian scripts except:
koha-upgrade-to-3.4: left out intentionally

Signed-off-by: Marcel de Rooy 
Most scripts tested on Wheezy (although it would not matter much).
Plack script tested on Jessie.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs)

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733

Owen Leonard  changed:

   What|Removed |Added

  Attachment #52464|0   |1
is obsolete||

--- Comment #11 from Owen Leonard  ---
Created attachment 53384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53384=edit
[SIGNED-OFF] Bug 16733: Add adjust_paths_dev_install to koha-functions.sh

This new function checks koha-conf.xml for a given instance and if it
contains a dev_install line, it adjusts PERL5LIB and KOHA_HOME
accordingly. Otherwise it does not touch the values of these
variables as normally read from /etc/default/koha-common.

The function will be used in various debian scripts to allow for more
flexibility with dev installs. And at the same time aiming to make better
use of PERL5LIB and KOHA_HOME.

Test plan:
[1] Add /not/there to your koha-conf.xml.
[2] Run on the command line:
PERL5LIB=test
source [path-to-your-instance]/debian/scripts/koha-functions.sh
echo $PERL5LIB
adjust_paths_dev_install [name-of-your-instance]
echo $PERL5LIB
The last echo should be: /not/there
[3] Remove the  line and repeat step 2.
The last echo should be: test

Signed-off-by: Marcel de Rooy 
Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for xnciptoolkit drivers

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652

Lari Taskula  changed:

   What|Removed |Added

 CC||la...@student.uef.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13927] Add API route to check hold capabilities

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13927

Lari Taskula  changed:

   What|Removed |Added

 CC||la...@student.uef.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Lari Taskula  changed:

   What|Removed |Added

 CC||la...@student.uef.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

--- Comment #25 from Nick Clemens  ---
(In reply to Marcel de Rooy from comment #24)
> (In reply to Nick Clemens from comment #23)
> > I would second the use of Flipster since it has a few different config
> > options available (coverflow, carousel, flat)
> 
> To second here does mean first, not second choice? :)

Poor choice of English vocabulary in a global community :-)

Yes, I support flipster as first choice

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16889] Move the ::columns subroutines to Koha::Objects->columns

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889

--- Comment #16 from Kyle M Hall  ---
Created attachment 53381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53381=edit
Bug 16889: Remove C4::Members::columns and use Koha::Patrons->columns instead

Test plan:
Import some patrons (tools/import_borrowers.pl) and make sure it imports
the patrons correctly.

Signed-off-by: Mark Tompsett 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16889] Move the ::columns subroutines to Koha::Objects->columns

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889

--- Comment #18 from Kyle M Hall  ---
Created attachment 53383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53383=edit
Bug 16889: Remove C4::Items::biblioitems_columns and use
Koha::Biblioitems->columns instead

Test plan:
Add new rule to the "Automatic item modifications by age" tools
(tools/automatic_item_modification_by_age.pl) and make sure the columns
of the biblioitems table are correctly displayed in the 'Conditions'
dropdown list.

Signed-off-by: Mark Tompsett 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16889] Move the ::columns subroutines to Koha::Objects->columns

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889

--- Comment #17 from Kyle M Hall  ---
Created attachment 53382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53382=edit
Bug 16889: Remove C4::Items::columns and use Koha::Items->columns instead

Test plan:
Add new rule to the "Automatic item modifications by age" tools
(tools/automatic_item_modification_by_age.pl) and make sure the columns
of the items table are correctly displayed.

Signed-off-by: Mark Tompsett 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16889] Move the ::columns subroutines to Koha::Objects->columns

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #53293|0   |1
is obsolete||
  Attachment #53294|0   |1
is obsolete||
  Attachment #53295|0   |1
is obsolete||
  Attachment #53379|0   |1
is obsolete||

--- Comment #15 from Kyle M Hall  ---
Created attachment 53380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53380=edit
Bug 16889: Add Koha::Objects->columns

Currently we have 3 subroutines to retrieve the columns of tables:
C4::Members::columns, C4::Items::columns and
C4::Items::biblioitems_columns.
It is easier to have a Koha::Objects->columns method to provide the
different classes to retrieve their related column names.

Signed-off-by: Mark Tompsett 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16889] Move the ::columns subroutines to Koha::Objects->columns

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #53292|0   |1
is obsolete||

--- Comment #14 from Kyle M Hall  ---
Created attachment 53379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53379=edit
Bug 16889: Add Koha::Objects->columns

Currently we have 3 subroutines to retrieve the columns of tables:
C4::Members::columns, C4::Items::columns and
C4::Items::biblioitems_columns.
It is easier to have a Koha::Objects->columns method to provide the
different classes to retrieve their related column names.

Signed-off-by: Mark Tompsett 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16889] Move the ::columns subroutines to Koha::Objects->columns

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||16889


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889
[Bug 16889] Move the ::columns subroutines to Koha::Objects->columns
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16889] Move the ::columns subroutines to Koha::Objects->columns

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||16917
 CC||k...@bywatersolutions.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917
[Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be
null
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

--- Comment #1 from Kyle M Hall  ---
Created attachment 53378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53378=edit
Bug 16917 - Error when importing patrons, Column 'checkprevcheckout' cannot be
null

Error:
DBIx::Class::Storage::DBI::_dbh_execute(): Column 'checkprevcheckout'
cannot be null at C4/Members.pm line 697

Test Plan:
1) Attempt to import a patron via csv
2) Note the error
3) Apply this patch
4) Repeat the import
5) No error!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Kyle M Hall  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Kyle M Hall  changed:

   What|Removed |Added

   Severity|enhancement |blocker

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||6906


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906
[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||16917


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917
[Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be
null
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] New: Error when importing patrons, Column 'checkprevcheckout' cannot be null

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Bug ID: 16917
   Summary: Error when importing patrons, Column
'checkprevcheckout' cannot be null
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Error:
DBIx::Class::Storage::DBI::_dbh_execute(): Column 'checkprevcheckout' cannot be
null at C4/Members.pm line 697

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527

--- Comment #30 from Fridolin SOMERS  ---
(In reply to Pedro Ferreira from comment #10)
> using the search data in the screenshot i performed the same search with yaz
> client.
> 
> so i did 
> 
>  YAZ-CLIENT>f @attr 1=32 @attr 4=5 @attr 2=4 2015-07-05
> 
> Sent searchRequest.
> Received SearchResponse.
> Search was a bloomin' failure.
> Number of hits: 0, setno 7
> Result Set Status: none
> records returned: 0
> Diagnostic message(s) from database:
> [114] Unsupported Use attribute -- v2 addinfo '32'
> Elapsed: 0.000181
> 
> 
> Here i can see the 114 error, but i dont know what is @attr 1=32

Attribute number 32 is defined in bib1.att = Date-of-acquisition.

By default 099$c is indexed as Date-of-acquisition.
Is it ?

Note that if you have no existing 099$c, the search query will fail, not juste
say 0 results.

Test : 
yaz> f @attr 1=32 @attr 2=103 ''

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16897] Re-focus on "Add item" in Lists

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16897

--- Comment #5 from Fridolin SOMERS  ---
(In reply to Katrin Fischer from comment #4)
> I just had a library report this as a bug - love it!

Thanks ! I also love my work, its always perfect ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16655] Date due error with SIP2 checkouts and holidays

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16655

Owen Leonard  changed:

   What|Removed |Added

   Severity|critical|major
Summary|ERROR ON HOLIDAYS   |Date due error with SIP2
   ||checkouts and holidays

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15759] Allow Koha::Object derived objects to be used as hashrefs

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15759] Allow Koha::Object derived objects to be used as hashrefs

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759

Kyle M Hall  changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15759] Allow Koha::Object derived objects to be used as hashrefs

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759

Kyle M Hall  changed:

   What|Removed |Added

 Resolution|WONTFIX |---
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16488] UNIMARC to MARC21 xslt to be used in z39.50 import sources

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16488

--- Comment #9 from Andy Boze  ---
I've tried installing the XSLT file. When I perform a Z39.50 search, I get a
bunch of errors "Warning: XSLT error on search result 1" etc, followed by the
search results without a transformation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16488] UNIMARC to MARC21 xslt to be used in z39.50 import sources

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16488

--- Comment #8 from Theodoros Theodoropoulos  ---
This updated xml version has better handling of Unimarc-100 (MARC21-008) field,
and supports the translation of far more UNIMARC fields.

Almost all of the new code was based on the (almost 15-year-old!) conversion
guidelines by LOC, so some fields/subfields might now be deprecated.
Even worse, important new fields might be missing from the translation.
(856 field was such an example, so by reading more recent docs, I think I
translated it properly).

How to test:
- Copy the file to koha-tmpl/intranet-tmpl/prog/en/xslt/
- Put "UNIMARC2MARC21.xsl" in "XSLT File(s) for transforming results:"
textfield of a UNIMARC Z39.50 source that you wish to translate to MARC21 
- Perform a test in the Z39.50 source. 
- Results /should/ be displayed properly in the Z39.50 result list.
- If the original Z39.50 source has non-utf (ie. Latin) encoding, you may even
try to import the records in Koha. 


Warnings:
- The work is nowhere near complete, but it's better (and more complete) that
what was currently available online.
- My knowledge of UNIMARC is very-very limited.
- The xsl was not thoroughly tested and the time I had to spend on it was
limited. Expect to find errors


Known issues:
Although the xsl /seems/ to work fine for me, there are certain encoding issues
when using it to IMPORT utf8 UNIMARC records to Koha. Displaying of UTF8
records in the Koha Z39.50 result list is OK, but importing them to cataloging
is not.
It's possible that it's an issue of Koha code and not related to this xsl. (I
will open a BZ case soon).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16079] Retrieving system preferences from database via DBIx is not fast enough

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16079

--- Comment #16 from Marcel de Rooy  ---
DBIx::Class 0.08196 vs 0.082810
WHEEZY WITHOUT 16079
Mysql
master-koha@WRKM006:/usr/share/koha/masterclone$ time
misc/tests/_dbix_test_search_performance_all_sysprefs.pl
Got 552 sysprefs
real0m1.966s
user0m1.844s
sys 0m0.072s
Hash ref inflator
master-koha@WRKM006:/usr/share/koha/masterclone$ time
misc/tests/_dbix_test_search_performance_all_sysprefs.pl
Got 552 sysprefs
real0m16.663s
user0m16.433s
sys 0m0.136s
Unblessed
master-koha@WRKM006:/usr/share/koha/masterclone$ time
misc/tests/_dbix_test_search_performance_all_sysprefs.pl
Got 552 sysprefs
real0m20.411s
user0m20.229s
sys 0m0.092s

=== WHEEZY WITH 16079
Mysql
master-koha@WRKM006:/usr/share/koha/masterclone$ time
misc/tests/_dbix_test_search_performance_all_sysprefs.pl
Got 552 sysprefs
real0m1.986s
user0m1.856s
sys 0m0.080s
Hashref inflator
master-koha@WRKM006:/usr/share/koha/masterclone$ time
misc/tests/_dbix_test_search_performance_all_sysprefs.pl
Got 552 sysprefs
real0m14.909s
user0m14.725s
sys 0m0.104s
Unblessed
master-koha@WRKM006:/usr/share/koha/masterclone$ time
misc/tests/_dbix_test_search_performance_all_sysprefs.pl
Got 552 sysprefs
real0m21.267s
user0m21.053s
sys 0m0.124s

=== JESSIE WITHOUT 16079
Mysql
upgrade-koha@UPGRADE:/usr/share/koha/upgradeclone$ time
misc/tests/_dbix_test_search_performance_all_sysprefs.pl
Got 509 sysprefs
real0m2.092s
user0m1.976s
sys 0m0.072s
Hashref inflator
upgrade-koha@UPGRADE:/usr/share/koha/upgradeclone$ time
misc/tests/_dbix_test_search_performance_all_sysprefs.pl
Got 509 sysprefs
real0m2.991s
user0m2.884s
sys 0m0.072s
Unblessed
upgrade-koha@UPGRADE:/usr/share/koha/upgradeclone$ time
misc/tests/_dbix_test_search_performance_all_sysprefs.pl
Got 509 sysprefs
real0m6.603s
user0m6.460s
sys 0m0.112s
JESSIE WITH 16079
Mysql
upgrade-koha@UPGRADE:/usr/share/koha/upgradeclone$ time
misc/tests/_dbix_test_search_performance_all_sysprefs.pl
Got 509 sysprefs
real0m2.032s
user0m1.892s
sys 0m0.100s
Inflator
upgrade-koha@UPGRADE:/usr/share/koha/upgradeclone$ time
misc/tests/_dbix_test_search_performance_all_sysprefs.pl
Got 509 sysprefs
real0m2.944s
user0m2.868s
sys 0m0.044s
Unblessed
upgrade-koha@UPGRADE:/usr/share/koha/upgradeclone$ time
misc/tests/_dbix_test_search_performance_all_sysprefs.pl
Got 509 sysprefs
real0m6.494s
user0m6.392s
sys 0m0.060s

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16488] UNIMARC to MARC21 xslt to be used in z39.50 import sources

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16488

Theodoros Theodoropoulos  changed:

   What|Removed |Added

  Attachment #53372|0   |1
is obsolete||

--- Comment #7 from Theodoros Theodoropoulos  ---
Created attachment 53377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53377=edit
XSL for Unimarc -> MARC21 (partial) translation

(minor update)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16916] New: OAI - Local covers as OAI-DC relations tags

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16916

Bug ID: 16916
   Summary: OAI - Local covers as OAI-DC relations tags
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: vfernan...@keep.pt
QA Contact: testo...@bugs.koha-community.org

Local covers are not in MARCXML record, so they can't be included in OAI-DC
record.
Local covers should be mapped to relation tags in OAI-DC record.

This can be done also for Google Books covers.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16289] Abbreviated formatting for numbering patterns

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289

--- Comment #12 from Katrin Fischer  ---
There is a problem witht he way seasonal translations are generated - it only
applies to that I think - months, days etc. should probably be ok. If you take
a look at the templates, you might see what I mean.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16870] Koha::Issue(s) should be named Koha::Checkout(s)

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870

--- Comment #8 from Kyle M Hall  ---
Created attachment 53376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53376=edit
Bug 16870 - Update Koha::Patron use of the class

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Patron/Borrower_PrevCheckout.t
3) prove t/db_dependent/Koha/Checkouts.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16870] Koha::Issue(s) should be named Koha::Checkout(s)

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #53373|0   |1
is obsolete||
  Attachment #53374|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall  ---
Created attachment 53375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53375=edit
Bug 16870 - Move and rename class files and unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16870] Koha::Issue(s) should be named Koha::Checkout(s)

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870

--- Comment #6 from Kyle M Hall  ---
Created attachment 53374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53374=edit
Bug 16870 - Update Koha::Patron use of the class

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Patron/Borrower_PrevCheckout.t
3) prove t/db_dependent/Koha/Checkouts.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16870] Koha::Issue(s) should be named Koha::Checkout(s)

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #53188|0   |1
is obsolete||
  Attachment #53189|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall  ---
Created attachment 53373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53373=edit
Bug 16870 - Move and rename class files and unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16488] UNIMARC to MARC21 xslt to be used in z39.50 import sources

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16488

Theodoros Theodoropoulos  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |th...@lib.auth.gr

--- Comment #6 from Theodoros Theodoropoulos  ---
Created attachment 53372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53372=edit
XSL for Unimarc -> MARC21 (partial) translation

This file supports the translation of far more tags from Unimarc->MARC21 than
what was currently available on the net, but is still not complete.
(btw, seeing the complexity of the conversion rules I doubt if it will ever be
100% translation xsl)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] Add API routes for getting item availability and holdability

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #53276|0   |1
is obsolete||

--- Comment #7 from Lari Taskula  ---
Created attachment 53371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53371=edit
Bug 16826: Add API route for getting item availability

GET /availability/items?itemnumber=123
GET /availability/items?itemnumber=123+456+789
GET /availability/items?biblionumber=321
GET /availability/items?biblionumber=321+654+987

This patch adds above routes for checking anonymous item availability. Patron
status is not checked.

The returned data is for example:
{
  "checkout": {
 "available": false,
 "description": ["onloan"],
 "expected_available": "2016-07-13"
  },
  "hold": {
 "available": true,
 "description": [],
 "expected_available": null
  },
  "local_use": {
 "available": false,
 "description": ["onloan"],
 "expected_available": "2016-07-13"
  },
  "onsite_checkout": {
 "available": false,
 "description": ["onsite_checkouts_disabled"],
 "expected_available": null
  },
  "hold_queue_length": 1,
  + some basic item information on locations, bib/bib(item)numbers etc.
}

Possible values in availability description are an empty array and any of:
"onloan", "reserved", "damaged", "withdrawn", "itemlost", "restricted",
"notforloan", "ordered". (+"onsite_checkouts_disabled" for onsite_checkout)

To test:
1. Play around with an item. Place a hold on it, checkout, set it damaged etc.
2. Make GET requests to /api/v1/availability/items?itemnumber=YYY, where
   YYY is an existing itemnumber. You can also try with biblionumber=XXX
   query parameter, where XXX is an existing biblionumber.
3. Check that the availability statuses are correct and that availability
   description lists the appropriate status for unavailability.
4. Repeat steps 1-3 until you are confident the route works as expected.
5. Run the following tests:
   - t/Koha/Item/Availability.t
   - t/db_dependent/Items.t
   - t/db_dependent/api/v1/availability.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16289] Abbreviated formatting for numbering patterns

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289

--- Comment #11 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #10)
> Looking at this code and some of otherthe code related to seasonal patterns,
> I believe the abbreviated seasons are not translatable/translated.

Can you expand on that? Is this due to us not using localized DateTimes?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #12 from Owen Leonard  ---
This breaks the list of current checkouts. On the circulation page it says "0
checkouts" even though I have many. On the patron detail page it shows the
correct count in the checkouts tab but lists no checkouts.

I strongly object to the delay this patch introduces to the appearance of the
checkout form. In my test system there is a 5-second delay between the time the
rest of the page renders and the time the checkout form appears.

The more AJAX we introduce on the checkout page the slower it gets. I don't
think that's what we intend, but that's the real consequence.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595

--- Comment #45 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #44)
> I have done some first tests - not so bad so far, but I worry about paying
> via SIP. Can you please verify that this works still as well?
> Which branch should be logged? The branch of the SIP user from the config
> file?

Yes, it should be the branch of the SIP user from the config file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16915] New: Integrate OMDb in to Koha

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16915

Bug ID: 16915
   Summary: Integrate OMDb in to Koha
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

OMDb API: http://www.omdbapi.com/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16870] Koha::Issue(s) should be named Koha::Checkout(s)

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870

--- Comment #4 from Kyle M Hall  ---
(In reply to Srdjan Jankovic from comment #3)
> Kyle, Koha::Checkout(s) was added in 14757, patch 1
> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52924

Yes, I noticed that! I will need to modify this patch set to take that into
account.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16687] Translatability: Fix issues in Administration preferences

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16687

Owen Leonard  changed:

   What|Removed |Added

  Attachment #53335|0   |1
is obsolete||

--- Comment #9 from Owen Leonard  ---
Created attachment 53370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53370=edit
[SGINED-OFF] Bug 16687 - Translatability: Fix issues in Administration
preferences

This patch fixes sentence splitting and other translation issues in
file koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
to avoid odd translations.

To test:
- Without patch, open Home > Administration > System preferences
  and go to tab 'Administration"
- Apply patch
- Open the same page in a new window and compare the text:
  - Verify  that no sentences are splitted
  - Verify that the text changes do not introduce misunderstandings
and have the same meaning as without patch

Amended for comment #7 2016-07-12/mv

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16687] Translatability: Fix issues in Administration preferences

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16687

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

--- Comment #24 from Marcel de Rooy  ---
(In reply to Nick Clemens from comment #23)
> I would second the use of Flipster since it has a few different config
> options available (coverflow, carousel, flat)

To second here does mean first, not second choice? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16914] New: Export csv in item search, exports all items in one line

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

Bug ID: 16914
   Summary: Export csv in item search, exports all items in one
line
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ha...@orex.es
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

We have discovered thant when you try to export in csv (koha 3.22.7) in
translated interface (es-ES and ca-ES) all items are located in just one file

This is because a problem with a file itemsearch_item.csv that it doesn't
include the order to break line for each item (at least is how we have fixed)

For reproduce the error
1. Go to staff 
2. Go to advance search -- item search
3. do whatever search and select csv to export
4. open with any textedior

sudo diff
/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/es-ES/includes/catalogue/itemsearch_item.csv.inc
/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/es-ES/includes/catalogue/itemsearch_item.csv.inc-original

< [%- USE Branches -%]
< [%- USE Koha -%]
< [%- biblio = item.biblio -%]
< [%- biblioitem = item.biblioitem -%]
< "[% biblio.title |html %] [% IF ( Koha.Preference( 'marcflavour' ) ==
'UNIMARC' && biblio.author ) %]by [% END %][% biblio.author |html %]", "[%
(biblioitem.publicationyear || biblio.copyrightdate) |html %]", "[%
biblioitem.publishercode |html %]", "[% biblioitem.collectiontitle |html %]",
"[% item.barcode |html %]", "[% item.itemcallnumber |html %]", "[%
Branches.GetName(item.homebranch) |html %]", "[%
Branches.GetName(item.holdingbranch) |html %]", "[% item.location |html %]",
"[% item.stocknumber |html %]", "[% item.status |html %]", "[% (item.issues ||
0) |html %]"[% INCLUDE 'empty_line.inc' %]
---
> [%- USE Branches -%] [%- USE Koha -%] [%- biblio = item.biblio -%] [%- 
> biblioitem = item.biblioitem -%] "[% biblio.title |html %] [% IF ( 
> Koha.Preference( 'marcflavour' ) == 'UNIMARC' && biblio.author ) %]por [% END 
> %][% biblio.author |html %]", "[% (biblioitem.publicationyear || 
> biblio.copyrightdate) |html %]", "[% biblioitem.publishercode |html %]", "[% 
> biblioitem.collectiontitle |html %]", "[% item.barcode |html %]", "[% 
> item.itemcallnumber |html %]", "[% Branches.GetName(item.homebranch) |html 
> %]", "[% Branches.GetName(item.holdingbranch) |html %]", "[% item.location 
> |html %]", "[% item.stocknumber |html %]", "[% item.status |html %]", "[% 
> (item.issues || 0) |html %]"[% INCLUDE 'empty_line.inc' %] 
\ No newline at end of file

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15131] Give SCO separate control for AllowItemsOnHoldCheckout

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15131

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com,
   ||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs)

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #10 from Marcel de Rooy  ---
(In reply to Owen Leonard from comment #9)
> (In reply to Marcel de Rooy from comment #1)
> 
> > Test plan:
> > [1] Add /not/there to your koha-conf.xml.
> > [2] Run on the command line:
> > PERL5LIB=test
> > source [path-to-your-instance]/debian/scripts/koha-functions.sh
> > echo $PERL5LIB
> > adjust_paths_dev_install [name-of-your-instance]
> 
> This last step results in an error in my gitified package installation. It
> says "bash: adjust_paths_dev_install: command not found."

Hi Owen,
Nice to see you test this.
The command not found-response sounds to me that you did not source the right
koha-functions file? Somehow the function was not loaded.
You should source the koha-functions file that has been adjusted by this patch.
If I follow the test plan, the output is as expected.
Could you clarify?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] Add API routes for getting item availability and holdability

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #6 from Lari Taskula  ---
How about something like this for general/anonymous availability? 

GET /availability/items?itemnumber=2225

returns for example:
[{
  "barcode":"TEST02",
  "biblioitemnumber":"629",
  "biblionumber":"629",
  "checkout": {
"available":false,
"description":["notforloan","reserved"],
"expected_available":null
  },
  "hold_queue_length":1,
  "holdingbranch":"CPL",
  "homebranch":"FFL",
  "itemcallnumber":"782.42166092",
  "itemnumber":"2225",
  "local_use": {
"available":false,
"description":["reserved"],
"expected_available":null
   },
  "location":"some_location",
  "onsite_checkout": {
"available":false,
"description":["onsite_checkouts_disabled"],
"expected_available":null
  }
}]
((+add hold-availability) In this example local_use = checkout with ignoring
notforloan, and onsite_checkout = OnSiteCheckouts syspref ? (local_use ?
true:false):false)

Anyway, what about when checking availability for a specific patron? Is it
better to use the same route or use a completely different route? The reason I
consider separation between anonymous availability and logged-in availability
is my fear that this endpoint will be super busy, and availability for a
specific patron is probably a heavy operation. On the other hand, if I used
this route, I think I would just want one route with always giving me the
correct availability status (checkout, hold, local_use, onsite_checkout etc)
for an item, regardless of me being logged-in or not. Opinions are welcome.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #82 from Marcel de Rooy  ---
QA Comment:
Taking the liberty to pass QA on this patch set now and granting Kyle the
privilege of having a last look, in view of history and extensive attention
given by several involved.
In the fourth patch get_timeout is moved to SIPServer after all (thx to
Srdjan); the last small follow-up just cares about a hypothetical first acs
resend request.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #53358|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 120 matches

Mail list logo