[Koha-bugs] [Bug 16874] Making serials collections actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874

--- Comment #4 from Aleisha Amohia  ---
(In reply to Claire Gravely from comment #3)
> Hi,
> Sorry, I didn't get two buttons in step 4 of the test. Just the one for
> 'create routing list'. The line wasn't highlighted either. 
> 
> 'Print list' was displaying just fine as a button.
> 
> Claire

Sorry, I should've added that the Renew button and row highlighting will only
show if the subscription is about to expire or has expired. Could you please
retest?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #53565|0   |1
is obsolete||

--- Comment #8 from Aleisha Amohia  ---
Created attachment 53716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53716=edit
Bug 16939: Making all 'add to basket' actions buttons

Edit: Fixing 'clas' typo in addorderiso2709.tt
Edit: Adding actions class to td
Edit: Fixing js error

To test:

1) Go to Acqui -> find a vendor -> view a basket
2) Click add to basket -> fill in 'for an existing record' and hit search
3) 'View MARC' and 'Order' buttons should show under an Actions column with
appropriate icons
4) Click Order
5) Click add item when you are redirected to the New order page (no need to
fill in any details)
6) Confirm that 'Edit' and 'Delete' buttons now show under an Actions column
with appropriate icons
7) Go back to your basket and click add to basket -> from a subscription (we
are skipping from a suggestion because this already has a button before my
patch)
8) Confirm that 'Order' shows as a button with appropriate icon
9) Go back to your basket and click add to basket -> from an external source
10) fill in any fields and click search to bring up results
11) 'Order' should now show as a button with appropriate icons. MARC and Card
preview have been moved into a dropdown menu - confirm this works as expected.
Links have not been changed when clicking on a row
12) Go back to your basket and click add to basket -> from a staged file
13) 'Add orders' should now show as a button with appropriate icon
14) Go back to your basket and click add to basket -> from titles with highest
hold ratios
15) 'X to order' should now show as a button with appropriate icon

Sponsored-by: Catalyst IT

Signed-off-by: Nicole C Engard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|ASSIGNED

--- Comment #25 from Chris Cormack  ---
Yep we definitely need a patch, at least for jessie, libsereal-perl is in
stretch, but it won't be backported for jessie.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16370] Set the record encoding to UTF8 when TransformHtmlToMarc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16370

--- Comment #7 from Liz Rea  ---
I even kept the attribution! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16370] Set the record encoding to UTF8 when TransformHtmlToMarc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16370

M. Tompsett  changed:

   What|Removed |Added

  Attachment #50819|0   |1
is obsolete||

--- Comment #6 from M. Tompsett  ---
Comment on attachment 50819
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50819
TransformHtmlToMarc-UTF8.patch

Liz Rea's patch is identical and git-friendlier for testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

M. Tompsett  changed:

   What|Removed |Added

 CC|mtomp...@hotmail.com|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

M. Tompsett  changed:

   What|Removed |Added

 CC|mtomp...@hotmail.com|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715

Mirko Tietgen  changed:

   What|Removed |Added

   Keywords||nowheezy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a rental charge

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #12 from Katrin Fischer  ---
Hm, also keep an eye on capitalisation please!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10451] Firefox prints only first page of table with shrink to fit option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10451

Billy  changed:

   What|Removed |Added

 CC||billiam...@gmail.com

--- Comment #12 from Billy  ---
i figured i should chime in here because i have been having this problem for
years. The only time i try to print something in Firefox is when Google Chrome
won't print my class schedule and i think the problems are related. In Chrome,
Safari, and Opera the printout and print preview is all goofy looking. It has
shrunken frames and visible scrollbars and is unusable. And it is like this on
every computer i try it on.

So i always try to do it in Firefox, but i always get this problem where
Firefox will only print the first page!

Whatever HTML my school's website is using for displaying both regular class
schedule and a "printable" version of the class schedule isn't rendering
properly for these browsers.

And i have to say it is SUPER annoying. I end up just printing screenshots.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5456] Create a link to opac-ics.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456

--- Comment #7 from Marc Véron  ---
Hi Jonathan,

I tested Magnus' newest patch again (with 2 checkouts), that's what I get:

BEGIN:VCALENDAR
VERSION:2.0
PRODID:Data::ICal 0.21
BEGIN:VEVENT
DESCRIPTION:Your copy of Pfützen schreien so laut ihr Licht (barcode glaupf
 u-01) is due back at the library today
DTSTAMP:20160725T185113Z
DTSTART:20160725T215900Z
SUMMARY:Pfützen schreien so laut ihr Licht is due
UID:issue-9@
END:VEVENT
BEGIN:VEVENT
DESCRIPTION:Your copy of Der Rattenkönig : (barcode rakoe-01) is due back a
 t the library today
DTSTAMP:20160725T185113Z
DTSTART:20160725T215900Z
SUMMARY:Der Rattenkönig : is due
UID:issue-10@
END:VEVENT
END:VCALENDAR

If I pass it through http://icalendar.org/validator.html#results, it gives no
errors (warnings though about the length of 2 lines).
I can import it to Thunderbird Calendar without problem, and Thunderbird shows
what I expect regarding time (25.07.2016 23:59 local time)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #26 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #25)
> I don't think I am ready to QA this one.
> Julian has announced a new plugin system few weeks ago and this patch will
> adds a precedent for the existing plugin system.
> Do you have in mind other uses case? Did you plan to extend it to other
> behaviors?
> It would be great to ping koha-devel to get other dev opinions.

Please follow the trace in the see also bug and see that it is already three
years under way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16138] Restart plack when rotating logfiles

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138

Tomás Cohen Arazi  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16974

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16974] koha-plack should check and fix log files permissions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16974] koha-plack should check and fix log files permissions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974

Tomás Cohen Arazi  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16138

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16974] koha-plack should check and fix log files permissions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 53714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53714=edit
Bug 16974: Make koha-plack should check and fix log files permissions

This patch adds a function to the koha-plack script so it checks for log file
existence and its permissions. This function is called from the start_plack
function.

If some of this conditions are not fulfilled, it solves the situation by either
touching and/or changing the permissions accordingly for the instances' plack
log files.

To test:
- Run (on kohadevbox):
  $ cd kohaclone
  $ debian/scripts/koha-plack --start kohadev
  $ debian/scripts/koha-plack --stop  kohadev
  $ ls /var/log/koha/kohadev/plack*
- Verify ownership of the created files (they might belong to the root user)
- Apply the patch
- Run:
  $ chown root:root /var/log/koha/kohadev/plack*
  $ debian/scripts/koha-plack --start kohadev
  $ ls /var/log/koha/kohadev/plack*
=> SUCCESS: Files belong to kohadev-koha:kohadev-koha
- Run:
  $ debian/scripts/koha-plack --stop  kohadev
  $ rm /var/log/koha/kohadev/plack*
  $ debian/scripts/koha-plack --start kohadev
  $ ls /var/log/koha/kohadev/plack*
=> SUCCESS: Files are created and belong to kohadev-koha:kohadev-koha
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Eric Bégin  changed:

   What|Removed |Added

 CC|remi.mayrand-provencher@inL |
   |ibro.com,   |
   |simith.dolive...@inlibro.co |
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Eric Bégin  changed:

   What|Removed |Added

 CC|maxime.beaul...@inlibro.com |eric.be...@inlibro.com
   |,   |
   |remi.mayrand-provencher@inL |
   |ibro.com,   |
   |simith.dolive...@inlibro.co |
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Eric Bégin  changed:

   What|Removed |Added

 CC|maxime.beaul...@inlibro.com |eric.be...@inlibro.com
   |,   |
   |remi.mayrand-provencher@inL |
   |ibro.com,   |
   |simith.dolive...@inlibro.co |
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Eric Bégin  changed:

   What|Removed |Added

 CC|maxime.beaul...@inlibro.com |
   |,   |
   |remi.mayrand-provencher@inL |
   |ibro.com,   |
   |simith.dolive...@inlibro.co |
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6934] New report Cash Register Statistics

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Eric Bégin  changed:

   What|Removed |Added

 CC|genevieve.plantin@inlibro.c |
   |om, |
   |remi.mayrand-provencher@inL |
   |ibro.com,   |
   |simith.dolive...@inlibro.co |
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Eric Bégin  changed:

   What|Removed |Added

 CC|maxime.beaul...@inlibro.com |
   |,   |
   |remi.mayrand-provencher@inL |
   |ibro.com,   |
   |simith.dolive...@inlibro.co |
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a rental charge

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||oleon...@myacpl.org

--- Comment #11 from Jonathan Druart  
---
I don't think we have found the best formatting for the fee sentence.
It shows:
  Renew Fee for VHS 5.00 (2 of 3 renewals remaining)
I think it's a bit confusing.

Owen, any ideas?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16974] koha-plack should check and fix log files permissions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |tomasco...@gmail.com
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16974] New: koha-plack should check and fix log files permissions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974

Bug ID: 16974
   Summary: koha-plack should check and fix log files permissions
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: gmcha...@gmail.com
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

It is not checking permissions and makes Koha fail badly if it cannot write the
logs.

This could happen on logrotate, on koha-plack --start|--restart.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #72 from Mehdi Hamidi  ---
Created attachment 53713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53713=edit
Bug 11879 - QA Follow-up

updatedatabase.pl no longer adds column primary_contact_method to table
borrowers
Fixed the incorrectly capitalized label and added the ':' in front of it(opac
and intranet).
Changed mobile phone to other phone in intranet and added a switch case in
moremember.tt
to display the correct label.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #71 from Mehdi Hamidi  ---
Created attachment 53712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53712=edit
Bug 11879 - Fix syspref BorrowerUnwantedField

How I tested:
Apply 1st patch
Apply this patch
Edit syspref BorrowerUnwantedField to exclude fields
Edit patron's contact information
Make sure that fields do not longer appear in drop down for Main contact

Wors as expected

http://bugs.koha-community.org/show_bug.cgi?id=11879
Signed-off-by: Marc Veron 

Signed-off-by: Kyle M Hall 
Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #69 from Mehdi Hamidi  ---
Created attachment 53710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53710=edit
Bug 11879 - QA Follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #68 from Mehdi Hamidi  ---
Created attachment 53709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53709=edit
Bug 11879 QA follow-up

Changed "Mobile Phone" to Other Phone, modified deletedborrowers table
structute and added the field in opac

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #70 from Mehdi Hamidi  ---
Created attachment 53711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53711=edit
Bug 11879 - Add a new borrower field : main contact method. (Was: Rebased on
current master for testing)

http://bugs.koha-community.org/show_bug.cgi?id=11879

To test this patch:
Update database
Edit a borrower's informations.
The "Main Contact Method" selectbox appears in the form and its
value is correctly.

Works as expected.
For handling of syspref BorrowerUnwantedField use second patch-

Signed-off-by: Marc Veron 

Signed-off-by: Kyle M Hall 
Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #67 from Mehdi Hamidi  ---
Created attachment 53708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53708=edit
Bug 11879 - Update BDIx schema and show main contact method in moremember.pl

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #53707|1   |0
   is patch||
  Attachment #53707|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #50433|0   |1
is obsolete||
  Attachment #52616|0   |1
is obsolete||
  Attachment #52617|0   |1
is obsolete||
  Attachment #52619|0   |1
is obsolete||
  Attachment #52620|0   |1
is obsolete||
  Attachment #53695|0   |1
is obsolete||

--- Comment #66 from Mehdi Hamidi  ---
Created attachment 53707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53707=edit
Bug 11879 - Add a new borrower field : main contact method

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16875] OPAC: Removing link to records if authority is not used by any records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16875

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53251|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 53706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53706=edit
Bug 16875: OPAC - removing link to records if authority is not used by any
records

To test:
1) Do an authority search. Notice that authorities not used by any records have
a clickable link (under Biblio records) which redirects to a catalog search
with no results
2) Go back to the authority search and click View full heading for an authority
with no records. Notice that under the auth name, it says Number of records
used in: 0, with a link to a catalog search
3) Apply patch
4) Repeat steps 1 and 2. Authorities not used in any records should no longer
have clickable links nd authorities which have records should work as expected.

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #53705|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16875] OPAC: Removing link to records if authority is not used by any records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16875

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #65 from Mehdi Hamidi  ---
Created attachment 53705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53705=edit
Bug 11879 - Add a new borrower field : main contact method

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16871] Translatability: Avoid [ %%-problem and fix related sentence splitting in catalogue/detail.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
1/ Looking at the logic it seems that reservedate could be missing (?)

2/ Before the patch the string was "waiting at LIBRARY since DATE", now it's
"waiting since DATE at LIBRARY". I don't think it represents a big change but I
would prefer to get the opinion of English native speakers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776

--- Comment #12 from Jonathan Druart  
---
(In reply to Marc Véron from comment #9)
> I tested, the counter patch works as well. That is the most important thing,
> I will sign-off.
> Hmm, patch title schuld say: Forget external language choice in language
> switcher (i.e. language switcher should not take care of language set by
> external link)

Well, it depends on how you see things actually :)
I wanted to say: Do not forget what has been passed in url when you click on
the language switcher.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5456] Create a link to opac-ics.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #6 from Jonathan Druart  
---
(In reply to Marc Véron from comment #5)
> Update 2016-07-25
> - Force date_due to UTC to avoid problematic timezone info like this:
>   DTSTART:TZID=Europe/Zurich:20160724T235900

I am not sure this is correct.

From https://metacpan.org/pod/DateTime::Format::ICal:
"The iCal spec requires that datetimes be formatted either as floating times
(no time zone), UTC (with a 'Z' suffix) or with a time zone id at the beginning
('TZID=America/Chicago;...'). If this method is asked to format a DateTime
object that has an offset-only time zone, then the object will be converted to
the UTC time zone internally before formatting."

So the TZID should be handled correctly by Thunderbird (I did not try).
I think we should either use a floating TZ or the tz returned by
C4::Context->tz, but not arbitrarily set it to UTC

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776

Marc Véron  changed:

   What|Removed |Added

  Attachment #53693|0   |1
is obsolete||
  Attachment #53693|0   |1
   is patch||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776

Marc Véron  changed:

   What|Removed |Added

  Attachment #53473|0   |1
is obsolete||

--- Comment #11 from Marc Véron  ---
Comment on attachment 53473
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53473
[SIGNED-OFF] Bug 16776 - If language is set by external link language switcher
does not work

Obsoelted in favour of Jonathan's counter patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776

Marc Véron  changed:

   What|Removed |Added

  Attachment #53693|1   |0
   is patch||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776

--- Comment #10 from Marc Véron  ---
Created attachment 53704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53704=edit
Bug 16776: Do not forget external language choice in language switcher

If language is set by external link language switcher does not work

To reproduce:

- Have a multilingual koha installation, let's say en, de-CH, fr-FR and it-IT
- Create external links e.g. from your multilingual library website to each
language variant of OPAC:

...cgi-bin/koha/opac-main.pl?language=en
...cgi-bin/koha/opac-main.pl?language=de-CH
...cgi-bin/koha/opac-main.pl?language=fr-FR
...cgi-bin/koha/opac-main.pl?language=it-IT

Each link opens fine displaying the language as appropriate.

Now try to switch language on the page you just opened via the external link.

It won't work, it will always stay on the language defined by the external
link.

To test:
- Apply patch
- Repeat steps above
- Verify that the language switcher works
- Verify in browser address field that after switching language, the param
'language= 'has vanished from url string
- Try links with multiple params and with params containing 'language', e.g.
  ...cgi-bin/koha/opac-search.pl?language=fr-FR=language=test
- Verify that only the parameter 'language=' vanishes

Tested counter patch, works as well.
Signed-off-by: Marc 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776

--- Comment #9 from Marc Véron  ---
I tested, the counter patch works as well. That is the most important thing, I
will sign-off.
Hmm, patch title schuld say: Forget external language choice in language
switcher (i.e. language switcher should not take care of language set by
external link)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16964] Fix capitalization for "Report Plugins" in reports-home.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16964

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16964] Fix capitalization for "Report Plugins" in reports-home.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16964

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53665|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 53703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53703=edit
Bug 16964: Fix capitalization for "Report Plugins" in reports-home.tt

Fix capitalization for "Report Plugins" in reports-home.tt according with
Coding Guidelines


Signed-off-by: Marc 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16937] Remove the use of "onclick" from the manage staged MARC records template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53646|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 53702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53702=edit
Bug 16937 [Revised] Remove "onclick" from the manage staged MARC records
template

This patch revises the manage staged MARC records template, removing
"onclick" attributes from the markup and defining those events in the
script.

To test, apply the patch and go to Tools -> Manage staged MARC records.

- If necessary, stage a MARC file for import.
- Click the name of the staged file and then the "Import this batch into
  the catalog" button. The batch should be correctly imported.
- Return to the list of staged MARC files.
- Click the name of an imported file and then the "Undo import into
  catalog" button. The import should be reverted.
- Return to the list of staged MARC files.
- Click the "Clean" button for any record. Confirm that the batch is
  cleaned.
- For any cleaned record, click the "Delete" button. The batch should be
  deleted.

Signed-off-by: Hector Castro 
Works as advertised

QA revision: Corrected class name so that "delete" button triggers the
correct warning.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16937] Remove the use of "onclick" from the manage staged MARC records template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16953] Acquisitions home: Remove trailing from breadcrumbs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53644|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 53701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53701=edit
Bug 16953: Acquisitions home: Remove trailing  from breadcrumbs

The breadcrumb on the Acquisition's home page reads: Home > Acquisitions >
This tiny patch removes the trailing > ()

Amended: Remove the link on 'Acquisitions' as well...
Signed-off-by: Claire Gravely 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16953] Acquisitions home: Remove trailing from breadcrumbs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953

Jonathan Druart  changed:

   What|Removed |Added

   Patch complexity|String patch|Trivial patch
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16953] Acquisitions home: Remove trailing from breadcrumbs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #25 from Jonathan Druart  
---
I don't think I am ready to QA this one.
Julian has announced a new plugin system few weeks ago and this patch will adds
a precedent for the existing plugin system.
Do you have in mind other uses case? Did you plan to extend it to other
behaviors?
It would be great to ping koha-devel to get other dev opinions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

Marc Véron  changed:

   What|Removed |Added

  Attachment #53690|0   |1
is obsolete||

--- Comment #35 from Marc Véron  ---
Created attachment 53700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53700=edit
Bug 12532 - QA Follow-up

Fixed tests, they now work without any fails

https://bugs.koha-community.org/show_bug.cgi?id=12532

Signed-off-by: Marc 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

Marc Véron  changed:

   What|Removed |Added

  Attachment #53649|0   |1
is obsolete||

--- Comment #34 from Marc Véron  ---
Created attachment 53699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53699=edit
Bug 12532 - Redirect guarantee email to guarantor

Fixed merge conflicts.
Both the guarantor and the guarantee will receive the email now.
Also fixed some log errors since the "save" button is the same one use for
editing the patron details.
Changed the save button "save" id whene editing only the Patron messaging
preferences so we can detect where the request is comming from.

Added unit tests.
Added an atomicupdate file.
Reordered the sysprefs in alphabetical order.
Refactored some code.

TEST PLAN:

I Apply the patch
II Run updatedatabase.pl
III Run db_dependent/Letters.t and db_dependant/Members.t

0) Enable EnhancedMessagingPreferences preference;
0) Enable EnableRedirectGuaranteeEmail preference;
1) Select a patron with child;
2) Enable Item checkout -> email in patron messaging preferences;
3) Select the patron's child;
4) Checkout an item;
5) Valide child checkout message in patron's inbox;

sponsored by the ville de victoriaville

Tested together with follow-up works as expected.
Signed-off-by: Marc 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #7 from Jonathan Druart  
---
You are using quote inside a quoted string, I get a JS error when creating a
new order:

SyntaxError: missing ; before statement
result += "" + edit_link + " " + del_link + "";

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53697|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 53698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53698=edit
Bug 16971: Missing dependency for HTML::Entities

This module is already used in opac-password-recovery.pl.
It is loaded in Acquisition, but not used (anymore?).
It is not yet listed in PerlDependencies.

Note: The module is packaged for Debian Wheezy and Jessie.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #13 from Jonathan Druart  
---
The sidebar does not appear on "Pending on-site checkouts", I guess it should.
I think the pref should be named CircSidebar instead of circSidebar.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Advanced search: Hide itemtypes from search form & Group itemtypes together into one search option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Eric Bégin  changed:

   What|Removed |Added

 CC|ahmed.sfa...@inlibro.com,   |
   |maxime.beaul...@inlibro.com |
   |,   |
   |simith.dolive...@inlibro.co |
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||hector.hecax...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #53674|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 53697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53697=edit
[SIGNED-OFF]Bug 16971: Missing dependency for HTML::Entities

This module is already used in opac-password-recovery.pl.
It is loaded in Acquisition, but not used (anymore?).
It is not yet listed in PerlDependencies.

Note: The module is packaged for Debian Wheezy and Jessie.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Hector Castro 
Good catch. HTML::Entities added.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315

Eric Bégin  changed:

   What|Removed |Added

 CC|ahmed.sfa...@inlibro.com,   |
   |maxime.beaul...@inlibro.com |
   |,   |
   |simith.dolive...@inlibro.co |
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11055] Add 'minutes' as a load period unit

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11055

Eric Bégin  changed:

   What|Removed |Added

 CC|ahmed.sfa...@inlibro.com,   |
   |maxime.beaul...@inlibro.com |
   |,   |
   |simith.dolive...@inlibro.co |
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Eric Bégin  changed:

   What|Removed |Added

 CC|ahmed.sfa...@inlibro.com,   |
   |maxime.beaul...@inlibro.com |
   |,   |
   |simith.dolive...@inlibro.co |
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11371] Add a new report : Orders by budget

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

Eric Bégin  changed:

   What|Removed |Added

 CC|ahmed.sfa...@inlibro.com,   |
   |maxime.beaul...@inlibro.com |
   |,   |
   |remi.mayrand-provencher@inL |
   |ibro.com,   |
   |simith.dolive...@inlibro.co |
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16507] show play media tab first

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53555|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  
---
Created attachment 53696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53696=edit
Bug 16507: Show play media tab first if record has no holdings

To test:
1) Go to Admin -> Global sysprefs
2) Turn on HTML5MediaEnabled and HTML5MediaYouTube
3) Go to Cataloging and create a new record
4) Catalogue a YouTube link in 856$u and save record. Do not add any items
(click Normal tab)
5) Confirm that Play media tab is the selected tab by default
6) View record on OPAC and confirm Play media tab is selected by default
7) Go back to staff client, add an item then go back to Normal tab
8) Confirm that Holdings tab is now selected by default
9) Confirm Holdings tab is selected by default on OPAC

Sponsored-by: Catalyst IT
Signed-off-by: Claire Gravely 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16507] show play media tab first

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

Eric Bégin  changed:

   What|Removed |Added

 CC|maxime.beaul...@inlibro.com |
   |,   |
   |remi.mayrand-provencher@inL |
   |ibro.com,   |
   |simith.dolive...@inlibro.co |
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #53229|0   |1
is obsolete||

--- Comment #64 from Mehdi Hamidi  ---
Created attachment 53695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53695=edit
Bug 11879 - QA Follow-up

updatedatabase.pl no longer adds column primary_contact_method to table
borrowers
Fixed the incorrectly capitalized label and added the ':' in front of it(opac
and intranet).
Changed mobile phone to other phone in intranet and added a switch case in
moremember.tt
to display the correct label.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #53688|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #50433|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16950] Serials subscriptions advanced search shows '0 found' pre-search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16950

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16950] Serials subscriptions advanced search shows '0 found' pre-search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16950

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53554|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 53694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53694=edit
Bug 16950: Serials subscriptions advanced search shows '0 found' pre-search

To test:
1) Go to Serials
2) Click Advanced Search in the toolbar at the top
3) Notice heading says Serials subscriptions (0 found) before a search has even
happened
4) Apply patch and click Advanced Search again
5) Heading should now say Serials subscriptions search
6) Submit search
7) Heading should say how many subscriptions your search found (like before)

Sponsored-by: Catalyst IT

Signed-off-by: Marc 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16973] Cannot upload cover images under plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16973

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #8 from Jonathan Druart  
---
Marc, could you take a look at this counter-patch?
Using regex seems easier to resolve this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776

--- Comment #7 from Jonathan Druart  
---
Created attachment 53693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53693=edit
[ALT] Bug 16776: Do not forget external language choice in language switcher

If language is set by external link language switcher does not work

To reproduce:

- Have a multilingual koha installation, let's say en, de-CH, fr-FR and it-IT
- Create external links e.g. from your multilingual library website to each
language variant of OPAC:

...cgi-bin/koha/opac-main.pl?language=en
...cgi-bin/koha/opac-main.pl?language=de-CH
...cgi-bin/koha/opac-main.pl?language=fr-FR
...cgi-bin/koha/opac-main.pl?language=it-IT

Each link opens fine displaying the language as appropriate.

Now try to switch language on the page you just opened via the external link.

It won't work, it will always stay on the language defined by the external
link.

To test:
- Apply patch
- Repeat steps above
- Verify that the language switcher works
- Verify in browser address field that after switching language, the param
'language= 'has vanished from url string
- Try links with multiple params and with params containing 'language', e.g.
  ...cgi-bin/koha/opac-search.pl?language=fr-FR=language=test
- Verify that only the parameter 'language=' vanishes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16973] Cannot upload cover images under plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16973

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16973] New: Cannot upload cover images under plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16973

Bug ID: 16973
   Summary: Cannot upload cover images under plack
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

To reproduce:

- Have a clean 3.22 packages install
- Create an instance, with plack enabled:
  $ koha-create --create-db test
- Go through the webinstaller
  $ koha-plack --enable test
  $ koha-plack --start  test
- Have a record
- Try attaching a cover image to it.
=> FAIL: "Denied" error message shows

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Eric Bégin  changed:

   What|Removed |Added

 CC|remi.mayrand-provencher@inL |
   |ibro.com,   |
   |simith.dolive...@inlibro.co |
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

   Assignee|simith.dolive...@inlibro.co |mehdi.ham...@inlibro.com
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins by metadata

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53544|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 53691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53691=edit
Bug 16586: Koha Plugins: Limit results of GetPlugins by metadata

It would be helpful if we could find a plugin based on some metadata
tag as returned by the plugin. This extends the use of GetPlugins that
already supports searching on method.

GetPlugins is used in: admin/edi_accounts.pl, plugins/plugins-home.pl and
tools/stage-marc-import.pl. The changes in these three scripts are
minimal and just related to parameter passing.

Test t/db_dependent/Plugins.t includes another test for GetPlugins. In this
regard a metadata tag has been added to t/Koha/Plugins/Test.pm.

NOTE: This adjustment will also be used in a redesign for bug 15545.

Test plan:
Run t/db_dependent/Plugins.t.
Enable pref UseKohaPlugins and config var enable_plugins.
Go to plugins-home.pl. Verify that it still lists your plugins.
Bonus: Check edi_accounts or stage-marc-import.pl if you have a working
plugin for that.

Signed-off-by: Liz Rea 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins by metadata

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586

--- Comment #4 from Jonathan Druart  
---
Created attachment 53692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53692=edit
Bug 16586: Simplify code using none

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins by metadata

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #53689|0   |1
is obsolete||

--- Comment #33 from Mehdi Hamidi  ---
Created attachment 53690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53690=edit
Bug 12532 - QA Follow-up

Fixed tests, they now work without any fails
Corrected commit message from Bug 11879 to Bug 12532.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715

--- Comment #24 from Mirko Tietgen  ---
Excellent! Can you also change PerlDependencies.pm please? Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

Mehdi Hamidi  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

--- Comment #32 from Mehdi Hamidi  ---
Created attachment 53689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53689=edit
Bug 11879 - QA Follow-up

Fixed tests, they now work without any fails

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #63 from Mehdi Hamidi  ---
Please discard my last comment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #52618|0   |1
is obsolete||

--- Comment #62 from Mehdi Hamidi  ---
Created attachment 53688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53688=edit
Bug 11879 - QA Follow-up

Fixed tests, they now work without any fails

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16946] Remove the use of "onclick" from several serials templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #3 from Jonathan Druart  
---
- serials/claims.pl
"clear filter" does not blank from and to dates.

- serials/routing-preview.tt and serials/routing.tt
you removed 

Otherwise, looks good!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16919] Problems with cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16919

rkui...@roundrocktexas.gov changed:

   What|Removed |Added

 CC||rkui...@roundrocktexas.gov

--- Comment #1 from rkui...@roundrocktexas.gov ---
Created attachment 53687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53687=edit
This is a screen capture of deleting 2 items from the Cart (notepad on our
system) and not working.

This is an example of a problem with the Cart feature.  I have 2 items in my
Cart (Notepad on our system) and I tried to remove them from the Notepad. 
After multiple tries the items are still there.
Rhonda K.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715

--- Comment #23 from Jonathan Druart  
---
(In reply to Mirko Tietgen from comment #20)
> > This Sereal module is a very thin wrapper around both Sereal::Encoder 
> > and Sereal::Decoder. It depends on both and loads both. So if you have
> > a user of both encoder and decoder, it is enough to depend on a particular 
> > version of Sereal and you'll get the most recent released versions of
> > Sereal::Encoder and Sereal::Decoder.
> 
> If that is all it does, it does not make much sense for Debian, IMHO. The
> real modules are there, just the wrapper isn't. I don't see a benefit of
> backporting this.

I have quickly tried this

diff --git a/Koha/Cache.pm b/Koha/Cache.pm
index 0f85ed1..fa4f136 100644
--- a/Koha/Cache.pm
+++ b/Koha/Cache.pm
@@ -40,7 +40,8 @@ use warnings;
 use Carp;
 use Module::Load::Conditional qw(can_load);
 use Koha::Cache::Object;
-use Sereal;
+use Sereal::Encoder;
+use Sereal::Decoder;

 use base qw(Class::Accessor);


And it seems to work correctly.
I can provide a patch if you need it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715

--- Comment #22 from Jonathan Druart  
---
(In reply to Marc Véron from comment #21)
> Oh, I see that the module is experimental (or am I missing something?):
> http://search.cpan.org/~yves/Sereal-0.330/lib/Sereal.pm

Not, it's http://search.cpan.org/~yves/Sereal-3.014/lib/Sereal.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360

--- Comment #58 from Jonathan Druart  
---
Created attachment 53686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53686=edit
Bug 11360 [QA Followup] - Fix styles and button order

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16942] Confirm hold results in ugly error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||11360


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
[Bug 11360] Disable barcode field and submit button when a hold is found
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/