[Koha-bugs] [Bug 17016] Button to clear all fields in budget planning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016 --- Comment #1 from Aleisha Amohia--- Created attachment 53872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53872=edit Bug 17016: Button to clear all fields in budget planning I have used the function from admin --> circ and fines rules To test: 1) Go to Admin --> Budgets 2) Click a budget 3) Click Planning -> any option 4) Test the Auto-fill button to see what it does 5) Apply patch and refresh page 6) Should now be a Clear button. Both buttons should show as font-awesome buttons with appropriate icons 7) Click Clear button. Confirm it clears all fields, which then refresh to have 0.00 etc. (default values) Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17016] Button to clear all fields in budget planning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016 Aleisha Amohiachanged: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17016] Button to clear all fields in budget planning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016 Aleisha Amohiachanged: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17016] New: Button to clear all fields in budget planning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016 Bug ID: 17016 Summary: Button to clear all fields in budget planning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamo...@hotmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Currently there is an auto-fill button, but if you want to undo this, now all fields are filled. There should be a clear option. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16273] Prevent selfregistration from printing the borrower password and filling the logging form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16273 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- How is the user informed about his/her login credentials when this preference is turned on? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 --- Comment #24 from Katrin Fischer--- *** Bug 16986 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16986] Index 035$a as OCLC-Number, Identifier-standard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16986 Katrin Fischerchanged: What|Removed |Added Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #11 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 6499 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16978] Add delete reports user permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978 Frédéric Demianschanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16978] Add delete reports user permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978 Frédéric Demianschanged: What|Removed |Added Attachment #53864|0 |1 is obsolete|| --- Comment #9 from Frédéric Demians --- Created attachment 53871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53871=edit Bug 16978: Followup - Copy create_report permissions for delete_report This patch should deal with comment #6's point of where a user who has create, but not execute permissions, would lose delete ability. Users with create and execute permissions would already have delete as well. TEST PLAN - 1) Back up db 2) drop database koha_library; 3) create database koha_library; 4) web install with all sample data with system user 6) log into staff client as system user 7) make sample koha admin user a superlibrarian 8) set username and password for sample koha admin user 9) log out and log in as koha admin 10) Create a user (USER_A) with permissions: create_reports and execute_reports. 11) Create a user (USER_B) with permissions: create_reports, but not execute_reports. 12) Create a user (USER_C) with permissions: execute_reports, but not create_reports. 13) Create a user (USER_D) with no report permissions. 14) Run the atomic update. 15) Check USER_A permissions -- should have delete_reports 16) Check USER_B -- should have delete_reports 17) Check USER_C -- should NOT have delete_reports 18) Check USER_D -- should NOT have delete_reports 19) run koha qa test tools 20) restore db Signed-off-by: Frédéric Demians -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16874] Making serials collections actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 --- Comment #6 from Aleisha Amohia--- (In reply to Claire Gravely from comment #5) > Hi, I just tried again. Same result. I set the expiration date in the past, > today and in the future and saw the same results each time with no renew > button. Actually, I just realised that this functionality kind of doesn't work without the patch applied also. The way I describe what to expect in the test case is exactly how it should work with and without the patch, but even without it it's not acting as it should. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Frédéric Demianschanged: What|Removed |Added Status|Needs Signoff |Failed QA CC||frede...@tamil.fr --- Comment #6 from Frédéric Demians --- I've just tried this patch in order to test bug 17005 depending patch. For me 4 tests are failing: 23, 24, 26, 27. It seems that each time, I've got this error: Can't call method "borrowernumber" on unblessed reference at Koha/REST/V1/Checkout.pm line 81 It may be due to my testing environment. Can someone confirm that tests are still working on master? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16949] Batch record deletion says success when no records have been passed in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16949 Aleisha Amohiachanged: What|Removed |Added Attachment #53792|0 |1 is obsolete|| --- Comment #8 from Aleisha Amohia --- Created attachment 53870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53870=edit Bug 16949: Batch record deletion says success when no records have been passed in The reason this happens is because the page will say success when the total number of records given equals the total number of successful deletions. If you pass in no records, there are no successful deletions --> 0 = 0 --> it thinks it has been successful. This patch adds a check that validates if any checkboxes were selected before submitting the final form. I have removed the check for if any records were selected AFTER the form has been submitted because it seemed unnecessary if the form can't be submitted without selection of records anyway. To test: 1) Go to Tools -> Batch record deletion 2) Put in a record number and click Continue 3) Deselect the record so that it doesn't actually delete and click Delete selected records 4) Page says 'All records have been deleted successfully!' 5) Apply patch. Go back and repeat step 3 6) Form should not submit and you should receive an alert saying that no records have been selected. 7) If you try selecting and deleting a record after this alert, it should still work Note: Have also changed the wording of error in Step 1 when you are entering record numbers to delete. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter and update master version number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013 Frédéric Demianschanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter and update master version number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013 Frédéric Demianschanged: What|Removed |Added Attachment #53842|0 |1 is obsolete|| --- Comment #2 from Frédéric Demians --- Created attachment 53869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53869=edit Bug 17013 - build-git-snapshot: add basetgz parameter and update master version number This adds a basetgz parameter to specify a pbuilder image. I use this to build against different distributions. This also updates the version number for master builds to 16.06. Signed-off-by: Frédéric Demians -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17011] Remove "onblur" event attribute from some templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17011 Frédéric Demianschanged: What|Removed |Added Attachment #53841|0 |1 is obsolete|| --- Comment #2 from Frédéric Demians --- Created attachment 53868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53868=edit Bug 17011 - Remove "onblur" event attribute from some templates Several templates have an "onblur" event attribute in the markup. This patch moves the onblur event definition into the JavaScript. To test, apply the patch and clear your browser cache if necessary. In Administration -> Authority types: - Choose "New authority type." - Enter any text into the "Authority type" field. - Moving the cursor focus away from this field should convert your text to uppercase. In Administration -> MARC bibliographic framework: - Choose "New framework." - Enter any text into the "Framework code" field. - Moving the cursor focus away from this field should convert your text to uppercase. In Administration -> Currencies and exchange rates: - Choose "New currency." - Enter any text into the "Currency" field. - Moving the cursor focus away from this field should convert your text to uppercase. In Administration -> Item types - Choose "New item type." - Enter any text into the "Item type" field. - Moving the cursor focus away from this field should convert your text to uppercase. Signed-off-by: Frédéric Demians -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17011] Remove "onblur" event attribute from some templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17011 Frédéric Demianschanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #15 from Aleisha Amohia--- (In reply to Jonathan Druart from comment #13) > Aleisha, as Mark told you in comment 3 and comment 5, your patch conflict > with bug 10589 and bug 16335. I see 10589 has been closed will this one goes ahead. Mark, should we wait for you to finish your work with 16335 before finishing this one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7520] json script to return advanced search types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520 --- Comment #22 from Srdjan Jankovic--- Correction to the comment #14: url is now /api/v1/meta/advanced-search-types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7520] json script to return advanced search types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520 --- Comment #21 from Srdjan Jankovic--- (In reply to Katrin Fischer from comment #18) > Hm, not sure - but couldn't you use a public SQL report to achieve the same? It would be a complex query that goes off two totally different tables depending on a syspref. If that's our policy I can certainly try. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7520] json script to return advanced search types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520 Srdjan Jankovicchanged: What|Removed |Added Attachment #7613|0 |1 is obsolete|| --- Comment #20 from Srdjan Jankovic --- Created attachment 53867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53867=edit bug_7520 Added Meta handler to API v1 for metadata lists Useful for building drop-downs etc. Kick off with /meta/advanced-search-types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7520] json script to return advanced search types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520 Srdjan Jankovicchanged: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for xnciptoolkit drivers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652 --- Comment #3 from Jiri Kozlovsky--- Created attachment 53866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53866=edit Bug 16652: RestfulAPI supporting services for Vufind and for xnciptoolkit drivers What this patch does is it takes current state of the following bugs: bug 13903 bug 16330 bug 13895 bug 16497 bug 16825 bug 17007 bug 16826 bug 15165 bug 17005 And rebases them on master altogether on each other fixing the merge conflicts. Using this patch it can be easily tried out the currently implemented functionality of REST API (even though in development for now) by running 'git bz apply 16652' after installing Koha's git-bz as decribed here: https://wiki.koha-community.org/wiki/Git_bz_configuration Also, the project xcncip2toolkit from eXtensibleCatalog has currently it's Koha connector implemented with respect to current state of these included bugs. See https://github.com/eXtensibleCatalog/xcncip2toolkit/blob/master/connectors/koha If you wish to try the full end-to-end functionality of this, you can run docker to install the xcncip2toolkit for you: https://github.com/eXtensibleCatalog/xcncip2toolkit/tree/master/dockerfile -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for xnciptoolkit drivers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652 Jiri Kozlovskychanged: What|Removed |Added Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7520] json script to return advanced search types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520 --- Comment #19 from Srdjan Jankovic--- Created attachment 53865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53865=edit bug_7520 Added helper "syspref" to Mojolicious handlers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16978] Add delete reports user permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978 M. Tompsettchanged: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16978] Add delete reports user permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978 --- Comment #8 from M. Tompsett--- Created attachment 53864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53864=edit Bug 16978: Followup - Copy create_report permissions for delete_report This patch should deal with comment #6's point of where a user who has create, but not execute permissions, would lose delete ability. Users with create and execute permissions would already have delete as well. TEST PLAN - 1) Back up db 2) drop database koha_library; 3) create database koha_library; 4) web install with all sample data with system user 6) log into staff client as system user 7) make sample koha admin user a superlibrarian 8) set username and password for sample koha admin user 9) log out and log in as koha admin 10) Create a user (USER_A) with permissions: create_reports and execute_reports. 11) Create a user (USER_B) with permissions: create_reports, but not execute_reports. 12) Create a user (USER_C) with permissions: execute_reports, but not create_reports. 13) Create a user (USER_D) with no report permissions. 14) Run the atomic update. 15) Check USER_A permissions -- should have delete_reports 16) Check USER_B -- should have delete_reports 17) Check USER_C -- should NOT have delete_reports 18) Check USER_D -- should NOT have delete_reports 19) run koha qa test tools 20) restore db -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16986] Index 035$a as OCLC-Number, Identifier-standard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16986 --- Comment #10 from Srdjan Jankovic--- Totally. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238 --- Comment #6 from David Cook--- Kyle, what do you need to move forward on this one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12268] Subject Broader Narrower Related terms and Query Parser and Exploded Terms issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12268 --- Comment #3 from David Cook--- (In reply to Marcel de Rooy from comment #2) > What should happen with QueryParser in its current state? That's a very good question. In my opinion, we should probably remove it from the code, since its use is problematic and it doesn't really have anyone to develop/maintain it. I would volunteer to work on it, but I don't have the time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7170] Remove use of XML::Simple
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170 --- Comment #22 from David Cook--- (In reply to Chris Cormack from comment #20) > > > > You can see why XML::Simple with its XMLout method is desirable. :) > > Except I work with the Author of XML::Simple and as David has already > pointed out, he recommends no one uses it. But this more than anything else. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7170] Remove use of XML::Simple
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170 --- Comment #21 from David Cook--- (In reply to M. Tompsett from comment #19) > I was looking in the svc ones and came up with this hackiness. > > You can see why XML::Simple with its XMLout method is desirable. :) That does indeed appear very hacky. It doesn't need to be so hacky. I have quite a bit of experience with XML::LibXML, and it wouldn't be hard to write a solid predictable output function. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16921] Authority Linking doesn't match to proper record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16921 --- Comment #6 from David Cook--- (In reply to Joy Nelson from comment #3) > I also am not seeing any oddities in my search results of authorities, nor > any mismatches in the linker script. Normally the oddities with the linker > script are due to setting in the system preferences. I have heard of other > sites with issues with the linker that appeared to be a result of their > zebra config. > -joy > If I recall correctly, I think Bywater has often shown a preference for using IndexData's repositories for Zebra? So you might have a more up-to-date version of Zebra than Nicholas, I think. Of course, this comment and my last one are after skimming this bug report for approximately 2 seconds, so I might be misreading :). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16921] Authority Linking doesn't match to proper record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16921 David Cookchanged: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #5 from David Cook --- (In reply to Nicholas van Oudtshoorn from comment #4) > Thanks Joy and Jacek, > > Hmmm - I was on 2.0.58 of zebra - updated now, and things seem a lot better. > Theology, Doctrinal > Theology, Doctrinal-popular Works > Theology, Doctrinal. > Not sure what that second one is doing being brought in... > Nicholas, are you on 2.0.59? If so, that hyphen is what's causing the problem. See bug 16581. I've been warning the community for a long time that the version of Zebra in Debian is bad when using ICU, but those warnings have mostly been ignored. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10816] Relational operators in Search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10816 --- Comment #2 from David Cook--- (In reply to Nicole C. Engard from comment #1) > So, how should we edit this section? I didn't write this guide so I'm open > to tips/suggestions. That's a good question. Ideally, someone (e.g. me) would try everything from the current guide to see if it works or not, then maybe fill in any gaps. With the addition of ElasticSearch, that's going to become a lot more difficult though, I think. Unfortunately, I'm not working much on Koha at the moment, so I don't have time to do this myself :/. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #98 from David Cook--- (In reply to M. Tompsett from comment #97) > PerlDependencies issue. Could you elaborate? I've added the Perl dependency. https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=10662=53362 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15541] Prevent normalization during matching/import process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 --- Comment #24 from David Cook--- To be honest, I don't know what I'm supposed to do about this patch anymore. I don't think Marcel liked my patch, but his suggestions weren't feasible, so... I don't know. I'm not inclined to work on it, since I'm not sure what I need to do to get it to an acceptable point. It's essentially a duplicate of bug 14238 anyway, so perhaps Kyle can write his own patch. I would be happy to add my sign off to that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16985] Self registration verification e-mail is broken - no token at the end of the URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985 Katrin Fischerchanged: What|Removed |Added Blocks|16275 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 [Bug 16275] Prevent patron self registration if the email already filled in borrowers.email -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16275] Prevent patron self registration if the email already filled in borrowers.email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Katrin Fischerchanged: What|Removed |Added Depends on|16985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985 [Bug 16985] Self registration verification e-mail is broken - no token at the end of the URL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16275] Prevent patron self registration if the email already filled in borrowers.email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 --- Comment #10 from Katrin Fischer--- Created attachment 53863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53863=edit [PASSED QA] Bug 16275: Do not allow a self registration with an existing email address To avoid multiple registrations, it would be good to check the unicity of the primary email address. This patchset adds a new pref PatronSelfRegistrationEmailMustBeUnique. If on, a patron will get "This email address already exists in our database" if he try to register with an existing email address. Test plan: 1/ Register a new patron with an email address 2/ Make an other registration using the same email address => With the pref PatronSelfRegistrationEmailMustBeUnique on, you won't be allowed => With the pref off, no change should be noticed. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no errors. Signed-off-by: Nicolas Legrand Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16275] Prevent patron self registration if the email already filled in borrowers.email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Katrin Fischerchanged: What|Removed |Added Attachment #51181|0 |1 is obsolete|| Attachment #51182|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 53862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53862=edit [PASSED QA] Bug 16275: Add the new pref PatronSelfRegistrationEmailMustBeUnique Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Bernardo Gonzalez Kriegel No errors Signed-off-by: Nicolas Legrand Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16275] Prevent patron self registration if the email already filled in borrowers.email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Katrin Fischerchanged: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16275] Prevent patron self registration if the email already filled in borrowers.email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Katrin Fischerchanged: What|Removed |Added Summary|Prevent patron creation if |Prevent patron self |the email already filled in |registration if the email |borrowers.email |already filled in ||borrowers.email -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16960] Patron::Modifications should be fixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960 Katrin Fischerchanged: What|Removed |Added Severity|normal |critical --- Comment #6 from Katrin Fischer --- Upping severity - appears to have bad side effects. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16957] Fine amount does not display on patron checkout page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16957 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 16810 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16810] Fines note not showing on checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 Katrin Fischerchanged: What|Removed |Added CC||vimal0...@gmail.com --- Comment #10 from Katrin Fischer --- *** Bug 16957 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16808] Serial claims: claiming via CSV export doesn't reload the page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808 --- Comment #4 from Katrin Fischer--- The warning reads something like this: this will make firefox reload the page and will cause all actions to be repeated (like a search or an ordering process) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16808] Serial claims: claiming via CSV export doesn't reload the page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808 Katrin Fischerchanged: What|Removed |Added Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- The way this patch works creates a warning about resending the page in Firefox 47 (mine is German, so copying the message here probably won't help much). This might turn some users away thinking it's a bug, especially since the message appears before the download with a warning sound. Is there a better way to achieve that? Could we not just reload the page like other forms do? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7520] json script to return advanced search types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #18 from Katrin Fischer --- Hm, not sure - but couldn't you use a public SQL report to achieve the same? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15922] Show authorized value description in staff client search results for lost , withdrawn, and damaged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 --- Comment #10 from Katrin Fischer--- In my opinion dealing with the other pages in separate bugs sounds ok, but we should file them now so the missing behaviour is better documented. As we got libraries differentiating between lost and missing and sometimes using the different status for 'odd' things they need, I can't say they are always left unchanged :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15541] Prevent normalization during matching/import process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Failed QA --- Comment #23 from Katrin Fischer --- It looks like bouzid.ferg...@inlibro.com's sign-off got lost along the way. I am not sure how much the patch set was changed after the initial sign off - setting to Failed QA to get David's or Bouzid's attention. Patches still apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #61 from Katrin Fischer--- Just took another look - agree with Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Katrin Fischerchanged: What|Removed |Added Attachment #53830|0 |1 is obsolete|| --- Comment #31 from Katrin Fischer --- Created attachment 53861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53861=edit [PASSED QA] Bug 16715: Use Sereal::Decoder and Sereal::Encoder instead of Sereal Sereal is not packaged for jessie, so let's use Sereal::Encoder and Sereal::Decoder instead. Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Katrin Fischerchanged: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16978] Add delete reports user permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978 --- Comment #7 from M. Tompsett--- (In reply to Jonathan Druart from comment #6) > Mark, you must provide a SQL query to update the permissions of patrons. > Actually everything should be ok for 95%, but if a patron has create_report > but execute_report (ok that sounds weird), after this patch he won't be able > to delete reports. DOH! Thanks for catching that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Chris Cormackchanged: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #3 from Chris Cormack --- (In reply to Katrin Fischer from comment #2) > >It will also check if the > >same day from last year was a holiday, if so, this will be counted as a > >holiday. > > This sounds like a wrong assumption. Most of the holidays here are not on > the same date every year - so this would create a horrible mess. It's the > reason why you can choose to have unique holidays and holidays that repeat > every year with the current system. I agree this sounds like a big step backwards in functionality. The first step of any rewrite/refactor should be to make sure all existing functionality is not lost. The calendar is vitally important, so many things depend on it, it is vital we don't lose functionality. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Katrin Fischerchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16986 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16986] Index 035$a as OCLC-Number, Identifier-standard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16986 Katrin Fischerchanged: What|Removed |Added CC||tomasco...@gmail.com See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=6499 --- Comment #9 from Katrin Fischer --- Hi Srdjan, I just saw that bug 6499 has passed QA - is this ok for you? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- >It will also check if the >same day from last year was a holiday, if so, this will be counted as a >holiday. This sounds like a wrong assumption. Most of the holidays here are not on the same date every year - so this would create a horrible mess. It's the reason why you can choose to have unique holidays and holidays that repeat every year with the current system. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16985] Self registration verification e-mail is broken - no token at the end of the URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985 --- Comment #2 from Katrin Fischer--- Jonathan, are you sure it's a duplicate? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16955] Internal Server Error while populating new framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955 --- Comment #8 from Marc Véron--- Hi Jonathan, Sorry, I have no time at the mmoment to fix this. Can you provide an alternative patch? Thanks Marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13029] Allow to pass additional parameters to SMS::Send drivers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 --- Comment #9 from Magnus Enger--- Any chance of this patch getting some more attention? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17014] Remove more event attributes from patron templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014 --- Comment #1 from Owen Leonard--- Created attachment 53860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53860=edit Bug 17014 - Remove more event attributes from patron templates There are many patron-related templates which still use event attributes to define events. This patch updates these templates so that events are defined in JavaScript. To test apply the patch and check out to a patron. - From the Print menu in the toolbar, choose "Print summary." The patron summary page should open and the print dialog should be automatically triggered. - From the Print menu in the toolbar, choose "Print slip." The patron slip page should open and the print dialog should be automatically triggered. - From the Print menu in the toolbar, choose "Print quick slip." The patron quick slip page should open and the print dialog should be automatically triggered. - Click the patron's "Fines" tab in the left-hand sidebar and then choose the "Account" tab. -- Click the "Print" button for an account payment (the link should point to printfeercpt.pl). A print receipt page should open and the print dialog should be automatically triggered. -- Follow the same procedure for a transaction which is not an account payment (the link should point to printinvoice.pl). - Click the "Create manual invoice" tab. -- Select one of the "type" choices. Doing so should automatically populate the "Description" field with the corresponding code. -- If necessary, define one or more values for the MANUAL_INV authorized value and confirm that those invoice types work as well. - From the patron's "Pay fines" tab, click the "Pay amount" button. In the "collect from patron" field, enter any combination of letters, numbers, and symbols. When you tab away from that field your text should be reformatted to currency format. - From the patrons home page, change the filter in the left-hand sidebar and submit it. The correct results should be returned. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17014] Remove more event attributes from patron templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014 Owen Leonardchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8016] Items are not tie to the transaction using "global" action.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8016 Marjorie Barry-Vilachanged: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidichanged: What|Removed |Added CC||mehdi.ham...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #1 from Mehdi Hamidi--- Created attachment 53859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53859=edit Bug - 17015 New calendar The new calendar is now in the table discreate_calendar. All holidays will be indicated in this table. Closing and opening hours will be available on this table as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidichanged: What|Removed |Added Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New: New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Bug ID: 17015 Summary: New Koha Calendar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Holidays Assignee: koha-bugs@lists.koha-community.org Reporter: mehdi.ham...@inlibro.com QA Contact: testo...@bugs.koha-community.org We are trying to create a new Koha calendar system. The one available right now is way too slow. This is the first patch of the calendar, it doesn't affect the functioning of the current calendar, but it works in parallel with it. Instead of having multiple tables for the holidays, we created one table, called discrete_calendar. This table contains the dates,branchcode, opening/closing hours, a note about the holiday and whether the library is open or not. The script misc/generate_discrete_calendar.pl fills the table discrete_calendar based on tables : repeatable_holidays, special_holidays, openinghours and branches. The script, by default, will add 2 years from the past and 1 year in the future in the table discrete_calendar. It also has an option to added more than 1 year in the future. The script misc/cronjobs/add_days_discrete_calendar.pl will add days in the future in the table discrete calendar. A day's opening and closing hours will be based on the same weekday from the week before. It will also check if the same day from last year was a holiday, if so, this will be counted as a holiday. The script makes sur there's at least 1 year in the future. So if it hasn't ran for 8 days, 8 days will be added in he future the next time the script is executed. There's also an atomic update to create the table. The current options are not final and they can be changed for convenience. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Jiri Kozlovskychanged: What|Removed |Added Attachment #53852|0 |1 is obsolete|| --- Comment #5 from Jiri Kozlovsky --- Created attachment 53858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53858=edit Bug 17005: REST API: add routes to list checkouts history GET /checkouts/history (get all old_issues' issue_id) GET /checkouts/history?borrowernumber={borrowernumber} (get all borrower's old_issues' issue_id) GET /checkouts/history/{checkout_id} (get old_issue) + unit tests in t/db_dependent/api/v1/checkoutshistory.t Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission circulate_remaining_permissions. 2. Go to http://yourlibrary/api/v1/checkouts/history?borrowernumber=XXX (replace XXX with a borrowernumber that has some checkouts history) and check you receive all the issues from patron's history 3. Go to http://yourlibrary/api/v1/checkouts/history/YYY (replace YYY with an existing checkout id) and check you receive correct data 4. Run unit tests in t/db_dependent/api/v1/checkoutshistory.t This patch on top of previous changes adds the condition that the old issue included in any response must have itemnumber. Those which does not have itemnumber does not count as such old issue is completely useless. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17012] Remove more event attributes from administration templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17012 Frédéric Demianschanged: What|Removed |Added Attachment #53846|0 |1 is obsolete|| --- Comment #2 from Frédéric Demians --- Created attachment 53857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53857=edit Bug 17012 - Remove more event attributes from administration templates There are several administration templates which still contain event attributes. This patch move event definition to the JavaScript. To test you must have the SMSSendDriver system preference set to "Email." Apply the patch and go to Administration. - In Global system preferences, change the value of any input or select and then click the "Cancel" link for that section. After confirming your choice, the page should reload with your changes reset. - In Circulation and fine rules, edit any existing rule. In the editing row, click the "Clear" button. The data for that rule should be cleared. - In Transport cost matrix, make any change to the matrix. Submitting the form should work correctly. - In MARC bibliographic framework, choose 'MARC structure' for any framework. - Checking or unchecking the 'Display only used tags/subfields' checkbox should reload the page and change the display according to your choice. - In Did you mean?, make changes to the existing configuration. - Clicking "Cancel" should reload the page and discard your changes. - Clicking "Save configuration" should correcly save your changes. - In SMS cellular providers, click to edit any existing provider. Clicking the "Cancel" link should cancel the editing process and return you to the list of providers. Signed-off-by: Frédéric Demians -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17012] Remove more event attributes from administration templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17012 Frédéric Demianschanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial collection and serial edit templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Frédéric Demianschanged: What|Removed |Added Attachment #53647|0 |1 is obsolete|| --- Comment #2 from Frédéric Demians --- Created attachment 53856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53856=edit Bug 16962 - Remove the use of "onclick" from serial collection and serial edit templates This patch removes the use of event attributes like "onclick" from the serial collection and serial edit templates. Events are now defined in JavaScript. Also changed: Converted "create routing list," "edit routing list," and "Renew" links to Bootstrap buttons. The "select all" and "clear all" links have Font Awesome icons added. To test, apply the patch and go to Serials - Locate or create a subscription for which an item record is NOT created when receiving. - On the serial collection page for this subscription, test that the "Multi receiving" button works correctly. - For any subscription, test that the "Generate next" button works correctly. - In each tab, test that the "select all" and "clear all" links work correctly. - On a subscription which has expired, test that the "Renew" button works correctly. - On the serial collection page, select multiple issues and click the "Edit serials" button. - Testing with a subscription for which an item record is NOT created when receiving: - Changing the status to "Arrived" or "Claimed" should change the "Expected on" date to today's date. Selecting any other status should leave the "expected on" date as it was or return it to its original value. - Test that the "Multi receiving" button works correctly. - Testing with a subscription for which an item record IS created when receiving: - Changing the status of an issue should work as above but should also trigger the appearance of the item add form when the status is "Arrived" or "Claimed," and hide the form otherwise. - Cliking the "Item" link at the top of the item add form should hide it. - Clicking the "Add item" link under any issue should display the item add form. - In the item add form, test that repeatable fields are correctly duplicated when you click the "clone" button. - On the "Supplemental issue" line, changing the status to "Arrived" should work as described above. Changing the status on this line to "Claimed" should only change the "Expected on" date. - Adding regular and supplemental issues should work correctly. Signed-off-by: Frédéric Demians Works as described. https://bugs.koha-community.org/show_bug.cgi?id=16692 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial collection and serial edit templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Frédéric Demianschanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16808] Serial claims: claiming via CSV export doesn't reload the page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808 Frédéric Demianschanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16808] Serial claims: claiming via CSV export doesn't reload the page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808 Frédéric Demianschanged: What|Removed |Added Attachment #52809|0 |1 is obsolete|| --- Comment #2 from Frédéric Demians --- Created attachment 53855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53855=edit Bug 16808 - Serial claims: claiming via CSV export doesn't reload the page When using the CSV export for claiming serial issues, with bug 12178 the claim counter is incremented and a claim date set, but this will only be visible after reloading the page manually as the feature itself doesn't reload the page. To avoid confusion and errors using this feature,, the page should reload when the claims data is changed. Test Plan: 1) Claim some serials 2) Note the page does not reload, the status is not set to 'claimed' 3) Apply this patch 4) Claim some serials 5) Note the page reloads and verify that the status of the selected serials are "claimed" Signed-off-by: Frédéric Demians -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15108] OAI-PMH provider improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Frédéric Demianschanged: What|Removed |Added Attachment #52423|0 |1 is obsolete|| --- Comment #41 from Frédéric Demians --- Created attachment 53854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53854=edit Bug 15108 - OAI-PMH provider improvements - Fixed date handling to use UTC as specs require. - Added support for second precision in time stamps. - Added support for marc21 metadata prefix as recommended in the guidelines (synonym for marcxml). - ListIdentifiers and ListRecords always return records in timestamp order (faster than biblionumber order with the new index). - Improved performance of database queries especially for large collections. - Unified functionality of ListRecords and ListIdentifiers to a common base class. - If items are included in the records, their timestamps are taken into account everywhere so that whichever is the most recent (timestamp of biblioitem or any of its items) is considered the record's timestamp. Signed-off-by: Frédéric Demians -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15108] OAI-PMH provider improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Frédéric Demianschanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15108] OAI-PMH provider improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #40 from Frédéric Demians--- Created attachment 53853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53853=edit Remove Koha::AtomicUpdater dependency Signed-off-by: Frédéric Demians -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Jiri Kozlovskychanged: What|Removed |Added Attachment #53851|0 |1 is obsolete|| --- Comment #4 from Jiri Kozlovsky --- Created attachment 53852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53852=edit Bug 17005: REST API: add routes to list checkouts history GET /checkouts/history (get all old_issues' issue_id) GET /checkouts/history?borrowernumber={borrowernumber} (get all borrower's old_issues' issue_id) GET /checkouts/history/{checkout_id} (get old_issue) + unit tests in t/db_dependent/api/v1/checkoutshistory.t Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission circulate_remaining_permissions. 2. Go to http://yourlibrary/api/v1/checkouts/history?borrowernumber=XXX (replace XXX with a borrowernumber that has some checkouts history) and check you receive all the issues from patron's history 3. Go to http://yourlibrary/api/v1/checkouts/history/YYY (replace YYY with an existing checkout id) and check you receive correct data 4. Run unit tests in t/db_dependent/api/v1/checkoutshistory.t Now the endpoint with borrowernumber does not return all the details from within the old issues, but only their issue_id. This is made in order to enhance API performance. E.g. VuFind can retrieve all the issue_ids & use AJAX to query details about those, so user sees how the details come up one by one & does not have to wait for all of them at once (could be very long with really old users) In order to get issue details, use the endpoint with the checkout_id. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17014] New: Remove more event attributes from patron templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014 Bug ID: 17014 Summary: Remove more event attributes from patron templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org There are many patron-related templates which still use event attributes to define events. These should be modified so that events are defined in JavaScript. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Jiri Kozlovskychanged: What|Removed |Added Attachment #53843|0 |1 is obsolete|| --- Comment #3 from Jiri Kozlovsky --- Created attachment 53851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53851=edit Bug 17005: REST API: add routes to list checkouts history GET /checkouts/history (get all old_issues' issue_id) GET /checkouts/history?borrowernumber={borrowernumber} (get all borrower's old_issues) GET /checkouts/history/{checkout_id} (get old_issue) + unit tests in t/db_dependent/api/v1/checkoutshistory.t Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission circulate_remaining_permissions. 2. Go to http://yourlibrary/api/v1/checkouts/history?borrowernumber=XXX (replace XXX with a borrowernumber that has some checkouts history) and check you receive correct data 3. Go to http://yourlibrary/api/v1/checkouts/history/YYY (replace YYY with an existing checkout id) and check you receive correct data 4. Run unit tests in t/db_dependent/api/v1/checkoutshistory.t Added promised unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 --- Comment #20 from Jonathan Druart--- Created attachment 53850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53850=edit Bug 16365: [QA Follow-up] Add some comment lines to Cache.pm Resolve typo inifinite too. Adds a few lines in order to stress that the thawed key of the L1 cache SHOULD ONLY be used for unsafe calls, and not be mixed with regular (safe) calls. Test plan: Nothing to test, but verify the quality of the added comments. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 --- Comment #19 from Jonathan Druart--- Created attachment 53849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53849=edit Bug 16365: Adding additional unsafe call-candidates from Acquisition [1] Candidate 1 is FillWithDefaultValues. This routine in Acquisition.pm does not autovivify the tagslib structure but first collects the keys at tag and subfield level. So, unsafe can be safely added here :) [2] Candidate 2 is script acqui/neworderempty.pl. It only (!) uses GetMarcStructure to know if there is a ACQ framework. There should be cheaper ways to do it, but when we use the fast cache, it does not matter that much anymore. [3] Candidate 3 is script acqui/orderreceive.pl. Same reason as [2]. Signed-off-by: Marcel de Rooy Tested with neworderempty.pl Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 --- Comment #18 from Jonathan Druart--- Created attachment 53848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53848=edit Bug 16365 - GetMarcStructure() "unsafe" variant in PrepareItemrecordDisplay() This sub is a good candidate for the "unsafe" treatment too, it doesn't modify nor autovivify anything in the marc structure. Added a warning in the code regarding the $tagslib usage by the custom item plugins, plus a small change to prevent possible "Use of uninitialized value" warnings in the future. Signed-off-by: Marcel de Rooy Tested with neworderempty.pl and itemrecorddisplay.pl. Amended slightly: Made warning less dramatic. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 Jonathan Druartchanged: What|Removed |Added Attachment #53761|0 |1 is obsolete|| Attachment #53762|0 |1 is obsolete|| Attachment #53763|0 |1 is obsolete|| Attachment #53764|0 |1 is obsolete|| --- Comment #17 from Jonathan Druart --- Created attachment 53847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53847=edit Bug 16365: Selectively introduce GetMarcStructure() "unsafe" variant for better performance GetMarcStructure() currently uses Koha::Cache in the "safe" mode (returning deep copy of the result data structure by default), which causes numerous performance issues in many Koha scripts. Switching it to the "unsafe" mode globally (2nd patch from Bug 16140) resolves those issues, but ensuring that it is regression-free (and that it will stay that way in the future) is far from easy. This patch proposes a bit more manageable solution, it introduces a possibility to use "unsafe" variant selectively (only in those places in the code where GetMarcStructure() is called repetitively). That way, amount of the code that needs to be audited for possible problems gets vastly reduced, without any performance trade-offs. Test plan: 1) Have a look at the code and audit the parts affected by this patch for possible regressions Signed-off-by: Marcel de Rooy Amended the POD of GetMarcStructure, removing a TODO. NOTE: GetAuthorisedValueDesc, as called in C4::XSLT::transformMARCXML4XSLT and by GetISBDView, GetMarcAuthors in C4::Biblio, may autovivify some hash entries in tagslib. Same for Koha/Filter/MARC/ViewPolicy.pm, sub filter. No reason however to worry; our use of this structure in Koha does not depend on the existence of intermediate hash keys. (We seem to be safe as long as $tagslib->{$tag}->{$subfield}->{tab} and/or hidden are not filled.) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17012] Remove more event attributes from administration templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17012 --- Comment #1 from Owen Leonard--- Created attachment 53846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53846=edit Bug 17012 - Remove more event attributes from administration templates There are several administration templates which still contain event attributes. This patch move event definition to the JavaScript. To test you must have the SMSSendDriver system preference set to "Email." Apply the patch and go to Administration. - In Global system preferences, change the value of any input or select and then click the "Cancel" link for that section. After confirming your choice, the page should reload with your changes reset. - In Circulation and fine rules, edit any existing rule. In the editing row, click the "Clear" button. The data for that rule should be cleared. - In Transport cost matrix, make any change to the matrix. Submitting the form should work correctly. - In MARC bibliographic framework, choose 'MARC structure' for any framework. - Checking or unchecking the 'Display only used tags/subfields' checkbox should reload the page and change the display according to your choice. - In Did you mean?, make changes to the existing configuration. - Clicking "Cancel" should reload the page and discard your changes. - Clicking "Save configuration" should correcly save your changes. - In SMS cellular providers, click to edit any existing provider. Clicking the "Cancel" link should cancel the editing process and return you to the list of providers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17012] Remove more event attributes from administration templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17012 Owen Leonardchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16830] koha-indexer still uses the deprecated -x option switch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16830 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16830] koha-indexer still uses the deprecated -x option switch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16830 --- Comment #6 from Jonathan Druart--- Created attachment 53845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53845=edit Bug 16830: (followup) Remove weird character from warning in rebuild_zebra.pl Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16830] koha-indexer still uses the deprecated -x option switch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16830 Jonathan Druartchanged: What|Removed |Added Attachment #53480|0 |1 is obsolete|| Attachment #53481|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 53844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53844=edit Bug 16830: Remove -x usage on koha-indexer This patch just does that, and removes it from the comment on /etc/default/koha-common To test: - Apply the patch - Run: $ vagrant ssh ; cd kohaclone $ sudo debian/scripts/koha-indexer --stop kohadev $ sudo debian/scripts/koha-indexer --start kohadev => SUCCESS: Verify no warning is shown on the indexer-output.log file - Sign off https://bugs.koha-community.org/show_bug.cgi?id=16830 Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Failed QA --- Comment #27 from Jonathan Druart --- 1/ Tests in t/db_dependent/Circulation/Returns.t does not pass with these patches applied. 2/ "This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences." Hum... git grep "ReturnToShelvingCart\|InProcessingToShelvingCart" | grep -v translator | wc -l 28 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #12 from Jonathan Druart --- Changes to sysprefs.sql are missing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #2 from Jiri Kozlovsky--- Since this bug depends on bug 13895, you should do "git bz apply 13895" first & then "git bz apply 17005" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #1 from Jiri Kozlovsky--- Created attachment 53843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53843=edit Bug 17005: REST API: add routes to list checkouts history GET /checkouts/history (get all old_issues' issue_id) GET /checkouts/history?borrowernumber={borrowernumber} (get all borrower's old_issues) GET /checkouts/history/{checkout_id} (get old_issue) + unit tests in t/db_dependent/api/v1/checkoutshistory.t Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission circulate_remaining_permissions. 2. Go to http://yourlibrary/api/v1/checkouts/history?borrowernumber=XXX (replace XXX with a borrowernumber that has some checkouts history) and check you receive correct data 3. Go to http://yourlibrary/api/v1/checkouts/history/YYY (replace YYY with an existing checkout id) and check you receive correct data 4. Run unit tests in t/db_dependent/api/v1/checkoutshistory.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Jiri Kozlovskychanged: What|Removed |Added Depends on||13895 Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 [Bug 13895] Add API routes for checkouts retrieval and renewal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Jiri Kozlovskychanged: What|Removed |Added Blocks||17005 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 [Bug 17005] REST API: add routes to list checkouts history -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter and update master version number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013 Mirko Tietgenchanged: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter and update master version number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013 --- Comment #1 from Mirko Tietgen--- Created attachment 53842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53842=edit Bug 17013 - build-git-snapshot: add basetgz parameter and update master version number This adds a basetgz parameter to specify a pbuilder image. I use this to build against different distributions. This also updates the version number for master builds to 16.06. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17013] New: build-git-snapshot: add basetgz parameter and update master version number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013 Bug ID: 17013 Summary: build-git-snapshot: add basetgz parameter and update master version number Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: mi...@abunchofthings.net QA Contact: testo...@bugs.koha-community.org CC: mi...@abunchofthings.net This adds a basetgz parameter to specify a pbuilder image. I use this to build against different distributions. This also updates the version number for master builds to 16.06. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/