[Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of stopping zebrasrv

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

M. Tompsett  changed:

   What|Removed |Added

  Attachment #53925|0   |1
is obsolete||

--- Comment #5 from M. Tompsett  ---
Created attachment 53926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53926=edit
Bug 16885: koha-stop-zebra should be more sure of stopping zebrasrv

This patch actually loops 10 tens to check, before giving up.

TEST PLAN
-
1) Back up your koha logs as desired.
2) add something to /var/log/koha/{instance name}/intranet-error.log
3) ps aux | grep zebra
4) logrotate -f /etc/logrotate.d/koha-common
5) ps aux | grep zebra
   -- the zebrasrv and daemon process for zebra indexing
  didn't restart.
6) apply this patch against /usr/sbin/koha-stop-zebra
7) sudo koha-start-zebra {instance name}
8) ps aux | grep zebra
   -- the processes should have started up again.
9) add different junk to /var/log/koha/{instance name}/intranet-error.log
10) ps aux | grep zebra
11) logrotate -f /etc/logrotate.d/koha-common
12) ps aux | grep zebra
-- the process ids for the zebrasrv and daemon processes should
   be different, but the number of processes is the same as before.
13) sign off, because its less ugly than comment #3

Sponsored-by: Tulong Aklatan

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of stopping zebrasrv

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of stopping zebrasrv

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

--- Comment #4 from M. Tompsett  ---
Created attachment 53925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53925=edit
Bug 16885: koha-stop-zebra should be more sure of stopping zebrasrv

This patch actually loops 10 tens to check, before giving up.

TEST PLAN
-
1) Back up your koha logs as desired.
2) add something to /var/log/koha/{instance name}/intranet-error.log
3) ps aux | grep zebra
4) logrotate -f /etc/logrotate.d/koha-common
5) ps aux | grep zebra
   -- the zebrasrv and daemon process for zebra indexing
  didn't restart.
6) apply this patch against /usr/sbin/koha-stop-zebra
7) sudo koha-start-zebra {instance name}
8) ps aux | grep zebra
   -- the processes should have started up again.
9) add different junk to /var/log/koha/{instance name}/intranet-error.log
10) ps aux | grep zebra
11) logrotate -f /etc/logrotate.d/koha-common
12) ps aux | grep zebra
-- the process ids for the zebrasrv and daemon processes should
   be different, but the number of processes is the same as before.
13) sign off, because its less ugly than comment #3

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7441] Search results showing wrong branch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #79 from Katrin Fischer  ---
Jonathan, would you be ok with me testing with a UNIMARC sample database (from
the sandboxes I think)?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17034] Creating a new patron fails due to DB error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17034

--- Comment #2 from Chris Cormack  ---
This bug was caused by commit 878402689eb652b09bed0d4f2c7e458d5c5493f4

I think we need to revert this out on 16.05.x

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17034] Creating a new patron fails due to DB error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17034

Katrin Fischer  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
   ||, katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
It seems the column was introduced to the categories table by bug 6906 and
should not appear in 16.05 - maybe it slipped in somehow with another
patch/rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17033] Rotating Collection does not show on tools-home.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17033

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
It shows for me in both spots - the tools main page and the tools sitebar.
Maybe different permission checks?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter and update master version number

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
Were you thinking about bug 16724?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17034] New: Creating a new patron fails due to DB error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17034

Bug ID: 17034
   Summary: Creating a new patron fails due to DB error
 Change sponsored?: ---
   Product: Koha
   Version: 16.05
  Hardware: All
OS: Linux
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: c...@adamgoforth.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

After upgrading from Koha 16.05.01 to 16.05.02 with the Debian package,
creating a new patron via the web interface fails. After filling out and
submitting the form at
/cgi-bin/koha/members/memberentry.pl?op=add=OP this error is
displayed:

DBIx::Class::Row::store_column(): No such column 'checkprevcheckout' on
Koha::Schema::Result::Borrower at /usr/share/koha/lib/C4/Members.pm line 731

It seems that the problem is in line 727 of Members.pm:

$new_member->{checkprevcheckout} ||= 'inherit';

Commenting out this line allows the patron creation to finish normally.

The issue seems to be that the column "checkprevcheckout" does not exist in the
borrowers table and should not exist in this version of Koha. Apparently it was
added to master in bug 6906, and it shouldn't be in a public release until Koha
16.11.

Koha version: 16.05.02.000
OS: Debian 8.5

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6934] New report Cash Register Statistics

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #106 from Katrin Fischer  ---
Please take a look at comment#103 - comment#105 for a hopefully last follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Jiri Kozlovsky  changed:

   What|Removed |Added

  Attachment #53901|0   |1
is obsolete||

--- Comment #30 from Jiri Kozlovsky  ---
Created attachment 53924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53924=edit
[SIGNED-OFF] Bug 13895: Allow user to access their own checkouts and renew them

Let user access their own checkouts and if OpacRenewalAllowed system preference
is on, also let user to renew their checkouts.

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie) with a Patron that has no permissions. This Patron will be
   referred as "your patron" or "your borrowernumber" below.
2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace
   XXX with your borrowernumber) and check you receive correct data
3. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace
   XXX with someone else's borrowernumber) and check you get a permission
   error.
4. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an
   existing checkout id of your Patron) and check you receive correct data
5. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an
   existing checkout id of some other Patron) and check you get a permission
   error.
6. Send PUT request to http://yourlibrary/api/v1/checkouts/YYY, replace YYY
   with existing checkout id of some other Patron. You should get a permission
   error.
7. Set system preference OpacRenewalAllowed to 0.
8. Send PUT request to http://yourlibrary/api/v1/checkouts/YYY. YYY should be
   checkout id of checkout for your patron. You should get a permission error.
9. Set system preference OpacRenewalAllowed to 1.
10. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until
the maximum number of renewals is reached (you should have a 403
error). YYY should be checkout id of checkout for your patron.
11. Run unit tests in t/db_dependent/api/v1/checkouts.t

Signed-off-by: Jiri Kozlovsky 

Wow, works like magic! :) Nice job!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Jiri Kozlovsky  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16825] Add API route for getting an item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Jiri Kozlovsky  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16825] Add API route for getting an item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

--- Comment #11 from Jiri Kozlovsky  ---
Created attachment 53923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53923=edit
Bug 16825: [QA Follow-up] Add 'new_status' to Swagger definition

Adds missing "new_status" to item's Swagger definition.

Also, to avoid forgotten columns in definitions, adds a test to
compare item-definition to database's items-table.

To test:
1. Run t/db_dependent/api/v1/items.t

Signed-off-by: Jiri Kozlovsky 

Lari: You have probably changed in your comment bug ID for 16826
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825#c9

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Jiri Kozlovsky  changed:

   What|Removed |Added

  Attachment #53922|0   |1
is obsolete||

--- Comment #18 from Jiri Kozlovsky  ---
Comment on attachment 53922
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53922
Bug 16826: [QA Follow-up] Add 'new_status' to Swagger definition

Sorry about this patch, I've messed up bug id - had to be 16825 instead of
16826.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #17 from Jiri Kozlovsky  ---
Created attachment 53922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53922=edit
Bug 16826: [QA Follow-up] Add 'new_status' to Swagger definition

Adds missing "new_status" to item's Swagger definition.

Also, to avoid forgotten columns in definitions, adds a test to
compare item-definition to database's items-table.

To test:
1. Run t/db_dependent/api/v1/items.t

Signed-off-by: Jiri Kozlovsky 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17033] Rotating Collection does not show on tools-home.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17033

Barton Chittenden  changed:

   What|Removed |Added

   Severity|enhancement |trivial

--- Comment #1 from Barton Chittenden  ---
If you look at Home › Tools (cgi-bin/koha/tools/tools-home.pl), 'Rotating
Collection' does not show among the available cataloging tools.

If you navigate to another tool, e.g. Home › Tools › Batch item deletion
(cgi-bin/koha/tools/batchMod.pl), you will see the link to Rotating collections
on the left bar, pointing to
cgi-bin/koha/rotating_collections/rotatingCollections.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16464] If a patron has been discharged, show a message in the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #2 from M. Tompsett  ---
(In reply to Owen Leonard from comment #1)
> I'm working on this, but I'm not sure what the message should say. "Your
> account has been discharged?" "You have been discharged?"

I vote for the former, if that's any help. It's not like the person is fired.
;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17033] New: Rotating Collection does not show on tools-home.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17033

Bug ID: 17033
   Summary: Rotating Collection does not show on tools-home.pl
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903

Lari Taskula  changed:

   What|Removed |Added

 Blocks||17032


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032
[Bug 17032] REST API tests: Make sure Swagger object definition is up-to-date
with database
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Lari Taskula  changed:

   What|Removed |Added

 Blocks||17032


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032
[Bug 17032] REST API tests: Make sure Swagger object definition is up-to-date
with database
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object definition is up-to-date with database

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Lari Taskula  changed:

   What|Removed |Added

 Depends on||13799, 13903


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799
[Bug 13799] Add base for building RESTful API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903
[Bug 13903] Add API routes to list, create, update, delete holds
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16825] Add API route for getting an item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

--- Comment #10 from Lari Taskula  ---
I created Bug 17032 to add similar tests for what's already in master.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17032] New: REST API tests: Make sure Swagger object definition is up-to-date with database

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Bug ID: 17032
   Summary: REST API tests: Make sure Swagger object definition is
up-to-date with database
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: la...@student.uef.fi
QA Contact: testo...@bugs.koha-community.org

If a Swagger object definition is based on some database table, the definition
should be covered by tests to ensure that it is up-to-date with database.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16825] Add API route for getting an item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

--- Comment #9 from Lari Taskula  ---
Created attachment 53921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53921=edit
Bug 16826: [QA Follow-up] Add 'new_status' to Swagger definition

Adds missing "new_status" to item's Swagger definition.

Also, to avoid forgotten columns in definitions, adds a test to
compare item-definition to database's items-table.

To test:
1. Run t/db_dependent/api/v1/items.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16825] Add API route for getting an item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17017] Dependency fixes for 16.05

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

Frédéric Demians  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16960] Patron::Modifications should be fixed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #53657|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall  ---
Created attachment 53920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53920=edit
Bug 16960 - Patron::Modifications should be fixed

The changes from opac-memberentry do not reach the table, since the
Patron::Modifications object does not work well.

Test Plan:
1) Apply this patch
2) Create some patron modification requests
3) Ensure you can approve and deny modifications
4) Ensure patron self registration works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16960] Patron::Modifications should be fixed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

--- Comment #8 from Kyle M Hall  ---
(In reply to Marc Véron from comment #4)
> Hi Kyle,
> 
> Sorry, after applying the patch, I get an "Internal server error" on Home >
> Patrons (members-home.pl)
> 
> plack-error.log says:
> Can't locate object method "GetPendingModificationsCount" via package
> "Koha::Patron::Modifications" at /home/marc/koha/members/members-home.pl
> line 91.
> 
> git grep GetPendingModifications
> 
> members/members-home.pl: 
> Koha::Patron::Modifications->GetPendingModificationsCount( $branch );
> ^ Leads to error. If I fix this line, members-home.pl displays as expected
> 
> 
> t/db_dependent/Koha_borrower_modifications.t:'Add a new pending modification
> and test GetPendingModificationsCount() again'
> t/db_dependent/Koha_borrower_modifications.t:## Check GetPendingModifications
> marc@debian8vm:~/koha$ 
> ^ Inside comments, but I think it would be fine to change them for
> readability
> 
> Otherwise, sending an update request from OPAC and applying it from Staff
> client works OK.

This should now be fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16960] Patron::Modifications should be fixed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17017] Dependency fixes for 16.05

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

Frédéric Demians  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #7 from Frédéric Demians  ---
Done. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17017] Dependency fixes for 16.05

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

--- Comment #6 from Mirko Tietgen  ---
(In reply to Frédéric Demians from comment #4)

> Since this patch is directly related to the stable release process,
> including Debian packaging, I'm really tempted to push it directly into
> 16.05.x branch without QAing...


Katrin says it's ok

> (17:39:15) drojf: cait: bug 17017
> (17:39:34) drojf: i used it in the packages without even a signoff. any 
> objections to pushing it?
> (17:40:14) cait: nope - trusting you there

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6934] New report Cash Register Statistics

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #105 from Owen Leonard  ---
> But you do get that "active transaction" groups all transactions where
> patrons give money to the library, right ?

I don't think "active transaction" has any inherent meaning. What about
something like "All payments to the library" ?

Some other things I notice:

- The page is looking for datatables.js in the wrong place. It's now at
intranet-tmpl/prog/js/datatables.js.

- The table header "Patron cardnumber" should be "Patron card number."

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17031] New: Use delimeter system preference for Overdues report download

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17031

Bug ID: 17031
   Summary: Use delimeter system preference for Overdues report
download
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

The delimiter system preference should be used to choose the separator to be
used for the data exported from circulation > overdues (overdue.pl).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17017] Dependency fixes for 16.05

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

Mirko Tietgen  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16588

--- Comment #5 from Mirko Tietgen  ---
(In reply to Frédéric Demians from comment #2)
> Isn't it also required for master?

Readonly will be removed from master, see bug 16588.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16588] libreadonly-perl (and libreadonly-xs-perl) need to be added as dependencies

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588

Mirko Tietgen  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17017

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17017] Dependency fixes for 16.05

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

Frédéric Demians  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6934] New report Cash Register Statistics

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #104 from Katrin Fischer  ---
I think that sounds more logical! Also safer with the option of new types being
added - not so likely we change the types for paying and credit.

Maybe we could also think about a more 'speaking' name.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17017] Dependency fixes for 16.05

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

--- Comment #4 from Frédéric Demians  ---
Since this patch is directly related to the stable release process, including
Debian packaging, I'm really tempted to push it directly into 16.05.x branch
without QAing...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17017] Dependency fixes for 16.05

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #53902|0   |1
is obsolete||

--- Comment #3 from Frédéric Demians  ---
Created attachment 53919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53919=edit
Bug 17017 Dependency fixes for 16.05

Things I did for 16.05.02. Should go in 16.05.03.

Adds to PerlDependencies.pm:

IO::Socket::IP
Readonly
Readonly::XS

Adds overrides to debian/list-deps:

IO::Socket::IP => 'perl-modules (>= 5.20.0) | libio-socket-ip-perl'
Swagger2 => 'libswagger2-perl (>= 0.59)'

and an up to date debian/control based on that.

Signed-off-by: Frédéric Demians 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of stopping zebrasrv

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

Marcel de Rooy  changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com

--- Comment #3 from Marcel de Rooy  ---
>From Philippe Blouin on the dev ml:
=== QUOTE
We've had this problem on 10% of our installations.  I solved it by 
 going nuclear with logrotate since that was really hurting the users to 
 not have zebra working (it would appear like working on our monitor, but 
 was actually just dying and restarting).

 Here is the postrotate I've end up with, after many iterations of Next 
 Level Apocalypse You :)

  postrotate
  service apache2 reload
  find /etc/init.d/ -name "*zebra-daemon" -exec bash -c 'service 
 "$(basename "$0")" stop' {} \;
  sleep 3
  find /etc/init.d/ -name "*zebra-daemon" -exec bash -c 'service 
 "$(basename "$0")" stop' {} \;
  sleep 3
  pkill -9 zebra
  sleep 2
  pkill -9 zebra
  sleep 2
  find /etc/init.d/ -name "*zebra-daemon" -exec bash -c 'service 
 "$(basename "$0")" start' {} \;
  endscript

 As you see, no subtlety, but I've had no problem for a year now...
== END QUOTE

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17030] New: Configure the REST api on packages install

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Bug ID: 17030
   Summary: Configure the REST api on packages install
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: mi...@abunchofthings.net

This should've been implemented a while back, so we start taking advantage of
the REST api in the UI.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17017] Dependency fixes for 16.05

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

--- Comment #2 from Frédéric Demians  ---
(In reply to Mirko Tietgen from comment #0)
> Things I did for 16.05.02. Should go in 16.05.03.

Isn't it also required for master?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17030] Configure the REST api on packages install

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17027] control file update for 3.22

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17027

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

--- Comment #38 from Mehdi Hamidi  ---
Created attachment 53913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53913=edit
Bug 12446 - QA Follow-up

- Added missing icon on add gurantee
- Removed category restriction when adding new guarentee
- Put back some deleted entries while fixing merging conflicts.
- Fixed some typing errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17027] control file update for 3.22

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17027

Mirko Tietgen  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||julian.maur...@biblibre.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #32 from Kyle M Hall  ---
Followup has been pushed to master for Koha 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17020] findborrower is not used in circulation.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17020

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17020] findborrower is not used in circulation.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17020

--- Comment #1 from Jonathan Druart  
---
Created attachment 53905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53905=edit
Bug 17020: Do no pass findborrower to the template

Indeed, it's not used!

Test plan:
  git grep '\[% findborrower'
should not return any result.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17027] control file update for 3.22

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17027

Mirko Tietgen  changed:

   What|Removed |Added

Summary|contril file update for |control file update for
   |3.22|3.22

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17027] contril file update for 3.22

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17027

--- Comment #1 from Mirko Tietgen  ---
Created attachment 53904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53904=edit
Bug 17027

I updated the control file for 3.22.09.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17027] New: contril file update for 3.22

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17027

Bug ID: 17027
   Summary: contril file update for 3.22
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mi...@abunchofthings.net
QA Contact: testo...@bugs.koha-community.org
CC: mi...@abunchofthings.net

I updated the control file for 3.22.09. This should go in 3.22.10.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6934] New report Cash Register Statistics

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #103 from Francois Charbonnier  
---
(In reply to Katrin Fischer from comment #102)
> (In reply to Francois Charbonnier from comment #96)
> > (In reply to Katrin Fischer from comment #59)
> > 
> > > - What is the definition of an "Active transaction"? (was not clear to me,
> > > so asking :) )
> > 
> > The idea behind "Active transactions" is to help balance cash register
> > transactions. In other words, how much goes in or how much goes out the cash
> > register. The active transactions group what patrons paid or gave as credit
> > to the library, which means what went IN the register.
> > 
> > The code works this way : it takes all transactions where account types  are
> > NOT "F" (Fine), "FU" (Fine unpaid), "FOR" (Forgiven), "M" (Sundry), "L"
> > (Lost).
> 
> Sorry, I still don't get it :( The list of excluded fine types looks a bit
> arbitrary to me - what about custom MANUAL_INV values? And what is left by
> excluding those?

Hey Katrin,

But you do get that "active transaction" groups all transactions where patrons
give money to the library, right ?

The logic should be different. What do you think of grouping the relevant
account types, "Pay" and "C" (are there other?) instead of excluding this list?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16478] Translation breaks display of Checkout history in tab Checkouts / On-site-checkouts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||14568

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14416] Stored XSS flaw affects OPAC and Staff interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14416

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||14568

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16478] Translation breaks display of Checkout history in tab Checkouts / On-site-checkouts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|14568   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16599] XSS found in opac-shareshelf.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16599

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||14568

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14423] Multiple XSS and XSRF issues in Staff Client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14423

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||14568

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|14568   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17020] New: findborrower is not used in circulation.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17020

Bug ID: 17020
   Summary: findborrower is not used in circulation.tt
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

It's passed to the template but never used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17019] debian/changelog update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019

Mirko Tietgen  changed:

   What|Removed |Added

 CC||frede...@tamil.fr
 Status|NEW |Needs Signoff

--- Comment #2 from Mirko Tietgen  ---
Should go in 16.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17019] debian/changelog update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019

--- Comment #1 from Mirko Tietgen  ---
Created attachment 53903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53903=edit
Bug 17019 - debian/changelog update

This has not been updated for a while. I plan to add the stable releases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17019] debian/changelog update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019

Mirko Tietgen  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |mi...@abunchofthings.net
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17019] New: debian/changelog update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019

Bug ID: 17019
   Summary: debian/changelog update
 Change sponsored?: ---
   Product: Koha
   Version: 16.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mi...@abunchofthings.net
QA Contact: testo...@bugs.koha-community.org
CC: mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17017] Dependency fixes for 16.05

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

Mirko Tietgen  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17017] Dependency fixes for 16.05

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

Mirko Tietgen  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17017] Dependency fixes for 16.05

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

--- Comment #1 from Mirko Tietgen  ---
Created attachment 53902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53902=edit
Bug 17017 Dependency fixes for 16.05

Things I did for 16.05.02. Should go in 16.05.03.

Adds to PerlDependencies.pm:

IO::Socket::IP
Readonly
Readonly::XS

Adds overrides to debian/list-deps:

IO::Socket::IP => 'perl-modules (>= 5.20.0) | libio-socket-ip-perl'
Swagger2 => 'libswagger2-perl (>= 0.59)'

and an up to date debian/control based on that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Lari Taskula  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #29 from Lari Taskula  ---
Created attachment 53901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53901=edit
Bug 13895: Allow user to access their own checkouts and renew them

Let user access their own checkouts and if OpacRenewalAllowed system preference
is on, also let user to renew their checkouts.

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie) with a Patron that has no permissions. This Patron will be
   referred as "your patron" or "your borrowernumber" below.
2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace
   XXX with your borrowernumber) and check you receive correct data
3. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace
   XXX with someone else's borrowernumber) and check you get a permission
   error.
4. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an
   existing checkout id of your Patron) and check you receive correct data
5. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an
   existing checkout id of some other Patron) and check you get a permission
   error.
6. Send PUT request to http://yourlibrary/api/v1/checkouts/YYY, replace YYY
   with existing checkout id of some other Patron. You should get a permission
   error.
7. Set system preference OpacRenewalAllowed to 0.
8. Send PUT request to http://yourlibrary/api/v1/checkouts/YYY. YYY should be
   checkout id of checkout for your patron. You should get a permission error.
9. Set system preference OpacRenewalAllowed to 1.
10. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until
the maximum number of renewals is reached (you should have a 403
error). YYY should be checkout id of checkout for your patron.
11. Run unit tests in t/db_dependent/api/v1/checkouts.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17018] New: Split AdvancedSearchTypes for staff and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018

Bug ID: 17018
   Summary: Split AdvancedSearchTypes for staff and OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

It would be nice if you could configure AdvancedSearchTypes differently for
staff and opac advanced search.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #54 from Jonathan Druart  
---
Created attachment 53900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53900=edit
Bug 15758: Koha::Libraries - Do not select an option if selected is defined

This will certainly need a few more tweaks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #53 from Jonathan Druart  
---
Created attachment 53899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53899=edit
Bug 15758: Koha::Libraries - Add tests for the Branches TT plugin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #50 from Jonathan Druart  
---
Created attachment 53896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53896=edit
Bug 15758: Koha::Libraries - Remove GetBranches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #52 from Jonathan Druart  
---
Created attachment 53898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53898=edit
Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #49 from Jonathan Druart  
---
Created attachment 53895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53895=edit
Bug 15758: Koha::Libraries - Move mybranch to C4::Context

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #51 from Jonathan Druart  
---
Created attachment 53897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53897=edit
Bug 15758: Koha::Libraries - Move onlymine to C4::Context::only_my_library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52913|0   |1
is obsolete||
  Attachment #52914|0   |1
is obsolete||
  Attachment #52915|0   |1
is obsolete||
  Attachment #52916|0   |1
is obsolete||
  Attachment #52917|0   |1
is obsolete||
  Attachment #52918|0   |1
is obsolete||
  Attachment #52919|0   |1
is obsolete||
  Attachment #52920|0   |1
is obsolete||

--- Comment #47 from Jonathan Druart  
---
Created attachment 53893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53893=edit
Bug 15758: Koha::Libraries - Remove GetBranchName

This is the fourth and last patch set to remove C4::Branch.
The real purpose of this patch is to standardise and refactor some code
which is related to the libraries selection/display.
Its unconfessed purpose is to remove the C4::Branch package.

Before this patch set, only 6 subroutines still existed in the C4::Branch
package:
- GetBranchName
- GetBranchesLoop
- mybranch
- onlymine
- GetBranches
- GetBranch

GetBranchName basically returns the branchname for a given branchcode.
The branchname is only used for a display purpose and we don't need to
retrieve it in package or pl scripts (unless for a few exceptions).
We have a `Branches` template plugin with a `GetName` method which does
exactly this job.
To achieve this removal, we will use this template plugin and delete the
GetBranchName from pl and pm files.
The `Branches.all()` will now select the library of the logged in user
if no `selected` parameter has been passed.
This new behavior could cause regressions, for instance there are some
places where we do not want an option preselected (batch item
modification for instance), keep that in mind when testing.

GetBranchesLoop took 3 parameters: $branch and $onlymine.
The first one was used to set a "selected" flag, for a display purpose:
select an option in the libraries dropdown lists.
The second one was useless: If not passed or set to 0, the
`C4::Branch::onlymine` subroutine was called.
This onlymine flag was use to know if the logged in user was able to see
other libraries infos.
A patron can see the infos from other libraries if IndependentBranches
is not set OR if he has the superlibrarian permission.
Prior to this patch set, the "onlymine test" was done on different
places (neworderempty.pl, additem.pl, holidays.pl, etc.), including the
Branches TT plugin. In this patch set, this test is only done on one
place (C4::Context::only_my_library, code moved from
C4::Branch::onlymine).
To accomplish the same job as this subroutine, we just need to call the
`Branches.all()` method from the `Branches` TT plugin. It already
accepts a `selected` parameter to set a flag on the option to select.
To avoid the repetitive
  [% IF selected %][% ELSE %][% END %]
pattern, a new `html_helpers` TT include file has been created, it
defines an `options_for_libraries` block, which takes a `selected`
parameter. We could imagine to use this include file for other
selects.

The 'mybranch` and `onlymine` subroutines of the C4::Branch package have
been moved to C4::Context. onlymine has been renamed with
only_my_library. There are only 4 occurrences of it, against 11 before
this patch set.
There 2 subroutines are Context-centric and it makes sense to put them
in `C4::Context` (at least it's the least worst place!)

GetBranches is the tricky part of this patch set: It retrieves all the
libraries, independently of the value of IndependentBranches.
To keep the same way as the existing calls of `Branches.all()`, I have
added a `unfiltered` parameter. If set, the `Branches.all()` will call
a usual Koha::Libraries->search method, otherwise
Koha::Libraries->search_filtered will be called. This new method will
check if the logged in user is allowed to see other libraries or only
its library.
Note that this `GetBranches` subroutine also created a `category` key:
it allowed to get the list of groups (of libraries) where this library
existed. Thanks to a previous patch set (bug 15295), this value was
not used anymore (I may have missed something!).

Note that the only use of `GetBranch` was buggy (see bug 15746).

Test plan (for the whole patch set):
The best way to test this whole patch set is to test with 2 instances: 1
with the patch set applied, 

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #48 from Jonathan Druart  
---
Created attachment 53894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53894=edit
Bug 15758: Koha::Libraries - Remove GetBranchesLoop

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53423|0   |1
is obsolete||

--- Comment #53 from Jonathan Druart  
---
Created attachment 53892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53892=edit
Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType

This unnecessary complicated subroutine returned an arrayref and an
hashref of the patron categories available for the logged in user, for a given
category_type, ordered by categorycode.
This can now be done with the search_limited method.

Test plan:
- Same prerequisite as before
For the following pages, you should not see patron categories limited to other
libraries. They should be ordered as before this patch, by categorycode.
- Add/edit a patron, change his/her patron category value.
- On the 3 following reports:
reports/bor_issues_top.pl
reports/borrowers_out.pl
reports/cat_issues_top.pl
The display for these 3 reports are different than the 2 from the first
patch (borrowers_stats.pl issues_avg_stats.pl): they are ordered by
categorycode and the ones limited to other libraries are not displayed
(should certainly be fixed).

Note that the big part of this patch has already been tested before
(update child related: CATCODE_MULTI).

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a rental charge

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796

--- Comment #14 from Owen Leonard  ---
I think Variant III is the best.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17017] Dependency fixes for 16.05

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

Mirko Tietgen  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |mi...@abunchofthings.net
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17017] New: Dependency fixes for 16.05

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017

Bug ID: 17017
   Summary: Dependency fixes for 16.05
 Change sponsored?: ---
   Product: Koha
   Version: 16.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mi...@abunchofthings.net
QA Contact: testo...@bugs.koha-community.org
CC: mi...@abunchofthings.net

Things I did for 16.05.02. Should go in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16829] action_logs should have an 'interface' column

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #11 from Jonathan Druart  
---
Tomás, don't you think we should try and fill the interface column for existing
values?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #4 from Jonathan Druart  
---
CONFLICT (content): Merge conflict in
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
CONFLICT (content): Merge conflict in C4/Letters.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter and update master version number

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

--- Comment #5 from Mirko Tietgen  ---
(In reply to Jonathan Druart from comment #4)

> Should not we create a subroutine to guess the version?
> Otherwise we will have to update it every 6 months :)

I think we did something similar in some other place. Do you remember where?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16825] Add API route for getting an item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #8 from Jonathan Druart  
---
items.new_status is missing in the swagger file.
Please have a look at bug 15126 comment 53.
We need a way to keep this file up-to-date.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15126] REST API: Use newer version of Swagger2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126

--- Comment #53 from Jonathan Druart  
---
(In reply to Tomás Cohen Arazi from comment #40)
> (In reply to Jonathan Druart from comment #38)
> > (In reply to Julian Maurice from comment #32)
> > > Created attachment 50142 [details] [review] [review] [review]
> > > Bug 15126: Update patron definition
> > 
> > Julian, I think we need tests to make sure the swagger file will be always
> > up-to-date with the DB structure. Any ideas how we could do that?
> 
> Maybe that should be a coding guideline/QA requisite, that every endpoint
> has a proper set of unit tests, including this check on the swagger files.
> I'd vote for discussing this on the next dev meeting to gather broader
> opinions.

This has never been done and the json file is not up-to-date: checkprevcheckout
and updated_on are missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #28 from Lari Taskula  ---
What about user who does not have 'circulate_remaining_permissions' permission,
but wants to access his own checkouts or renew his own checkouts if
OpacRenewalAllowed is on?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Mehdi Hamidi  changed:

   What|Removed |Added

 CC||eric.be...@inlibro.com,
   ||francois.charbonnier@inlibr
   ||o.com,
   ||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Lari Taskula  changed:

   What|Removed |Added

  Attachment #53889|0   |1
is obsolete||

--- Comment #27 from Lari Taskula  ---
Created attachment 53891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53891=edit
[SIGNED-OFF] Bug 13895: Fixed QA demands

Signed-off-by: Frédéric Demians 
  Fix QA, and fix tests failing

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Lari Taskula  changed:

   What|Removed |Added

  Attachment #51303|0   |1
is obsolete||

--- Comment #26 from Lari Taskula  ---
Created attachment 53890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53890=edit
[SIGNED-OFF] Bug 13895: Add API routes for checkouts retrieval and renewal

GET /checkouts?borrowernumber={borrowernumber}
GET /checkouts/{checkout_id}
PUT /checkouts/{checkout_id}

+ unit tests in t/db_dependent/api/v1/checkouts.t

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie). You should have permission circulate_remaining_permissions.
2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace
   XXX with a borrowernumber that has checkouts) and check you receive
   correct data
3. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an
   existing checkout id) and check you receive correct data
4. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until
   the maximum number of renewals is reached (you should have a 403
   error)
5. Run unit tests in t/db_dependent/api/v1/checkouts.t

Depends on bug 15126

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #53878|0   |1
is obsolete||

--- Comment #25 from Frédéric Demians  ---
Created attachment 53889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53889=edit
Bug 13895: Fixed QA demands

Signed-off-by: Frédéric Demians 
  Fix QA, and fix tests failing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter and update master version number

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013

--- Comment #4 from Jonathan Druart  
---
Comment on attachment 53869
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53869
Bug 17013 - build-git-snapshot: add basetgz parameter and update master version
number

Review of attachment 53869:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=17013=53869)
-

::: debian/build-git-snapshot
@@ +31,4 @@
>  my $buildresult;
>  my $distribution='squeeze-dev';
>  my $git_checks='all';
> +my $version='16.06~git';

Should not we create a subroutine to guess the version?
Otherwise we will have to update it every 6 months :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16978] Add delete reports user permission

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53741|0   |1
is obsolete||
  Attachment #53871|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  
---
Created attachment 53887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53887=edit
Bug 16978: Add delete reports user permission

This splits off the delete capability from the create reports permission.
>From a UI perspective there were CSS issues, that this patch set hackily
bypasses. Perhaps someone else can amend this enhancement with the required
changes so that the extra column at the beginning of the table can be
removed when the user does not have delete capability.

TEST PLAN
-
1) back up db
2) apply patch
3) ./installer/data/mysql/updatedatabase.pl
   -- should run without issue.
4) in mysql:
   > drop database ...
   > create database ...
   -- totally blanks it for fresh web install
5) run web install
   -- installing should have no issues
6) go to a patron
7) set permissions
8) expand the reports permission
   -- should have delete reports now
9) click help and scroll down to
   'Granular Reports Permissions' right at the bottom.
   -- there should be a new delete_reports section
10) Head over to guided reports and build a few reports.
-- as system account user, delete stuff should all be visible.
11) Find a patron, set all permissions, except delete reports.
12) log out and then log in as the modified patron
13) Head over the save reports
-- none of the delete options should be available to the user.
14) run koha qa test tools
15) restore db

Followed test plan. Additionally tried to delete using params in URL
(not possible, OK)
Signed-off-by: Marc 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16978] Add delete reports user permission

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/