[Koha-bugs] [Bug 17121] debian/control.in update: change maintainer for 3.22.x

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17121

--- Comment #7 from Mirko Tietgen  ---
Thanks for testing! Changes to debian/control are in bug 17111, which is (will
be) generated automatically when there are changes. This bug is only about
having the change in the control.in file. Please sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17121] debian/control.in update: change maintainer for 3.22.x

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17121

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #6 from M. Tompsett  ---
(In reply to Mirko Tietgen from comment #2)
[SNIP]
> The result of git diff should be two changes in debian/control:
[SNIP]

This test plan works for debian/control.in, but following build instructions
from
https://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Way
would mean you should make the same change to the debian/control not just
debian/control.in, which this patch has. I'm not sure how the .in progresses to
the non-in version, so I can't sign this off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17327] Item level holds no longer enforced

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327

Benjamin Rokseth  changed:

   What|Removed |Added

 CC||benjamin.roks...@kul.oslo.k
   ||ommune.no
 Status|Needs Signoff   |Signed Off

--- Comment #5 from Benjamin Rokseth  ---
Tests ok.
patron without holds -> both item and record level allowed
patron with record level hold -> only record hold allowed
patron with item level hold -> only item hold allowed

How item/record level holds should be enforced by circulation rules is probably
the scope of another bug, as this needs to be pushed to master quickly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17327] Item level holds no longer enforced

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #55745|0   |1
is obsolete||

--- Comment #4 from Benjamin Rokseth  ---
Created attachment 55762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55762=edit
Bug 17327 - Item level holds no longer enforced

Reported by Katrin:

Example:
- on shelf holds allowed
- holds allowed 5
- holds on same record allowed 5
- FORCE item level holds

On a record with only one item, you can only place a record level hold
in OPAC now - which is against your circulation conditions.

Another example:
- record with 2 items
- circulation rules as above, 1 hold allowed on the record
- Item level holds: forced

I can only place record level holds in OPAC and staff. At the moment, I
am not able to place item level holds in any circumstances in my
installation.

Test Plan:
1) Apply the unit test patch
2) prove t/db_dependent/Reserves/MultiplePerRecord.t
   should fail
3) Apply the second patch
4) prove t/db_dependent/Reserves/MultiplePerRecord.t
   should pass
5) Attempt to replicate one of the examples above, you should be unable to

Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17327] Item level holds no longer enforced

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #55744|0   |1
is obsolete||

--- Comment #3 from Benjamin Rokseth  ---
Created attachment 55761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55761=edit
Bug 17327 - Add unit test for regression

Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17307] Some edit buttons/ links for patrons do not work without a categorycode in the URL

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17307

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #55732|0   |1
is obsolete||

--- Comment #9 from Benjamin Rokseth  ---
Created attachment 55760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55760=edit
Bug 17307: Smaller counter-patch

Given that the issue is trying to call a method on something that isn't
an object, because the category code doesn't exist, then why is it
even trying to change the expiry date? A simple postfix if fixes it.

Applied counter-patch by M. Tompsett. All three patron 'Edit' links
mentioned in previous patch's test plan work fine.

Signed-off-by: Andreas Roussos 
Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17307] Some edit buttons/ links for patrons do not work without a categorycode in the URL

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17307

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com

--- Comment #8 from Héctor Eduardo Castro Avalos  ---
Good Catch, Andreas

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17318] Make 'Normalization rule' configurable on matchpoint definition

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17318

Tom Misilo  changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com,
   ||tomasco...@gmail.com
 Status|NEW |In Discussion

--- Comment #7 from Tomás Cohen Arazi  ---
Bug 17318 introduces new normalization routines (including the misterious
option 'None') which could be considered a solution to this bug, and probably
also 15541.

Kyle, Galen, David: would you agree on closing this one as duplicate of bug
17318?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14668] Show serial enumeration in the patron's opac checkout summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #55758|0   |1
is obsolete||

--- Comment #15 from Héctor Eduardo Castro Avalos  
---
Created attachment 55759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55759=edit
[SIGNED-OFF]Bug 14668: (follow-up) JSON fails if single quotes are used

Change single quotes to double quotes also add brackets to serial
enumeration.

To test follow previous test plan for intranet.
Fix double semicolon

Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14668] Show serial enumeration in the patron's opac checkout summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14668] Show serial enumeration in the patron's opac checkout summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #55756|0   |1
is obsolete||

--- Comment #14 from Héctor Eduardo Castro Avalos  
---
Created attachment 55758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55758=edit
[SIGNED-OFF]Bug 14668: (follow-up) JSON fails if single quotes are used

Change single quotes to double quotes also add brackets to serial
enumeration.

To test follow previous test plan for intranet.

Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14668] Show serial enumeration in the patron's opac checkout summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #53448|0   |1
is obsolete||

--- Comment #13 from Héctor Eduardo Castro Avalos  
---
Created attachment 55757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55757=edit
[SIGNED-OFF]Bug 14668: Show serial enumeration in INTRANET circulation.tt and
OPAC patron's relatives' checkouts

TEST PLAN

1. THE CHECKOUT TAB, INTRANET
1.1. Add a value to the 'h' subfield of an item. ie: 'volume #42'
1.2. Check out the item to a patron
1.3. Display this patron's issues in his checkout page
1.3.1. The enumchron should be concatenated with the title

2. A PATRON'S RELATIVE, INTRANET + OPAC
1.1. Add somebody to a patron's guarantee list
1.2. Checkout a serial to this guarantee
1.3. Visit the guarantor's OPAC and INTRANET checkout page
1.3.1. You should see the enumchron in his guarantee's issues

Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14668] Show serial enumeration in the patron's opac checkout summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668

--- Comment #12 from Héctor Eduardo Castro Avalos  
---
Created attachment 55756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55756=edit
Bug 14668: (follow-up) JSON fails if single quotes are used

Change single quotes to double quotes also add brackets to serial
enumeration.

To test follow previous test plan for intranet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17318] Make 'Normalization rule' configurable on matchpoint definition

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17318

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #55740|0   |1
is obsolete||

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 55754
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55754=edit
Bug 17318: Make C4::Matcher::_get_match_keys handle 'norms' param

The current implementation doesn't care about that parameter, and applies
a default normalization rule that seems counter-productive (in general) for
its aleged purpose.

This patch makes it handle the following values for 'norms':

- upper_case
- lower_case
- remove_spaces
- legacy_default
- none

They make it call the relevant Koha::Utils::Normalize routines.
'legacy_default'
is used only for backwards compatibility, but could be removed if there's
consensus.

To test:
- Run:
  $ prove t/Matcher.t
=> FAIL: most _get_match_keys tests fail
- Apply the patch
- Run:
  $ prove t/Matcher.t
=> SUCCESS: Tests pass!
- Sign off :-D

Sponsored-by: FIT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17318] Make 'Normalization rule' configurable on matchpoint definition

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17318

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #55741|0   |1
is obsolete||

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 55755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55755=edit
Bug 17318: Allow chosing fixed normalization routines

This patch changes the matching-rules.pl page, so it allows the user to choose
from the different hardcoded normalization routines. It is done using TT blocks
and the routine descriptions are translatable.

To test:
- Create some matching rule
- Have free text values on the 'Normalization rule' field
- Apply the patches
- Create a new routine
=> SUCCESS: You can now only choose between fixed option
- Save the rule
- Open it for editing
=> SUCCESS: Chosen rules are preserved
- Edit the original free-text including rule
=> SUCCESS: Rules fall back to 'None'
- Sign off :-D

TODO: A followup will add a warning about the current value and the fact that
  saving the matching rule will overwrite those, with 'none'.

Sponsored-by: FIT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17318] Make 'Normalization rule' configurable on matchpoint definition

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17318

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #55720|0   |1
is obsolete||

--- Comment #6 from Tomás Cohen Arazi  ---
Created attachment 55753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55753=edit
Bug 17318: Unit tests

The current C4::Matcher::_get_match_keys implementation doesn't take
normalization rules params into account. This patch makes Matcher.t test the
proposed behaviour for new hardcoded values, that match string normalization
routines introduced by Bu 17302.

Possible values are:
- upper_case
- lower_case
- remove_spaces
- legacy_default
- none

* 'legacy_default' is left (for now) to catch the current behaviour. So tests
which
did not get a 'norm' param, now are passed 'legacy_default' and they still
pass.

* 'none' means no normalization, of course

Note: on introducing 'none', a bug got highlighted, because the subfields
traversal loop
was introducing an unneeded space. The tests from 17304 get adjusted to reflect
this.

To test:
- Run:
  $ sudo koha-shell kohadev ; cd kohaclone
  $ prove t/Matcher.t
=> FAIL: The routine doesn't care about the norms param.

Sponsored-by: FIT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17262] Plack on packages is not having memcached set properly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Stable

--- Comment #8 from Tomás Cohen Arazi  ---
This patch has been pushed to 16.05.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17262] Plack on packages is not having memcached set properly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17262] Plack on packages is not having memcached set properly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262

Tomás Cohen Arazi  changed:

   What|Removed |Added

Version|master  |16.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17258] [OMIBUS] MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

Blou  changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com

--- Comment #2 from Blou  ---
Bug 17328 - Koha fixes for Mysql 5.7

A mini omnibus as I go, with no other intent than report.  Sorry, didn't know
about this one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17328] Koha fixes for Mysql 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17328

Blou  changed:

   What|Removed |Added

  Attachment #55749|0   |1
is obsolete||

--- Comment #5 from Blou  ---
Created attachment 55752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55752=edit
Bug 17328 - borrowers.flags must be passed an integer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17328] Koha fixes for Mysql 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17328

--- Comment #4 from Zeno Tajoli  ---
Connect to the general bug 17258

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17317] Adding "bib" type to GetAvailability method for ILSDI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317

--- Comment #3 from Arthur Suzuki  ---
To test this patch you should try to send a query to you opac formatted this
way :
http://[your-opac-domain-name]/cgi-bin/koha/ilsdi.pl?service=GetAvailability=[biblionumber]_type=bib

You should get availability status for all the items of the matched
bibliographic record.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17328] Koha fixes for Mysql 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17328

Zeno Tajoli  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17258] [OMIBUS] MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

Zeno Tajoli  changed:

   What|Removed |Added

 Depends on||17328


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17328
[Bug 17328] Koha fixes for Mysql 5.7
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17328] Koha fixes for Mysql 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17328

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it
 Blocks||17258


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
[Bug 17258] [OMIBUS] MySQL 5.7
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17328] Koha fixes for Mysql 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17328

--- Comment #3 from Blou  ---
Created attachment 55751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55751=edit
Bug 17328 - categories' many int fields cannot be NULL

This fixes the code, but the DB should also be fixed with default values.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17083] Remove more event attributes from tools templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083

Owen Leonard  changed:

   What|Removed |Added

  Attachment #54435|0   |1
is obsolete||

--- Comment #4 from Owen Leonard  ---
Created attachment 55750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55750=edit
[PASSED QA] Bug 17083: Remove more event attributes from tools templates

This patch removes event attributes from several tool-related templates.
Events are defined instead in the JavaScript.

To test, apply the patch and:

- Go to Tools -> Label creator -> Manage -> Layouts and edit any layout.
  - In the "Font" setting, choose any font which includes the word
"italic" or "oblique" in the name. Doing so should disable the
"Oblique title" checkbox.
- Go to Tools -> Batch patron deletion/anonymization.
  - Submit the form without making any changes. You should be prompted
to select an action.
- Go to Tools -> Inventory.
  - Select a batch of barcodes to upload.
  - Submit the form without selecting any filters. This should trigger a
warning.
  - Also changed: Added Font Awesome icons to the "Select all" and
"Clear all" links on the inventory results view.
- Go to Tools -> Notices and Slips.
  - Click "New notice"
  - Change the selection under "Koha module." The page should reload
with the correct available message body fields. For instance,
selecting "Holds" should make available reserves.* columns.
- Go to Tools -> Upload.
  - In the search form, enter a search term and click the 'Search'
button. The form should submit.

Signed-off-by: Hector Castro 
Works as advertised. Event attributes removed

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17083] Remove more event attributes from tools templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17328] Koha fixes for Mysql 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17328

--- Comment #2 from Blou  ---
Created attachment 55749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55749=edit
Bug 17328 - borrowers.flags must be passed an integer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17238] Warnings in gather_print_notices.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17238

Blou  changed:

   What|Removed |Added

  Attachment #55747|0   |1
is obsolete||

--- Comment #4 from Blou  ---
Comment on attachment 55747
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55747
Bug 17328 - import_records.marcxml_old requires a value

Apologies, wrong ticket.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17328] Koha fixes for Mysql 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17328

--- Comment #1 from Blou  ---
Created attachment 55748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55748=edit
Bug 17328 - import_records.marcxml_old requires a value

https://bugs.koha-community.org/show_bug.cgi?id=17238

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17238] Warnings in gather_print_notices.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17238

--- Comment #3 from Blou  ---
Created attachment 55747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55747=edit
Bug 17328 - import_records.marcxml_old requires a value

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17328] Koha fixes for Mysql 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17328

Blou  changed:

   What|Removed |Added

 CC||eric.be...@inlibro.com,
   ||francois.charbonnier@inlibr
   ||o.com
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17328] Koha fixes for Mysql 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17328

Blou  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17328] New: Koha fixes for Mysql 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17328

Bug ID: 17328
   Summary: Koha fixes for Mysql 5.7
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: MARC Bibliographic record staging/import
  Assignee: gmcha...@gmail.com
  Reporter: philippe.blo...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

I'm accruing many little issues. while running the code.  I'll put the patches
in, at least to document them.  If the powers-that-be decide to fix in
differently, all the same to me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

--- Comment #28 from Marc Véron  ---
Hi Nicholas

The qa tool no longer complains.

I re-tested with following scenario (restart plack after each change to
syspref):

- Client's IP is 192.168.1.32

- SelfCheckAllowByIPRanges is empty
  go to  .../cgi-bin/koha/sco/sco-main.pl OK for all IPs

- Set SelfCheckAllowByIPRanges to 192.168.1.32
  Allowed for client OK
  Client with other IP redirected to OPAC main page OK

- Set SelfCheckAllowByIPRanges to 192.168
  Allowed for client OK
  Client with other IP redirected to OPAC main page OK

- Set SelfCheckAllowByIPRanges to 192.168.1.32 192.168.1.30 192.168.1.10
  Allowed for client OK
  Client with other IP redirected to OPAC main page OK

- Set SelfCheckAllowByIPRanges to 192.168.1.15 192.168.1.30 192.168.1.10
  Client redirected to OPAC main page OK
  Client with other IP redirected to OPAC main page OK 

- Set SelfCheckAllowByIPRanges to 192.168.1.1 192.168.1.0/36
  as described for syspref SelfCheckAllowByIPRanges
  Internal Server Error
  Plack error log says;
  36, as in '192.168.1.30/36', does not make sense at
/home/marc/koha/C4/Auth.pm line 2058.

Is it a bug or a wrong description for SelfCheckAllowByIPRanges?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17326] Koha not asking if the book is to be renewed when max book limit is reached

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17326

daltonfur...@gmail.com changed:

   What|Removed |Added

Summary|KOha not asking if the book |Koha not asking if the book
   |is to be renewed when max   |is to be renewed when max
   |book limit is reached   |book limit is reached

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

Nicholas van Oudtshoorn  changed:

   What|Removed |Added

  Attachment #54560|0   |1
is obsolete||

--- Comment #27 from Nicholas van Oudtshoorn  ---
Created attachment 55746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55746=edit
Latest version of patch, with errors fixed

Thanks for that Marc. Hopefully all of those mistakes have now been rectified!
:-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Frédéric Demians  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #57 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11921] memcached configuration should be moved back to koha-conf.xml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #33 from Frédéric Demians  ---
Jonathan, don't you think pushing those patches to 16.05 would be highly
risky? I can see the issue in 16.05 concerning the way memcached server is
retrieved. With Plack enabled, memcached server is just not used whether you
don't export MEMCACHED_SERVERS in shell environment before starting Plack. But
isn't the patch for bug 17262 more secure for 16.05? because it doesn't affect
that much code in Koha inner modules?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/