date:20161205

[Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only)

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #8 from Josef Moravec  ---
Sorry, QA tool complains:

 FAIL  
koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-de.inc
   FAIL   tt_valid
lines 12, 47, 72, 84

 FAIL  
koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-contact-style-de.inc
   FAIL   tt_valid
lines 36, 60, 72

 FAIL  
koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc
   FAIL   tt_valid
lines 35, 47, 71, 83

It's related to HTML1 point of coding guidelines I think.

But the functionality is OK so, when you fix this, I am going to sign-off ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17725] New: Repeating a field or subfield clones content

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725

Bug ID: 17725
   Summary: Repeating a field or subfield clones content
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

To replicate:
- Open an existing record in your catalog
- Create another field or subfield of a field/subfield already used using the
icon to repeat it
- Verify that the content is copied over
- Verify this happens for input (one line) and textare (multiple lines)

I can't make this happen for when creating a new record, but more consistently
on editing existing records.

This is rather annoying when cataloguing in Koha, as the cataloguer has to
empty the field first and that adds an extra step for each repeated field.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16723] Add additional subscription fields to serial claim notices

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16723
Bug 16723 depends on bug 10855, which changed state.

Bug 10855 Summary: Custom fields for subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

   What|Removed |Added

 Status|Pushed to Master|CLOSED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16565] additional_fields and additional_field_values are not dropped in kohastructure.sql

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565
Bug 16565 depends on bug 10855, which changed state.

Bug 10855 Summary: Custom fields for subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

   What|Removed |Added

 Status|Pushed to Master|CLOSED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Custom fields for subscriptions

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Master|CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11844] Additional fields for order lines

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844
Bug 11844 depends on bug 10855, which changed state.

Bug 10855 Summary: Custom fields for subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

   What|Removed |Added

 Status|Pushed to Master|CLOSED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17724] New: Callnumber not copied into serial issue, when callnumber subfield is linked to a plugin

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17724

Bug ID: 17724
   Summary: Callnumber not copied into serial issue, when
callnumber subfield is linked to a plugin
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

To test:
- Make sure your 952$o (callnumber) is linked to a plugin such as cn_browser.pl
in your frameworks
- Create a subscription with "create item on receive" and a callnumber
- Receive an issue
- Verify that the callnumber is not copied into the item on receive
- Remove the plugin from the framework
- Verify that the callnumber now is copied into the item on receive

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17580] Add the Koha::Patron->get_overdues method

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580

--- Comment #13 from Katrin Fischer  ---
There is a follow-up for this on the master branch with a wrong bug number. 
It won't be needed in stable releases:
 Bug 17586 [QA Followup] - Correct the number of unit tests
 46432511a600f0f22b35d004ee47eb573a33f94f

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17716] Remove itemtype-related t/db_dependent/ CourseReserves.t warnings

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17716

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Pushed to Master|Pushed to Stable

--- Comment #9 from Katrin Fischer  ---
These patches have been pushed to 16.11.x, will be in 16.11.01.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17715] Remove itemtype-related t/db_dependent/Holds/ RevertWaitingStatus.t warnings

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
This patch has been pushed to 16.11.x, will be in 16.11.01.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17714] Remove itemtype-related t/db_dependent/Members/* warnings

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17714

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Pushed to Master|Pushed to Stable

--- Comment #7 from Katrin Fischer  ---
This patch has been pushed to 16.11.x, will be in 16.11.01.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17713] Members.t is failing randomly

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||katrin.fisc...@bsz-bw.de

--- Comment #8 from Katrin Fischer  ---
This patch has been pushed to 16.11.x, will be in 16.11.01.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17720] CSRF token is not generated correctly

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Pushed to Master|Pushed to Stable

--- Comment #5 from Katrin Fischer  ---
This patch has been pushed to 16.11.x, will be in 16.11.01.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances.

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979

--- Comment #30 from Alex Buckley  ---
Re: Comment 29 

Hello Alex,

Patches are rebased on master. You can test again.



Thanks Alex. As I am new to Koha would it be possible to have a clearer test
plan for this patch for me to follow in my testing?

Cheers
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17722] t/db_dependent/PatronLists.t doesn't run inside a transaction

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17722] t/db_dependent/PatronLists.t doesn't run inside a transaction

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57968|0   |1
is obsolete||

--- Comment #2 from Josef Moravec  ---
Created attachment 57986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57986=edit
[SIGNED-OFF] Bug 17722: Make PatronLists.t run inside a transaction

This patch makes t/db_dependent/PatronLists.t run inside a transaction.
It also makes it generate its own data using t::lib::TestBuilder instead
of relying on sample patrons on the DB.

To test:
- Run:
  $ prove t/db_dependent/PatronLists.t
=> SUCCESS: Tests pass
- Apply the patch
- Run:
  $ prove t/db_dependent/PatronLists.t
=> SUCCESS: Tests pass
- Sign off :-D

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12027] Shibboleth authentication for staff client

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

mourik jan  changed:

   What|Removed |Added

 CC||heup...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16376] Koha::Calendar-> is_holiday date truncation creates fatal errors for TZ America/Santiago

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

--- Comment #21 from Tomás Cohen Arazi  ---
I spent a couple hours on this. And now have to leave for Manuel's birthday :-D
So, for the record:

- I narrowed the problem down to the sub days_between. Which is called in the
failing scripts. The only way to reproduce this (in order to create the unit
tests) was:

$ENV{TZ} = $timezone;
use POSIX qw(tzset);
tzset;
my $tz = C4::Context->tz;

my $chile_dt = DateTime->new(
day   => 6,
month => 9,
year  => 2015,
time_zone => $tz
);
my $now_dt = DateTime->now;

my $branch = $builder->build({ source => 'Branch' })->{branchcode};
my $calendar = Koha::Calendar->new( branchcode => $branch );
my $diff = $calendar->days_between($now_dt,$chile_dt);

Using the other suspected functions didn't trigger the problem
(exception_holidays, etc)[1]. So the problem was correctly highlighted by
David, but I'm not sure what's the best place to fix it. I vote for
days_between.

I'll try to resume tomorrow, and will be glad to hear people's comments,
specially David, that created the patch.

[1] Using truncate didn't raise the problem to me, either.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17723] New: Using MySQL on external server - lack of documentation giving example

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17723

Bug ID: 17723
   Summary: Using MySQL on external server - lack of documentation
giving example
 Change sponsored?: ---
   Product: Project Infrastructure
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Project website
  Assignee: wizzy...@gmail.com
  Reporter: fooque...@gmail.com

I am trying to create a Koha instance using MySQL on a remote server.

https://wiki.koha-community.org/wiki/Debian#Create_a_Koha_instance

states:

"create a new file in its place containing the connection information for the
server, in the form of a my.cnf file."

but no example is given.

I would assume this somehow allows specification of all of hostname, username
and password, but it is entirely unclear currently how to do this.

Could someone kindly add an example or give more details of what format exactly
"the connection information" should be in?

http://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html
has no mention of a password configuration for instance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16034] Integration with OverDrive Patron API

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #32 from Nick Clemens  ---
couple things:
POD fails QA tools

opac/external/overdrive/auth.pl has wrong description (copy/paste error)

When attempting to cancel a hold from results or patron details error is
displayed at top of page:
The title is not checked out. at
/usr/local/share/perl/5.14.2/WebService/ILS/OverDrive/Patron.pm line 571.

This is awesome overall though! Nice addition of ability to
checkout/download/hold titles.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14774] Task Scheduler not working on Ubuntu/Apache2.4

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14774

fooque...@gmail.com changed:

   What|Removed |Added

 CC||fooque...@gmail.com

--- Comment #3 from fooque...@gmail.com ---
On Ubuntu 14.04, I found that installing koha, which installs mpm-itk broke
Exim4 mail sending.

I found, as per the references below, that adding the following directive to
the top-level Apache configuration resolved the problem:

LimitUIDRange 0 2000

The description above sounds like a very similar problem.

http://blog.gaiterjones.com/send-php-mail-ubuntu-upgrade/
https://esilibrary.com/evergreen-and-koha-sitting-on-a-server/
http://mpm-itk.sesse.net/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15822] STAFF Advanced search error date utils

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822

Nick Clemens  changed:

   What|Removed |Added

  Attachment #57849|0   |1
is obsolete||

--- Comment #19 from Nick Clemens  ---
Created attachment 57985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57985=edit
Bug 15822: Fix 500 error when searching if items.onloan=-00-00

The calls
  output_pref({ dt => dt_from_string( $date ) })
are wrong and should be replaced with
  output_pref({ str => $date })
For better error handling.

Here we fix the problem of items.onloan when searching

Test plan:
- Set items.onloan=-00-00 (UPDATE items SET onloan='-00-00')
This can come from old data or bad migration
- Execute a search
=> Without this patch you get
Can't locate object method "ymd" via package "dateonly" (perhaps you forgot to
load "dateonly"?) at /home/vagrant/kohaclone/Koha/DateUtils.pm line 225.
=> With this patch you won't get the error

Signed-off-by: Alex Buckley 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15822] STAFF Advanced search error date utils

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578

--- Comment #63 from Nick Clemens  ---
Created attachment 57984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57984=edit
QA Follow - Adjust number of tests

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578

Nick Clemens  changed:

   What|Removed |Added

  Attachment #57973|0   |1
is obsolete||

--- Comment #62 from Nick Clemens  ---
Created attachment 57983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57983=edit
But 17578: (followup) amountoutstanding

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578

Nick Clemens  changed:

   What|Removed |Added

  Attachment #57972|0   |1
is obsolete||

--- Comment #60 from Nick Clemens  ---
Created attachment 57981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57981=edit
Bug 17578: GetMemberDetails - Remove enrolmentperiod

This value is not used anywhere

Test plan:
  git grep enrolmentperiod| grep -v installer| grep -v translator|vim -

should show you that I am right

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578

--- Comment #61 from Nick Clemens  ---
Created attachment 57982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57982=edit
Bug 17578: GetMemberDetails - Remove GetMemberDetails

All the values different from the ones GetMember returned has been
managed outside of GetMemberDetails.
It looks safe to replace all the occurrences of GetMemberDetails with
GetMember.

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578

Nick Clemens  changed:

   What|Removed |Added

  Attachment #57821|0   |1
is obsolete||

--- Comment #57 from Nick Clemens  ---
Created attachment 57978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57978=edit
Bug 17578: GetMemberDetails - Remove flags

Same as authflags, a flags key is set containing all the patron flags.
It is only used in a few places and it's better to call
C4::Members::patronflags when we need it.

Test plan:
Look at the diff and confirm that the change make sense
Use git grep to confirm we do not use the flags somewhere else.

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578

Nick Clemens  changed:

   What|Removed |Added

  Attachment #57823|0   |1
is obsolete||

--- Comment #59 from Nick Clemens  ---
Created attachment 57980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57980=edit
Bug 17578: GetMemberDetails - Remove reservefee

Same as other patches, reservefee is only used in opac-reserve.pl

Test plan;
Set reserve fee for a patron category
Place a hold at the OPAC with one of these patrons.
You must get a message about the reserve fee.

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578

Nick Clemens  changed:

   What|Removed |Added

  Attachment #57822|0   |1
is obsolete||

--- Comment #58 from Nick Clemens  ---
Created attachment 57979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57979=edit
Bug 17578: GetMemberDetails - Remove is_expired

The is_expired value is used in 2 places, let's use
Koha::Patron->is_expired instead.

Test plan:
Depending on the different value of BlockExpiredPatronOpacActions for
the patron category, a patron must be blocked if he has expired.
Confirm that behavior from opac-renew and opac-reserve scripts

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578

Nick Clemens  changed:

   What|Removed |Added

  Attachment #57818|0   |1
is obsolete||

--- Comment #54 from Nick Clemens  ---
Created attachment 57975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57975=edit
Bug 17578: GetMemberDetails - Remove authflags - 1

GetMemberDetails create a authflags key, but this key is only used from
2 different places.
One is a very simple script, which does not seem very usefull
C4/SIP/interactive_members_dump.pl. I propose to simply remove it.
The other one is the member-flags.pl script. What is done in this one is
a bit weird since we a doing twice the same query (it was not highlighted
before this patch). We will need to fix that later.
At the moment the goal it to remove the GetMemberDetails subroutine
without introducing any regressions (and so without adding big changes)

Test plan:
Select/unselect permissions for a patron, save and edit again.
The behavior of the permission checkboxes should be ok

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578

Nick Clemens  changed:

   What|Removed |Added

  Attachment #57819|0   |1
is obsolete||

--- Comment #55 from Nick Clemens  ---
Created attachment 57976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57976=edit
Bug 17578: GetMemberDetails - Remove authflags - 2

This script is not used from the Koha codebase and does not seem very
useful.
We could rewrite it if needed later (ie. if someone complains I will
rewrite it).

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578

Nick Clemens  changed:

   What|Removed |Added

  Attachment #57820|0   |1
is obsolete||

--- Comment #56 from Nick Clemens  ---
Created attachment 57977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57977=edit
Bug 17578: GetMemberDetails - Remove amountoutstanding

The amountoutstanding value set by GetMemberDetails was only used in a
few places. In that case it makes sense to only retrieve it when needed.

Test plan:
1/ Add fines to a patron, on the OPAC patron info page, you should see a
"Fines" tab
2/ Add credit to a patron, you should see the credit displayed
3/ Set the pref maxoutstanding to 3
4/ Add a fine of 4 to a patron
5/ Try to place an hold for this patron
=> You should get a "too much oweing" message

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578

Nick Clemens  changed:

   What|Removed |Added

  Attachment #57817|0   |1
is obsolete||

--- Comment #53 from Nick Clemens  ---
Created attachment 57974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57974=edit
Bug 17578: GetMemberDetails - Remove BlockExpiredPatronOpacActions

The correct way to get the value of BlockExpiredPatronOpacActions from a
patron object is to get the patron category then call the
effective_BlockExpiredPatronOpacActions:
  $patron->category->effective_BlockExpiredPatronOpacActions

So this patch applies this change and remove this value from the
GetMemberDetails subroutine.

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

--- Comment #3 from George Williams (NEKLS)  ---
Tried to test in the sandbox but I kept getting an error message saying
"CONFLICT (content): Merge conflict in C4/Reserves.pm"

George

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586

--- Comment #10 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #9)
> (In reply to Kyle M Hall from comment #8)
> > I don't want to be *too* much of a pedant, but wouldn't this method be
> > better in Koha::Account? I see there are a good number of patches that
> > depend on this, so if that change will require many further changes, I'd be
> > happy with just a final bug at the end of the chain to move it to
> > Koha::Account.
> 
> How would you write this line in that case:
>   my $balance = $patron->get_account_lines->get_balance;
> (from the patch on bug 17588).
> 
> Maybe just $patron->get_account_balance then?

I would do $patron->account()->balance() with account() returning the
Koha::Account object, and balance() returning the account balance. Of course,
I'm a fan of being succinct ; )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17714] Remove itemtype-related t/db_dependent/Members/* warnings

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17714

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #6 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578

--- Comment #52 from Jonathan Druart  
---
Created attachment 57973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57973=edit
But 17578: (followup) amountoutstanding

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #57825|0   |1
is obsolete||
  Attachment #57826|0   |1
is obsolete||

--- Comment #51 from Jonathan Druart  
---
Created attachment 57972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57972=edit
Bug 17578: GetMemberDetails - Remove GetMemberDetails

All the values different from the ones GetMember returned has been
managed outside of GetMemberDetails.
It looks safe to replace all the occurrences of GetMemberDetails with
GetMember.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17716] Remove itemtype-related t/db_dependent/ CourseReserves.t warnings

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17716

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #8 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17584] Add the Koha::Patron->get_issues method

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #57365|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 57971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57971=edit
Bug 17584: Add the Koha::Patron->get_issues method

Test plan:
  prove t/db_dependent/Koha/Patrons.t
should return green

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17584] Add the Koha::Patron->get_issues method

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17715] Remove itemtype-related t/db_dependent/Holds/ RevertWaitingStatus.t warnings

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17713] Members.t is failing randomly

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #7 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||n...@bywatersolutions.com

--- Comment #50 from Nick Clemens  ---
fatal: sha1 information is lacking or useless (circ/circulation.pl).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 17578: GetMemberDetails - Remove GetMemberDetails

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17720] CSRF token is not generated correctly

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17584] Add the Koha::Patron->get_issues method

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Signed Off  |Patch doesn't apply

--- Comment #4 from Nick Clemens  ---
Applying: Bug 17584: Add the Koha::Patron->get_issues method
fatal: sha1 information is lacking or useless (Koha/Patron.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 17584: Add the Koha::Patron->get_issues method

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17556] Move GetHideLostItemsPreference to Koha::Patron

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17584] Add the Koha::Patron->get_issues method

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585

Tomás Cohen Arazi  changed:

   What|Removed |Added

Version|unspecified |master
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17568] Add the Koha::Patron->library method

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17568

Tomás Cohen Arazi  changed:

   What|Removed |Added

Version|unspecified |master
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17720] CSRF token is not generated correctly

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720

Tomás Cohen Arazi  changed:

   What|Removed |Added

Version|unspecified |master
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #4 from Nick Clemens  ---
Framework is updated in at least two other subs, the framework is passed in to
the subs and not pulled from the record so I don't see any problem with not
updating it first.

Editing a record works, updating framework works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629

Nick Clemens  changed:

   What|Removed |Added

  Attachment #57955|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 57970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57970=edit
Bug 17629: Koha::Biblio - Remove ModBiblioframework

There is only one call to C4::Biblio::ModBiblioframework, it's called
just before C4::Biblio::ModBiblio in cataloguing/addbiblio.pl
At first glance this call does not seems useful: all the subroutines
called from ModBiblio send the frameworkcode in parameter.

I'd go to remove it, but I'd like to get confirmation by others.

No test plan here, you need a good pair of eyes and deep into the
C4::Biblio code.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only)

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718

--- Comment #7 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
Address templates allow to use street number merged into one field with the
street name or separately as two fields. Autocomplete should work correctly
without problems regardless the settings in BorrowerUnwantedField system
preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only)

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718

--- Comment #6 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
Created attachment 57969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57969=edit
Bug 17718: Used Koha.preference instead of passing params to templates from
module memberentry.pl

Test plan:
1) Apply the patch
2) Setup preferences "SmartformEnable", "SmartformClientID"
   (register at smartform.cz or use "smartform" as the client ID)
3) Show/hide streetnumber as desired in BorrowerUnwantedField pref
   (eg. fill in "streetnumber|B_streetnumber")
4) Edit a patron
5) Start entering street in an address field
6) Select a street from autocomplete
7) Continue entering street number and select the right address
8) ZIP and city should get values from autocomplete
9) Disable SmartformEnable and repeat steps above
10) No autocompletion should occur

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17246] GetPreparedLetter should not allow multiple FK defined in arrayref

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17246

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #3 from Jonathan Druart  
---
Upgrading severity to get attention

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17600] Standardize the EXPORT

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||17722


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722
[Bug 17722] t/db_dependent/PatronLists.t doesn't run inside a transaction
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17722] t/db_dependent/PatronLists.t doesn't run inside a transaction

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 57968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57968=edit
Bug 17722: Make PatronLists.t run inside a transaction

This patch makes t/db_dependent/PatronLists.t run inside a transaction.
It also makes it generate its own data using t::lib::TestBuilder instead
of relying on sample patrons on the DB.

To test:
- Run:
  $ prove t/db_dependent/PatronLists.t
=> SUCCESS: Tests pass
- Apply the patch
- Run:
  $ prove t/db_dependent/PatronLists.t
=> SUCCESS: Tests pass
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17722] t/db_dependent/PatronLists.t doesn't run inside a transaction

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||17600


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600
[Bug 17600] Standardize the EXPORT
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17722] t/db_dependent/PatronLists.t doesn't run inside a transaction

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17722] t/db_dependent/PatronLists.t doesn't run inside a transaction

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16749] Follow-up for bug 16733: changes for koha-translate

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749

--- Comment #9 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #8)
> (In reply to Marcel de Rooy from comment #7)
> > (In reply to Jonathan Druart from comment #5)
> > >   % sudo koha-translate --dev kohadev --install es-ES
> > >   % ls koha-tmpl/intranet-tmpl/prog|grep es-ES 
> > > 
> > > Does not return anything, what did I miss?
> > > 
> > > I have used a very new script to update the debian files, 
> > > cp_debian_files.pl
> > > on koha-misc4dev (see https://github.com/joubu/koha-misc4dev).
> > 
> > Dumb question, but you checked this?
> > Add the  line to koha-conf.xml. (See 16733.)
> 
> Nope :)
> Why don't you use intranetdir?

dev_install tells you too that this is a gitified install

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17600] Standardize the EXPORT

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #14 from Jonathan Druart  
---
Ok so, a lot of things is broken with these patches:

- from tests:
  use_ok should be be used since it does not export subroutines
- from pm:
  subroutines are not exported sometimes whereas the script assumes they were
  things are working when they are expecting not to (get_template_and_user from
C4::Auth is not exported by scripts use it and it works).

Maybe it would be easier not to export anything and use fully qualified names
instead?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17722] New: t/db_dependent/PatronLists.t doesn' t run inside a transaction

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722

Bug ID: 17722
   Summary: t/db_dependent/PatronLists.t doesn't run inside a
transaction
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: tomasco...@gmail.com
QA Contact: gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17541] Add ability to log all barcodes scanned at checkin

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17541

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
This new pref does not affect checkins from the checkouts page (svc/checkin),
is it expected?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17720] CSRF token is not generated correctly

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #57957|0   |1
is obsolete||

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 57967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57967=edit
Bug 17720: CSRF - Handle unicode characters

From the pod of Digest::MD5:
"""
Since the MD5 algorithm is only defined for strings of bytes, it can not
be used on strings that contains chars with ordinal number above 255
(Unicode strings). The MD5 functions and methods will croak if you try
to feed them such input data.
What you can do is calculate the MD5 checksum of the UTF-8
representation of such strings.
"""

Test plan:
- Set a MySQL/MariaDB password with unicode characters:
  UPDATE user SET password=PASSWORD('❤') WHERE USER='koha_kohadev';
  FLUSH PRIVILEGES
- Update your $KOHA_CONF file
- Restart Memcached
- Hit the files modified by this patch

=> Without this patch, you will get a software error (with "Wide
character in subroutine entry" in the logs).
=> With this patch, everything will go fine

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

Edit: removed debugging leftover

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17720] CSRF token is not generated correctly

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16749] Follow-up for bug 16733: changes for koha-translate

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749

--- Comment #8 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #7)
> (In reply to Jonathan Druart from comment #5)
> >   % sudo koha-translate --dev kohadev --install es-ES
> >   % ls koha-tmpl/intranet-tmpl/prog|grep es-ES 
> > 
> > Does not return anything, what did I miss?
> > 
> > I have used a very new script to update the debian files, cp_debian_files.pl
> > on koha-misc4dev (see https://github.com/joubu/koha-misc4dev).
> 
> Dumb question, but you checked this?
> Add the  line to koha-conf.xml. (See 16733.)

Nope :)
Why don't you use intranetdir?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979

Alex Arnaud  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #29 from Alex Arnaud  ---
Hello Alex,

Patches are rebased on master. You can test again.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #57483|0   |1
is obsolete||

--- Comment #28 from Alex Arnaud  ---
Created attachment 57966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57966=edit
Bug 6979 - Fix Already in a transaction error

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #57482|0   |1
is obsolete||

--- Comment #27 from Alex Arnaud  ---
Created attachment 57965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57965=edit
Bug 6979 - Handle multiple branches in non-auth_by_bin

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #57481|0   |1
is obsolete||

--- Comment #26 from Alex Arnaud  ---
Created attachment 57964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57964=edit
Bug 6979 - Update tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #57480|0   |1
is obsolete||

--- Comment #25 from Alex Arnaud  ---
Created attachment 57963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57963=edit
Bug #6979

I removed several lines of code in the checkpw_ldap subroutine where
LDAP authentication takes place, in the "else" part of the conditional
that checks for the auth_by_bind config parameter. I added several lines
to check whether the user can log in to LDAP using their DN and the
password supplied in the login form. If they are able to bind, login
contiues as normal and the LDAP attributes can be harvested as normal if
the update options are turned on. The routine that was in place was
failing because it was trying to check against a non-existent LDAP entry
attribute called 'userpassword'. Instead of checking against a
'userpassword' attribute, the routine really should be checking to make
sure the user can actually bind to LDAP. That's what I set up, and it is
a safer way to test authentication against LDAP.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17713] Members.t is failing randomly

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #57932|0   |1
is obsolete||

--- Comment #6 from Tomás Cohen Arazi  ---
Created attachment 57962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57962=edit
Bug 17713: Fix Members.t tests

If the category_type is 'S', GetBorrowersToExpunge won't return the
patron.

Test plan:
  t/db_dependent/Members.t
should always return green

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17713] Members.t is failing randomly

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17716] Remove itemtype-related t/db_dependent/ CourseReserves.t warnings

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17716

--- Comment #7 from Jonathan Druart  
---
Created attachment 57961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57961=edit
Bug 17716: (followup) Remove dep on existing data and tidy

This patch removes the requirement for this tests for the DB to include
at least 10 borrowers to pass. Borrowers are now created on each run
using t::lib::TestBuilder and a loop.

Bonus: some tiny changes to tidy the file.

To test:
- Run:
  $ prove t/db_dependent/CourseReserves.t
SUCCESS => Tests pass with and without the patch.
- Sign off :-D

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17716] Remove itemtype-related t/db_dependent/ CourseReserves.t warnings

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17716

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #57941|0   |1
is obsolete||
  Attachment #57942|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 57960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57960=edit
Bug 17716: Remove itemtype-related t/db_dependent/CourseReserves.t

This patch makes t/db_dependent/CourseReserves.t create
good sample data for its tests. It does so by creating a random
itemtype.

To test:
- Run
  $ prove t/db_dependent/CourseReserves.t
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
  set for item"
- Apply the patch
- Run:
  $ prove t/db_dependent/CourseReserves.t
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17716] Remove itemtype-related t/db_dependent/ CourseReserves.t warnings

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17716

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17715] Remove itemtype-related t/db_dependent/Holds/ RevertWaitingStatus.t warnings

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #57940|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 57959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57959=edit
Bug 17715: Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t
warnings

This patch makes t/db_dependent/Holds/RevertWaitingStatus.t create
good sample data for its tests. It does so by creating a random
itemtype.

To test:
- Run
  $ prove t/db_dependent/Holds/RevertWaitingStatus.t
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
  $ prove t/db_dependent/Holds/RevertWaitingStatus.t
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17715] Remove itemtype-related t/db_dependent/Holds/ RevertWaitingStatus.t warnings

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17714] Remove itemtype-related t/db_dependent/Members/* warnings

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17714

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17714] Remove itemtype-related t/db_dependent/Members/* warnings

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17714

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #57943|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 57958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57958=edit
Bug 17714: Remove itemtype-related t/db_dependent/Members/* warnings

This patch makes t/db_dependent/Members/* create
good sample data for its tests. It does so by creating a random
itemtype.

To test:
- Run
  $ prove t/db_dependent/Members/*
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
  $ prove t/db_dependent/Members/*
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only)

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718

--- Comment #5 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
No registration is required to start testing, just use "smartform" as client ID
when working on localhost.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17720] CSRF token is not generated correctly

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57949|0   |1
is obsolete||

--- Comment #2 from Josef Moravec  ---
Created attachment 57957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57957=edit
[SIGNED-OFF] Bug 17720: CSRF - Handle unicode characters

From the pod of Digest::MD5:
"""
Since the MD5 algorithm is only defined for strings of bytes, it can not
be used on strings that contains chars with ordinal number above 255
(Unicode strings). The MD5 functions and methods will croak if you try
to feed them such input data.
What you can do is calculate the MD5 checksum of the UTF-8
representation of such strings.
"""

Test plan:
- Set a MySQL/MariaDB password with unicode characters:
  UPDATE user SET password=PASSWORD('❤') WHERE USER='koha_kohadev';
  FLUSH PRIVILEGES
- Update your $KOHA_CONF file
- Restart Memcached
- Hit the files modified by this patch

=> Without this patch, you will get a software error (with "Wide
character in subroutine entry" in the logs).
=> With this patch, everything will go fine

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17720] CSRF token is not generated correctly

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17676] Default COLLATE for marc_subfield_structure is not set

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17676

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17721

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17721] Do we need utf8_bin collation on tagsubfield?

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17721

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17676
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17721] New: Do we need utf8_bin collation on tagsubfield?

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17721

Bug ID: 17721
   Summary: Do we need utf8_bin collation on tagsubfield?
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

Comes from report 17676. This discussion should be on a new report.
===
Comment11
> Indeed we want to keep tagsubfield a utf8_bin (to allow lowercase and 
> uppercase of the same letter for subfields).
Could you provide an example where we want to do that? Is that MARC conform?
And if so(!), why would you need utf8_bin to do so? You can still insert them,
only finding the right a or A would be harder.
It seems to me that we should remove this strange exception, and make sure that
all tagsubfields are saved lowercase. Should not be too hard.
Can MARC::Record handle subfields a and A btw?
But this discussion should be on a new report.

> if ( $table[1] !~ /COLLATE=utf8_unicode_ci/ and $table[1] !~ 
> /COLLATE=utf8mb4_unicode_ci/ ) { #catches utf8mb4 collated tables
This is only 99,9% safe (as you are probably aware of).
If you find one column in unicode_ci, the table might still be something else
(theoretically). Perhaps someone added a custom column with collation?
Since you only change the default here, why not always do it? Replacing X with
X will not be a problem..

Comment12&13 (Katrin)
It's not strictly MARC conform, but we use this a lot and I have talked to
others using it as well. Take the 952 field as the example - all subfield codes
are taken. Using upper case letters works fantastically now and allows you to
store and index data that we got no other sensible spot for. We got it all
working perfectly, why break this feature without need?
Ah, and I think I have encountered upper case in German MARC - just can't find
a documentation right now.
===
Even if we do not change it at all, it would be worth writing somewhere why we
do not. (And where we can still find it later.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17591] Use fully qualified C4::Items function names in C4:: Circulation

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17591

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|Failed QA   |RESOLVED

--- Comment #12 from Jonathan Druart  
---
So, we finally fix the issue with bug 17599.
To continue the discussion and find a more complete solution, see bug 17600.

*** This bug has been marked as a duplicate of bug 17599 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17599] Move C4::Circulation::GetIssuingRule to Koha::IssuingRules-> get_effective_issuing_rule

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17599

--- Comment #11 from Jonathan Druart  
---
*** Bug 17591 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug 10480)

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203

--- Comment #7 from Marcel de Rooy  ---
(In reply to Josef Moravec from comment #6)
> Signed-off-by: Josef Moravec 

Great! Thx.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17600] Standardize the EXPORT

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #13 from Jonathan Druart  
---
So, what's next?
It won't be feasible to test all the changes. So we need to decide if it worth
the try to push these patches as it.

At least it would be great to get a review from someone else.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17600] Standardize the EXPORT

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

Jonathan Druart  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug 10480)

2016-12-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203

Josef Moravec  changed:

   What|Removed |Added

  Attachment #50066|0   |1
is obsolete||

--- Comment #6 from Josef Moravec  ---
Created attachment 57956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57956=edit
[SIGNED-OFF] Bug 16203: Convert item plugins to new style (see bug 10480)

Converts item plugins to new style (with builder and launcher).
See also bugs 10480 and 13437.

The following plugins have been adjusted:
barcode_manual.pl
barcode.pl
callnumber-KU.pl
callnumber.pl
cn_browser.pl (Added license statement too)
dateaccessioned.pl
macles.pl
stocknumberam123.pl
stocknumberAV.pl
stocknumber.pl

Test plan:
Connect the plugin to an item field.
Verify that the plugin still works.

Signed-off-by: Marcel de Rooy 
Tested if all plugins compile okay.
Ran most of them thru FrameworkPlugin.t.
Tested them in the item editor.

Note: the form for macles.pl comes up, further hard to test.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 121 matches

Mail list logo