date:20161212

[Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742

--- Comment #7 from Josef Moravec  ---
(In reply to Jonathan Druart from comment #3)
> (In reply to Chris Kirby from comment #2)
> > Changes test #7 to the one which was probably originally intended
> 
> No, the original test was good. We want to check that the updated_on value
> has been updated when a patron is modified.

I change the back to original test, fix it (I hope), now it's tested on
firstname, instead of surname, which is needed in later test... and maked the
tests use Koha::Database instead of C4:Context->dbh;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58085|0   |1
is obsolete||

--- Comment #6 from Josef Moravec  ---
Created attachment 58148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58148=edit
Bug 17742: Fix t/db_dependent/Patrons.t

Moves the getting of testing date for updated_on just after the storing
the test patron data to make the gap between generating data and now
date as short as possible

Fixes test 7

Use Koha::Database instead of C4::Context->dbh

Test plan
1. prove t/db_dependent/Patrons.t
2. read the diff

Signed-off-by: Chris Kirby 
Tests passed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742

Josef Moravec  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17765] New: Hide 'Holds' link in staff result list when user has no permission to place holds

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

Bug ID: 17765
   Summary: Hide 'Holds' link in staff result list when user has
no permission to place holds
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The "Holds" link on the staff result list is still visible, even if the  user
has no "reserveforothers" permission. 

At the same time it's not possible to place a hold from the detail page and you
get a permission error when trying to use the link.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #6 from Liz Rea  ---
Hi,

This script seems really dangerous, how will it know if it is cancelling a hold
that is for something missing or lost, or one that someone legitimately placed
on an item and it's just taking AGES to get through the (possibly very long)
reserve list? I'd be concerned especially in libraries that routinely have very
long waiting lists on popular titles.

I feel like this needs some safeguards.

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17764] New: OPAC search fails when lost items are in the result set and there is no logged in user

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17764

Bug ID: 17764
   Summary: OPAC search fails when lost items are in the result
set and there is no logged in user
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P2
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: l...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

To replicate:

Make sure you have at least one lost item in your result set 
Do a search in the opac that would turn up a whole list of results (and not
just that one) with the lost item included 
You will probably get an error: 
Can't call method "category" on an undefined value at
/home/liz/koha-src/koha/C4/Search.pm line 2091.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16348] Kohacon 2012 is not on the website

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16348

Liz Rea  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Liz Rea  ---
Hi Mirko,

It doesn't seem to exist now. I'm quite sure I didn't delete it myself.
Possibly the person who was maintaining the page deleted it. That really isn't
too strange, the people writing that page would have had delete privileges. 

I've added a link to the internet archive page of the programme.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15419] Sipserver problem with stale db handles

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15419

--- Comment #8 from Srdjan Jankovic  ---
Yes, that should be the case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17556] Move GetHideLostItemsPreference to Koha::Patron

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED
 CC||katrin.fisc...@bsz-bw.de

--- Comment #12 from Katrin Fischer  ---
This won't get backported to 16.11.x as it is an enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846
Bug 16846 depends on bug 17556, which changed state.

Bug 17556 Summary: Move GetHideLostItemsPreference to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17516] Add CSV export option to item search after displaying output to screen

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17516

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||katrin.fisc...@bsz-bw.de
 Status|Pushed to Master|RESOLVED

--- Comment #5 from Katrin Fischer  ---
This won't get backported to 16.11.x as it is an enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17416] Move javascript in doc-head-close.inc into a separate include

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED

--- Comment #10 from Katrin Fischer  ---
These won't get backported to 16.11.x as it is an enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17418] Move staff client home page JavaScript to the footer

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418
Bug 17418 depends on bug 17416, which changed state.

Bug 17416 Summary: Move javascript in doc-head-close.inc into a separate include
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17416] Move javascript in doc-head-close.inc into a separate include

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17556] Move GetHideLostItemsPreference to Koha::Patron

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #11 from Liz Rea  ---
Not that it particularly matters, because you shouldn't do this anyway - this
patch breaks searching in the staff client for the database user
superlibrarian. 

Only leaving this note in case someone else sees 

Can't call method "category" on an undefined value at
/home/liz/koha-src/koha/C4/Search.pm line 2091.

and traces it back to this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17416] Move javascript in doc-head-close.inc into a separate include

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416

Katrin Fischer  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #9 from Katrin Fischer  ---
Patch status is set to "patch doesn't apply" - but both patches appear to have
been pushed to master. I am resetting the status to reflect this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897
Bug 15897 depends on bug 15896, which changed state.

Bug 15896 Summary: Use Koha::Account::pay internally for makepayment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15894] Unify all account fine payment functions

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894
Bug 15894 depends on bug 15896, which changed state.

Bug 15896 Summary: Use Koha::Account::pay internally for makepayment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

--- Comment #44 from Katrin Fischer  ---
This won't get backported to 16.11.x as it is an enhancement and has
dependencies that were not backported either.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896
Bug 15896 depends on bug 15906, which changed state.

Bug 15906 Summary: [ONLY PUSH TOGETHER WITH 15896] Remove use of makepayment in 
paycollect.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15906

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15905] Remove use of makepayment

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905
Bug 15905 depends on bug 15906, which changed state.

Bug 15906 Summary: [ONLY PUSH TOGETHER WITH 15896] Remove use of makepayment in 
paycollect.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15906

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15906] [ONLY PUSH TOGETHER WITH 15896] Remove use of makepayment in paycollect.pl

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15906

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

--- Comment #17 from Katrin Fischer  ---
This won't get backported to 16.11.x as it is an enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17722] t/db_dependent/PatronLists.t doesn't run inside a transaction

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Pushed to Master|Pushed to Stable

--- Comment #5 from Katrin Fischer  ---
This patch has been pushed to 16.11.x, will be in 16.11.01.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #22 from Katrin Fischer  ---
These patches have been pushed to 16.11.x, will be in 16.11.01.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17449] Let users choose action in self checkout

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17449

Chuck McAndrew  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||chuck.mcandrew@leblibrary.c
   ||om

--- Comment #4 from Chuck McAndrew  ---
I tested this, everything worked fine except that scanning the barcode on the
renew tab fails to renew the item. If you manually click the renew link, it
renews the item, but entering the barcode doesn't.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17668] typo in parcel.pl listinct vs listincgst

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17668

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Pushed to Master|Pushed to Stable

--- Comment #5 from Katrin Fischer  ---
This patch has been pushed to 16.11.x, will be in 16.11.01.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15822] STAFF Advanced search error date utils

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||katrin.fisc...@bsz-bw.de

--- Comment #21 from Katrin Fischer  ---
This patch has been pushed to 16.11.x, will be in 16.11.01.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16376] Koha::Calendar-> is_holiday date truncation creates fatal errors for TZ America/Santiago

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||katrin.fisc...@bsz-bw.de

--- Comment #25 from Katrin Fischer  ---
These patches have been pushed to 16.11.x, will be in 16.11.01.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17763] Exact ponctuation and words order is needed for matching results for author and title in adv. search

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17763

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Alexandre,

which search options are you using on the advanced search?
Have you compared the author, phrase and the normal author search?
Can you give a search example?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17763] New: Exact ponctuation and words order is needed for matching results for author and title in adv. search

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17763

Bug ID: 17763
   Summary: Exact ponctuation and words order is needed for
matching results for author and title in adv. search
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: Linux
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alexandre.bre...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org

When we use in advanced search, the exact ponctuation ("," and "-") and words
order (name, first name) is required to find the good author. Also, when we
search by customer, we must put an "-" in the customer name to find the good
one.

Some people want a more flexible way to find the good author or the good
customer in theirs orders.

There is a patch or a fix of any kind to do this without ",", "-" and the
specific word order ? I searched but find nothing related (maybe I miss
something...)

Thanks,

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17401] Returns form not submitting after printing slip

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17401

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Benjamin, I don't understand how to test this and what happens, can you add
a test plan?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10142] Unclear which issues show on subscription details issues tab

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10142

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52406|0   |1
is obsolete||
  Attachment #52407|0   |1
is obsolete||

--- Comment #12 from Kyle M Hall  ---
Created attachment 58146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58146=edit
Bug 14570 - Update Schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #13 from Kyle M Hall  ---
Created attachment 58147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58147=edit
Bug 14570 - Make it possible to add multiple guarantors to a record

This patch adds the ability to set an unlimited number of guarantors
for a given patron. As before, each guarantor may be linked to another
Koha patron, and all the behavior that applies to a given guarantor
remains the same.

Test Plan:
 1) Apply this patch
 2) Run updatedatabase.pl
 3) Find some patrons with guarantors, verify the still have their guarantor
 4) Test adding and removing guarantors on a patron record, both Koha users and
not
 5) Verify the "Add child" button works
 6) Verify NoIssuesChargeGuarantees still works
 7) Verify tools/cleanborrowers.pl will not delete a guarantor
 8) Verify the guarantors are displayed on moremember.pl
 9) Verify the guarantor is removed by members/update-child.pl
10) Verify the guarantor is removed by misc/cronjobs/j2a.pl
11) Verify import patrons converts guarantor_id, relationship,
contactfirstname,
  and contactsurname into a guarantor
12) prove t/Patron.t
13) prove t/db_dependent/Circulation.t
14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
15) prove t/db_dependent/Items.t
16) prove t/db_dependent/Koha/Patrons.t
17) prove t/db_dependent/Members.t
18) prove t/db_dependent/Patron/Relationships.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #58143|0   |1
is obsolete||

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 58145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58145=edit
Bug 17755: Introduce Koha::Patron::Attribute::Type(s)

This patch introduces the Koha::Object-based classes for handling
patron attribute types.

It also adds branch limitation handling to the
Koha::Patron::Attribute::Type class.

It is built on top of the new Koha::Object::Library::Limit class
that extends Koha::Object so it handles library limits.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com
 QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c
   |y.org   |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|Move|Introduce
   |C4::Members::AttributeTypes |Koha::Patron::Attribute::Ty
   |to Koha::* namespace|pe(s)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17755] Move C4::Members::AttributeTypes to Koha::* namespace

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 58144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58144=edit
Bug 17755: Unit tests

This patch introduces unit tests for Koha::Object::Library::Limit. It is
done this way because it needs to be instantiated to be usable.

To test:
- Run:
  $ prove t/db_dependent/Koha/Patron/Attribute/Types.t
=> SUCCESS: Tests pass
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17755] Move C4::Members::AttributeTypes to Koha::* namespace

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 58143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58143=edit
Bug 17755: Introduce Koha::Patron::Attribute::Type(s)

This patch introduces the Koha::Object-based classes for handling
patron attribute types.

It also adds branch limitation handling to the
Koha::Patron::Attribute::Type class.

It is built on top of the new Koha::Object::Library::Limit class
that extends Koha::Object so it handles library limits.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17755] Move C4::Members::AttributeTypes to Koha::* namespace

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 58142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58142=edit
Bug 17755: Introduce Koha::Object::Library::Limit

This patch introduces a new class for extending Koha::Object using
multiple inheritance. It cannot be used standalone, it needs to be
used in Koha::Object implementations like this:

use base qw( Koha::Object Koha::Object::Library::Limit );

Its goal is to provide a single way and place to deal with this common
pattern in Koha's codebase.

As it happened with Koha::Object, that needed to be tested in a real object
class, this work was done on top of Koha::Patron::Attribute::Type
implementation
and it is fully covered by the tests that are introduced for it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15200] t/Creators.t fails when using build-git-snapshot

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200

--- Comment #21 from Mason James  ---
(In reply to Mirko Tietgen from comment #20)
> Still needed for 16.05, package build fails.

Pushed to 16.05.x, will be in 16.05.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #8 from Jonathan Druart  
---
Created attachment 58140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58140=edit
Bug 17762: Send lang to GetPreparedLetter

This patch set the lang parameter when C4::Letters::GetPreparedLetter is
called to generate the notice.
Note that we do not need to pass it if want_librarian is set.

TODO: I do not know what to do with TransferSlip

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #9 from Jonathan Druart  
---
Created attachment 58141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58141=edit
Bug 17762: Add the lang parameter to C4::Letters::getletter

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #6 from Jonathan Druart  
---
Created attachment 58138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58138=edit
Bug 17762: Add lang to the PK of letter

We need to enlarge the PK of the letter table.

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #7 from Jonathan Druart  
---
Created attachment 58139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58139=edit
Bug 17762: Update the letter form interface

If the pref is on, the notice template will be translatable in different
languages

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #5 from Jonathan Druart  
---
Created attachment 58137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58137=edit
Bug 17762: Remove FK on message_transports

I don't really understand where does come from this foreign key but at first
glance it does not make sense.

Note that it seems we could also remove message_transports.branchcode

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #4 from Jonathan Druart  
---
Created attachment 58136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58136=edit
Bug 17762: Add the lang attribute to the patron form

Not the opac because we do not want the patron to modify it, they won't
be necessary translated.

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #3 from Jonathan Druart  
---
Created attachment 58135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58135=edit
Bug 17762: Add the new TranslateNotices syspref

This whole patch set adds the ability to translate notices in different
languages.
That way, if a library has patrons from different countries, they will
not have to send the notices in only one language but they will be able to
translate them.

Test plan:
- Switch on TranslateNotices
- Translate the interface in different languages
- Edit patron's details
=> You should see a new "prefered language" entry
That language will be used to send notices to this patron
- Edit several notice templates
=> You should see different tabs, 1 tab per language translated at the
opac (which sounds to make sense)
- Now the notice generated for this patron should be the one translated
in the language picked for him
To confirm that, try to generate several notices for this patron.
If the notice is not translated, the default one should be used.

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #2 from Jonathan Druart  
---
Created attachment 58134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58134=edit
Bug 17762: DBIC Schema changes

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #1 from Jonathan Druart  
---
Created attachment 58133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58133=edit
Bug 17762: DB changes - Add new 'lang' columns to letter and borrowers tables

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

Jonathan Druart  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] New: Ability to translate notices

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

Bug ID: 17762
   Summary: Ability to translate notices
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

If a library has students/patrons from different countries, they will all
receive the same notices. At the moment they are not translatable.
An improvement would be to let the library translate the notices in different
languages.

This bug will get patches to achieve this goal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15503] Grab Item Information from Order Files

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #44 from Matthias Meusburger  ---
Created attachment 58132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58132=edit
Bug 15503 [QA Followup] - Use Koha::AuthorisedValues and fetch notforloan
values.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12941] batch enable/disable courses

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12941

Felicia Beaudry  changed:

   What|Removed |Added

 CC||felicia.beau...@newberry.ed
   ||u

--- Comment #2 from Felicia Beaudry  ---
I would also like to see an easy way to batch enable/disable course reserves.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146

--- Comment #4 from Jonathan Druart  
---
Created attachment 58128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58128=edit
Bug 14146: Add the new pref CumulativeRestrictionPeriods

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146

--- Comment #6 from Jonathan Druart  
---
Created attachment 58130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58130=edit
Bug 14146: Add the ability to cumulate restriction periods

At the moment the default behaviour is not to cumulate the restriction
periods but to apply the longest one.
This patch set creates a new syspref CumulativeRestrictionPeriods. If
on, the behaviour changes and the restriction periods are cumulated: the
days of the second restriction are added to the actual restriction
period.

We could add a new circulation rule instead of a syspref, but I am not
sure it's very useful to have such granularity for this behaviour (can
be changed if needed).

How it works:
Let's take 2 items, A and B.
A is returned with Na days late, and B Nb days late
The grace period is Ng and there is 1 day of suspension charge per day
of overdue
The suspension period is until day D = Na - Ng + Nb - Ng

I would have expected D = Na + Nb - Ng but it's how it worked before
this patch.

Test plan:
Create several overdue for a given patron
Do the checkins and confirm that the period are added if the pref is on.
If the pref is off, you should not get any changes in the existing behaviour.

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146

--- Comment #7 from Jonathan Druart  
---
Created attachment 58131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58131=edit
Bug 14146: Clean a bit and make the code understandable

The code was a bit weird and this patch cleans it a bit by renaming
variables and adding a variable.

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146

--- Comment #5 from Jonathan Druart  
---
Created attachment 58129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58129=edit
Bug 14146: Add tests for AddReturn + CumulativeRestrictionPeriods

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16387] Incorrect loan period calculation when using decreaseLoanHighHolds feature

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387

--- Comment #3 from Lari Taskula  ---
Created attachment 58127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58127=edit
Bug 16387: Fix default shortened loan period time

When a loan period is shortened due to using decreaseLoanHighHolds* the time is
always set to the current time in X days, even if the original loan period is
given in days and not in hours.

It should default to 23:59 as is normal for loan periods given in days.

As original due date time defaults to 23:59 when given in days, this patch
modifies the hours and minutes of shortened due date to be equal to original
due
date.

To test:
1. prove t/db_dependent/DecreaseLoanHighHolds.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16387] Incorrect loan period calculation when using decreaseLoanHighHolds feature

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387

Lari Taskula  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8437] Large database backups and large exports from export.pl fail under plack

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437

--- Comment #15 from Barton Chittenden  ---
(In reply to Jonathan Druart from comment #14)
> (In reply to Dobrica Pavlinusic from comment #7)
> > Correct way to fix this is to issue redirect under plack in download_backup
> > to some plack handled URL so we don't read whole file in memory.
> 
> The solution seems to be here, but I don't understand what Dobrica meant.

Dobrica,

Can you clarify and/or submit a further patch? This issue is really causing
issues for large libraries.

Thanks,

--Barton

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Alex Sassmannshausen  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |alex.sassmannshausen@ptfs-e
   |y.org   |urope.com
 Depends on||14187
   Assignee|koha-b...@lists.koha-commun |alex.sassmannshausen@ptfs-e
   |ity.org |urope.com
 CC||alex.sassmannshausen@ptfs-e
   ||urope.com

--- Comment #2 from Alex Sassmannshausen  
---
We will shortly be able to finally upload a complete patch set for this
feature.

The basic idea with this feature is that:
- librarians can create rotas, that specify a route that stock should
automatically take along 'stages' (using branchtransfers)
- for now, stages are considered completed if an item has spent X items at the
branch associated with the stage (this could later be enhanced with other
triggers, e.g. X number of check outs at the given branch)
- Items are associated with rotas, and are automatically added to the first
stage.

Once an item arrives at the first stage, a nightly cron script will make sure
it is put into branchtransfer to the next stage when the item has exceeded the
number of days specified in the stage at the current branch.

This feature is subtly different from rotating collections, as that feature is
to do with the management of a 'group of items', that can be moved on together
to the next library.

This feature is about the automatic rotation of individual items attached to
rotas along the rota.

Alex


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187
[Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187

Alex Sassmannshausen  changed:

   What|Removed |Added

 Blocks||11897


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897
[Bug 11897] Stock Rotation for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187

Alex Sassmannshausen  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #13 from Alex Sassmannshausen 
 ---
Hello,

I've now been able to:

- [X] Re-checked code paths to see if all required changes were made
- [X] Updated test files
- [X] Added atomic update script
- [X] Tested database update & new database creation
- [X] Separated out schema changes
- [X] Ran QA scripts
- [X] Upload new patches.

This should now be ready for sign-off/QA.

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187

--- Comment #12 from Alex Sassmannshausen 
 ---
Created attachment 58124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58124=edit
DO NOT PUSH: Updated Branchtransfer schema.

* Koha/Schema/Result/Branchtransfer.pm: Newly generated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187

Alex Sassmannshausen  changed:

   What|Removed |Added

  Attachment #58121|0   |1
is obsolete||

--- Comment #11 from Alex Sassmannshausen 
 ---
Created attachment 58123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58123=edit
Bug 14187 - branchtransfer needs a primary key (id) for DBIx and common sense.

* C4/Circulation.pm (GetTransfers, GetTransfersFromTo): Also return
  branchtransfer_id in return columns.
* installer/data/mysql/atomicupdate/14187.perl: New file.
* installer/data/mysql/kohastructure.sql: Modify branchtransfers structure.
* t/db_dependent/Circulation/transfers.t: Update tests to expect
  branchtransfer_id.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Nick Clemens  changed:

   What|Removed |Added

  Attachment #53503|0   |1
is obsolete||

--- Comment #26 from Nick Clemens  ---
Created attachment 58125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58125=edit
Bug 13937 - Add a Z39.50 daemon that can inject item status MARC subfields

This creates a new daemon, misc/z3950_responder.pl, which can respond to
Z39.50 requests. By default, it just proxies searches to Zebra.

If desired, however, it can also add a subfield to the item tags on
outgoing records with a textual description of the item's status
(checked out, lost, etc.). This is useful for certain ILL systems. These
strings can be translated using the 'Z3950_STATUS' authorized value.

Test plan:
  1) Start the Z39.50 server using `perl misc/z3950_responder.pl`.
  2) Connect to the server using `yaz-client 127.0.0.1:/biblios`.
  3) Run a search, such as `find @attr 1=1016 book`.
  4) Fetch the results both one at a time with `show 1` and in a batch
 using `show 1+5`.
  5) Turn on MARCXML using `format xml` and `elements marcxml`, and
 verify that the records are still correctly fetched.
  6) Enable the item status subfield by restarting the server with the
 option `--add-item-status=k`.
  7) Search for and fetch records, and verify that a $k subfield is
 added to the item tags as appropriate. It should show some
 combination of "Checked Out", "Lost", "Not For Loan", "Damaged",
 "Withdrawn", "In Transit", or "On Hold" as appropriate, or
 "Available".
  8) Add an authorized value named "Z3950_STATUS" with any of the keys
 "AVAILABLE", "CHECKED_OUT", "LOST", "NOT_FOR_LOAN", "DAMAGED",
 "WITHDRAWN", "IN_TRANSIT" or "ON_HOLD", and verify that their
 descriptions are used instead of the default values above.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Nick Clemens  changed:

   What|Removed |Added

  Attachment #58122|0   |1
is obsolete||

--- Comment #27 from Nick Clemens  ---
Created attachment 58126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58126=edit
Bug 13937 (Followup) - Remove reference to sub _prefetch_records

Remove reference to sub _prefetch_records

It appears this subis built into fetch and this call is a duplicate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #25 from Nick Clemens  ---
Created attachment 58122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58122=edit
Bug 13937 (Followup) - Remove reference to sub _prefetch_records

Remove reference to sub _prefetch_records

It appears this subis built into fetch and this call is a duplicate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187

Alex Sassmannshausen  changed:

   What|Removed |Added

  Attachment #40075|0   |1
is obsolete||

--- Comment #10 from Alex Sassmannshausen 
 ---
Created attachment 58121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58121=edit
Bug 14187 - branchtransfer needs a primary key (id) for DBIx and common sense.

* C4/Circulation.pm (GetTransfers, GetTransfersFromTo): Also return
  branchtransfer_id in return columns.
* installer/data/mysql/atomicupdate/14187.perl: New file.
* installer/data/mysql/kohastructure.sql: Modify branchtransfers structure.
* t/db_dependent/Circulation/transfers.t: Update tests to expect
  branchtransfer_id.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8437] Large database backups and large exports from export.pl fail under plack

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437

Barton Chittenden  changed:

   What|Removed |Added

Summary|Plack and database backup   |Large database backups and
   ||large exports from
   ||export.pl fail under plack
 CC||bar...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17700] Add columns configuration to fines table

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17700

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17700] Add columns configuration to fines table

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17700

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #58118|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 58120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58120=edit
Bug 17700: Add columns setting to fines tables

Test plan:
0) Apply the patch and restart memcached + koha-common services if
needed
1) Go to adminitration -> Configure columns and confirm there is new
table configuration with id=account-fines in Patrons section available
2) play with table setting to ensure it works as expected
3) go to to boraccount page for some patron with both fines - payed and
owed
4) Note there is new button "Columns visibility" in top paginator panel,
try to use it
5) Play with the datatable, sort filter and so on

Signed-off-by: Radek Šiman 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17702] Create configuration for account types

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

--- Comment #9 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
(In reply to Josef Moravec from comment #1)
> Created attachment 57856 [details] [review]
> Bug 17702: Account types configuration - db changes
> 
> Test plan:
> 1) Read the diff and confirm that it does make sense
> 2) Comment what does not make sense ;)

According to db changes, is it possible to extend type_code from only 5 chars
to (let's say) 10 chars? It would be very useful for some libraries having a
longer list of payments not to be so cryptic. For instance, one of them (Czech
only - sorry):
mvs 50|MVS
tA4 3|Tisk a kopie A4
t2sA4   4|Tisk a kopie A4 oboustranně
toA46|Tisk a kopie A4 + obrázek
tbA415|Celobarevná A4
t20A4   2|Tisk a kopie A4 nad 20 kusů
s20A4   3|Tisk a kopie A4 oboustranně nad 20 kusů
b20A4   10|Tisk a kopie A4 barevně nad 20 kusů
tA3 5|Tisk a kopie A3
t2sA3   7|Tisk a kopie A3 oboustranně
toA310|Tisk a kopie A3 + obrázek
tbA325|Celobarevná A3
t20A3   3|Tisk a kopie A3 nad 20 kusů
s20A3   5|Tisk a kopie A3 oboustranně nad 20 kusů
b20A3   20|Tisk a kopie A3 barevně nad 20 kusů
sken7|skenování
eursl   3|eurosložka
papsl   5|papírová složka
taskm   3|taška malá
taskv   5|taška velká
prodj   ?|prodej
plack   ?|placky
eshop   ?|e-shop
poukaz  110|Poukaz na registraci
REZER   10|Rezervace (ručně)
pspec   2|Papír speciál

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
Skipping QA, too much time spent on these tests already.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #58117|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  
---
Created attachment 58119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58119=edit
Bug 17759: Remove invalid guarantorid's in Members.t

See also bug 17733. As long as we have no FK, these invalid guarantorid's
can make tests fail.
Adding a sql statement to clear them in the beginning of the test.

Test plan:
[1] Since it seems that AUTO_INC+8, +9 and +10 may fail one or two tests,
we should manipulate one or two borrowers:
Run this SQL query first:
SELECT `AUTO_INCREMENT` FROM  INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA =
'[your database]' and table_name='borrowers';
Now run: UPDATE borrowers SET guarantorid=[former value + 8] WHERE
borrowernumber=[some existing borrowernumber]
[2] Without this patch, run Members.t. Should fail two tests.
[3] Apply the patch. Fetch the new AUTO_INCREMENT value and update
guarantorid accordingly again for the manipulated borrower.
[4] Run the test. It should not fail.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17547] (MARC21) Chronological term field 648 not indexed

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547

--- Comment #4 from Magnus Enger  ---
(In reply to Jonathan Druart from comment #3)
> (In reply to Tomás Cohen Arazi from comment #1)
> > I assume NORMARC is similar on this regard. Feel free to fail it if the
> > NORMARC part of the
> > patch is wrong.
> 
> Magnus, could you confirm?

Akshuly, there is no 648 in NORMARC, and no other field is used for
"Chronological term" either, as far as I can tell.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15419] Sipserver problem with stale db handles

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15419

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #7 from Jonathan Druart  
---
Is this still valid for new versions?
I'd expect this to be fixed by bug 14778.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742

--- Comment #5 from Jonathan Druart  
---
(In reply to Josef Moravec from comment #4)
> (In reply to Jonathan Druart from comment #3)
> > (In reply to Chris Kirby from comment #2)
> > > Changes test #7 to the one which was probably originally intended
> > 
> > No, the original test was good. We want to check that the updated_on value
> > has been updated when a patron is modified.
> 
> But shouldn't it be tested on $b3_new?

Yes it should.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17700] Add columns configuration to fines table

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17700

Radek Šiman (R-Bit Technology, s.r.o.)  changed:

   What|Removed |Added

  Attachment #57830|0   |1
is obsolete||

--- Comment #2 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
Created attachment 58118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58118=edit
Bug 17700: Add columns setting to fines tables

Test plan:
0) Apply the patch and restart memcached + koha-common services if
needed
1) Go to adminitration -> Configure columns and confirm there is new
table configuration with id=account-fines in Patrons section available
2) play with table setting to ensure it works as expected
3) go to to boraccount page for some patron with both fines - payed and
owed
4) Note there is new button "Columns visibility" in top paginator panel,
try to use it
5) Play with the datatable, sort filter and so on

Signed-off-by: Radek Šiman 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17700] Add columns configuration to fines table

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17700

Radek Šiman (R-Bit Technology, s.r.o.)  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|m.de.r...@rijksmuseum.nl
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759

--- Comment #1 from Marcel de Rooy  ---
Created attachment 58117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58117=edit
Bug 17759: Remove invalid guarantorid's in Members.t

See also bug 17733. As long as we have no FK, these invalid guarantorid's
can make tests fail.
Adding a sql statement to clear them in the beginning of the test.

Test plan:
[1] Since it seems that AUTO_INC+8, +9 and +10 may fail one or two tests,
we should manipulate one or two borrowers:
Run this SQL query first:
SELECT `AUTO_INCREMENT` FROM  INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA =
'[your database]' and table_name='borrowers';
Now run: UPDATE borrowers SET guarantorid=[former value + 8] WHERE
borrowernumber=[some existing borrowernumber]
[2] Without this patch, run Members.t. Should fail two tests.
[3] Apply the patch. Fetch the new AUTO_INCREMENT value and update
guarantorid accordingly again for the manipulated borrower.
[4] Run the test. It should not fail.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742

--- Comment #4 from Josef Moravec  ---
(In reply to Jonathan Druart from comment #3)
> (In reply to Chris Kirby from comment #2)
> > Changes test #7 to the one which was probably originally intended
> 
> No, the original test was good. We want to check that the updated_on value
> has been updated when a patron is modified.

But shouldn't it be tested on $b3_new?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17547] (MARC21) Chronological term field 648 not indexed

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||mag...@libriotech.no

--- Comment #3 from Jonathan Druart  
---
(In reply to Tomás Cohen Arazi from comment #1)
> I assume NORMARC is similar on this regard. Feel free to fail it if the
> NORMARC part of the
> patch is wrong.

Magnus, could you confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17470] overdue_notices.pl produces X emails with the SAME list of ALL overdue items if a patron has overdue items from X branches

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@univ-lyon3.fr
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17470] overdue_notices.pl produces X emails with the SAME list of ALL overdue items if a patron has overdue items from X branches

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #57791|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 58116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58116=edit
Bug 17470 Make overdue notices according to branch item only

When a patron had overdues on items from different branches
he received from each corresponding branch a notice claiming
the complete list of these items.

Signed-off-by: sbujam 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17470] overdue_notices.pl produces X emails with the SAME list of ALL overdue items if a patron has overdue items from X branches

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734

Radek Šiman (R-Bit Technology, s.r.o.)  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734

Radek Šiman (R-Bit Technology, s.r.o.)  changed:

   What|Removed |Added

  Attachment #58009|0   |1
is obsolete||

--- Comment #5 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
Created attachment 58115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58115=edit
Bug 17734: Make possible to pay and writeoff from boraccount page and make
action buttons split button

Test plan
0) Have a patron with some fines - some paid and some unpaid
1) Apply the patch
2) git grep reverse_col should not return any appearence
3) Go to boraccount page, the last column header should have "Actions"
title
4) In the rightmost column you should see apropriate combination of buttons
for each row:
Print - fee which was written-off and write-off line
Pay + Print in dropdown - unpaid fee, for user without permission to
writeoff
Pay + Print and Write off in dropdown - unpaid fee, user with
permission to writeoff
Print + Reverse in dropdown - for payment row
5) Try all combination and use buttons and confirm they work as expected

Signed-off-by: Radek Šiman 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly

2016-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #57854|0   |1
is obsolete||

--- Comment #18 from Jonathan Druart  
---
Created attachment 58114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58114=edit
Bug 11274 Sent Notices Tab Not Working Correctly

This patch implements the notices toggle event using a different method.
Using on() lets us bind the event to a parent element, allowing the
event to attach to elements which may not exist on the page yet.

Test plan the same as original patch:

1) have a patron with more then 20 notices sent
2) go to patron profile -> notices
-> without patch, the showing/hidding of notices content does work
correctly only on first loaded page
-> with patch, it should work correctly everywhere - try to use
paginator, searching, ordering

Signed-off-by: Josef Moravec 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 137 matches

Mail list logo