date:20161213

[Koha-bugs] [Bug 2237] Use primary email address as Koha login account

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2237

Chris Kirby  changed:

   What|Removed |Added

 CC||chris.kirby@ilsleypubliclib
   ||rary.org

--- Comment #7 from Chris Kirby  ---
*** Bug 17769 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17769] Preference for patron username

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17769

Chris Kirby  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Chris Kirby  ---
This bug is a duplicate of Bug 2237.

*** This bug has been marked as a duplicate of bug 2237 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #32 from Andreas Hedström Mace  ---
I started testing this today and after some initial confusion about the rules
system (that could use some more documentation!) it seems mostly to work as
intended. But am I correct in understanding that Marc field permissions does
not currently work with Staged MARC Imports?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17743] Item search: indexes build on MARC do not work in item' s search

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17743

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
The same happens for fields like 952$x. I just tested on master and it also
gives back all results instead of filtering.
We think this used to work sometime prior to 3.22.10.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17772] New: Allow to sort lists by date the record was created

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17772

Bug ID: 17772
   Summary: Allow to sort lists by date the record was created
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Lists
  Assignee: gmcha...@gmail.com
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Lists in OPAC and staff can be sorted by different fields. It would be nice if
we could offer 'date created' as an additional option for sorting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17771] New: Add link to bibliographic record on spent/ ordered lists in acquisitions

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17771

Bug ID: 17771
   Summary: Add link to bibliographic record on spent/ordered
lists in acquisitions
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

The funds table on the start page of the acquisitions module provides links to
open orders (ordered) and received orders (spent) for each fund. 
On the lists, there is no way to see the details of an ordered record. 
It would be nice to provide a link to the staff detail page of the ordered
titles.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17770] New: t/db_dependent/ Sitemapper.t fails when date changes during test run

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

Bug ID: 17770
   Summary: t/db_dependent/Sitemapper.t fails when date changes
during test run
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: gmcha...@gmail.com

(22:48:28) tcohen: we need to fix the test
(22:48:34) tcohen: so it mocks the current date


t_db_dependent_Sitemapper_t.Its content is valid (369)
Failing for the past 1 build (Since Unstable#6 )
Took 0 ms.
Error Message

not ok 12 - Its content is valid

Standard Output

1..16
ok 1 - use Koha::Sitemapper;
ok 2 - use Koha::Sitemapper::Writer;
ok 3 - add fixtures
ok 4 - File sitemapindex.xml created
ok 5 - Its content is valid
ok 6 - File sitemap0001.xml created
ok 7 - Its content is valid
ok 8 - File sitemap0001.xml with short URLs created
ok 9 - Its content is valid
ok 10 - add fixtures
ok 11 - File sitemapindex.xml for 75000 bibs created
not ok 12 - Its content is valid
ok 13 - File sitemap0001.xml created
ok 14 - It contains 5 URLs
ok 15 - File sitemap0002.xml created
ok 16 - It contains 25000 URLs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15503] Grab Item Information from Order Files

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #49 from Benjamin Daeuber  ---
(In reply to Benjamin Daeuber from comment #46)
> Created attachment 58164 [details]
> Import screen
> 
> I've attached a screenshot of the import screen, where I've highlighted in
> red the collection. That collection is the top alphabetical, even though the
> based on the collection in the order file, the first should be a book and
> the next a book club in a bag. 

By this I mean Item Type, sorry. The item type for both is Audiobook, even
though the item types in the order file are different (and both valid).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 58167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58167=edit
Bug 17755: (followup) Rename ::Library::Limit for ::Limit::Library

It makes sense to rename it, as there might be other limits defined, not
just library-wise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15503] Grab Item Information from Order Files

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #48 from Benjamin Daeuber  ---
Created attachment 58166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58166=edit
Item information after import 2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15503] Grab Item Information from Order Files

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #47 from Benjamin Daeuber  ---
Created attachment 58165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58165=edit
Item information after import 1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15503] Grab Item Information from Order Files

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #46 from Benjamin Daeuber  ---
Created attachment 58164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58164=edit
Import screen

I've attached a screenshot of the import screen, where I've highlighted in red
the collection. That collection is the top alphabetical, even though the based
on the collection in the order file, the first should be a book and the next a
book club in a bag. 

It appears at this point that the collection code is correct. I've highlighted
in green.

The next two are ccode_1 and ccode_2, which are the item edit screens for both
of these items. They both have the top collection code alphabetically, rather
than the collection code we saw at import. Again, called in in green.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17547] (MARC21) Chronological term field 648 not indexed

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547

--- Comment #6 from Magnus Enger  ---
(In reply to Jonathan Druart from comment #5)
> Does that mean we need to remove NORMARC changes, to keep them or that does
> not matter? :)

My gut feeling says to just keep them. It should not hurt anyone.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15985] Include transacting library in fines

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985

Jason Robb  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15985] Include transacting library in fines

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985

Jason Robb  changed:

   What|Removed |Added

  Attachment #58157|0   |1
is obsolete||

--- Comment #3 from Jason Robb  ---
Created attachment 58163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58163=edit
[SIGNED-OFF] Attachment to Bug 15985 - Include transacting library in fines

Bug 15985 - Include transacting library in fines

Some librarians would like to see the library an item was checked out
from in the fines table on the fines payment page.

Test Plan:
1) Apply this patch
2) Find a patron with overdue items that have fines
3) Browse to the pay fines page
4) Note the new "checked out from" column

Signed-off-by: Jason Robb 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17769] Preference for patron username

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17769

--- Comment #1 from Chris Kirby  ---
I hope to put together a patch for this. Suggestions/feedback welcome.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17769] Preference for patron username

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17769

Chris Kirby  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |chris.kirby@ilsleypubliclib
   |ity.org |rary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17760] patron search not working in firefox

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17760

Heinrich Hartl  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
   Severity|enhancement |minor
 Status|NEW |RESOLVED

--- Comment #4 from Heinrich Hartl  ---
Apparently wrong content was cached by Firefox. This resulted in apparent
function failure. Conditions for caching such wrong content are unknown. I can
not reproduce the incorrect behaviour. Just in case some one else runs into a
similar problem: clearing the cache may solve your problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17769] New: Preference for patron username

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17769

Bug ID: 17769
   Summary: Preference for patron username
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: chris.ki...@ilsleypubliclibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When a librarian creates a patron account, the username field defaults to
firstname.lastname. However, many libraries change the default username to the
patron cardnumber, or email address when they set up a new patron account. It
would be useful if there were a branch level or system level preference for
default username with the following choices:
1)firstname.lastname
2)patron cardnumber
3)primary email address

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17768] New: spinelabel.css should be user editable.

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17768

Bug ID: 17768
   Summary: spinelabel.css should be user editable.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The quick-label CSS file is currently part of the Koha distribution, stored at
koha-tmpl/intranet-tmpl/prog/en/css/spinelabel.css.

This means that users who use package Koha cannot change the styling of the
quick slips without resorting to javascript.

I would suggest that koha-tmpl/intranet-tmpl/prog/en/css/spinelabel.css be a
default, but that we can change this via syspref.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17763] Exact punctuation and word order is needed for matching author and dealer names in acqui /histsearch.pl

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17763

Alexandre  changed:

   What|Removed |Added

Summary|Exact punctuation and word  |Exact punctuation and word
   |order is needed for |order is needed for
   |matching author and title   |matching author and dealer
   |in acqui/histsearch.pl  |names in
   ||acqui/histsearch.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17763] Exact punctuation and word order is needed for matching author and title in acqui /histsearch.pl

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17763

Owen Leonard  changed:

   What|Removed |Added

Summary|Exact ponctuation and words |Exact punctuation and word
   |order is needed for |order is needed for
   |matching results for author |matching author and title
   |and title in adv. search|in acqui/histsearch.pl
 OS|Linux   |All
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Patch doesn't apply

--- Comment #6 from Jonathan Druart  
---
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17547] (MARC21) Chronological term field 648 not indexed

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547

--- Comment #5 from Jonathan Druart  
---
Does that mean we need to remove NORMARC changes, to keep them or that does not
matter? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #27 from Jonathan Druart  
---
Aleisha, Have a look at your patches, there are some weird stuffs to fix:
1/ kohastructure: you re-add the entire item table
2/ update db: you should specify the "after" sql clause to keep the same order
as the kohastructure (not necessary useful but good practice to have)
3/ There is no need to use strict and warnings alongside Modern::Perl;
4/ The svc script has a BibLibre copyright
5/ I don't understand the need of the new subroutine in the svc script
(ajax_auth_cgi). You should not need it, have a look at how the other svc
scripts deal with authentication
6/ QA script fails with:
 FAIL   installer/data/mysql/sysprefs.sql
   FAIL   sysprefs_order
Not blocker: Sysprefs AllowIssueNotes is bad placed (see bug
10610)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15503] Grab Item Information from Order Files

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #45 from Matthias Meusburger  ---
Benjamin,

I can successfully map ccodes and item types. 

Can you explain this sentence : "Even on initial import (i.e the order edit
screen when adding to a basket), it simply shows the our top collection
alphabetically."?

Notforloans are working for me (items are shown not available when needed) but
I tested it with my last patch. Could you have another look at it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187

--- Comment #42 from Chris Cormack  ---
Yes, bug 9850 meets all the requirements of this. We have it in production for
our sites. So we will not be doing any more work on this. 

Our recommendation is to use coce for book covers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187

--- Comment #41 from Katrin Fischer  ---
We are really interested in this as well - centralizing the code would make it
easier to add new content providers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17761] Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #58160|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 58162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58162=edit
Bug 17761 - Renewing or returning item via the checkouts table causes lost and
damaged statuses to disappear

Due to the fact that the lost and damaged status are contained within the
due_due span,
when the item is renewed or returned these statuses disappear.
Some librarians find this disconcerting and it seems that it would be better to
keep the visible.

Test Plan:
1) Find a lost item checked out to a patron
2) Renew that lost item via the checkouts table
3) Notice the lost status disappears from that row
4) Apply this patch
5) Refresh the page ( you may want to clear your browser cache as well )
6) Renew the item again
7) The lost status should remain visible!

Signed-off-by: Kyle M Hall 
Signed-off-by: Edie Discher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17761] Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17566] Change initial focus in item editor depending on last action

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17566

--- Comment #8 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #7)
> With the second patch, I don't see the focus at all.
> It seems to be on the first select because when I tab it selects the second
> select. But I cannot interact with it (select an option).

Thats a browser problem that I cannot solve.
The focus is there.
See commit message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17472] Borrower Previously Checked Out: Display title

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17472] Borrower Previously Checked Out: Display title

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #57247|0   |1
is obsolete||

--- Comment #12 from Jonathan Druart  
---
Created attachment 58161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58161=edit
Bug 17472: Borrower Previously Checked Out: Display title

Test plan:
0) apply the patch
1) turn on checking previously checkouts - syspref CheckPrevCheckout
2) checkout an item to borrower
3) check the item in and check it out again, you should see the
dialog, with information that the current item was previously checked
out to this patron. With this patch, the information includes title and
author of the item

Signed-off-by:  Nick Clemens 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17761] Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17761] Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #58112|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall  ---
Created attachment 58160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58160=edit
Bug 17761 - Renewing or returning item via the checkouts table causes lost and
damaged statuses to disappear

Due to the fact that the lost and damaged status are contained within the
due_due span,
when the item is renewed or returned these statuses disappear.
Some librarians find this disconcerting and it seems that it would be better to
keep the visible.

Test Plan:
1) Find a lost item checked out to a patron
2) Renew that lost item via the checkouts table
3) Notice the lost status disappears from that row
4) Apply this patch
5) Refresh the page ( you may want to clear your browser cache as well )
6) Renew the item again
7) The lost status should remain visible!

Signed-off-by: Kyle M Hall 
Signed-off-by: Edie Discher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Owen Leonard  changed:

   What|Removed |Added

   Assignee|jwea...@bywatersolutions.co |k...@bywatersolutions.com
   |m   |
 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17566] Change initial focus in item editor depending on last action

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17566

--- Comment #7 from Jonathan Druart  
---
With the second patch, I don't see the focus at all.
It seems to be on the first select because when I tab it selects the second
select. But I cannot interact with it (select an option).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #14 from Owen Leonard  ---
Created attachment 58159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58159=edit
Proposal for initial state of add guarantor form

It seems that now the search for patrons to select as a guarantor includes
patrons with a 'Child' type patron category. Is that intentional? Shouldn't
they be excluded?

I notice also that when you select a patron to be a guarantor, the patron
number is no longer a link to the patron record. I think it would make more
sense to not show the borrowernumber at all, but make the guarantor name a
link:

Surname, Firstname (cardnumber)

I think it's confusing that there are two buttons, 'Add guarantor', 'Set to
patron.' They could potentially mean the same thing. I think we might have the
initial state of this form have only two links: 'Search to add guarantor' and
'Add guarantor manually' (see attached image).

Clicking the 'Add manually' link would display the form along with a submit
button, and the "Clear" link would be shown.

The manual add form should prevent the user from submitting empty data.

Sorry, I know that's a lot, and I'm willing to help with follow-ups if folks
think these are good ideas.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17763] Exact ponctuation and words order is needed for matching results for author and title in adv. search

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17763

--- Comment #2 from Alexandre  ---
Hi Katrin,

I'm sorry, it's in the advanced search for acquisition module.

here is the link :
/koha/acqui/histsearch.pl

I must also correct something, it's for the search by author and by dealers
(not title). These terms must be exact to be found and with the good
ponctuation.

Thanks again,

Alexandre from CCSR

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #7 from Jonathan Druart  
---
Nick, do you have any good reasons to use DateTime instead of dt_from_string to
get today's date?

Note that you could have use Koha::Libraries->search->get_column('branchcode')
to get an iterator on the branchcodes.

Please resubmit tidying the whole file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17760] patron search not working in firefox

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17760

--- Comment #3 from Heinrich Hartl  ---
clearing the cache (Firefox options Advanced: Cached Web Content"clear now" has
solved the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #9 from Jonathan Druart  
---
accountlines_id has been removed from the param list, but it's still used in
tests.
We also need tests to highlight this change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #112 from Jonathan Druart  
---
QA comments (with bug 16735):

1/ treegrid plugin patches should be removed
2/ updatedb: I think we decided not to use Koha code from the updatedb process
3/ I have added a library to  __SEARCH_GROUPS__, on the adv search form, the
dropdown list contains an empty line, if I select it, the result list is empty
4/ There are 2 occurrences of Koha::Library->get_categories in
C4/Circulation.pm
5/ There is a lack of tests, some new subroutines are not tested
6/ DB structure
- updated_on could be "timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE
CURRENT_TIMESTAMP". That would avoid the trick in ->store
- Don't we want a constraint a the library_groups table? A unique key on title
for instance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187

--- Comment #40 from Magnus Enger  ---
(In reply to Chris Cormack from comment #37)
> We are actually evaluating 9580 at the moment to see if it will meet all the
> requirements of this bug. Will let you know shortly

Any results from the evaluation yet? ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15985] Include transacting library in fines

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985

Kyle M Hall  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17763] Exact ponctuation and words order is needed for matching results for author and title in adv. search

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17763

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17766] Patron notification does not work with multi item holds

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766

Benjamin Rokseth  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17766] Patron notification does not work with multi item holds

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766

--- Comment #1 from Benjamin Rokseth  ---
Created attachment 58158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58158=edit
Bug 17766 - Patron notification does not work with multi item holds

This patch fixes notification when same biblio has multiple reserves with same
borrower,
introduced in Bug 14695. C4::Reserves::ModReserveAffect uses internal method
_koha_notify_reserve but sends itemnumber and biblionumber instead of
record_id.

To test:
Prerequisites:
- One biblio with two items attached
- A patron with hold_filled notification activated
- A letter for HOLD with <> in it
1) Place two reservations on same biblio
2) checkin item x on pickup branch, observe patron message generated
3) checkin item y on pickup branch, observe patron message generated
4) note that reserve_id is the same on both messages, which is wrong
5) apply this patch and repeat 1-3
6) now observe notifications have correct (different) reserve_id

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17760] patron search not working in firefox

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17760

--- Comment #2 from Heinrich Hartl  ---
Problem doesn't exist when tested from another laptop (windows 10, also Firefox
50.0.2). This suggests the problem is a problem with the laptop and not with
koha.
I will try to give more details as soon as available.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17766] Patron notification does not work with multi item holds

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766

Benjamin Rokseth  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17758

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17758] SIP checkin does not handle holds correctly

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17758

Benjamin Rokseth  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17766

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||17767


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767
[Bug 17767] Let Koha::Patron::Modification handle extended attributes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle extended attributes

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17767] New: Let Koha::Patron::Modification handle extended attributes

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

Bug ID: 17767
   Summary: Let Koha::Patron::Modification handle extended
attributes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

This is actually needed in order to implement bug 13757, because the underlying
code doesn't handle extended attributes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle extended attributes

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||13757


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757
[Bug 13757] Make patron attributes editable in the opac if set to 'editable in
OPAC'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17760] patron search not working in firefox

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17760

--- Comment #1 from Heinrich Hartl  ---
Problem continues to exist after upgrading to koha stable (16.11.0).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15985] Include transacting library in fines

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985

--- Comment #2 from Kyle M Hall  ---
Created attachment 58157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58157=edit
Bug 15985 - Include transacting library in fines

Some librarians would like to see the library an item was checked out
from in the fines table on the fines payment page.

Test Plan:
1) Apply this patch
2) Find a patron with overdue items that have fines
3) Browse to the pay fines page
4) Note the new "checked out from" column

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15985] Include transacting library in fines

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #13 from Marcel de Rooy  ---
(In reply to Josef Moravec from comment #12)
> (In reply to Marcel de Rooy from comment #11)
> > (In reply to Kyle M Hall from comment #10)
> > > (In reply to Marcel de Rooy from comment #8)
> > > > Please adjust this parameter:
> > > > 
> > > > +lines  => [$line],
> > > > 
> > > > And check the comment on bug 15986 on the paypal script.
> > > 
> > > Not sure what you mean by this. Koha::Account::Pay accepts a 'lines'
> > > parameter.
> > 
> > Could you please double-check?
> > I cannot find it.
> 
> It was added by bug 15897 I think

OK That's clear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726

--- Comment #8 from Marcel de Rooy  ---
Created attachment 58156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58156=edit
Bug 17726: [QA Follow-up] Add test descriptions

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #58152|0   |1
is obsolete||

--- Comment #7 from Marcel de Rooy  ---
Created attachment 58155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58155=edit
Bug 17726: TestBuilder - Add default values

The items.more_subfields_xml is set to random data (generated by
TestBuilder), and so GetMarcBiblio does not manage to embed items (if
needed).

The error is:
  :1: parser error : Start tag expected, '<' not found

More precisely it explodes in
C4::Items::_parse_unlinked_item_subfields_from_xml when
MARC::Record->new_from_xml is called with an invalid xml

This patch adds a default values mechanism to TestBuilder to avoid
modifying all the existing calls.

Test plan:
Set SearchEngine to ElasticSearch
prove t/db_dependent/Circulation.pl
should return green with this patch

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17472] Borrower Previously Checked Out: Display title

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472

--- Comment #11 from Alex Sassmannshausen 
 ---
Hi Jonathan,

This is probably clear by now (I saw you obsoleted a patch).  The right patch
is Josef's.

Best wishes,

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17472] Borrower Previously Checked Out: Display title

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472

--- Comment #10 from Jonathan Druart  
---
I am lost with the different patches. Could someone tell me which one is the
good one?
Authorship has changed between the first submission and the last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17472] Borrower Previously Checked Out: Display title

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
  Attachment #57247|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17766] New: Patron notification does not work with multi item holds

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766

Bug ID: 17766
   Summary: Patron notification does not work with multi item
holds
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: benjamin.roks...@kul.oslo.kommune.no
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Bug 14685 introduces multi item holds on same record, but notifications
triggered by ModReserveAffect does not honour multiple this. When a patron has
multiple reserves on same record, notifications will only pick the first, as
the database query only uses biblionumber and borrowernumber.

_koha_notify_reserve in C4::Reserves is only used once anyway, so it should
probably be removed, but that is another bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17758] SIP checkin does not handle holds correctly

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17758

Benjamin Rokseth  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17758] SIP checkin does not handle holds correctly

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17758

--- Comment #2 from Benjamin Rokseth  ---
Created attachment 58154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58154=edit
Bug 17758 - SIP checkin does not handle holds correctly

This patch updates SIP checkin to use reserve_id as param, to fix regression
introduced by Bug 14695.

To test:

Given 1 patron and 1 biblio with two items attached:

1) create two record level holds on one biblio on same user
Using SIP client or telnet:
2) checkin item x on pickup branch, observe item is waiting and hold 1 is
filled
3) checkin item y on pickup branch, observe item y now is waiting and x is
available
4) apply this patch and repeat 1-3, now expected behaviour should be
   that both holds are filled and both items waiting

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14876] Show number of holds per record on the search results

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14876] Show number of holds per record on the search results

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #58013|0   |1
is obsolete||

--- Comment #27 from Jonathan Druart  
---
Created attachment 58153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58153=edit
Bug 14876 - Show number of holds per record on the search results

This patch sues the existing plugin
Koha::Template::Plugin::Biblio->HoldsCount

To be consistent with current behaviour 'Holds (0)' is shown when
no holds have been placed on an item

To test:
1 - Search in staff
2 - Note holds link has no extra information
3 - Apply patch
4 - prove -v t/db_dependent/Template/Plugin/Holds.t
5 - Do search in staff that returns records with some holds (i.e. place
some holds)
6 - Note the number of holds now displays next to the text of the link:
Holds (#)

Signed-off-by: Barbara Johnson 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7663] batch add barcodes to a list

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7663

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #5 from Jonathan Druart  
---
Nick, just a small concern: if you end with an empty line, you get "The item ()
does not exist". It seems easy to handle it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11698] Add validity check for amount on budget page

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11698

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17164

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17164] Software error when enrolment fee or reserve fee are too high (Patron categories)

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17164

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15770,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=11698

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15770] Number::Format issues with large numbers

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17164

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17164] Software error when enrolment fee or reserve fee are too high (Patron categories)

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17164

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
We use 28,6 for almost all the price fields, I think we should stick with it.
Have a look at bug 15770 and bug 11698.

Note that the tests should be executed in a transaction and these random data
should not persist in DB.
If it happens, we need to fix the tests, which are the root of the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726

--- Comment #6 from Jonathan Druart  
---
*** Bug 17727 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17727] A lot of tests fail if SearchEngine is set to Elastic

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17727

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|ASSIGNED|RESOLVED

--- Comment #2 from Jonathan Druart  
---
Will be fixed by bug 17726.

*** This bug has been marked as a duplicate of bug 17726 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17758] SIP checkin does not handle holds correctly

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17758

Benjamin Rokseth  changed:

   What|Removed |Added

 CC||benjamin.roks...@kul.oslo.k
   ||ommune.no

--- Comment #1 from Benjamin Rokseth  ---
on further investigation, SIP checkin only lacks the reserve_id param to
ModReserveAffect, which is rather weird, since it is the unique key on a
reserve.

Also ModReserveAffect and its called method _koha_notify_reserve should be
rewritten to use Koha::Holds, and use the reserve_id but I will do this in a
separate bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726

--- Comment #5 from Jonathan Druart  
---
Created attachment 58152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58152=edit
Bug 17726: TestBuilder - Add default values

The items.more_subfields_xml is set to random data (generated by
TestBuilder), and so GetMarcBiblio does not manage to embed items (if
needed).

The error is:
  :1: parser error : Start tag expected, '<' not found

More precisely it explodes in
C4::Items::_parse_unlinked_item_subfields_from_xml when
MARC::Record->new_from_xml is called with an invalid xml

This patch adds a default values mechanism to TestBuilder to avoid
modifying all the existing calls.

Test plan:
Set SearchEngine to ElasticSearch
prove t/db_dependent/Circulation.pl
should return green with this patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17702] Create configuration for account types

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

--- Comment #11 from Josef Moravec  ---
(In reply to Radek Šiman (R-Bit Technology, s.r.o.) from comment #9)
> (In reply to Josef Moravec from comment #1)
> > Created attachment 57856 [details] [review] [review]
> > Bug 17702: Account types configuration - db changes
> > 
> > Test plan:
> > 1) Read the diff and confirm that it does make sense
> > 2) Comment what does not make sense ;)
> 
> According to db changes, is it possible to extend type_code from only 5
> chars to (let's say) 10 chars? It would be very useful for some libraries
> having a longer list of payments not to be so cryptic. For instance, one of
> them (Czech only - sorry):

I have no problem with this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17702] Create configuration for account types

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

--- Comment #10 from Josef Moravec  ---
(In reply to Chris Kirby from comment #8)
> (In reply to comment #7), 
> Hi Josef, thanks for the tip to upgrade the db schema.
> 
> When one creates a "manual invoice" for a patron using one of the created
> debit types, both the debit type code and the description are entered into
> the "Description of charges." However, for the pre-existing debit types, the
> debit type description is entered twice in the "description of charges".
> Is there any reason for this difference?

It's a bug, I am going to work on this a bit more...


> When one creates a credit type, there is no field for default amount. Is
> there any reason for leaving a default amount out of the credit type but
> keeping it in the debit?

Yes, the reason is, the when you are creating manual invoice, you often know
the price of some kind of things, but you can't pretend which amount are people
going to pay, or so...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17702] Create configuration for account types

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578

Jonathan Druart  changed:

   What|Removed |Added

 CC||koha.sek...@gmail.com

--- Comment #64 from Jonathan Druart  
---
*** Bug 7058 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7058] GetMemberDetails must die!

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7058

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|NEW |RESOLVED

--- Comment #1 from Jonathan Druart  
---


*** This bug has been marked as a duplicate of bug 17578 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #57727|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart  
---
Created attachment 58151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58151=edit
Bug 17666: Revert "Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of
File::Slurp"

This reverts commit 7ac1bc35372990520a7c67870b2c702c41bbebcc.

On a kohadevbox:
Error flock (1) on
'/home/vagrant/kohaclone/installer/data/mysql/atomicupdate/bug_.perl':
No locks available at installer/data/mysql/updatedatabase.pl line 13637.

This is because Path::Tiny->slurp[_utf8] uses flocks which does not work
with NFS

Test plan:
Execute a .perl atomic update file on a kohadevbox
=> Without this patch you should get the flock error
=> With this patch the update should work fine

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907

--- Comment #12 from Josef Moravec  ---
(In reply to Marcel de Rooy from comment #11)
> (In reply to Kyle M Hall from comment #10)
> > (In reply to Marcel de Rooy from comment #8)
> > > Please adjust this parameter:
> > > 
> > > +lines  => [$line],
> > > 
> > > And check the comment on bug 15986 on the paypal script.
> > 
> > Not sure what you mean by this. Koha::Account::Pay accepts a 'lines'
> > parameter.
> 
> Could you please double-check?
> I cannot find it.

It was added by bug 15897 I think

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17234, 17666


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
[Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7.  This breaks
updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666
[Bug 17666] .perl atomic update does not work under kohadevbox
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17762


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762
[Bug 17762] Ability to translate notices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17762


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762
[Bug 17762] Ability to translate notices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7058] GetMemberDetails must die!

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7058

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
 Depends on||17578


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578
[Bug 17578] Replace GetMemberDetails with GetMember
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578

Josef Moravec  changed:

   What|Removed |Added

 Blocks||7058


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7058
[Bug 7058] GetMemberDetails must die!
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58148|0   |1
is obsolete||

--- Comment #8 from Josef Moravec  ---
Created attachment 58150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58150=edit
Bug 17742: Fix t/db_dependent/Patrons.t

Moves the getting of testing date for updated_on just after the storing
the test patron data to make the gap between generating data and now
date as short as possible

Fixes test 7

Use Koha::Database instead of C4::Context->dbh

Test plan
1. prove t/db_dependent/Patrons.t
2. read the diff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #58128|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 58149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58149=edit
Bug 14146: Add the new pref CumulativeRestrictionPeriods

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17401] Returns form not submitting after printing slip

2016-12-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17401

Benjamin Rokseth  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Benjamin Rokseth  ---
Hi Katrin, there might be a bug in the bug ;) I believe we blamed the
prevendefault for another weird behaviour, but unable to reproduce now, so
either it is fixed, or we had a hickup. Closing this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

98 matches

Mail list logo