date:20170109

[Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #58719|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 58720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58720&action=edit
Bug 17870 - Call to include file incorrectly moved into the footer

This patch moves a line of template code from js_includes.inc back into
doc-head-close.inc where it belongs.

To test, apply the patch and view a page which uses a template that
depends on html_helpers.inc being processed. For example:

- The set library page
- The holds queue report
- The new patron form

The pages should work correctly.

Signed-off-by: Claire Gravely 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870

Claire Gravely  changed:

   What|Removed |Added

  Attachment #58705|0   |1
is obsolete||

--- Comment #3 from Claire Gravely  ---
Created attachment 58719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58719&action=edit
Bug 17870 - Call to include file incorrectly moved into the footer

This patch moves a line of template code from js_includes.inc back into
doc-head-close.inc where it belongs.

To test, apply the patch and view a page which uses a template that
depends on html_helpers.inc being processed. For example:

- The set library page
- The holds queue report
- The new patron form

The pages should work correctly.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13528] Ability to search on the different isbn variations

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528

Magnus Enger  changed:

   What|Removed |Added

 Blocks||17457


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17457
[Bug 17457] Use SearchWithISBNVariations in acquisition advanced search
(histsearch.pl)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17457] Use SearchWithISBNVariations in acquisition advanced search ( histsearch.pl)

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17457

Magnus Enger  changed:

   What|Removed |Added

 Depends on||13528
 CC||mag...@libriotech.no


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528
[Bug 13528] Ability to search on the different isbn variations
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||mtomp...@hotmail.com

--- Comment #11 from M. Tompsett  ---
With plack changes and the like, this no longer applies. :(
Tinkered with getting it up, but not finished, so marking does not apply until
someone rebases or fixes it. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814

--- Comment #5 from Pongtawat  ---
TEST PLAN
-
1) Login to staff client and do something that will hold connection for a long
time, e.g. a batch import or a slow report.
2) sudo koha-plack --stop mykoha
3) ps aux | grep plack   <-- a Plack process will still running work in 1)
4) wait for 1) to finish and all Plack processes exit
5) sudo koha-plack --start mykoha
6) apply the patch
7) repeat step 1)-2)
8) ps aux | grep plack   <-- There should be no Plack process running now
9) Note that work in step 1) might get terminated midway. Since we force Plack
to stop after some wait.

Alternatively, I think we can test with --restart too. Before patch, it should
behave like in comment 3. After patch, it should restart properly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814

--- Comment #4 from Pongtawat  ---
Won't --restart work properly if stop work properly? 
>From the code, it seems that --restart just call stop and then start.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871

David Cook  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871

--- Comment #2 from David Cook  ---
Created attachment 58718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58718&action=edit
Bug 17871 - Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1

Remove line , which causes
retrieval failures for zebra::* elements when using YAZ 5.8.1.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871

David Cook  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871

--- Comment #1 from David Cook  ---
I've sent emails to Adam Dickmeiss and i...@indexdata.com, so hopefully
IndexData can shine some light on this one.

In the meantime, I think a configuration change would be acceptable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17871] New: Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871

Bug ID: 17871
Summary: Can't retrieve facets (or zebra::snippet) from Zebra
with YAZ 5.8.1
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Z39.50 / SRU / OpenSearch Servers
Assignee: gmcha...@gmail.com
Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Colin Campbell and Frédéric Demians mentioned in 2015 that Zebra facets don't
work with YAZ 5.8.1:
https://lists.katipo.co.nz/public/koha/2015-February/041987.html

In 2016, Zeno said he couldn't get zebra::snippet to work:
http://koha.1045719.n5.nabble.com/Zebra-the-elements-zebra-snippet-doesn-t-work-td5871444.html

I've looked at Indexdata's YAZ git repo for 5.8.1:
https://github.com/indexdata/yaz/blame/v5.8.1/src/retrieval.c

And I think the problem is this commit:
https://github.com/indexdata/yaz/commit/f24766f1e9fc5404fc0b512af8607d7f7054f4be

At first, I thought the problem was with yaz_match_glob, but I've tested this
function independently, and I think it's OK. I think the problem might be with
how "el_best" is getting set.

In theory, should be selected as el_best first...
then zebra::* should be selected as it should have a true value returned from
yaz_match_glob. (Note that "return 0" appears to indicate success for
yaz_retrieval_request.)

So if you try to use facets with YAZ 5.8.1, you get the following from Zebra:
[25] Specified element set name not valid for specified database -- v2 addinfo
''.

That makes it seem like el_best isn't being set at all... but I don't know. I'm
going to email Indexdata and see what they come up with for this one.

But in any case... I have a solution for now.

If we remove the line and restart
Zebra, we can get results using zebra::facet and zebra::snippet.

I've tested this change with OpenSuse Leap 42.2 with Zebra 2.0.60 and YAZ
5.8.1, and it works, but I'd be interested in hearing about other people's
experiences with older (and newer) versions of YAZ.

With commit 67abcc64, Marcel actually removed most unnecessary retrieval
elements, but Tomas added them back with ca074c92 along with the zebra::* line.

--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

M. Tompsett  changed:

   What|Removed |Added

   Keywords||Academy
 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

M. Tompsett  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

--- Comment #5 from M. Tompsett  ---
Created attachment 58717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58717&action=edit
Bug 15702: Trim whitespace from fields with non-whitespace data

Since space may be a valid value for something, trimming what has
non-whitespace was done.

TEST PLAN
-
1) Enter patron with spaces before, after, and both.
2) Apply patch.
3) Attempt to enter another patron with spaces before, after, and both.
   -- attempting to edit after saving will demonstrate the spaces
  were trimmed.
4) Attempt to edit the patron initially entered.
   -- while there may be spaces before, after, and both initially,
  after saving and trying to edit again, there will not be.
5) run koha qa test tools.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15908] Remove use of recordpayment_selectaccts

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15908

--- Comment #5 from M. Tompsett  ---
Comment on attachment 52152
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52152
Bug 15908 - Remove use of recordpayment_selectaccts

Review of attachment 52152:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15908&attachment=52152)
-

Perhaps it is an extra constraint, but the code isn't identical without it.
Results should be identical though.

::: C4/Accounts.pm
@@ -372,5 @@
> -
> -my @lines = Koha::Account::Lines->search(
> -{
> -borrowernumber=> $borrowernumber,
> -amountoutstanding => { '<>' => 0 },

Why is...

::: members/paycollect.pl
@@ +135,5 @@
> +
> +my @lines = Koha::Account::Lines->search(
> +{
> +borrowernumber=> $borrowernumber,
> +accountno => { 'IN' => \@acc },

... this not here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 2.4+

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255

--- Comment #28 from Chris Cormack  ---
(In reply to Olli-Antti Kivilahti from comment #27)
> Has there been any discussion about migrating to ElasticSearch 5.1 instead
> of 2.4?
> 
> I ran a small test setup back home (using Ubuntu16.04) during the weekends
> and discovered that I had accidentally installed ElasticSearch 5.1 and
> Catmandu dependencies from cpan, and that indexing and searching and
> deleting worked with no probs using the Catmandu::Store::Elasticsearch
> perldoc examples with "the" compatibility patch in the perldoc.
> 
> Will look into that tomorrow and hopefully provide a patch for running with
> ES 5.1

Nope no discussion yet (5.1 only came out in December) But I think going to 5.1
seems sensible enough to me

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17867] Improve display of source (MARC21 773) in result list

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17867

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17788] (MARC21) $9 fields not indexed in authority-linked fields

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
Linking the same authority type to multiple bibliographic fields should not
cause any problem. As those are custom use fields, I think it's ok as it is. If
someone needs a different framework for them, it can be added via the
configuration.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #18 from Alex Buckley  ---
I will go through and rebase shortly and then push up the commits again for
testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233

M. Tompsett  changed:

   What|Removed |Added

  Attachment #55098|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233

--- Comment #3 from M. Tompsett  ---
Created attachment 58716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58716&action=edit
[SIGNED-OFF] Bug 17233 - Add 008 value builder plugin for MARC21
classifications

This patch adds 008 cataloguing value builder for MARC21 classifications
records (LCC, DDC/Dewey, UDC and so on).

For most practical purposes, MARC21 classification records
() are quite similar to regular
MARC21 authority records, so handling them in Koha is (almost) achievable
by means of the built-in 'regular' MARC21 authority records related
functionalities, but there are some notable differences - in particular,
008 field length and format is not the same.

To test:

1) apply patch
2) link the new plugin (marc21_field_008_classifications.pl) to the 008
field in the existing (or cloned, ..) authority framework of your choice
3) try to add, edit, re-edit 008 field using this "authority" framework,
ensure that the new plugin behaves as it should according to the
Library of Congress specifications for MARC21 classification records
008 field format ().

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #2 from M. Tompsett  ---
There was another plug in that did a really cool single line at the top and
highlight and update thing, but this generally works.

An improvement would be highlighting changes, because if I put an invalid value
in the field and then call up the builder, it defaults to a valid value in the
part that is invalid.

But I don't think this is a reason to block this. Signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814

Barton Chittenden  changed:

   What|Removed |Added

 CC||bar...@bywatersolutions.com

--- Comment #3 from Barton Chittenden  ---
I think that --restart also has this issue. Here's a paste from a recent
restart:

sudo koha-plack --restart glenoaks
[] Restarting Plack daemon for glenoaks:[] Stopping Plack daemon for
gle[ ok :.
[FAIL] Error: Plack already running for glenoaks: failed!
 failed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #17 from M. Tompsett  ---
(In reply to Alex Buckley from comment #16)
> M. Tompsett. Thank you of informing me of this. 
> 
> I have now gone through and obsoleted older patches including the patch that
> was causing the failure.
> 
> So try seeing if it will apply for you now.

Still fails. I'm thinking you are patching an old version of master. You may
need to rebase.

$ git checkout master
$ git pull
$ git checkout -b bug_17855_retest1 origin/master
$ git bz apply 17855
-- This should fail.
$ git bz apply --abort
$ git checkout bug_17855
-- probably discover your are out some changes, not just these.
-- I'm assuming you generally name your branches bug_#.
$ git rebase origin/master
$ git bz attach -e HEAD..HEAD
-- there are 8 ^'s. That should get all your patches.
$ git checkout bug_17855_retest1
-- probably some messages about being out of sync, doesn't matter.
$ git reset --hard origin/master
$ git bz apply 17855
-- hopefully this will work now.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #16 from Alex Buckley  ---
M. Tompsett. Thank you of informing me of this. 

I have now gone through and obsoleted older patches including the patch that
was causing the failure.

So try seeing if it will apply for you now.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #58429|0   |1
is obsolete||

--- Comment #61 from Tomás Cohen Arazi  ---
Created attachment 58714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58714&action=edit
Bug 13757: (followup) Regression tests for ->approve changes

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #58703|0   |1
is obsolete||

--- Comment #59 from Tomás Cohen Arazi  ---
Created attachment 58712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58712&action=edit
Bug 13757: (followup) Staff interface changes

This patch adds proper extended attributes display and handling on the
patron modifications moderation page (members-update.pl).

It also adds changes checking to the opac-memberentry.pl page so it
only saves a modification request if there are changes (it only checked
regular fields and not the extended ones).

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #58581|0   |1
is obsolete||

--- Comment #62 from Tomás Cohen Arazi  ---
Created attachment 58715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58715&action=edit
Bug 13757: (followup) Fix authorized value display when opac_display & not
opac_editable

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #58428|0   |1
is obsolete||

--- Comment #60 from Tomás Cohen Arazi  ---
Created attachment 58713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58713&action=edit
Bug 13757: (followup) Only touch opac_editable attributes

As reported by Owen, the members-update.pl was showing every attributes
the patron has (display issue) instead of showing only those affected by
the changes.

This patch fixes this by filtering the patron's attributes by opac
editability.

It also fixes Koha::Patron::Modification->approve so it only clears the
attributes with the updating 'code' and leaves the others untouched.
As its been coded so far (until someone refactors it all) the
Koha::Patron::Modification object needs to contain all the attributes
for a specific code. And it comes from parsing the UI's input.

Tests for Koha::Patron::Modification->approve to come.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #58356|0   |1
is obsolete||

--- Comment #58 from Tomás Cohen Arazi  ---
Created attachment 58711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58711&action=edit
Bug 13757: (followup) Remove warnings

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #58355|0   |1
is obsolete||

--- Comment #57 from Tomás Cohen Arazi  ---
Created attachment 58710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58710&action=edit
Bug 13757: Add extended attributes to the patron modification

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #58354|0   |1
is obsolete||

--- Comment #56 from Tomás Cohen Arazi  ---
Created attachment 58709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58709&action=edit
Bug 13757: DBIC update

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #58353|0   |1
is obsolete||

--- Comment #55 from Tomás Cohen Arazi  ---
Created attachment 58708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58708&action=edit
Bug 13757: OPAC changes

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #58352|0   |1
is obsolete||

--- Comment #54 from Tomás Cohen Arazi  ---
Created attachment 58707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58707&action=edit
Bug 13757: DB update

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #58351|0   |1
is obsolete||

--- Comment #53 from Tomás Cohen Arazi  ---
Created attachment 58706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58706&action=edit
Bug 13757: Add the option to set patron attributes editable in the OPAC

Note: this is a squashed version of the original patchset, because it was
needed

This patch adds an opac_editable property of borrower attribute types
that can be set in the interface. I'm removing work on OPAC and will
refactor it, keeping the author attribution.

Test plan:
  1. Repeat the following with a new and existing borrower attribute
 type:
  2. Verify that "Editable in OPAC" can only be checked if "Display in
 OPAC" is checked.
  3. Verify that this new property is correctly saved.

Signed-off-by: Aleisha 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #58661|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #58660|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #58659|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #58658|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #58657|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870

--- Comment #2 from Owen Leonard  ---
Created attachment 58705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58705&action=edit
Bug 17870 - Call to include file incorrectly moved into the footer

This patch moves a line of template code from js_includes.inc back into
doc-head-close.inc where it belongs.

To test, apply the patch and view a page which uses a template that
depends on html_helpers.inc being processed. For example:

- The set library page
- The holds queue report
- The new patron form

The pages should work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870

--- Comment #1 from Owen Leonard  ---
Affected would be any templates which include:

[% PROCESS options_for_libraries...

or

[% PROCESS options_for_authorised_value_categories...

...because those blocks are defined in html_helpers.inc. The breakage would
only occur if you tried to add [% SET footerjs = 1 %] to any of those
templates.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16984] Standing orders - when ordering a JS error is raised

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16984

Claire Gravely  changed:

   What|Removed |Added

  Attachment #57695|0   |1
is obsolete||

--- Comment #8 from Claire Gravely  ---
Created attachment 58704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58704&action=edit
Bug 16984: Do not clone the item block for standing orders

If AcqCreateItem is set to ordering and the basket is marked as
"standing orders", when ordering a JS error is raised:
additem.js:176 Uncaught TypeError: window[events[i]] is not a function

The item block should not be displayed in that case.

Test plan:
- Set AcqCreateItem to "ordering"
- Create a basket and tick the "Standing orders" checkbox
- Add an order to this basket
=> Without this patch you get the JS error
=> With this patch applied you will not get it

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16984] Standing orders - when ordering a JS error is raised

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16984

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897

--- Comment #13 from Kyle M Hall  ---
Created attachment 58701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58701&action=edit
Bug 15897 - Folowup Revert "Bug 15896: [QA Follow-up] Add accountlines_id
parameter in paycollect"

This reverts commit b6d5748c001febc5acd67938d12ba25844d11fbc.

As this bug report no more uses the accounline_id parameter to identify
account lines to pay in Koha::Account->pay, it should revert this, to
use the new notation everywhere.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #58698|0   |1
is obsolete||

--- Comment #11 from Kyle M Hall  ---
Created attachment 58699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58699&action=edit
Bug 15897 - Use Koha::Account::pay internally for recordpayment_selectaccts

This is the third patch in a series to unify all payment functions into
a single mathod

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Accounts.t
3) Test fine payment via the "Pay selected" button

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16984] Standing orders - when ordering a JS error is raised

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16984

--- Comment #7 from Claire Gravely  ---
(In reply to Claire Gravely from comment #6)
> I have also been unable to reproduce the issue.

have now reproduced - will retest

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17859] Move JavaScript to the footer on about and auth pages

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859

Owen Leonard  changed:

   What|Removed |Added

 Depends on||17870


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870
[Bug 17870] Call to include file incorrectly moved into the footer
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17870] New: Call to include file incorrectly moved into the footer

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870

Bug ID: 17870
   Summary: Call to include file incorrectly moved into the footer
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: major
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: bouzid.ferg...@inlibro.com,
jonathan.dru...@bugs.koha-community.org,
katrin.fisc...@bsz-bw.de, k...@bywatersolutions.com,
philippe.blo...@inlibro.com,
testo...@bugs.koha-community.org
Depends on: 17416, 17418
Blocks: 17858, 17859

In Bug 17418 I moved a line from doc-head-close.inc to js_includes.inc which I
shouldn't have: 

-[% PROCESS 'html_helpers.inc' %]

That file isn't JS and many pages depend on it being defined at the top of the
page.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416
[Bug 17416] Move javascript in doc-head-close.inc into a separate include
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418
[Bug 17418] Move staff client home page JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859
[Bug 17859] Move JavaScript to the footer on about and auth pages
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17418] Move staff client home page JavaScript to the footer

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418

Owen Leonard  changed:

   What|Removed |Added

 Blocks||17870


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870
[Bug 17870] Call to include file incorrectly moved into the footer
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard  changed:

   What|Removed |Added

 Depends on||17870


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870
[Bug 17870] Call to include file incorrectly moved into the footer
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17416] Move javascript in doc-head-close.inc into a separate include

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416

Owen Leonard  changed:

   What|Removed |Added

 Blocks||17870


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870
[Bug 17870] Call to include file incorrectly moved into the footer
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #58357|0   |1
is obsolete||

--- Comment #52 from Tomás Cohen Arazi  ---
Created attachment 58703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58703&action=edit
Bug 13757: (followup) Staff interface changes

This patch adds proper extended attributes display and handling on the
patron modifications moderation page (members-update.pl).

It also adds changes checking to the opac-memberentry.pl page so it
only saves a modification request if there are changes (it only checked
regular fields and not the extended ones).

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #58699|0   |1
is obsolete||

--- Comment #12 from Kyle M Hall  ---
Created attachment 58700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58700&action=edit
Bug 15897 - Use Koha::Account::pay internally for recordpayment_selectaccts

This is the third patch in a series to unify all payment functions into
a single mathod

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Accounts.t
3) Test fine payment via the "Pay selected" button

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897

--- Comment #14 from Kyle M Hall  ---
Created attachment 58702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58702&action=edit
Bug 15897 [QA Followup] - Update unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #58092|0   |1
is obsolete||
  Attachment #58094|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall  ---
Created attachment 58698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58698&action=edit
Bug 15897 - Use Koha::Account::pay internally for recordpayment_selectaccts

This is the third patch in a series to unify all payment functions into
a single mathod

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Accounts.t
3) Test fine payment via the "Pay selected" button

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17869] Don' t show pick-up library for holds in OPAC account when there is only one branch

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17869] New: Don' t show pick-up library for holds in OPAC account when there is only one branch

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869

Bug ID: 17869
   Summary: Don't show pick-up library for holds in OPAC account
when there is only one branch
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

When there is only one branch in an installation, it makes no sense to show a
pick-up library column in the holds list in the patron account in OPAC.

We should remove it from display, as we do in other spots.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #29 from Andrew Isherwood  ---
(In reply to Owen Leonard from comment #22)

Hi Owen

Thanks *very* much for your feedback, hugely useful. I've just attached a bunch
of modified patches that address most of the points, pertinent comments below
each of your points.

> I've done a quick run-through of this and nothing looks broken. The tests
> all pass. I think the biggest gap is documentation. There should be a help
> file for the whole process, especially the things which aren't
> self-explanatory. For instance:
> 
> - What does the 'cyclical' setting do?
> - What is the purpose of the "Start" item in the stages
>   and duration column of the manage items table?
> - What does the "In demand" setting do?

Excellent point, we'll address that.

> Minor problems:
> 
> - Our capitalization rules say the heading should say
>   "Stock rotation" instead of "Stock Rotation"

Fixed  

> 
> - I don't the the alert-style div is correct for showing
>   a confirmation of items added. I would put the confirmation
>   message in a  and show a
>   table of results below that.

Yes, agreed, fixed.

> - In the manage items table, there is no  wrapping .

I couldn't replicate this. I looked in the markup for the manage items table
and there was definitely a  wrapping . I'm not sure if I'm
misunderstanding where you mean.

> - The page title and breadcrumbs should be made more specific
>   for each page. For instance, when on the manage items page
>   the breadcrumbs should be:
> 
>   Home › Tools › Stock rotation > Manage items
> 
>   This provides an easily accessible link back to the main
>   stock rotation page.

Yes, excellent point. This has now been addressed throughout.

> Suggestions:
> 
> - Add a toolbar to the manage items page with a 'New rota'
>   and 'Edit rota' buttons.

Done.

> - Move the add items forms to the top of the [items table]

Done.

> - In the manage items table, I think title and barcode
>   should link to the bibliographic record and items page,
>   respectively.

Done.

> - Make the manage items table a DataTable with sorting and
>   searching. Unless you think the items table will typically
>   hold so much data this would become cumbersome?

I don't imagine it will, good suggestion. Done.

> - Should item status information be displayed in the manage
>   items table? Is it relevant to the process to know whether
>   something is checked out, lost, etc?

Not sure how immediately useful this will be, particularly as we're linking
directly to the item from the barcode in the row. I got a consensus of opinions
here and the majority felt it wasn't necessary. Thanks for the suggestion
though.

> - Since the drag-to-sort interaction is new to Koha it
>   probably needs a hint at the top to suggest it. (Looks 
>   good and work well, though).

Done.

Again, thanks for your feedback. If you find time to go through the latest
changes, I'd be very grateful. I'll update this bug when we have some
accompanying docs.

Cheers
Andrew

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17868] New: Improve display of authors in cart and list emails

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17868

Bug ID: 17868
   Summary: Improve display of authors in cart and list emails
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Lists
  Assignee: gmcha...@gmail.com
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

The cart and list emails display a lot of subfields for the author. Example:

Author: Seemann, Christian --Bearb. --adp
$a $e $4

It would be nice to not display $4 (relator code) if there is $e (relator
term).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

Claire Gravely  changed:

   What|Removed |Added

  Attachment #58691|0   |1
is obsolete||

--- Comment #84 from Claire Gravely  ---
Created attachment 58697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58697&action=edit
Bug 16239 [CSS Follow-up] Upgrade Bootstrap in the staff client

This followup tweaks some CSS and markup in order to correct conflicts
between default Bootstrap styles and the expected (previous) style of
the staff client. Included:

- Corrections to the widths of some modals.
- Corrections to the style of the  tag, seen often in MARC preview
  modals.
- Corrections to the default active and hover states for dropdown menus.

To test, apply the patch and view various pages which use Bootstrap
modals, confirming that they look correct.

- Add order from staged file MARC preview
- Add order from external source MARC preview
- Cataloging record merge MARC preview
- Batch record modification MARC preview
- Authorities Z39.50 search MARC preview

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 2.4+

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255

--- Comment #26 from Olli-Antti Kivilahti  ---
Created attachment 58690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58690&action=edit
Bug 17255 - Upgrade Elastic Search code to work with version 2.4+ - rebased wip

-Changed deprecated facets to aggregations
-Fixed boolean datatypes not allowing analyzers to be specified
-Fixed deprecated '_id' to 'es_id'. Now the ES-index has the correct
id==biblionumber

ZE TEST PLAN

1. Reset Zebra index since facets are hard coded to dynamic
search_marc_mappings.
2. perl misc/search_tools/rebuild_elastic_search.pl
3. Fetch all indexed records and the facet for subject__facet

curl -XGET localhost:9200/koha_biblios/data/_search?pretty -d '{
  "aggregations": {
"my_agg": {
  "terms": {
"field": "subject__facet"
  }
}
  }
}'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #27 from Andrew Isherwood  ---
Created attachment 58695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58695&action=edit
Bug 11897: Interface for rota items from biblio

* catalogue/stockrotation.pl: New file
* koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/stockrotation.tt:
New file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #28 from Andrew Isherwood  ---
Created attachment 58696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58696&action=edit
Bug 11897: Add menu options for Stock Rotation

* koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc: Add
menu option
* koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc: Add menu
option
* koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt: Add menu
option

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #26 from Andrew Isherwood  ---
Created attachment 58694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58694&action=edit
Bug 11897: Interface for rotas from Tools menu

* tools/stockrotation.pl: New file
* koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt: New file
* koha-tmpl/intranet-tmpl/prog/en/includes/stockrotation-toolbar.inc:

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #25 from Andrew Isherwood  ---
Created attachment 58693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58693&action=edit
Bug 11897: Add Stock Rotation permissions to list

* koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc: Add new
permissions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #24 from Andrew Isherwood  ---
Created attachment 58692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58692&action=edit
Bug 11897: Add Stockrotation CSS rules

* koha-tmpl/intranet-tmpl/prog/css/staff-global.css: New rules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #58281|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #58216|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #58217|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #58280|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 2.4+

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 CC||olli-antti.kivila...@jns.fi

--- Comment #27 from Olli-Antti Kivilahti  ---
Has there been any discussion about migrating to ElasticSearch 5.1 instead of
2.4?

I ran a small test setup back home (using Ubuntu16.04) during the weekends and
discovered that I had accidentally installed ElasticSearch 5.1 and Catmandu
dependencies from cpan, and that indexing and searching and deleting worked
with no probs using the Catmandu::Store::Elasticsearch perldoc examples with
"the" compatibility patch in the perldoc.

Will look into that tomorrow and hopefully provide a patch for running with ES
5.1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

Claire Gravely  changed:

   What|Removed |Added

  Attachment #58683|0   |1
is obsolete||

--- Comment #83 from Claire Gravely  ---
Created attachment 58691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58691&action=edit
Bug 16239 [CSS Follow-up] Upgrade Bootstrap in the staff client

This followup tweaks some CSS and markup in order to correct conflicts
between default Bootstrap styles and the expected (previous) style of
the staff client. Included:

- Corrections to the widths of some modals.
- Corrections to the style of the  tag, seen often in MARC preview
  modals.
- Corrections to the default active and hover states for dropdown menus.

To test, apply the patch and view various pages which use Bootstrap
modals, confirming that they look correct.

- Add order from staged file MARC preview
- Add order from external source MARC preview
- Cataloging record merge MARC preview
- Batch record modification MARC preview
- Authorities Z39.50 search MARC preview

Signed-off-by: Claire 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #58687|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #22 from Kyle M Hall  ---
Created attachment 58689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58689&action=edit
Bug 14570 - Update Schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #58146|0   |1
is obsolete||
  Attachment #58412|0   |1
is obsolete||

--- Comment #21 from Kyle M Hall  ---
Created attachment 58688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58688&action=edit
Bug 14570 - Make it possible to add multiple guarantors to a record

This patch adds the ability to set an unlimited number of guarantors
for a given patron. As before, each guarantor may be linked to another
Koha patron, and all the behavior that applies to a given guarantor
remains the same.

Test Plan:
 1) Apply this patch
 2) Run updatedatabase.pl
 3) Find some patrons with guarantors, verify the still have their guarantor
 4) Test adding and removing guarantors on a patron record, both Koha users and
not
 5) Verify the "Add child" button works
 6) Verify NoIssuesChargeGuarantees still works
 7) Verify tools/cleanborrowers.pl will not delete a guarantor
 8) Verify the guarantors are displayed on moremember.pl
 9) Verify the guarantor is removed by members/update-child.pl
10) Verify the guarantor is removed by misc/cronjobs/j2a.pl
11) Verify import patrons converts guarantor_id, relationship,
contactfirstname,
  and contactsurname into a guarantor
12) prove t/Patron.t
13) prove t/db_dependent/Circulation.t
14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
15) prove t/db_dependent/Items.t
16) prove t/db_dependent/Koha/Patrons.t
17) prove t/db_dependent/Members.t
18) prove t/db_dependent/Patron/Relationships.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Andrew Isherwood  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #58215|0   |1
is obsolete||

--- Comment #23 from Andrew Isherwood  ---
Created attachment 58687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58687&action=edit
Bug 11897: Add Stockrotation CSS rules

* koha-tmpl/intranet-tmpl/prog/css/staff-global.css: New rules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

--- Comment #14 from Chris Kirby  ---
(In reply to Tomás Cohen Arazi from comment #13)
> Note for testers: this patches need to be tested with 13757 applied on top
> of them. Otherwise some tests will be skipped.

applied the following patches:17755, 17813 (followed by updatedatabase.pl), 
17792, (followed by updatedatabase.pl), 13757.

13757 doesn't apply cleanly over 17792: 
 https://snag.gy/q4co8z.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #15 from M. Tompsett  ---
I was hoping to test this, but got:
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 17855- In web installer step 3, automatically selected default
data values are successfully being inserted into the database.
Applying: Bug 17855 - As with the last patch the updated web installers step 3
is showing bulletpoints for default data values which stops the user being able
to unselect data neccisary to use Koha.
Applying: Bug 17855 - Implemented basic and advanced setup modes in the web
installer avalable on the MARC flavour selection page of step 3.
Applying: Bug 17855 - Finished front end of onboarding tool which user is
redirected to (after authentication) after finishing the web installer.
/home/vagrant/kohaclone/.git/rebase-apply/patch:391: trailing whitespace.

/home/vagrant/kohaclone/.git/rebase-apply/patch:402: trailing whitespace.

/home/vagrant/kohaclone/.git/rebase-apply/patch:410: trailing whitespace.

/home/vagrant/kohaclone/.git/rebase-apply/patch:416: trailing whitespace.
[% ELSE %]
/home/vagrant/kohaclone/.git/rebase-apply/patch:470: trailing whitespace.
[% END %]
fatal: sha1 information is lacking or useless (installer/onboarding.pl).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 17855 - Finished front end of onboarding tool which
user is redirected to (after authentication) after finishing the web installer.
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-17855---Finished-front-end-of-onboarding-tool--YKACAI.patch

Perhaps you have forgotten to obsolete older patches on this bug as well?
Click Details, Edit details, check obsolete, and everything else is hopefully
obvious. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17867] New: Improve display of source (MARC21 773) in result list

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17867

Bug ID: 17867
   Summary: Improve display of source (MARC21 773) in result list
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Bibliographic data support
  Assignee: gmcha...@gmail.com
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

Currently only $t is shown. If there is no author in $a, the title goes in $a
and there is no $t. We should also catch this case and show at least a and t.

>From the XSLT:
 928 
 929 
 930 
 931 
 932 Source: 
 933 
 934 
 935 
 936 
 937 

Note: if there were multiple 773, the lable would be printed mulitple times.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17788] (MARC21) $9 fields not indexed in authority-linked fields

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788

Hugo Agud  changed:

   What|Removed |Added

 CC||ha...@orex.es
 Status|Needs Signoff   |Signed Off

--- Comment #3 from Hugo Agud  ---
I have checked that all those fields are now indexed and this bugs it is signed
off BUT under  my undestading this opens a new bug regarding the authorities

For example 650  SUBJECT ADDED ENTRY--TOPICAL TERM and 690 - LOCAL SUBJECT
ADDED ENTRY--TOPICAL TERM (OCLC, RLIN)  POINTS TO the same authority base -->
TOPIC_TERM

Under my understanding Koha should have new authority for cocver 690, 691,
692...If I am not wrong, If we don't add new authotiries, the official and
local authorities will be the at the TOPIC_TERM and it is little weird

What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17864] Increase coverage on admin pages

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864

M. Tompsett  changed:

   What|Removed |Added

  Attachment #58656|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17864] Increase coverage on admin pages

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864

--- Comment #6 from M. Tompsett  ---
Created attachment 58686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58686&action=edit
Bug 17864: Follow up to add missing tests

This adds tests for the missing items.
Remember the kohadevbox has annoying caching issues,
so close tab, vagrant halt, vagrant up just to be
certain you are not failing because of caching.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17864] Increase coverage on admin pages

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864

--- Comment #5 from M. Tompsett  ---
Created attachment 58685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58685&action=edit
Bug 17864: Test Cases

There was no form of testing for the change. In order to test
the perl-side of the changes, I just went to a variety of
URLs to see if they have the expected three tabs.

TEST PLAN
-
1) Apply this patch
2) At the bash prompt, export KOHA_INTRANET_URL=http://localhost:8080/
   -- Or whatever yours is. With or without the trailing /
3) prove -v t/db_dependent/www/prefs-admin_search.t
   -- before applying the other patch, there should be failures.
4) Apply both patches
5) prove -v t/db_dependent/www/prefs-admin_search.t
   -- there should be no failures now.
6) run koha qa test tools

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

--- Comment #13 from M. Tompsett  ---
I ran:
$ git grep -l cat-search.inc | grep admin

This means I believe the outstanding ones are
(koha-tmpl/intranet-tmpl/prog/en/modules/):
- admin/auth_subfields_structure.tt
- admin/clone-rules.tt
- admin/marc_subfields_structure.tt
- admin/searchengine/elasticsearch/mappings.tt
- plugins/plugins-home.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17794] Menu items in Tools menu and Admin menu not bold when active but not on linked page

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794

--- Comment #7 from Owen Leonard  ---
These comments are not a criticism of this patch, but just something I've been
thinking about with regard to this area of the templates:

1. This is starting to get convoluted. At what point should we try to
reevaluate how we highlight menu items? Eventually the JavaScript becomes
almost as complicated as doing the logic in the template.

2. This way of doing things is going to create a problem for Bug 17858 because
these menu templates include jQuery JavaScript which the browser will attempt
to run before jQuery has loaded. We will need to figure out a way to make it
not break.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

--- Comment #13 from Tomás Cohen Arazi  ---
Note for testers: this patches need to be tested with 13757 applied on top of
them. Otherwise some tests will be skipped.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

M. Tompsett  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

--- Comment #14 from M. Tompsett  ---
Created attachment 58684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58684&action=edit
Bug 17793: Follow up for identified missing changes

I ran:
$ git grep -l cat-search.inc | grep admin

This means I believe the outstanding ones are
(koha-tmpl/intranet-tmpl/prog/en/modules/):
- admin/auth_subfields_structure.tt
- admin/clone-rules.tt
- admin/marc_subfields_structure.tt
- admin/searchengine/elasticsearch/mappings.tt

One other was recommended by Katrin in comment #9:
- plugins/plugins-home.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client

2017-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

Owen Leonard  changed:

   What|Removed |Added

  Attachment #58323|0   |1
is obsolete||

--- Comment #82 from Owen Leonard  ---
Created attachment 58683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58683&action=edit
Bug 16239 [CSS Follow-up] Upgrade Bootstrap in the staff client

This followup tweaks some CSS and markup in order to correct conflicts
between default Bootstrap styles and the expected (previous) style of
the staff client. Included:

- Corrections to the widths of some modals.
- Corrections to the style of the  tag, seen often in MARC preview
  modals.
- Corrections to the default active and hover states for dropdown menus.

To test, apply the patch and view various pages which use Bootstrap
modals, confirming that they look correct.

- Add order from staged file MARC preview
- Add order from external source MARC preview
- Cataloging record merge MARC preview
- Batch record modification MARC preview
- Authorities Z39.50 search MARC preview

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 146 matches

Mail list logo