date:20170116

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

--- Comment #41 from Jonathan Druart  
---
Aleisha, it seems that your last patch kept the 2 subroutines in C4::Items.
Since you are not using them, you can remove them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17920] t/db_dependent/Sitemapper.t fails because of permissions

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920

Claire Gravely  changed:

   What|Removed |Added

  Attachment #59060|0   |1
is obsolete||

--- Comment #2 from Claire Gravely  ---
Created attachment 59067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59067=edit
Bug 17920: t/db_dependent/Sitemapper.t fails because of permissions

The directory it attempts to create an xml file may not be writable for
the user running the test. By changing the directory from the current
directory to a temporary one, the test runs. After all 'chmod 777
t/db_dependent' is a bad idea.

TEST PLAN
-
1) sudo koha-shell "prove t/db_dependent/Sitemapper.t" kohadev
   -- fails
2) apply patch
3) sudo koha-shell "prove t/db_dependent/Sitemapper.t" kohadev
   -- succeeds
4) run koha qa test tools

Tested without qa tools
Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17920] t/db_dependent/Sitemapper.t fails because of permissions

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16870] Koha::Issue(s) should be named Koha::Checkout(s)

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #12 from Jonathan Druart  
---


*** This bug has been marked as a duplicate of bug 17796 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17796] Koha::Issues should be moved to Koha::Checkouts

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796

--- Comment #11 from Jonathan Druart  
---
*** Bug 16870 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17913] Merge three authority merge fixes

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #59065|0   |1
is obsolete||

--- Comment #7 from Marcel de Rooy  ---
Created attachment 59066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59066=edit
Bug 17913: Fix the new field tag in merge when changing type

Originally aimed for 9988, adjusted for this report.

Old behavior was: pick the first tag. This is definitely wrong.
If you (would) merge 610 to 611, you don't want to get a 111.

This patch resolves the problem by determining the new tag in a small
helper routine _merge_newtag, and corrects the position of the new field
in the MARC record with append_fields_ordered. Too bad that MARC::Record
does not have such a function; it looks like insert_fields_ordered, but
it is different in case of multiple fields with the same tag.

Note: These two small helper functions are not tested separately, since they
should not be called outside of merge. They are implicitly tested by the
adjusted tests in Merge.t.

Note: In adding tests for this fix, I chose to simplify compare_field_count
(no need for the pass parameter), and replace the pass parameter of sub
compare_field_order by an exclude parameter, a hash of fields to exclude in
counting fields.

Test plan:
Run t/db_dependent/Authorities/Merge.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17466] Show number of outstanding issues when checking in

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466

--- Comment #12 from Jonathan Druart  
---
Could not compile /home/vagrant/kohaclone/circ/returns.pl: Can't locate
Koha/Issues.pm

See bug 17919.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17913] Merge three authority merge fixes

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913

--- Comment #6 from Marcel de Rooy  ---
Created attachment 59065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59065=edit
Bug 17913: Fix the new field tag in merge when changing type

Originally aimed for 9988, adjusted for this report.

Old behavior was: pick the first tag. This is definitely wrong.
If you (would) merge 610 to 611, you don't want to get a 111.

This patch resolves the problem by determining the new tag in a small
helper routine _merge_newtag, and corrects the position of the new field
in the MARC record with append_fields_ordered. Too bad that MARC::Record
does not have such a function; it looks like insert_fields_ordered, but
it is different in case of multiple fields with the same tag.

Note: These two small helper functions are not tested separately, since they
should not be called outside of merge. They are implicitly tested by the
adjusted tests in Merge.t.

Test plan:
Run t/db_dependent/Authorities/Merge.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17919] circ/returns.pl caught in Object Name crossfire

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17919

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17466
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466
[Bug 17466] Show number of outstanding issues when checking in
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17466] Show number of outstanding issues when checking in

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17919


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17919
[Bug 17919] circ/returns.pl caught in Object Name crossfire
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #19 from Jonathan Druart  
---
Why do you want to replace AddMember calls with TestBuilder?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #18 from Jonathan Druart  
---
This is wrong, see the last patch on bug 6782.

It is not pushed yet, but I have asked Kyle to push it quickly.
You should always take a look at the patch that introduces the regression, I
usually attach the patch on it (if it's trivial) or create another and link it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17919] circ/returns.pl caught in Object Name crossfire

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17919

Claire Gravely  changed:

   What|Removed |Added

  Attachment #59059|0   |1
is obsolete||

--- Comment #2 from Claire Gravely  ---
Created attachment 59063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59063=edit
Bug 17919: Koha::Issue is now called Koha::Checkout

Ignoring the pluralization or lack thereof:
$ git grep "Koha::Issue"
-- This has results.
But this was renamed by 17796, and supposedly still
in discussion in 16870.

apply this patch, and do the same git.
There will be no results.

This was found while running a prove t/db_dependent/00-strict.t

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17919] circ/returns.pl caught in Object Name crossfire

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17919

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17919] circ/returns.pl caught in Object Name crossfire

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17919

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17920

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17920] t/db_dependent/Sitemapper.t fails because of permissions

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17919

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17920] t/db_dependent/Sitemapper.t fails because of permissions

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920

M. Tompsett  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

M. Tompsett  changed:

   What|Removed |Added

   Keywords||Academy
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17920

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17919] circ/returns.pl caught in Object Name crossfire

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17919

M. Tompsett  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |mtomp...@hotmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17919] circ/returns.pl caught in Object Name crossfire

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17919

M. Tompsett  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17920] t/db_dependent/Sitemapper.t fails because of permissions

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17917

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

--- Comment #17 from M. Tompsett  ---
Created attachment 59062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59062=edit
Bug 17917: fix Jenkins for t/db_dependent/Suggestions.t

TEST PLAN
-
1) sudo koha-shell -c "prove t/db_dependent/Suggestions.t" kohadev
   -- fails
2) apply patch
3) sudo koha-shell -c "prove t/db_dependent/Suggestions.t" kohadev
   -- succeeds
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17918] Make Koha News add form show up on a pop up box when 'New' is clicked from home page

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17918

M. Tompsett  changed:

   What|Removed |Added

  Attachment #59061|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Comment on attachment 59061
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59061
Bug 17918: fix Jenkins for t/db_dependent/Suggestions.t

Oops! Typo. Sorry.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17918] Make Koha News add form show up on a pop up box when 'New' is clicked from home page

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17918

--- Comment #1 from M. Tompsett  ---
Created attachment 59061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59061=edit
Bug 17918: fix Jenkins for t/db_dependent/Suggestions.t

TEST PLAN
-
1) sudo koha-shell -c "prove t/db_dependent/Suggestions.t" kohadev
   -- fails
2) apply patch
3) sudo koha-shell -c "prove t/db_dependent/Suggestions.t" kohadev
   -- succeeds
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17920] t/db_dependent/Sitemapper.t fails because of permissions

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920

--- Comment #1 from M. Tompsett  ---
Created attachment 59060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59060=edit
Bug 17920: t/db_dependent/Sitemapper.t fails because of permissions

The directory it attempts to create an xml file may not be writable for
the user running the test. By changing the directory from the current
directory to a temporary one, the test runs. After all 'chmod 777
t/db_dependent' is a bad idea.

TEST PLAN
-
1) sudo koha-shell "prove t/db_dependent/Sitemapper.t" kohadev
   -- fails
2) apply patch
3) sudo koha-shell "prove t/db_dependent/Sitemapper.t" kohadev
   -- succeeds
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17920] t/db_dependent/Sitemapper.t fails because of permissions

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17920] New: t/db_dependent/Sitemapper.t fails because of permissions

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920

Bug ID: 17920
   Summary: t/db_dependent/Sitemapper.t fails because of
permissions
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: mtomp...@hotmail.com
QA Contact: gmcha...@gmail.com

The directory it attempts to create an xml file may not be writable for the
user running the test. By changing the directory from the current directory to
a temporary one, the test runs. After all 'chmod 777 t/db_dependent' is a bad
idea.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17919] circ/returns.pl caught in Object Name crossfire

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17919

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17919] circ/returns.pl caught in Object Name crossfire

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17919

--- Comment #1 from M. Tompsett  ---
Created attachment 59059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59059=edit
Bug 17919: Koha::Issue is now called Koha::Checkout

Ignoring the pluralization or lack thereof:
$ git grep "Koha::Issue"
-- This has results.
But this was renamed by 17796, and supposedly still
in discussion in 16870.

apply this patch, and do the same git.
There will be no results.

This was found while running a prove t/db_dependent/00-strict.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17919] circ/returns.pl caught in Object Name crossfire

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17919

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17917

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17919

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17919] New: circ/returns.pl caught in Object Name crossfire

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17919

Bug ID: 17919
   Summary: circ/returns.pl caught in Object Name crossfire
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mtomp...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Koha::Items was renamed to Koha::Checkouts
Find and fix any lingering code.
Only code? circ/returns.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||mtomp...@hotmail.com

--- Comment #40 from M. Tompsett  ---
(In reply to Aleisha Amohia from comment #39)
> I realised I had taken some shortcuts with the object-oriented stuff and
> wasn't doing it properly. The latest patch fixes that. This is ready to test.

We already had a Koha::Issues become Koha::Checkouts.
This seems to go backwards.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

--- Comment #16 from M. Tompsett  ---
See https://jenkins.koha-community.org/job/Koha_Master_D8/91/#showFailuresLink

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16034] Integration with OverDrive Patron API

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16034] Integration with OverDrive Patron API

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #58791|0   |1
is obsolete||

--- Comment #47 from Srdjan Jankovic  ---
Created attachment 59058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59058=edit
Bug 16034 follow-up: added WebService::ILS to PerlDependencies

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16034] Integration with OverDrive Patron API

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #58519|0   |1
is obsolete||

--- Comment #45 from Srdjan Jankovic  ---
Created attachment 59056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59056=edit
bug_16034 Adding a new syspref - OverDriveCirculation

If set to true, Opac will integrate OverDrive patron services

Signed-off-by: Jesse Weaver 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16034] Integration with OverDrive Patron API

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #58518|0   |1
is obsolete||

--- Comment #44 from Srdjan Jankovic  ---
Created attachment 59055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59055=edit
bug_16034 Koha::ExternalContent::OverDrive - a wrapper around
WebService::ILS::Overdrive::Patron

* Using the upstream module for all the heavy lifting
* opac/external/overdrive/auth.pl - 3-legged authentication handler

Signed-off-by: Jesse Weaver 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16034] Integration with OverDrive Patron API

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #58790|0   |1
is obsolete||

--- Comment #46 from Srdjan Jankovic  ---
Created attachment 59057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59057=edit
bug_16034 Add overdrive info to the users page in the public interface

Signed-off-by: Jesse Weaver 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16870] Koha::Issue(s) should be named Koha::Checkout(s)

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17796

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17796] Koha::Issues should be moved to Koha::Checkouts

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17796

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16870
 CC||mtomp...@hotmail.com

--- Comment #10 from M. Tompsett  ---
How might this be related to 16870?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986

Chris Cormack  changed:

   What|Removed |Added

 Status|In Discussion   |ASSIGNED

--- Comment #12 from Chris Cormack  ---
(In reply to Sally Healey from comment #11)
> This is a really exciting feature.
> 
> I know it's been sent back to discussion from being signed off - what's the
> next step for moving it forward?  We think this would make a fantastic
> addition to Koha.

To move it forward it needs comment 10 addressed, and a lot of the code moved
out of the .pl file into a module, with unit tests written. 
This shouldn't be a big job, but will mean way less chance of
breakage/maintenance in the future.
As well as a signoff from outside of the sponsoring library.

I think comment 9 could be a future enhancement. But mostly comment 10 (moving
the code to a module and writing tests) and an independent sign off are what
are need

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

M. Tompsett  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #15 from M. Tompsett  ---
Most of the issues were AddMember calls failing.
Those are the one's intended to be fixed by this bug.
Strange thing is I can't replicate on kohadevbox, but I can on my git install.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840

Emma  changed:

   What|Removed |Added

  Attachment #59053|0   |1
is obsolete||

--- Comment #2 from Emma  ---
Created attachment 59054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59054=edit
bug 17840: adding classes to notes in checkouts

Test Plan
1) Add an internal and a public note to an item.
2) Check out the item.
3) Verify that both notes are shown in between title and barcode in the
second column of the details table.
4) Verify there is an empty class="" in the HTML source code for each
5) Apply patch and refresh page
6) View page source, confirm that class has been changed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840

--- Comment #1 from Emma  ---
Created attachment 59053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59053=edit
bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal
and a public note to an item. 2) Check out the item. 3) Verify that both notes
are shown in between title and barcode in the second column of the details
table. 4) Verify there i

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840

Emma  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

--- Comment #14 from M. Tompsett  ---
Created attachment 59052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59052=edit
Bug 17917: Fix Jenkins for t/db_dependent/Reserves.t

TEST PLAN
-
1) prove -v t/db_dependent/Reserves.t
   -- fails
2) apply this patch
3) prove -v t/db_dependent/Reserves.t
   -- succeeds
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469

--- Comment #18 from M. Tompsett  ---
Comment on attachment 59048
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59048
Bug 17469: Follow-up adding hold print notice

Review of attachment 59048:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=17469=59048)
-

Not sure which solution is best and most likely to be accepted by the
community.

::: installer/data/mysql/fr-CA/obligatoire/sample_notices.sql
@@ +15,4 @@
>  ('orderacquisition','ACQORDER','','Acquisition 
> order',0,'Order','<>\r\n<>\r\n<>\r\n<>\r\n<>\r\n<>\r\n\r\nPlease
>  order for the library:\r\n\r\nOrdernumber <> 
> (<>) (quantity: <>) ($<> 
> each).\r\n\r\nThank you,\n\n<>', 'email'),
>  ('members','ACCTDETAILS','','Modèle de message pour les détails d\'un compte 
> lecteur - DEFAULT',0,'Votre compte Koha','Bonjour <> 
> <>,\r\n\r\nLes informations pour vous connecter à votre 
> compte lecteur sont :\r\n\r\nIdentifiant :  <>\r\nMot de 
> passe: <>\r\n\r\nSi vous rencontrez des problèmes ou avez 
> des questions concernant votre compte, veuillez contacter l\'administrateur 
> de Koha.\r\n\r\nMerci, \r\nL\'administrateur de 
> Koha\r\nkohaad...@yoursite.org','email'),
>  ('reserves','HOLD','','Réservation en attente de retrait',0,'Réservation en 
> attente de retrait à <>','Bonjour 
> <> <>,\r\n\r\nVotre réservation est 
> disponible depuis le <> :\r\n\r\nTitre : 
> <>\r\nAuteur : <>\r\nCopie : 
> <>\r\nLocalisation : 
> <>\r\n<>\r\n<>\r\n<>\r\n<>
>  <>\r\n\r\nNous vous invitons à venir emprunter votre 
> document rapidement.\r\n\r\nMerci.\r\n\r\n<>','email'),
> +('reserves', 'HOLD', 'Réservation disponible pour retrait', 'Réservation 
> disponible à la banque de retrait du site <>', 
> '<>\n<>\n<>\n\n\nLe
>  service des réservations\n\n\n\n\n\n\n\n<> 
> <>\n<>\n<> 
> <>\n\n\n\n\n\n\n\n\n\n\n<> 
> <> <>\n\nVotre réservation est 
> disponible pour retrait depuis le <>:\r\n\r\nTitre: 
> <>\r\nAuteur: <>\r\nNuméro de fascicule: 
> <>\r\n', 'print'),

Good try, but '' and 0 are missing, as the field lists between the fr-FR and
fr-CA differ. A separate INSERT statement would be better, if you are going to
cut and paste. Otherwise, make sure the fields line up. Another cut-and-paste
idea would be just to copy the email HOLD above, and change it to 'print' on
the end. I am sure the folks pushing for this will submit a fix on another bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #84 from Liz Rea  ---
Created attachment 59051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59051=edit
Bug 17855 - removing some errant warns

Just removing some warns that crept in during debugging.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865

Luke Honiss  changed:

   What|Removed |Added

  Attachment #59049|0   |1
is obsolete||

--- Comment #4 from Luke Honiss  ---
Created attachment 59050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59050=edit
Bug 17865 'If a subscription has no history end date, it shows as expired today
in OPAC' fixed

--TEST PLAN--
1. Find a record in the OPAC with a serial subscription
2. Check more details under subscription tab
3. The expiration date should be incorrect
4. Apply patch
5. Reload and now the expiration date should now be correct

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865

Luke Honiss  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865

--- Comment #3 from Luke Honiss  ---
Created attachment 59049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59049=edit
Bug 17865 'If a subscription has no history end date, it shows as expired today
in OPAC' fixed

--TEST PLAN--
1. Find a record in the OPAC with a serial subscription
2. Check more details under subscription tab
3. The expiration date should be incorrect
4. Apply patch
5. Reload and now the expiration date should now be correct

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469

--- Comment #17 from Caitlin Goodger  ---
Created attachment 59048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59048=edit
Bug 17469: Follow-up adding hold print notice

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469

Caitlin Goodger  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469

Chris Cormack  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED
   Severity|enhancement |major
   Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||ch...@bigballofwax.co.nz

--- Comment #16 from Chris Cormack  ---
It's much nicer to not leave it as needs signoff if its not ready for needs
signoff. The students and I will try to fix

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17837] Correct some authorised values in fr-FR

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17837

Luke Honiss  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17837] Correct some authorised values in fr-FR

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17837

Luke Honiss  changed:

   What|Removed |Added

  Attachment #58576|0   |1
is obsolete||

--- Comment #2 from Luke Honiss  ---
Created attachment 59047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59047=edit
Bug 17837 correct authorisation values for fr-FR

Bug 17809 corrected ER, but failed to correct:
CC -- duplicate, but name not full.
GQ -- duplicate, but only one name correct.
PK -- Poland was mislabelled.

This removes and edits duplicates and corrects PK to PL.

Signed-off-by: Luke Honiss 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

--- Comment #13 from M. Tompsett  ---
Created attachment 59046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59046=edit
Bug 17917: Fix Jenkins for t/db_dependent/Circulation/Branch.t

TEST PLAN
-
1) prove -v t/db_dependent/Circulation/Branch.t
   -- fails
2) apply this patch
3) prove -v t/db_dependent/Circulation/Branch.t
   -- succeeds
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

--- Comment #12 from M. Tompsett  ---
Created attachment 59045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59045=edit
Bug 17917: Fix Jenkins for t/db_dependent/Members/GetPendingIssues.t

TEST PLAN
-
1) prove -v t/db_dependent/Members/GetPendingIssues.t
   -- fails
2) apply this patch
3) prove -v t/db_dependent/Members/GetPendingIssues.t
   -- succeeds
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

--- Comment #11 from M. Tompsett  ---
Created attachment 59044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59044=edit
Bug 17917: Fix Jenkin for t/db_dependent/Members/GetOverdues.t

TEST PLAN
-
1) prove -v t/db_dependent/Members/GetOverdues.t
   - fails
2) apply this patch
3) prove -v t/db_dependent/Members/GetOverdues.t
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866

Gracie  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866

Gracie  changed:

   What|Removed |Added

  Attachment #58721|0   |1
is obsolete||

--- Comment #5 from Gracie  ---
Created attachment 59043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59043=edit
Bug 17866: Change sender for serial claim notifications

Currently, the From field uses the emailaddress of the staff client member
from the user context. This is exceptional in Koha. And might very well be,
as in our case, the cause of fraud detection warnings.
We should use branch email address or fallback to KohaAdminEmailAddress,
as we do (almost) everywhere else.

Test plan:
Go to subscription detail in Koha.
Go to Claims.
Select a missing issue and click Send notification.
Verify the sender address in the generated notification. (Make sure that
you receive this mail.)

Signed-off-by: Grace McKenzie 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

--- Comment #10 from M. Tompsett  ---
Created attachment 59042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59042=edit
Bug 17917: Fix Jenkins for t/db_dependent/Serials_2.t

TEST PLAN
-
1) prove -v t/db_dependent/Serials_2.t
   -- fails
2) apply this patch
3) prove -v t/db_dependent/Serials_2.t
   -- succeeds
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

--- Comment #9 from M. Tompsett  ---
Created attachment 59041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59041=edit
Bug 17917: Fix Jenkins for t/db_dependent/Members/GetAllIssues.t

TEST PLAN
-
1) prove -v t/db_dependent/Members/GetAllIssues.t
   -- fails
2) apply this patch
3) prove -v t/db_dependent/Members/GetAllIssues.t
   -- succeeds
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

--- Comment #8 from M. Tompsett  ---
Created attachment 59040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59040=edit
Bug 17917: Fix Jenkins for t/db_dependent/Circulation/MarkIssueReturned.t

TEST PLAN
-
1) prove -v t/db_dependent/Circulation/MarkIssueReturned.t
   -- fails
2) apply rhis patch
3) prove -v t/db_dependent/Circulation/MarkIssueReturned.t
   -- succeeds
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

--- Comment #7 from M. Tompsett  ---
Created attachment 59039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59039=edit
Bug 17917: Fix Jenkins for t/db_dependent/Circulation/issue.t

TEST PLAN
-
1) prove -v t/db_dependent/Circulation/issue.t
   -- fail
2) apply this patch
3) prove -v t/db_dependent/Circulation/issue.t
   -- success
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17731] Remove the noxml option from rebuild_zebra.pl

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731

Emma  changed:

   What|Removed |Added

  Attachment #58003|0   |1
is obsolete||

--- Comment #2 from Emma  ---
Created attachment 59038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59038=edit
Bug 17731: Remove noxml option from rebuild_zebra.pl

The removal of the noxml is a logical follow-up of bug 16506 (which
make xml the default).

Actually this option should have been removed by bug 10455 (it removes
the biblioitem.marc field).

Test plan:
Make sure the rebuild_zebra.pl script works as before.

Signed-off-by: Emma Smith 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17731] Remove the noxml option from rebuild_zebra.pl

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731

Emma  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #83 from Alex Buckley  ---
Because my internship is until the 10 Feb if we can sign off this onboarding
tool soon,  then I can write additional patches to perfect the onboarding tool.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469

M. Tompsett  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #15 from M. Tompsett  ---
The reason I did not sign off was because of comment #3 which was purposefully
repeated the outstanding part in comment #12.

Sorry but I'm unsigning it. There is still just one this one to clean up.

As per comment #3:
31d28
< reserves  HOLD0   print

-- There is one more you may wish to include, Katrin.

It can be signed off, if there is a good reason to exclude this. However, that
wasn't given.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #82 from Alex Buckley  ---
Created attachment 59037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59037=edit
Bug 17855 - Seventh update following testing feedback.

1. Moved the "select all options" button down to just above the selectable
options
in the basic setup, and positioned at the top of the page for the advanced
setup.

2. Removed the "there is nothing to do because the sample data is
already installed" page so if the user has install sample data in the web
installer then the step to create that object in the onboarding tool is
skipped altogether.

3. Removed the "We're just going to setup a few more things" page

4. Changed the title of the 'Create patron page'

5. Added clarifying information to the "Add a patron category" page

6. Added clarifying information to the "Create item type" page

7. Fixed the capitalization in the onboarding tool

8. Removed the BackupStep3.tt file which was un-used

9. Changed the redirect time displayed to user in step3.tt to 10

10. Changed the cardnumber on the create patron administrator page so
that it is only populated when the user installed sample patrons. Also
changed the regex so that it allows letters and number.

11. Used the HTMl validator to identify errors in the template and have
corrected all possible in the onboarding templates.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17891] typo in housebound.tt div tag

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891

Zoe Schoeler  changed:

   What|Removed |Added

  Attachment #58868|0   |1
is obsolete||

--- Comment #3 from Zoe Schoeler  ---
Created attachment 59036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59036=edit
Bug 17891 - typo in housebound.tt div tag

In housebound.tt there is a end tag div missing closing character '>'.

Signed-off-by: Zoe Schoeler 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17891] typo in housebound.tt div tag

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891

Zoe Schoeler  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17918] New: Make Koha News add form show up on a pop up box when 'New ' is clicked from home page

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17918

Bug ID: 17918
   Summary: Make Koha News add form show up on a pop up box when
'New' is clicked from home page
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

At the moment if there are news items on the staff home page, there is a 'New'
button that redirects to an add form. It would be nice if this add form opened
in a pop up box then refreshed the page to show the news item

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17784] Ability to see funds with an amount of 0.00 when doing a new order

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17784

Aleisha Amohia  changed:

   What|Removed |Added

   Keywords||Academy
 CC||aleishaamo...@hotmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17777] koha-remove should deal with temporary uploads

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

Karen  changed:

   What|Removed |Added

  Attachment #58181|0   |1
is obsolete||

--- Comment #2 from Karen  ---
Created attachment 59035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59035=edit
Bug 1: koha-remove should deal with temporary uploads

If the temporary upload folder exists, it should be discarded when
removing an instance. If we do not, it may/will create problems when
recreating the same instance.

A function in koha-functions.sh is added to determine the temp directory
instead of hardcoding /tmp.

Test plan:
[1] Copy koha-functions.sh to /usr/share/koha/bin
[2] Run koha-create --create-db newinstancexx
[3] Run mkdir /tmp/koha_newinstancexx_upload (if /tmp is your temp!)
[4] Run debian/scripts/koha-remove newinstancexx
Do not run the regular one, but verify that you use the updated one.
[5] Check that /tmp/koha_newinstancexx_upload is gone.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Karen Jen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17777] koha-remove should deal with temporary uploads

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

Karen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469

Caitlin Goodger  changed:

   What|Removed |Added

  Attachment #59025|0   |1
is obsolete||

--- Comment #14 from Caitlin Goodger  ---
Created attachment 59034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59034=edit
Bug 17469: Add missing sample notices to fr-CA web installer

Adds missing notices to the fr-CA web installer:
- MEMBERSHIP_EXPIRY
- PASSWORD_RESET
Renames RESERVESLIP to HOLD_SLIP

TEST PLAN
-
1) Apply the first patch
2) prove xt/sample_notices.t
   -- it should fail for fr-CA.
3) Apply the second patch
4) prove xt/sample_notices.t
   -- it should pass.
5) run all tests (prove t; prove xt)
   -- they should generally pass
6) run koha qa test tools

NOTE: Split test patch from fix patch, so could prove problem
  exists easily.

Signed-off-by: Mark Tompsett 
Signed-off-by: Caitlin Goodger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469

Caitlin Goodger  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469

Caitlin Goodger  changed:

   What|Removed |Added

  Attachment #59024|0   |1
is obsolete||

--- Comment #13 from Caitlin Goodger  ---
Created attachment 59033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59033=edit
Bug 17469: Add missing sample notices fr-CA test

Add fr-CA installer to xt/sample_letter.t

To test:
- Verify xt/sample_letter.t test checks fr-CA now and
  fails for just fr-CA.

Signed-off-by: Mark Tompsett 
Signed-off-by: Caitlin Goodger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #58887|0   |1
is obsolete||

--- Comment #4 from Aleisha Amohia  ---
Created attachment 59032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59032=edit
Bug 4461: Add a context-sensitive 'Report a Problem' feature to OPAC

This patch adds a 'Report a problem' link to the bottom of every page in
the OPAC. The user can choose to submit their report to the library or
Koha administrator. The report will store the user's problem message,
but also their username and the page they were on when they clicked the
'report a problem' link. The patch adds a table 'problem_reports' to the
db.

Update: This patch adds a check for the KohaAdminEmailAddress and
library branch email before sending the report.

To test:
1) Apply patch, update database, rebuild schema
2) Restart koha-common and memcached
3) Confirm that your user has an email address.
4) Confirm that your library does NOT have an email address.
5) Confirm that your syspref KohaAdminEmailAddress is NOT filled.
6) Log into OPAC
7) Click the 'Report a problem' link at the bottom of whatever page
you're on
8) Notice that there are error messages alerting that library does not
have an email address and that the Koha Administrator does not have
email address. Both submit buttons will be disabled.
9) Add an email address for your library. You may have to restart
memcached again. The error message for the library email address will
have disappeared and the Submit button for 'Report to library' will now
work.
10) Add an email address for the syspref KohaAdminEmailAddress. You may
have to restart memcached again. The error message for the administrator
email address will have disappeared and the Submit button for 'Report to
Koha Administrator' will not work.
11) First try submitting a problem to the library. Confirm that the
fields for 'Problem found on page' and 'Username' are correct, then fill
out the 'Subject' and 'Message' and click Submit.
12) Confirm a message shows at the top of the page to show success.
13) Go into mysql and display records from the message_queue table.
Confirm that the borrowernumber and subject are correct. Confirm that
content shows the message from the problem report, but also the user's
username and the problem page. Confirm that the to_address shows the
library's email address and the from_address shows the user's email
address.
14) Now try submitting a problem to the Koha Admin. Fill fields and
click Submit. Confirm message shows at top to show success again.
15) Check message_queue for new problem report. Confirm that the
to_address shows the email address from the syspref
KohaAdminEmailAddress.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

--- Comment #6 from M. Tompsett  ---
Created attachment 59031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59031=edit
Bug 17917: Fix Jenkins for t/db_dependent/Letters.t

TEST PLAN
-
1) prove -v t/db_dependent/Letters.t
   -- fail
2) apply this patch
3) prove -v t/db_dependent/Letters.t
   -- success
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #81 from Liz Rea  ---
(In reply to Chris Cormack from comment #80)
> For the record, I disagree with hiding the basic/advanced step. It is a good
> enhancement and will help users.
> I also disagree with removiing the skip, if we allow users to skip they will
> end up logging into Koha with the DB user which as we know can cause a lot
> of problems. 
> For dev companies or experienced users they can just close the tab at that
> point.

+1 to all of this. 

Enhancements or changes to the advanced setup should be addressed in further
bugs. 

We have built the bike shed, we can paint it later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

--- Comment #5 from M. Tompsett  ---
Created attachment 59030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59030=edit
Bug 17917: Fix Jenkinds for t/db_dependent/Holds/LocalHoldsPriority.t

TEST PLAN
-
1) prove -v t/db_dependent/Holds/LocalHoldsPriority.t
   -- fail
2) apply this patch
3) prove -v t/db_dependent/Holds/LocalHoldsPriority.t
   --success
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

--- Comment #4 from M. Tompsett  ---
Created attachment 59029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59029=edit
Bug 17917: Fix Jenkins for t/db_dependent/Members/IssueSlip.t

TEST PLAN
-
1) prove -v t/db_dependent/Members/IssueSlip.t
   -- fail
2) apply this patch
3) prove -v t/db_dependent/Members/IssueSlip.t
   -- success
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

M. Tompsett  changed:

   What|Removed |Added

  Attachment #59027|0   |1
is obsolete||

--- Comment #3 from M. Tompsett  ---
Created attachment 59028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59028=edit
Bug 17917: Fix Jenkins for t/db_dependent/Holds.t

This changes AddMember into TestBuilder calls.

TEST PLAN
-
1) prove -v t/db_dependent/Holds.t
   -- fails
2) apply this patch
3) prove -v t/db_dependent/Holds.t
   -- works
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

M. Tompsett  changed:

   What|Removed |Added

  Attachment #59026|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 59027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59027=edit
Bug 17917: Fix Jenkins tests failing on C4::Member.

C4/Members.pm line 502 references:
C4::Context->userenv->{'branch'}.
As the tests are not logged in userenv is not defined, and triggers test
failures.
This patches it by giving a reasonable branch value.

Test Plan
-
1) prove t/db_dependent/Holds.t
   -- fails
2) apply patch
3) prove t/db_dependent/Holds.t
   -- passes
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

--- Comment #1 from M. Tompsett  ---
Created attachment 59026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59026=edit
Bug 17917: Fix Jenkins tests failing on C4::Member.

C4/Members.pm line 502 references:
C4::Context->userenv->{'branch'}.
As the tests are not logged in userenv is not defined, and triggers test
failures.
This patches it by giving a reasonable branch value.

Test Plan
-
1) prove t/Members/cardnumber.t
   -- fails
2) apply patch
3) prove t/Members/cardnumber.t
   -- passes
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17917] New: Jenkins tests failing because test suite not logged in user

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917

Bug ID: 17917
   Summary: Jenkins tests failing because test suite not logged in
user
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: mtomp...@hotmail.com
QA Contact: gmcha...@gmail.com

C4/Members.pm line 502 references:
C4::Context->userenv->{'branch'}.
As the tests are not logged in userenv is not defined, and triggers test
failures.
This patches it by giving a reasonable branch value.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17502] Resolve internal server error on 0000-00-00 (with Plack)

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #12 from M. Tompsett  ---
(In reply to Marcel de Rooy from comment #9)
> Main change has been used in 15822.
> So forget the rest.

Well, unless you care about type checking, if you actually right your test, you
will still trigger an error, because dt is a string and not a DateTime.
A quick perusal of the code shows lots of dt_from_string calls, and lots of
$foo's used. Given the number of $foo's, I suspect they probably are dates,
because otherwise we would have hit this problem sooner. So leaving it closed,
because type checking the programmer's code should be part of the QA process.
:)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17916] New: "Delete MARC modification template" fails to actually delete it

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17916

Bug ID: 17916
   Summary: "Delete MARC modification template" fails to actually
delete it
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: PC
OS: Windows
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: jster...@umich.edu
QA Contact: testo...@bugs.koha-community.org

As of 16.11.00 on Ubuntu 14.04, attempting to delete a MARC modification
template (Tools > MARC Modification templates) does not work.  A change to the
MARC modification template interface was noted in the upgrade to 16.11.x from
16.05.x, where the functionality did work correctly (as it had in any release
used since 3.18)

VERIFY:
*Upon selecting "Delete" for the appropriate template, system will prompt "Are
you sure you wish to delete this template action" (select "OK") and then "Are
you sure you wish to delete this template" (select "OK" again).  There is no
response by the system after this final "OK".  The screen is not refreshed as
expected and the template remains in place, fully intact with no changes as
though no action had been taken.  

NOTES:
*The "Are you sure you wish to delete this template action" prompt seems out of
place given the goal of deleting the entire template, not just a single element
therein.
*Problem exists for both modification templates carried forward from other koha
releases as well as for templates created "new" in 16.11.
*"Edit actions" and "Duplicate" functions appear to work without issue.
*User confirmed to have superlibrarian privileges.
*PC running Chrome 55.0.x on Win7 Enterprise, though also confirmed in Firefox
50.1.0

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #80 from Chris Cormack  ---
For the record, I disagree with hiding the basic/advanced step. It is a good
enhancement and will help users.
I also disagree with removiing the skip, if we allow users to skip they will
end up logging into Koha with the DB user which as we know can cause a lot of
problems. 
For dev companies or experienced users they can just close the tab at that
point.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #79 from M. Tompsett  ---
(In reply to Alex Buckley from comment #78)
> 1. ... i.e. the basic setup protects new users from
> mistakes and lack of knowledge.

JD, this is an enhancement, as advanced is the current default.
There is value to basic (enhanced protection against user error)
and there is value to advanced (some koha support providers may
have there own data and actually know what is needed).

Perhaps to push this along, leave the code in for basic/advanced, but set the
UI to choose advanced behind the scenes. After all, advanced is the current
behaviour.


> 2. [styling speel snip]

Okay, that's all fine and dandy, Alex, but there was a visual disconnect in
styling and positioning of elements. The first time I ran the onboarding step
the koha logo was weird to me. Still is. Compare it's position and styling with
the previous steps, it doesn't match nicely.


> 3. I do not believe having a button at the end of the web installer to skip
> the onboarding tool is wise.
>
[SNIP]
> 
> If experienced Koha users want to skip the onboarding tool they could always
> open Koha in another tab, 

-- Or you could actually give them a GUI which let's them shoot themselves in
the foot, because they chose Advanced. We are not supposed to be the
nanny-state of data and configuration. But if they choose Basic, then clearly
they want help and do not need a set of skip buttons.

That being said, this skipping issue seems better suited for a secondary bug,
rather than hold this one up. And on that bug, make the basic/advanced visible
again and add all the skipping stuff based on Advanced being selected.

That all said, I'm looking forward to seeing the issues in comment #71
addressed. Keep it up, Alex. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices

2017-01-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469

--- Comment #12 from M. Tompsett  ---
Sorry for the excessive messages. I messed up splitting things. Just one this
to clean up.

As per comment #3:
31d28
< reserves  HOLD0   print

-- There is one more you may wish to include, Katrin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 161 matches

Mail list logo