date:20170127

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Status|Failed QA   |In Discussion

--- Comment #115 from Alex Buckley  ---
(in reply to M.Tompsett in comments 113 and 114)

To fix the dateexpiry issue I can simply remove the dateexpiry altogether from
the onboarding.pl script, because in the database it is set to null by default.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #114 from M. Tompsett  ---
Also missing: address and city need to default to something other than undef
(onboarding.pl line 378ish -- see lack of address and city). Adding blank
values should be good enough.

Also questionable: onshelfholds logic. The schema says bit, but "yes" and the
other possible string values are not bit values. I hacked a !(!( blah )) to get
it to keep running, but that's the wrong solution.

All problems are highlighted when testing on Xenial KohaDevBox.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

M. Tompsett  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #113 from M. Tompsett  ---
Comment on attachment 59279
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59279
[SIGNED-OFF] bug 17855 - Updated web installer finished

Review of attachment 59279:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=17855=59279)
-

Sorry I didn't catch this the first time.

::: installer/onboarding.pl
@@ +381,5 @@
> +$newdata{categorycode}   = $input->param('categorycode_entry');
> +$newdata{userid} = $input->param('userid');
> +$newdata{password}   = $input->param('password');
> +$newdata{password2}  = $input->param('password2');
> +$newdata{dateexpiry} = '12/10/2016';

No no no! I was trying to test under Xenial Kohadevbox, and it blew up!
"DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect date value: '12/10/2016'
for column 'dateexpiry' at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line
120"
Dates that will be used directly with SQL queries need to be -MM-DD.
Plus hard coded?! YUCK!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16583] Strangeness in the staff client on ubuntu 16.04 and MySQL 5.7

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16583

--- Comment #6 from M. Tompsett  ---
(In reply to Nabila from comment #5)
> The Ubuntu 16.04 LTS is not supporting a fresh installation of Koha.

With the application of 17260, I was able to get a fresh installation working
on the xenial kohadevbox.


> The error not comes in Acquisition Module but also the following:
> 
> -- Cannot create New Vendor in Acquisition (Doesn't save the record instead
> searches the vendor)
> -- Cannot do the Batch Patron Import (Shows error in DBI.pm file)
> -- Cannot create any entry that requires Auto Increment of Primary Key.
> -- Does not load default framework of Cataloging.

I propose making this bug one of these things, and creating other bugs for the
others. Smaller bugs get pushed through faster. They are also easier to test.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17260] updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17260

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16583

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16583] Strangeness in the staff client on ubuntu 16.04 and MySQL 5.7

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16583

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17260
 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #19 from M. Tompsett  ---
Don't sign off until I get feedback on comment #14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17996] longoverdue.pl should not set 'datereturned' when --mark-returned option is used.

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996

Tom Misilo  changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17310] Broken URLs in 'Item renewed' / 'Cannot renew' messages

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17310

Tom Misilo  changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

Josef Moravec  changed:

   What|Removed |Added

  Attachment #59627|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

--- Comment #18 from Josef Moravec  ---
(In reply to Josef Moravec from comment #15)
> Created attachment 59627 [details]
> WebIntallerStep1
> 
> I have broken screen on step 1, when I am trying to install in Czech
> language...
> 
> Generated html code is here: http://paste.koha-community.org/287
> 
> In English it's OK

Forgot it, my mistake, I did not regenerate the templates...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

--- Comment #17 from Josef Moravec  ---
I faced a weird behavior, after installation, I was redirected to onboarding
step 1, then immediatelly to step 2 and then step 3... so imposible to use two
first forms/steps.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

Josef Moravec  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #16 from Josef Moravec  ---
Hm, maybe some fa icon by link "Select all sample data" would be useful to make
it more visible...

I like the using of "btn-primary" ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

--- Comment #15 from Josef Moravec  ---
Created attachment 59627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59627=edit
WebIntallerStep1

I have broken screen on step 1, when I am trying to install in Czech
language...

Generated html code is here: http://paste.koha-community.org/287

In English it's OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18005] Pagination of the search result displayed wrong

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18005

Josef Moravec  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18005] Pagination of the search result displayed wrong

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18005

Josef Moravec  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18005] Pagination of the search result displayed wrong

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18005

--- Comment #1 from Josef Moravec  ---
Created attachment 59626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59626=edit
Bug 18005: Re-styled pagination on search results with Bootstrap

Test plan:
0. Don't apply path
1. Make catalogue search in staff client with more then 20 results,
scroll down to see that pagination is broken
2. Apply the patch
3. Make similar search and confirm, the pagination looks OK with new
style

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #14 from M. Tompsett  ---
There, screen shots of what I was talking about. Explain the reasons for the
difference.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

--- Comment #13 from M. Tompsett  ---
Created attachment 59625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59625=edit
Superlibrarian is red

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

--- Comment #12 from M. Tompsett  ---
Created attachment 59624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59624=edit
Staff is black

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17987] Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987

--- Comment #3 from Owen Leonard  ---
Could this show the description instead of the code?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18007] Interface updates to notices and notice previews

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

--- Comment #11 from Owen Leonard  ---
(In reply to Josef Moravec from comment #8)
> It is enough to use container-fluid for full width grid, row-fluid should be
> just "row" acording to bootstrap documentation

Quite right. It is fixed now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

Owen Leonard  changed:

   What|Removed |Added

  Attachment #59275|0   |1
is obsolete||

--- Comment #10 from Owen Leonard  ---
Created attachment 59623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59623=edit
Bug 17942 - Update style of the web installer with Bootstrap 3

This patch makes style and markup changes to the web installer and new
onboarding tool (Bug 17855).

- Markup has been corrected, improved, and in many places reindented.
- Some page titles have been made more specific.
- Some JavaScript and CSS have been moved to separate files.

In the onboarding tool I have removed form validation from the markup
and JavaScript in many cases where the requirements were not matched
elsewhere in Koha. For instance, we shouldn't limit item type
descriptions to only letters because the database doesn't require such a
limit.

To test, apply the patch and run the web installer with an empty
database. Confirm that the installation process completes correctly and
that each page looks good and works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18007] Interface updates to notices and notice previews

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007

Owen Leonard  changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18007] Interface updates to notices and notice previews

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007

--- Comment #1 from Owen Leonard  ---
Created attachment 59622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59622=edit
Bug 18007 - Interface updates to notices and notice previews

This patch makes changes to the form for adding and editing notices, and
to the template for viewing a rendered preview of notices.

- Preview now shows side-by-side comparisons
- JavaScript has been movied out of template into separate file
- Validation of the add/edit form improved through use of validation
  plugin
- There is now better visual feedback for AJAX form checks

To test, apply the patch on top of those for Bug 17981

- Add a new notice.
  - Confirm that the form can't be submitted without data in the "code"
and "name" fields.
  - Confirm that the form can't be submitted without filling in at least
one message template (subject and body).
  - Confirm that you cannot submit the form while using an
existing notice code.
- Confirm that while the form validates this step the submit button
  shows a loading indicator.
  - Follow Bug 17981's test plan for testing the preview function.
Confirm that the preview loads correctly and looks correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18007] Interface updates to notices and notice previews

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

Owen Leonard  changed:

   What|Removed |Added

 Blocks||18007


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007
[Bug 18007] Interface updates to notices and notice previews
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18007] New: Interface updates to notices and notice previews

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007

Bug ID: 18007
   Summary: Interface updates to notices and notice previews
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: jonathan.dru...@bugs.koha-community.org,
testo...@bugs.koha-community.org
Depends on: 17961, 17981

An upcoming patch will:
- Restructure the template for side-by-side comparisons of notice updates
- Move JavaScript out of template into separate file
- Improving form validation through use of validation plugin
- Give better visual feedback for AJAX form checks


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961
[Bug 17961] TT syntax for notices - Prove we have an equivalent for our
historical custom syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
[Bug 17981] Add the ability to preview generated notice templates
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961

Owen Leonard  changed:

   What|Removed |Added

 Blocks||18007


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007
[Bug 18007] Interface updates to notices and notice previews
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17260] updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17260

M. Tompsett  changed:

   What|Removed |Added

  Attachment #55263|0   |1
is obsolete||

--- Comment #4 from M. Tompsett  ---
Created attachment 59621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59621=edit
Bug 17260: updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN
columns

The loading of file admin/searchengine/elasticsearch/mappings.yaml
specifies 'type' as empty, which fails with Mysql 5.7+ which is more
stringent.

Also, forcing an empty value into a boolean also fails.

Both issues arise when updatedatabase.pl hit 3.23.00.050.

NOTE: both issues could also be resolved by actually setting values in
  the load file. This doesn't make this solution incorrect, though.

To Test/reproduce:
-1) Happens with Mysql 5.7.4.  Maybe earlier, but certainly at
that point. Use a Xenial kohadevbox to more easily test.
0) Find a database on 3.22 or earlier, save it.
a) place
  
sql_mode=IGNORE_SPACE,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION
   into the [mysqld] section of /etc/mysql/mysql.conf.d/mysqld.cnf
b) restart you mysql server
c) drop the db and recreate it
d) checkout the 3.22.x branch
e) do a web install
f) remove the added sql_mode
g) restart the mysql server
1) Set your code base to master
2) run updatedatabase.pl
3) See the errors on 3.23.00.050
4) Apply the patch
5) Reload the 3.22 db.
   a) repeat steps 0(a)-0(g)
   b) don't forget the caching issues
6) succeed with updatedatabase.pl
7) drop the db and recreate it
8) run the web installer
9) notice no issues either.
10) run koha qa test tools

NOTE: This bug only solved the upgrade portion.
  I added the kohastructure.sql change as well.
  I confirmed that all the code changes were
  triggered with this test plan.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18006] New: MARC21: Don't show 246 when 1st indicator = 3

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18006

Bug ID: 18006
   Summary: MARC21: Don't show 246 when 1st indicator = 3
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Bibliographic data support
  Assignee: gmcha...@gmail.com
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

http://www.loc.gov/marc/bibliographic/bd246.html

It is our understanding, that the entry should be searchable but not display in
the detail view, when the first indicator of 246 is 3.

For example:
245 10 $a Apples & bears (displayed)
246 33 $a Apples and bears (not displayed)

See also discussion on IRC:
http://irc.koha-community.org/koha/2017-01-27#i_1900430

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18005] Pagination of the search result displayed wrong

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18005

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Add functionality to create a vendor and budget in the onboarding tool

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

--- Comment #1 from Owen Leonard  ---
I think it would be nice to be able to skip this step since Koha can function
just fine without the use of acquisitions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17978] Circ rules will not limit holds

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|REOPENED|NEW

--- Comment #6 from Jonathan Druart  
---
Technically: placerequest.pl is not checking if a patron can place reserve.
The check is only done in reserve.pl
That means that if a patron can place 1 hold, he will not be blocked to place X
holds.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #33 from Alex Arnaud  ---
(In reply to Fridolin SOMERS from comment #32)
> Change in C4/Installer/PerlDependencies.pm is useless I think

I think you are right Frido

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18005


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18005
[Bug 18005] Pagination of the search result displayed wrong
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18005] New: Pagination of the search result displayed wrong

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18005

Bug ID: 18005
   Summary: Pagination of the search result displayed wrong
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 16239

There is 1 line per page, it's very ugly :)

Introduced by bug 16239.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239
[Bug 16239] Upgrade Bootstrap in the staff client
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17695] Frameworks not saving in IE11 when editing records

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17695

--- Comment #2 from Fiona Borthwick  ---
We have had another few customers report this problem too. It is often the case
that they do not have any use of a different browser so it is causing major
problems for them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 5.1

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #59487|0   |1
is obsolete||

--- Comment #22 from Jonathan Druart  
---
Created attachment 59620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59620=edit
Bug 17929 - You can't edit indicators in the cataloging screen

Test plan:
0. Do not apply the patch
1. Edit a biblio record, note you can't edit an indicator (in fact you edit it,
but can't see the value)
2. Edit an authority record, note you can't edit an indicator (in fact you edit
it, but can't see the value)
3. Apply the patch, you may need clear the browser cache (in Firefox Ctrl+F5 is
often enough)
4. Repeat steps 1 and 2 - but now you will be able to edit the indicator

Signed-off-by: J Schmidt 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16387] Incorrect loan period calculation when using decreaseLoanHighHolds feature

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |lari.task...@jns.fi
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16387] Incorrect loan period calculation when using decreaseLoanHighHolds feature

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #59278|0   |1
is obsolete||
  Attachment #59285|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 59619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59619=edit
Bug 16387: Fix default shortened loan period time

When a loan period is shortened due to using decreaseLoanHighHolds* the time is
always set to the current time in X days, even if the original loan period is
given in days and not in hours.

It should default to 23:59 as is normal for loan periods given in days.

As original due date time defaults to 23:59 when given in days, this patch
modifies the hours and minutes of shortened due date to be equal to original
due
date.

To test:
1. prove t/db_dependent/DecreaseLoanHighHolds.t

Signed-off-by: Grace McKenzie 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16387] Incorrect loan period calculation when using decreaseLoanHighHolds feature

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4126] bulkmarcimport.pl allows -b and -a to be specified simultaneously

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4126

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #58833|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 59618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59618=edit
Bug 4126 - Exit bulkmarcimport if -a and -b given

Currently it is possible to spceify both --biblios and --authorities
as command line switches to bulkmarcimport.pl. This does not make sense
so we should exit early and explain that these switches are mutually
exclusive.

To test:
- Run one of these and check that there is no complaint about missing
  options:
  perl misc/migration_tools/bulkmarcimport.pl -a -b
  sudo koha-shell -c "perl misc/migration_tools/bulkmarcimport.pl -a -b"
  kohadev
- Observe that this displays the perldoc, but does not complain about
  mutually exclusive switches.
- Apply the patch
- Rerun the command(s) from earlier.
- Verify that the script is now halted and a small explanation given.

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4126] bulkmarcimport.pl allows -b and -a to be specified simultaneously

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4126

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280

--- Comment #15 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #14)
> (In reply to Jonathan Druart from comment #13)
> > I think that this patch should not be pushed before bug 17964.
> 
> There is no direct connection? These patches do a simple change to the
> default notice that works and only depends on biblio and branch, not issues.

They prove that CHECKIN and CHECKOUT work and will still work if a change is
done in template processing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030

--- Comment #35 from Katrin Fischer  ---
Critical bug, can we get this moving again? We had another report for barcode
going missing when editing from the serials module. That's bad.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12437] <> 952$h field not populated while sending Routing List Notice

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12437

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #4 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 13972 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13972] Include fields from subscription and serial table in serial notification email

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13972

Katrin Fischer  changed:

   What|Removed |Added

 CC||b...@eclateng.com

--- Comment #11 from Katrin Fischer  ---
*** Bug 12437 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #40 from Marcel de Rooy  ---
>From khall on irc to clarify:

marcelr: pluggability should be for the controlling behavior, not for the
action imo. I'm trying to say if the plugin hook could be used to decide if any
given hold form field should be required it would make more sense to me. That
being said, I'm not opposed to it the way it works atm. I'm wondering if maybe
HEA should be able to track installed plugins, that would be useful

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

--- Comment #23 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #22)
> Oops, did not see [Josef Moravec's] comment before passing QA.
> Anybody has opinions?

A new enhancement that actually has configurable search bar letting you also
set the default active tab? In short, let this pass, and fix it elsewhere.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #41 from Mehdi Hamidi  ---
Hello Jenny,

Went into ByWater sandbox on 1/27/17.
- Adding an entry in the future worked for me, I added an exception and a fixed
holiday and they were both added and their hours changed.

- Copy calendar to an other branch will take the current state of the calendar
and copy it to another. Holidays that there were not saved will not be copied.
So you will have to save your changes, and then, copy calendar.
I tested it and it copied the Alphaville to Betatown.

Mehdi Hamidi

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #39 from Kyle M Hall  ---
I'm really on the fence. I don't see anything wrong with extending the plugin
functionality, but on the other hand, there is a *very* specific behavior. If
it were an extension to control all the hold fields it would seem a bit less
odd.

Marcel, considering the small size of the patches, I don't think moving the sub
to Koha::Hold is too big of an ask ; )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280

--- Comment #14 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #13)
> I think that this patch should not be pushed before bug 17964.

There is no direct connection? These patches do a simple change to the default
notice that works and only depends on biblio and branch, not issues.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #38 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #37)
> I would like to see the C4::Reserves sub moved to a Koha::Hold method at
> least.

I would not block this for that reason; the change was already pending before
Koha::Objects were invented :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18004] Koha don't add authority id that exist

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18004

--- Comment #1 from Marcel de Rooy  ---
Please describe in more detail what you are doing exactly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18000] Add --tablename option to misc/devel/ update_dbix_class_files.pl script

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000

--- Comment #5 from Jonathan Druart  
---
It would be good to pass several tables. It seems that we can pass a regexp, so
I tried:
  --tablename='*borro*'

And got:
\A* matches null string many times in regex; marked by <-- HERE in m/\A* <--
HERE borro*\z/ at misc/devel/update_dbix_class_files.pl line 59.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18000] Add --tablename option to misc/devel/ update_dbix_class_files.pl script

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000

Jonathan Druart  changed:

   What|Removed |Added

 QA Contact|alex.arn...@biblibre.com|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18000] Add --tablename option to misc/devel/ update_dbix_class_files.pl script

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000

--- Comment #4 from Alex Arnaud  ---
(In reply to Jonathan Druart from comment #3)
> I think this is fixed in new version of DBIx::Class::Schema::Loader, I have
> 0.07042

Tested with version 0.07046 and it's better but i still got about thirty files
modified. I keep thinking this feature could be nice to avoid that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18004] New: Koha don't add authority id that exist

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18004

Bug ID: 18004
   Summary: Koha don't add authority id that exist
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: Linux
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: angelosebast...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

When we try to add an authority in field 701 702, that is, where a field with
authorized value exists, it does not add the authority that exists, it creates
another authority id.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Jonathan Druart  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #37 from Jonathan Druart  
---
I do not manage to clear up my mind about the use of this plugin.

I'd say it's the kind of feature that could be driven by a syspref. The
quantity of code to wrap the plugin seems the same as the size of the plugin
itself. It is also the kind of code we will not be able to know if it is used
by someone in few years (what we do have with a syspref, cf Hea).

I would like to see the C4::Reserves sub moved to a Koha::Hold method at least.

Kyle, can we get your opinion on this one please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #70 from Jonathan Druart  
---
Found a bug:
If a attr is editable at the opac and the patron clear the field, it appears in
the patron modifications to approve/deny. But if you approve it, it's not
cleared.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280

--- Comment #13 from Jonathan Druart  
---
I think that this patch should not be pushed before bug 17964.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15282] Switch default CHECKIN notice to Template Toolkit

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282

--- Comment #6 from Jonathan Druart  
---
I think that this patch should not be pushed before bug 17964.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18003] Should deletedborrowers.borrowernumber be a primary key?

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003

--- Comment #1 from Jonathan Druart  
---
Created attachment 59616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59616=edit
Bug 18003: Example of why we would need a PK on deletedborrowers

These tests do not pass:
DBIx::Class::ResultSource::_pri_cols_or_die(): Operation requires a primary key
to be declared on 'Deletedborrower' via set_primary_key at
t/db_dependent/Koha/Patrons.t line 329

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18003] Should deletedborrowers.borrowernumber be a primary key?

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003

Jonathan Druart  changed:

   What|Removed |Added

 CC||alex.sassmannshausen@ptfs-e
   ||urope.com,
   ||fridolin.som...@biblibre.co
   ||m,
   ||julian.maur...@biblibre.com
   ||, katrin.fisc...@bsz-bw.de,
   ||k...@bywatersolutions.com,
   ||m.de.r...@rijksmuseum.nl,
   ||martin.renvoize@ptfs-europe
   ||.com,
   ||n...@bywatersolutions.com,
   ||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18000] Add --tablename option to misc/devel/ update_dbix_class_files.pl script

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
I think this is fixed in new version of DBIx::Class::Schema::Loader, I have
0.07042

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15282] Switch default CHECKIN notice to Template Toolkit

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782

--- Comment #18 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #17)
> Let's deal with deletedborrowers.borrowernumber as a PK on another bug
> report.

See bug 18003.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15282] Switch default CHECKIN notice to Template Toolkit

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15282] Switch default CHECKIN notice to Template Toolkit

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282

--- Comment #5 from Marcel de Rooy  ---
Created attachment 59615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59615=edit
Bug 15282 - Switch default CHECKIN notice to Template Toolkit

Test Plan:
1) Ensure dependancies are applied
2) Apply this patch
3) Update your CHECKIN notice to match the following:

The following items have been checked in:

[% biblio.title %]

Thank you.

3) Generate a CHECKIN notice for a patron
4) Note there is no change to the generated notice

Signed-off-by: Mirko Tietgen 

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18003] New: Should deletedborrowers.borrowernumber be a primary key?

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003

Bug ID: 18003
   Summary: Should deletedborrowers.borrowernumber be a primary
key?
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 17782

(Raised from bug 17782)

DBIC needs a primary key to work correctly.
We could be tempt to make borrowernumber a primary key, but a use case could
bring thing. Indeed if a table is empty and the mysql (mariadb behaves
identically) server restarted, the Auto Increment (AI) is reset.

Problematic use case:
1. Install Koha
2. Create a patron (borrowers.borrowernumber = 1)
3. Delete it (deletedborrowers.borrowernumer = 1, and AI is set to 2
4. Restart mysql
=> borrowers is empty so AI is reset
5. Create a patron (borrowers.borrowernumber = 1)
6. Delete it
=> We will try to insert a new row with an existing borrowernumber (1) into the
deletedborrowers table: BOOM

Solution 1:
Do not care about this problematic use case and prevent to delete the last
patron.

Solution 2:
Add a AI primary key (id) to deletedborrowers
=> The 2 tables borrowers and deletedborrowers will differ, bugs will be
expected

Solution 3:
Deal with that at code level: when a patron is created, guess the
borrowernumber it will get and check if it does not already exist in the
deletedborrowers table. If so, force it before inserting it

Solution 4:
Do not enforce this constraint at DB level but set the primary key to DBIC
schema:
  Koha::Schema::Result::Deletedborrower:
__PACKAGE__->set_primary_key("borrowernumber");
Problem:
  Koha::Database->new->schema->resultset('Deletedborrower')->find(42);
will raise a warning "DBIx::Class::Storage::DBI::select_single(): Query
returned more than one row.  SQL that returns multiple rows is DEPRECATED for
->find and ->single" if 42 is duplicated, and the first matching row will be
picked

Another solution?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782
[Bug 17782] Patron updated_on field should be set to current timestamp when
borrower is deleted
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18003


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003
[Bug 18003] Should deletedborrowers.borrowernumber be a primary key?
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280

--- Comment #12 from Marcel de Rooy  ---
The fact that we should replace <> by [% branch.field %] is
somewhat confusing ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280

Marcel de Rooy  changed:

   What|Removed |Added

Version|unspecified |master
 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #57173|0   |1
is obsolete||

--- Comment #11 from Marcel de Rooy  ---
Created attachment 59614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59614=edit
Bug 15280 - Switch default CHECKOUT notice to Template Toolkit

Test Plan:
1) Ensure dependancies are applied
2) Apply this patch
3) Update your CHECKOUT notice to match the following:

The following items have been checked out:

[% biblio.title %]

Thank you for visiting [% branch.branchname %].

3) Generate a CHECKOUT notice for a patron
4) Note there is not change to the generated notice

Signed-off-by: Mirko Tietgen 

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15566] Update API to allow to reserve first available item from a group of titles

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15566

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #8 from Marcel de Rooy  ---
Blocked: this depends on a failed qa report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA

--- Comment #8 from Marcel de Rooy  ---
Would be nice to validate this small change with a small test in e.g.
t/db_dependent/SIP/Message.t
We already have a test there for patron info.
Should not be big deal :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17846] Remove C4::Koha::get_infos_of

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #58596|0   |1
is obsolete||
  Attachment #58597|0   |1
is obsolete||

--- Comment #7 from Marcel de Rooy  ---
Created attachment 59610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59610=edit
Bug 17846: Remove C4::Koha::get_infos_of

This subroutine does not longer make any senses. The call to
get_infos_of can be replaced with $dbh->selectall_hashref.
The third argument of this subroutine was never used.

Test plan (for developer only):
Compare the 2 codes and confirm that they are equivalent

Signed-off-by: Mark Tompsett 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17846] Remove C4::Koha::get_infos_of

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
Version|unspecified |master
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17846] Remove C4::Koha::get_infos_of

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17846] Remove C4::Koha::get_infos_of

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846

--- Comment #8 from Marcel de Rooy  ---
Created attachment 59611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59611=edit
Bug 17846: Remove get_infos_of declaration

The function which was removed was still being exported.
This removes it completely.

Signed-off-by: Mark Tompsett 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

--- Comment #22 from Jonathan Druart  
---
(In reply to Josef Moravec from comment #19)
> Hm, what about
> 
> syspref|checkout|checkin|catsearch combination?

Oops, did not see your comment before passing QA.
Anybody has opinions?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

--- Comment #21 from Jonathan Druart  
---
Created attachment 59609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59609=edit
Bug 17793: Follow up for identified missing changes

I ran:
$ git grep -l cat-search.inc | grep admin

This means I believe the outstanding ones are
(koha-tmpl/intranet-tmpl/prog/en/modules/):
- admin/auth_subfields_structure.tt
- admin/clone-rules.tt
- admin/marc_subfields_structure.tt
- admin/searchengine/elasticsearch/mappings.tt

One other was recommended by Katrin in comment #9:
- plugins/plugins-home.tt

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #58407|0   |1
is obsolete||
  Attachment #59507|0   |1
is obsolete||

--- Comment #20 from Jonathan Druart  
---
Created attachment 59608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59608=edit
Bug 17793: Make sysprefs search show on all Admin pages

This patch is amended to use the sysprefs search on all Administration
pages that do not have their own custom search.

To test:
1) Go to Administration
2) Notice Catalogue search at the top - seems out of place.
3) Apply patch and refresh page.
4) Notice admin / sysprefs search now shows and is more appropriate.
5) Confirm searching for sysprefs still works

This patch affects the following pages:
- admin-home.pl
- audio_alerts.pl
- authtypes.pl
- auth_tag_structure.pl
- authorised_values.pl
- biblio_framework.pl
- marctagstructure.pl
- branch_transfer_limits.pl
- branches.pl
- checkmarc.pl
- classsources.pl
- columns_settings.pl
- didyoumean.pl
- edi_accounts.pl
- edi_ean_accounts.pl
- fieldmapping.pl
- item_circulation_alerts.pl
- items_search_fields.pl
- items_search_field.pl
- item_types.pl
- koha2marklinks.pl
- matching-rules.pl
- oai_sets.pl
- oai_set_mappings.pl
- patron-attr-types.pl
- smart-rules.pl
- transport-cost-matrix.pl
- sms_providers.pl

Sponsored-by: Catalyst IT

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782

--- Comment #17 from Jonathan Druart  
---
Let's deal with deletedborrowers.borrowernumber as a PK on another bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

--- Comment #19 from Josef Moravec  ---
Hm, what about

syspref|checkout|checkin|catsearch combination?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782

--- Comment #16 from Jonathan Druart  
---
Created attachment 59607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59607=edit
Bug 17782: Fix tests

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #58913|0   |1
is obsolete||
  Attachment #59558|0   |1
is obsolete||
  Attachment #59573|0   |1
is obsolete||
  Attachment #59583|0   |1
is obsolete||

--- Comment #14 from Jonathan Druart  
---
Created attachment 59605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59605=edit
Bug 17782 - Patron updated_on field should be set to current timestamp when
borrower is deleted

To test:
01 Find a patron
02 Get the updated_on value from the db in borrowers table
03 Delete the patron
04 Get the update_on value from the db on deletedborrowers table
05 Values from 02 and 04 are the same
06 Apply patch
07 Repeat 01-04
08 Values should now be different

Signed-off-by: Claire Gravely 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782

--- Comment #15 from Jonathan Druart  
---
Created attachment 59606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59606=edit
Bug 17782 - (QA Followup)

Fix tests

prove t/db_dependent/Koha/Patrons.t

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17788] (MARC21) $9 fields not indexed in authority-linked fields

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17788] (MARC21) $9 fields not indexed in authority-linked fields

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 114 matches

Mail list logo