[Koha-bugs] [Bug 18052] Show link to the item for an issue on serial collection page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18052 Josef Moravecchanged: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18053] Allow to manually link items to serial issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18053 Josef Moravecchanged: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18044] Label Batches not displaying
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18044 Josef Moravecchanged: What|Removed |Added CC||josef.mora...@gmail.com --- Comment #2 from Josef Moravec --- I can confirm it on master too -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 --- Comment #17 from Tomás Cohen Arazi--- (In reply to Marcel de Rooy from comment #16) > (In reply to Tomás Cohen Arazi from comment #15) > > (In reply to Marcel de Rooy from comment #14) > > > Thanks, Nick. You beat me in signing off :) > > > > You can QA it ;-) > > Good plan. Just a dumb question btw: why do you use uppercase TO_JSON? > Is it that important :) > Note that I see everywhere get_whatever etc. I personally dislike ->get_whatever, and prefer ->whatever in most cases (->as_json would be acceptable, because it is clear we want the object in a specific serialization format). Anyway, this time we are just sticking to what JSON libraries expect from blessed objects to accept them for rendering as JSON strings. See http://search.cpan.org/~makamaka/JSON-2.90/lib/JSON.pm#allow_blessed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 --- Comment #16 from Marcel de Rooy--- (In reply to Tomás Cohen Arazi from comment #15) > (In reply to Marcel de Rooy from comment #14) > > Thanks, Nick. You beat me in signing off :) > > You can QA it ;-) Good plan. Just a dumb question btw: why do you use uppercase TO_JSON? Is it that important :) Note that I see everywhere get_whatever etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18054] New: Refreshing the screen for a confirmed checkout can cause odd results ( item checked out and waiting on hold)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18054 Bug ID: 18054 Summary: Refreshing the screen for a confirmed checkout can cause odd results (item checked out and waiting on hold) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com To recreate: 1 - Place a hold and confirm it to mark waiting 2 - Checkout that item to another patron and override the hold 3 - Leave that window open 4 - In a new tab checkin the item and confirm the hold as waiting 5 - Refresh the tab from #3 - the item checksout but waiting hold does not revert -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Barton Chittendenchanged: What|Removed |Added CC||bar...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 --- Comment #15 from Tomás Cohen Arazi--- (In reply to Marcel de Rooy from comment #14) > Thanks, Nick. You beat me in signing off :) You can QA it ;-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17927] REST API: /holds and /patrons attributes have wrong types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17927 Tomás Cohen Arazichanged: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17927] REST API: /holds and /patrons attributes have wrong types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17927 --- Comment #10 from Tomás Cohen Arazi--- Created attachment 59899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59899=edit Bug 17927: (QA followup) Fix timestamp nullable in hold.json Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 M. Tompsettchanged: What|Removed |Added Status|Needs Signoff |Failed QA CC||mtomp...@hotmail.com --- Comment #2 from M. Tompsett --- Let's start with the good: authbylogin -- cleaned up. SCOUserJS, SCOUserCSS -- both fixed. AllowSelfCheckReturns -- remnant left behind, but variable is used, so that's okay. Then the weird: display_patron_image -- something isn't quite right. It is only set if there is an image to display, whereas the preference change makes no such distinction. cardnumber is currently only set if there is an image, you could expand the condition. Strangely, cardnumber isn't even used in the template currently. The image logic is using borrower number. Something is wrong. Recommendation: Perhaps a prequel bug is in order to deal with this patron image bug in self-checkout? And lastly the reason I'm Failing QA. $selfchecktimeout -- Remnant left behind, which deals with system preference not being set. Logic in sco-main.tt line 343 does not deal with system preference not being set. Also line 419 in sco-main.tt was unchanged. Recommendation: leave the logic for this as was OR put the logic into the TT file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #79 from Tomás Cohen Arazi--- Created attachment 59898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59898=edit Bug 13757: Better display for attr changes in members-update.pl This patch changes the way changed attributes are displayed for the staff user to make the decision to approve (or not) the changes. Regards -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Tomás Cohen Arazichanged: What|Removed |Added Attachment #59813|0 |1 is obsolete|| --- Comment #77 from Tomás Cohen Arazi --- Created attachment 59896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59896=edit Bug 13757: (QA followup) Fix non-editable attrs on failed save When a field is not editable but displayable in the OPAC, and you submit an incomplete/wrong update, those attributes are displayed as empty. This patch fixes that. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #78 from Tomás Cohen Arazi--- Created attachment 59897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59897=edit Bug 13757: Make K::P::Modifications->pending return K::P::Attribute This patch makes Koha::Patron::Modifications->pending return Koha::Patron:Attribute objects. They are not stored on the DB but only live in memory on runtime. members-update.pl is the only place this is used, and this way we have all we need for better rendering the UI. Tests are added for the changed API. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Jonathan Fieldchanged: What|Removed |Added CC||jonathan.field@ptfs-europe. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Andrew Isherwoodchanged: What|Removed |Added CC||andrew.isherwood@ptfs-europ ||e.com --- Comment #12 from Andrew Isherwood --- Installing the Dummy ILL connector == The Dummy connector returns canned responses to search requests and should be used for basic testing of ILL functionality. INSTALL --- - Change to the correct directory: cd /Koha - If the 'Illbackends' directory does not exist, create it: mkdir Illbackends - Change to the backends directory: cd Illbackends - Clone the Dummy connector repository: git clone https://github.com/a-sassmannshausen/Dummy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #11 from Andrew Isherwood--- Created attachment 59895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59895=edit ILLModule -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #10 from Andrew Isherwood--- Created attachment 59894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59894=edit DO NOT PUSH: Updated Schema files. * Koha/Schema/Result/Borrower.pm: New file. * Koha/Schema/Result/Branch.pm: New file. * Koha/Schema/Result/Illrequest.pm: New file. * Koha/Schema/Result/Illrequestattribute.pm: New file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #9 from Andrew Isherwood--- Created attachment 59893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59893=edit Bug 7317: Add SQL templates & sysprefs. * installer/data/mysql/atomicupdate/ill_tables.sql: New file. * installer/data/mysql/kohastructure.sql: Add tables. * installer/data/mysql/sysprefs.sql: Add sysprefs. * installer/data/mysql/userflags.sql: Add userflags. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add sysprefs to UI. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 --- Comment #35 from Francois Charbonnier--- Hello, If you're still interested by this patch, please have a look at this one who add this feature and fixes the issue from bug 11211. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015#c46 Any help to help us get it upstreamed will be much appreciated! Thanks! François -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 --- Comment #57 from Francois Charbonnier--- Hello, If you're still interested by this patch, please have a look at this one who fixes the issue, but also add the feature from bug 8133. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015#c46 Any help to help us get it upstreamed will be much appreciated! Thanks! François -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #46 from Francois Charbonnier--- When I read again the description here, I felt that an overview of the work and its benefits will help you anyone who wants to get involved. Short version : The communinity and some of our clients noticed two issues : 1. Hour loans doesn't know when a library is closed 2. We have performance issues when checking in overdue book or managing overdue fines. We identified that both issues are related to the way Koha does date calculation. To improve and fix these issues, we developped a new calendar with a couple of new features. The benefits of this new calendar are : 1. management of the libraries opening hours (new feature). 2. performance improvement when circulating items and managing fines. In particular, when checking in overdue book or managing overdue fines. 3. help to setup holidays/closed days from one year to another (new feature) To acheive this, we redesigned the calendar database table and rewrote part of the code in charge of the date calculation. We used this work to move part of the code and separate what's in charge of the calendar and what's used to do the calculation. This way, we solved two bugzilla issues opened a long time ago : https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 (Move calculation code out of C4::Calendar) (opened by Jesse Weaver on the 2013-11-06) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 (hourly loans doesn't know when library closed) (opended by Nicole C. Engard on the 2012-05-21) For now, BZ11211 blocked BZ8133. All features from the old calendar is available in the new calendar. The new calendar passed all the unit tests. Long version : The calendar's database table contains only rules to set whether the library is closed or not. If Koha needs a date or a range of date (was the library closed that day? how long is this book overdue? etc.), it has to be calculated using these rules. Depending on the type of transactions, how Koha does the calculation is not always efficient. For example, a return of overdue books can take as long as many seconds (for 2 months old overdues for example). We redesigned the calendar table to be able to give Koha the information it needs to do the calculation in a more efficient way. In the calendar's new table, we don't store rules anymore. Each day from the calendar is now stored (an entry for each day). For each day, we can indicate if the library is open or closed. We took this redesign opportunity to add the library opening hours as well. That way, Koha gets straight the information it needs to determine if the library is open or not, it can take into consideration the opening hours (good for hour loans and the date range calculation is simplified by using the information stored in the database. No need to calculate it based on different rules anymore. Among the patches we submitted, we have a script to benchmark checkin and checkout transactions. The benchmark of checkin is more indicative of the performance improvement. Here is an example of collected statistics. When an item is returned the day the checkout expires, the calculation time decreased of 22% (for 100 checkins, the calculation time drops from 52.2s to 40.7s). When an item is 2 months overdue and returned, the calculation time decreased of 70% (for 100 checkins, the calculation time drops from 154s to 46.6s). How does the new calendar work ? Before the first use, a script will populate the new calendar table with on entry for each day of the year. This script can retreive your actual setting to keep track of your old set up. It also creates all the entries for future years. The basic set up would be : the library wants to have a 1 year overview of the calendar so they can set it up in advance. The script creates every entry in the table to be able to set up the calendar 1 year in advance. Then, another script will be scheduled to run every day. This script will add a new entry for every day spent. In this manner, Koha keeps a 1 year advance overview at all time. The advantage of this last script is to help the koha admin to set up the calendar in advance. Each time the script will add a new entry (a new day), it will check one year in the past how the same day was set up to try to determine if the library should be closed or not : - If the date is a unique holiday : the script will not keep it for the new entry. - If the date is a repeatable holiday : the script will keep it. (For example, a library closed every saturday) - If the day type was "floatting" (it's a new type of holiday) : the new entry status is "needs confirmation". Thus, when setting up the calendar, I have two options : 1. I know it's a repeatable holiday every year or very week, I choose the date type 'repeatable'. When the script add a new entry, it keeps the holiday. 2. I want to check the holiday
[Koha-bugs] [Bug 14405] Add datatable to fines table in OPAC patron account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14405 M. Tompsettchanged: What|Removed |Added Attachment #59764|0 |1 is obsolete|| --- Comment #2 from M. Tompsett --- Created attachment 59892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59892=edit Bug 14405: Add datatables to fines table in OPAC To test: 1) Apply patch 2) Go to OPAC -> Your account 3) Confirm you can now sort on all columns Sponsored-by: Catalyst IT NOTE: NICE! Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14405] Add datatable to fines table in OPAC patron account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14405 M. Tompsettchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11932] move delete checkbox on patron modification to right
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11932 M. Tompsettchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11932] move delete checkbox on patron modification to right
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11932 M. Tompsettchanged: What|Removed |Added Attachment #59835|0 |1 is obsolete|| --- Comment #2 from M. Tompsett --- Created attachment 59891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59891=edit Bug 11932: Move delete checkbox on patron modification to right To test: 1) Go to Tools -> Batch patron modification 2) Put in a user cardnumber and click Continue 3) Notice checkboxes on the left of the input fields 4) Apply patch and refresh page (resend information if prompted) 5) Notice checkboxes on the right of the input fields 6) Confirm they still work as expected Sponsored-by: Catalyst IT NOTE: Why not left before the label? And while functional, is there a pretty align it nicely with all the other checkboxes CSS styling somehow? Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15408] Timestamp not updated when you duplicate a budget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 M. Tompsettchanged: What|Removed |Added Attachment #59887|0 |1 is obsolete|| --- Comment #3 from M. Tompsett --- Created attachment 59890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59890=edit Bug 15408 : deleted the timestamp so that the database gives a new one To duplicate the budget, the function CloneBudgetHierarchy create a new budget from the old without the parameter timestamp, so that the database generates a new one. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15408] Timestamp not updated when you duplicate a budget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 M. Tompsettchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #45 from Mehdi Hamidi--- Hello everyone, We updated the UI a little a bit and changed the behavior of the add_days script. UI updates: - Moved copy to another branch to the top, just like in circulation rules, to follow the current Koha pattern. - Inputs for past days are now disabled for clarity since they can't be edited. - Renamed Normal day to Working day for clarity. - Renamed Fixed holiday to Repeatable holiday for clarity. - Renamed Exception holiday to Unique holiday for clarity. - Added coloring to all datepickers. Script add_days_discrete_calendar.pl: - Unique holidays will no longer be "Need validation" when copied from a past date. - Added debug option to display the details about the added date. - Branchcodes will now be retrieved from table discrete_calendar instead of branches to prevent empty data and errors. Patch test plan: 1- Apply patch 2- Run installer/data/mysql/updatedatabase.pl 3- Run the script add_days_discrete_calendar.pl with debug option 4- Generate schemas by running misc/devel/update_dbix_class_files.pl 5- Run test t/db_dependent/DiscreteCalendar.t 6- Run all of Koha's tests in t/ UI test plan : - Go tools and choose Discrete Calendar - The field title is optional. [Change past] - Choose any date from the calendar that is yesterday or older. - Everything should be disabled except the To date. You can only use past dates to copy into different dates. Adding holidays : [Unique holiday] - Choose any date from the calendar that is today or in the future. - Choose another date in the To date field that is in the future (optional, for range only). - Change Date type to : Unique holiday. - Save. Result: **All dates in the range should be marked red for unique holiday.** [Weekly] - Choose a Sunday from the calendar that is editable (today or in the future). - Change Date type to : Weekly. - Save. Result: **All upcoming (starting from today) Sundays will be holidays.** PS: Title, open and close hour will be affected to **ALL SUNDAYS** unless the inputs are empty. [Repeatable] - Choose any date from the calendar that is today or in the future. - Change Date type to : Repeatable holiday. - Save Result: **The selected date and the same day in the future (if available in Calendar) will be holiday.** Delete holidays : [Single date] - Choose any date from the calendar that is today or in the future and is also a holiday. - Change Date type to : Working day. - Save. Result: **The selected date should be a Working day** [Range of dates] - Choose any date from the calendar that is today or in the future. - Choose another date in the To date field that is in the future. - Change date type to : Normal day - Save. Result: **The selected range of dates should be Working days** [Delete type] - Choose any date from the calendar that is today or in the future and is a weekly or a repeatable holiday. - Change date type to : Working day. - Check : Delete this type CheckBox - Save. Result: -Weekly, all upcoming weekly holidays if that day will be normal days. Example : all upcoming Sundays will be working days -Fixed, all upcoming fixed holidays of that day will be normal days. Example : all upcoming 25 December will be working days [Copy dates, 1 day to multiple] - Choose starting date from the calendar. - Select Copy to different dates - Choose starting date. - Choose end date date. - Save. Result: **The selected day details will be copied to all the dates in the range.** [Copy dates, 1 week to 1 week] - Choose starting date from the calendar. - Choose end date in the To date field to make a whole week(7 days). - Select Copy to different dates - Choose starting date. - Choose end date date to make a whole week(7 days). - Save. Result: **Every day of week from the first range will be applied to the second range. Independently of the order. Exemple : Sunday1 to Sunday2, Monday1 to Monday2, etc.** [Copy dates, multiple dates to multiple dates] - Choose start date from the calendar. - Choose end date in the To date field. - Select Copy to different dates - Choose start date. - Choose end date date to have the same number of days as the first range - Save. Result: **Each day from the first range will be applied the second range in the same order. Exemple : day1 to day1, day2 to day2, etc.** [Copy to branch] - The from branch is the current used calendar (Define the holidays for) - Choose a calendar to copy TO, from the second Dropdown. - Click on Clone. - Choose Copy calendar to in the Dropdown : Define the holidays for. Result: **All of the information in the current calendar will be copied to the selected calendar** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs
[Koha-bugs] [Bug 17950] Small improvements for Merge.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 --- Comment #11 from M. Tompsett--- (In reply to Julian Maurice from comment #9) > I wonder if making a test script parameterizable is the way to go here. It is the most expandable, in terms of we don't know what marcflavors will be valid in the future, and writing code such that you have to change it all the time is kind of annoying. Plus, I agree with Marcel in comment #10. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17950] Small improvements for Merge.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 --- Comment #10 from Marcel de Rooy--- (In reply to Julian Maurice from comment #9) > I wonder if making a test script parameterizable is the way to go here. > Wouldn't it be cool to run the tests for each MARC flavour when you run > prove ? :) > > Not blocking for QA, just a thought. Yes, we could to that. But I prefer to postpone it to another report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17950] Small improvements for Merge.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 --- Comment #9 from Julian Maurice--- I wonder if making a test script parameterizable is the way to go here. Wouldn't it be cool to run the tests for each MARC flavour when you run prove ? :) Not blocking for QA, just a thought. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18053] New: Allow to manually link items to serial issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18053 Bug ID: 18053 Summary: Allow to manually link items to serial issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com In some cases, when items for a subscription have been (accidentally) added outside the subscriptions module, it would be nice if it was possible to link the items to their corresponding serial issues manually. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18052] New: Show link to the item for an issue on serial collection page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18052 Bug ID: 18052 Summary: Show link to the item for an issue on serial collection page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com It would be nice if there was a link to edit the item linked to a specific serial issue from within the serials module. For example, a new column with an 'edit item' link could be added to the serials-collection page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidichanged: What|Removed |Added Attachment #59517|0 |1 is obsolete|| --- Comment #44 from Mehdi Hamidi --- Created attachment 59889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59889=edit Bug 17015 - Tests for DiscreteCalendar -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidichanged: What|Removed |Added Attachment #59587|0 |1 is obsolete|| --- Comment #43 from Mehdi Hamidi --- Created attachment 59888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59888=edit Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidichanged: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15408] Timestamp not updated when you duplicate a budget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 Baptistechanged: What|Removed |Added CC||baptiste.wojtkowski@biblibr ||e.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15408] Timestamp not updated when you duplicate a budget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 Baptistechanged: What|Removed |Added Attachment #59886|0 |1 is obsolete|| --- Comment #2 from Baptiste --- Created attachment 59887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59887=edit Bug 15408 : deleted the timestamp so that the database gives a new one To duplicate the budget, the function CloneBudgetHierarchy create a new budget from the old without the parameter timestamp, so that the database generates a new one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15408] Timestamp not updated when you duplicate a budget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 --- Comment #1 from Baptiste--- Created attachment 59886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59886=edit Bug 15408 : deleted the timestamp so that the database gives a new one To duplicate the budget, the function CloneBudgetHierarchy create a new budget from the old without the parameter timestamp, so that the database generates a new one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18051] New: Advanced Editor - Rancor - encoding issues with some sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18051 Bug ID: 18051 Summary: Advanced Editor - Rancor - encoding issues with some sources Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl This source for example: http://www.webclarity.info/registry/display?fileID=69 All displays fine from basic editor - rancor however causes garbled characters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18050] New: Missing constraint foreign key on table aqbudget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Bug ID: 18050 Summary: Missing constraint foreign key on table aqbudget Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: gmcha...@gmail.com Reporter: baptiste.wojtkow...@biblibre.com QA Contact: testo...@bugs.koha-community.org There is not foreign key constraint on the column budget_parent_id in the table aqbudget. It is so possible to delete a budget without deleting the associated fund. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #42 from David Gustafsson--- Ok! One more try. A little bit unsure how to handle attribution, right now looks like the patch is attributed to me which is wrong. But hope it will at least apply now (also hope I did not make any mistake during the rebase, when through the patch several times to check everything adds up, but still might have botched something up). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafssonchanged: What|Removed |Added Attachment #59812|0 |1 is obsolete|| --- Comment #41 from David Gustafsson --- Created attachment 59885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59885=edit Bug 14957 - Rule based permission for MARC fields Add a rule based permission system for MARC field modifications. Test plan: 1. Apply this patch 2. Run updatedatabase.pl 3. Log in to staff client 4. Enable new syspref MARCPermissions 5. You should see a new link "MARC field permissions" in the "Catalog" section under "Koha administrtion". 6. Go to the "MARC field permissions" page 7. Next to the page heading ("Manage MARC field permissions") there is a button with a question mark, click this for more information about the rule system. 8. Add desired rules to the rule table, press the +-button to add. 9. Clicking the pen-icon (edit) should allow you to edit corresponding rule. 10. Clicking the x-icon should remove corresponding rule after confirmation. 11. Selecting one or more rules followed by clicking the trash-icon should remove all selected rules after confirmation. 12. To test your rules, import or in other way modify a record. 13. Check that the record was modified as defined by your rules. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafssonchanged: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18040] Updating buttons on Tools->Upload Local Cover Image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18040 M. Tompsettchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18040] Updating buttons on Tools->Upload Local Cover Image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18040 M. Tompsettchanged: What|Removed |Added Attachment #59833|0 |1 is obsolete|| --- Comment #2 from M. Tompsett --- Created attachment 59884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59884=edit Bug 18040: Updating buttons in Tools -> Upload local cover image To test: 1) Go to Tools -> Upload local cover image 2) Select an image and click Upload file 3) Notice Process images button looks different to Upload file button 4) Apply patch and refresh page 5) Follow steps 1-3 again and notice the changed styling of the buttons Sponsored-by: Catalyst IT NOTE: Kind of sad that the input type="file" is harder to style. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18049] New: record export fails on callnumber limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18049 Bug ID: 18049 Summary: record export fails on callnumber limit Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: verolenci...@yahoo.com.ar QA Contact: testo...@bugs.koha-community.org If you export marc records and select callnumber limits you get this error: DBIx::Class::ResultSet::next(): Unknown column 'callnumber' in 'where clause' at /usr/share/koha/lib/Koha/Objects.pm line 150 Very similar to Bug 17420. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #40 from Andreas Hedström Mace--- (In reply to Magnus Enger from comment #39) > Indeed, it looks more like a regular diff than a git patch. It seems odd > that this should trigger the error that Andreas got, though. But I tested, > an I get the same error on this patch while other patches work as they > should. A new patch looks like a good place to start, though. :-) Yeah, as I have never seen such an error either I made sure to check that other patches applied as intended, which they did. Sounds great if you can provide a follow-up David! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18048] New: Add index on biblioitems.ean
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18048 Bug ID: 18048 Summary: Add index on biblioitems.ean Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcha...@gmail.com Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org In big databases querying on the EAN can take a while, it would be nice to have an index on this column as we have on other columns with standard numbers in this table already: 196 PRIMARY KEY (`biblioitemnumber`), 197 KEY `bibinoidx` (`biblioitemnumber`), 198 KEY `bibnoidx` (`biblionumber`), 199 KEY `itemtype_idx` (`itemtype`), 200 KEY `isbn` (`isbn`(255)), 201 KEY `issn` (`issn`(255)), 202 KEY `publishercode` (`publishercode`), -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18046] Problem with redirect on logout with CAS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 Katrin Fischerchanged: What|Removed |Added Depends on||17481 --- Comment #1 from Katrin Fischer --- Sorry, had the wrong bug number: bug 17481 was the change that changed things... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 [Bug 17481] Cas Logout: bug 11048 has been incorrectly merged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17481] Cas Logout: bug 11048 has been incorrectly merged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 Katrin Fischerchanged: What|Removed |Added Blocks||18046 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 [Bug 18046] Problem with redirect on logout with CAS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Julian Mauricechanged: What|Removed |Added Attachment #59882|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Julian Mauricechanged: What|Removed |Added Attachment #59881|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Julian Mauricechanged: What|Removed |Added Attachment #59880|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Julian Mauricechanged: What|Removed |Added Attachment #59870|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Julian Mauricechanged: What|Removed |Added Attachment #59869|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Julian Mauricechanged: What|Removed |Added Attachment #59871|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #22 from Julian Maurice--- Oops, I didn't see Nick already did QA earlier. I will obsolete my patches (except for the followup) and de-obsolete Nick's patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #21 from Julian Maurice--- Created attachment 59883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59883=edit Bug 18014: QA follow-up: Use ok() instead of is() for '>' comparison Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Julian Mauricechanged: What|Removed |Added Attachment #59871|0 |1 is obsolete|| --- Comment #20 from Julian Maurice --- Created attachment 59882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59882=edit Bug 18014: AddAuthority should respect AUTO_INCREMENT Instead of using the MAX(authid)+1 logic, AddAuthority should just save the record and get the new id. The authid column is an autoincrement. This eliminates problems where a newly assigned authid also refers to a previously deleted record. (And it will not cause problems when refining the dontmerge functionality on report 9988.) Note: ModAuthority also calls AddAuthority to update an existing record; in that case we should not create a new record even if the record should not be found any more (which should be exceptional). This patch also simplifies handling of 001 in the authority record: in all cases this field is updated now; no need to check its contents. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t [2] Add a new authority record via the interface Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Julian Mauricechanged: What|Removed |Added Attachment #59870|0 |1 is obsolete|| --- Comment #19 from Julian Maurice --- Created attachment 59881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59881=edit Bug 18014: Add test to AuthoritiesMarc.t to expose problem in AddAuthority Since AddAuthority uses max(id)+1 logic to produce the next authid, authority id's will be reused when you delete the last record. This may be a source of problems and will be addressed on the next patch. This patch add a test to expose the problem. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Julian Mauricechanged: What|Removed |Added Attachment #59869|0 |1 is obsolete|| --- Comment #18 from Julian Maurice --- Created attachment 59880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59880=edit Bug 18014: General update of AuthoritiesMarc.t Modern::Perl, Koha::Database, etc. Test plan: Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #39 from Magnus Enger--- (In reply to David Gustafsson from comment #38) > I think I might not have followed the guidelines for submitting patches > properly. Will try to see if I can generate a patch using the recommended > tools (git bz etc). Indeed, it looks more like a regular diff than a git patch. It seems odd that this should trigger the error that Andreas got, though. But I tested, an I get the same error on this patch while other patches work as they should. A new patch looks like a good place to start, though. :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #38 from David Gustafsson--- I think I might not have followed the guidelines for submitting patches properly. Will try to see if I can generate a patch using the recommended tools (git bz etc). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Marcel de Rooychanged: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Marcel de Rooychanged: What|Removed |Added Attachment #58674|0 |1 is obsolete|| --- Comment #16 from Marcel de Rooy --- Created attachment 59877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59877=edit Bug 17737: Remove C4::Reserves::GetReservesFromItemnumber At this point, there should not be any occurrences of GetReservesFromItemnumber anymore. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Marcel de Rooychanged: What|Removed |Added Attachment #59872|0 |1 is obsolete|| --- Comment #18 from Marcel de Rooy --- Created attachment 59879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59879=edit Bug 17737: [QA Follow-up] Remove unused reservedfor variable The changes in this patch set obsolete this variable. Remove confusing comment about reserve via host record. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Marcel de Rooychanged: What|Removed |Added Attachment #58673|0 |1 is obsolete|| --- Comment #15 from Marcel de Rooy --- Created attachment 59876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59876=edit Bug 17737: Replace GetReservesFromItemnumber with Koha::Item->get_holds_placed_before_today On the same way of Koha::Biblio->get_holds, Koha::Biblio->get_holds_placed_before_today and Koha::Patron->get_holds, this new subroutin will permit to retrieve the holds placed on a specific item. Note that at the moment we do not need a Koha::Item->get_holds method: we do not want to display future holds placed in the future. Test plan: I would suggest to test this patch with patches from bug 17736 and bug 17738, to place different kind of holds (biblio and item level, future and past). Then do a whole workflow to detect bug, view a record, delete record, order, place a hold on an item which has been ordered, etc. The hold's informations should always be the same without or without these patches. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Marcel de Rooychanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Marcel de Rooychanged: What|Removed |Added Attachment #58675|0 |1 is obsolete|| --- Comment #17 from Marcel de Rooy --- Created attachment 59878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59878=edit Bug 17737: Rename holds_placed_before_today with current_holds Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Nick Clemenschanged: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17453] Inter-site holds improvement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 Nick Clemenschanged: What|Removed |Added CC||n...@bywatersolutions.com Status|Signed Off |Patch doesn't apply --- Comment #12 from Nick Clemens --- Patch doesn't apply, I also wonder about last patch: Allow pickup at a library where all items are checked out It only checks if items are checked out, but what about case of items waiting for pickup or damaged/lost? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16115] JavaScript error on item search form unless NOT_LOAN defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16115 Nick Clemenschanged: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #8 from Nick Clemens --- Fixed commit message - LOC case handled on bug 18047 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18047] JavaScript error on item search form unless LOC defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18047 Nick Clemenschanged: What|Removed |Added Assignee|gmcha...@gmail.com |n...@bywatersolutions.com Severity|enhancement |minor CC||claire_grav...@hotmail.com, ||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18047] JavaScript error on item search form unless LOC defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18047 Nick Clemenschanged: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18047] JavaScript error on item search form unless LOC defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18047 --- Comment #1 from Nick Clemens--- Created attachment 59875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59875=edit Bug 18047 - JavaScript error on item search form unless LOC defined If LOC is not present, the item search form will raise a JS error: SyntaxError: expected expression, got '}' This patch fixes it by handling this specific case. Note that the "Status" column is still displayed. Test plan: Remove your LOC authorised values Go on the item search form => You will not get the JS error and the "Shelving location" bloc is no longer displayed. There is no need to display it if empty. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18047] New: JavaScript error on item search form unless LOC defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18047 Bug ID: 18047 Summary: JavaScript error on item search form unless LOC defined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org If LOC is not present, the item search form will raise a JS error: SyntaxError: expected expression, got '}' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #14 from Marcel de Rooy--- (In reply to Marcel de Rooy from comment #13) > Need feedback on comment 11 before signoff. No longer, just misread the search call. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16115] JavaScript error on item search form unless NOT_LOAN defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16115 Nick Clemenschanged: What|Removed |Added Attachment #59659|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 59874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59874=edit Bug 16115: Remove JS error on item search if NOT_LOAN values do not exist If NOT_LOAN is not present, the item search form will raise a JS error: SyntaxError: expected expression, got '}' This patch fixes it by handling this specific case. Note that the "Status" column is still displayed. Test plan: Remove your NOT_LOAN authorised values Go on the item search form => You will not get the JS error and the "Status" bloc is no longer displayed. There is no need to display it if empty. Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16115] JavaScript error on item search form unless NOT_LOAN defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16115 Nick Clemenschanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #13 from Marcel de Rooy--- Need feedback on comment 11 before signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #12 from Marcel de Rooy--- Seems the same for two other occurrences. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #11 from Marcel de Rooy--- +my $item = Koha::Items->find( $itemnumber ); +$holds = $item->holds_placed_before_today; +my $dtf = Koha::Database->new->schema->storage->datetime_parser; +my $future_holds = $holds->search({ reservedate => { '>' => $dtf->format_date( dt_from_string ) } } ); +is( $future_holds->count, 0, 'holds_placed_before_today does not return a future next available hold'); +# 9788b: holds_placed_before_today does not return future item level hold Hm. You look at future_holds and then say something about the results of holds_placed_before_today as saved in holds ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8306] Patron stats, patron activity : no active doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8306 Nick Clemenschanged: What|Removed |Added Attachment #14066|0 |1 is obsolete|| Attachment #58874|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 59873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59873=edit Bug 8306: Patrons statistics, fix for patron activity choice The "inactive" for "patron activity" choice is now effective. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8306] Patron stats, patron activity : no active doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8306 Nick Clemenschanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #10 from Marcel de Rooy--- Minor inconsistency on the interface: if I set OPACShowHoldQueueDetails and place a future hold, opac-details says Available but also 1 (priority 1). Should be resolved somewhere else though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18044] Label Batches not displaying
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18044 Chris Nighswongerchanged: What|Removed |Added Priority|P5 - low|P2 Severity|enhancement |critical --- Comment #1 from Chris Nighswonger --- Bumping severity. Can anyone confirm this? I don't have an installation of this version handy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #9 from Marcel de Rooy--- Created attachment 59872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59872=edit Bug 17737: [QA Follow-up] Remove unused reservedfor variable The changes in this patch set obsolete this variable. Remove confusing comment about reserve via host record. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #17 from Nick Clemens--- Created attachment 59871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59871=edit Bug 18014: AddAuthority should respect AUTO_INCREMENT Instead of using the MAX(authid)+1 logic, AddAuthority should just save the record and get the new id. The authid column is an autoincrement. This eliminates problems where a newly assigned authid also refers to a previously deleted record. (And it will not cause problems when refining the dontmerge functionality on report 9988.) Note: ModAuthority also calls AddAuthority to update an existing record; in that case we should not create a new record even if the record should not be found any more (which should be exceptional). This patch also simplifies handling of 001 in the authority record: in all cases this field is updated now; no need to check its contents. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t [2] Add a new authority record via the interface Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #16 from Nick Clemens--- Created attachment 59870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59870=edit Bug 18014: Add test to AuthoritiesMarc.t to expose problem in AddAuthority Since AddAuthority uses max(id)+1 logic to produce the next authid, authority id's will be reused when you delete the last record. This may be a source of problems and will be addressed on the next patch. This patch add a test to expose the problem. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Nick Clemenschanged: What|Removed |Added Attachment #59700|0 |1 is obsolete|| Attachment #59701|0 |1 is obsolete|| Attachment #59702|0 |1 is obsolete|| --- Comment #15 from Nick Clemens --- Created attachment 59869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59869=edit Bug 18014: General update of AuthoritiesMarc.t Modern::Perl, Koha::Database, etc. Test plan: Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Nick Clemenschanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18046] Problem with redirect on logout with CAS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 Katrin Fischerchanged: What|Removed |Added Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18046] New: Problem with redirect on logout with CAS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 Bug ID: 18046 Summary: Problem with redirect on logout with CAS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcha...@gmail.com Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org Since updating to 3.22.14 which includes the fix for bug 17841, there is a problem when logging out of the OPAC with CAS. Settings: casLogout = Logout Before the update, you weren't redirected back to the OPAC after logout. Bug 17841 was supposed to fix this behaviour. After the update, we are sending the redirect URL in the service parameter of the logout URL: https://.../logout?url=https%3A%2F%2F...%2Fcgi-bin%2Fkoha%2Fopac-main.pl%3Flogout.x%3D1 The CAS logout itself works, but the redirect to Koha seems to be stuck in an "infinite loop". The page reloads again and again. It seems to work ok, when you craft an URL like: https://.../logout?url=https%3A%2F%2F...%2Fcgi-bin%2Fkoha%2Fopac-main.pl%3Flogout.x%3D1 without the logout.x%3D1 parameter at the end of the URL. Tested in Firefox ESR 45.7.0. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18045] Reserves.t can fail because of caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18045 Marcel de Rooychanged: What|Removed |Added Attachment #59858|0 |1 is obsolete|| --- Comment #2 from Marcel de Rooy --- Created attachment 59868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59868=edit Bug 18045: Fix Reserves.t tests - caching issues If the cache has to be cleaned when marc structure is updated. Before this patch, if the age restriction was not mapped, Reserves.t failed with: Tag "" is not a valid tag. at t/db_dependent/Reserves.t line 523. Test plan: Just confirm that the tests still pass and that the changes make sense. Signed-off-by: Marcel de Rooy It seems that only removing the key MarcSubfieldStructure- should be enough, but it does not hurt either to remove those four keys. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16984] Standing orders - when ordering a JS error is raised
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16984 Nick Clemenschanged: What|Removed |Added Attachment #58704|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 59867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59867=edit Bug 16984: Do not clone the item block for standing orders If AcqCreateItem is set to ordering and the basket is marked as "standing orders", when ordering a JS error is raised: additem.js:176 Uncaught TypeError: window[events[i]] is not a function The item block should not be displayed in that case. Test plan: - Set AcqCreateItem to "ordering" - Create a basket and tick the "Standing orders" checkbox - Add an order to this basket => Without this patch you get the JS error => With this patch applied you will not get it Signed-off-by: Claire Gravely Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16984] Standing orders - when ordering a JS error is raised
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16984 Nick Clemenschanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18045] Reserves.t can fail because of caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18045 Marcel de Rooychanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 Nick Clemenschanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/