[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #164 from Alex Buckley  ---
(in reply to Jonathan Druart in comment 161)

>To make thing clear: I did not want to obsolete the other patches because of 
>>the error, and I was a bit tired yesterday and the last patch does not 
>contain >any commit message.

Now that that error has kindly been resolved by Katrin and Liz's work on bug
17942 I will continue to test these three combined bug patches (17855, 18039
and 17942) and if successful I will obsolete the 10 previous patches for this
bug and amend the final commit message of this bug.

>If you agree with the plan, we can go with try to get 18039 first, then this 
>>one.
>But I have no idea how we can test 18039 widely and make sure it will not 
>>introduce any regressions.

To clarify do you mean try to get 18039 through testing and QA before this bug? 

>At the beginning of the onboarding tool, if I already have patron categories 
>and libraries, the steps 1 and 2 are skipped.
>But it's a bit weird, we do not understand what is going on.
>IIRC when I tested earlier, these steps contain message like "data already 
>>exists, click on next".

Yes I changed the way the steps for creating libraries, patron categories and
item types were displayed if the user had installed sample libraries, patron
categories and item types in the web installer due to your request in comment
70) so now the user is redirected to the next step that they do need to
complete.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18087] Clarification on File type when using file of biblionumbers to export data

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087

Claire Gravely  changed:

   What|Removed |Added

  Attachment #60120|0   |1
is obsolete||

--- Comment #6 from Claire Gravely  ---
Created attachment 60124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60124=edit
Bug 18087 - Clarification on File type when using file of biblionumbers to
export data

Added a line to the screen  detailing the types of files that can be used to
upload a list of biblionumbers.

Test plan:
1. Go to tools->export data
2. under File option,  (File types accepted: .csv and .txt)  should appear
3. Check both Bibliographic and Authority Export screens for this new string.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18098] Add an index with the count of available items

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18098] Add an index with the count of available items

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18098] Add an index with the count of available items

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18098] Add an index with the count of available items

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 60123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60123=edit
Bug 18098: Add an index with the count of available items

This patch adds a way to specify which MARC field contains the onloan
status and uses it to generate an XSLT that generates a new index for
Zebra called 'available'. This index contains the amount of items that
have an onloan status different than 1.

The idea is to change the way we build the query on the Perl side, and
just search for available > 0, taking advantage of DOM indexing
capabilities.

To test:
- Have a marcxml record containing holdings (952/995 depending on your
MARC flavour).
- Run:
  $ xsltproc \
  etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \
  your_record.marcxml
=> FAIL: There's no 'available' z:index.
- Apply the patch
- Run:
  $ xsltproc \
  etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \
  your_record.marcxml
=> SUCCESS: There's a  entry for 'available'
- Sign off :-D

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11450] Hold Request Confirm Deletion

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450

--- Comment #21 from Christopher Brannon  ---
Created attachment 60122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60122=edit
Screen shot of how this patch looks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11450] Hold Request Confirm Deletion

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450

--- Comment #20 from Christopher Brannon  ---
Well, it stood out to me.  I don't recall a lot, if any, of these alerts being
used.  If they are, I think we should consider phasing them out with modals. 
Like I mentioned earlier, the alert contains extra information that may be
confusing.  It isn't consistent, and I am probably overly picky about keeping
things consistent.  I've attached what I am seeing.  The alert just seems out
of place, and it is typical to use message boxes or modals in Koha with
particular fonts and colors to get attention.  This does not feel like part of
the software.  It feels more like a shortcut to be honest.

Again, I am very grateful for the functionality, but I think we should maintain
a more consistent look throughout Koha, and steer away from alerts whenever
possible.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17297] Give librarians the ability to add messages to an item

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297

Tomás Cohen Arazi  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18098

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18098] Add an index with the count of available items

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098

Tomás Cohen Arazi  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17297

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18098] Add an index with the count of available items

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098

--- Comment #1 from Tomás Cohen Arazi  ---
There should be an index including the amount of items that are available.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18098] New: Add an index with the count of available items

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098

Bug ID: 18098
   Summary: Add an index with the count of available items
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17940] Holds not going to waiting state after having been transferred

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #10 from Marcel de Rooy  ---
(In reply to David Roberts from comment #9)
> I know this has been signed off and passed QA, but in the patch attachment,
> shouldn't: 
> 
> reserve_id => $reserve->{reserve_id},
> 
> actually be:
> 
> reserve_id => $reserve->{'reserve_id'},
> 
> ?

Just the same. No problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18097] It is possible to create unusable category codes (ccode) due to field length mismatch

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18097

--- Comment #1 from Kyle M Hall  ---
Created attachment 60121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60121=edit
Bug 18097 - Update kohastructure.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18097] It is possible to create unusable category codes (ccode) due to field length mismatch

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18097

Kyle M Hall  changed:

   What|Removed |Added

   Severity|enhancement |major
   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18097] New: It is possible to create unusable category codes (ccode) due to field length mismatch

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18097

Bug ID: 18097
   Summary: It is possible to create unusable category codes
(ccode) due to field length mismatch
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

The column items.ccode is 10 characters long. It references authorised values
of the type CCODE. The maximum length of an authorised value is 80 characters
long. If a CCODE is created with a value greater than 10, when it is stored for
the item it will be truncated and become either a) an invalid ccode or b) match
a different ccode!

The solution should be to increase the items.ccode column from varchar(10) to
varchar(80).

This really goes for all columns that could possibly store an authorised value.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17940] Holds not going to waiting state after having been transferred

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940

David Roberts  changed:

   What|Removed |Added

 CC||david.roberts@ptfs-europe.c
   ||om

--- Comment #9 from David Roberts  ---
I know this has been signed off and passed QA, but in the patch attachment,
shouldn't: 

reserve_id => $reserve->{reserve_id},

actually be:

reserve_id => $reserve->{'reserve_id'},

?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18087] Clarification on File type when using file of biblionumbers to export data

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087

--- Comment #5 from Joy Nelson  ---
Hi Claire-
I've added the same text to the authority export string.  Take a look!

Thanks and great suggestions!
joy


(In reply to Claire Gravely from comment #3)
> wondering if we should then also have the same for authority records?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18087] Clarification on File type when using file of biblionumbers to export data

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087

Joy Nelson  changed:

   What|Removed |Added

  Attachment #60105|0   |1
is obsolete||

--- Comment #4 from Joy Nelson  ---
Created attachment 60120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60120=edit
Bug 18087 - Clarification on File type when using file of biblionumbers to
export data

Added a line to the screen  detailing the types of files that can be used to
upload a list of biblionumbers.

Test plan:
1. Go to tools->export data
2. under File option,  (File types accepted: .csv and .txt)  should appear
3. Check both Bibliographic and Authority Export screens for this new string.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18096] New: BnF Authorities Z39.50 search and access

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18096

Bug ID: 18096
   Summary: BnF Authorities Z39.50 search and access
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Z39.50 / SRU / OpenSearch Servers
  Assignee: gmcha...@gmail.com
  Reporter: synapse@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

The Bibliothèque nationale de France has launched a new Z39.50 platform on the
22nd of november 2016. It is now possible to retrieve the authority records as
well as every kind of bibliographical records.

The problem is that according to server profile
(http://www.bnf.fr/documents/profilZ3950_bnf_en.pdf) it is needed to use
attribute 2016 and 2017 to search for authority record. 
 • Search attributes are hardcoded in function Z3950SearchAuth in Breeding.pm
(and there is no attribute 2016 and 2017). 
 • BnF does not have SRU server (and even if it had, you can't add authority
SRU server to Koha right now). 
So the question is:

How to search BnF Authorities?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18095] Batch item modification: Better message if no item is modified

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18095

Marc Véron  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18095] Batch item modification: Better message if no item is modified

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18095

Marc Véron  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18095] Batch item modification: Better message if no item is modified

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18095

--- Comment #1 from Marc Véron  ---
Created attachment 60119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60119=edit
Bug 18095: Batch item modification: Better message if no item is modified

If no item is modified, the result page of Batch item modification says:
"item(s) modified (with fields modified)."
The message should be: "No items modified"

To reproduce:
- Go to Tools -> Batch item modification
- Put a barcode in and click Continue
- Do not make any changes and/or deselect all item(s)
- Click "Save"
=> Result message reads: "item(s) modified (with fields modified)."

To test:
- Apply patch
- Repeat steps above
- Verify that message makes sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18095] New: Batch item modification: Better message if no item is modified

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18095

Bug ID: 18095
   Summary: Batch item modification: Better message if no item is
modified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org

If no item is modified, the result page of Batch item modification says:
"item(s) modified (with fields modified)."
The message should be: "No items modified"

To reproduce: 
- Go to Tools -> Batch item modification
- Put a barcode in and click Continue
- Do not make any changes and/or deselect all item(s)
- Click "Save"
=> Result message reads: "item(s) modified (with fields modified)."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18041] Updating buttons in Batch Item Mod and Deletion

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18041

Marc Véron  changed:

   What|Removed |Added

  Attachment #59958|0   |1
is obsolete||

--- Comment #4 from Marc Véron  ---
Created attachment 60118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60118=edit
Bug 18041: Updating buttons in Batch Item modification and deletion

To test:
1) Go to Tools -> Batch item modification
2) Put a barcode in and click Continue (notice ugly button)
3) Scroll to the bottom of the page and click Save (you don't have to
make any changes) (Notice ugly button)
4) I am leaving the Return button as is
5) Go to Tools -> Batch item deletion
6) Put a barcode in and click Continue (notice ugly button)
7) Uncheck the selected item (so you don't actually delete anything) and
click Delete selected items (Notice ugly button)
8) I am leaving the Return button as is
9) Apply patch and repeat steps 1-8. Notice changes to buttons

Sponsored-by: Catalyst IT

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18041] Updating buttons in Batch Item Mod and Deletion

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18041

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7614] Branch transfer limit and holds

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Lari Taskula  changed:

   What|Removed |Added

 CC||lari.task...@jns.fi

--- Comment #3 from Lari Taskula  ---
I would like to work with this issue. I have prepared some stuff in other Bugs
that should make this one easier to solve, see Bug 7534 (let each library
define if they don't want to act as a pickup library) and Bug 18072 (easily
check branch transfer limitations for a specific item and biblio).

My proposal is that in this Bug we do the following:
1. Add branch transfer limits checks to CanBook/ItemBeReserved
2. Attempt to construct a "smarter" pickup location list that considers both 1.
library's configuration on being a pickup location, and 2. branch transfer
limits for that particular book

Dependencies:
Bug 7534
Bug 18072

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18094] New: Patron search filters are broken by searchable attributes

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094

Bug ID: 18094
   Summary: Patron search filters are broken by searchable
attributes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When using searchable patron attributes they seem to be added to all searches
as a contain

To recreate:
Add a new patron attrbute and mark it searchable
Populate a new patron with 'potato' in that field
Add/edit another patron to have email pot...@invalidemail.com'
Perform a patron search with filters 'Email' and 'Starts with' and query
'potato'
You will see both patrons in your results
Remove the potato email
Perform search again
You will be directed to the patron containing the potato attribute

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18043] Updating buttons for z39.50 cataloguing search

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||ve...@veron.ch

--- Comment #4 from Marc Véron  ---
Buttons display as expected, but "Go to page" is broken.
Reason: Button "Go" definition misses: value="Go"
If I add it (line 212), "Go to page" works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

--- Comment #12 from Lari Taskula  ---
Created attachment 60117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60117=edit
Bug 18072: Add Koha::Biblio->can_be_transferred

This patch adds a new method Koha::Biblio->can_be_transferred. The method
checks
if at least one of the item of that biblio can be transferred to desired
location.

This method will be useful for building a smarter pickup location list for
holds,
because we will be able to hide those libraries to which none of the items of
this biblio can be transferred to due to branch transfer limits (see Bug 7614).

To test:
1. prove t/db_dependent/Koha/Biblios.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

--- Comment #11 from Lari Taskula  ---
Created attachment 60116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60116=edit
Bug 18072: (QA-follow-up) let Koha::Item->can_be_transferred take HASHref as
param

This patch changes Koha::Item->can_be_transferred to accept a HASHref as
follows:
$item->can_be_transferred({ to => $library, from => $library2 })

To test:
1. prove t/db_dependent/Koha/Items.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

Lari Taskula  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18093] Add the Koha::Objects->get_column method

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18093] Add the Koha::Objects->get_column method

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093

Marc Véron  changed:

   What|Removed |Added

  Attachment #60104|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 60115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60115=edit
Bug 18093: Add Koha::Objects->get_column

Test plan:
  prove t/db_dependent/Koha/Objects.t
Should return green

Followed test plan, result as expected
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11450] Hold Request Confirm Deletion

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450

--- Comment #19 from Owen Leonard  ---
(In reply to Christopher Brannon from comment #16)

> a generic alert window is being used
> instead of a modal confirmation.  It has been standard for confirmations to
> be done through modal.

This is not true. Simple deletion confirmations are most often done via a
JavaScript alert(). Some deletions, for instance in Administration, take the
user to a separate page which displays a '' and asks
for confirmation there. But these are not the norm.

I don't think any follow-up is required.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16749] Additional fixes for debian scripts

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60113|0   |1
is obsolete||

--- Comment #27 from Marcel de Rooy  ---
Created attachment 60114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60114=edit
Bug 16749: Adjustments for koha-translate

[1] Add a -d|--dev parameter for dev installs.
[2] KOHA_CONF is not needed in this script.
[3] No hardcoded PERL5LIB, following bug 16733.
[4] Adjust template paths for dev installs: OPAC_TMPL, INTRANET_TMPL.
[5] Remove reference now to obsolete thems ccsr and prog.

Test plan:
[1] Regular package install:
Run koha-translate -l to show installed languages.
Run koha-translate -l -a to show available languages.
Add a language: koha-translate -i nl-NL. Check the nl-NL folder.
Remove a language: koha-translate -r nl-NL. Check again.
[2] If you have a dev install too, try:
Add the  line to koha-conf.xml. (See 16733.)
Run koha-translate -l -d yourinstance to show installed languages.
(Note: You only see the languages installed in that instance.)
Add a language: koha-translate -i nl-NL -d yourinstance.
Remove a language: koha-translate -r nl-NL -d yourinstance.

Signed-off-by: Marcel de Rooy 

EDIT (Feb 10, 2017):
Fixed a typ PERL5DIR. Decided to not pass KOHA_CONF after all.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16749] Additional fixes for debian scripts

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749

--- Comment #26 from Marcel de Rooy  ---
PERL5DIR typo ??

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16749] Additional fixes for debian scripts

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #52561|0   |1
is obsolete||

--- Comment #25 from Marcel de Rooy  ---
Created attachment 60113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60113=edit
Bug 16749: Adjustments for koha-translate

[1] Add a -d|--dev parameter for dev installs.
[2] KOHA_CONF is not needed in this script.
[3] No hardcoded PERL5LIB, following bug 16733.
[4] Adjust template paths for dev installs: OPAC_TMPL, INTRANET_TMPL.
[5] Remove reference now to obsolete thems ccsr and prog.

Test plan:
[1] Regular package install:
Run koha-translate -l to show installed languages.
Run koha-translate -l -a to show available languages.
Add a language: koha-translate -i nl-NL. Check the nl-NL folder.
Remove a language: koha-translate -r nl-NL. Check again.
[2] If you have a dev install too, try:
Add the  line to koha-conf.xml. (See 16733.)
Run koha-translate -l -d yourinstance to show installed languages.
(Note: You only see the languages installed in that instance.)
Add a language: koha-translate -i nl-NL -d yourinstance.
Remove a language: koha-translate -r nl-NL -d yourinstance.

Signed-off-by: Marcel de Rooy 

EDIT (Feb 10, 2017):
Added KOHA_CONF variable when calling translate. (Needed on kohadevbox.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16749] Additional fixes for debian scripts

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60110|0   |1
is obsolete||

--- Comment #24 from Marcel de Rooy  ---
Created attachment 60112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60112=edit
Bug 16749: Adjustments for koha-plack

[1] Use run_safe_xmlstarlet for plack workers and requests
[2] Simplify adjust_paths. The lazy export statement is actually enough to
replace adjust_paths by one direct call to adjust_paths_dev_install.

Test plan:
[1] See patch for adjusting xmlstarlet calls.
[2] Change plack_requests to 51 in your koha-conf. Restart Plack and
check that you see 51 in ps aux|grep plack.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16749] Additional fixes for debian scripts

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60109|0   |1
is obsolete||

--- Comment #23 from Marcel de Rooy  ---
Created attachment 60111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60111=edit
Bug 16749: Adjust xmlstarlet calls in koha-functions

In various scripts we use xmlstarlet to extract values from koha-conf.
If we call xmlstarlet on non-existing entries in koha-conf, this may
however result in silently failing scripts.
A function run_safe_xmlstarlet is added for situations where the entry
might not be there. No need to use it everywhere rightaway.

This patch only adjusts koha-functions and modifies the xmlstarlet calls
for dev_install and zebra_loglevels.

Test plan:
[1] Apply the patch for koha-plack too.
[2] Copy koha-functions.sh and koha-plack from clone to default locations.
[3] Start and stop koha-plack while you have dev_install in koha-conf.
Verify with ps aux|grep plack.
[4] Rename dev_install to nodev_install and start/stop koha-plack.
Verify with ps aux|grep plack.

Signed-off-by: Marcel de Rooy 
Tested on a Debian VM and with a Windows kohadevbox :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18085] Elasticsearch ids are not being stored correctly

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18085

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #3 from Nick Clemens  ---
Nvm - this is a kohadevbox issue - version of Catmandu installed is not the
.deb from bug 17255

was using version 3.03 - need .5 or greater

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16749] Additional fixes for debian scripts

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60103|0   |1
is obsolete||

--- Comment #21 from Marcel de Rooy  ---
Created attachment 60109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60109=edit
Bug 16749: Adjust xmlstarlet calls in koha-functions

In various scripts we use xmlstarlet to extract values from koha-conf.
If we call xmlstarlet on non-existing entries in koha-conf, this may
however result in silently failing scripts.
A function run_safe_xmlstarlet is added for situations where the entry
might not be there. No need to use it everywhere rightaway.

This patch only adjusts koha-functions and modifies the xmlstarlet calls
for dev_install and zebra_loglevels.

Test plan:
[1] Apply the patch for koha-plack too.
[2] Copy koha-functions.sh and koha-plack from clone to default locations.
[3] Start and stop koha-plack while you have dev_install in koha-conf.
Verify with ps aux|grep plack.
[4] Rename dev_install to nodev_install and start/stop koha-plack.
Verify with ps aux|grep plack.

Signed-off-by: Marcel de Rooy 
Tested on a Debian VM and with a Windows kohadevbox :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16749] Additional fixes for debian scripts

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60106|0   |1
is obsolete||

--- Comment #22 from Marcel de Rooy  ---
Created attachment 60110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60110=edit
Bug 16749: Adjustments for koha-plack

[1] Use run_safe_xmlstarlet for plack workers and requests
[2] Simplify adjust_paths. The lazy export statement is actually enough to
replace adjust_paths by one direct call to adjust_paths_dev_install.

Test plan:
[1] See patch for adjusting xmlstarlet calls.
[2] Change plack_requests to 51 in your koha-conf. Restart Plack and
check that you see 51 in ps aux|grep plack.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18025] Expired password recovery links cause sql crash

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18025] Expired password recovery links cause sql crash

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025

Marc Véron  changed:

   What|Removed |Added

  Attachment #59760|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 60108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60108=edit
Bug 18025 - Expired password recovery links cause sql crash

When a user gets an email, but doesn't act or visit it within two days,
 attempting to create a new one causes a collision. We should just
 delete the old one, assuming they still want to reset their
 password.

To test:
create yourself a borrower with a userid and password.
Attempt a password recovery on the OPAC
update the entry in the database for that user to have an expired token
e.g. update borrower_password_recovery set valid_until = '2017-01-25
03:25:26' where borrowernumber = 12;
Attempt another password recovery operation - should error
apply the patch
Try it again - no error, new token is generated and additional email
with new link is sent.

Issue reproduced without patch; resolved with patch.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16749] Additional fixes for debian scripts

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60064|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16749] Additional fixes for debian scripts

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749

--- Comment #20 from Marcel de Rooy  ---
Comment on attachment 60064
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60064
Bug 17049: Improve PERL5LIB handling for packaged dev install

Obsoleting this theoretical approach

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18077] Batch item modification link is bold when batch item deletion is active in tools menu

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18077

Marc Véron  changed:

   What|Removed |Added

  Attachment #60001|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 60107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60107=edit
Bug 18077: Batch item modification link is bold when batch item deletion is
active in tools menu

To test:
1) Go to Tools -> Batch item deletion
2) Notice the link for Batch item MODIFICATION is bold, not the deletion
link
3) Apply patch and refresh page
4) Correct link should now be bold.
5) Go to batch item modification and confirm the correct link is bold

Sponsored-by: Catalyst IT

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18077] Batch item modification link is bold when batch item deletion is active in tools menu

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18077

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16749] Additional fixes for debian scripts

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749

--- Comment #19 from Marcel de Rooy  ---
Created attachment 60106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60106=edit
Bug 16749: Adjustments for koha-plack

[1] Use run_safe_xmlstarlet for plack workers and requests
[2] Simplify adjust_paths

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18087] Clarification on File type when using file of biblionumbers to export data

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087

Claire Gravely  changed:

   What|Removed |Added

 CC||claire_grav...@hotmail.com

--- Comment #3 from Claire Gravely  ---
wondering if we should then also have the same for authority records?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18087] Clarification on File type when using file of biblionumbers to export data

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087

Claire Gravely  changed:

   What|Removed |Added

  Attachment #60094|0   |1
is obsolete||

--- Comment #2 from Claire Gravely  ---
Created attachment 60105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60105=edit
Bug 18087 - Clarification on File type when using file of biblionumbers to
export data

Added a line to the screen  detailing the types of files that can be used to
upload a list of biblionumbers.

Test plan:
1. Go to tools->export data
2. under File option,  (File types accepted: .csv and .txt)  should appear

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18087] Clarification on File type when using file of biblionumbers to export data

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18085] Elasticsearch ids are not being stored correctly

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18085

--- Comment #2 from Olli-Antti Kivilahti  ---
Sorry. Busy.
I (or somebody in Koha-Suomi) will solve the ES issues when we decide to go to
ES.

Can't tell from the top of my hat, where the problem is. Sounds like something
to do with interfacing via Catmandu. Catmandu needs some special care to handle
_id properly. Maybe the issue is with one of the multiple Catmandu modules
needed to get the MARC::Record to ES.

Do we really need Catmandu at this phase? We can directly index to ES, or any
search engine because Koha already has the infrastucture to facilitate multiple
search engines.
Now we need to wait for the Catmandu-guys to port
Catmandu::Store::ElasticSearch to 5.2 or supply a patch (if the problem is in
Catmandu)

Also We need to implement Catmandu in the JavaScript-side if we want to consume
the results directly to the browser. We would have to implement any parser
there though.
AJAX-searches would be nice!

I guess Catmandu defines some kind of a "standard" for working with library
data, but so does MARCXML.
Turning MARCXML to JSON is really simple.
Or even better... JSON-LD!!


But this is not an answer to the bug at hand :)


My bet is Catmandu. Giving it the right parameters to handle _id.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18093] Add the Koha::Objects->get_column method

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093

--- Comment #1 from Jonathan Druart  
---
Created attachment 60104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60104=edit
Bug 18093: Add Koha::Objects->get_column

Test plan:
  prove t/db_dependent/Koha/Objects.t
Should return green

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18093] Add the Koha::Objects->get_column method

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18093] New: Add the Koha::Objects->get_column method

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093

Bug ID: 18093
   Summary: Add the Koha::Objects->get_column method
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18081] New EU General Data Protection Regulation 2018

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16749] Additional fixes for debian scripts

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749

--- Comment #18 from Marcel de Rooy  ---
Created attachment 60103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60103=edit
Bug 16749: Adjust xmlstarlet calls in koha-functions

WORK_IN_PROGRESS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #163 from Jonathan Druart  
---
With fr-FR, I do not see the "select all data" link on "Selecting Default
Settings"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #162 from Jonathan Druart  
---
At the beginning of the onboarding tool, if I already have patron categories
and libraries, the steps 1 and 2 are skipped.
But it's a bit weird, we do not understand what is going on.
IIRC when I tested earlier, these steps contain message like "data already
exists, click on next".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18085] Elasticsearch ids are not being stored correctly

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18085

--- Comment #1 from Jonathan Druart  
---
Olli, any chances you can try and fix this one?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages

2017-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039

--- Comment #15 from Jonathan Druart  
---
To generate these patches I have used the move_installer_files.pl script (from
the last patch).
We now need to make sure all files have been correctly move for the different
languages.
Everything looks ok so far to me, unless ru-RU and uk-UA, that are not really
maintained.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/