[Koha-bugs] [Bug 18070] Support clean removal of authority records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||9988


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988
[Bug 9988] Leave larger authority merges to merge_authority cronjob (pref
AuthorityMergeLimit)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||18070


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070
[Bug 18070] Support clean removal of authority records
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17731] Remove the noxml option from rebuild_zebra.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #11 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16749] Additional fixes for debian scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749

--- Comment #40 from Mirko Tietgen  ---
I did not copy anything, I built a Debian package, so everything is in place
already. I edited the correct instance koha-conf file.

According to bug 17610 it is plack_max_requests, not plack_requests. I will try
that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960

--- Comment #25 from Katrin Fischer  ---
Was wondering - why not have a database update fix this automatically? Should
only be a find kind of thing?
)

NOTICE - If you are using opac_news.new in your notice templates, you should
update it to opac_news.content

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18108] Sorting by author in opac summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18108

M. Tompsett  changed:

   What|Removed |Added

  Attachment #60169|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 60173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60173=edit
[SIGNED-OFF] Bug 18108: Sorting by author in opac summary

To test:
1) Log into OPAC, go to your summary
2) Notice 'author' is in Title column, therefore unable to sort by
author
3) Apply patch and refresh page
4) Notice author has now been moved into Author column
5) Confirm sorting by author works as expected and sorting of all other
columns works as expected

Sponsored-by: Catalyst IT

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18108] Sorting by author in opac summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18108

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12341] Untranslatable strings in file-upload.inc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12341

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 CC||aleishaamo...@hotmail.com

--- Comment #1 from Aleisha Amohia  ---
I don't believe this is valid - Upload fail messages have been moved into
tools/upload.tt and seem to be translatable. Setting to Resolved

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18109] Uncertain prices has no font awesome icon in acquisitions toolbar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18109

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18109] Uncertain prices has no font awesome icon in acquisitions toolbar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18109

--- Comment #1 from Aleisha Amohia  ---
Created attachment 60172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60172=edit
Bug 18109: Adding font awesome icon to uncertain prices button

To test:
1) Go to Acquisitions -> search for a vendor
2) View a basket with uncertain prices or add an order with uncertain
prices to a basket
3) Confirm that font awesome icon is appropriate and button still works
as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18109] New: Uncertain prices has no font awesome icon in acquisitions toolbar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18109

Bug ID: 18109
   Summary: Uncertain prices has no font awesome icon in
acquisitions toolbar
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 60171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60171=edit
toolbar

Uncertain prices is the only button with no icon. Looks a bit plain

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4971] Planning types not translatable in acq

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4971

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com

--- Comment #2 from Aleisha Amohia  ---
Is this still valid?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8548] Add callnumber sort option to overdue report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8548

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com
   Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com
   |ity.org |
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8548] Add callnumber sort option to overdue report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8548

--- Comment #3 from Aleisha Amohia  ---
Created attachment 60170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60170=edit
Bug 8548: Add datatable to circ overdue report, remove sortby filter

This patch adds a datatable to the circ overdue report. Since the
datatable makes sorting easy, I've also removed the sort by filter on
the side.

To test:
1) Go to Circulation -> Overdues
2) Notice overdues report shows as datatable
3) Confirm sorting on all columns works
4) Test the Filters and confirm they all still work as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8548] Add callnumber sort option to overdue report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8548

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13685] Sorting Patron Reading History

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13685

--- Comment #11 from Aleisha Amohia  ---
(In reply to M. Tompsett from comment #9)
> Might I also recommend doing the same kind of split for the summary page
> too? Not that affects this bug, but it might be another one to think about.

Have implemented this fix in bug 18108

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18108] Sorting by author in opac summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18108

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |aleishaamo...@hotmail.com
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18108] Sorting by author in opac summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18108

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18108] Sorting by author in opac summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18108

--- Comment #1 from Aleisha Amohia  ---
Created attachment 60169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60169=edit
Bug 18108: Sorting by author in opac summary

To test:
1) Log into OPAC, go to your summary
2) Notice 'author' is in Title column, therefore unable to sort by
author
3) Apply patch and refresh page
4) Notice author has now been moved into Author column
5) Confirm sorting by author works as expected and sorting of all other
columns works as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18108] New: Sorting by author in opac summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18108

Bug ID: 18108
   Summary: Sorting by author in opac summary
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

similar fix desired from bug 13685, comment 9

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14854] Add DataTables on upload results table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14854

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com
  Change sponsored?|--- |Sponsored
   Assignee|gmcha...@gmail.com  |aleishaamo...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14854] Add DataTables on upload results table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14854

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14854] Add DataTables on upload results table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14854

--- Comment #3 from Aleisha Amohia  ---
Created attachment 60168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60168=edit
Bug 14854: Add DataTables on upload results table

This patch adds datatables to the upload results table.
Tools -> Upload

To test:
1) Go to Tolls -> Upload
2) Put any search term in search box, click Search
3) Confirm table shows as datatable and sorting works on all columns
EXCEPT Actions

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC||a...@hanover.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10086] No way to go back to the basket after correcting uncertain prices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086

--- Comment #2 from Aleisha Amohia  ---
Created attachment 60167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60167=edit
Bug 10086: Link to go to basket from uncertain prices page

This patch moves the Edit button into an Edit column, styled with
bootstrap button and font awesome icon, and adds a link on the basket
name to go to the basket.

To test;
1) Add an item with uncertain prices to a basket
2) Go to the vendor of the basket
3) Click Uncertain prices on the left
4) Notice 'edit' button does not look like a button, and basket name is
not a link
5) Apply patch and refresh page
6) Basket name is now a link. Click to confirm it takes you to the right
page
7) Edit button is now in edit column. Confirm it works as expected
8) Confirm you cannot sort on Edit column and the button does not wrap
on a narrower browser

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10086] No way to go back to the basket on uncertain prices page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com
   |ity.org |
Summary|No way to go back to the|No way to go back to the
   |basket after correcting |basket on uncertain prices
   |uncertain prices|page

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18106] Batch-update bibliographic records when authorities are modified

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18106

--- Comment #11 from Katrin Fischer  ---
Claudio, from the glances I took at the code, it looks differently to me. But
you can also ask on the mailing list - someone there might be using the
non-automatic verson of dontmerge.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10086] No way to go back to the basket after correcting uncertain prices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10086] No way to go back to the basket after correcting uncertain prices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com

--- Comment #1 from Aleisha Amohia  ---
When I click Edit for an order line with uncertain prices, clicking Save and
Cancel both take me back to the basket, and the breadcrumbs at the top of the
page have a link back to the basket. So i think this bug is no longer valid.

However, there should be a link from the uncertain prices page to the basket.
So (I hope you don't mind Mathieu) I am just going to adapt this bug to that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9176] Save buttons in syspref editor are not disabled after saving sysprefs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9176

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 CC||aleishaamo...@hotmail.com

--- Comment #7 from Aleisha Amohia  ---
This has been fixed in the latest version. Setting to Resolved

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18106] Batch-update bibliographic records when authorities are modified

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18106

--- Comment #10 from Claudio  ---
The merge_authority.pl cronjob is not for upgrading bibliographic records, but
to merge authority ones. It seems there's no way to batch-update bibliographic
records when an authority one is modified...

Thanks anyway Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2326] Help should be diff for each of the sys pref tabs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2326

--- Comment #3 from Aleisha Amohia  ---
Created attachment 60166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60166=edit
Bug 2326: Individual help pages for every tab in system preferences

To test:
1) Apply patch
2) Confirm that when not on any particular tab, the general help shows
as usual
3) Confirm that when on a specific tab, the help that shows up is
correct
4) Confirm that all links in the help file work correctly
5) Confirm this works for every tab

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2326] Help should be diff for each of the sys pref tabs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2326

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2326] Help should be diff for each of the sys pref tabs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2326

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Large patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18106] Batch-update bibliographic records when authorities are modified

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18106

--- Comment #9 from Katrin Fischer  ---
Hm, found ModAuthority should be adding to the table:
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/AuthoritiesMarc.pm;hb=2f64fd3918a205ac21630657160f61200c791320#l727

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18106] Batch-update bibliographic records when authorities are modified

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18106

--- Comment #8 from Katrin Fischer  ---
I think it might be able to run it manually and without options to use the
table. I don't fully understand the script. But there is a note:

42 All biblios with the authority in -t will be modified to be "connected" to
authority -f

The change in the bilbiographic records could not happen in the script itself,
but in one of the routines it calls. Hard to tell without further
investigation.  I won't be able to look deeper into this.

Maybe check if changing an authority heading creates an entry in the table for
a start.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18106] Batch-update bibliographic records when authorities are modified

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18106

--- Comment #7 from Claudio  ---
By the way, dontmerge syspref is set to don't merge

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18106] Batch-update bibliographic records when authorities are modified

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18106

--- Comment #6 from Claudio  ---
Created attachment 60165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60165=edit
.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18106] Batch-update bibliographic records when authorities are modified

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18106

--- Comment #5 from Claudio  ---
merge_authority.pl works merging two authority records. It does not update
bibliographic records from an authority record recently modified. For example,
we have an authority record linked to 1000 bibliographic records. If we modify
the authority record and then run merge_authority.pl it fails. See file
attached.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18107] Articles about SIP2 and LDAP for the Koha manual

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18107

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18106] Batch-update bibliographic records when authorities are modified

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18106

--- Comment #4 from Katrin Fischer  ---
Btw. this would be a better type of question for the mailing list, where lots
more people read you and should not be a bug possibly at this state.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18106] Batch-update bibliographic records when authorities are modified

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18106

--- Comment #3 from Katrin Fischer  ---
We haven't used it so far - only the automatic way. But I think it takes
information about what records to update from the need_merge_authorities table
in the database usually.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18106] Batch-update bibliographic records when authorities are modified

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18106

--- Comment #2 from Claudio  ---
Katrin, happy to read you.

I want to use merge_authority.pl cronjob (because a performance issue) but it
does not work as the manual or the syspref explain it. Would you please send me
an example? I want to modified ALL bibliographic records in a batch mode. Which
parameters must I add to merge_authority.pl? Because it asks for two...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18106] Batch-update bibliographic records when authorities are modified

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18106

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
I think that is exactly what dontmerge does - unless you modified it outside of
Koha? 

dontmerge: [Do|Don't] automatically update attached biblios when changing an
authority record. If this is off, please ask your administrator to enable the
merge_authority.pl cronjob. 

The merge_authority.pl cronjob will be used if you don't want to do it
immediately after changing the record (could be a performance hit I guess)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18107] Articles about SIP2 and LDAP for the Koha manual

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18107

Alex Buckley  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18107] New: Articles about SIP2 and LDAP for the Koha manual

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18107

Bug ID: 18107
   Summary: Articles about SIP2 and LDAP for the Koha manual
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Documentation
  Assignee: alexbuck...@catalyst.net.nz
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

This bug has attached to it patches documenting how to set up and use SIP2 and
LDAP with Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18106] New: Batch-update bibliographic records when authorities are modified

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18106

Bug ID: 18106
   Summary: Batch-update bibliographic records when authorities
are modified
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: MARC Authority data support
  Assignee: gmcha...@gmail.com
  Reporter: cost...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Is there a way to batch-update bibliographic records when an authority record
is modified? I mean with a cronjob (I guess dontmerge syspref is not the
correct way)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

Andreas Hedström Mace  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18105] Should we restart koha-indexer differently i.e. like koha-plack?

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18105

Marcel de Rooy  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18105] New: Should we restart koha-indexer differently i.e. like koha-plack?

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18105

Bug ID: 18105
   Summary: Should we restart koha-indexer differently i.e. like
koha-plack?
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: mi...@abunchofthings.net

Koha-indexer uses a daemon --restart:
A daemon restart does not really stop and start; the client processes are
terminated, but the named daemon itself is not. Changed options are not taken
into account.

Same for koha-restart-zebra btw.

Koha-plack implements its restart by doing a daemon --stop and daemon --start.
This makes that changed options are taken into account.

If you know how this work, no problem. But it is not consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16749] Additional fixes for debian scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749

--- Comment #39 from Marcel de Rooy  ---
(In reply to Mirko Tietgen from comment #38)
> I have tested patch 3 and 4 in a regular package installation of master+all
> patches from this bug and they work. I can also confirm that the postinst
> issue is gone with this patch set.
> 
> i tried plack_requests from the test plan in patch 2 in koha-conf.xml but it
> did not have any effect in the regular installation. I may be missing a
> parameter or it is not applicable for a regular install?

Thanks for testing.

Should work on a regular instance too.
Just to be sure: Master up-to-date including 17610? Did you copy the debian
scripts from the master clone to /usr/sbin? And koha-functions.sh to
/usr/share/koha/bin? And did you edit the koha-conf of the instance for which
you are restarting plack? This setting is instance specific.

You should see something like (52 coming from my koha-conf):
master-+ 28433  0.0  0.1  61320 14636 ?Ss   18:57   0:00 starman master
-M FindBin --max-requests 52 --workers 2 --user=master-koha --group master-koha
--pid /var/run/koha/master/plack.pid --daemonize --access-log
/var/log/koha/master/plack.log --error-log /var/log/koha/master/plack-error.log
-E deployment --socket /var/run/koha/master/plack.sock /etc/koha/plack.psgi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15678] Make pickup branch editable on holds tab on circulation/ patron detail screens

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15678

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk
Version|3.22|unspecified

--- Comment #1 from Sally Healey  
---
This is valid on master, not just 3.22.

Trying to update the branch via the Holds tab in Patron details returns a
dialogue of:  There was an error:  error Method Not Allowed

It would be useful if the value could be edited.  If it can't be edited, it
should be text, and not a drop down menu.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14578] Allow merging of records upon import match

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14578] Allow merging of records upon import match

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #53596|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall  ---
Created attachment 60164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60164=edit
Bug 14578: Allow manual merging of import records on match

Test plan:
 1) Ensure that normal record merging still correctly functions.
 2) Import a record that matches an existing record (exporting an
existing record and reimporting it is an easy way to test this).
 3) On the manage import batch page, there should now be a link to
Merge.
 4) Clicking this and going through the merge process should leave both
records in place but update the import record.

Sponsored-by: Rutgers School of Law

Signed-off-by: Kyle M Hall 
Signed-off-by: Heather Mitchell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18099] Put call number in its own column on inventory screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18099

Claire Gravely  changed:

   What|Removed |Added

  Attachment #60136|0   |1
is obsolete||

--- Comment #2 from Claire Gravely  ---
Created attachment 60163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60163=edit
Bug 18099 - Put call number in its own column on inventory screen

TEST PLAN

0) Apply patch

1) Create an item with a call number in 952$o (e.g. ABC 123)
2) Using the inventory tool, make sure you "Select items you want to check"
which include that item (e.g. Item callnumber between: A and C)
3) Click "Submit"
4) The call number appears in the column marked "Call number"
instead of appearing as [ABC 123] under the library in the
"Library" column

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18099] Put call number in its own column on inventory screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18099

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

 Blocks||18103


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18103
[Bug 18103] REST API: Add endpoint for patron status / blocks
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18103] REST API: Add endpoint for patron status / blocks

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18103

Lari Taskula  changed:

   What|Removed |Added

 Depends on||16826


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826
[Bug 16826] REST API: Add API routes for getting item availability and
holdability
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18103] REST API: Add endpoint for patron status / blocks

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18103

--- Comment #6 from Lari Taskula  ---
Corrected invalid Bug number.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18103] REST API: Add endpoint for patron status / blocks

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18103

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60159|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18103] REST API: Add endpoint for patron status / blocks

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18103

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60160|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18103] REST API: Add endpoint for patron status / blocks

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18103

--- Comment #5 from Lari Taskula  ---
Created attachment 60162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60162=edit
Bug 18103: Add patronstatus operation to controller

This patch adds patronstatus operation to Koha::REST::V1::Patron.

Also adds new method Koha::Patron->status_not_ok that returns an array of
Koha::Exceptions if there are some issues with patron status.

To test:
1. prove t/db_dependent/Koha/Patrons.t
2. prove t/db_dependent/api/v1/patrons.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18103] REST API: Add endpoint for patron status / blocks

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18103

--- Comment #4 from Lari Taskula  ---
Created attachment 60161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60161=edit
Bug 18103: Add patronstatus to Swagger

This patch adds the Swagger definition for patronstatus.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18103] REST API: Add endpoint for patron status / blocks

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18103

--- Comment #3 from Lari Taskula  ---
Tests are still failing due to data type changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18103] REST API: Add endpoint for patron status / blocks

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18103

--- Comment #2 from Lari Taskula  ---
Created attachment 60160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60160=edit
Bug 18013: Add patronstatus operation to controller

This patch adds patronstatus operation to Koha::REST::V1::Patron.

Also adds new method Koha::Patron->status_not_ok that returns an array of
Koha::Exceptions if there are some issues with patron status.

To test:
1. prove t/db_dependent/Koha/Patrons.t
2. prove t/db_dependent/api/v1/patrons.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18103] REST API: Add endpoint for patron status / blocks

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18103

--- Comment #1 from Lari Taskula  ---
Created attachment 60159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60159=edit
Bug 18013: Add patronstatus to Swagger

This patch adds the Swagger definition for patronstatus.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8010] Search history can be added to the wrong patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010

--- Comment #6 from Baptiste  ---
Created attachment 60158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60158=edit
Added a new syspref to Load history to the next user

Added a syspref LoadHistory addSearchHistoryToTheFirstLoggedUser to select if
you want the system to add the history of searches performed without session
when you log in as registered user.
TEST PLAN
1 - Search in the catalogue, check you are not logged
2 - Log in : your last history should appear
4 - Log out
5 - Apply the patch
6 - Repeat 1 and 2
7 - Desactivate the syspref addSearchHistoryToTheFirstLoggedUser
8 - Repeat 1 and 2 : your last history shouldn't appear

The Unit test doesn't rollback but delete the added lines : the function
get_template_and_user allway sets the autocommit to 1.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Johnny Rotten  changed:

   What|Removed |Added

 CC||geo...@nekls.org,
   ||geor...@latahlibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16749] Additional fixes for debian scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749

--- Comment #38 from Mirko Tietgen  ---
I have tested patch 3 and 4 in a regular package installation of master+all
patches from this bug and they work. I can also confirm that the postinst issue
is gone with this patch set.

i tried plack_requests from the test plan in patch 2 in koha-conf.xml but it
did not have any effect in the regular installation. I may be missing a
parameter or it is not applicable for a regular install?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2985] Link patron renewal to patron category age restrictions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2985

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

--- Comment #2 from Sally Healey  
---
This is still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16749] Additional fixes for debian scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749

--- Comment #37 from Mirko Tietgen  ---
This patch set appears to fix the koha-common.postinst error presumably
introduced in bug 16733.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16755] allow SIP2 field DA ( hold patron name ) to be customized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16755

Kyle M Hall  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18104

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18104] allow SIP2 field AE (personal name ) to be customized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18104

Kyle M Hall  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16755

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18104] allow SIP2 field AE (personal name ) to be customized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18104

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18104] New: allow SIP2 field AE (personal name ) to be customized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18104

Bug ID: 18104
   Summary: allow SIP2 field AE (personal name ) to be customized
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

Koha's SIP2 server sends the patron's name in the format "Firstname Surname"
which is not very good for machine reading. We need to allow the format of the
patron name to be customized in a manner similar to what is done with the DA
field on bug 16755.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15399] MARCXML records larger than 1 MB (1048576 bytes) are not searchable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399

--- Comment #8 from Barton Chittenden  ---
It turns out that the 1024 K limit is the default max record size in zebrasrv;
this can be changed using the -k option to zebrasrv.

man zebrasrv shows:

-k size
   Maximum record size/message size, in kilobytes. Default is 1024 KB (1 MB).

This could be increased in koha-start-zebra, koha-restart-zebra and koha-zebra.
I imagine the change would look something like this:

from

zebrasrv \
-v $loglevels \
-f "/etc/koha/sites/$instancename/koha-conf.xml" && \
return 0 || \
return 1

to

zebrasrv \
-v $loglevels \
-k $max_record_size
-f "/etc/koha/sites/$instancename/koha-conf.xml" && \
return 0 || \
return 1

where $max_record_size would be read from $KOHA_CONF in the same manner that
$loglevels is.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

--- Comment #38 from Marcel de Rooy  ---
(In reply to Andreas Hedström Mace from comment #37)
> Tested and everything works as intended, except that it is not possible to
> cancel holds with the cronjob in
> misc/cronjobs/holds/cancel_expired_holds.pl, and thus not possible to set a
> cancelation fee.
> 
> However, with the ExpireReservesOnHolidays syspref set to allow, and without
> ExcludeHolidaysFromMaxPickUpDelay (set to don’t allow), the hold is
> cancelled and sets the fee. 
> 
> I don't think this is the desired behaviour (one might want to exclude
> holidays but still apply a fee for those who doesn’t pick up a reserved
> book), so I'm setting this to patch doesn't apply.
> 
> If someone disagrees, feel free to change the status.

Sounds like a Failed QA.
Patch doesnt apply is meant for patches needing a rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

Andreas Hedström Mace  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #37 from Andreas Hedström Mace  ---
Tested and everything works as intended, except that it is not possible to
cancel holds with the cronjob in misc/cronjobs/holds/cancel_expired_holds.pl,
and thus not possible to set a cancelation fee.

However, with the ExpireReservesOnHolidays syspref set to allow, and without
ExcludeHolidaysFromMaxPickUpDelay (set to don’t allow), the hold is cancelled
and sets the fee. 

I don't think this is the desired behaviour (one might want to exclude holidays
but still apply a fee for those who doesn’t pick up a reserved book), so I'm
setting this to patch doesn't apply.

If someone disagrees, feel free to change the status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733

--- Comment #38 from Marcel de Rooy  ---
(In reply to Mirko Tietgen from comment #37)
> Looks like this breaks koha-common.postinst. Do not push to *stable. Thanks.
Enhancement :) Not for backporting. Note that bug 16749 should follow it. First
two patches may solve your problem..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733

--- Comment #37 from Mirko Tietgen  ---
Looks like this breaks koha-common.postinst. Do not push to *stable. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

Lari Taskula  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lari.task...@jns.fi
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18103] REST API: Add endpoint for patron status / blocks

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18103

Lari Taskula  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lari.task...@jns.fi
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18103] REST API: Add endpoint for patron status / blocks

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18103

Lari Taskula  changed:

   What|Removed |Added

   Assignee|wizzy...@gmail.com  |koha-b...@lists.koha-commun
   ||ity.org
  Component|Websites, Mailing Lists,|Web services
   |etc |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18103] New: REST API: Add endpoint for patron status / blocks

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18103

Bug ID: 18103
   Summary: REST API: Add endpoint for patron status / blocks
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Websites, Mailing Lists, etc
  Assignee: wizzy...@gmail.com
  Reporter: lari.task...@jns.fi
QA Contact: testo...@bugs.koha-community.org

Add endpoint that returns information on patron's debarments / excessive fines
etc. This endpoint can be used to find out patron's ability for checkouts and
holds.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #58457|0   |1
is obsolete||

--- Comment #40 from Lari Taskula  ---
Created attachment 60156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60156=edit
Bug 16826: Swaggerize Koha::Availability objects

Koha::Biblio::Availability->swaggerize
Koha::Item::Availability->swaggerize

Constructs a HASHref that contains all availability data to be returned in a
JSON
object. Numifies numbers to be numbers instead of strings. E.g. biblio
swaggerize

{
  "biblionumber": 1234,
  "availability": {
"available": true,
"notes": {
  "Patron::SomethingToNote": {
"cool": 1
  }
}
  },
  "item_availabilities": [
{
  "itemnumber": 5678,
  "availability": {
"available": false,
"unavailabilities": {
  "Item::Withdrawn": {}
}
  }
}
  ]
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #58458|0   |1
is obsolete||

--- Comment #41 from Lari Taskula  ---
Created attachment 60157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60157=edit
Bug 16826: Controllers for availability

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #58456|0   |1
is obsolete||

--- Comment #39 from Lari Taskula  ---
Created attachment 60155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60155=edit
Bug 16826: Availability Swagger definitions

GET /availability/biblio/hold
GET /availability/biblio/search
GET /availability/item/checkout
GET /availability/item/hold
GET /availability/item/search

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358

--- Comment #57 from Marcel de Rooy  ---
(In reply to sepas91 from comment #56)
> In koha 3.22, when I merge authorities without records it works. However, if
> they have some one I get this error:
> 
> Software error:
> Control fields (generally, just tags below 010) do not have subfields, use
> data() at /var/www/html/koha/lib/C4/AuthoritiesMarc.pm line 1523

Please have a look at the bugs under bug 17908. Including bug 17913.
Pushed to master, but not yet to stable. 
So, some improvements are coming..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

--- Comment #24 from Lari Taskula  ---
Fixed failing tests. To test these patches, I recommend applying patches in Bug
16826 on top of these and testing it via REST API. It demonstrates the
unavailability reasons nicely as it will include any additional parameter (like
"max_outstanding", "current_outstanding" in Patron::Debt) in the response JSON.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358

sepa...@gmail.com changed:

   What|Removed |Added

 CC||sepa...@gmail.com

--- Comment #56 from sepa...@gmail.com ---
In koha 3.22, when I merge authorities without records it works. However, if
they have some one I get this error:

Software error:
Control fields (generally, just tags below 010) do not have subfields, use
data() at /var/www/html/koha/lib/C4/AuthoritiesMarc.pm line 1523

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

Lari Taskula  changed:

   What|Removed |Added

  Attachment #58454|0   |1
is obsolete||

--- Comment #23 from Lari Taskula  ---
Created attachment 60154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60154=edit
Bug 17712: Item and biblio availability in search context

Usage:
my $availability = Koha::Availability::Search->item({
  item => $item,
})->in_opac;
if ($availability->available) {
  # yes
}

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

Lari Taskula  changed:

   What|Removed |Added

  Attachment #58453|0   |1
is obsolete||

--- Comment #22 from Lari Taskula  ---
Created attachment 60153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60153=edit
Bug 17712: Item availability for checkout

Usage:
my $issuability = Koha::Availability::Checkout->item({
  item => $item,
  patron => $patron,
  duedate => $duedate  # custom due date
})->in_intranet;
if ($issuability->available) {
  # yes!
} else {
  # not available for checkout. $issuability contains all the reasons for this.
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

Lari Taskula  changed:

   What|Removed |Added

  Attachment #58452|0   |1
is obsolete||

--- Comment #21 from Lari Taskula  ---
Created attachment 60152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60152=edit
Bug 17712: Biblio availability for hold

Usage:

$holdability = Koha::Availability::Hold->biblio({
  biblio => $biblio,
  patron => $patron,
  to_branch => "CPL",
})->in_opac;
if ($holdability->available) {
  # yup!
  # arrayref of Koha::Item::Availability::Hold -objects:
  # 1. all available items (items may contain confirmations / notes)
  my $item_availabilities = $holdability->item_availabilities;
  # 2. all unavailable items
  my $item_unavailabilities = $holdability->item_unavailabilites;
}

Returns a Koha::Biblio::Availability::Hold -object.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

Lari Taskula  changed:

   What|Removed |Added

  Attachment #58450|0   |1
is obsolete||

--- Comment #19 from Lari Taskula  ---
Created attachment 60150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60150=edit
Bug 17712: Centralize availability-related checks

There are some problems to our current approach for "availability" which makes
it complicated to integrate with e.g. REST API.

Firstly, there has been no unified way of representing reasons for
unavailability. Previously, each implementation of availability calculation has
chosen its own way for describing the reasons. For example, CanItemBeReserved
string "ageRestricted" vs. CanBookBeIssued key "AGE_RESTRICTION" in a HASHref.

Secondly, some of the availability logic is contained outside centralized
methods like CanItemBeReserved which is missing checks e.g. for maxreserves
(checked instead in opac-reserve.pl) and patron fines. Perhaps this issue could
be fixed in another Bug, but I propose we squash it at the same time with this
Bug. Currently, because of this, we will not get reliable responses to
holdability from CanItemBeReserved alone.

This causes problems for API integration where we need to be able to describe
the reason in an uniform way and additionally provide information on what needs
to be done to fix the issue. Also, we do not want to duplicate all the external
checks from .pl files into our REST controllers.

Instead of modifying the old methods, I propose a new structure for the whole
availability-problem and let us deal with proper "status-codes" to easily
integrate availability & additional availability-related information into e.g.
REST API.

My proposal is an approach to centralize the availability-related checks and
have
them return uniform reasons to describe reasons for availability problems.

Ultimately, we could ask availability something like this:
my $holdability = Koha::Availability::Hold->biblio({
  biblio => $biblio,
  patron => $patron,
  to_branch => 'CPL',
})->in_opac;

...and $holdability->unavailabilities HASHref would contain Koha::Exceptions
possibily with additional parameters to let us know why this biblio is not
holdable in OPAC.

This patch adds all availability related logic with centralization in mind.
From
these individual methods we are able to construct full availability queries in
order to determine if something is actually available in some way and also
describe the problems with the help of Koha::Exceptions.

Since availability is a mixture of multiple different smaller checks from
multiple
categories like item, patron, issuing rules, etc, they can be categorized into
their own subclasses. This lets us centralize availability-related methods per
category into their own modules.

To test:
1. prove t/db_dependent/Koha/Availability/Checks/*

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

Lari Taskula  changed:

   What|Removed |Added

  Attachment #58451|0   |1
is obsolete||

--- Comment #20 from Lari Taskula  ---
Created attachment 60151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60151=edit
Bug 17712: Item availability for hold

Adds Koha::Item::Availability::Hold class for item hold availability.

This patch adds item holdability queries in two contexts:
1. in_opac (perspective of patron themselves)
2. in_intranet (perspective of a librarian to patron)

Returns a Koha::Item::Availability::Hold object, which contains all information
on
availability for hold in that context. This may include additional notes,
reasons
to ask for confirmation or reasons for unavailability.

Example: To find out if patron can hold an item in OPAC, we will write:

my $availability = Koha::Availability::Hold->item({
patron => $patron,
item => $item,
to_branch => $branchcode, # transfer allowed from holdingbranch to
to_branch?
})->in_opac;
if ($availability->available) {
# yes!
} else {
foreach my $reason (keys %{$availability->unavailabilities}) {
# each reason for unavailability
}
foreach my $reason (keys %{$availability->confirmations}) {
# each reason that requires confirmation
}
foreach my $reason (keys %{$availability->notes}) {
# each additional note
}
}

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

Lari Taskula  changed:

   What|Removed |Added

  Attachment #58449|0   |1
is obsolete||

--- Comment #18 from Lari Taskula  ---
Created attachment 60149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60149=edit
Bug 17712: Add base for item and biblio availability

This patch adds two new classes:
- Koha::Biblio::Availability
- Koha::Item::Availability

These classes represent biblio- and item-level availabilities and the purpose
of this patch is simply to provide constructors that validate given biblio/item
and patron parameters.

Hold / checkout / search view availabilities (the actual answers to
availability)
will be provided in the next patches.

To test:
1. Run t/db_dependent/Koha/Item/Availability.t
2. Run t/db_dependent/Koha/Biblio/Availability.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

Lari Taskula  changed:

   What|Removed |Added

  Attachment #58447|0   |1
is obsolete||

--- Comment #17 from Lari Taskula  ---
Created attachment 60148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60148=edit
Bug 17712: Koha::Availability, a base for availability information

This patch adds a new class, Koha::Availability, which is designed to contain
availability information for each type of availability in an uniform way.
Because
of this, Koha::Availability has no actual availability calculation logic, but
simply methods to get and set availability information into the object.

With such design, we can next create new classes Koha::Availability::Hold and
Koha::Availability::Checkout and let them inherit Koha::Availability so that
they
are able to handle availaibility information in an uniform way.

   Koha::Availability::Hold  Koha::Availability::Checkout
  |   |
   \_/
   |
  Koha::Availability

Koha::Availability can represent four levels of availability statuses:
1. available
2. available, with an additional note
3. available, but requires confirmation
4. unavailable

Additional notes, reasons for a need to confirm and reasons for
unavailabilities
are kept in a HASHref, where each value in my proposal is a
Koha::Exceptions::*.
This allows us to easily store any additional data directly into the reason.
For
example, if we want to check biblio availability for hold and find out it is
not
available, the HASHref for unavailabilities has a
Koha::Exceptions::Patron::Debt
that contains parameters "current_outstanding" and "max_outstanding" which lets
us pick up the information easily later on without making new queries.

To test:
1. Run t/Koha/Availability.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

Lari Taskula  changed:

   What|Removed |Added

  Attachment #58446|0   |1
is obsolete||

--- Comment #16 from Lari Taskula  ---
Created attachment 60147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60147=edit
Bug 17712: Add new Koha::Exceptions

To describe problems or notes to availability, we will be using
Koha::Exceptions.
This patch adds many useful Koha::Exceptions that we can use for this purpose.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18102] REST API: Add pickup_location to library's Swagger definition

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18102

Lari Taskula  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lari.task...@jns.fi
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18102] REST API: Add pickup_location to library's Swagger definition

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18102

--- Comment #1 from Lari Taskula  ---
Created attachment 60146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60146=edit
Bug 18102: Add pickup_location to library's Swagger definition

This patch adds pickup_location to library's Swagger definition.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/