[Koha-bugs] [Bug 18025] Expired password recovery links cause sql crash

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025

--- Comment #14 from Jonathan Druart  
---
Created attachment 60305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60305=edit
Bug 18025: Simplify logic and avoid 1 call to ValidateBorrowernumber

Signed-off-by: Liz Rea 
This is fine with me.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18025] Expired password recovery links cause sql crash

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18025] Expired password recovery links cause sql crash

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #60245|0   |1
is obsolete||
  Attachment #60295|0   |1
is obsolete||
  Attachment #60296|0   |1
is obsolete||

--- Comment #12 from Jonathan Druart  
---
Created attachment 60303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60303=edit
Bug 18025 - Expired password recovery links cause sql crash

When a user gets an email, but doesn't act or visit it within two days,
 attempting to create a new one causes a collision. We should just
 delete the old one, assuming they still want to reset their
 password.

To test:
create yourself a borrower with a userid and password.
Attempt a password recovery on the OPAC
update the entry in the database for that user to have an expired token
e.g. update borrower_password_recovery set valid_until = '2017-01-25
03:25:26' where borrowernumber = 12;
Attempt another password recovery operation - should error
apply the patch
Try it again - no error, new token is generated and additional email
with new link is sent.

Issue reproduced - is resolved by patch
Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18025] Expired password recovery links cause sql crash

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025

--- Comment #13 from Jonathan Druart  
---
Created attachment 60304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60304=edit
Bug 18025: Fix test

Signed-off-by: Liz Rea 
Seems to work fine

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification /deletion tools

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #4 from Marcel de Rooy  ---
Aleisha
Looks good.
But please note that a list only contains biblio records. So you should not
offer the option when the user selects Authorities.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification /deletion tools

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17273

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17273] Batch MARC Modification - improve options to define which records to modify

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=12759

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18105] Should we restart koha-indexer differently i.e. like koha-plack?

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18105

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #1 from Magnus Enger  ---
(In reply to Marcel de Rooy from comment #0)
> If you know how this work, no problem. But it is not consistent.

+1 for consistency!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14854] Add DataTables on upload results table

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14854

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14854] Add DataTables on upload results table

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14854

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60168|0   |1
is obsolete||

--- Comment #5 from Marcel de Rooy  ---
Created attachment 60302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60302=edit
Bug 14854: Add DataTables on upload results table

This patch adds datatables to the upload results table.
Tools -> Upload

To test:
1) Go to Tools -> Upload
2) Put any search term in search box, click Search
3) Confirm table shows as datatable and sorting works on all columns
EXCEPT Actions

Sponsored-by: Catalyst IT

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

Marc Véron  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #14 from Marc Véron  ---
(In reply to dilan from comment #13)
> I tried to apply the patch to ptfs sandbox 0 but received the following
> error in an email during the sandbox setup:
> 
> 
(...)
The patches are for different versions of Koha, you should apply only one of
them, depending on your version. Choose 'Interactive' while applying and then
comment out the patches you do not want to apply.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18128] 'Go to page' option for search results in opac and staff

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128

--- Comment #1 from Aleisha Amohia  ---
Created attachment 60301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60301=edit
Bug 18128: Go to page option for search results in OPAC and staff

This patch adds a dropdown of all available search result pages for a
user to jump to.

To test:
1) Apply Bug 13205
2) Do a search in OPAC and in staff client
3) Try to jump to different pages in the dropdown, confirm they always
work

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18128] 'Go to page' option for search results in opac and staff

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |aleishaamo...@hotmail.com
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18128] 'Go to page' option for search results in opac and staff

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch
 Depends on||13205


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205
[Bug 13205] Last/First page options for result list paging
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||18128


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128
[Bug 18128] 'Go to page' option for search results in opac and staff
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18128] New: 'Go to page' option for search results in opac and staff

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128

Bug ID: 18128
   Summary: 'Go to page' option for search results in opac and
staff
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

As suggested in Bug 13205 Comment 1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

--- Comment #4 from Aleisha Amohia  ---
Created attachment 60300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60300=edit
Bug 13205: Last/first page options for result list paging for OPAC

Same fix but on OPAC side. Same test plan

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5560] pagination option for lists

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5560

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Aleisha Amohia  ---
I believe this has now been fixed thanks to DataTables. Setting to Resolved.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18127] Add batch modified records to an existing list

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |aleishaamo...@hotmail.com
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification /deletion tools

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

--- Comment #3 from Aleisha Amohia  ---
(In reply to Joy Nelson from comment #1)
> Along these same lines, it would be great to be able to use the batch
> modification (or other method) to add a batch of bib/items to a list.

I have added a patch for this suggestion to Bug 18127

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18127] Add batch modified records to an existing list

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127

--- Comment #1 from Aleisha Amohia  ---
Created attachment 60299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60299=edit
Bug 18127: Add batch modified records to an existing list

This patch is based off a suggestion from bug 12759 to allow a user to
add records to a list after they have been batch modified.

To test:
1) Apply 12759
2) Pick a list to modify, go through batch modification process
3) Once the modification is done and successful, there should now be a
'Next' box with options in it
4) Confirm the 'New batch record modification' button takes you back to
the start of the process.
5) Repeat step 2
6) Select a list from the dropdown to add your records to
7) Confirm that the correct records show in the pop up window
8) Once saved, go to your lists and confirm unique records were saved to
the list

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification /deletion tools

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||18127


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127
[Bug 18127] Add batch modified records to an existing list
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18127] Add batch modified records to an existing list

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch
 Depends on||12759


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759
[Bug 12759] Add ability to pass list contents to batch record
modification/deletion tools
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18127] New: Add batch modified records to an existing list

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127

Bug ID: 18127
   Summary: Add batch modified records to an existing list
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

>From Bug 12759 Comment 1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17627] Move C4::Koha::GetItemTypesByCategory to Koha::ItemTypes

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17627

Nick Clemens  changed:

   What|Removed |Added

  Attachment #57479|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 60298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60298=edit
Bug 17627: Move C4::Koha::GetItemTypesByCategory to Koha::ItemTypes

C4::Koha::GetItemTypesByCategory can be easily replaced with
Koha::ItemTypes->search({ searchcategory => ? });

So let's replace it where it is used.

Test plan:
Make sure this patch does not break the test plan of bug 10937

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17627] Move C4::Koha::GetItemTypesByCategory to Koha::ItemTypes

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17627

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17453] Inter-site holds improvement

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

--- Comment #28 from Nick Clemens  ---
And forgot to mention - in the atomic update the options and explanation
columns are switched - needs to be corrected when pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

di...@calyx.net.au changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #13 from di...@calyx.net.au ---
I tried to apply the patch to ptfs sandbox 0 but received the following error
in an email during the sandbox setup:


The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 18026:
Something went wrong !Applying: Bug 18026 - URL to database columns
link in system preferences is incorrect (16.05.x)
Applying: Bug 18026 - URL to database columns link in system preferences is
incorrect (16.11.x)
Using index info to reconstruct a base tree...
M  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
M   koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
M   koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
Falling back to patching base and 3-way merge...
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
Failed to merge in the changes.
Patch failed at 0001 Bug 18026 - URL to database columns link in system
preferences is incorrect (16.11.x)
The copy of the patch that failed is found in:
   /home/koha/src/.git/rebase-apply/patch

When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 18026 - URL to database columns link in system preferences is incorrect

60232 - Bug 18026 - URL to database columns link in system preferences is
incorrect (16.05.x)
60233 - Bug 18026 - URL to database columns link in system preferences is
incorrect (16.11.x)
60234 - Bug 18026 - URL to database columns link in system preferences is
incorrect (3.22.x)
60235 - Bug 18026 - URL to database columns link in system preferences is
incorrect (master)
60292 - Bug 18026 [ALTERNATIVE PATCH FOR MASTER] URL to database columns link
in system preferences is incorrect

Apply? [(y)es, (n)o, (i)nteractive] Patch left in
/tmp/Bug-18026---URL-to-database-columns-link-in-system-w0Wf3f.patch .

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification /deletion tools

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |aleishaamo...@hotmail.com
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification /deletion tools

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

Aleisha Amohia  changed:

   What|Removed |Added

Summary|Add ability to pass list|Add ability to pass list
   |contents to batch item  |contents to batch record
   |modification/deletion tools |modification/deletion tools
 CC||aleishaamo...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch item modification/ deletion tools

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch item modification/ deletion tools

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

--- Comment #2 from Aleisha Amohia  ---
Created attachment 60297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60297=edit
Bug 12759: Use a list (shelf) for batch record modification and deletion

To test:
1) Create a list, add a record to it by its barcode that you don't mind
deleting
2) Go to Tools -> Batch record modification
3) Select the list from the dropdown, select a modification template,
Continue
4) Confirm all of the records in that list show on the page. Click
Modify selected records. Confirm this is successful.
5) Go to Batch record deletion
6) Select the list from the dropdown and click Continue
7) Confirm all of the records in that list show on the page. Click
Delete selected records. Confirm this is successful.
8) Go back to your lists. The list should still exist but it will now be
empty.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9026] Reject/approve a tag *one time* / (batch) edit tags

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9026

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com

--- Comment #4 from Aleisha Amohia  ---
Is this still valid? Once a tag has been approved or rejected, it's status can
be changed over and over.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9666] add columns for status to inventory

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9666

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com

--- Comment #1 from Aleisha Amohia  ---
Is this still valid? In the latest version I can see Status etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18125] Edit button can duplicate some circulation rule

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18125

Katrin Fischer  changed:

   What|Removed |Added

 CC||claire_grav...@hotmail.com,
   ||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18025] Expired password recovery links cause sql crash

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025

Liz Rea  changed:

   What|Removed |Added

  Attachment #60282|0   |1
is obsolete||

--- Comment #11 from Liz Rea  ---
Created attachment 60296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60296=edit
Bug 18025: Simplify logic and avoid 1 call to ValidateBorrowernumber

Signed-off-by: Liz Rea 
This is fine with me.


 Current status: Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18025] Expired password recovery links cause sql crash

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025

Liz Rea  changed:

   What|Removed |Added

  Attachment #60281|0   |1
is obsolete||

--- Comment #10 from Liz Rea  ---
Created attachment 60295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60295=edit
Bug 18025: Fix test

Signed-off-by: Liz Rea 
Seems to work fine

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7626] Delete multiple tags at once

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7626

Marc Véron  changed:

   What|Removed |Added

  Attachment #60225|0   |1
is obsolete||

--- Comment #3 from Marc Véron  ---
Created attachment 60294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60294=edit
Bug 7626: Delete multiple tags in OPAC at once

This patch removes the individual 'Delete' buttons for every tag as
suggested in Comment 0. It adds a checkbox to every tag, with a 'Delete
selected tags' button at the bottom of the table. This patch also adds a
function to check if any checkboxes have been checked before submitting
the form (only works with JS enabled).

To test:
1) Find a record in the OPAC and add some tags to it
2) Go to your tags and notice the checkboxes, no more delete buttons for
each tag
3) Click 'Delete selected tags' button without selecting any tags
4) Confirm alert shows up. Click OK
5) Select one or more tags and click 'Delete selected tags' button
6) Confirm delete is successful and correct number of deleted tags shows
up

Sponsored-by: Catalyst IT

Followed test plan, works as expected
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7626] Delete multiple tags at once

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7626

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10978] redirect to basket list of a supplier after deleting a basket

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10978

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10978] redirect to basket list of a supplier after deleting a basket

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10978

Marc Véron  changed:

   What|Removed |Added

  Attachment #60283|0   |1
is obsolete||

--- Comment #4 from Marc Véron  ---
Created attachment 60293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60293=edit
Bug 10978: Redirect to basket list of a supplier after deleting a basket

This patch redirects to the vendor's list of baskets after deleting a
basket, fixes breadcrumbs after deletion and also hides the toolbar
actions after deletion (seeing as you can't edit/export etc a basket
that no longer exists).

To test:
1) Go to Acquisitions -> find a vendor -> view a basket or create a new
basket
2) Delete the basket. Notice you are taken to a list of all vendors and
baskets
3) Apply patch and do step 1 again
4) Delete the basket. Notice appropriate breadcrumbs, no toolbar, and
confirm link to return to baskets for the vendor works.

Sponsored-by: Catalyst IT

Followed test plan, works as expected (links to vendor's baskets and all
baskets)
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

--- Comment #12 from Marc Véron  ---
Created attachment 60292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60292=edit
Bug 18026 [ALTERNATIVE PATCH FOR MASTER] URL to database columns link in system
preferences is incorrect

Alternative patch for Master (with unsplitted sentences for better
translatability)

To test:
- Apply patch to master
- Go to Home > Administration > System preferences
- Select Acquisitons, OPAC and Patrons, search for "Database schma", verify
that text and links are correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17453] Inter-site holds improvement

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

--- Comment #27 from Nick Clemens  ---
I am not 100% sure on the wording of the message, but I don't have a better
suggestion and feature works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17453] Inter-site holds improvement

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

--- Comment #26 from Nick Clemens  ---
Created attachment 60291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60291=edit
Bug 17453 (QA Followup)

Add line break before note message

https://bugs.koha-community.org/show_bug.cgi?id=14753

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17453] Inter-site holds improvement

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

--- Comment #21 from Nick Clemens  ---
Created attachment 60286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60286=edit
Bug 17453: Inter-site holds improvement

At the moment users can reserve items and choose any library as a pick up
location, but there is no mechanism to prevent users from reserving items that
are available on the shelf at any given location from reserving the item at the
same location, essentially creating a Fetch and Collect scenario.
This has an impact on staff workloads as they are having to process
reservations
and check shelves for items that students can already come and collect from the
open library shelves.
The aim of this enhancement is to decrease the impact on staff workload there
should be a restriction in place that prevents users from requesting items for
collection at a library where the item is currently available.

Implementation:
We first tried to add a new circulation rule adding a 4th
“NotIfAvailableAtPickupLibrary” option to "On shelf holds allowed".
That would make the development more flexible.
But in that case we quickly faced non-trivial problematics:
Let's say you have 3 items I1, I2 and I3. The first one has onshelfholds
set to Yes and 2 others has it set to “NotIfAvailableAtPickupLibrary”.
What would be the expected behavior if a hold is placed at biblio level?
And if a hold is placed at item level for I1?
This second point could be answered by reworking the interface to move
the libraries dropdown list elsewhere (1 list per item) or by adding a
lot of JS code to handle the different situation. But it would be
much more complicated to implement.
So finally I moved back to the simple approach and added a new pref to
handle the behavior globally.

Test plan:
0/ Switch off OPACHoldsIfAvailableAtPickup
1/ Let's say you have 3 libraries L1, L2, L3, create 2 items owned by L1
and L2
2/ Place a biblio level hold. You should only be able to pick it up at
L3
2/ Place a item level hold. You should only be able to pick it up at
L3
3/ Create a third items owned by L3
4/ Now you should not be able to place a hold on this record anymore

Sponsored-by: University of the Arts London

Signed-off-by: Nick Clemens 

https://bugs.koha-community.org/show_bug.cgi?id=14753

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17453] Inter-site holds improvement

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

--- Comment #22 from Nick Clemens  ---
Created attachment 60287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60287=edit
Bug 17453: Add exceptions

This patch adds the ability to define patron categories not affected by
the behavior of OPACHoldsIfAvailableAtPickup.
The new pref OPACHoldsIfAvailableAtPickupExceptions get a list of patron
categories (separated by pipes |).

Signed-off-by: Nick Clemens 

https://bugs.koha-community.org/show_bug.cgi?id=14753

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17453] Inter-site holds improvement

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

--- Comment #25 from Nick Clemens  ---
Created attachment 60290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60290=edit
Bug 17453: Take into account items that are lost or damaged

If all the items are either lost, damaged or checked out, then pickup
should be allowed.

Signed-off-by: Nick Clemens 

https://bugs.koha-community.org/show_bug.cgi?id=14753

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17453] Inter-site holds improvement

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

--- Comment #23 from Nick Clemens  ---
Created attachment 60288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60288=edit
Bug 17453: Allow pickup at a library where all items are checked out

If all items are checked out then it should be possible to select the pickup
library for that record.

Signed-off-by: Janet McGowan 

Signed-off-by: Nick Clemens 

https://bugs.koha-community.org/show_bug.cgi?id=14753

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17453] Inter-site holds improvement

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

--- Comment #24 from Nick Clemens  ---
Created attachment 60289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60289=edit
Bug 17453: Add a visible notification to patron to explain why the hold
locations are disabled

Signed-off-by: Nick Clemens 

https://bugs.koha-community.org/show_bug.cgi?id=14753

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17453] Inter-site holds improvement

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

Nick Clemens  changed:

   What|Removed |Added

  Attachment #57002|0   |1
is obsolete||
  Attachment #57003|0   |1
is obsolete||
  Attachment #59915|0   |1
is obsolete||
  Attachment #59916|0   |1
is obsolete||
  Attachment #60093|0   |1
is obsolete||
  Attachment #60102|0   |1
is obsolete||

--- Comment #20 from Nick Clemens  ---
Created attachment 60285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60285=edit
Bug 17453: Add pref OPACHoldsIfAvailableAtPickup

Signed-off-by: Nick Clemens 

https://bugs.koha-community.org/show_bug.cgi?id=14753

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17453] Inter-site holds improvement

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17912] Koha- common error

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17912

KiraM  changed:

   What|Removed |Added

 CC||kira.ma...@edu.sait.ca

--- Comment #1 from KiraM  ---
have had same issues - any luck?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18126] New: error message koha-common packages with unmet dependencies

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18126

Bug ID: 18126
   Summary: error message koha-common packages with unmet
dependencies
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: gmcha...@gmail.com
  Reporter: kira.ma...@edu.sait.ca
QA Contact: testo...@bugs.koha-community.org

Created attachment 60284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60284=edit
Screen shot of error message

We are an educational institute trying to install Koha for classroom use and
have received an error message with the "sudo apt-get install koha-command"
line that some packages could not be installed. Please see attached screen
shot. Any suggestions welcome!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10978] redirect to basket list of a supplier after deleting a basket

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10978

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #60227|0   |1
is obsolete||

--- Comment #3 from Aleisha Amohia  ---
Created attachment 60283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60283=edit
Bug 10978: Redirect to basket list of a supplier after deleting a basket

This patch redirects to the vendor's list of baskets after deleting a
basket, fixes breadcrumbs after deletion and also hides the toolbar
actions after deletion (seeing as you can't edit/export etc a basket
that no longer exists).

To test:
1) Go to Acquisitions -> find a vendor -> view a basket or create a new
basket
2) Delete the basket. Notice you are taken to a list of all vendors and
baskets
3) Apply patch and do step 1 again
4) Delete the basket. Notice appropriate breadcrumbs, no toolbar, and
confirm link to return to baskets for the vendor works.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12786] permission to allow everyone in staff client to see all patron lists

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12786

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com

--- Comment #2 from Aleisha Amohia  ---
My superlibrarian user can see all patron lists already. Do you mean to make a
permission for if there is a staff user who is not a superlibrarian?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18044] Label Batches not displaying

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18044

--- Comment #22 from Chris Nighswonger  ---
Thanks to everyone who helped get this resolved quickly!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

--- Comment #11 from Mason James  ---
(In reply to Marc Véron from comment #10)
> Hi Mason,
> 
> Since we touch this part and for the sake of translatability: Is it possible
> to get rid of sentence splitting by HTML tags (at least for master)?
> 
> Example (Link on 'Database schema'):
> ---   
> The following database columns will not appear on the patron
> self-modification screen:
> [ ]  (separate columns with |) Database schema
> ---

Hi Mark, 

yes, sounds good :)

could you attach a small example patch for me?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18044] Label Batches not displaying

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18044

Mason James  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Stable|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18044] Label Batches not displaying

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18044

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #21 from Mason James  ---
Pushed to 16.05.x, for 16.05.10 release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18097] It is possible to create unusable category codes (ccode) due to field length mismatch

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18097

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||17216

--- Comment #2 from Jonathan Druart  
---
Kyle, do you plan to provide a complete patch?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216
[Bug 17216] Add a new table to store authorized value categories
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18097


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18097
[Bug 18097] It is possible to create unusable category codes (ccode) due to
field length mismatch
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18025] Expired password recovery links cause sql crash

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |l...@catalyst.net.nz
 Status|Failed QA   |Signed Off

--- Comment #9 from Jonathan Druart  
---
Liz, Does the last patch sounds ok to you?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18025] Expired password recovery links cause sql crash

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025

--- Comment #8 from Jonathan Druart  
---
Created attachment 60282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60282=edit
Bug 18025: Simplify logic and avoid 1 call to ValidateBorrowernumber

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18025] Expired password recovery links cause sql crash

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025

--- Comment #7 from Jonathan Druart  
---
Created attachment 60281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60281=edit
Bug 18025: Fix test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #10 from Marc Véron  ---
Hi Mason,

Since we touch this part and for the sake of translatability: Is it possible 
to get rid of sentence splitting by HTML tags (at least for master)?

Example (Link on 'Database schema'):
--- 
The following database columns will not appear on the patron self-modification
screen:
[ ]  (separate columns with |) Database schema
---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168

Nick Clemens  changed:

   What|Removed |Added

  Attachment #60279|0   |1
is obsolete||

--- Comment #2 from Nick Clemens  ---
Created attachment 60280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60280=edit
Bug 17168 - Add a command line script for updating patron category based on
status

This patch adds a new script update_patrons_category.pl which allows for
updating patron categories in a batch upon meeting provided criteria.
This script additionally can replace j2a.pl.

To test:
1 - perl update_patrons_category.pl -h
2 - Ensure help text makes sense and covers all options
3 - Test converting patrons supplying only fromcat and tocat
perl update_patrons_category.pl -f PT -t J -v
perl update_patrons_category.pl -f PT -t J -v
4 - All patrons should have been switched to and from Juveniles
5 - Try with -n switch
perl update_patrons_category.pl -f PT -t J -v -n
6 - Should list all patrons but not update
7 - Set the age for juvenile patrons to be outside the range provided in
categories (or set the upper age limit for juveniles to '2')
8 - Test with verbosity and with without -n
perl update_patrons_category.pl -f J -a -t PT -v -n
perl update_patrons_category.pl -f J -a -t PT -v
9 - Repeat above and verify linked/unlinked guarantors are removed in above
scenario
10 - Test various fine and registration limits
11 - Test matching on specific fields i.e. --field surname=acosta
12 - Sign off

Sponsored by: Round Rock Public Library
(https://www.roundrocktexas.gov/departments/library/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18025] Expired password recovery links cause sql crash

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #6 from Jonathan Druart  
---
Liz, could you double check please? The tests do not pass for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168

--- Comment #1 from Nick Clemens  ---
Created attachment 60279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60279=edit
Bug 17168 - Add a command line script for updating patron category based on
status

This patch adds a new script update_patrons_category.pl which allows for
updating patron categories in a batch upon meeting provided criteria.
This script additionally can replace j2a.pl.

To test:
1 - perl update_patrons_category.pl -h
2 - Ensure help text makes sense and covers all options
3 - Test converting patrons supplying only fromcat and tocat
perl update_patrons_category.pl -f PT -t J -v
perl update_patrons_category.pl -f PT -t J -v
4 - All patrons should have been switched to and from Juveniles
5 - Try with -n switch
perl update_patrons_category.pl -f PT -t J -v -n
6 - Should list all patrons but not update
7 - Set the age for juvenile patrons to be outside the range provided in
categories (or set the upper age limit for juveniles to '2')
8 - Test with verbosity and with without -n
perl update_patrons_category.pl -f J -a -t PT -v -n
perl update_patrons_category.pl -f J -a -t PT -v
9 - Repeat above and verify linked/unlinked guarantors are removed in above
scenario
10 - Test various fine and registration limits
11 - Test matching on specific fields i.e. --field surname=acosta
12 - Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #60277|0   |1
is obsolete||

--- Comment #31 from Kyle M Hall  ---
Created attachment 60278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60278=edit
Bug 14826 - Add offset for rental fees

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #27 from Kyle M Hall  ---
Created attachment 60274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60274=edit
Bug 14826 - Remove old offset table schema file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #28 from Kyle M Hall  ---
Created attachment 60275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60275=edit
Bug 14826 - Add new offset table schema file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #29 from Kyle M Hall  ---
Created attachment 60276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60276=edit
Bug 14826 - Update existing schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #30 from Kyle M Hall  ---
Created attachment 60277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60277=edit
Bug 14826 - Add offset for rental fees

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #25 from Kyle M Hall  ---
Created attachment 60272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60272=edit
Bug 14826 - Resurrect account offsets table

The account offsets table should be used to track increments and
decrements of fines via payments and credits, as well as fine accruals.
It should be able to match fees to payments and visa versa, so we can
know which fee was paid by a given payment, and which payments applied
to a given fee.

Test Plan:
1) Apply this patch
2) Run updatedatabase
3) Note the table accountoffsets has been renamed to account_offsets
4) Ensure fine generation creates offsets
5) Ensure creating a manual invoice creates an offset
6) Ensure a lost item charge creates an offset
7) Ensure Reverse Payment creates an offset
8) Ensure a payment creates an offset
9) Ensure a payment for multiple fees creates an offset for each
10) Ensure writeoffs create offsets

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #26 from Kyle M Hall  ---
Created attachment 60273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60273=edit
Bug 14826 - Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #24 from Kyle M Hall  ---
Created attachment 60271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60271=edit
Bug 14826 - Add Koha modules for offsets

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #59254|0   |1
is obsolete||
  Attachment #59255|0   |1
is obsolete||
  Attachment #59256|0   |1
is obsolete||
  Attachment #59257|0   |1
is obsolete||
  Attachment #59258|0   |1
is obsolete||

--- Comment #23 from Kyle M Hall  ---
Created attachment 60270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60270=edit
Bug 14826 - Update database

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60219|0   |1
is obsolete||

--- Comment #46 from Lari Taskula  ---
Created attachment 60269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60269=edit
Bug 16826: Controllers for availability

GET /availability/biblio/hold
GET /availability/biblio/search
GET /availability/item/checkout
GET /availability/item/hold
GET /availability/item/search

Includes API tests.

To test:
1. prove t/db_dependent/api/v1/availability.t
2. Use Swagger-UI or make direct GET requests to specified availability
   endpoints, and make sure the returned data looks ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60156|0   |1
is obsolete||

--- Comment #45 from Lari Taskula  ---
Created attachment 60268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60268=edit
Bug 16826: Swaggerize Koha::Availability objects

Koha::Biblio::Availability->swaggerize
Koha::Item::Availability->swaggerize

Constructs a HASHref that contains all availability data to be returned in a
JSON
object. Numifies numbers to be numbers instead of strings. E.g. biblio
swaggerize

{
  "biblionumber": 1234,
  "availability": {
"available": true,
"notes": {
  "Patron::SomethingToNote": {
"cool": 1
  }
}
  },
  "item_availabilities": [
{
  "itemnumber": 5678,
  "availability": {
"available": false,
"unavailabilities": {
  "Item::Withdrawn": {}
}
  }
}
  ]
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60155|0   |1
is obsolete||

--- Comment #44 from Lari Taskula  ---
Created attachment 60267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60267=edit
Bug 16826: Availability Swagger definitions

GET /availability/biblio/hold
GET /availability/biblio/search
GET /availability/item/checkout
GET /availability/item/hold
GET /availability/item/search

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60150|0   |1
is obsolete||

--- Comment #25 from Lari Taskula  ---
Created attachment 60261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60261=edit
Bug 17712: Centralize availability-related checks

There are some problems to our current approach for "availability" which makes
it complicated to integrate with e.g. REST API.

Firstly, there has been no unified way of representing reasons for
unavailability. Previously, each implementation of availability calculation has
chosen its own way for describing the reasons. For example, CanItemBeReserved
string "ageRestricted" vs. CanBookBeIssued key "AGE_RESTRICTION" in a HASHref.

Secondly, some of the availability logic is contained outside centralized
methods like CanItemBeReserved which is missing checks e.g. for maxreserves
(checked instead in opac-reserve.pl) and patron fines. Perhaps this issue could
be fixed in another Bug, but I propose we squash it at the same time with this
Bug. Currently, because of this, we will not get reliable responses to
holdability from CanItemBeReserved alone.

This causes problems for API integration where we need to be able to describe
the reason in an uniform way and additionally provide information on what needs
to be done to fix the issue. Also, we do not want to duplicate all the external
checks from .pl files into our REST controllers.

Instead of modifying the old methods, I propose a new structure for the whole
availability-problem and let us deal with proper "status-codes" to easily
integrate availability & additional availability-related information into e.g.
REST API.

My proposal is an approach to centralize the availability-related checks and
have
them return uniform reasons to describe reasons for availability problems.

Ultimately, we could ask availability something like this:
my $holdability = Koha::Availability::Hold->biblio({
  biblio => $biblio,
  patron => $patron,
  to_branch => 'CPL',
})->in_opac;

...and $holdability->unavailabilities HASHref would contain Koha::Exceptions
possibily with additional parameters to let us know why this biblio is not
holdable in OPAC.

This patch adds all availability related logic with centralization in mind.
From
these individual methods we are able to construct full availability queries in
order to determine if something is actually available in some way and also
describe the problems with the help of Koha::Exceptions.

Since availability is a mixture of multiple different smaller checks from
multiple
categories like item, patron, issuing rules, etc, they can be categorized into
their own subclasses. This lets us centralize availability-related methods per
category into their own modules.

To test:
1. prove t/db_dependent/Koha/Availability/Checks/*

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60152|0   |1
is obsolete||

--- Comment #27 from Lari Taskula  ---
Created attachment 60263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60263=edit
Bug 17712: Biblio availability for hold

Usage:

$holdability = Koha::Availability::Hold->biblio({
  biblio => $biblio,
  patron => $patron,
  to_branch => "CPL",
})->in_opac;
if ($holdability->available) {
  # yup!
  # arrayref of Koha::Item::Availability::Hold -objects:
  # 1. all available items (items may contain confirmations / notes)
  my $item_availabilities = $holdability->item_availabilities;
  # 2. all unavailable items
  my $item_unavailabilities = $holdability->item_unavailabilites;
}

Returns a Koha::Biblio::Availability::Hold -object.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60154|0   |1
is obsolete||

--- Comment #29 from Lari Taskula  ---
Created attachment 60265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60265=edit
Bug 17712: Item and biblio availability in search context

Usage:
my $availability = Koha::Availability::Search->item({
  item => $item,
})->in_opac;
if ($availability->available) {
  # yes
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60153|0   |1
is obsolete||

--- Comment #28 from Lari Taskula  ---
Created attachment 60264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60264=edit
Bug 17712: Item availability for checkout

Usage:
my $issuability = Koha::Availability::Checkout->item({
  item => $item,
  patron => $patron,
  duedate => $duedate  # custom due date
})->in_intranet;
if ($issuability->available) {
  # yes!
} else {
  # not available for checkout. $issuability contains all the reasons for this.
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60151|0   |1
is obsolete||

--- Comment #26 from Lari Taskula  ---
Created attachment 60262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60262=edit
Bug 17712: Item availability for hold

Adds Koha::Item::Availability::Hold class for item hold availability.

This patch adds item holdability queries in two contexts:
1. in_opac (perspective of patron themselves)
2. in_intranet (perspective of a librarian to patron)

Returns a Koha::Item::Availability::Hold object, which contains all information
on
availability for hold in that context. This may include additional notes,
reasons
to ask for confirmation or reasons for unavailability.

Example: To find out if patron can hold an item in OPAC, we will write:

my $availability = Koha::Availability::Hold->item({
patron => $patron,
item => $item,
to_branch => $branchcode, # transfer allowed from holdingbranch to
to_branch?
})->in_opac;
if ($availability->available) {
# yes!
} else {
foreach my $reason (keys %{$availability->unavailabilities}) {
# each reason for unavailability
}
foreach my $reason (keys %{$availability->confirmations}) {
# each reason that requires confirmation
}
foreach my $reason (keys %{$availability->notes}) {
# each additional note
}
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18125] Edit button can duplicate some circulation rule

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18125

Baptiste  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |baptiste.wojtkowski@biblibr
   |ity.org |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18125] New: Edit button can duplicate some circulation rule

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18125

Bug ID: 18125
   Summary: Edit button can duplicate some circulation rule
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: baptiste.wojtkow...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

If you modify the patron category and the item type when you edit a circulation
rule, this will create a new circulation rule

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11889] Disown a list

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

--- Comment #6 from Christopher Brannon  ---
*** Bug 13844 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13844] Orphaned lists

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13844

Christopher Brannon  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #4 from Christopher Brannon  ---


*** This bug has been marked as a duplicate of bug 11889 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15108] OAI-PMH provider improvements

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108

Ere Maijala  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15108] OAI-PMH provider improvements

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108

Ere Maijala  changed:

   What|Removed |Added

  Attachment #58245|0   |1
is obsolete||
  Attachment #58246|0   |1
is obsolete||
  Attachment #58247|0   |1
is obsolete||
  Attachment #58248|0   |1
is obsolete||
  Attachment #58249|0   |1
is obsolete||
  Attachment #58250|0   |1
is obsolete||
  Attachment #58251|0   |1
is obsolete||

--- Comment #77 from Ere Maijala  ---
Created attachment 60260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60260=edit
Bug 15108 - OAI-PMH provider improvements

This patch incorporates the extended test from bug 17493 and all other patches
(if I didn't mess up anything!). It also fixes a record range display problem
in OAI.xslt and reverts the order back to biblionumber to avoid a situation
where a record update could have changed the order of records and cause records
to be skipped.

This also fixes the QA problem with PartialList not found, removes the broken
and unused deleted method from ResumptionToken, fixes tests and fixes
resumptionToken cursor handling etc. compared to the previous patch. 

Here's the complete change list compared to master branch:

- Fixed date handling to use UTC as specs require.

- Added support for second precision in time stamps.

- Added support for marc21 metadata prefix as recommended in the
  guidelines (synonym for marcxml).

- Improved performance of database queries especially for large
  collections.

- Unified functionality of ListRecords and ListIdentifiers to a common
  base class.

- If items are included in the records, their timestamps are taken into
  account everywhere so that whichever is the most recent (timestamp of
  biblioitem or any of its items) is considered the record's timestamp.

- Fixed OAI.xslt to show correct record range.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17493] Improve OAI Server tests

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17493

Ere Maijala  changed:

   What|Removed |Added

 CC||ere.maij...@helsinki.fi

--- Comment #9 from Ere Maijala  ---
Thanks for extending the tests. I'm going to incorporate them and their fixes
into an upcoming patch to bug 15108 if that's ok for everyone. I'm afraid I'll
lost track of the patches around otherwise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #10 from Marcel de Rooy  ---
Created attachment 60257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60257=edit
Bug 9988: Table revision for need_merge_authorities

In order to let merge do exactly the same when called from the merge
cron job, we need two additional fields in the table. One existing field
is renamed.

Test plan:
Run the dbrev (updatestructure step in webinstaller).

Signed-off-by: Marcel de Rooy 
Also tested running kohastructure.sql for this table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #59159|0   |1
is obsolete||

--- Comment #12 from Marcel de Rooy  ---
Created attachment 60259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60259=edit
Bug 9988: Add Koha objects for table need_merge_authorities

This patch adds two Koha objects: MergeRequest(s).
A method add_merge_request is added to Koha::Authority.
A class method reporting_tag_xml is added to MergeRequests.pm.
Both routines are tested in Authorities.t.

Test plan:
Run t/db_dependent/Koha/Authorities.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #11 from Marcel de Rooy  ---
Created attachment 60258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60258=edit
Bug 9988: DBIx schema changes for need_merge_authorities

As generated by misc/devel/update_dbix_class_files.pl.
No test plan.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #59158|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 60256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60256=edit
Bug 9988: Database revision for AuthorityMergeLimit

Introduce the new preference and remove dontmerge.
If dontmerge was enabled, the new pref will be set to a lower number.

Test plan:
Run the database revision or a new install.
In case of an upgrade, check the new pref value. Should be 10 when
dontmerge was enabled, otherwise 50.

Signed-off-by: Marcel de Rooy 
Also tested sysprefs.sql on a new database.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18045] Reserves.t can fail because of caching issues

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18045

Nick Clemens  changed:

   What|Removed |Added

  Attachment #59868|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 60255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60255=edit
Bug 18045: Fix Reserves.t tests - caching issues

If the cache has to be cleaned when marc structure is updated.

Before this patch, if the age restriction was not mapped, Reserves.t
failed with:
  Tag "" is not a valid tag. at t/db_dependent/Reserves.t line 523.

Test plan:
Just confirm that the tests still pass and that the changes make sense.

Signed-off-by: Marcel de Rooy 
It seems that only removing the key MarcSubfieldStructure- should be
enough, but it does not hurt either to remove those four keys.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18045] Reserves.t can fail because of caching issues

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18045

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >