[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

--- Comment #108 from Zeno Tajoli  ---
Hi all,

I have the authorization.
I will publish my code in github (I hope soon).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #57404|0   |1
is obsolete||

--- Comment #7 from Srdjan Jankovic  ---
Created attachment 60857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60857=edit
Bug 17602 Add Oneclickdigital integration to Koha

Add OneClickdigital to the users page in the public interface

To Test:
1/ Apply all 3 patches
2/ Set the sysprefs to valid values (you will need a test account with
Oneclickdigital)
3/ Try a search
4/ Login to the OPAC, try to place a hold, or check an item out
5/ Check the opac-user page, see if your items are showing on the
oneclickdigital tab

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #57402|0   |1
is obsolete||

--- Comment #5 from Srdjan Jankovic  ---
Created attachment 60855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60855=edit
Bug 17602 : Add OneClickDigital Integration to Koha

Koha::ExternalContent::OneClickDigital - a wrapper around
WebService::ILS::OneClickDigital::PartnerPatron

Nothing functional to test with this patch yet.
But you can run the tests that come with it

 t/db_dependent/Koha_ExternalContent_OneClickDigital.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #57403|0   |1
is obsolete||

--- Comment #6 from Srdjan Jankovic  ---
Created attachment 60856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60856=edit
Bug 17602 OneClickDigital* sysprefs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18220] New: OPAC login appears to be linked to staff login

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18220

Bug ID: 18220
   Summary: OPAC login appears to be linked to staff login
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

On current master, I am noticing that after I login to Koha staff, when I open
a new tab in the browser, I am logged into the OPAC.  If I log off the OPAC, it
logs me off the staff as well.  I tested the same browser (Chrome) with our
3.22 production server and it does not have this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219

Christopher Brannon  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18219] New: "Not checked out." problem message displays twice on local use.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219

Bug ID: 18219
   Summary: "Not checked out." problem message displays twice on
local use.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When checking in an item that is not checked out, the problem message "Not
checked out appears twice.

This seems to have occured with the last update to the master.  I did not see
this before my master was updated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18150] CanItemBeReserved doesn't work with ( IndependentBranches AND ! canreservefromotherbranches)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150

Christopher Brannon  changed:

   What|Removed |Added

  Attachment #60853|0   |1
is obsolete||

--- Comment #4 from Christopher Brannon  ---
Created attachment 60854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60854=edit
[SIGNED OFF] Bug 18150 - CanItemBeReserved doesn't work with
(IndependentBranches AND ! canreservefromotherbranches)

The variable $item used to be a hash, but at the end of the function,
it's a Koha object. As $item->{homebranch} doesn't yield anything and
should be $item->homebranch. It prevents people using different
branches without holds between branches from placing a hold on an item
they should be able to place hold on.

Test plan:

1. Before patch

  a. with IndependantBranches off
  b. try to place hold on an item you should be able to place hold on
  d. put IndependantBranches on and canreservefromotherbranches off
  e. shouldn't work

2. after patches redo steps from (1) and everything should be working
fine.

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18150] CanItemBeReserved doesn't work with ( IndependentBranches AND ! canreservefromotherbranches)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150

Christopher Brannon  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18150] CanItemBeReserved doesn't work with ( IndependentBranches AND ! canreservefromotherbranches)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150

--- Comment #3 from Christopher Brannon  ---
Created attachment 60853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60853=edit
[SIGNED OFF] Bug 18150 - CanItemBeReserved doesn't work with
(IndependentBranches AND ! canreservefromotherbranches)

The variable $item used to be a hash, but at the end of the function,
it's a Koha object. As $item->{homebranch} doesn't yield anything and
should be $item->homebranch. It prevents people using different
branches without holds between branches from placing a hold on an item
they should be able to place hold on.

Test plan:

1. Before patch

  a. with IndependantBranches off
  b. try to place hold on an item you should be able to place hold on
  c. it should work
  d. put IndependantBranches on and canreservefromotherbranches off
  e. shouldn't work

2. after patches redo steps from (1) and everything should be working
fine.

Signed-off-by: Your Full Name 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18120] REST API: CRUD endpoint for vendors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18120] REST API: CRUD endpoint for vendors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 60852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60852=edit
Bug 18120: REST api | Add a 'vendors' endpoint

This patch introduces an /acquisitions/vendors endpoint.
To test:
- Apply the patch
- Run:
  $ sudo koha-shell kohadev
 k$ prove t/db_dependent/api/v1/acquisitions_vendors.t
=> SUCCESS: Tests pass
- Sign off :-D

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18120] REST API: CRUD endpoint for vendors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 60851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60851=edit
Bug 18120: REST api | /acquisitions/vendors unit tests

This patch introduces unit tests that need to be passed by an
/acquisitions/vendors/ REST endpoint.

To test:
- Apply the patch
- Run:
  $ sudo koha-shell kohadev
 k$ prove t/db_dependent/api/v1/acquisitions_vendors.t
=> FAIL: The endpoint is not present, should fail.

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18206] REST API: Default exception handling

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206

Lari Taskula  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lari.task...@jns.fi
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18205] REST interface to Koha::Logger

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205

Lari Taskula  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lari.task...@jns.fi
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18205] REST interface to Koha::Logger

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205

--- Comment #3 from Lari Taskula  ---
Created attachment 60850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60850=edit
Bug 18205: Mojo::Log with Koha::Logger::Mojo

This patch adds a new module, Koha::Logger::Mojo, based on
MojoX::Log::Log4perl.
This module allows us to use log4perl configurations with Mojolicious on the
freshly introduced 'rest' interface in log4perl.conf.

$c->app->log->warn will then use Log4perl as the underlying log mechanism and
those log events will point to the appropriate log file.

To test:
1. prove t/Koha/Logger/Mojo.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18205] REST interface to Koha::Logger

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205

--- Comment #2 from Lari Taskula  ---
Created attachment 60849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60849=edit
Bug 18205: Unit tests

To test:
1. prove t/db_dependent/Log.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18205] REST interface to Koha::Logger

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205

--- Comment #1 from Lari Taskula  ---
Created attachment 60848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60848=edit
Bug 18205: Add interface 'rest' for Koha::Logger

This patch adds an interface 'rest' for Koha::Logger.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Depends on||15427


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427
[Bug 15427] Allow db connections using TLS
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15427] Allow db connections using TLS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||18215


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215
[Bug 18215] Resolve warning on $tls in Database.pm
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776

--- Comment #8 from Martin Renvoize  ---
(In reply to Zeno Tajoli from comment #5)
> Do you think we can use http://www.ssocircle.com/en/portfolio/publicidp/ for
> testing ?
> 
> Or is better to use https://www.testshib.org/ ?

Either IdP should work perfectly happily.  I've tested here against teshshib,
openfiede and some customer systems using simplesamlphp and ms active directory
services.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776

--- Comment #7 from Martin Renvoize  ---
So after more local testing, i found that the plack environment could be a
little more complex than my initial tests.

This patch obsoletes the original and calls 'get_shib_login' later in the
runtime (i.e. outside of the begin block) so we have a valid environment by the
time the routine run.

In short, it should all work now so long as you've updated your Apache configs
as per the inline perldoc documentation.

I believe the UseHeaders and UseEnvironment variables for the shibboleth
service provider software are mutually exclusive (they appeared to be in my
brief testing), so I don't believe it is possible to run in a half and half
setup (unless you have two entirely separate vhosts.. one for plack and one for
non-plack running).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #60800|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 60847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60847=edit
Enable Shibboleth for Plack

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18218] New: Contact information (borrower, branch, acquisitions), should be centralized into a single table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18218

Bug ID: 18218
   Summary: Contact information (borrower, branch, acquisitions),
should be centralized into a single table
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The borrowers table contains three sets of contact information -- primary
(streetnumber, streettype, address, etc... no prefix), secondary
(B_streetnumber, B_streettype, etc) and alternate (altcontactaddress1,
altcontactaddress2, etc.)... there are also the emailpro and phonepro fields.

These should be moved into a 'contacts' table.

I think that it would be reasonable to re-factor the aqcontacts table so that
generic contact information was in the contacts table, as well as pulling
branch contact information into contacts as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|jwea...@bywatersolutions.co |k...@bywatersolutions.com
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15522] New interface for revamped circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Kyle M Hall  changed:

   What|Removed |Added

 Blocks|15524   |
 Depends on||15524


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524
[Bug 15524] Set limit on maximum possible holds per patron by category
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524

Kyle M Hall  changed:

   What|Removed |Added

 Depends on|15521, 15522|
 CC||k...@bywatersolutions.com
 Blocks||15521, 15522


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521
[Bug 15521] Make circulation rules backend more granular
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
[Bug 15522] New interface for revamped circulation rules
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15521] Make circulation rules backend more granular

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521

Kyle M Hall  changed:

   What|Removed |Added

 Blocks|15524   |
 Depends on||15524


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524
[Bug 15524] Set limit on maximum possible holds per patron by category
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182

--- Comment #6 from Tomás Cohen Arazi  ---
(In reply to Marcel de Rooy from comment #5)
> (In reply to Tomás Cohen Arazi from comment #4)
> > Singular classes are not aware of the plural class name. And we need the
> > plural to ->find the created object. That's the design decision I don't like
> > about koha::object(s). I'm open to opinions, but the only solutions are
> > -annotate singular classes so they know their plural
> > -move the plural methods to the singular classes and get rid of plural
> > 
> > I vote for the latter, of course. But that would be a bigger dev.
> 
> Did you look at this one: sub _get_objects_class
> $ git grep koha_objects_class
> Koha/Objects.pm:if( $type->can('koha_objects_class') ) {
> Koha/Objects.pm:return $type->koha_objects_class;
> Koha/Schema/Result/Borrower.pm:sub koha_objects_class {
> Koha/Schema/Result/Branch.pm:sub koha_objects_class {
> Koha/Schema/Result/OldIssue.pm:sub koha_objects_class {
> 
> So cool :)

So we annotate our singular classes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18217] New: SMS alert number should be grouped with other borrower contact information.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18217

Bug ID: 18217
   Summary: SMS alert number should be grouped with other borrower
contact information.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

SMS alert number is currently grouped with borrower messing preferences.

This is inconsistent with the rest of the borrower contact information.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941

--- Comment #39 from Petter Goksøyr Åsen  ---
(In reply to Petter Goksøyr Åsen from comment #38)
> > Pushed to master for 17.05, thanks Francesco!
> 
> It does not appear to be pushed:
> http://git.koha-community.org/gitweb/?p=koha.git;a=shortlog

Forget it, I'm blind!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941

--- Comment #38 from Petter Goksøyr Åsen  ---
> Pushed to master for 17.05, thanks Francesco!

It does not appear to be pushed:
http://git.koha-community.org/gitweb/?p=koha.git;a=shortlog

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182

--- Comment #5 from Marcel de Rooy  ---
(In reply to Tomás Cohen Arazi from comment #4)
> Singular classes are not aware of the plural class name. And we need the
> plural to ->find the created object. That's the design decision I don't like
> about koha::object(s). I'm open to opinions, but the only solutions are
> -annotate singular classes so they know their plural
> -move the plural methods to the singular classes and get rid of plural
> 
> I vote for the latter, of course. But that would be a bigger dev.

Did you look at this one: sub _get_objects_class
$ git grep koha_objects_class
Koha/Objects.pm:if( $type->can('koha_objects_class') ) {
Koha/Objects.pm:return $type->koha_objects_class;
Koha/Schema/Result/Borrower.pm:sub koha_objects_class {
Koha/Schema/Result/Branch.pm:sub koha_objects_class {
Koha/Schema/Result/OldIssue.pm:sub koha_objects_class {

So cool :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #60844|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall  ---
Created attachment 60846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60846=edit
Bug 18215: Resolve warning on $tls in Database.pm

Resolve this warning:
updatedatabase.pl: Use of uninitialized value $tls in string eq at
/usr/share/koha/masterclone/Koha/Database.pm line 63.

Test plan:
[1] Check if you do not see the warning anymore.

Signed-off-by: Magnus Enger 
Warning disappears after applying the patch.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182

--- Comment #4 from Tomás Cohen Arazi  ---
(In reply to Marcel de Rooy from comment #3)
> Great, Tomas.
> 
> Few remarks:
> I would rather remove the id column. We c/should take care of that in the
> code.
> Like:
> my @pk = $schema->source('Borrower')->primary_columns;
> Note that we theoretically can have multiple columns. (We don't have such
> Koha objects, but iirc we have one or two tables like that.)

I agree. Read the next answer to have context.

> Similarly, it would be more consistent and less confusing to use the
> singular form. We do so in build; I would expect the same for build_object.
> Additionally, you return just one singular object.

Singular classes are not aware of the plural class name. And we need the plural
to ->find the created object. That's the design decision I don't like about
koha::object(s). I'm open to opinions, but the only solutions are
-annotate singular classes so they know their plural
-move the plural methods to the singular classes and get rid of plural

I vote for the latter, of course. But that would be a bigger dev.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182

--- Comment #3 from Marcel de Rooy  ---
Great, Tomas.

Few remarks:
I would rather remove the id column. We c/should take care of that in the code.
Like:
my @pk = $schema->source('Borrower')->primary_columns;
Note that we theoretically can have multiple columns. (We don't have such Koha
objects, but iirc we have one or two tables like that.)

Similarly, it would be more consistent and less confusing to use the singular
form. We do so in build; I would expect the same for build_object.
Additionally, you return just one singular object.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18104] allow SIP2 field AE (personal name ) to be customized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18104

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18104] allow SIP2 field AE (personal name ) to be customized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18104

--- Comment #1 from Kyle M Hall  ---
Created attachment 60845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60845=edit
Bug 18104 - allow SIP2 field AE (personal name ) to be customized

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #60832|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 60844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60844=edit
Bug 18215: Resolve warning on $tls in Database.pm

Resolve this warning:
updatedatabase.pl: Use of uninitialized value $tls in string eq at
/usr/share/koha/masterclone/Koha/Database.pm line 63.

Test plan:
[1] Check if you do not see the warning anymore.

Signed-off-by: Magnus Enger 
Warning disappears after applying the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

--- Comment #18 from Lari Taskula  ---
(In reply to Lari Taskula from comment #10)
> I would like to point out that I am experiencing an issue with
> JSON::Validator, where $refs are sometimes left unresolved in our spec and
> it causes some error messages and crashes. This issue is being tracked at
> https://github.com/jhthorsen/json-validator/pull/52.

The developer of JSON::Validator has been working hard on it and it now seems
to have been fixed. The fix will appear in version 0.96 of JSON::Validator.
That should probably be added as dependency once it is released.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #60533|0   |1
is obsolete||

--- Comment #17 from Olli-Antti Kivilahti  ---
Created attachment 60843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60843=edit
Bug 18137: Remove x-mojo-around-action

Mojolicious::Plugin::OpenAPI does not support x-mojo-around action. This patch
removes it from our specification document.

Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #60495|0   |1
is obsolete||

--- Comment #16 from Olli-Antti Kivilahti  ---
Created attachment 60842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60842=edit
Bug 18137: Make /holds Mojolicious::Plugin::OpenAPI compatible

Also
- adding some missing and new response definitions into Swagger spec.
- fixing failing tests due to Bug 17932's change of boolean values

To test:
1. prove t/db_dependent/api/v1/holds.t

Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #60494|0   |1
is obsolete||

--- Comment #15 from Olli-Antti Kivilahti  ---
Created attachment 60841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60841=edit
Bug 18137: Make /cities Mojolicious::Plugin::OpenAPI compatible

Also:
- adding some missing and new response definitions into Swagger spec.

To test:
1. prove t/db_dependent/api/v1/cities.t

Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #60493|0   |1
is obsolete||

--- Comment #14 from Olli-Antti Kivilahti  ---
Created attachment 60840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60840=edit
Bug 18137: Make /patrons Mojolicious::Plugin::OpenAPI compatible

Also:
- adding some missing and new response definitions into Swagger spec.
- fixing failing test due to Bug 17932's change of boolean values

To test:
1. prove t/db_dependent/api/v1/patrons.t

Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #60492|0   |1
is obsolete||

--- Comment #13 from Olli-Antti Kivilahti  ---
Created attachment 60839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60839=edit
Bug 18137: Migrate from Swagger2 to Mojolicious::Plugin::OpenAPI

This patch migrates from Swagger2 to Mojolicious::Plugin::OpenAPI as Swagger2
is
no longer actively maintained.

This migration involves some minor changes to our Swagger specification
documents
and to controllers. Each operation is migrated in following patches separately.
Please see Mojolicious::Plugin::OpenAPI and its tutorial for more
documentation.

The patch also refactors some API authentication -related code by taking
advantage
of Koha::Exceptions. Authentication is now handled via Mojolicious's
"under->to"
functionality. The actual authentication & authorization checks are moved to
Koha::REST::V1::Auth. Added a HTTP 503 response for when database update is
required, instead of returning an authentication failure as before.

To test:
1. prove t/db_dependent/api/v1/auth.t

Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #60491|0   |1
is obsolete||

--- Comment #12 from Olli-Antti Kivilahti  ---
Created attachment 60838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60838=edit
Bug 18137: Add useful Koha::Exceptions

Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #60490|0   |1
is obsolete||

--- Comment #11 from Olli-Antti Kivilahti  ---
Created attachment 60837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60837=edit
Bug 18137: List Mojolicious::Plugin::OpenAPI as Perl dependency

This patch also upgrades Mojolicious version requirement to 6.40 as it is the
minimum requirement set by Mojolicious::Plugin::OpenAPI.

To test:
1. sudo cpanm Mojolicious::Plugin::OpenAPI@1.10

Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15108] OAI-PMH provider improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #60835|0   |1
is obsolete||

--- Comment #88 from Olli-Antti Kivilahti  ---
Created attachment 60836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60836=edit
Bug 15108 - OAI-PMH provider improvements

Fixed OAI-PMH Server tests to delete any existing issues before deleting
biblios, to delete oai_sets to avoid sets in the responses and to work with
UNIMARC and NORMARC as well as MARC 21.

Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15108] OAI-PMH provider improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108

--- Comment #87 from Olli-Antti Kivilahti  ---
Created attachment 60835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60835=edit
Bug 15108 - OAI-PMH provider improvements

- Fixed date handling to use UTC as specs require.

- Added support for second precision in time stamps.

- Added support for marc21 metadata prefix as recommended in the
  guidelines (synonym for marcxml).

- Improved performance of database queries especially for large
  collections.

- Unified functionality of ListRecords and ListIdentifiers to a common
  base class.

- If items are included in the records, their timestamps are taken into
  account everywhere so that whichever is the most recent (timestamp of
  biblioitem or any of its items) is considered the record's timestamp.

- Fixed OAI.xslt to show correct record range.

- Incorporated extended tests from Bug 17493 and their tweaks from Bug 15108.

Signed-off-by: Josef Moravec 
Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115

Matthias Meusburger  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115

Matthias Meusburger  changed:

   What|Removed |Added

  Attachment #60811|0   |1
is obsolete||

--- Comment #6 from Matthias Meusburger  ---
Created attachment 60834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60834=edit
Bug 18115 - Fix use of Objects as hashref in acqui/addorderiso2709.pl - Bug
15503 followup

Fix use of 'gstrate' for 'tax_rate'

Signed-off-by: Matthias Meusburger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18216] Apache2.4 403 errors for Gitified or git clone installs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18216

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18216] Apache2.4 403 errors for Gitified or git clone installs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18216

--- Comment #1 from Olli-Antti Kivilahti  ---
Created attachment 60833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60833=edit
Bug 18216 - Apache2 grants access to Koha modules and templates

Fixes this install step for dev installs:

https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages#403_errors_for_Gitified_or_git_clone_installs

--SNIP--
 403 errors for Gitified or git clone installs

In Ubuntu 14.04 you may discover that your gitified install returns 403 errors
- this is because of the changes to Apache directory security. A possible fix
includes adding the following stanza to apache2.conf (could be added in the
virtualhost, or in one of the koha-shared*.conf files as well):


 Options Indexes FollowSymLinks
 AllowOverride None
 Require all granted

--SNAP--

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18216] New: Apache2.4 403 errors for Gitified or git clone installs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18216

Bug ID: 18216
   Summary: Apache2.4 403 errors for Gitified or git clone
installs
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: gmcha...@gmail.com
  Reporter: olli-antti.kivila...@jns.fi
QA Contact: testo...@bugs.koha-community.org

Fixes this install step for dev installs:

https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages#403_errors_for_Gitified_or_git_clone_installs

--SNIP--
 403 errors for Gitified or git clone installs

In Ubuntu 14.04 you may discover that your gitified install returns 403 errors
- this is because of the changes to Apache directory security. A possible fix
includes adding the following stanza to apache2.conf (could be added in the
virtualhost, or in one of the koha-shared*.conf files as well):


 Options Indexes FollowSymLinks
 AllowOverride None
 Require all granted

--SNAP--

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

--- Comment #70 from Olli-Antti Kivilahti  ---
Rebased to master.

(In reply to Jonathan Druart from comment #65)
> Can you explain this patch?

Yes.
Without this bad things will happen when caching is used.

Our page load times drop at best 2-4 seconds depending on the env we run Koha.
Better than plack :)


When the Koha-version changes, the urls for all static web-assets dynamically
change to point at the new Koha-version.
This forces the browser to reload new versions of javascript-code.

You cannot really cache static web-content without a way of invalidating the
user's cache, because then after version upgrades, some browsers would use old
javascript code and bad things would happen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215

Magnus Enger  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215

Magnus Enger  changed:

   What|Removed |Added

  Attachment #60823|0   |1
is obsolete||

--- Comment #2 from Magnus Enger  ---
Created attachment 60832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60832=edit
Bug 18215: Resolve warning on $tls in Database.pm

Resolve this warning:
updatedatabase.pl: Use of uninitialized value $tls in string eq at
/usr/share/koha/masterclone/Koha/Database.pm line 63.

Test plan:
[1] Check if you do not see the warning anymore.

Signed-off-by: Magnus Enger 
Warning disappears after applying the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

--- Comment #69 from Olli-Antti Kivilahti  ---
Created attachment 60831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60831=edit
Bug 12904 - Add mod_expire to etc/koha-httpd.conf

Has a positive effect on page loads for crazy dev-installs as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18173] Remove issues.return

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173

Magnus Enger  changed:

   What|Removed |Added

  Attachment #60828|0   |1
is obsolete||

--- Comment #3 from Magnus Enger  ---
Created attachment 60829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60829=edit
Bug 18173: Remove DB field issues.return

The DB field issues.return has never really been used apparently.
I found the first occurrence of this field in
commit eac3a7b19a8aa7cda34aac396f5093c213a4aa5a
CommitDate: Mon Mar 12 22:43:47 2001 +
Database definition file, checked into cvs to make keeping database
current easier

Since I did not find any use of this field.
I guess it can be removed safely.

There is no proper test plan here. Just make sure this field has never
been used.

Signed-off-by: Magnus Enger 
I have not found any use of issues.return or old_issues.return. In
all my live instances the column is always NULL. Issuing and returning
seems to work as expected after the columns have been removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #58395|0   |1
is obsolete||

--- Comment #68 from Olli-Antti Kivilahti  ---
Created attachment 60830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60830=edit
Bug 12904 [QA Followup] - Don't send 301 status

Signed-off-by: Nick Clemens 
Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18173] Remove issues.return

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173

Magnus Enger  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #58394|0   |1
is obsolete||

--- Comment #67 from Olli-Antti Kivilahti  ---
Created attachment 60827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60827=edit
Bug 12904 - Update template css and js file references

Signed-off-by: Nick Clemens 
Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #58393|0   |1
is obsolete||

--- Comment #66 from Olli-Antti Kivilahti  ---
Created attachment 60826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60826=edit
Bug 12904 - Force browser to load new javascript files after upgrade

A common issue with Koha seems to be that the web browsers continue to
use cached js files after an upgrade. If we append the version as a
parameter, we can force the browser to update the javascript files.

1) Apply this patch on a new branch based on master.
2) In a separate branch check out a previous version of Koha and go
   through the installation process on an empty database.
3) After logging into Koha, turn on Firebug's Net panel (or Chrome's
   Network panel) and turn on the filter for JavaScript files.
4) Clear the browser cache and navigate to a page, for instance
   Circulation. In Firebug the Net panel should show a status of "200
   OK" for all files, indicating that the file was downloaded, not
   loaded from the cache. In Chrome the "size" column will show a file
   size if the file was downloaded.
5) Navigate to another page and confirm that scripts are being loaded
   from the cache: Scripts like jquery.js and jquery-ui.js which are
   loaded on every page should have a status in the Firebug Net panel of
   "304 Not Modified." In Chrome the "size" columns should show "from
   cache."
6) Check out the branch you created for testing this patch.
7) In order to preserve the state of your browser cache for accurate
   testing, open a different browser from the one you were previously
   testing with, load Koha, and run through the database update.
8) Return to your original testing browser and navigate to another Koha
   page. Firebug's Net panel should show that script files are now being
   downloaded with a "koha_version" query string. These files should
   have a status of "200 OK" indicating that they are being downloaded,
   not loaded from the cache.
9) Navigate to another page and conifrm that the new versions of the
   scripts are being loaded from the cache.

To confirm that all affected JavaScripts links are working correctly,
test these pages by checking the Firebug Net panel for errors:

- Administration -> Currencies and exchange rates
  (jquery.dataTables.colvis.js)
- Tools -> Stage MARC records for import (ajaxfileupload.js) or another
  page which performs a file upload.
- Catalog -> Detail page -> MARC Preview (greybox JS)
- Help -> Any help page
- Any page which loads DataTables (Circulation in the staff client, for
  instance, and a title's detail page in the OPAC)
- Bonus points if you check the various conditional JS includes
  controlled by the many OPAC feature preferences

Signed-off-by: Nick Clemens 
Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18173] Remove issues.return

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173

Magnus Enger  changed:

   What|Removed |Added

  Attachment #60696|0   |1
is obsolete||

--- Comment #2 from Magnus Enger  ---
Created attachment 60828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60828=edit
Bug 18173: Remove DB field issues.return

The DB field issues.return has never really been used apparently.
I found the first occurrence of this field in
commit eac3a7b19a8aa7cda34aac396f5093c213a4aa5a
CommitDate: Mon Mar 12 22:43:47 2001 +
Database definition file, checked into cvs to make keeping database
current easier

Since I did not find any use of this field.
I guess it can be removed safely.

There is no proper test plan here. Just make sure this field has never
been used.

Signed-off-by: Magnus Enger 
I have not found any use of issues.return or old_issues.return. In
all my live instances the column is always NULL. Issuing and returning
seems to work as expected after the columns have been removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Gustafsson  changed:

   What|Removed |Added

  Attachment #60824|0   |1
is obsolete||

--- Comment #48 from David Gustafsson  ---
Created attachment 60825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60825=edit
Bug 14957 - Rule based permission for MARC fields

Add a rule based permission system for MARC field modifications.

Test plan:
1. Apply this patch
2. Run updatedatabase.pl
3. Log in to staff client
4. Enable new syspref MARCPermissions
5. You should see a new link "MARC field permissions" in the "Catalog"
   section under "Koha administrtion".
6. Go to the "MARC field permissions" page
7. Next to the page heading ("Manage MARC field permissions") there is a
   button with a question mark, click this for more information about the
   rule system.
8. Add desired rules to the rule table, press the +-button to add.
9. Clicking the pen-icon (edit) should allow you to edit corresponding
rule.
10. Clicking the x-icon should remove corresponding rule after
confirmation.
11. Selecting one or more rules followed by clicking the trash-icon
should remove all selected rules after confirmation.
12. To test your rules, import or in other way modify a record.
13. Check that the record was modified as defined by your rules.

Sponsored-by: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #47 from David Gustafsson  ---
Nope, still managed to screw it up. Should be ok now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #46 from David Gustafsson  ---
Screwed up the last merge. Should be fixed now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Gustafsson  changed:

   What|Removed |Added

  Attachment #60711|0   |1
is obsolete||

--- Comment #45 from David Gustafsson  ---
Created attachment 60824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60824=edit
Bug 14957 - Rule based permission for MARC fields

Add a rule based permission system for MARC field modifications.

Test plan:
1. Apply this patch
2. Run updatedatabase.pl
3. Log in to staff client
4. Enable new syspref MARCPermissions
5. You should see a new link "MARC field permissions" in the "Catalog"
   section under "Koha administrtion".
6. Go to the "MARC field permissions" page
7. Next to the page heading ("Manage MARC field permissions") there is a
   button with a question mark, click this for more information about the
   rule system.
8. Add desired rules to the rule table, press the +-button to add.
9. Clicking the pen-icon (edit) should allow you to edit corresponding
rule.
10. Clicking the x-icon should remove corresponding rule after
confirmation.
11. Selecting one or more rules followed by clicking the trash-icon
should remove all selected rules after confirmation.
12. To test your rules, import or in other way modify a record.
13. Check that the record was modified as defined by your rules.

Sponsored-by: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18202] Define profiles for Z39.50 server targets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18202

--- Comment #1 from Marcel de Rooy  ---
Not for this specific issue, but note that we have defined a field for SRU
search mappings in the z3950servers table. If you add a new SRU server, you can
open the admin/sru_modmapping.pl form.
This sounds like something similar for Z3950.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215

--- Comment #1 from Marcel de Rooy  ---
Created attachment 60823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60823=edit
Bug 18215: Resolve warning on $tls in Database.pm

Resolve this warning:
updatedatabase.pl: Use of uninitialized value $tls in string eq at
/usr/share/koha/masterclone/Koha/Database.pm line 63.

Test plan:
[1] Check if you do not see the warning anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18215] New: Resolve warning on $tls in Database.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215

Bug ID: 18215
   Summary: Resolve warning on $tls in Database.pm
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

updatedatabase.pl: Use of uninitialized value $tls in string eq at
/usr/share/koha/masterclone/Koha/Database.pm line 63.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214

Magnus Enger  changed:

   What|Removed |Added

  Attachment #60821|0   |1
is obsolete||

--- Comment #2 from Magnus Enger  ---
Created attachment 60822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60822=edit
Bug 18214: Cannot edit list permissions of a private list

If you have disabled the pref OpacAllowPublicListCreation, your users are
not able to edit the list permissions for private/shared lists.
For a private list they may only be theoretically relevant, but for a shared
list they are relevant.
Since we do not always know the history of a list (has it been public or
shared, does it contains entries from other users) and therefore permissions
are even relevant for a currently private list, we should just allow editing
these permissions.

Test plan:
[1] Do not yet apply this patch.
[2] Disable OpacAllowPublicListCreation.
[3] Create a private list in OPAC. Edit the list. Verify that you do not
see the permission combo boxes.
[4] Apply this patch. Edit the list again. Do they appear now?

Signed-off-by: Marcel de Rooy 
Signed-off-by: Magnus Enger 
Works as advertised.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214

Magnus Enger  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13913] Renewal error message in OPAC is confusing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13913

Katrin Fischer  changed:

   What|Removed |Added

Summary|Renewal error message in|Renewal error message in
   |OPAC is not correct |OPAC is confusing

--- Comment #2 from Katrin Fischer  ---
We have another report on this.

Currently, all reasons why a renewal failed are listed as unformatted text and
it's very hard to see, which message applies to which checkout. We shoudl fix
this to show the specific reasons with the issues and only a general message on
top.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18210] Allow API to update/ merge bibliographic records & not just replace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18210

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=14957

--- Comment #1 from Magnus Enger  ---
(In reply to Cab Vinton from comment #0)
> This would require a means of identifying fields that are protected from
> overlay on import.

Have you looked at "Bug 14957 - Write protecting MARC fields based on source of
import"?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Magnus Enger  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18210

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214

--- Comment #1 from Marcel de Rooy  ---
Created attachment 60821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60821=edit
Bug 18214: Cannot edit list permissions of a private list

If you have disabled the pref OpacAllowPublicListCreation, your users are
not able to edit the list permissions for private/shared lists.
For a private list they may only be theoretically relevant, but for a shared
list they are relevant.
Since we do not always know the history of a list (has it been public or
shared, does it contains entries from other users) and therefore permissions
are even relevant for a currently private list, we should just allow editing
these permissions.

Test plan:
[1] Do not yet apply this patch.
[2] Disable OpacAllowPublicListCreation.
[3] Create a private list in OPAC. Edit the list. Verify that you do not
see the permission combo boxes.
[4] Apply this patch. Edit the list again. Do they appear now?

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18214] New: Cannot edit list permissions of a private list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214

Bug ID: 18214
   Summary: Cannot edit list permissions of a private list
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Lists
  Assignee: gmcha...@gmail.com
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

If you have disabled the pref OpacAllowPublicListCreation, your users are not
able to edit the list permissions for private/shared lists.
For a private list they may only be theoretically relevant, but for a shared
list they are relevant.
Since we do not always know the history of a list (has it been public or
shared, does it contains entries from other users) and therefore permissions
are even relevant for a currently private list, we should just allow editing
these permissions.
Trivial change in opac-shelves template. No need to change staff side.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5763] Add users private list management functionality for administrators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5763

Marcel de Rooy  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5763] Add users private list management functionality for administrators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5763

Marcel de Rooy  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #9 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #8)
> There is now a way to delete public lists covered by a separate permission.

We can close this bug now. See bug 13417.

*** This bug has been marked as a duplicate of bug 13417 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417

Marcel de Rooy  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #48 from Marcel de Rooy  ---
*** Bug 5763 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310
Bug 7310 depends on bug 5763, which changed state.

Bug 5763 Summary: Add users private list management functionality for 
administrators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5763

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/