[Koha-bugs] [Bug 17346] Enable the check in option in Columns settings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242

Chris Cormack  changed:

   What|Removed |Added

  Attachment #60973|0   |1
is obsolete||

--- Comment #7 from Chris Cormack  ---
Created attachment 61057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61057=edit
Bug 18242: [SOLUTION 2]Handle correctly move to old_issues

The table old_issues has a primary key defined on the issue_id column.
This issue_id comes from the issues table when an item is checked in.

In some case the value of issue_id already exists in the table

Basically this happens when an item is returned and mysqld is restarted:
The auto increment value for issues.issue_id will be reset to
MAX(issue_id)+1 (which is the value of the last entry of old_issues).
See also the description of bug 18003 for more informations.

In this solution the change is done at code level instead of DB
structure: If old_issues.issue_id already exists before moving from
the issues table, the issue_id is updated (not on cascade for
accountlines.issue_id, should it?) before the move.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242

Chris Cormack  changed:

   What|Removed |Added

  Attachment #60969|0   |1
is obsolete||
  Attachment #60970|0   |1
is obsolete||
  Attachment #60971|0   |1
is obsolete||
  Attachment #60972|0   |1
is obsolete||

--- Comment #6 from Chris Cormack  ---
Created attachment 61056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61056=edit
Bug 18242: [SOLUTION 2]Add tests

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243

--- Comment #5 from Srdjan Jankovic  ---
Apologies for the late submission.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243

--- Comment #4 from Srdjan Jankovic  ---
Created attachment 61055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61055=edit
Bug 18243: 16034 follow-up: Conditionally test Koha::ExternalContent::* modules
loading

To test:
1 - Make sure you don't have WebService::ILS installed
2 - prove t/00-load.t
3 - You should get a failure to load module and tests are skipped
4 - Apply patch
5 - prove t/00-load.t
6 - Module is not loaded, test are skipped
Optional:
7 - Install WebService::ILS
5 - prove t/00-load.t
6 - Module is loaded, test passes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Passed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262

--- Comment #1 from Jonathan Druart  
---
Created attachment 61054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61054=edit
Bug 18262: Koha::Biblio - Remove GetBiblioData - part 1

Most of the time C4::Biblio::GetBiblioData is used to retrieve the title
and/or the author of a bibliographic record.

This patch replaces the easy occurrences of GetBiblioData, the ones
where the 2 joins are needed, but only data from biblio and biblioitems
table are.

Test plan:
It will be hard to test everything, I'd suggest a QAer to review this
patch and confirm that the difference occurrences of GetBiblioData have
been correctly replaced by calling Koha::Biblios->find or
$biblio->bibioitem

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17628


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628
[Bug 17628] Move bibliographic related code to Koha::Biblio
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17628] Move bibliographic related code to Koha::Biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||18262

--- Comment #5 from Jonathan Druart  
---
Bug 18262 - Koha::Biblios - Remove GetBiblioData - part 1


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262
[Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18261] New: Select item type not available when staff overrides hold policy

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18261

Bug ID: 18261
   Summary: Select item type not available when staff overrides
hold policy
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: andreas.hedstrom.m...@sub.su.se
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

With AllowHoldItemTypeSelection set to Allow, it is possible to select an item
type to fill the hold. But when staff overrides a circulation policy, the
”Request specific item type” dropdown on the place hold page only lists ”Any
item type”, even if there are several items with various item types attached to
the bibliographic record. We believe this to be a bug.

To reproduce:
Set AllowHoldItemTypeSelection to Allow.
Set AllowHoldPolicyOverride to Allow.
Create/choose a circulation rule for a patron category of your choice, allow
holds and set On shelf holds allowed to ”If all unavailable”.
Find or create a bibliographic record with two or more items, with two or more
item types.
Check out one item.
Place a hold using the patron category for which you specified the circulation
rule above. This should result in a staff override as this behaviour should not
be allowed by the circulation policy.
Try to request a specific item type, and confirm that choosing an item type is
not available, the only option being ”Any item type”.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260

--- Comment #1 from Jonathan Druart  
---
Created attachment 61053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61053=edit
Bug 18260: Koha::Biblio - Remove GetBiblio

C4::Biblio::GetBiblio can be replaced with Koha Biblio->find

Test plan:
Import batch, view issue history, search for items, see the image of a
bibliographic record, modify and delete records in a batch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13259] Set notforloan status when adding items to a course reserve

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13259

Alexandre  changed:

   What|Removed |Added

 CC||alexandre.bre...@ccsr.qc.ca

--- Comment #1 from Alexandre  ---
I was creating a new bug when I found an old one from my work partner... I
decided to put my notes here as a supplement.

Alternative title:
Adding alerts when loaning a record from a course reserve

When the staff put a record in a course reserve (with his barcode for example),
the record stay avalable for loan. It must be corrected in a second step for
which not all the staff are allowed to do it. Can we add an option "not for
loan" when we transfer a record in a reserve ? (It will eliminate a step and
some errors possibilities as it's not the same people making the 2 steps. Also,
some items may be loaned by error when they are put in a course reserve.

Path :
1) Go to "Course reserves" module
2) Select a course
3) Clic on "Add reserves"
4) On "Add items : scan barcode", I use "02500141x" because I know we already
have in the system (put one that you are sure to have)
5) Select the record you entered in the reserve
6) Observe that no option are creating a "not for loan" status ($7) for the
record, even if they are put in a reserve, they still available

Then, we must change the status "not for loan" manually in a second step (with
some upper staff rights).

I see some solutions for this :
- Add a dropdown menu linked to autorized values from NOT_LOAN function ($7) or
at least, a "not for loan" option (y/n) on the same page
- A alert message in a yellow square informing the user that he is about to
loan a record in the reserve (with y/n)
- All records put in a reserve will automatically have the "not for loan"
status (This status will then return automatically to 0 value when the record
exit the reserve.)

Also, one of our users said that before around v3.12, when we are doing a loan
from a reserve, we receive an alert "Are you sure you want to loan this record
y/n ?" (or something like this.). But now, this message doesn't appears all the
time (just when $7 was modified after the first step).

Thanks all,

Alexandre from CCSR

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17628] Move bibliographic related code to Koha::Biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||18260

--- Comment #4 from Jonathan Druart  
---
Bug 18260 - Koha::Biblio - Remove GetBiblio


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260
[Bug 18260] Koha::Biblio - Remove GetBiblio
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17628


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628
[Bug 17628] Move bibliographic related code to Koha::Biblio
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||18256


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256
[Bug 18256] Koha::Biblio - Remove GetItemsCount
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18260


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260
[Bug 18260] Koha::Biblio - Remove GetBiblio
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18260] New: Koha::Biblio - Remove GetBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260

Bug ID: 18260
   Summary: Koha::Biblio - Remove GetBiblio
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

C4::Biblio::GetBiblio can be replaced with Koha::Biblios->find

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18249] Typo "resrerves" in en-NZ translation files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18249

--- Comment #3 from Aleisha Amohia  ---
Oh I see, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #61049|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 61052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61052=edit
Bug 18256: Koha::Items - Remove GetItemsCount

C4::Items::GetItemsCount can be replaced with Koha::Biblio->items->count

Test plan:
Create a bibliographic record with items attached
Try to delete the record from a basket (acquisition module), the detail
page and the batch item deletion tool.

=> You should not be able to delete it.

Remove the items and then try again to delete the record

=> Now you must be able to delete it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17708] Renewal log seems empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17708

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259

--- Comment #1 from Jonathan Druart  
---
Created attachment 61051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61051=edit
Bug 18259: Koha::Biblio - Remove GetSubscriptionsId

C4::Biblio::GetSubscriptionsId can be replaced using
Koha::Biblio->subscriptions

Test plan:
Create a new order for a bibliographic record
Create a new subscription on this biblio
>From the basket (acquisition), confirm that you are not able to delete
the order with the biblio ("Can't cancel order and delete catalog record
1 subscription(s) left")
Receive the order
On the parcel page, confirm that you are not able to delete the order
with the biblio

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18259


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259
[Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||18256


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256
[Bug 18256] Koha::Biblio - Remove GetItemsCount
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||18258


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18258
[Bug 18258] Add the Koha::Biblio->subscriptions method
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18258] Add the Koha::Biblio->subscriptions method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18258

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18259


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259
[Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17628


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628
[Bug 17628] Move bibliographic related code to Koha::Biblio
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17628] Move bibliographic related code to Koha::Biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||18259

--- Comment #3 from Jonathan Druart  
---
Bug 18259 - Koha::Biblio - Remove GetSubscriptionsId


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259
[Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18259] New: Koha::Biblio - Remove GetSubscriptionsId

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259

Bug ID: 18259
   Summary: Koha::Biblio - Remove GetSubscriptionsId
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

C4::Biblio::GetSubscriptionsId can be replaced using
Koha::Biblio->subscriptions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18258] Add the Koha::Biblio->subscriptions method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18258

--- Comment #1 from Jonathan Druart  
---
Created attachment 61050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61050=edit
Bug 18258: Add the Koha::Biblio->subscriptions method

Test plan:
  prove t/db_dependent/Koha/Biblios.t
should return green

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18258] Add the Koha::Biblio->subscriptions method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18258

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18258] New: Add the Koha::Biblio->subscriptions method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18258

Bug ID: 18258
   Summary: Add the Koha::Biblio->subscriptions method
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18217] SMS alert number should be grouped with other borrower contact information.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18217

--- Comment #2 from Barton Chittenden  ---
(In reply to Owen Leonard from comment #1)
> I don't know how easy it would be to implement, but shouldn't we instead
> offer an option to specify one of the existing phone numbers (primary,
> secondary, other) as the SMS alert number?
> 
> Could this be combined with Bug 11879?

maybe a drop down... along the lines of

SMS Alert Number [ [ Use Primary   ] ]
   [ Use Secondary ]
   [ Use Other ]
   [ Enter SMS Number |  | ]

?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18257] New: Column visibility button does not increase colspan properly with pre-hidden columns

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18257

Bug ID: 18257
   Summary: Column visibility button does not increase colspan
properly with pre-hidden columns
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When toggling a column that is hidden by default in circulation.pl and
moremember.pl, the "Today's checkouts" and "Previous checkouts" cells do not
expand correctly.

To test:
1) Go to circulation.pl and checkout an item.
2) Hide a column.  See that the "Today's checkouts" cell is the correct length.
3) Show the hidden column.  See that the cell is still the correct length.
4) Go to columns_settings.pl --> issues-table and hide one of the columns by
default.
5) Go back to circulation.pl and show that hidden column.  See that the
"Today's checkouts" cell is shorter than the row.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #61048|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  
---
Created attachment 61049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61049=edit
Bug 18256: Koha::Items - Remove GetItemsCount

C4::Items::GetItemsCount can be replaced with Koha::Biblio->items->count

Test plan:
Create a bibliographic record with items attached
Try to delete the record from a basket (acquisition module), the detail
page and the batch item deletion tool.

=> You should not be able to delete it.

Remove the items and then try again to delete the record

=> Now you must be able to delete it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256

--- Comment #1 from Jonathan Druart  
---
Created attachment 61048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61048=edit
Bug 18256: Koha::Items - Remove GetItemsCount

C4::Items::GetItemsCount can be replaced with Koha::Biblio->items->count

Test plan:
Create a bibliographic record with items attached
Try to delete the record from a basket (acquisition module), the detail
page and the batch item deletion tool.

=> You should not be able to delete it.

Remove the items and then try again to delete the record

=> Now you must be able to delete it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17628


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628
[Bug 17628] Move bibliographic related code to Koha::Biblio
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17628] Move bibliographic related code to Koha::Biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||18256

--- Comment #2 from Jonathan Druart  
---
Bug 18256 - Koha::Biblio - Remove GetItemsCount


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256
[Bug 18256] Koha::Biblio - Remove GetItemsCount
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18256] New: Koha::Biblio - Remove GetItemsCount

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256

Bug ID: 18256
   Summary: Koha::Biblio - Remove GetItemsCount
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

Lari Taskula  changed:

   What|Removed |Added

  Attachment #61045|0   |1
is obsolete||

--- Comment #41 from Lari Taskula  ---
Created attachment 61047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61047=edit
Bug 7534: Check hold availability to desired pickup location in opac-reserve.pl

To test:
-1. Have access to your browser's developer tools in order to modify 
dropdown values
1. Go to cgi-bin/koha/admin/branches.pl
2. Configure one of your libraries to "Pickup location" => "No". Remember the
   branchcode of this library!
3. Go place a hold in OPAC
4. See the provided "Pick up location" list
5. Observe the library that you configured is not present in the list
6. You should see another library selected by default. Right click that and
   in Firefox/Chrome click "Inspect element"
7. You should see a list of blabla elements
8. Double click between value ( in above example) and replace the value
   with the branchcode you remember from step 2.
9. Place the hold
10. Observe that you are taken to cgi-bin/koha/opac-user.pl but your hold
was not successful.
11. Go back to place a hold and this time do not modify any values.
12. Observe that a hold is now placed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

Lari Taskula  changed:

   What|Removed |Added

  Attachment #61044|0   |1
is obsolete||

--- Comment #40 from Lari Taskula  ---
Created attachment 61046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61046=edit
Bug 7534: Validate pickup location in CanBook/ItemBeReserved

This patch adds $branchcode_to parameter to CanBookBeReserved and
CanItemBeReserved. It represents the pickup location for the hold.

To test:
1. prove t/db_dependent/Holds.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17346] Enable the check in option in Columns settings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346

Christopher Brannon  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #7 from Christopher Brannon  ---
Please QA again.  It appears this is a pre-existing condition, and will happen
with any column that is hidden by default and then toggled on.

I will open a new ticket for this condition.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

Lari Taskula  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #39 from Lari Taskula  ---
(In reply to Jonathan Druart from comment #36)
> Lari, I think we need a check server-side to make sure a patron will not
> inject a library that is not in the list.

Agreed. This was done in Bug 7614, but as it should be already in this Bug, I
took the patches from 7614 and rewrote them to be suitable in 7534.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

--- Comment #38 from Lari Taskula  ---
Created attachment 61045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61045=edit
Bug 7534: Check hold availability to desired pickup location in opac-reserve.pl

To test:
-1. Have access to your browser's developer tools in order to modify 
dropdown values
1. Go to cgi-bin/koha/admin/branches.pl
2. Configure one of your libraries to "Pickup location" => "No". Remember the
   branchcode of this library!
3. Go place a hold in OPAC
4. See the provided "Pick up location" list
5. Observe the library that you configured is not present in the list
6. You should see another library selected by default. Right click that and
   in Firefox/Chrome click "Inspect element"
7. You should see a list of blabla elements
8. Double click between value ( in above example) and replace the value
   with the branchcode you remember from step 2.
9. Place the hold
10. Observe that you are taken to cgi-bin/koha/opac-user.pl but your hold
was not successful.
11. Go back to place a hold and this time do not modify any values.
12. Observe that a hold is now placed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

--- Comment #37 from Lari Taskula  ---
Created attachment 61044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61044=edit
Bug 7534: Validate pickup location in CanBook/ItemBeReserved

This patch adds $branchcode_to parameter to CanBookBeReserved and
CanItemBeReserved. It represents the pickup location for the hold.

To test:
1. prove t/db_dependent/Holds.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18217] SMS alert number should be grouped with other borrower contact information.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18217

--- Comment #1 from Owen Leonard  ---
I don't know how easy it would be to implement, but shouldn't we instead offer
an option to specify one of the existing phone numbers (primary, secondary,
other) as the SMS alert number?

Could this be combined with Bug 11879?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18255] Koha::Biblio - Remove GetBiblioItemByBiblioNumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18255

--- Comment #1 from Jonathan Druart  
---
Created attachment 61043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61043=edit
Bug 18255: WIP

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18255] Koha::Biblio - Remove GetBiblioItemByBiblioNumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18255

--- Comment #2 from Jonathan Druart  
---
Waiting for an answer from the mailing list -
http://lists.koha-community.org/pipermail/koha-devel/2017-March/043530.html

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17628] Move bibliographic related code to Koha::Biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||18255

--- Comment #1 from Jonathan Druart  
---
Bug 17629 - Koha::Biblio - Remove ModBiblioframework

Bug 17631 - Koha::Biblio - Remove GetHolds

Bug 18255 - Koha::Biblio - Remove GetBiblioItemByBiblioNumber


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18255
[Bug 18255] Koha::Biblio - Remove GetBiblioItemByBiblioNumber
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18255] Koha::Biblio - Remove GetBiblioItemByBiblioNumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18255

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17628


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628
[Bug 17628] Move bibliographic related code to Koha::Biblio
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18255] New: Koha::Biblio - Remove GetBiblioItemByBiblioNumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18255

Bug ID: 18255
   Summary: Koha::Biblio - Remove GetBiblioItemByBiblioNumber
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16461] Add some information (branch and barcode) in fine description for overdue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
 QA Contact|testo...@bugs.koha-communit |alex.arn...@biblibre.com
   |y.org   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16461] Add some information (branch and barcode) in fine description for overdue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #52052|0   |1
is obsolete||

--- Comment #7 from Alex Arnaud  ---
Created attachment 61042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61042=edit
Bug 16461 - Add branch and barcode in accountline table for overdues

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7614] Branch transfer limit and holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Lari Taskula  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #16 from Lari Taskula  ---
(In reply to Koha Team AMU from comment #13)
> I tried to test in sandbox but failed : 

Hi and thanks for testing! This patch set is not rebased yet on top of Bug 7534
as it is currently going through some changes in QA process. I will rebase
these patches once Bug 7534 passes QA.

(In reply to Olli-Antti Kivilahti from comment #14)
> Created attachment 60938 [details] [review]
> Bug 7614 - Fix my variable earlier declaration bug.
(In reply to Olli-Antti Kivilahti from comment #15)
> Created attachment 60946 [details] [review]
> Bug 7614 - Fixes "Looks like you planned 61 tests but ran 62" at
> t/db_dependent/Holds.t

Thanks Olli-Antti!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

--- Comment #25 from Lari Taskula  ---
(In reply to Mirko Tietgen from comment #24)
> I submitted Mojolicious::Plugin::OpenAPI to Debian a few days ago (1.10).
> 1.13 is out by now. And both versions depend on versions of
> libjson-validator-perl not yet in Debian unstable, and the tests in the
> latest version are broken.
Thanks for looking at this Mirko! 

I had a look at JSON::Validator version 0.96. There indeed seemed to be some
issues with the tests in the latest version. I noticed there is a commit to
json-validator in GitHub as well as some IRC discussion in #swagger
@irc.perl.org suggesting that tests are broken on an older version of
Test::More. Using the latest version of Test::More passes the tests. I tested
an older version of Test::More (1.001014) and tests are indeed failing:

$ sudo cpanm Test::More@1.001014
--> Working on Test::More
Fetching
http://backpan.perl.org/authors/id/E/EX/EXODIST/Test-Simple-1.001014.tar.gz ...
OK
Configuring Test-Simple-1.001014 ... OK
Building and testing Test-Simple-1.001014 ... OK
Successfully installed Test-Simple-1.001014 (downgraded from 1.302078)
1 distribution installed
$ prove t
..
..
Test Summary Report
---
t/acceptance.t   (Wstat: 0 Tests: 265 Failed: 0)
  TODO passed:   45-47, 49-52, 56-57
t/jv-formats.t   (Wstat: 256 Tests: 28 Failed: 1)
  Failed test:  27
  Non-zero exit status: 1
t/jv-object.t(Wstat: 256 Tests: 19 Failed: 1)
  Failed test:  18
  Non-zero exit status: 1
t/openapi-formats.t  (Wstat: 512 Tests: 24 Failed: 2)
  Failed tests:  12, 22
  Non-zero exit status: 2
t/openapi-response.t (Wstat: 0 Tests: 7 Failed: 0)
  TODO passed:   1
t/openapi.t  (Wstat: 0 Tests: 8 Failed: 0)
  TODO passed:   1
Files=44, Tests=558, 11 wallclock secs ( 0.24 usr  0.06 sys +  9.82 cusr  1.04
csys = 11.16 CPU)
Result: FAIL

Whereas the new version passes:

$ sudo cpanm Test::More
--> Working on Test::More
Fetching
http://www.cpan.org/authors/id/E/EX/EXODIST/Test-Simple-1.302078.tar.gz ... OK
Configuring Test-Simple-1.302078 ... OK
Building and testing Test-Simple-1.302078 ... OK
Successfully installed Test-Simple-1.302078 (upgraded from 1.001014)
1 distribution installed
$ prove t
..
..
All tests successful.

Test Summary Report
---
t/acceptance.t   (Wstat: 0 Tests: 265 Failed: 0)
  TODO passed:   45-47, 49-52, 56-57
t/jv-object.t(Wstat: 0 Tests: 19 Failed: 0)
  TODO passed:   9
t/openapi-formats.t  (Wstat: 0 Tests: 24 Failed: 0)
  TODO passed:   7, 10-11
t/openapi-response.t (Wstat: 0 Tests: 7 Failed: 0)
  TODO passed:   1
t/openapi.t  (Wstat: 0 Tests: 8 Failed: 0)
  TODO passed:   1
Files=44, Tests=558, 12 wallclock secs ( 0.23 usr  0.08 sys + 10.66 cusr  1.12
csys = 12.09 CPU)
Result: PASS

Could this be related to the issue you were having with the tests?

Anyway, as a side note to comment #18, Mojolicious::Plugin::OpenAPI 1.13 has a
requirement for JSON::Validator 0.95, which is not enough for us. We need
JSON::Validator 0.96 or newer. It will be a requirement in currently unreleased
Mojolicious::Plugin::OpenAPI version 1.14. Should we wait for that or
explicitly define requirement for JSON::Validator 0.96 in PerlDependencies.pm?

What comes to Mojolicious - I've attempted to run our REST API on Mojolicious
7.26 and so far it seems ok. Tests are also passing for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18254] Remove C4::Items:: GetItemsByBiblioitemnumber call from additem.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18254

--- Comment #1 from Jonathan Druart  
---
Created attachment 61041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61041=edit
Bug 18254: Remove call to GetItemsByBiblioitemnumber call from additem.pl

The code from additem to delete all the items of a bibliographic record
is very ackward.
This patch simplifies the algorithm and make the code more readable.

Test plan:
Remove all the items of a bibliographic records
If at least 1 item is checked out you should get an error.

No change with the current behavior is expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18254] Remove C4::Items:: GetItemsByBiblioitemnumber call from additem.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18254

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18254] Remove C4::Items:: GetItemsByBiblioitemnumber call from additem.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18254

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18253


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18253
[Bug 18253] Remove C4::Items::GetItemsByBiblioitemnumber
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18253] Remove C4::Items::GetItemsByBiblioitemnumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18253

--- Comment #1 from Jonathan Druart  
---
There are only 2 calls, first on is in additem.pl

Bug 18254 - Remove C4::Items::GetItemsByBiblioitemnumber call from additem.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18253] Remove C4::Items::GetItemsByBiblioitemnumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18253

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||18254


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18254
[Bug 18254] Remove C4::Items::GetItemsByBiblioitemnumber call from additem.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18254] New: Remove C4::Items:: GetItemsByBiblioitemnumber call from additem.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18254

Bug ID: 18254
   Summary: Remove C4::Items::GetItemsByBiblioitemnumber call from
additem.pl
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18252] Move C4::Items code to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||18253

--- Comment #1 from Jonathan Druart  
---
Bug 18253 - Remove C4::Items::GetItemsByBiblioitemnumber


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18253
[Bug 18253] Remove C4::Items::GetItemsByBiblioitemnumber
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18253] Remove C4::Items::GetItemsByBiblioitemnumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18253

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18252


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252
[Bug 18252] Move C4::Items code to the Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18253] New: Remove C4::Items::GetItemsByBiblioitemnumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18253

Bug ID: 18253
   Summary: Remove C4::Items::GetItemsByBiblioitemnumber
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

This subroutine does too many things, we could use existing method from the
Koha namespace to achieve the same goal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||18252

--- Comment #19 from Jonathan Druart  
---
Bug 18252 - Move C4::Items code to the Koha namespace


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252
[Bug 18252] Move C4::Items code to the Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18252] Move C4::Items code to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15449


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449
[Bug 15449] Move stuffs to the Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18252] New: Move C4::Items code to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252

Bug ID: 18252
   Summary: Move C4::Items code to the Koha namespace
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16732] Add audio alerts (custom sound notifications) to web based self checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732

Nick Clemens  changed:

   What|Removed |Added

 Blocks||18251


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251
[Bug 18251] SCO alerts - need a trigger for successful checkouts
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251

Nick Clemens  changed:

   What|Removed |Added

 Depends on||16732


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732
[Bug 16732] Add audio alerts (custom sound notifications) to web based self
checkout
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17346] Enable the check in option in Columns settings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346

--- Comment #6 from Christopher Brannon  ---
(In reply to Jonathan Druart from comment #5)
> I finally remember why the action columns were not modifiable.
> There is something wrong happening if you select checkin hidden by default
> and can be toggled.
> When you show it, the tr element "Today's checkouts" does not display
> correctly. 
> 
> Not sure how to fix that cleanly...

I will look into it, but if I can't find a resolution, at least we can still
lock the option to toggle it.  That would be a reasonable compromise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14150] Field issues.date_due does not display in ISSUESLIP or ISSUEQSLIP

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14150

--- Comment #8 from Christopher Brannon  ---
On further inspection, it appears that in 3.22.8, issues.date_due shows the
date but not the time.  In master, I see that issues.date_due includes the time
as well.  Can't find the bug that changed this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
It seems that replacement price is ok before this patch, and the patch does not
affect it. Should we rename the bug report and the commit msg?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18251] New: SCO alerts - need a trigger for successful checkouts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251

Bug ID: 18251
   Summary: SCO alerts - need a trigger for successful checkouts
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Self checkout
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Failed checkouts on the sco can be triggered by presence of alert, however, we
have no feedback for a successful checkout.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14150] Field issues.date_due does not display in ISSUESLIP or ISSUEQSLIP

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14150

--- Comment #7 from Christopher Brannon  ---
(In reply to Katrin Fischer from comment #6)
> I did some more tests - this problem appears in 3.18.6, but is fixed on the
> current 3.18.x branch, that will be 3.18.7.

Katrin,
Please confirm with master.  I am in 3.22, and I see that issues.date_due is
producing a date, but I do not see a time stamp.  Shouldn't this value produce
a timestamp for hourly loans, or do hourly loans have to be turned on in order
for it to produce a time stamp?

Christopher

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251

--- Comment #1 from Nick Clemens  ---
Created attachment 61040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61040=edit
Bug 18251 - SCO alerts - need a trigger for successful checkouts

This patch adds simple text and a div to allow for sounds to be
configured upon successful SCO checkout

To test:
1 - Enable sco module
2 - Enable AudioAlerts
3 - Define alert with
 Selector: .sco-alert-success
 Sound:http://localhost:8081/intranet-tmpl/prog/sound/opening.ogg
4 - Checkout to patron using SCO
5 - Note only feedback is a addition of item to checkouts list
6 - Apply patch
7 - Checkout ot patron via SCO
8 - You should hear the sound specified above
9 - You should also see a note: Item checked out

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243

Jonathan Druart  changed:

   What|Removed |Added

   Severity|enhancement |normal
  Component|OPAC|Test Suite
   Assignee|oleon...@myacpl.org |srd...@catalyst.net.nz
 QA Contact|testo...@bugs.koha-communit |gmcha...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #61017|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 61039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61039=edit
Bug 18243: 16034 follow-up: better handling of absence of
WebService::ILS::OverDrive::Patron at testing

To test:
1 - Make sure you don't have WebService::ILS::OverDrive::Patron
installed
2 - prove t/Koha_ExternalContent_OverDrive.t
3 - You should get a failure to load module and tests are skipped
4 - Apply patch
5 - prove t/Koha_ExternalContent_OverDrive.t
6 - Module is not loaded, test are skipped

Fixed small typo 'cannot filnd' -> 'cannot find'
Signed-off-by: Nick Clemens 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17346] Enable the check in option in Columns settings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #5 from Jonathan Druart  
---
I finally remember why the action columns were not modifiable.
There is something wrong happening if you select checkin hidden by default and
can be toggled.
When you show it, the tr element "Today's checkouts" does not display
correctly. 

Not sure how to fix that cleanly...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18250] koha-common should start after memcached

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250

--- Comment #11 from Mirko Tietgen  ---
To avoid workarounds, we could just make memcached mandatory. It is widely
available in Debian versions. Feels like a cleaner approach to me. Any reasons
not to do it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18219


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219
[Bug 18219] "Not checked out." problem message displays twice on local use.
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #60908|0   |1
is obsolete||
  Attachment #60910|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 61037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61037=edit
Bug 18219: Remove duplicated code in returns.tt

Removed lines of code that were duplicated in bug 16530.
Fixes alignment of a few lines of code surrounding duplication.

Modifies returns.tt

To test:
1) Check in items that are not checked out.
2) Note duplicated problem message (i.e. "Not checked out.")
3) Apply patch.
4) Repeat step 1.
5) Note the problem message is no longer duplicated.

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||16530


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530
[Bug 16530] Add a circ sidebar navigation menu
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219

--- Comment #9 from Jonathan Druart  
---
Created attachment 61038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61038=edit
Bug 18219: Remove extra whitespace from returns.tt

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18200] Fix a potential issue with preceding space in GetMarcUrls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18200

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18200] Fix a potential issue with preceding space in GetMarcUrls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18200

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #60808|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 61036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61036=edit
Bug 18200: Fix a potential issue with preceding space in GetMarcUrls

Trims the URL in order prevent prefixing a space with http://
Normally you won't have a preceding space here, but I saw it happening
one day and it does not cost much to resolve it.

Bonus: Adding few simple tests in t/db_dependent/Biblio.t.

Test plan:
[1] Run t/db_dependent/Biblio.t
[2] Add a 856$u with preceding space (MARC21)
[3] Check opac-detail, Online access with OPACXSLTDetailsDisplay empty.

Signed-off-by: Marcel de Rooy 

Followed test plan, works as expected
Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18250] koha-common should start after memcached

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250

--- Comment #10 from Marcel de Rooy  ---
So far my proposals; this report now first needs some feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18250] koha-common should start after memcached

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250

--- Comment #9 from Marcel de Rooy  ---
Or should we do in postinst:

if memcached_is_installed
if memcached_not_yet_in_lsb_header
add to init.d/koha-common
disable, enable
fi
fi

That way we would only do the reshuffle once..

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #36 from Jonathan Druart  
---
Lari, I think we need a check server-side to make sure a patron will not inject
a library that is not in the list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18250] koha-common should start after memcached

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250

--- Comment #8 from Marcel de Rooy  ---
Tested a notexisting service with disable/enable:

insserv: Service notexistingservice has to be enabled to start service
koha-common
insserv: exiting now!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18250] koha-common should start after memcached

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250

--- Comment #7 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #3)
> (In reply to Mirko Tietgen from comment #2)
> > Memcached is optional for Koha. What happens with this patch if it is not
> > installed?
> 
> True. We need to take care of that too.

Maybe an easy way out here is the $all-approach in insserv? (Start after
anything else..) Or removing the memcached from init.d with sed when there is
no memcached. Only problem there: what happens if someone installs memcached
later?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17098] Validation problems with form field type "number" ( decimal separator)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17098

--- Comment #7 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #6)
> If we simply replace type="number" with type="text", we will reintroduce bug
> 2542.

That could work using the pattern attribute indeed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17098] Validation problems with form field type "number" ( decimal separator)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17098

--- Comment #6 from Jonathan Druart  
---
If we simply replace type="number" with type="text", we will reintroduce bug
2542.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/