[Koha-bugs] [Bug 6473] Test bug for Git-bz

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Mason James  changed:

   What|Removed |Added

 CC|m...@kohaaloha.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #116 from David Cook  ---
(In reply to Sebastian Hierl from comment #115)
> We are interested as well and I trust that there are many more Koha
> libraries who would like to update their data via OAI-PMH.  Thank you,
> Sebastian

Glad to hear it! I hope the end result works well for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18269] Move field mappings related code to Koha::FieldMapping[s]

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269

--- Comment #2 from Jonathan Druart  
---
Created attachment 61092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61092=edit
Bug 18269: Move field mappings related code to Koha::FieldMapping[s]

The 3 subroutines GetFieldMapping, SetFieldMapping and
DeleteFieldMapping from the C4::Biblio module were only used from the
field mappings admin page.
They can easily replaced with new packages Koha::FieldMappings based on
Koha::Object[s]

Test plan:
Add and delete field mappings (admin/fieldmapping.pl, Home ›
Administration › Keyword to MARC mapping).
Add an existing mapping > Nothing should be added

Note that this page has not been rewritten and you will not get any
feedbacks, but it's not the goal of this page to improve it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18269] Move field mappings related code to Koha::FieldMapping[s]

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269

--- Comment #1 from Jonathan Druart  
---
Created attachment 61091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61091=edit
Bug 18269: Add Koha::FieldMapping[s] packages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18269] Move field mappings related code to Koha::FieldMapping[s]

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18269] New: Move field mappings related code to Koha::FieldMapping[s]

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269

Bug ID: 18269
   Summary: Move field mappings related code to
Koha::FieldMapping[s]
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

There are 3 subroutines in C4::Biblio that only do CRUD operations. They can be
replaced with a new package Koha::FieldMapping[s]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18269] Move field mappings related code to Koha::FieldMapping[s]

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15449


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449
[Bug 15449] Move stuffs to the Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||18269

--- Comment #20 from Jonathan Druart  
---
Bug 18269 - Move field mappings related code to Koha::FieldMapping[s]


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269
[Bug 18269] Move field mappings related code to Koha::FieldMapping[s]
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18101] "Internal server error" when accessing audio alerts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18101

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #5 from Marc Véron  ---
Works fine for me on current master. No error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18268] New: Notices no longer sent; resending when Patron Messaging Preference changed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18268

Bug ID: 18268
   Summary: Notices no longer sent; resending when Patron
Messaging Preference changed
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cgda...@uintah.utah.gov
QA Contact: testo...@bugs.koha-community.org

A patron’s Koha account had a address within its primary email address field
and all patron messaging preferences were enabled (including the “Digests only”
preferences), and yet, after a time, Koha failed to send notices to the
patron’s email address. It was confirmed when checking the “Notices sent for
[patron name] ([patron barcode])” tab on the patron’s account that Koha stopped
sending notices to the patron’s email address. The email addresses of another
patron account with the same patron messaging preference within this Koha
system received notices from Koha.

Koha began re-sending notices to the patron email address when the “Item
checkout” patron messaging preference was disabled and then re-enabled.

This is on Koha 3.22.08

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18257] Column visibility button does not increase colspan properly with pre-hidden columns

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18257

--- Comment #1 from Christopher Brannon  ---
I'm looking at the possibility of changing the nature of the tables a touch. 
Right now, the tables completely remove the columns.  I am looking to see if
they can just be hidden.  The problem is that when the columns are hidden by
default, the Column Visibility feature does not know how many columns are
hidden by default.  I have a desire to retain the columns hidden, so I can use
the information in those cells for another feature I have in the works.

This is open for discussion.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215

Marcel de Rooy  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #11 from Marcel de Rooy  ---
Katrin: This was Passed QA. So you should not close it. Just wait until all
patches have been pushed and the status has been changed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265

Olli-Antti Kivilahti  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |olli-antti.kivila...@jns.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265

--- Comment #3 from Olli-Antti Kivilahti  ---
WIP. Will fix  tests tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265

--- Comment #2 from Olli-Antti Kivilahti  ---
Created attachment 61090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61090=edit
Bug 18265 - Followup to Buuug 17196. deletedbiblio_metadata is not used.
biblioitemnumber was forgot.

perl misc/devel/update_dbix_class_files.pl

perl t/db_dependent/Biblio_crud.t

perl t/db_dependent/Holds/HoldFulfillmentPolicy.t
 + other tests from Buug 17196

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #136 from Olli-Antti Kivilahti  ---
Just noticed while doing DB changes, that biblio_metadata is linked to the
biblio table instead of the biblioitems-table!

This will be fixed in the followup.


>Try to be around when we ask for feedbacks and tests, *before* things are 
>pushed.
>I am sure it would be more useful for everybody.
>I cannot count how many times I have asked for help on this one.

Unfortunately that is not possible at the moment. I can only bark later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9031] Overdue items crossing DST boundary throw invalid local time exception

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #10 from Nick Clemens  ---
One test is failing on master currently for me 
(13 - Exception holiday is not a closed day test)
This patch doesn't affect that

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9031] Overdue items crossing DST boundary throw invalid local time exception

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031

Nick Clemens  changed:

   What|Removed |Added

  Attachment #13795|0   |1
is obsolete||

--- Comment #9 from Nick Clemens  ---
Created attachment 61089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61089=edit
Bug 9031 - Overdue items crossing DST boundary throw invalid local time
exception

To test:
1 - Set TZ to America/New York
2 - Checkout item and set due date to '2016-03-09 02:29:00"
3 - Make sure fines are set for the item type, fine mode production,
  calculate fines on return
4 - Check in item - invalid date time warning in logs
5 - Apply patch
6 - Check in item - no error
7 - prove t/Calendar.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16344] Add a circ rule to limit the auto renewals given a specific date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344

--- Comment #33 from Jonathan Druart  
---
Created attachment 61075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61075=edit
Bug 16344: Fix alignment between top and bottom columns

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18206] REST API: Default exception handling

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206

Lari Taskula  changed:

   What|Removed |Added

  Attachment #61072|0   |1
is obsolete||

--- Comment #3 from Lari Taskula  ---
Created attachment 61087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61087=edit
Bug 18206: Default exception handling for REST API

Many of our operations in REST API controllers now use try-catch blocks to
catch
exceptions and handle them appropriately. This is great, but we should
introduce
a centralized way of handling default HTTP 500 errors. Currently they are
checked
over and over again in each operation. As an example this same lovely poem, in
many cases, is currently replicated for each operation:

sub list {
  ...
  try {
blabla
  } catch {
# This should stay here, custom error handling for this particular
operation
if ($_->isa('Koha::Exceptions::Patron::Something')) {
   return $c->render(status => 400, openapi => { error => $_->error });
}
# But the checks below can be centralized!
elsif ($_->isa('DBIx::Class::Exception')) {
   return $c->render(status => 500, openapi => { error => $_->{msg} });
}
elsif ($_->isa('Koha::Exceptions::Exception')) {
   return $c->render(status => 500, openapi => { error => $_->error });
}
else {
   return $c->render(status => 500, openapi => { error =>
 "Something went wrong, check the logs." });
}
  };
}

Instead, my proposal for a more centralized solution is to use a before_render
hook to catch all of the default exceptions before rendering that are expected
to return a 500, logging the error and displaying an appropriate error message
in response body. After this patch, the above example would then look like
this:

sub list {
  ...
  try {
blabla
  } catch {
# This should stay here, custom error handling for this particular
operation
if ($_->isa('Koha::Exceptions::Patron::Something')) {
   return $c->render(status => 400, openapi => { error => $_->error });
}
# Simply rethrow the exception with the help of below function - it will
then
# be handled in before_render hook
Koha::Exceptions::rethrow_exception($_);
  };
}

What does this patch actually do?

After this patch, in case of an exception, we will normally visit the
catch-block.
If none of the specified Koha::Exceptions match the thrown $_, we will now
rethrow
the exception. This does not crash the whole app, but forwards the exception
eventually into our before_render hook at
Koha::REST::V1::handle_default_exceptions.
There, we are able to customize our way of handling these exceptions. In this
patch
I have added an error logging there. We should also discuss whether we want to
display a detailed error message, or simply "Something went wrong, check the
logs."
for all of the default exceptions. Perhaps this could be controlled by some
sort
of configuration for development/production (e.g. MOJO_MODE) ?

To test:
1. prove t/db_dependent/api
2. prove t/Koha/Exceptions.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18206] REST API: Default exception handling

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206

Lari Taskula  changed:

   What|Removed |Added

  Attachment #61073|0   |1
is obsolete||

--- Comment #4 from Lari Taskula  ---
Created attachment 61088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61088=edit
Bug 18206: Use this feature for cities

To test:
1. prove t/db_dependent/api/v1/cities.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15705] Notify the user on auto renewing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705

--- Comment #44 from Jonathan Druart  
---
Created attachment 61085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61085=edit
Bug 15705: DO NOT PUSH DBIC Changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15705] Notify the user on auto renewing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705

--- Comment #45 from Jonathan Druart  
---
Created attachment 61086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61086=edit
Bug 15705: Add specific warning messages for auto_too_much_oweing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15705] Notify the user on auto renewing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #57741|0   |1
is obsolete||
  Attachment #57742|0   |1
is obsolete||
  Attachment #57743|0   |1
is obsolete||
  Attachment #57744|0   |1
is obsolete||
  Attachment #57745|0   |1
is obsolete||
  Attachment #57746|0   |1
is obsolete||
  Attachment #57747|0   |1
is obsolete||

--- Comment #39 from Jonathan Druart  
---
Created attachment 61080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61080=edit
Bug 15705: Notify the user on auto renewing

When an issue is auto renewed, a notice will be sent to the patron.
The notice will tell if the renewed has been successfully done.

Note that this patch is not ready to be pushed yet, as it has some
defects:
- 1 notice per issue
- no way to disable the notice generation
- no way to specify patron categories to enable/disable the
  notifications

Test plan:
Use the automatic_renewals.pl script to auto renew issues.
If the auto renew has failed or succeeded, a notice will be generated in the
message_queue table.
If the error is "too_soon" or is the same as the previous error, the
notice won't be generated (we do not want to spam the patron).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15705] Notify the user on auto renewing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705

--- Comment #42 from Jonathan Druart  
---
Created attachment 61083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61083=edit
Bug 15705: [DO NOT PUSH] DBIC Schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15705] Notify the user on auto renewing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705

--- Comment #40 from Jonathan Druart  
---
Created attachment 61081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61081=edit
Bug 15705: DB Changes - Add [old_]issues.auto_renew_error and the AUTO_RENEWALS
notice

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15705] Notify the user on auto renewing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705

--- Comment #41 from Jonathan Druart  
---
Created attachment 61082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61082=edit
Bug 15705: Add is_tt param to the new letter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #57738|0   |1
is obsolete||
  Attachment #57739|0   |1
is obsolete||
  Attachment #57740|0   |1
is obsolete||

--- Comment #29 from Jonathan Druart  
---
Created attachment 61077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61077=edit
Bug 15582: DB changes - add new pref OPACFineNoRenewalsBlockAutoRenew

Sponsored-by: University of the Arts London

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582

--- Comment #31 from Jonathan Druart  
---
Created attachment 61079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61079=edit
Bug 15582: Fix grammar in syspref description

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582

--- Comment #30 from Jonathan Druart  
---
Created attachment 61078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61078=edit
Bug 15582: Ability to block auto renewals if OPACFineNoRenewals is reached

If a patron owes more than the OPACFineNoRenewals value, the issue won't
be auto renewed anymore (driven by the new pref
OPACFineNoRenewalsBlockAutoRenew).

Test plan:
Note: You will have to manually change data in your DB, make sure you
have access to the sql cli.
1/ Set the OPACFineNoRenewals to 5 (for instance)
2/ Set OPACFineNoRenewalsBlockAutoRenew to block
3/ Check an item out to a patron and mark is as an auto renewal
4/ Make sure the patron does not have any fees or charges.
5/ Execute the automatic renewals cronjob script
(misc/cronjobs/automatic_renewals.pl)
Confirm that the issue has been renewed
6/ Create an invoice for this patron with a amount > OPACFineNoRenewals (6
for instance)
7/ Execute the automatic renewals cronjob script
(misc/cronjobs/automatic_renewals.pl)
Confirm that the issue has not been renewed.
8/ Set OPACFineNoRenewalsBlockAutoRenew to allow
9/ Execute the automatic renewals cronjob script
(misc/cronjobs/automatic_renewals.pl)
Confirm that the issue has been renewed

Sponsored-by: University of the Arts London

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16344] Add a circ rule to limit the auto renewals given a specific date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #57735|0   |1
is obsolete||
  Attachment #57736|0   |1
is obsolete||
  Attachment #57737|0   |1
is obsolete||

--- Comment #32 from Jonathan Druart  
---
Created attachment 61074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61074=edit
Bug 16344: Add a circ rule to limit the auto renewals given a specific

This patch adds a new circulation rule (no_auto_renewal_after_hard_limit) to
block/allow
auto renewals after a given date.
The idea is to stop renewals at a given date. That way the library will have
time to send overdues and get the books back before the students do on holiday.

Test plan:
0/ Execute the update DB entry
1/ Define a rule with no_auto_renewal_after_hard_limit set to tomorrow
2/ Modify the issues.issuedate, to simulate a checkout in the past:
UPDATE issues
SET issuedate = "-mm-dd hh:mm:ss"
WHERE itemnumber = YOUR_ITEMNUMBER;
with issuedate = 2 days before for instance
3/ Execute the automatic renewals cronjob script
(misc/cronjobs/automatic_renewals.pl)
Confirm that the issue has been renewed
4/ Modify the no_auto_renewal_after_hard_limit and set it to yesterday
5/ Execute the automatic renewals cronjob script
(misc/cronjobs/automatic_renewals.pl)
Confirm that the issue has not been renewed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16344] Add a circ rule to limit the auto renewals given a specific date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344

--- Comment #34 from Jonathan Druart  
---
Created attachment 61076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61076=edit
Bug 16344: [DO NOT PUSH] Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941

--- Comment #42 from Katrin Fischer  ---
I will watch this a bit longer and consider pushing it to the next 16.11.x
release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18267] New: Update price and tax fields in EDI to reflect DB changes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Bug ID: 18267
   Summary: Update price and tax fields in EDI to reflect DB
changes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: colin.campb...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

The aqorders price and tax fields were renamed/ added to in bug 13321 but the
changes were not propagated to EDI.pm which is still creating orders with the
prices in the old fields. Update the fields used and check the correct Edifact
elements are being assigned

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |minor
 Status|Pushed to Master|Pushed to Stable
 CC||katrin.fisc...@bsz-bw.de

--- Comment #19 from Katrin Fischer  ---
Considering this a bug fix.

This patch has been pushed to 16.11.x and will be in 16.11.05.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #360 from Katrin Fischer  ---
Pushed the last fix for Santellan to 16.11.x.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |RESOLVED
 Resolution|--- |FIXED
 CC||katrin.fisc...@bsz-bw.de

--- Comment #10 from Katrin Fischer  ---
Depends on enh bug 15427 that is not in 16.11.x.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18135] Can submit batch deletion for authorities without selecting any

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18135

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |trivial
 CC||katrin.fisc...@bsz-bw.de
 Status|Pushed to Master|Pushed to Stable

--- Comment #6 from Katrin Fischer  ---
'Upping' this to be a bug fix as this fixes the former inconsistent behaviour.

This patch has been pushed to 16.11.x and will be in 16.11.05.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18206] REST API: Default exception handling

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206

Lari Taskula  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18206] REST API: Default exception handling

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206

--- Comment #2 from Lari Taskula  ---
Created attachment 61073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61073=edit
Bug 18206: Use this feature for cities

To test:
1. prove t/db_dependent/api/v1/cities.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14764] Add OPAC News branch selector

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|This patch insert a new sys |This patch inserts a new
  release notes|pref:   |system preference:
   |"OpacNewsLibrarySelect".|"OpacNewsLibrarySelect".
   |When it is active you can   |When it is active you can
   |select the news that you|select to see the news of
   |see in the 
|any library on the OPAC
   |main opac page. |start page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18206] REST API: Default exception handling

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206

Lari Taskula  changed:

   What|Removed |Added

 Depends on||18205


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205
[Bug 18205] REST interface to Koha::Logger
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18205] REST interface to Koha::Logger

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205

Lari Taskula  changed:

   What|Removed |Added

 Blocks||18206


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206
[Bug 18206] REST API: Default exception handling
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18206] REST API: Default exception handling

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206

--- Comment #1 from Lari Taskula  ---
Created attachment 61072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61072=edit
Bug 18206: Default exception handling for REST API

Many of our operations in REST API controllers now use try-catch blocks to
catch
exceptions and handle them appropriately. This is great, but we should
introduce
a centralized way of handling default HTTP 500 errors. Currently they are
checked
over and over again in each operation. As an example this same lovely poem, in
many cases, is currently replicated for each operation:

sub list {
  ...
  try {
blabla
  } catch {
# This should stay here, custom error handling for this particular
operation
if ($_->isa('Koha::Exceptions::Patron::Something')) {
   return $c->render(status => 400, openapi => { error => $_->error });
}
# But the checks below can be centralized!
elsif ($_->isa('DBIx::Class::Exception')) {
   return $c->render(status => 500, openapi => { error => $_->{msg} });
}
elsif ($_->isa('Koha::Exceptions::Exception')) {
   return $c->render(status => 500, openapi => { error => $_->error });
}
else {
   return $c->render(status => 500, openapi => { error =>
 "Something went wrong, check the logs." });
}
  };
}

Instead, my proposal for a more centralized solution is to use a before_render
hook to catch all of the default exceptions before rendering that are expected
to return a 500, logging the error and displaying an appropriate error message
in response body. After this patch, the above example would then look like
this:

sub list {
  ...
  try {
blabla
  } catch {
# This should stay here, custom error handling for this particular
operation
if ($_->isa('Koha::Exceptions::Patron::Something')) {
   return $c->render(status => 400, openapi => { error => $_->error });
}
# Simply rethrow the exception with the help of below function - it will
then
# be handled in before_render hook
Koha::Exceptions::rethrow_exception($_);
  };
}

What does this patch actually do?

After this patch, in case of an exception, we will normally visit the
catch-block.
If none of the specified Koha::Exceptions match the thrown $_, we will now
rethrow
the exception. This does not crash the whole app, but forwards the exception
eventually into our before_render hook at
Koha::REST::V1::handle_default_exceptions.
There, we are able to customize our way of handling these exceptions. In this
patch
I have added an error logging there. We should also discuss whether we want to
display a detailed error message, or simply "Something went wrong, check the
logs."
for all of the default exceptions. Perhaps this could be controlled by some
sort
of configuration for development/production (e.g. MOJO_MODE) ?

To test:
1. prove t/db_dependent/api
2. prove t/Koha/Exceptions.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519

--- Comment #12 from Katrin Fischer  ---
Ok, so when adding an item the behaviour will be the same. 
But it will be possible to empty out the date on changing an item, correct?

I am not sure how replacementpricedate was intended to work. I have heard
somewhere that it was used to decrease the replacement price over time as the
item aged, but not entirely sure. I am not sure we have any functionality tied
to it at the moment in Koha itself.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

--- Comment #47 from Jonathan Druart  
---
(In reply to Marc Véron from comment #46)
> Just wondering:
> - What value will be sent to the HEA database? 

The non-translated ones.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519

--- Comment #11 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #10)
> We have trained libraries that they don't have to fill out the field because
> Koha does it in the background automatically. I was wondering, because this
> patch talks about clearing the field. At the moment it's simply not possible
> to have an item without a dateaccessioned which is often used as creation
> data in various reports.

No, this does not affect adding an item with an empty date. The sub
_set_defaults_for_add will default dateaccessioned to today.
The change is in ModItemFromMarc. If the user cleared the date when modifying
an item, this change was not picked up. Now it is possible just as it already
was for replacementpricedate.

Note that we are still not 100% consistent imo. Only a little bit more ;)
If we want a default in dateaccessioned, we should better take care of that in
the interface rather than doing it invisibly in a set_defaults sub. Why should
a user understand that we fill dateaccessioned but we do not fill
replacementpricedate? But that is a topic for another report..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

--- Comment #46 from Marc Véron  ---
Just wondering:
- What value will be sent to the HEA database? 
- The translated one? 
- Does it depend on what language is choosen at the moment you set the value
for UsageStatsCountry?
- Deutschland or Germany?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519

--- Comment #10 from Katrin Fischer  ---
We have trained libraries that they don't have to fill out the field because
Koha does it in the background automatically. I was wondering, because this
patch talks about clearing the field. At the moment it's simply not possible to
have an item without a dateaccessioned which is often used as creation data in
various reports.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265

Owen Leonard  changed:

   What|Removed |Added

Summary|Followup to Buuug 17196.|Followup to Bug 17196.
   |deletedbiblio_metadata is   |deletedbiblio_metadata is
   |not used. biblioitemnumber  |not used. biblioitemnumber
   |was forgot. |was forgotten

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519

--- Comment #9 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #8)
> Will this effect the automatic setting of dateaccessioned on leaving it
> empty when saving? We rely on this behaviour at the moment.

Please explain what you mean. Where do you rely on exactly?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #8 from Katrin Fischer  ---
Will this effect the automatic setting of dateaccessioned on leaving it empty
when saving? We rely on this behaviour at the moment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15336] Script for merging vendors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #61070|0   |1
is obsolete||

--- Comment #20 from Alex Arnaud  ---
Created attachment 61071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61071=edit
Bug 15336 - New command-line script: merge_bookseller.pl

Test plan (i.e. merge bookseller n° 3 into the n° 6):

run perl misc/migration_tools/merge_booksellers.pl -f 3 -t 6 -v -c

Check that basketgroups, baskets, contacts, contracts and invoices
had moved into bookseller 6.
Check that bookseller n° 3 has been deleted.

Remove -c (confirm) parameter to run in test mode only.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

--- Comment #45 from Katrin Fischer  ---
They are translated via the yaml file - the memory of translating them is still
fresh. Having only one list would be preferable of course.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15336] Script for merging vendors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15336] Script for merging vendors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #45530|0   |1
is obsolete||
  Attachment #45607|0   |1
is obsolete||
  Attachment #45777|0   |1
is obsolete||
  Attachment #49313|0   |1
is obsolete||

--- Comment #19 from Alex Arnaud  ---
Created attachment 61070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61070=edit
Bug 15336 - New command-line script: merge_bookseller.pl

Test plan (i.e. merge bookseller n° 3 into the n° 6):

run perl misc/migration_tools/merge_booksellers.pl -f 3 -t 6 -v -c

Check that basketgroups, baskets, contacts, contracts and invoices
had moved into bookseller 6.
Check that bookseller n° 3 has been deleted.

Remove -c (confirm) parameter to run in test mode only.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18266] Internal Server Error when paying fine for lost item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266

Marc Véron  changed:

   What|Removed |Added

Version|unspecified |master

--- Comment #1 from Marc Véron  ---
Following finding:

sub pay in Koha/Account.pm line 106 triggers  
C4::Circulation::ReturnLostItem ( $self->{patron_id}, $fine->itemnumber );

$fine->itemnumber is not defined.

But should payment for a lost item mark the item as returned? 

Payment for an item that is lost does not necessarily mean that the item is
already replaced or will be replaced at all.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6473] Test bug for Git-bz

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #61059|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #135 from Jonathan Druart  
---
(In reply to Olli-Antti Kivilahti from comment #134)
> I don't want to beat a dead horse, but can't resist:

Try to be around when we ask for feedbacks and tests, *before* things are
pushed. I am sure it would be more useful for everybody.
I cannot count how many times I have asked for help on this one.

> The search is arguably slow.
> I wonder how the performance inspiration server (10 min search time) is
> configured?

"This is a test DB, not optimized, but we were surprised by the results."
http://lists.koha-community.org/pipermail/koha-devel/2016-July/042821.html

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6473] Test bug for Git-bz

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

--- Comment #190 from sandbo...@biblibre.com  ---
Created attachment 61069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61069=edit
Bug 6473: just a test

https://bugs.koha-community.org/show_bug.cgi?id=6473

Signed-off-by: Julian Maurice 

Signed-off-by: Julian Maurice 

Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6473] Test bug for Git-bz

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #189 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18186] Amounts with decimal comma instead of decimal dot breaking payments

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17462

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17462] Pay fines not accepting ', ' for EUR currency input

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17462

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18186

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18266] New: Internal Server Error when paying fine for lost item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266

Bug ID: 18266
   Summary: Internal Server Error when paying fine for lost item
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To reproduce:
- Create a Manual invoice for a patron, select Type: Lost Item
- Do not fill in Barcode, Description
- Give the invoice an amount that is easy to identify
- Go to tab "Pay fines"
- Identify row of new fine, click "Pay"
- On the following page, click "Confirm"
Result: "Internal Server Error"
plack error log says:
Can't call method "last_returned_by" on an undefined value at
/home/marc/koha/C4/Circulation.pm line 2188.

- Repeat steps above, insert a valid Barcode of an item that is lost. Same
result.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18265] Followup to Buuug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgot.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Depends on||17196


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196
[Bug 17196] Move marcxml out of the biblioitems table
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Blocks||18265


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265
[Bug 18265] Followup to Buuug 17196. deletedbiblio_metadata is not used.
biblioitemnumber was forgot.
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 CC||olli-antti.kivila...@jns.fi

--- Comment #134 from Olli-Antti Kivilahti  ---
I don't want to beat a dead horse, but can't resist:

> There are several goals to do it:
> - Performance
> As Paul Poulain wrote, a simple query like
>   SELECT publicationyear, count(publicationyear) FROM biblioitems GROUP BY
> publicationyear;
> takes more than 10min on a DB with more than 1M bibliographic records
> but only 3sec (!) on the same DB without the biblioitems.marcxml field

All our test environments:
MariaDB [koha]> SELECT COUNT(*) FROM biblioitems;
+--+
| COUNT(*) |
+--+
|  1424537 |
+--+
1 row in set (0.34 sec)


On Ubuntu14.04 MariaDB using a normal 10k HDD with Intel Xeon 3GHz:
innodb_buffer_pool_size = 128MB

MariaDB [koha]> SELECT publicationyear, count(publicationyear) FROM biblioitems
GROUP BY publicationyear;
+-++
| publicationyear | count(publicationyear) |
+-++
| NULL|  0 |
+-++
1 row in set (39.64 sec)

The search is arguably slow.
I wonder how the performance inspiration server (10 min search time) is
configured?


On Ubuntu14.04 MariaDB using RAID-1 SSD with Intel Xeon 3GHz 32GB RAM
innodb_buffer_pool_size = 24G (Percona autoconfigurer)

MariaDB [koha]> SELECT publicationyear, count(publicationyear) FROM biblioitems
GROUP BY publicationyear;
+-++
| publicationyear | count(publicationyear) |
+-++
| NULL|  0 |
+-++
1 row in set (5.56 sec)




RAM and SSDs are really cheap nowadays.

See also Bug 18265

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6473] Test bug for Git-bz

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Paul Poulain  changed:

   What|Removed |Added

 CC|paul.poul...@biblibre.com,  |
   |sandbo...@biblibre.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #359 from Tomás Cohen Arazi  ---
Created attachment 61068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61068=edit
Bug 7143: Add Patricio Marrone to history.txt

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18265] New: Followup to Buuug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgot.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265

Bug ID: 18265
   Summary: Followup to Buuug 17196. deletedbiblio_metadata is not
used. biblioitemnumber was forgot.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: olli-antti.kivila...@jns.fi
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Exhibit 1:

The MARCXML is lost when the biblio is deleted because the values in
biblio_metadata-table from biblioitems-table are never moved to
deletedbiblio_metadata-table.
Previously the marcxml was preserved in the oldbiblioitems-table
This is a challenge for gathering statistics
For example item has been ordered, received, and removed from collection during
the statistics period
Information in marcxml is needed to accurately categorize the item

Exhibit 2:

[15:22:38]  also. In Koha there once was a great idea that one
biblio-entry can have multiple biblioitems
[15:22:45]  and the marcxml was tied to the biblioitems-table
[15:23:11]  this is a nice idea, but nobdy really cared for it and
now biblionumber and biblioitemnumber are used interchangeably
[15:23:22]  except when they get out of sync during a data
migration
[15:23:41]  then things start to work really interestingly
[15:23:47]  but the point is
[15:23:57]  biblio_metadata has a biblionumber-column
[15:24:15]  shouldn't it have a biblioitemnumber-column, just for
old time's sake?

In the biblioitems-table we had marcxml. primary keyed with biblioitemnumber.
Now the marcxml is moved to biblio_metadata and the foreign key reference was
simplified to biblionumber.
This makes the existing FRBR-bug worse.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264

--- Comment #1 from Nick Clemens  ---
Created attachment 61067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61067=edit
Bug 18264 - Course reserves - use itemnumber for editing existing reserve items

This patch alters the crouse reserves module to use itemnumber as the
lookup method for existing reserves as opposed to barcode

To test:
1 - Apply patch
2 - Add some items to a course reserves - all should work as expected
3 - Delete the barcode for an item on reserve
4 - Note the edit link still resolves to the correct item

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18264] New: Course reserves - use itemnumber for editing existing reserve items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264

Bug ID: 18264
   Summary: Course reserves - use itemnumber for editing existing
reserve items
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Course reserves
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Some libraries have found that when using course reserves an item will have the
barcode removed. If this happens the edit links break. We should use the
itemnumber for links.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18186] Amounts with decimal comma instead of decimal dot breaking payments

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15406] Very SLOW OAI server performance

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15406

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 CC||olli-antti.kivila...@jns.fi

--- Comment #6 from Olli-Antti Kivilahti  ---
Then please go sign it off!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519

--- Comment #7 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #6)
> Marcel, sorry but I do not understand your answer.
> I am just saying that replacementpricedate is working correctly without your
> patch, so we should remove it from the bug title and commit message.
> Do you agree?

Yes, no problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18263] Make use of syspref 'CurrencyFormat' for Account and Pay fines tables

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18263

Marc Véron  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18263] Make use of syspref 'CurrencyFormat' for Account and Pay fines tables

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18263

--- Comment #1 from Marc Véron  ---
Created attachment 61066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61066=edit
Bug 18263: Make use of syspref 'CurrencyFormat' for Account and Pay fines
tables

On Home > Patrons > Accounts for... and Home > Patrons > Pay fines for...,
make the amounts display as defined in syspref 'CurrencyFormat'

To test:
- Apply patch
- Give a patron a high fine or credit (e.g. 12345.67)
- Got to pages Home > Patrons > Accounts for... and
  Home > Patrons > Pay fines
- Verify that amounts display following syspref 'CurrencyFormat'
  (e.g. 12'345.67 for syspref set to 360'000.00 (CH)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16327] Running build_oai_sets.pl with embed items option should consider every item in a biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16327

--- Comment #1 from Pedro Amorim  ---
The solution is shared in the following community entry:
https://lists.katipo.co.nz/public/koha/2016-April/045257.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #51 from David Gustafsson  ---
Made some small adjustments:

- Removed $options-{filter} arguments from ModBiblioMarc in AddBiblio since
ApplyMarcPermissions is never run on adding new biblios anyways (since no
caller uses it, and marc-xml for current biblionumber will always be empty on
save and ApplyMarcPermissions will bail out anyway), and to provide that
arguments makes things even more confusing.

- Added source => 'batchimport' for staged import batches. So now
ApplyMarcPermissions runs also on staged imports. One thing I did not realize
before is that marc permissions are never enforced adding new biblios, this is
also the case for staged imports. Only if a match is found permissions will be
applied. It would probably be more appropriate to call the current system "Marc
merge rules" or something like that, since it is really a framework for
defining what happens when two marc records are to be merged (and not
"permissions" in the strict sense of the word).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941

--- Comment #41 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #40)
> This seems to use some new constructs, is this safe for backporting to
> 16.11.x?

That would need to be tested, I only tested against master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6473] Test bug for Git-bz

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519

--- Comment #6 from Jonathan Druart  
---
Marcel, sorry but I do not understand your answer.
I am just saying that replacementpricedate is working correctly without your
patch, so we should remove it from the bug title and commit message.
Do you agree?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Gustafsson  changed:

   What|Removed |Added

  Attachment #60825|0   |1
is obsolete||

--- Comment #50 from David Gustafsson  ---
Created attachment 61065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61065=edit
Bug 14957 - Rule based permission for MARC fields

Add a rule based permission system for MARC field modifications.

Test plan:
1. Apply this patch
2. Run updatedatabase.pl
3. Log in to staff client
4. Enable new syspref MARCPermissions
5. You should see a new link "MARC field permissions" in the "Catalog"
   section under "Koha administrtion".
6. Go to the "MARC field permissions" page
7. Next to the page heading ("Manage MARC field permissions") there is a
   button with a question mark, click this for more information about the
   rule system.
8. Add desired rules to the rule table, press the +-button to add.
9. Clicking the pen-icon (edit) should allow you to edit corresponding
rule.
10. Clicking the x-icon should remove corresponding rule after
confirmation.
11. Selecting one or more rules followed by clicking the trash-icon
should remove all selected rules after confirmation.
12. To test your rules, import or in other way modify a record.
13. Check that the record was modified as defined by your rules.

Sponsored-by: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

--- Comment #44 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #43)
> Just a note: Translating the countries is quite a bit of work, please make
> sure the include file is translatable - looking at it I am not sure as there
> is no HTML.

I thought they were already not translatable on the prefs page, because they
are translated in the DB and how we handle all of that is completely buggy.
But actually they are translated...

I really would prefer to deal with that on another bug report, and find a way
to use the same file from the pref and admin pages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243

Jonathan Druart  changed:

   What|Removed |Added

 QA Contact|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #8 from Jonathan Druart  
---
Ok thanks, skipping QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #61039|0   |1
is obsolete||
  Attachment #61055|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 61063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61063=edit
Bug 18243: 16034 follow-up: better handling of absence of
WebService::ILS::OverDrive::Patron at testing

To test:
1 - Make sure you don't have WebService::ILS::OverDrive::Patron
installed
2 - prove t/Koha_ExternalContent_OverDrive.t
3 - You should get a failure to load module and tests are skipped
4 - Apply patch
5 - prove t/Koha_ExternalContent_OverDrive.t
6 - Module is not loaded, test are skipped

Fixed small typo 'cannot filnd' -> 'cannot find'
Signed-off-by: Nick Clemens 

Signed-off-by: Jonathan Druart 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243

--- Comment #7 from Jonathan Druart  
---
Created attachment 61064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61064=edit
Bug 18243: 16034 follow-up: Conditionally test Koha::ExternalContent::* modules
loading

To test:
1 - Make sure you don't have WebService::ILS installed
2 - prove t/00-load.t
3 - You should get a failure to load module and tests are skipped
4 - Apply patch
5 - prove t/00-load.t
6 - Module is not loaded, test are skipped
Optional:
7 - Install WebService::ILS
5 - prove t/00-load.t
6 - Module is loaded, test passes

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18263] Make use of syspref 'CurrencyFormat' for Account and Pay fines tables

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18263

Marc Véron  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18263] New: Make use of syspref 'CurrencyFormat' for Account and Pay fines tables

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18263

Bug ID: 18263
   Summary: Make use of syspref 'CurrencyFormat' for Account and
Pay fines tables
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

On Home > Patrons > Accounts for... and Home > Patrons > Pay fines for..., make
the amounts display as defined in syspref 'CurrencyFormat'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6473] Test bug for Git-bz

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #188 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6473] Test bug for Git-bz

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Julian Maurice  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/