[Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
   Severity|normal  |critical

--- Comment #7 from Chris Cormack  ---
Can confirm this is happening with Ubuntu 16.04 (as the webserver db on another
server) and Koha 16.11.05

No mail is sent with this bug

Can't locate Authen/CAS/Client/Response/Failure.pm:  
./Authen/CAS/Client/Response/Failure.pm: Permission denied at
/usr/share/perl/5.22/base.pm line 97.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17257] Cannot create a patron under MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17257

--- Comment #9 from Jonathan Druart  
---
Thanks for volunteering :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17257] Cannot create a patron under MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17257

--- Comment #8 from Srdjan Jankovic  ---
(In reply to Jonathan Druart from comment #6)
> As I said, I just mimic what existed before.
> The plan is to move C4::Members::AddMember to Koha::Patron, of course. But
> that patch is just supposed to be a bugfix.
I understand. In that light I think it would be better to fix it in
Koha::Patron rather than adding more code to a legacy module. Especially when
you can add it elegantly to Patron::new(), bonus moving similar lines too - a
micro-refactoring that will make moving AddMember to Patroms easier.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17257] Cannot create a patron under MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17257

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17257] Cannot create a patron under MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17257

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #55231|0   |1
is obsolete||

--- Comment #7 from Srdjan Jankovic  ---
Created attachment 61425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61425=edit
[SIGNED-OFF] Bug 17257: Fix add/edit patrons under MySQL 5.7

If no guarantor is defined the patron won't be added/modified and an
error will be raised:

DBD::mysql::st execute failed: Incorrect integer value: '' for column
'guarantorid'

Test plan:
Using MySQL 5.7 (and/or sql_mode=STRICT_TRANS_TABLES)
Create a patron without guarantor

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17257] Cannot create a patron under MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17257

--- Comment #6 from Jonathan Druart  
---
(In reply to Srdjan Jankovic from comment #5)
> (In reply to Jonathan Druart from comment #4)
> > (In reply to Srdjan Jankovic from comment #3)
> > > I don't have mysql (running mariadb), and wondering how come DBIx::Class 
> > > did
> > > not solve it?
> > 
> > If the key exists, the default value defined at DB level is not used.
> 
> Ah I see. Then maybe
> 
> delete $data{'dateofbirth'} if exists($data{'dateofbirth') &&
> !$data{'dateofbirth'};
> 
> would make intention clearer.

I just mimic what existed before.

> > I do not understand, we are not using Koha::Patron here.
> 
> A couple of lines later:
> 
> my $patron = Koha::Patron->new( $new_member )->store;
> 
> Considering the line number mismatch, I'd say base for this patch is lagging
> a bit.

As I said, I just mimic what existed before.
The plan is to move C4::Members::AddMember to Koha::Patron, of course. But that
patch is just supposed to be a bugfix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18189] Elasticsearch sorting broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18189

--- Comment #5 from Srdjan Jankovic  ---
(In reply to Nick Clemens from comment #4)
> (In reply to Srdjan Jankovic from comment #3)
> > I'm getting:
> > Fielddata is disabled on text fields by default. Set fielddata=true on
> > [author.phrase] in order to load fielddata in memory by uninverting the
> > inverted index. Note that this can however use significant memory.
> > 
> > Is something wrong with my es config?
> 
> Is this before or after the patch? I cannot seem to replicate the issue.

Both. What was the error that you were trying to get rid of?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18314] New: Account lockout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314

Bug ID: 18314
   Summary: Account lockout
 Change sponsored?: Sponsored
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To prevent brute force attacks on Koha accounts, staff and opac, we need to
implement an account lockout process to Koha.

After a number of failed login attempts a users account would become locked. 
The user would then need to use the reset password functionality to send a
reset token to their email account. After a successful password reset the
lockout flag would be removed.

The number of failed login attempts before lockout will be configurable using a
system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17257] Cannot create a patron under MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17257

--- Comment #5 from Srdjan Jankovic  ---
(In reply to Jonathan Druart from comment #4)
> (In reply to Srdjan Jankovic from comment #3)
> > I don't have mysql (running mariadb), and wondering how come DBIx::Class did
> > not solve it?
> 
> If the key exists, the default value defined at DB level is not used.

Ah I see. Then maybe

delete $data{'dateofbirth'} if exists($data{'dateofbirth') &&
!$data{'dateofbirth'};

would make intention clearer.

> I do not understand, we are not using Koha::Patron here.

A couple of lines later:

my $patron = Koha::Patron->new( $new_member )->store;

Considering the line number mismatch, I'd say base for this patch is lagging a
bit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17014] Remove more event attributes from patron templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014

--- Comment #6 from Jonathan Druart  
---
Created attachment 61424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61424=edit
Bug 17014: Simplify some code

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17014] Remove more event attributes from patron templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #61382|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 61423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61423=edit
Bug 17014 - Remove more event attributes from patron templates

There are many patron-related templates which still use event attributes
to define events. This patch updates these templates so that events are
defined in JavaScript.

To test apply the patch and check out to a patron.

- From the Print menu in the toolbar, choose "Print summary." The patron
  summary page should open and the print dialog should be automatically
  triggered.

- From the Print menu in the toolbar, choose "Print slip." The patron
  slip page should open and the print dialog should be automatically
  triggered.

- From the Print menu in the toolbar, choose "Print quick slip." The
  patron quick slip page should open and the print dialog should be
  automatically triggered.

- Click the patron's "Fines" tab in the left-hand sidebar and then
  choose the "Account" tab.
  -- Click the "Print" button for an account payment (the link should
 point to printfeercpt.pl). A print receipt page should open and
 the print dialog should be automatically triggered.
  -- Follow the same procedure for a transaction which is not an account
 payment (the link should point to printinvoice.pl).

- Click the "Create manual invoice" tab.
  -- Select one of the "type" choices. Doing so should automatically
 populate the "Description" field with the corresponding code.
  -- If necessary, define one or more values for the MANUAL_INV
 authorized value and confirm that those invoice types work as well.

- From the patron's "Pay fines" tab, click the "Pay amount" button. In
  the "collect from patron" field, enter any combination of letters,
  numbers, and symbols. When you tab away from that field your text
  should be reformatted to currency format.

- From the patrons home page, change the filter in the left-hand sidebar
  and submit it. The correct results should be returned.

Signed-off-by: EricGosselin 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17014] Remove more event attributes from patron templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15854] Race condition for sending renewal/check-in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15854

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #10 from Martin Renvoize  ---
Well done Jonathan, not a simple one there.

Passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15854] Race condition for sending renewal/check-in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15854

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #60814|0   |1
is obsolete||

--- Comment #9 from Martin Renvoize  ---
Created attachment 61422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61422=edit
Bug 15854: Use a READ and WRITE LOCK on message_queue

To make sure we will not never get a race conditions for these kinds of
notices, we need to add a LOCK on the message_queue table.

This does not smell the best way to do that, but I faced deadlock issues
when I tried to use "UPDATE FOR"

https://dev.mysql.com/doc/refman/5.7/en/innodb-locking-reads.html
https://dev.mysql.com/doc/refman/5.7/en/lock-tables.html
https://dev.mysql.com/doc/refman/5.7/en/commit.html

To test this patch, or another solution, you need to apply manually this
change:

 my $message = C4::Message->find_last_message($borrower, $type, $mtt);
 unless ( $message ) {
+sleep(1);
 C4::Message->enqueue($letter, $borrower, $mtt);
 } else {

And repeat the test plan from first patch.
Do not forget to truncate the message_queue table.

Followed test plans, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15854] Race condition for sending renewal/check-in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15854

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #60813|0   |1
is obsolete||

--- Comment #8 from Martin Renvoize  ---
Created attachment 61421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61421=edit
Bug 15854: Simplify the code to limit race conditions

There is an obvious race condition when CHECKIN and RENEWAL are
generated from circulation.pl calling svc/renew or svc/checkin in AJAX.

The 2 first queries will try to get the id of the last message
(find_last_message) and if it does not exist, they will insert it.
Theorically that could be lead to have several "digest" messages for a
given patron.
I did not recreate more than 2 messages, from the third one at least one
of the two firsts existed in the DB already.

This patch just simplifies the code to make the SELECT and INSERT or
UPDATE closer and limit the race condition possibilities.

Test plan:
0. Set RenewalSendNotice and circ rules to have a lot of renewals available
1. Use batch checkouts (or one by one) to check out several items to a
patron
2. Empty message_queue (at least of this patron)
3. Renew them all at once ("select all" link, "renew or check in"
button)
4. Check the message_queue
Without this patch you have lot of chances to faced a race condition and
get at least 2 messages for the same patron. This is not expected, we
expect 1 digest with all the messages.
With this patch apply you have lot of chances not to face it, but it's
not 100% safe as we do not use a mechanism to lock the table at the DBMS
level.

Tested both patches together, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17708] Renewal log seems empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17708

--- Comment #26 from Jonathan Druart  
---
Created attachment 61420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61420=edit
Bug 17708: Rename 'RENEW' with 'RENEWAL'

Sounds more appropriate and consistent with existing action logs.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17708] Renewal log seems empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17708

--- Comment #25 from Jonathan Druart  
---
Created attachment 61419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61419=edit
Bug 17708: Fix use statements

For an unknown reason, the use_ok('Circulation') does not work as
intended (see 3660c451a36d).
With the new use of C4::Log, the trick does no longer work.
It does not make sense to add the use_ok('C4::Log') in Circulation.t,
removing it.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17708] Renewal log seems empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17708

--- Comment #24 from Jonathan Druart  
---
Created attachment 61418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61418=edit
Bug 17708: Add the IGNORE clause

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17708] Renewal log seems empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17708

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #61368|0   |1
is obsolete||

--- Comment #23 from Jonathan Druart  
---
Created attachment 61417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61417=edit
Bug 17708: Added a logaction function in Addrenewal in order to send renew logs

20/02/17 : added the syspref RenewalLog
24/20/17 : added a test for the syspref Renewal Log

test plan
1 - Chose a Borrower and have him renewing an item
2 - Check the renew logs : they should be empty
3 - Apply patch and set the syspref RenewalLog to 1
4 - Have the Borrower renewing a new item
5 - Check the renew logs : there should be your renew

I called the function logaction, which is in charge of modifying the
logs, within the function which adds a new renewal at the list.

Signed-off-by: Julien Comte 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17708] Renewal log seems empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17708

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #60 from Martin Renvoize  ---
Tested pretty thoroughly and is looking solid to me. Thanks for the efforys
Jonathan and for the thorough testing Marcel.

Passing QA!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #59860|0   |1
is obsolete||

--- Comment #59 from Martin Renvoize  ---
Created attachment 61416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61416=edit
Bug 17736: Fix typo ->new vs ->next

while ->new is terrible, let's call that a typo...

Signed-off-by: Marcel de Rooy 
opac-detail works again !

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #59855|0   |1
is obsolete||

--- Comment #58 from Martin Renvoize  ---
Created attachment 61415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61415=edit
Bug 17736: [QA Follow-up] Script basket.pl is not Plack compliant

Several warnings like:
Variable "$confirm_pref" is not available at
/usr/share/koha/masterclone/acqui/basket.pl line 507.

Primarily caused by sub edi_close_and_order.

Easy fix.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #59854|0   |1
is obsolete||

--- Comment #57 from Martin Renvoize  ---
Created attachment 61414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61414=edit
Bug 17736: [QA Follow-up] We do not need GetItemHolds in acqui

The solution of Jonathan can be applied in two other cases, effectively
making GetItemHolds obsolete.

Test plan:
[1] Git grep on GetItemHolds
[2] Add an order, place a hold, delete order.
[3] Add an order, receive, place hold, delete order.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #59852|0   |1
is obsolete||

--- Comment #55 from Martin Renvoize  ---
Created attachment 61412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61412=edit
Bug 17736: [QA Follow-up] Wrong biblionumber in acqui/parcel

Trivial fix.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #59851|0   |1
is obsolete||

--- Comment #54 from Martin Renvoize  ---
Created attachment 61411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61411=edit
Bug 17736: [QA Follow-up] Solve warning from qa tools on Holds.t

FAIL   t/db_dependent/Holds.t
"my" variable $hold masks earlier declaration in same scope

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #59853|0   |1
is obsolete||

--- Comment #56 from Martin Renvoize  ---
Created attachment 61413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61413=edit
Bug 17736: [QA Follow-up] Crashes in basket.pl and parcel.pl

Crash in basket.pl:
Can't call method "holds" on an undefined value at
/usr/share/koha/masterclone/acqui/basket.pl line 466.
Comes from a biblionumber == NULL in aqorders where I cancelled the order and
deleted the biblio.

Crash in parcel.pl:
Can't call method "holds" on an undefined value at
/usr/share/koha/masterclone/acqui/parcel.pl line 246.
Similar fix.

Trivial fixes indeed.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #59850|0   |1
is obsolete||

--- Comment #53 from Martin Renvoize  ---
Created attachment 61410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61410=edit
Bug 17736: [Follow-up] Resolve inherited AUTOLOAD for non-method errors

Like:
Use of inherited AUTOLOAD for non-method Koha::Biblio::GetMarcBiblio() is
deprecated at /usr/share/koha/masterclone/Koha/Biblio.pm line 60.
Use of inherited AUTOLOAD for non-method Koha::Biblio::GetRecordValue() is
deprecated at /usr/share/koha/masterclone/Koha/Biblio.pm line 60.

Resolved by not importing them but fully qualifying them.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #59849|0   |1
is obsolete||

--- Comment #52 from Martin Renvoize  ---
Created attachment 61409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61409=edit
Bug 17736: [Follow-up] Rename to current_holds

It is not about when the hold was 'placed' but if the hold pertains to
the future or not.

Test plan:
[1] Git grep on holds_placed_before_today.
[2] Run t/db_dependent/Koha/Biblios.t
[3] Run t/db_dependent/Reserves.t

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #59848|0   |1
is obsolete||

--- Comment #51 from Martin Renvoize  ---
Created attachment 61408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61408=edit
Bug 17736: Remove C4::Reserves::GetReservesFromBiblionumber

At this point, there should not be any occurrences of
GetReservesFromBiblionumber left in the codebase

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #59846|0   |1
is obsolete||

--- Comment #49 from Martin Renvoize  ---
Created attachment 61406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61406=edit
Bug 17736: Add the Koha::Biblio->holds_placed_before_today method

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #59847|0   |1
is obsolete||

--- Comment #50 from Martin Renvoize  ---
Created attachment 61407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61407=edit
Bug 17736: Replace GetReservesFromBiblionumber with Koha::Biblio->holds

The C4::Reserve::GetReservesFromBiblionumber took 3 parameters, the
biblionumber, an optional itemnumber and a "all_dates" flag.
If set, the subroutine returned all the holds placed on a given bibliographic
record, even the ones placed in the future. Almost all of the calls had this
flag set, they will be replaced with a call to Koha::Biblio->holds.

But 5 did not have it:
- C4::Biblio::DelBiblio
-tools/batch_delete_records.pl
=> These 2 were wrong, we want to retrieve the holds to cancel them
before deleting the record. We need to get all the holds, even the ones
placed in the future /!\ CHANGE IN THE BEHAVIOR

- acqui/parcel.pl
=> 1 call per item were made to this subroutine. They have been replaced
with only 1 call to the new method Koha::Biblios->holds_placed_before_today
Then we filter on the itemnumbers.
I think this is wrong: we need the number of holds to know if the record
can be deleted, so even if future holds exist, the deletion should not
be possible.

- serials/routing-preview.pl
- C4::ILSDI::Services::GetRecords
- C4::SIP::ILS::Item->new
=> Seems ok, we just one to display holds placed before today

Test plan:
I would suggest to test this patch with patches from bug 17737 and bug 17738,
to place different kind of holds (biblio and item level, future and
past).
Then do a whole workflow to detect bug, view a record, delete record,
order, place a hold on an item which has been ordered, etc.
The hold's informations should always be the same without or without
these patches.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18181] Can' t tell which subscriptions already have routing lists if seeing all subs attached to a biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18181

Eric  changed:

   What|Removed |Added

 CC||eric.gosseli...@gmail.com

--- Comment #2 from Eric  ---
Hello,

I don't know if its only on my sandbox, but it seems the Add recipients option
in the Create a Routing list is broken when i update the sandbox with the
patch.

I feel it's only on my side, but if someone can verify it too ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17600] Standardize the EXPORT

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

--- Comment #17 from Jonathan Druart  
---
Put in QA queue to get feedbacks from QAer. More than 2 signoffs from QA team
members would be great.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17600] Standardize the EXPORT

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

--- Comment #16 from Jonathan Druart  
---
(In reply to M. Tompsett from comment #15)
> (In reply to Jonathan Druart from comment #14)
> > Maybe it would be easier not to export anything and use fully qualified
> > names instead?
> 
> If someone has "use Foo;" in their code, they probably would rather write
> Bar() than Foo::Bar(); in their code. I know I would.

It is what is done here, you have to export them explicitly.

  use Foo qw( bar );
  bar();

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688

Suzanne Fayle  changed:

   What|Removed |Added

 CC||sfa...@roseman.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697

Suzanne Fayle  changed:

   What|Removed |Added

 CC||sfa...@roseman.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10086] No way to go back to the basket on uncertain prices page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
Aleisha, the button looks misplaced. Usually the action buttons are in the last
column of the table, do not you think it is better to stick to this rule?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18066] Hea - Version 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #34 from Jonathan Druart  
---
Julian, was it a PQA?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18257] Column visibility button does not increase colspan properly with pre-hidden columns

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18257

--- Comment #3 from Christopher Brannon  ---
(In reply to Jonathan Druart from comment #2)
> (In reply to Christopher Brannon from comment #1)
> > I have a desire to retain the columns hidden, so I can
> > use the information in those cells for another feature I have in the works.
> 
> Which is?

Maintaining the columns and hiding them will allow us to more easily compensate
for this bug this ticket addresses, in my opinion, and will allow a feature I
am looking into developing.  

That feature is to give the added choice of showing the hidden information in a
popover while hovering over the row.  Having the columns hidden instead of
removed allows me to repurpose the data without having to invent another method
of bringing that information back to the page.

The idea is that there is a lot of clutter on the checkout rows that people
don't need all the time in the normal checkout workflow, which is why some
people turn off certain columns.  However, someone might still occasionally
need a piece of information, and they can simply hover their mouse over the row
to read it.

I have a working concept in jquery, but I think it would be a good permanent
enhancement to try.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #77 from Josef Moravec  ---
Created attachment 61405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61405=edit
Bug 8612 - QA followup, fix kohastructure.sql, fix typo in template

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17309] Renewing and HomeOrHoldingBranch syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17309] Renewing and HomeOrHoldingBranch syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #61399|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 61404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61404=edit
Bug 17309 - Renewing and HomeOrHoldingBranch syspref

The AddRenewal subroutine currently uses the circulation rules for the branch
stored in the Issues table (which is the holding branch) when calculating the
new due date.

This patch replaces using the branch from the Issues table with the branch
specified by the HomeOrHoldingBranch syspref.

To test:
1. Set up 2 branches, Branch1 and Branch2
2. Set up a loan rule in Branch1 for DVDs with a 21 day loan period and a
   21 day renewal period.
3. Set up a loan rule in Branch2 for DVDs with a 14 day loan period and a
   14 day renewal period.
4. Checkout a DVD belonging to Branch1 while logged into Branch2. It will
   receive the correct 21 day loan period.
5. Renewing the same DVD while logged into either Branch1 or Branch2
   will give a 14 day due date, rather than 21 days.
6. Checkout a DVD belonging to Branch2 while logged into Branch1. It will
   receive the correct 14 day loan period.
7. Renewing the same DVD while logged into either Branch1 or Branch2
   will give a 21 day due date, rather than 14 days.
8. Apply the patch and repeat steps 4-7. The correct due date should be given
   when the item is renewed, regardless of where it is checked out or renewed.

This update removes reassignment of $branch variable.

Signed-off-by: Cédric Vita 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17290] Standardize on "Patron categories" when referring to patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #61386|0   |1
is obsolete||

--- Comment #9 from Jonathan Druart  
---
Created attachment 61403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61403=edit
Bug 17290 - Standardize on "Patron Categories"

We need to standardize on terminology, this changes all instances of
patron types to be patron categories.  To text, just view the patch

Signed-off-by: Cédric Vita 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17290] Standardize on "Patron categories" when referring to patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18297] Clicking on Stage MARC records for import launches koha installer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18297

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #45 from Marcel de Rooy  ---
Prelimary results (QA can be an iterative process):

perl t/db_dependent/Holds/CancelReserves.t
1..5
ok 1 - use C4::Reserves;
ok 2 - Reserve 1 should not be canceled.
ok 3 - Reserve 2 should be canceled.
Can't locate object method "get_instance" via package "Koha::Cache" at
t/db_dependent/Holds/CancelReserves.t line 81.
# Looks like your test exited with 255 just after 3.

perl t/db_dependent/Holds/WaitingReserves.t
1..11
ok 1 - use C4::Reserves;
ok 2 - Waiting date should be set to today
ok 3 - Expiration date should be set to today + 6
ok 4 - Reserve status is now "waiting"
ok 5 - Priority should be 0
ok 6 - Item number should be set correctly
ok 7 - 2nd reserve - Reserve status is now "To transfer"
ok 8 - 2nd reserve - Priority should be 0
ok 9 - 2nd reserve - Item number should be set correctly
not ok 10 - Expiration date should be set to today + 7
#   Failed test 'Expiration date should be set to today + 7'
#   at t/db_dependent/Holds/WaitingReserves.t line 218.
#  got: '2017-03-27'
# expected: '2017-03-29'
ok 11 - Requested expiration date should be kept
# Looks like you failed 1 test of 11.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18266] Internal Server Error when paying fine for lost item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18266] Internal Server Error when paying fine for lost item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266

--- Comment #4 from Jonathan Druart  
---
Created attachment 61402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61402=edit
Bug 18266: Fix internal error when paying fine for lost item without.. item

If a fine is created for a lost item but the itemnumber is not supplied,
the system will return it.
The item should not be mark as returned if there is no item linked to
the fine.

Test plan:
1. Turn StoreLastBorrower on
2. Create a manual invoice for a lost item, do not supply a barcode
3. Pay the fines 'Pay fines > Pay'

=> Without this patch applied you get
Can't call method "last_returned_by" on an undefined value at
/home/marc/koha/C4/Circulation.pm line 2188.

=> With this patch applied, you must not get the error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18266] Internal Server Error when paying fine for lost item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
To recreate you need StoreLastBorrower

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17346] Enable the check in option in Columns settings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18257

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

--- Comment #44 from Marcel de Rooy  ---
(In reply to Andreas Hedström Mace from comment #41)
> And yes that is the same settings I was using. Since it works for both of
> you, I'm going to assume that either it is an issue with my devbox or I made
> a mistake while testing. Going to sign off.
Andreas:
This is not the best introduction for a signoff btw :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18257] Column visibility button does not increase colspan properly with pre-hidden columns

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18257

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17346

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18257] Column visibility button does not increase colspan properly with pre-hidden columns

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18257

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---
(In reply to Christopher Brannon from comment #1)
> I have a desire to retain the columns hidden, so I can
> use the information in those cells for another feature I have in the works.

Which is?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

--- Comment #12 from Andreas Hedström Mace  ---
It seems I was a but quick when I looked over the comments for this bug, I
assumed there was a working patch that I could test but reading the comments
again (more thoroughly!) it seems it was more in discussion? Should I change
the status back to Needs Signoff or maybe In Discussion?

My two cents is that a drag and drop option, combined with an action menu to be
accessible, sounds like the best way to go. (Actually the holds page in the
staff interface is the one who got singled out as most in need of re-work when
we did some UX work on Koha, and anything that can be done to make it
easier/more understandable is great!)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #24 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #23)
> Just another question: If we checkout in the staff client, wouldn't it be
> good to also show a message? A staff member could remind the patron that the
> fee is applied now, but he does not see it happening.

Not to talk about SIP.
This 'fortunately' does not look very promising currently in do_hold:
AddReserve( $branch, $borrower->{borrowernumber}, $bibno,
GetBiblioItemByBiblioNumber($bibno) );
# unfortunately no meaningful return value
$self->ok(1);
return $self;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Eric  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||eric.gosseli...@gmail.com

--- Comment #5 from Eric  ---
Patch doesn't apply :

Some problems occurred applying patches from bug 4461:
Something went wrong !Applying: Bug 4461: Add a context-sensitive
'Report a Problem' feature to OPAC
Using index info to reconstruct a base tree...
M   Koha/Schema/Result/Borrower.pm
M   installer/data/mysql/kohastructure.sql
M   koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
Auto-merging installer/data/mysql/kohastructure.sql
Auto-merging Koha/Schema/Result/Borrower.pm
CONFLICT (content): Merge conflict in Koha/Schema/Result/Borrower.pm
Patch failed at 0001 Bug 4461: Add a context-sensitive 'Report a Problem'
feature to OPAC
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
error: Failed to merge in the changes.
Bug 4461 - Context-sensitive report a problem screen

59032 - Bug 4461: Add a context-sensitive 'Report a Problem' feature to OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

Andreas Hedström Mace  changed:

   What|Removed |Added

  Attachment #59165|0   |1
is obsolete||

--- Comment #42 from Andreas Hedström Mace  ---
Created attachment 61401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61401=edit
Bug 12063 - Keep patron's requested expiration date if it is prior to the
calculated one

Signed-off-by: Andreas Hedström Mace 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

--- Comment #43 from Marcel de Rooy  ---
Ah great. I will be looking again at this one very soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

Andreas Hedström Mace  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18221] Wrong form action in checkout table (/tools/export.pl)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18221

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
Yes, it is used for the export feature (see ExportWithCsvProfile).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #23 from Marcel de Rooy  ---
Just another question: If we checkout in the staff client, wouldn't it be good
to also show a message? A staff member could remind the patron that the fee is
applied now, but he does not see it happening.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

Andreas Hedström Mace  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #41 from Andreas Hedström Mace  ---
Thanks for testing Alex and Sonia!

And yes that is the same settings I was using. Since it works for both of you,
I'm going to assume that either it is an issue with my devbox or I made a
mistake while testing. Going to sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18313] New: Remove Delicious icon from OPAC social network links

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18313

Bug ID: 18313
   Summary: Remove Delicious icon from OPAC social network links
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

The Delicious web site doesn't seem to be doing anything but trying to sell
things from their "shop" subdomain. The link on the OPAC detail page should be
removed.

If anyone wants to write a configurable social network widget system for the
OPAC that would be cool.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #22 from Marcel de Rooy  ---
(In reply to Alex Sassmannshausen from comment #20)
> Claire and I have deliberated for a bit at the hackfest, and we think the
> following would be minor improvements (though it kind of works as it is).

Great. Thanks.

> > There is a charge of [% RESERVE_CHARGE %] for collecting this hold
> You will be charged a hold fee of [% _ %] for collecting this item

Although I am not a native speaker, maybe we can still improve here :) Note
that opac-reserve tells this to the user. So the time is placing the hold, but
collecting it is still in the future. We do not charge for collecting btw, we
just charge when you collect.. Shouldn't it be better to say You will be
charged WHEN collecting? (Very strictly, we can't say THIS item; could be a
biblio level hold. Maybe: book, material, or just 'it'.)
So I would opt for: You will be charged WHEN collecting THE item.
No blocker btw.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18066] Hea - Version 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066

Julian Maurice  changed:

   What|Removed |Added

  Attachment #61358|0   |1
is obsolete||

--- Comment #31 from Julian Maurice  ---
Created attachment 61396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61396=edit
Bug 18066: Fix tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18066] Hea - Version 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066

Julian Maurice  changed:

   What|Removed |Added

  Attachment #60743|0   |1
is obsolete||

--- Comment #28 from Julian Maurice  ---
Created attachment 61393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61393=edit
Bug 18066: Add the leaflet library

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18306] "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306

--- Comment #5 from Alexandre  ---
Created attachment 61400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61400=edit
error message with renew button in 16.11

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18306] "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306

--- Comment #4 from Alexandre  ---
I just tested it in 16.11 too, they still there.

We can also observe an error message (in yellow) when we try the "renew all"
button (see second picture): 

" Your loan renewal failed because of the following reason(s): You have renewed
this item the maximum number of times allowed. You have renewed this item the
maximum number of times allowed."

I must admit that can be very confusing for a student. These buttons let the
student think that they can renew their books by themself and at home (OPAC)
but they will realise just in the last days of their loans that they can't...
This message don't help them to understand the situation.

Marc, which version did you use ? Maybe it was corrected for 17.05 but I didn't
see any bug on this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17309] Renewing and HomeOrHoldingBranch syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #3 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Cédric Vita 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17309] Renewing and HomeOrHoldingBranch syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309

--- Comment #4 from sandbo...@biblibre.com  ---
Created attachment 61399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61399=edit
Bug 17309 - Renewing and HomeOrHoldingBranch syspref

The AddRenewal subroutine currently uses the circulation rules for the branch
stored in the Issues table (which is the holding branch) when calculating the
new due date.

This patch replaces using the branch from the Issues table with the branch
specified by the HomeOrHoldingBranch syspref.

To test:
1. Set up 2 branches, Branch1 and Branch2
2. Set up a loan rule in Branch1 for DVDs with a 21 day loan period and a
   21 day renewal period.
3. Set up a loan rule in Branch2 for DVDs with a 14 day loan period and a
   14 day renewal period.
4. Checkout a DVD belonging to Branch1 while logged into Branch2. It will
   receive the correct 21 day loan period.
5. Renewing the same DVD while logged into either Branch1 or Branch2
   will give a 14 day due date, rather than 21 days.
6. Checkout a DVD belonging to Branch2 while logged into Branch1. It will
   receive the correct 14 day loan period.
7. Renewing the same DVD while logged into either Branch1 or Branch2
   will give a 21 day due date, rather than 14 days.
8. Apply the patch and repeat steps 4-7. The correct due date should be given
   when the item is renewed, regardless of where it is checked out or renewed.

This update removes reassignment of $branch variable.

Signed-off-by: Cédric Vita 
Signed-off-by: Cédric Vita 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17309] Renewing and HomeOrHoldingBranch syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #58195|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18306] "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306

--- Comment #3 from Alexandre  ---
Very sorry for this second post.

After a discussion with my collegue Marjorie, it's appears that this bug is in
16.11 too.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18066] Hea - Version 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066

Julian Maurice  changed:

   What|Removed |Added

  Attachment #60746|0   |1
is obsolete||

--- Comment #30 from Julian Maurice  ---
Created attachment 61395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61395=edit
Bug 18066: Use https for ws

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18066] Hea - Version 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066

Julian Maurice  changed:

   What|Removed |Added

  Attachment #61362|0   |1
is obsolete||

--- Comment #32 from Julian Maurice  ---
Created attachment 61397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61397=edit
Bug 18066: Fix map positioning in admin/usage_statistics.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18309] UNIMARC update from IFLA

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309

Couffignal  changed:

   What|Removed |Added

 CC||fcouffig...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18306] "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306

Alexandre  changed:

   What|Removed |Added

Version|3.22|16.11

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18066] Hea - Version 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066

Julian Maurice  changed:

   What|Removed |Added

  Attachment #60745|0   |1
is obsolete||

--- Comment #33 from Julian Maurice  ---
Created attachment 61398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61398=edit
[DO NOT PUSH] Bug 18066: Use hea test server instead of prod

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18066] Hea - Version 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066

Julian Maurice  changed:

   What|Removed |Added

  Attachment #60744|0   |1
is obsolete||

--- Comment #29 from Julian Maurice  ---
Created attachment 61394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61394=edit
Bug 18066: Do not use token for OSM tiles

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18066] Hea - Version 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066

Julian Maurice  changed:

   What|Removed |Added

  Attachment #60742|0   |1
is obsolete||

--- Comment #27 from Julian Maurice  ---
Created attachment 61392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61392=edit
Bug 18066: Hea V2

This patch is the Koha part of the Hea v2 project.
You can find the (testing) code for the server at
  hea-ws  - https://github.com/joubu/hea-ws/commits/v2
  hea-app - https://github.com/joubu/hea-app/commits/v2
They contain the different pull requests made over the last 6 months.

More information on Hea at
https://wiki.koha-community.org/wiki/KohaUsageStat_RFC
The goal of this commit message is to provide an overview of what could
be a new version of Hea.

Prior to these changes, the Hea database was filled with 1 line per Koha
installation. System preferences were filled by the libraries and a
cronjob (share_usage_with_koha_community.pl) collected these values to send
them to a webservice (hea-ws/upload.pl).

With the need to collect more data we would want to collect data at the library
level (branch) and not at the installation level.
For instance the geolocation, the url or the country can be different from one
library to another, even if managed from the same Koha installation.
The Hea DB has been upgraded to reflect that change (see
hea-app/sql/schema.sql).

The hidden goal of this patch is to make Hea sexier and explain
better to libraries how it can be useful to share their information
with the Koha community. I guess the main problem is the lack of
communication and explanations about what we are doing we these data.
To fill this gap I'd like to (TODO)
  1. Communicate on the ML about this new version of Hea (once it got
pushed and backported)
  2. Link the Privacy_Policy.md from the Hea interface
  3. Get help from a native English speaker to add
popup/help/info/whatever on "Home › Administration › Usage statistics",
to clearly explain what happens (and what will not happen!) when an option or
another is set.

You can find screenshot of this whole enhancement on bug 18066, comment 2.

What this patch does:
- Create a new branches.geolocation DB field
- Add 3 new sysprefs:
  * UsageStatsGeolocation
  * UsageStatsLibrariesInfo
  * UsageStatsPublicID
- Integrate the Leaflet JS library to get a fancy map to pick
geolocations

How does it works:
On the new administration page where statistics to share are configured,
there are several new things. It is now possible to share information either
per Koha installation or libraries. If UsageStatsLibrariesInfo is set,
the info at library level (url, name, country, geolocation) will be
sent to the Hea webservice. If it is not set, you can decide to fill
UsageStatsLibraryUrl, UsageStatsLibraryName, UsageStatsCountry,
UsageStatsGeolocation to share these information. Note that even if the
data are retrieved at installation level, it's better to fill the prefs
as well: On the Hea website the different libraries defined for a given
Koha installation could be displayed on the same page.
This page is a public page which will be attributed to every
installation (with the pref UsageStatsPublicID). On this page all the
info available publicly will be displayed.

TODO later:
- Add a button on the administration page to delete the info shared
publicly. It will be easy to show that the info are no longer displayed
on the public page.
- Add an icon per Koha installation to get a better "public page"
- Any suggestions?

Test plan:
We will need to test hea-ws, hea-app and the Koha-side code to test the
whole enhancement.
1/ To start, clone the hea-ws and hea-app project and checkout the
'master' branch (*not* 'v2')
2/ Create the hea database and user
  CREATE DATABASE hea
  CREATE USER 'hea'@'localhost' IDENTIFIED BY 'hea';
  GRANT ALL PRIVILEGES ON hea.* TO 'hea'@'localhost';
  FLUSH PRIVILEGES;
3/ Fill the DB with some data
  mysql hea < hea-app/sql/schema.sql
  mysql hea < hea-app/sql/sql/mock-data.sql
4/ Checkout the 'v2' branch for both hea-ws and hea-app
5/ Execute the upgrade DB script
  % cd hea-app
  % perl -p -i -e 's/REPLACE_ME/hea/' sql/upgrade.pl # Fill the DB info
  % perl sql/upgrade.pl
Now the DB is using the v2 structure. That means we have 1 installation
row per library previously defined. 1 library row has also been created.
5/ Configure hea-ws
% echo '192.168.50.1 hea.koha-community.org' >> /etc/hosts

  DocumentRoot "/path/to/hea-ws"
  ServerName "hea.koha-community.org"
  
Options +ExecCGI
Require all granted
AddHandler cgi-script .pl
  


And enable it with a2ensite, then restart apache.
The copy the database.yml.sample to database.yml and edit it to fill the
DB info.

6/ Launch the hea-app
  % cd 

[Koha-bugs] [Bug 18312] Export is broken unless a file is supplied

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18312] Export is broken unless a file is supplied

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #2 from Nick Clemens  ---
*** Bug 18311 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18311] Exporting records without using a file is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18311

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Nick Clemens  ---


*** This bug has been marked as a duplicate of bug 18312 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18312] Export is broken unless a file is supplied

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312

--- Comment #1 from Jonathan Druart  
---
Created attachment 61391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61391=edit
Bug 18312: Fix export unless a file is supplied

Bug 18087 breaks export unless a file is supplied.

Can't use an undefined value as a HASH reference at
/home/vagrant/kohaclone/tools/export.pl line 75.

Test plan:
Export records using a file of id that is not a valid file (not txt or
csv)
Export records using a valid file
Export records without supplying a file

=> The export should work or fail as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580

Jens Weber  changed:

   What|Removed |Added

 CC||jens.we...@phsh.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14666] adds fixed_fines for overdues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666

Jens Weber  changed:

   What|Removed |Added

 CC||jens.we...@phsh.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18312] Export is broken unless a file is supplied

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18311] Exporting records without using a file is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18311

--- Comment #1 from Nick Clemens  ---
Created attachment 61390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61390=edit
Bug 18311 - Exporting records without using a file is broken

TO test:
Try exporting authority records using numbers
It wil faill
Apply patch
It should succeed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18311] Exporting records without using a file is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18311

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18312] Export is broken unless a file is supplied

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||18087


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087
[Bug 18087] Clarification on File type when using file of biblionumbers to
export data
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18087] Clarification on File type when using file of biblionumbers to export data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18312

--- Comment #23 from Jonathan Druart  
---
Introduced bug 18312.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312
[Bug 18312] Export is broken unless a file is supplied
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18312] New: Export is broken unless a file is supplied

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312

Bug ID: 18312
   Summary: Export is broken unless a file is supplied
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: major
  Priority: P5 - low
 Component: Tools
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

Bug 18087 breaks export unless a file is supplied

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18311] New: Exporting records without using a file is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18311

Bug ID: 18311
   Summary: Exporting records without using a file is broken
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Bug 18087 added a check to the mimetype of files for export - it missed
checking if a file was provided

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13816] Set Overdue letter fine to the overduerules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13816

Jens Weber  changed:

   What|Removed |Added

 CC||jens.we...@phsh.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12769] Notice fee management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769

Jens Weber  changed:

   What|Removed |Added

 CC||jens.we...@phsh.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187

Jens Weber  changed:

   What|Removed |Added

 CC||jens.we...@phsh.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

--- Comment #40 from Koha Team Lyon 3  ---
hello Andreas,
I have tested one more time but I can't reproduce your issue.

you said : "one might want to exclude holidays but still apply a fee for those
who doesn’t pick up a reserved book"

I try with those syspref : 
ExcludeHolidaysFromMaxPickUpDelay = allow
ExpireReservesMaxPickUpDelay= allow
ExpireReservesMaxPickUpDelayCharge=1
ReservesMaxPickUpDelay=1

That seems to be the setting translation of your sentence.
After launching misc/cronjobs/holds/cancel_expired_holds.pl, holds expired are
canceled and a fee of 1 € is charged to borrowers.

Perhaps, I haven't really understood what is the problem..


(I assume that the script misc/cronjobs/holds/cancel_expired_holds.pl will have
no effect if ExpireReservesMaxPickUpDelay is set to "don't allow")

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12283] Set autocomplete=off for patron search input

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12283

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12388] IssueSlip output should be sorted by date_due, not timestamp

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12388

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/