date:20170411

[Koha-bugs] [Bug 16138] Restart plack when rotating logfiles

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138

Barton Chittenden  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17717

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717

Barton Chittenden  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16138
 CC||bar...@bywatersolutions.com

--- Comment #12 from Barton Chittenden  ---
Note: this seems to be the same compilation error that was tripping up plack in
Bug 16138

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18421] New: Make Coce cover images available for staff search

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

Bug ID: 18421
   Summary: Make Coce cover images available for staff search
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: a...@hanover.ca
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

When turned on, Coce cover images appear in the OPAC only, not staff interface.
(Coce Cover images - settings in enhanced content.)

Desired setting would be like Amazon cover settings - the ability to turn on
Coce images for the OPAC and/or the staff interface separately.
Coce server needs Koha searches to populate it with cover image links. While it
is collecting them, images do not display on the first time search results. To
make them display would need a refresh or a programmed time delay and re-query
to the Coce server. This is not useful for public OPAC.
While the Coce server is being populated with links it is desirable to have
only the staff interface using Coce.
After a time, when the Coce server has accumulated a large collection of links,
it would then be turned on for public OPAC and used by both.

I have Koha 3.22.07, and am testing with the Bywater Coce server.
If this is under way or in more recent versions already, please comment.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|17855   |
 Depends on||17855


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855
[Bug 17855] New onboarding tool feature to guide users through setting up Koha,
and minor web installer UI improvements
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18039
 Depends on|18039   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039
[Bug 18039] Move the mandatory and optional files for non-english languages
into 'default' directory so bug 17855 permits use of other languages
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18420] t/dbdependent/Budgets.t fails without patron category 'S'

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17855

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18420

--- Comment #175 from Marc Véron  ---
(In reply to Katrin Fischer from comment #173)
> Hm, should we not fix the test instead? Not sure I understood correctly, but
> having a category of 'S' should not be mandatory for the tests to pass in a
> normal environment.

No problem for me. I filed a bug:
Bug 18420 - t/dbdependent/Budgets.t fails without patron category 'S'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18420] New: t/dbdependent/Budgets.t fails without patron category 'S'

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420

Bug ID: 18420
   Summary: t/dbdependent/Budgets.t fails without patron category
'S'
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: ve...@veron.ch
QA Contact: gmcha...@gmail.com

If no patron category 'S' is defined, t/dbdependent/Budgets.t fails.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17821] due date in intranet search results should use TT date plugin

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821

--- Comment #7 from Jonathan Druart  
---
(In reply to Fridolin SOMERS from comment #6)
> Some of our instances have sometimes an invalid date in items.onload (like
> 000-00-00). We don't know why but without this patch the page failes on
> error :
> "Can't locate object method \"ymd\" via package \"dateonly\" (perh"...)
> called at /home/koha/src/Koha/DateUtils.pm line 223

Ok but you are not fixing anything with this patch, just hide other problems:

course_reserves/course-details.tt: [% IF cr.item.onloan %]
reserve/request.tt:[% IF ( itemloo.onloan ) %]
catalogue/detail.tt:   [% UNLESS ( item.itemnotforloan ||
item.notforloan_per_itemtype || item.onloan || item.itemlost || item.withdrawn
|| item.damaged || item.transfertwhen || item.reservedate ) %]

In all of these tests, onloan will be true when you are expecting it to be
false.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14606] Donate to the Koha International Fund

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14606

--- Comment #17 from Pablo AB  ---
That's really a pity. Meanwhile maybe at least a bitcoin wallet? Created by
someone reliable of the community.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12930] Web installer does not show login errors

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #8 from Jonathan Druart  
---
Alex, it seems that the only changes you made are:

+if ($info{'invalid_username_or_password'} == 1) {
+$template->param( 'invalid_username_or_password' =>
$info{'invalid_username_or_password'});
+}

If it is right I would prefer a single patch with only the needed changes
instead of indentation changes and modification of the return value of checkpw.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14606] Donate to the Koha International Fund

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14606

--- Comment #16 from Liz Rea  ---
This button really ought to be removed, as no one has given me information
about the foundation and as far as I know it is dysfunctional.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #174 from Liz Rea  ---
Agree with Cait, this is a problem with the test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394

--- Comment #11 from Jonathan Druart  
---
Created attachment 62069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62069=edit
Bug 18394: Add an option to item search to export a barcodes file

Test plan:
1. Go to item search (/cgi-bin/koha/catalogue/itemsearch.pl)
2. Fill the form with whatever you want
3. Leave the 'Output' option to 'Screen' and click 'Search'
4. Verify that the search still works
5. Click on 'Edit search' and set 'Output' to 'Barcodes file', click 'Search'
6. You should be able to download a 'barcodes.txt' file, open it and compare it
   to the previous search results
7. Now click on the 'Export results to barcodes file' button above the results,
   you should have the same result as in step 5
8. Verify that the CSV export still works

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62006|0   |1
is obsolete||
  Attachment #62007|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  
---
Created attachment 62068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62068=edit
Bug 18394: Remove useless code from item search

The item search was originally designed to work even with JS disabled.
Since bug 15111, the staff interface does not work at all without JS, so some
parts of this code are useless and should be removed

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #9 from Jonathan Druart  
---
(In reply to delaye from comment #8)
> The number of exported barcodes remains unchanged despite the use of filters
> in the result table

Yes right, but this behavior already existed when exporting as CSV.

Julian, any chances to see you fix that on another bug report? :)

Passing QA this one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18375] Better readability of patron category table for zero ages and fees

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18375

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #61867|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 62067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62067=edit
Bug 18375: Better readability of patron category table for zero ages and fees

In patron category table, this patch displays zero / empty values for ages and
fees with '-' for better readability

To test:
- Go to Home > Administration > Patron categories
- Verify that you have 0 years and/or only years in Age required and Uper age
limit colums
- Verify that you have Enrollment and Hold fees of 0.00
- Apply patch
- Verify that such values are replaced by - to enhance table readability

Signed-off-by: Luke Honiss 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18375] Better readability of patron category table for zero ages and fees

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18375

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17309] Renewing and HomeOrHoldingBranch syspref

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309

--- Comment #11 from Katrin Fischer  ---
Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17309] Renewing and HomeOrHoldingBranch syspref

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309

David Kuhn  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2454] Don't show credits on Pay Fines Tab

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
Hi Felix, if there is a problem like the ones you describe, it's totally ok to
set 'failed qa' - 'in discussion' is more when more opinions are needed or when
there is disagreement about the implementation.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17872] Fix small error in GetBudgetHierarchy and one of its calls

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17872

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17872] Fix small error in GetBudgetHierarchy and one of its calls

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17872

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62064|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 62066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62066=edit
Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls

In aqbudgetperiods.pl a commented line is removed that contains a
wrong userenv hash key. Should be branch instead of branchcode.

In aqbudgets GetBudgetHierarchy is called with the same wrong userenv
hash key. Should be userenv->{branch}.
This made another bug visible: if you call GetBudgetHierarchy with a
branch and without owner, the where clause should take into account
that the branchcode can be empty (not null).

Test plan:
[1] Run Budgets.t
[2] Run aqbudgets.pl from Administration
[3] Add the show_mine=1 parameter in the URL
[4] Change owner of one of the funds and repeat step 2 and 3.

t/Budgets.t returns green. Followed test plan, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18411] t/db_dependent/www/search_utf8.t fails on 16.11.x

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411

--- Comment #6 from Jonathan Druart  
---
Tomas,

I get the following if I launch the tests manually on jenkins
t/db_dependent/www/search_utf8.t .. 9/66 Error GETing
http://koha_16_11:8080/cgi-bin/koha/tools/background-job-progress.pl?jobID=741d649f9d4472fe75f30761ba2488c0:
Bad Request at t/db_dependent/www/search_utf8.t line 170.

But nothing in the logs to debug. Any ideas?

I just see the apache access log which indeed returns a 400
koha_16_05:8080 127.0.0.1 - - [11/Apr/2017:20:54:24 +] "GET
/cgi-bin/koha/tools/background-job-progress.pl?jobID=741d649f9d4472fe75f30761ba2488c0
HTTP/1.1" 400 0
"http://koha_16_11:8080/cgi-bin/koha/tools/stage-marc-import.pl;
"Test-WWW-Mechanize/1.42"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18411] t/db_dependent/www/search_utf8.t fails on 16.11.x

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411

--- Comment #5 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #4)
> I get much more errors that Jenkins's ones.
> Someone else to take a look?

Ok pass for me locally finally.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #173 from Katrin Fischer  ---
Hm, should we not fix the test instead? Not sure I understood correctly, but
having a category of 'S' should not be mandatory for the tests to pass in a
normal environment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #172 from Marc Véron  ---
Hi Alex,

Just found a small problem while testing around with an installation that was
configured using the onboarding tool. 

The problem was a test failing: t/dbdependent/Budgets.t
I figured out that while onboarding, step 'Create a new patron category', I had
put a Categorycode that was not 'S' (something like 'STAFF'). The test assumes
that a category 'S' exists and fails without it.
I can imagine that other tests and other scripts could fail as well.

I went again through installation / onboarding and set the category code to
'S'. Now the test passed.

Maybe it is a good idea to have in the Onboarding tool a fix value 'S' for the
new patron category. What do you think about?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18387] 404 errors on page causes SCO user to be logged out

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387

--- Comment #5 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #4)
> I would not consider this as a bug, you just need to fix the url ...right?

Technically yes, but no visible error is thrown to the user, you are just
silently signed out. Why fetch the 404 error template if we aren't displaying
it?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829

--- Comment #5 from Jonathan Druart  
---
I have worked for several days on bug 18403, on top of these patches, and did
not find any errors.
I am quite confident with these patches, even if the changes are important.
Please do not let them wait too long.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18367] Fix untranslatable string from Bug 18264

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18367

--- Comment #1 from Nick Clemens  ---
Created attachment 62065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62065=edit
Bug 18367 - Fix untranslatable string from Bug 18264

Restore display of message when no barcode found

To test:
1 - Go to course reserves
2 - Add an item to a course
3 - Try adding an invalid barcode - should get an alert
4 - Try force adding an item with itemnumber:
   
http://localhost:8081/cgi-bin/koha/course_reserves/add_items.pl?op=lookpup_id=11=1234523546
5 - Should recieve an error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18367] Fix untranslatable string from Bug 18264

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18367

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18387] 404 errors on page causes SCO user to be logged out

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387

--- Comment #4 from Jonathan Druart  
---
I would not consider this as a bug, you just need to fix the url ...right?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18387] 404 errors on page causes SCO user to be logged out

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387

--- Comment #3 from Jonathan Druart  
---
I would not consider this as a bug, you hyst need to fix the url ...right?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17872] Fix small error in GetBudgetHierarchy and one of its calls

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17872

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17872] Fix small error in GetBudgetHierarchy and one of its calls

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17872

Marc Véron  changed:

   What|Removed |Added

  Attachment #58723|0   |1
is obsolete||

--- Comment #5 from Marc Véron  ---
Created attachment 62064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62064=edit
Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls

In aqbudgetperiods.pl a commented line is removed that contains a
wrong userenv hash key. Should be branch instead of branchcode.

In aqbudgets GetBudgetHierarchy is called with the same wrong userenv
hash key. Should be userenv->{branch}.
This made another bug visible: if you call GetBudgetHierarchy with a
branch and without owner, the where clause should take into account
that the branchcode can be empty (not null).

Test plan:
[1] Run Budgets.t
[2] Run aqbudgets.pl from Administration
[3] Add the show_mine=1 parameter in the URL
[4] Change owner of one of the funds and repeat step 2 and 3.

t/Budgets.t returns green. Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #8 from Jonathan Druart  
---
#   Failed test at t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
line 112.
#  got: 'donald duck'
# expected: 'donald* duck*'

#   Failed test at t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
line 114.
#  got: 'donald or duck and mickey not mouse'
# expected: 'donald* or duck* and mickey* not mouse*'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14590] Validate messaging preferences

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18418] Advanced Editor - Rancor - Add a control number widget

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18418

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18418] Advanced Editor - Rancor - Add a control number widget

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18418

--- Comment #1 from Nick Clemens  ---
Created attachment 62063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62063=edit
Bug 18418 - Advanced Editor - Rancor - Add a control number widget

This patchset adds a control number widget - numbers are generated using
an authorised value in the CONTROL_NUM_SEQUENCES category

Test plan:
1 - Apply patch
2 - Enable helpers for fixed and coded fields in advanced cataloging
editor
3 - Add or view 001 field
4 - You should see a 'Manually assign button
5 - Click and add control number
6 - Note the title when hovering over the button
7 - Add an authorised value in the CONTROL_NUM_SEQUENCES category with
initial value as 'authorised_value' and Description as you choose
8 - Reload the editor or load a new record
9 - note you now have an 'Assign next' button or an Override button -
test both

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18228] Make list permissions easier to use/understand

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228

--- Comment #23 from Jonathan Druart  
---
Basically with this patch we are going to remove the "Let people adds stuffs to
this list but do not let them remove stuffs from this list (unless added by
themself)" option.

If nobody uses it, this patch makes code and interface much more easy to
read/understand.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18419] New: Broken patron-blank image in viewlog.tt

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18419

Bug ID: 18419
   Summary: Broken patron-blank image in viewlog.tt
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: ephettepl...@cca.edu
QA Contact: testo...@bugs.koha-community.org

Created attachment 62062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62062=edit
screenshot

The theme's patron-blank.png image is incorrectly referenced from the
viewlog.tt template, resulting in a broken image. One can see this by going to
the logs tool, selecting the "Patrons" module, and filling in a borrowernumber
under "object" which matches a patron who does not have a custom image.
Screenshot attached.

I believe this is due to the interaction between line #13 of circ-menu.inc and
lines #58-66 of viewlog.tt. The circ menu include expects a value like
"/intranet-tmpl" for the "interface" variable (this is what's used on
circulation.tt, for instance) while viewlog.tt has a switch statement that
assigns the value "Intranet" to the variable, causing the link to break.

I'd offer a patch except I'm not sure how the interface value is used
throughout viewlog.tt and its includes, or why it appears to refer to the same
interface (the intranet) in two different forms for two different templates.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264

--- Comment #16 from Nick Clemens  ---
The 'bug' part is reproducible on 16.11, I filed as a bug because it can cause
issues in those limited cases where barcodes are removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17956] Provide additional functionality in the onboarding tool through configuring z-targets , and providing information on setting up SIP and LDAP services

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17956

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17956] Provide additional functionality in the onboarding tool through configuring z-targets , and providing information on setting up SIP and LDAP services

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17956

Marc Véron  changed:

   What|Removed |Added

  Attachment #6|0   |1
is obsolete||

--- Comment #12 from Marc Véron  ---
Created attachment 62061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62061=edit
Bug 17956 - Fixed the indentation of onboardingstep6.tt.

Ensured SIP2 was written in the joint SIP and LDAP information screen

Followed test plan from comment #9, works as expected
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #36 from Jonathan Druart  
---
(In reply to Paul Poulain from comment #35)
>  * Not sure we should use Koha/Reports.pm & Report.pm. Why not something
> related to Mana (ie: Koha/Mana/Reports.pm, Koha/Mana/Reports.pm) [this is a
> question]

They make sense to me, they are related to the (badly named) table saved_sql

>  * Some "+# Copyright 2016 BibLibre Morgane Alonso" => you're Baptiste, not
> Morgane (and we're now 2017)

After a very quick look at the code it seems that it is some code written by
Morgane and moved by Baptiste, sounds right to keep it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18418] Advanced Editor - Rancor - Add a control number widget

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18418

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
   Assignee|gmcha...@gmail.com  |n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18418] New: Advanced Editor - Rancor - Add a control number widget

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18418

Bug ID: 18418
   Summary: Advanced Editor - Rancor - Add a control number widget
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021

Marc Véron  changed:

   What|Removed |Added

  Attachment #61640|0   |1
is obsolete||

--- Comment #17 from Marc Véron  ---
Created attachment 62060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62060=edit
Bug 12021 - SIP2 checkin should alert on transfer and use CT for return branch

This small patch corrects the SIP2 checkin response if branch transfer is
needed.
It depends on bug 7981 and also removes an obsolete alert check in SIP2.

Test plan:
 - apply bug 7981
 - make sure syspref AutomaticItemReturn is false
 - check 'Return policy' in 'Default checkout, hold and return policy'
 - make a SIP2 checkout and checkin from a branch different than item's home
branch.
 - verify that SIP2 response gives alert CV04 (=send to different branch)
 - also verify that response field CT gives correct branch according to 'Return
policy'

Signed-off-by: Kyle M Hall 

Followed test plan, works as expected
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17665] SIP2 Item Information Response returns incorrect circulation status of ' 08' ( waiting on hold shelf ) if record has any holds

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17665

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17665] SIP2 Item Information Response returns incorrect circulation status of ' 08' ( waiting on hold shelf ) if record has any holds

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17665

Marc Véron  changed:

   What|Removed |Added

  Attachment #57703|0   |1
is obsolete||

--- Comment #4 from Marc Véron  ---
Created attachment 62059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62059=edit
Bug 17665 - SIP2 Item Information Response returns incorrect circulation status
of '08' ( waiting on hold shelf ) if record has any holds

If a record has any holds on it, the SIP2 item information response will
return a value of 08 "waiting on hold shelf" even if the item is not
actually a waiting hold. This is clearly a bug.

Test Plan:
1) Find an item that is not a waiting hold, but whose record has one or
   more holds.
2) Issue a SIP2 item information request
3) Note in the response, the circulation status field is '08'
4) Apply this patch
5) Repeat the item informationr request
6) Note the code is now '03' ( available )
7) Check the item in to fill the hold
8) Repeat the item information request
9) Verify the circulation status is now '08'

Followed test plan, works as expected
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17309] Renewing and HomeOrHoldingBranch syspref

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309

--- Comment #10 from Katrin Fischer  ---
I am asking, because it is marked as enh - please switch to the appropriate
severity! (Second input after Importance) Enh are usually not backported to
stable releases, so it's important to set the right status :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #27 from Owen Leonard  ---
Sorry, patch doesn't apply. I'll test ASAP after rebased patches are attached.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18372] transits are not created at check in despite user responsing Yes to the prompt

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18372

Owen Leonard  changed:

   What|Removed |Added

Version|16.11   |master
   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18372] transits are not created at check in despite user responsing Yes to the prompt

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18372

--- Comment #4 from Owen Leonard  ---
Created attachment 62058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62058=edit
Bug 18372 - transits are not created at check in despite user responsing Yes to
the prompt

If the AutomaticItemReturn system preference is set to "Don't" and you
check in an item which belongs to another library, a dialog will ask you
if you want to transfer. This patch corrects a bug to enable the "Yes"
buttons to work, triggering the transfer.

To test, apply the patch and check in an item which belongs to another
library. In the dialog, click the 'Yes' button and confirm that the item
has been made 'in transit' to the correct library.

Perform the same test with the 'Yes, print slip' and 'No' buttons and
confirm they are working correctly.

Since this patch changes the behavior of many other popups triggered
from this template, test other operations which trigger a 'print slip'
option like:

- Checking in an item which is part of a rotating collection
- Checking in an item which is on hold for a patron

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18372] transits are not created at check in despite user responsing Yes to the prompt

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18372

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17309] Renewing and HomeOrHoldingBranch syspref

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309

--- Comment #9 from David Kuhn  ---
(In reply to Katrin Fischer from comment #8)
> Enhancement or bug?

This patch is to fix a bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

--- Comment #37 from Julian Maurice  ---
(In reply to Marc Véron from comment #36)
> German page displays "Es gibt nur eine Kategorie..." (WRONG)

It depends on how you configured the Plural-Forms header, but by convention,
msgstr[0] is the singular form and msgstr[1] is the plural form, so it looks ok
to me

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P)

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417

--- Comment #1 from Nick Clemens  ---
Created attachment 62057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62057=edit
Bug 18417 - Advanced Editor - Rancor - add shortcuts for copyright symbols (C)
(P)

To test:
1 - Apply patch
2 - Open advanced cataloging editor
3 - Try using Alt+P and Alt+C and note symbols are added
4 - Save record and ensure symbols are saved

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P)

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P)

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417

Nick Clemens  changed:

   What|Removed |Added

Summary|Advanced Editor - Rancor -  |Advanced Editor - Rancor -
   |add shortcuts for copyright |add shortcuts for copyright
   |symbols © ℗ |symbols (C) (P)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols © ℗

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417

Nick Clemens  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |n...@bywatersolutions.com
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18417] New: Advanced Editor - Rancor - add shortcuts for copyright symbols © ℗

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417

Bug ID: 18417
   Summary: Advanced Editor - Rancor - add shortcuts for copyright
symbols © ℗
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

--- Comment #36 from Marc Véron  ---
OK, I tested with 3 files:

koha-tmpl/intranet-tmpl/prog/en/js/categories.js
koha-tmpl/intranet-tmpl/prog/js/staff-global.js
koha-tmpl/opac-tmpl/bootstrap/js/global.js

All files were picked up in Koha.po

I translated them and did a translate install

Example for JavaScript used (added as line 1 of
koha-tmpl/intranet-tmpl/prog/en/js/categories.js):

alert(__nx("There is one category", "There are {count} categories", 4, {count:
4}));

Translation in misc/translator/po/de_DE/LC_MESSAGES/Koha.po:

#: koha-tmpl/intranet-tmpl/prog/en/js/categories.js:1
msgid "There is one category"
msgid_plural "There are {count} categories"
msgstr[0] "Es gibt {count} Kategorien"
msgstr[1] "Es gibt nur eine Kategorie..."

English page displays "There are 4 categories"  (OK)
German page displays "Es gibt nur eine Kategorie..." (WRONG)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18415] Advanced Editor - Rancor - return focus to editor after successful macro

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18415

--- Comment #1 from Nick Clemens  ---
Created attachment 62056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62056=edit
Bug 18415 - Advanced Editor - Rancor - return focus to editor after successful
macro

After running a macro we should return focus to the editor screen so
editing can continue from keyboard

To test:
1 - Create a macro
   007=vd cvaizq
2 - Run it and note focus is not on editor
3 - Apply patch
4 - Reload page
5 - Run macro
6 - Note focus is returned to editor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18415] Advanced Editor - Rancor - return focus to editor after successful macro

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18415

Nick Clemens  changed:

   What|Removed |Added

   Severity|enhancement |trivial
   Assignee|gmcha...@gmail.com  |n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18415] Advanced Editor - Rancor - return focus to editor after successful macro

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18415

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18416] New: Allow local uploading of audio files

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18416

Bug ID: 18416
   Summary: Allow local uploading of audio files
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bibli...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Staff can currently use the AudioAlerts preference to control which sounds are
played based on particular triggers (for example, a bad barcode scan).

At present there is a limited number of built-in sounds to choose from.

It would be great if libraries could upload their own sound files so that
customized messages could be used.

Think of the possibilities -- Warnings in Darth Vader's voice. Reminders in a
soothing British accent. Etc.

Koha already allows for local book cover files to be uploaded, so I don't
believe there would be any major technical obstacles.

Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18415] New: Advanced Editor - Rancor - return focus to editor after successful macro

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18415

Bug ID: 18415
   Summary: Advanced Editor - Rancor - return focus to editor
after successful macro
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18228] Make list permissions easier to use/understand

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228

--- Comment #22 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #19)
> I'd like to get users' opinions before removing features. I have no idea if
> these permissions are used or not.
> I agree that it is not very clear, but we can still make the interface more
> easier to use/understand instead of remove features.

In response to comment17 and comment19 I wrote the Koha mailing list and asked
for feedback on this report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Paul Poulain  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #35 from Paul Poulain  ---
Verified that, with mana OFF, nothing changes & Koha still working :
 * SQL => everything is OK
 * subscriptions => ERROR
On the logs I see:
Use of uninitialized value $loggedinuser in string ne at
/home/koha/src/Koha/SharedContent.pm line 89.
Can't call method "email" on an undefined value at
/home/koha/src/Koha/SharedContent.pm line 91.


Some QA comments:
 * patch description : "2 - Copy the three lines about mana config in
etc/koha-conf.xml in ../etc/koha-conf.xml" => not very clear. Better "copy in
your koha-conf.xml the 3 lines about mana configuration the 3 lines you'll find
in $KOHA_SRC/etc/koha-conf.xml"
 * some "+# Copyright ByWater Solutions 2015" => Yikes, it's Biblibre 2017, not
ByWater 2015 ;-)
 * Not sure we should use Koha/Reports.pm & Report.pm. Why not something
related to Mana (ie: Koha/Mana/Reports.pm, Koha/Mana/Reports.pm) [this is a
question]
 * Some "+# Copyright 2016 BibLibre Morgane Alonso" => you're Baptiste, not
Morgane (and we're now 2017)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18228] Make list permissions easier to use/understand

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228

--- Comment #21 from Marcel de Rooy  ---
(In reply to Owen Leonard from comment #20)
> From my perspective this simplification will make things easier and doesn't
> take away any functionality we use.
> 
> What is the purpose of the "Allow changes to contents from - Nobody" option?
> Why is it useful to create a list which you cannot add to, only delete
> altogether?
> 
> The combination of "Category - Private" and "Allow changes to contents from:
> -- Anyone seeing this list" is confusing since the staff client lacks the
> "share" feature. Without knowing that you *could* share the list from the
> OPAC, allowing others to change a private list doesn't make sense.
> 
> It would be nice to get sharing working in the staff client.

Thanks for responding. Good to read that the simplification is not interpreted
as feature loss.

The "Allow changes from Nobody" locks a list: you cannot add, but you cannot
delete too. (A contents change is an add or a delete.) Some people may find it
comfortable that the list is protected from accidental/incidental changes.

The combination of Private and "Anyone seeing" is indeed a bit confusing
(altough still true). Might add a follow-up or a new report for it.

Sharing in the staff client certainly is a new report. I can at least open one
to get some more feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #107 from Marcel de Rooy  ---
Created attachment 62055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62055=edit
Bug 9988: [QA Follow-up] Satisfy QA issues

[1] See comment102. Moved sub reporting_tag_xml to MergeRequest.pm.
Adjusted t/db_dependent/Koha/Authorities.t accordingly.
This resolves the C3 inconsistent hierarchy errors.
[2] Removed empty POD section Instance Methods from MergeRequests.
This resolves the POD error in comment102 point 2.
[3] Include a tag 100 for UNIMARC in reporting_tag_xml to resolve an error
on encoding in MARC::File::XML. Subtest for oldmarc and subtest for
reporting_tag_xml adjusted accordingly.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #106 from Marcel de Rooy  ---
(In reply to Julian Maurice from comment #102)
> 4) Koha::Authorities::get_usage_count and
> Koha::Authorities::linked_biblionumbers look very similar. Is there a real
> performance gain to use get_usage_count instead of linked_biblionumbers ?
> C4::Authorities::merge call them both and it looks like we could save one
> search request by calling only linked_biblionumbers

Yes, there is a performance gain depending on the number of linked records. A
significant difference between both subs is the second and third parameter of
the simple_search_compat call. And the biblionumber extraction of course.
I first worked with one sub doing both, but in the end I felt that separating
them resulted in cleaner code. I would prefer not to change them on this report
anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #33 from Baptiste  ---
Created attachment 62053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62053=edit
Bug 17047 - Don't show action column (use link) on mana search page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #34 from Baptiste  ---
Created attachment 62054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62054=edit
Bug 17047: Add report, factorize code, add a comment feature

Interface :
- On mana-search, rows are now sorted by date of last import, then by number of
users
- Windows redisigned to improve the user experience
- New Feature : report a record.
 - peoples can now report a weird report
 - if a record is reported a lot of time, it will appear differently
- Added few tooltip (to explain the fields last import, nb of users, to explain
  the new feature)
- Added the syspref "AutoShareWithMana", which enables to select which fields
  you want to share automatically with mana

API (svc/mana)
- add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a
resource
- no hardcoding for resources in the code of api (api needs to be called with a
ressourcename)

- Factorize a lot of code in order to improve the speed of next developments

SytemPreferences:
Mana Activation:
- add a field "no, let me think" at the syspref "Mana"
- as long as this field is selected, messages ask if user want to activate
it
messages in pages:
- Administration
- Add-subscription(page 2)
AutoShareWithMana
- Add the syspref AutoShareWithMana: user can automatically share infos
with mana (automatically not set)

Report Share
- Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
- New feature: share reports with Mana
- New feature: search report in Mana Knowledge Base with keywords
- New feature: load reports from Mana

Comment Resources
- The comments can now be manually added
- On a resource mana datatable, you can now see comments, add comment and vote
for comments you think pertinent
- Comments are NOT dynamically generated on the table you need to reload the
page when you vote

Test plan:
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in
../etc/koha-conf.xml
3 - Check Mana syspref and AutoShareWithMana syspref are not activated

4 - subscriptions
- Try create a new subscription for a first serial  => mana shouldn't show you
anything (except if the base hase been filled)
- Share this serial with Mana (on the serial individual's page there must be a
Share button)
- Try to create a new subscription for serial nr1 => a message should appear
when you click on "next", click on "use", the fields should automaticaly appear
- Activate AutoShareWithMana => Subscriptions
- Create a new subscription for a second serial
- There shouldn't be any Share button
- Create a second subscription => the message should appear, click again on use

5 - Report
- Create a new report, without notes.
- On the table with all report (reports > use saved), there should be the
action "Share"
- If you click on share, you have an error message
- Create a new report, with a title and notes longer than 20 characters
- You  can share it with mana => you will have a success message
- On (report > use saved), there must be a message inviting you to search on
mana KB for more results, enter a few word from title, notes, type of  the
report you shared, it should appear. You can use it, it will load it into your
report list.

6 - Comments.
- On any table containing mana search results, you can comment. To comment,
click on report mistake. For now, you only can chose "other".
- If you click other, a new textbox appears. Enter a short comment.
- Reload the whole page, the comment should appear in the menu and in the
comment column.
- If you select a comment and reload the whole page, there should be one more
comment with this name
- If you select a comment and click on cancel just after, there shouldn't be
any change when you reload.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #32 from Baptiste  ---
Created attachment 62052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62052=edit
Bug 17047 - Don't create numberpattern if the same exists

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #31 from Baptiste  ---
Created attachment 62051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62051=edit
Bug 17047 - Use Koha::Libraries instead of GetBranches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #30 from Baptiste  ---
Created attachment 62050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62050=edit
Bug 17047 Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #29 from Baptiste  ---
Created attachment 62049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62049=edit
Bug 17047 ability to import a subscription model from mana

- modify subscription-add.tt and subscription.pl to manage a
import from mana during a subscription creation
- add 2 script in svc for ajax calling from subscription-add.tt
to communicate with mana server during a asubscription creation
- add a function in Subscription.pm to have all the info for a mana research
from a biblionumber
- modify functions used by subscription-add.pl in C4/Serials to manage a
frequency which came from mana server and not already created on the
koha database, and modify the tests of the said functions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #28 from Baptiste  ---
Created attachment 62048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62048=edit
Bug 17047 ability to share a subscription to mana

- add a mana_id to subscription table
- add a share button on serials-toolbar.inc and a modal to ask
the language of the share and to alert if the subscription is
already link to a mana subscription model
- add function in C4/Serials to get all the info for a subscription
sharing
- modify subscription-detail.pl to manage sharing to mana

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #27 from Baptiste  ---
Created attachment 62047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62047=edit
Bug 17047 ability to search subscription model on mana

- add a class SharedContent.pm to communicate with mana server
- add a link in serials-menu.inc to serials_search.pl to open
a mana-subscription research form
- modify the research form in serials-search.tt to show the right fields
for mana
- create datatable in mana-subscription-search-result.inc to show
results from a research on mana
- modify serials-search.pl to manage research on mana

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #26 from Baptiste  ---
Created attachment 62046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62046=edit
Bug 17047 add frequencies and numberpattern in subscription class

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Baptiste  changed:

   What|Removed |Added

  Attachment #56175|0   |1
is obsolete||
  Attachment #56176|0   |1
is obsolete||
  Attachment #56177|0   |1
is obsolete||
  Attachment #56178|0   |1
is obsolete||
  Attachment #56179|0   |1
is obsolete||
  Attachment #56180|0   |1
is obsolete||
  Attachment #56181|0   |1
is obsolete||
  Attachment #59728|0   |1
is obsolete||
  Attachment #59931|0   |1
is obsolete||
  Attachment #61905|0   |1
is obsolete||

--- Comment #25 from Baptiste  ---
Created attachment 62045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62045=edit
Bug 17047 add mana syspref

Add the system preference to enable or disable mana
webservice on koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18411] t/db_dependent/www/search_utf8.t fails on 16.11.x

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411

--- Comment #4 from Jonathan Druart  
---
I get much more errors that Jenkins's ones.
Someone else to take a look?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #105 from Marcel de Rooy  ---
(In reply to Julian Maurice from comment #103)
> 5) When I merge 2 authorities on the staff interface, I get a
> UNIMARC-related error:
> 
> Unsupported UNIMARC character encoding [] for XML output for UNIMARCAUTH;
> 100$a ->  at /usr/share/perl5/MARC/File/XML.pm line 568.
> 
> It's triggered by MARC::Record::as_xml in
> Koha::Authority::MergeRequests::reporting_tag_xml.
> 
> It seems to work correctly when I add the following code before as_xml:
> 
> # Copied from AddAuthority
> my $date = POSIX::strftime("%Y%m%d", localtime);
> my $defaultfield100 =
> C4::Context->preference('UNIMARCAuthorityField100');
> $newrecord->append_fields(
> MARC::Field->new('100', ' ', ' ' , 'a'=> $date.$defaultfield100)
> );

Thanks. This error actually is the same as point 3 of the previous comment. I
will add an absolute minimum 100 with encoding only for UNIMARC to resolve the
problem in MARC::File::XML.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18411] t/db_dependent/www/search_utf8.t fails on 16.11.x

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411

--- Comment #3 from Katrin Fischer  ---
Hm, ok, but how would we do this for Jenkins?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14590] Validate messaging preferences

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590

Lari Taskula  changed:

   What|Removed |Added

  Attachment #62043|0   |1
is obsolete||

--- Comment #17 from Lari Taskula  ---
Created attachment 62044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62044=edit
Bug 14590: Validate messaging preferences

Messaging preferences should be only available if a valid contact information
is stored for the patron for that transport type. Otherwise, it should not be
possible to select preferences for that transport type.

For example, when attempting to set messages to be delivered via sms, we should
automatically check patron's smsalertnumber before allowing this type of
modification. If patron does not have a valid smsalertnumber and is not passing
it along with the messaging preference change, we should not store those given
messaging transport types.

This patch implements exactly this. It uses Koha::Validation from Bug 14620
to validate contact informations and attaches it into patron modification
logic - whenever messaging preferences are processed by Koha, preferences
that link to an invalid or non-existent contact information will be removed.

Client-side JavaScript checks are also implemented. When modifying patron
information, messaging preferences for a certain transport type will be either
enabled and/or disabled on the fly depending on validity of the contact info
linked to that transport type (transport type "sms" => borrower
"smsalertnumber").

TESTING:
This feature requires tests both in OPAC and staff client.

Requirements:
1. Apply patch(es) in Bug 14620 before this patch
2. Make sure EnhancedMessagingPreferences is enabled
3. Make sure EnhancedMessagingPreferencesOPAC is enabled
4. Make sure TalkingTechItivaPhoneNotification is enabled (activates transport
   type "phone")
5. Make sure SMSSendDriver is enabled (for simple testing purposes you can use
   the value "test")
6. Preference "ValidatePhoneNumber" needs a regular expression for validating
   phone numbers. An example regular expression is provided below the input
   field. You can use that while testing this feature. Copy-paste it into the
   input box and save preferences. (regex also provided below)
^((\+)?[1-9]{1,2})?([-\s\.])?((\(\d{1,4}\))|\d{1,4})(([-\s\.])?[0-9]{1,12}){1,2}$

TEST PLAN:
1. Login to staff client
2. Go to modification view of any patron
3. Scroll down all the way and you should see "Patron messaging preferences"
   table including checkboxes for transport types "SMS", "Phone" and "Email".
4. If the patron you are modifying has any contact information of the following
   "Primary email", "Primary phone", "SMS number", please clear those fields.
5. Scroll down. All checkboxes for the given transport types should now
   be disabled.
6. Modify field "Primary email" and insert "test". A warning of invalid email
   should appear.
7. Scroll down. Checkboxes for transport type "Email" should still be disabled.
8. Modify field "Primary email" and insert "nob...@example.com".
9. Scroll down. Checkboxes for transport type "Email" should now be enabled.
10. Select email as transport type for each message type and click "Save".
11. Go back to modification screen. The messaging preferences should still
appear as you stored them.
12. Repeat steps 6-11 also for both "Phone" and "SMS number". When inserting
text into phone number fields, they should appear as invalid, so test
like that.
13. After successful testing, test also other patron modification screens. Go
to patron's Details tab and you should see multiple "Edit" links on that
page. The point is to make sure transport type selections are correctly
removed from the patron if the modification screen lets you modify for
example primary email, but does not present the messaging preferences
at the bottom of the page. So, as an example, first insert patron a valid
email and select all email transport types. Then, go to the "Edit" link
right above "Patron messaging preferences" title on patron's details page.
This page lets you modify "Primary email" but not messaging preferences.
Clear the "Primary email" field and save, and observe that all previously
selected email transport types are now removed.
14. Give your patron a valid email and go to Details tab -> "Edit" link below
"Patron messaging preferences title" on the left. You should still be able
to select email as transport types.
15. Go remove patron's primary email and repeat step 14. You will observe that
it is no longer possible to select email as a transport type.
16. Try steps 13-15 with other transport types as well

After this test plan you should have a pretty good idea of the feature. As
mentioned earlier, this

[Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs)

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733

--- Comment #39 from Jonathan Druart  
---
I really would like to see them backported, it will greatly simplify setup of
installation based on stable releases and so backporting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14590] Validate messaging preferences

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590

--- Comment #16 from Lari Taskula  ---
Rebased on master & rewrote much of the patch and added a more detailed test
plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18411] t/db_dependent/www/search_utf8.t fails on 16.11.x

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411

--- Comment #2 from Jonathan Druart  
---
(In reply to Mason James from comment #1)
> ./t/db_dependent/www/search_utf8.t .. You tried to plan twice at

You did not specify KOHA_INTRANET_URL and KOHA_OPAC_URL

% KOHA_INTRANET_URL=http://pro.kohadev.vm
KOHA_OPAC_URL=http://catalogue.kohadev.vm prove
t/db_dependent/www/search_utf8.t
t/db_dependent/www/search_utf8.t .. ok 
All tests successful.
Files=1, Tests=66, 67 wallclock secs ( 0.03 usr  0.00 sys +  1.44 cusr  0.76
csys =  2.23 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14606] Donate to the Koha International Fund

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14606

Pablo AB  changed:

   What|Removed |Added

 CC||pablo.bian...@gmail.com

--- Comment #15 from Pablo AB  ---
Right now I get an error using donate button: "Error Detected: PayPal cannot
process this transaction because of a problem with the seller's website. Please
contact the seller directly to resolve this problem."

I'd be less shy about this subject, like Wikipedia or Canonical. Why not a
Donate button in the black menu top bar?

BTW, why not also offer some other alternatives?
- A donation site better than Paypal: donorbox.org, bountysource.com,
liberapay.com, patreon.com.
- QR code to donate to a Bitcoin wallet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14590] Validate messaging preferences

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590

Lari Taskula  changed:

   What|Removed |Added

  Attachment #62040|0   |1
is obsolete||

--- Comment #15 from Lari Taskula  ---
Created attachment 62043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62043=edit
Bug 14590: Validate messaging preferences

Messaging preferences should be only available if a valid contact information
is stored for the patron for that transport type. Otherwise, it should not be
possible to select preferences for that transport type.

For example, when attempting to set messages to be delivered via sms, we should
automatically check patron's smsalertnumber before allowing this type of
modification. If patron does not have a valid smsalertnumber and is not passing
it along with the messaging preference change, we should not store those given
messaging transport types.

This patch implements exactly this. It uses Koha::Validation from Bug 14620
to validate contact informations and attaches it into patron modification
logic - whenever messaging preferences are processed by Koha, preferences
that link to an invalid or non-existent contact information will be removed.

Client-side JavaScript checks are also implemented. When modifying patron
information, messaging preferences for a certain transport type will be either
enabled and/or disabled on the fly depending on validity of the contact info
linked to that transport type (transport type "sms" => borrower
"smsalertnumber").

TESTING:
This feature requires tests both in OPAC and staff client.

Requirements:
1. Apply patch(es) in Bug 14620 before this patch
2. Make sure EnhancedMessagingPreferences is enabled
3. Make sure EnhancedMessagingPreferencesOPAC is enabled
4. Make sure TalkingTechItivaPhoneNotification is enabled (activates transport
   type "phone")
5. Make sure SMSSendDriver is enabled (for simple testing purposes you can use
   the value "test")
6. Preference "ValidatePhoneNumber" needs a regular expression for validating
   phone numbers. An example regular expression is provided below the input
   field. You can use that while testing this feature. Copy-paste it into the
   input box and save preferences. (regex also provided below)
^((\+)?[1-9]{1,2})?([-\s\.])?((\(\d{1,4}\))|\d{1,4})(([-\s\.])?[0-9]{1,12}){1,2}$

TEST PLAN:
1. Login to staff client
2. Go to modification view of any patron
3. Scroll down all the way and you should see "Patron messaging preferences"
   table including checkboxes for transport types "SMS", "Phone" and "Email".
4. If the patron you are modifying has any contact information of the following
   "Primary email", "Primary phone", "SMS number", please clear those fields.
5. Scroll down. All checkboxes for the given transport types should now
   be disabled.
6. Modify field "Primary email" and insert "test". A warning of invalid email
   should appear.
7. Scroll down. Checkboxes for transport type "Email" should still be disabled.
8. Modify field "Primary email" and insert "nob...@example.com".
9. Scroll down. Checkboxes for transport type "Email" should now be enabled.
10. Select email as transport type for each message type and click "Save".
11. Go back to modification screen. The messaging preferences should still
appear as you stored them.
12. Repeat steps 6-11 also for both "Phone" and "SMS number". When inserting
text into phone number fields, they should appear as invalid, so test
like that.
13. After successful testing, test also other patron modification screens. Go
to patron's Details tab and you should see multiple "Edit" links on that
page. The point is to make sure transport type selections are correctly
removed from the patron if the modification screen lets you modify for
example primary email, but does not present the messaging preferences
at the bottom of the page. So, as an example, first insert patron a valid
email and select all email transport types. Then, go to the "Edit" link
right above "Patron messaging preferences" title on patron's details page.
This page lets you modify "Primary email" but not messaging preferences.
Clear the "Primary email" field and save, and observe that all previously
selected email transport types are now removed.
14. Give your patron a valid email and go to Details tab -> "Edit" link below
"Patron messaging preferences title" on the left. You should still be able
to select email as transport types.
15. Go remove patron's primary email and repeat step 14. You will observe that
it is no longer possible to select email as a transport type.
16. Try steps 13-15 with other transport types as well

After this test plan you should have a pretty good idea of the feature. As
mentioned earlier, this

[Koha-bugs] [Bug 18413] Fix Letters.t (follow-up of 17866)

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18413

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18413] Fix Letters.t (follow-up of 17866)

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18413

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62039|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 62042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62042=edit
Bug 18413: Fix Letters.t (following bug 17866)

SendAlert now needs a userenv to find branch email and the fallback
of KohaAdminEmailAddress if the branch mail is not filled.

Test plan:
Run t/db_dependent/Letters.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18414] New: Allow to use other select criteria with delete_patrons.pl

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18414

Bug ID: 18414
   Summary: Allow to use other select criteria with
delete_patrons.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: gmcha...@gmail.com
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

It would be nice if the delete_patrons.pl script could be enhanced to also
allow to delete patrons using a list of borrowernumbers from a file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17693] Add option to export deleted bibs in export_records.pl

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17693

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Owen Leonard  ---
If the only option for retrieving deleted records is to get a text file with
one biblionumber per line I don't think it should save a file with the ".mrc"
extension. That makes it look like it's a MARC file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18373] `make upgrade` is broken

2017-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18373

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #5 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #4)
> Can we get speedy QA on this please? The bug is present in 16.11.06.

Upping severity

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 138 matches

Mail list logo