[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #9 from Owen Leonard  ---
Setting to 'Failed QA' based on Comment 8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #11 from Jonathan Druart  
---
Aleisha, the last case is wrong, maxlength_cardnumber is evaluated false and
the message will be "Card number must not be more than  characters". That
should not be possible (because C4::Members::get_cardnumber_length returns
max=16), but the code does not make sense as it is.

Moreover you should not use the keypress event but change, that way a paste or
delete in the input will update the message as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18485] REST API: add endpoint for calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18485

Mehdi Hamidi  changed:

   What|Removed |Added

 CC||mehdi.ham...@inlibro.com

--- Comment #1 from Mehdi Hamidi  ---
Hello Mike,

What do you mean by a new endpoint? Please give us more details.

Thanks!

Mehdi Hamidi

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18486] Calendar maintenance script: correct dates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18486

Mehdi Hamidi  changed:

   What|Removed |Added

 CC||mehdi.ham...@inlibro.com

--- Comment #1 from Mehdi Hamidi  ---
Hello Mike, 

our calendar  (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015)
is supposed to handle this already, not as a maintenance script, but when
calculating fines, the borrower won't be charged for the extra day.  

Can you try your scenario and let us know?

Thanks!

Mehdi Hamidi

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18469] Suspend all holds when specifying a date to resume hold does not keep date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18469

Owen Leonard  changed:

   What|Removed |Added

  Attachment #62526|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 62612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62612=edit
[SIGNED-OFF] Bug 18469 - Suspend all holds when specifying a date to resume
hold does not keep date

Name of field had 'datepicker' embedded, this caused variable issue

To test:
 1 - Place several holds for a patron
 2 - Go to holds tab in circulation
 3 - Select a date for suspend all holds until
 4 - Suspend all holds
 5 - Note date is not used, suspended indefinitely
 6 - Apply patch
 7 - Resume all suspended holds
 8 - Select a date for suspend all holds until
 9 - Suspend all holds
10 - Note date is used

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18469] Suspend all holds when specifying a date to resume hold does not keep date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18469

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18435] Message about Materials specified does not display when items are checked out and checked in

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18435

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Severity|normal  |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18435] Message about Materials specified does not display when items are checked out and checked in

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18435

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62173|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 62611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62611=edit
Bug 18435 - Language entered in Materials Specified does not display when items
are checked out and checked in

This problem stems from bug 17642, if items.materials is not linked to
an authorized value the contents are being tossed out. We shuold display
them instead

To test:
1 - Ensure items.materials 952$3 is not mapped to an authorized value
2 - Add a value to an item
3 - Check the item out, note the materials does not display
4 - Check the item in, note the materials does not display
5 - Apply patch
6 - Check the item out, note the materials does display
7 - Check the item in, note the materials does display

Followed test plan, message about material displays as expected
whil checking out and in.
Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18435] Message about Materials specified does not display when items are checked out and checked in

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18435

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17421] Missing dependency on CGI::Emulate::PSGI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17421

--- Comment #4 from Lari Taskula  ---
Created attachment 62610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62610=edit
Bug 17421: Add Devel::Size and Plack::Middleware::Debug as Perl dependency

After fresh install, starting Plack throws the following errors:

Error while loading /home/koha/Koha/misc/plack/plack.psgi: Can't locate
Devel/Size.pm in @INC (you may need to install the Devel::Size module)

Error while loading /home/koha/Koha/misc/plack/plack.psgi: Can't locate
Plack/Middleware/Debug.pm in @INC (you may need to install the
Plack::Middleware::Debug module)

This patch adds Devel::Size and Plack::Middleware::Debug to Perl dependencies.

sudo cpanm Devel::Size
sudo cpanm Plack::Middleware::Debug

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17421] Missing dependency on CGI::Emulate::PSGI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17421

Lari Taskula  changed:

   What|Removed |Added

 CC||lari.task...@jns.fi

--- Comment #3 from Lari Taskula  ---
I got the same errors for Plack::Middleware::Debug and Devel::Size.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18452] Should say 'URL' instead of 'url' in catalog detail

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18452

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62471|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 62609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62609=edit
Bug 18452: Correcting 'url' to say 'URL' in catalog detail

To test:
1) Edit a record, put a URL in 856u and hit save
2) Confirm that url shows as URL in OPAC and staff client

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18452] Should say 'URL' instead of 'url' in catalog detail

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18452

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18484] opac-advsearch.tt missing closing div tag for .container-fluid

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18484] opac-advsearch.tt missing closing div tag for .container-fluid

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484

--- Comment #1 from Owen Leonard  ---
Created attachment 62608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62608=edit
Bug 18484 - opac-advsearch.tt missing closing div tag for .container-fluid

This patch corrects HTML validation errors by adding back a missing
 which was removed accidentally by Bug 9043 (2014!).

This patch also removes "border" attributes from  tags because the
attribute is obsolete.

To test, apply the patch and test the validity of the OPAC's advanced
search page. The only error should be one about 'Bad value
"api-server,"' which isn't really resolvable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #69 from Paul Poulain  ---
Created attachment 62607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62607=edit
Bug 17047 security token agst flooding for Mana-KB

Rework messages from Mana-KB.

- Add A syspref contains an authentication token. The token will be used to
prevent anaonymous flooding of Mana-KB
- To get an Authentication token, you have to fill a form and validate your
e-mail address
- Messages return codes are now correctly displayed and there shouldn't be any
crash when Mana-KB webservices return a wrong answer or doesn't answer

Test plan:
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in
../etc/koha-conf.xml (after  for example)


https://mana-kb.koha-community.org
3 - Check Mana syspref and AutoShareWithMana syspref are not activated
4 - Search the syspref ManaToken and follow the instructions
5 - subscriptions
  - Try create a new subscription for a first serial  => Mana-KB shouldn't
show you anything (except if the base hase been filled)
  - Share this serial with Mana-KB (on the serial individual's page there
must be a Share button)
  - Try to create a new subscription for serial nr1 => a message should
appear when you click on "next", click on "use", the fields should automaticaly
appear
  - Activate AutoShareWithMana => Subscriptions
  - Create a new subscription for a second serial
  - There shouldn't be any Share button
  - Create a second subscription => the message should appear, click again
on use

6 - SQL Report
  - Create a new SQL report, without notes.
  - On the table with all report (reports > use saved), there should be the
action "Share"
  - If you click on share, you have an error message
  - Create a new report, with a title and notes longer than 20 characters
  - You  can share it with mana => you will have a success message
  - On (report > use saved), there must be a message inviting you to search
on Mana-KB for more results, enter a few word from title, notes, type of  the
report you shared, it should appear. You can use it, it will load it into your
report list.

7 - Report mistakes.
  - On any table containing Mana-KB search results, you can report a
mistake and add a comment.

8 - For each previous test, try to send wrong data, to delete the security
token, to send nothing: it should show a correct warning message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #68 from Paul Poulain  ---
Created attachment 62606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62606=edit
Bug 17047 SQL reports management with Mana-KB

Includes:

* code factorization
Some code from subscription & Mana-KB has been factorized in order to speed-up
next developments

* SytemPreferences:
Mana Activation:
- add a value "no, let me think about it", that is the default value.
- as long as this value is selected, messages ask if user want to activate
it ( in Administration and Add-subscription(page 2) )
AutoShareWithMana
- Add the syspref AutoShareWithMana: user can automatically share infos
with Mana-KB (not set by default)

* Interface :
- On mana-search, rows are now sorted by date of last import, then by
number of users
- Windows redesigned to improve the user experience

* New Feature : report a mistake.
- people can now report an invalid data (wrong, obsolete,...)
- if a data is reported as invalid many time, it will appear differently
- Added few tooltip (to explain the fields last import, nb of users, to
explain the new feature)
- When reporting a data as invalid, a comment can also be added. Koha will
then display comments related to data in result lists

* API (svc/mana)
- add svc/mana/addvaluetofield: allows to ask mana incrementing a field of
a resource
- no hardcoding for resources in the code of api (api needs to be called
with a ressourcename)

* New feature : SQL report sharing
- Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
- New feature: share reports with Mana-KB
- New feature: search report in Mana-KB with keywords
- New feature: load reports from Mana-KB

=
Test plan
=
(see BibLibre complete documentation, attached to this patch)
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in
../etc/koha-conf.xml
3 - Check Mana syspref and AutoShareWithMana syspref are not activated

4 - subscriptions
- Try create a new subscription for a first serial  => Koha shouldn't show you
anything (except if the base hase been filled)
- Share this serial on Mana-KB (on the subscription detail page there must be a
Share button)
- Try to create a new subscription for serial #1 => a message should appear
when you click on "next", click on "use", the fields should automaticaly appear
- Activate AutoShareWithMana => Subscriptions
- Create a new subscription for a second serial
- There shouldn't be any Share button
- Create a second subscription => the message should appear, click again on use

5 - SQL Report
- Create a new report, without notes.
- On the table with all report (reports > use saved), there should be the
action "Share"
- If you click on share, you have an error message
- Create a new report, with a title and notes longer than 20 characters
- You can share it on Mana-KB => you will have a success message
- On (report > use saved), there must be a message inviting you to search on
mana-KB for more results, enter a few word from title, notes, type of the
report you shared, it should appear. You can use it, it will load it into your
report list.

6 - Comments.
- On any table containing mana search results, you can report a mistake &
comment why you report: click on report mistake. You only can chose "other"
because there's no comment in Mana-KB [if there are comments, you'll get other
values].
- If you click other, a new textbox appears. Enter a short comment.
- Reload the whole page, the comment should appear in the menu and in the
comment column.
- If you select a comment and reload the whole page, there should be one more
comment with this name
- If you select a comment and click on cancel just after, there shouldn't be
any change when you reload.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #67 from Paul Poulain  ---
Created attachment 62605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62605=edit
Bug 17047 Mana-KB, Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #66 from Paul Poulain  ---
Created attachment 62604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62604=edit
Bug 17047 subscriptions management with Mana-KB

- add a class SharedContent.pm to communicate with Mana-KB server
- add a link in serials-menu.inc to serials_search.pl to open
a mana-subscription research form
- modify the research form in serials-search.tt to show the right fields
for Mana-KB
- create datatable in mana-subscription-search-result.inc to show
results from a research on Mana-KB
- modify serials-search.pl to manage research on Mana-KB

- add a mana_id to subscription table
- add a share button on serials-toolbar.inc and a modal to ask
the language of the share and to alert if the subscription is
already link to a Mana-KB subscription model
- add function in C4/Serials to get all the info for a subscription
sharing
- modify subscription-detail.pl to manage sharing to Mana-KB

- modify subscription-add.tt and subscription.pl to manage a
import from Mana-KB during a subscription creation
- add 2 script in svc for ajax calling from subscription-add.tt
to communicate with Mana-KB server during a asubscription creation
- add a function in Subscription.pm to have all the info for a Mana-KB research
from a biblionumber
- modify functions used by subscription-add.pl in C4/Serials to manage a
frequency which came from Mana-KB server and not already created on the
koha database, and modify the tests of the said functions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Paul Poulain  changed:

   What|Removed |Added

  Attachment #62591|0   |1
is obsolete||
  Attachment #62592|0   |1
is obsolete||
  Attachment #62593|0   |1
is obsolete||
  Attachment #62594|0   |1
is obsolete||
  Attachment #62595|0   |1
is obsolete||
  Attachment #62596|0   |1
is obsolete||
  Attachment #62597|0   |1
is obsolete||
  Attachment #62598|0   |1
is obsolete||
  Attachment #62599|0   |1
is obsolete||

--- Comment #65 from Paul Poulain  ---
Created attachment 62603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62603=edit
Bug 17047 add Mana-KB syspref

Add the system preference to enable or disable Mana-KB webservice on koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18484] opac-advsearch.tt missing closing div tag for .container-fluid

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484

Owen Leonard  changed:

   What|Removed |Added

Summary|opac-advsearch.tt missing   |opac-advsearch.tt missing
   |closing div tag for |.container-fluid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18484] opac-advsearch.tt missing closing div tag for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15815] improve wording in popup warning when deleting patron from patron-batch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15815

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62469|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 62602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62602=edit
Bug 15815: Reword confirm message when removing patrons from card batch

This patch rewords the confirm message when removing patrons from a card
batch.
From: "Are you sure you want to remove card number(s):1 from this
batch?"
To: "Are you sure you want to remove the selected patron(s) from this
batch?"

To test:
1) Go to Tools -> Patron Card Creator -> Manage batches
2) Edit a batch
3) Select one or more patrons and click 'Remove selected patrons' (not
individual Delete buttons)
4) Confirm the message is worded better and easier to understand
5) Click OK and confirm the patrons are deleted as expected

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15815] improve wording in popup warning when deleting patron from patron-batch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15815

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15815] improve wording in popup warning when deleting patron from patron-batch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15815

Jonathan Druart  changed:

   What|Removed |Added

Version|3.22|unspecified
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
Aleisha, labels and patron cards scripts are very tied, I think we should apply
the same change to labels/label-edit-batch.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18409] Error when updating pickup library on patron pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18409

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18409] Error when updating pickup library on patron pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18409

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #62568|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 62601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62601=edit
Bug 18409: Make the controller for holds use Koha::Holds

Recently, there's been a major fix on the REST api swagger spec,
which involved fixing boolean values so they are actually booleans
and Koha::Object was extended to handle that.
While the swagger spec for this endpoint got fixed, such is not the case
with the implementation (the controller class).

This patch fixes this situation by:
- Specifying boolean properties as boolean in the schema file
- Fixes the controller so it returns Koha::Hold objects instead of the
  hashref returned by GetReserve, which is wrong.
- Better (than empty) descriptions are added to 'suspend',
  'suspend_until' and 'lowestPriority' on the spec.

To test:
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/db_dependent/api/v1/holds.t
=> FAIL: Tests fail, mostly due to error 500 results.
- Apply this patch
- Run:
 k$ prove t/db_dependent/api/v1/holds.t
=> SUCCESS: Tests pass!
- Sign off :-D

This can also be tested using any interface for REST apis.

Note: This endpoint lacks several of the new guidelines and is not
complete (there's no GET for single holds, etc). It is also missing
exception handling. There are probably
other bug reports for that, just thought it was worth mentioning.

Followed test plan and this patch worked as intended
Signed-off-by: Alex Buckley 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18409] Error when updating pickup library on patron pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18409

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442

--- Comment #12 from Jonathan Druart  
---
The patch is ok to me.
I'd like opinion about

$userid ||= $q_userid;

vs

  $userid ||= $q_userid if $return == 2;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Nick Clemens  changed:

   What|Removed |Added

 CC||bar...@bywatersolutions.com
   ||, cbran...@cdalibrary.org,
   ||mich...@bywatersolutions.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15741] Incorrect rounding in total fines calculations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15741

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18481

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18481] Unable to pay full fine amount.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18481

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||3379
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15741


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3379
[Bug 3379] Rounding error for fines total in
C4::Members::GetMemberAccountRecords
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3379] Rounding error for fines total in C4::Members:: GetMemberAccountRecords

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3379

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18481


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18481
[Bug 18481] Unable to pay full fine amount.
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18487] GetMemberAccountRecords returning imprecise amount - causing pay issue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18487

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Nick Clemens  ---


*** This bug has been marked as a duplicate of bug 17140 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #15 from Nick Clemens  ---
*** Bug 18487 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18481] Unable to pay full fine amount.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18481

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #3 from Nick Clemens  ---


*** This bug has been marked as a duplicate of bug 17140 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Nick Clemens  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #14 from Nick Clemens  ---
*** Bug 18481 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18487] GetMemberAccountRecords returning imprecise amount - causing pay issue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18487

Nick Clemens  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18487] GetMemberAccountRecords returning imprecise amount - causing pay issue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18487

--- Comment #1 from Nick Clemens  ---
Created attachment 62600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62600=edit
Bug 18487 - GetMemberAccountRecords returning imprecise amount - causing pay
issue

To test:
1 - Create a manual fine of 7.56
2 - Attempt to 'pay amount' 7.56
3 - Error
4 - Apply patch
5 - payment should succeed
6 - prove t/db_dependent/Members.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #23 from Alex Sassmannshausen 
 ---
Hi Daphne,

Thank you very much for taking the time to test!

I've added some comments in line.

(In reply to Daphne Hoolahan from comment #22)
> It all went pretty good and worked fine.
> 
> We just found a couple of things that are worth pointing out:
> 
> 6.1.1 – Why is the biblio number empty on this screen? Actually one of them
> has the value zero now that we went through the whole process.

The biblio number would be the number that a library assigns to an ILL when
they receive it, before they lend it out to a borrower.  As a result, the
ILLmodule will just allow it to be empty and never assigns a value to it.  It
is the librarian that manually assigns a number to it.

I need to investigate why the biblio is set to 0 in more detail, but I believe
this is because a blank field is converted to a 0 at some point in conversion
from form input to koha object.

> 6.1.2 – we noticed that we could request the same title more than once.
> Maybe not an issue but worth mentioning.

Indeed — the module currently carries out no validation.  This might be an
interesting enhancement at a later stage!

> 6.1.9 – we received the email fine but it does not say who it is from, ther
> than it has the from email address. Should it have the from organisation
> above the status or is the staff member expected to customise the email text
> to indicate their organisation?
> 
> Dear Sir/Madam,
> 
> We would like to request an interlibrary loan for a title matching the
> following description:
> 
>   - Status: New
>   - Author: A.N. Other
>   - ID: 5678
>   - Title: Interlibrary loans in Koha
> 
> Please let us know if you are able to supply this to us.
> 
> Kind Regards

The email headers (from address) should be set at the server level.  I.e.
changing the server configuration should fix that issue.  Having said that, it
may well be a good idea to add a hard-coded block with the libraries delivery
address to this template.

A future patch should use notice templates to allow customization of these
emails.

> 6.2 – We found it difficult to find any matching titles. What is keywords
> for? (especially as title has a separate entry field)

The keywords field should just search "anywhere".  Adding more keywords should
significantly reduce the number of hits.

The searches against the test system will be searching against the British
Library test API — which I'm very confident has an extremely limited result
set.

I believe that explains the difficulty you had in finding results?

> image attached
> 
> Also we got an error when we tried this search – didn’t seem to like the
> book filter:
> Error performing operation
> image attached
> 
> When trying to confirm a request from the BL
> 
> Software error:
> 
> The API responded with an error: 500 Internal Server Error
> Detail:  encoding="UTF-8"?>2017-03-28 13:15:56.941
> BST8Authentication failed: Exception
> occurred processing authentication, please contact BL Customer
> Services at
> /usr/share/koha-interleaf/Koha/Illbackends/BLDSS/Base.pm line 481.
> For help, please send mail to the webmaster
> (alex.sassmannshau...@ptfs-europe.com), giving this error message and the
> time and date of the error.

This is a peculiar error message, as it's to do with authentication.  I expect
a great number of request confirmations against the BL test system to fail, but
normally with different error messages.

I will investigate this issue in more detail.

I will also add a block with library details to the generic email template. 
Probably just after the "Kind regards".  What do you think?

Best wishes,

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3379] Rounding error for fines total in C4::Members:: GetMemberAccountRecords

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3379

Nick Clemens  changed:

   What|Removed |Added

 Blocks||18487


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18487
[Bug 18487] GetMemberAccountRecords returning imprecise amount - causing pay
issue
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18487] New: GetMemberAccountRecords returning imprecise amount - causing pay issue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18487

Bug ID: 18487
   Summary: GetMemberAccountRecords returning imprecise amount -
causing pay issue
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To recreate:
Create a manual invoice for 7.56
Pay fines, 'pay amount'
Attempt to pay 7.56
You get an error "amount paid must be less than or equal to 7.56"
Verify you can pay 7.55 - or 7.57 if you owe 7.57, but not 7.56 if you owe 7.56

Turns out $total_due is being fetched as '7.5599'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733

--- Comment #41 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #40)
> What about comment #37?

Comment 38 says it is fixes on bug 16749

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18487] GetMemberAccountRecords returning imprecise amount - causing pay issue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18487

Nick Clemens  changed:

   What|Removed |Added

 Depends on||3379
   Severity|enhancement |normal
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 CC||bar...@bywatersolutions.com
   ||,
   ||mich...@bywatersolutions.co
   ||m


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3379
[Bug 3379] Rounding error for fines total in
C4::Members::GetMemberAccountRecords
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #64 from Paul Poulain  ---
Created attachment 62599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62599=edit
Bug 17047: Add security token against spam, Rework messages from Mana.

- A syspref contains an authentication token
- To get an Authentication token, you have to fill a form and validate your
e-mail address
- Messages ar now correctly displayed and there shouldn't be any crash when
mana answer wrong/doesn't answer

Test plan:
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in
../etc/koha-conf.xml
3 - Check Mana syspref and AutoShareWithMana syspref are not activated
4 - Search the syspref ManaToken and follow the instructions
5 - subscriptions
  - Try create a new subscription for a first serial  => mana shouldn't
show you anything (except if the base hase been filled)
  - Share this serial with Mana (on the serial individual's page there must
be a Share button)
  - Try to create a new subscription for serial nr1 => a message should
appear when you click on "next", click on "use", the fields should automaticaly
appear
  - Activate AutoShareWithMana => Subscriptions
  - Create a new subscription for a second serial
  - There shouldn't be any Share button
  - Create a second subscription => the message should appear, click again
on use

6 - Report
  - Create a new report, without notes.
  - On the table with all report (reports > use saved), there should be the
action "Share"
  - If you click on share, you have an error message
  - Create a new report, with a title and notes longer than 20 characters
  - You  can share it with mana => you will have a success message
  - On (report > use saved), there must be a message inviting you to search
on mana KB for more results, enter a few word from title, notes, type of  the
report you shared, it should appear. You can use it, it will load it into your
report list.

7 - Comments.
  - On any table containing mana search results, you can comment. To
comment, click on report mistake. For now, you only can chose "other".
  - If you click on other, a new textbox appears. Enter a short comment.
  - Reload the whole page, the comment should appear in the menu and in the
comment column.
  - If you select a comment and reload the whole page, there should be one
more comment with this name
  - If you select a comment and click on cancel just after, there shouldn't
be any change when you reload.
  - If to a result has been reported a lot (>5, >10 and >15), it should
appear differently

8 - For each precedent test, try to send wrong datas, to delete the
security token, to send nothing: it should send you a propper message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #61 from Paul Poulain  ---
Created attachment 62596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62596=edit
Bug 17047 - Don't create numberpattern if the same exists

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #60 from Paul Poulain  ---
Created attachment 62595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62595=edit
Bug 17047 ability to import a subscription model from mana

- modify subscription-add.tt and subscription.pl to manage a
import from mana during a subscription creation
- add 2 script in svc for ajax calling from subscription-add.tt
to communicate with mana server during a asubscription creation
- add a function in Subscription.pm to have all the info for a mana research
from a biblionumber
- modify functions used by subscription-add.pl in C4/Serials to manage a
frequency which came from mana server and not already created on the
koha database, and modify the tests of the said functions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Paul Poulain  changed:

   What|Removed |Added

  Attachment #62544|0   |1
is obsolete||
  Attachment #62545|0   |1
is obsolete||
  Attachment #62546|0   |1
is obsolete||
  Attachment #62547|0   |1
is obsolete||
  Attachment #62548|0   |1
is obsolete||
  Attachment #62549|0   |1
is obsolete||
  Attachment #62550|0   |1
is obsolete||
  Attachment #62551|0   |1
is obsolete||
  Attachment #62552|0   |1
is obsolete||
  Attachment #62553|0   |1
is obsolete||
  Attachment #62589|0   |1
is obsolete||

--- Comment #58 from Paul Poulain  ---
Created attachment 62593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62593=edit
Bug 17047 ability to search subscription model on mana

- add a class SharedContent.pm to communicate with mana server
- add a link in serials-menu.inc to serials_search.pl to open
a mana-subscription research form
- modify the research form in serials-search.tt to show the right fields
for mana
- create datatable in mana-subscription-search-result.inc to show
results from a research on mana
- modify serials-search.pl to manage research on mana

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #62 from Paul Poulain  ---
Created attachment 62597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62597=edit
Bug 17047 Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #63 from Paul Poulain  ---
Created attachment 62598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62598=edit
Bug 17047: Add report, factorize code, add a comment feature

Interface :
- On mana-search, rows are now sorted by date of last import, then by number of
users
- Windows redisigned to improve the user experience
- New Feature : report a record.
 - peoples can now report a weird report
 - if a record is reported a lot of time, it will appear differently
- Added few tooltip (to explain the fields last import, nb of users, to explain
  the new feature)
- Added the syspref "AutoShareWithMana", which enables to select which fields
  you want to share automatically with mana

API (svc/mana)
- add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a
resource
- no hardcoding for resources in the code of api (api needs to be called with a
ressourcename)

- Factorize a lot of code in order to improve the speed of next developments

SytemPreferences:
Mana Activation:
- add a field "no, let me think" at the syspref "Mana"
- as long as this field is selected, messages ask if user want to activate
it
messages in pages:
- Administration
- Add-subscription(page 2)
AutoShareWithMana
- Add the syspref AutoShareWithMana: user can automatically share infos
with mana (automatically not set)

Report Share
- Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
- New feature: share reports with Mana
- New feature: search report in Mana Knowledge Base with keywords
- New feature: load reports from Mana

Comment Resources
- The comments can now be manually added
- On a resource mana datatable, you can now see comments, add comment and vote
for comments you think pertinent
- Comments are NOT dynamically generated on the table you need to reload the
page when you vote

Test plan:
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in
../etc/koha-conf.xml
3 - Check Mana syspref and AutoShareWithMana syspref are not activated

4 - subscriptions
- Try create a new subscription for a first serial  => mana shouldn't show you
anything (except if the base hase been filled)
- Share this serial with Mana (on the serial individual's page there must be a
Share button)
- Try to create a new subscription for serial nr1 => a message should appear
when you click on "next", click on "use", the fields should automaticaly appear
- Activate AutoShareWithMana => Subscriptions
- Create a new subscription for a second serial
- There shouldn't be any Share button
- Create a second subscription => the message should appear, click again on use

5 - Report
- Create a new report, without notes.
- On the table with all report (reports > use saved), there should be the
action "Share"
- If you click on share, you have an error message
- Create a new report, with a title and notes longer than 20 characters
- You  can share it with mana => you will have a success message
- On (report > use saved), there must be a message inviting you to search on
mana KB for more results, enter a few word from title, notes, type of  the
report you shared, it should appear. You can use it, it will load it into your
report list.

6 - Comments.
- On any table containing mana search results, you can comment. To comment,
click on report mistake. For now, you only can chose "other".
- If you click other, a new textbox appears. Enter a short comment.
- Reload the whole page, the comment should appear in the menu and in the
comment column.
- If you select a comment and reload the whole page, there should be one more
comment with this name
- If you select a comment and click on cancel just after, there shouldn't be
any change when you reload.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #59 from Paul Poulain  ---
Created attachment 62594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62594=edit
Bug 17047 ability to share a subscription to mana

- add a mana_id to subscription table
- add a share button on serials-toolbar.inc and a modal to ask
the language of the share and to alert if the subscription is
already link to a mana subscription model
- add function in C4/Serials to get all the info for a subscription
sharing
- modify subscription-detail.pl to manage sharing to mana

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Paul Poulain  changed:

   What|Removed |Added

  Attachment #62543|0   |1
is obsolete||

--- Comment #57 from Paul Poulain  ---
Created attachment 62592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62592=edit
Bug 17047 add frequencies and numberpattern in subscription class

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Paul Poulain  changed:

   What|Removed |Added

  Attachment #62542|0   |1
is obsolete||

--- Comment #56 from Paul Poulain  ---
Created attachment 62591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62591=edit
Bug 17047 add mana syspref

Add the system preference to enable or disable mana
webservice on koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Paul Poulain  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

Ray Delahunty  changed:

   What|Removed |Added

 CC||r.delahu...@arts.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18479] Holds 'Placed on' column in opac-user.pl not sorting correctly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18479

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18479] Holds 'Placed on' column in opac-user.pl not sorting correctly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18479

--- Comment #1 from Owen Leonard  ---
Created attachment 62590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62590=edit
Bug 18479 - Holds 'Placed on' column in opac-user.pl not sorting correctly

Two columns in the user's holds table in the OPAC do not sort correctly
because they are not marked up correctly to enable date sorting: 'Placed
on' and 'Expires on.' This patch corrects it.

This patch also removes a stray  which was causing validation
errors.

To test, apply the patch and log into the OPAC with an account which has
multiple holds with differnt hold dates and expiration dates. Confirm
that sorting on these columns works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18462] Implemented bootstrap styling on the web installer and onboarding tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18462

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #11 from Marc Véron  ---
Sorry again, I get a merge conflict:

Wende an: Bug 17855: Onboarding tool
Verwende Informationen aus der Staging-Area, um einen Basisverzeichnis
nachzustellen
M   installer/install.pl
M   koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt
Falle zurück zum Patchen der Basis und des 3-Wege-Merges...
automatischer Merge von
koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt
KONFLIKT (Inhalt): Merge-Konflikt in
koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt
automatischer Merge von installer/install.pl
KONFLIKT (Inhalt): Merge-Konflikt in installer/install.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18471] Receiving order with unitprice greater than 1000 processing incorrectly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471

--- Comment #3 from Nick Clemens  ---
(In reply to Alex Buckley from comment #2)
> I tried to replicate this bug on a clean up to date branch and was unable
> to, the price of 4367.00 was shown throughout the whole of the purchasing
> process and was also correct in the db

This may be specific to USD and/or browser settings. If the comma is not
displaying at any point in the ordering that seems likely

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18479] Holds 'Placed on' column in opac-user.pl not sorting correctly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18479

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
Version|16.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Baptiste  changed:

   What|Removed |Added

 CC||baptiste.wojtkowski@biblibr
   ||e.com
   Assignee|morgane.alo...@biblibre.com |baptiste.wojtkowski@biblibr
   ||e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055

Baptiste  changed:

   What|Removed |Added

   Assignee|m...@kohaaloha.com   |baptiste.wojtkowski@biblibr
   ||e.com
 CC||baptiste.wojtkowski@biblibr
   ||e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403

Fiona Borthwick  changed:

   What|Removed |Added

 CC||fiona.borthwick@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18485] REST API: add endpoint for calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18485

Mike  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Mike  changed:

   What|Removed |Added

 Blocks||18486


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18486
[Bug 18486] Calendar maintenance script: correct dates
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18486] Calendar maintenance script: correct dates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18486

Mike  changed:

   What|Removed |Added

 CC||blac...@gmail.com,
   ||josef.mora...@gmail.com,
   ||r...@rbit.cz
   Priority|P5 - low|P3
 Depends on||17015


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
[Bug 17015] New Koha Calendar
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18486] New: Calendar maintenance script: correct dates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18486

Bug ID: 18486
   Summary: Calendar maintenance script: correct dates
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Holidays
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: blac...@gmail.com
QA Contact: testo...@bugs.koha-community.org

User case:
Some holiday need to be added just couple of days before. We need tool that
corect date of check-ins or pickup days on new the closest working day, if some
changes in calendar are made. Script find dates for check-ins and pickups at
new holiday and validate them with new schedule.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Mike  changed:

   What|Removed |Added

 Blocks||18485


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18485
[Bug 18485] REST API: add endpoint for calendar
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18485] REST API: add endpoint for calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18485

Mike  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com,
   ||m...@jkozlovsky.cz,
   ||r...@rbit.cz
 Depends on||17015
   Priority|P5 - low|P3


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
[Bug 17015] New Koha Calendar
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18485] New: REST API: add endpoint for calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18485

Bug ID: 18485
   Summary: REST API: add endpoint for calendar
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: blac...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Hello,
new calendar (bug 17015) works with opening hours, so new endpoint for calendar
will be useful for transfer informations about opening hours into other
systems.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #55 from Baptiste  ---
Created attachment 62589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62589=edit
Bug 17047: Add report_group as shared attribute

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399

--- Comment #19 from David Cook  ---
(In reply to Marcel de Rooy from comment #18)
> Fridolin or David: Would you see any chance of testing this bug?

I have my hands full at the moment but I'll keep it on my to do list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into Koha directory perl modules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #15 from Marc Véron  ---
Sorr,, Alex, I wanted to rescue a minor issue in the first patch (qa tools
complaining about missing blank line preceding a =cut to make), but it did not
work out.

Reset to your patches.

Do you have qa tools installed?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into Koha directory perl modules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212

Marc Véron  changed:

   What|Removed |Added

  Attachment #62588|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into Koha directory perl modules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212

Marc Véron  changed:

   What|Removed |Added

  Attachment #62584|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into Koha directory perl modules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212

Marc Véron  changed:

   What|Removed |Added

  Attachment #62584|0   |1
is obsolete||

--- Comment #14 from Marc Véron  ---
Created attachment 62588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62588=edit
Bug 18212 - Moved all sql queries out aqplan.pl into Koha::Libraries.pm,
Koha::ItemType.pm, Koha::AuthorisedValue.pm files

The new subroutines in the perl modules contain POD

There is a minor error in qa tools that can be fixed in next patch.
Followed test plan (comment #6) with both patches together, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into Koha directory perl modules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212

Marc Véron  changed:

   What|Removed |Added

  Attachment #62584|1   |0
is obsolete||

--- Comment #13 from Marc Véron  ---
Comment on attachment 62584
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62584
Bug 18212 - Moved all sql queries out aqplan.pl into Koha::Libraries.pm,
Koha::ItemType.pm, Koha::AuthorisedValue.pm files

Restoring previous patch. It does not pass qa tools because of a fail in
Koha/ItemType.pm (Apparent command =cut not preceded by blank lins)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into Koha directory perl modules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212

Marc Véron  changed:

   What|Removed |Added

  Attachment #62587|0   |1
is obsolete||

--- Comment #12 from Marc Véron  ---
Comment on attachment 62587
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62587
Bug 18212 - Moved all sql queries out aqplan.pl into Koha::Libraries.pm,
Koha::ItemType.pm, Koha::AuthorisedValue.pm files

Obsoleting because there are problems with next patch after my amendement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into Koha directory perl modules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212

Marc Véron  changed:

   What|Removed |Added

  Attachment #62584|0   |1
is obsolete||

--- Comment #11 from Marc Véron  ---
Created attachment 62587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62587=edit
Bug 18212 - Moved all sql queries out aqplan.pl into Koha::Libraries.pm,
Koha::ItemType.pm, Koha::AuthorisedValue.pm files

The new subroutines in the perl modules contain POD

Tested both patches together, works as expected
Amended with blank line preceding a =cut to make qa tools pass
for first patch
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18247] Remove SQL queries from branch_transfer_limit.pl administrative script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18247

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18247] Remove SQL queries from branch_transfer_limit.pl administrative script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18247

Marc Véron  changed:

   What|Removed |Added

  Attachment #62583|0   |1
is obsolete||

--- Comment #7 from Marc Véron  ---
Created attachment 62586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62586=edit
Bug 18247 - Moved the SQL queries out of the branch_transfer_limits.pl script
into the Koha::AuthorisedValue, Koha::Libraries, Koha::ItemType perl modules.

Also added 3 successfully working unit tests for the new subroutines

Followed test plan from comment #3, works as expected
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/