date:20170502

[Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438

--- Comment #12 from Alex Buckley  ---
Created attachment 62955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62955=edit
Bug 18438 - Added focus on the checkin barcode input box after modal box is
dismissed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702)

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494

Marcel de Rooy  changed:

   What|Removed |Added

   Severity|trivial |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702)

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494

Marcel de Rooy  changed:

   What|Removed |Added

   Severity|enhancement |trivial
Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702)

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #14 from Marcel de Rooy  ---
(In reply to M. Tompsett from comment #12)
> If that is acceptable. obsolete the first and sign off the second.

Counter patch is a trivial one. Passing QA immediately. First patch obsoleted.
If there is a need for it, please open a new report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702)

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #62749|0   |1
is obsolete||
  Attachment #62926|0   |1
is obsolete||

--- Comment #13 from Marcel de Rooy  ---
Created attachment 62954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62954=edit
Bug 18494: Pass a code, not hash & Fix double commas

TEST PLAN
-
1) prove -v t/db_dependent/Letters.t
   -- fails at test 5 or so.
2) apply patch
3) run step 1
   -- success
4) run koha qa test tools

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702)

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2454] Don't show credits on Pay Fines Tab

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454

--- Comment #8 from Alex Buckley  ---
Created attachment 62953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62953=edit
Bug 2454 - Amended patch: Removed the display of accountype, Notify ID, Level
values for manual credit in pay.tt and replaced the description with string
"Credit"

These specific values have been removed because this bug report requires
the manual credit to no longer be shown on the 'Pay fines' tab.

In response to comment 4 (thankyou for noticing that Felix) I have redone this
patch so users can now successfully pay or write off manual credits because the
manual credit values although not being displayed are still being
submitted to pay.pl.

Test plan:
1. From the Koha staff interface go the Patron area and select a patron
page

2. Create a fine of $10 for the patron by clicking on the 'Fines' tab and
creating a fine in the 'Create manual invoice' tab

3. Create a credit of $5 for the patron in the 'Create manual credit'
page

4. Then go to the 'Pay fines' tab and notice there is a row for both the fine
and
credit both with values in the account type, Notify ID, and level boxes
of the table

5. Select "write off all" and 'OK' in the confirmation box

6. Youre redirected to Account tab, return to 'pay fines' tab and notice no
fines or credits are displayed

7. Repeat steps 2, 3, 4 and then click "Pay amount", confirm it, then navigate
back
to the 'Pay fines' tab and notice although the fine and credit are
displayed the 'total due' value is 0.00

8. Apply the patch attached to this bug report

9. Repeat steps 2, and 3.

10. Navigate to 'Pay fines' tab and notice the fine has values
in account type, Notify ID, and level and the credit does not. Additionally
credit has the description value of 'Credit'

11. Repeat steps 5 and 6 and as with before this patch was applied
notice the 'Pay fines' tab does not show any fines or credits

12. Repeat step 7 and again notice the 'Total due' value is 0.00

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2454] Don't show credits on Pay Fines Tab

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454

Alex Buckley  changed:

   What|Removed |Added

  Attachment #62194|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18483] Customised help: Enhance staff client with news based, easily editable help system

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18483

Josef Moravec  changed:

   What|Removed |Added

  Attachment #62901|0   |1
is obsolete||

--- Comment #18 from Josef Moravec  ---
Created attachment 62952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62952=edit
[SIGNED-OFF] Bug 18483 - Customised help: Enhance staff client with news based,
easily editable help system

Koha's staff client has a file based help system with an edit function for
customising. However, the edited files have to be saved and restored with each
release. Otherwise they are overwritten.

As an enhancement or alternative, the existing news system is used to implement
a
complementing help system. Similar to the news, the text can be created for all
branches or for individual branches. Help is context sensitive (based on the
existing help system), and it can be created / edited directly from the help
page
(based on a user permission). Du to the need of this user permissen, a user
permission for editing news is implemented as well.

Display can be managed with a system preference (Bug 18472: Add system
preference
to manage online help system). Preferences default to legacy (fiele based)
help.

To test:
- Apply patch on top of Bug 18472, restart memcached and plack
- Update database (Alternative: fresh install)
- Log in as superlibrarian (later we test the permisisons)
- Verify that news behave as before
- Verify that legacy help works as before
- Locate system preferences 'EnableEditingFilebasedHelp' and 'Help system'
- For our tests, set 'EnableEditingFilebasedHelp' to 'No'
- In 'HelpSystem', uncheck 'File based'  (none selected)
- Refresh any page and verify that 'Help' Link in the main menu has vanished
- Check both 'File based' and 'News based'
- Verify that 'Help appears again in top menu
- Click 'Help' for any page, verify that, above the 'classic' filebased help,
you
  see a title 'Help for (library name) and two buttons 'Add help for this page'
  and 'Add help for all pages'
- Close the help page
- Go back to system preferences, select 'News based' only for 'HelpSystem'
- Open Help again for any page
- Verify that the text from file based help no longer displays, you should have
  a title and buttons only at the moment.
- Click 'Add help for this page'. You are taken to the form you already know
from
  editing 'News'
- Click 'Cancel'. You should be taken back to the help page as before
- Again click 'Add help for this page' and add an easyly identifiable title and
  some text, like you would do with news.
- Leave the new field 'Help key' unchanged.
- Submit. You should be taken back to the help you just created should appear
- Close help page and open it again to verify that the text persists (for this
  page)
- Go to an other page and verify that the help you added for the first page
does
  not appear.
- Add a help entry using the button 'Add help for all pages'
- Go back to the first page you entered help for and verify, that it displays
it's
  own help text and the text for all pages
- Edit one of the texts, verify that it saves correctly
- Add some more entries and verify that they appear as expected
- Go to More > Tools (in an other tab)
- Verify that the menu entry for News appears/disappears and changes text
  depending on the settings of system preference 'HelpSystem'
- Open 'News' rsp. 'Help', verify that entries appear depending on the settings
  of syspref 'HelpSystem'
- Verify that the filter for 'Display location' works
- Verify that in the 'Location' column a hint about the page appears the entry
  was created for
- Edit a staff help entry, verify that submit or close takes you back to the
list
- Bonus test: Edit a staff help entry, change the key to 'all', verify that the
  entry now appears for all pages. Change the key to 'help/admin/preferences'
and
  verify that it appears now for the preferences page
- Create a staff user with following permisisons only: catalogue (for login),
  edit_help and edit_news
- Test visibility of news / help  editing functionality depending on the
  edit_ permissions
- Run QA tools

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18483] Customised help: Enhance staff client with news based, easily editable help system

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18483

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18522] New: User Panel filtered books not showing

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18522

Bug ID: 18522
   Summary: User Panel filtered books not showing
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: bugs.koha-community.org
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lkirakos...@polytechnic.am
QA Contact: testo...@bugs.koha-community.org

Created attachment 62951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62951=edit
Error screenshot

When logging through admin panel, uploaded books are shown. But when logging
through the user account books are not showing up and search is not working.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18472] Add system preferences to manage online help system

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18472] Add system preferences to manage online help system

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472

Josef Moravec  changed:

   What|Removed |Added

  Attachment #62897|0   |1
is obsolete||

--- Comment #16 from Josef Moravec  ---
Created attachment 62950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62950=edit
[SIGNED-OFF] Bug 18472: Add system preferences to manage online help system

This patch introduces two new system preferences in section
'Administration'
- 'HelpSystem' to select / disable the help system to use. It is designed
  to allow future expansions (alternative / complementing help system), thats
   why it is a 'Multiple choice' with one choice
- 'EnableEditingFilebasedHelp' is used to toggle on/off the 'Edit'
  field that appears at the bottom of the durrent help pages.

To test:
- In staff client, open help on some pages, including help on main page
- They have a button 'Edit help'. On main page help, you see a text about
  'Can I edit the online help?'
- Apply patch, restart memcached and plack
- Update database
- In staff client, go to Administration > System preferences > Administration
- Locate section 'Help system', do not yet schange settings
- Verify that the help pages you visited look the same as before
- Change syspref 'EnableEditingFilebasedHelp' to 'No'
- Visit the help pages again, verify that 'Edit help' button no longer appears.
- Set the system preference 'HelpSystem' to none (deselect 'File based (staff
client)
- Reload any page and verify that the 'Help' link in the page header does no
  longer display
- In syspref 'HelpSystem', check 'File based (staff client)'
- Reload any page, verify that the 'Help' link is displayed

(Amended to correct wrong line in sysprefs.sql 201-04-29 mv)

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Barry Cannon  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||b...@interleaf.ie

--- Comment #7 from Barry Cannon  ---
Applied to customer instance and confirmed working.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284

--- Comment #1 from Josef Moravec  ---
See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906#c33

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18035] Front-end changes to serials -> Numbering patterns

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18035

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18035] Front-end changes to serials -> Numbering patterns

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18035

Nick Clemens  changed:

   What|Removed |Added

  Attachment #61731|0   |1
is obsolete||

--- Comment #9 from Nick Clemens  ---
Created attachment 62949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62949=edit
Bug 18035: Front-end changes to serials -> numbering patterns

This patch:
1) Uses datatables functionality on numbering patterns table
2) Shows breadcrumbs when using the form to add or modify numbering
patterns
3) Updates the Save, Reset, and Test Pattern buttons in the form to be
bootstrap 3 buttons

To test:
1) Confirm that datatable sorting works on all columns EXCEPT Actions
column
2) Click 'New numbering pattern'
3) Confirm breadcrumbs reads 'New numbering pattern'
4) Go back to numbering patterns and Edit an existing one
5) Confirm breadcrumbs reads 'Modifying number pattern ''
6) Confirm Save, Reset and Test pattern buttons now show as bootstrap3
buttons
7) Confirm all buttons work as expected

Sponsored-by: Catalyst IT

Followed test plan works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18350] Moving call number in subscriptions tab in OPAC biblio detail

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18350

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18350] Moving call number in subscriptions tab in OPAC biblio detail

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18350

Nick Clemens  changed:

   What|Removed |Added

  Attachment #61728|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 62947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62947=edit
Bug 18350: Moving call number in subscriptions tab in OPAC biblio detail

This patches moves the call number up to be under the library name, so
it is equivalent to the staff client

To test:
1) Go to the detail page of a biblio with subscriptions in the staff
client
2) Notice callnumber sits under the library name
3) Go to the detail page of the same biblio in OPAC
4) Notice callnumber is not in the same order
5) Apply patch, refresh page
6) Notice callnumber is now in same order

Sponsored-by: Catalyst IT

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18350] Moving call number in subscriptions tab in OPAC biblio detail

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18350

--- Comment #4 from Nick Clemens  ---
Created attachment 62948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62948=edit
Bug 18350 (QA Followup) Add classes to elements

Provide classes for easy access in case library wishes to make further
chnages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||josef.mora...@gmail.com

--- Comment #46 from Josef Moravec  ---
QA test tool complains: 

 FAIL   C4/Members/Attributes.pm
   FAIL   pod

 in file C4/Members/Attributes.pm

Apparent command =cut not preceded by blank line
*** ERROR: 

 FAIL   C4/Utils/DataTables/Members.pm
   FAIL   forbidden patterns
forbidden pattern: tab char (line 58)
forbidden pattern: tab char (line 59)
   FAIL   valid
Can't continue after import errors 
"GetMemberIssuesAndFines" is not exported by the C4::Members
module

 FAIL  
koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/guarantor_search.tt
   FAIL   forbidden patterns
forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 20)

 FAIL   members/moremember.pl
   FAIL   forbidden patterns
forbidden pattern: tab char (line 221)

also the patch does not apply cleanly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17190] Mark REST API dependencies as mandatory in PerlDependencies.pm

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17190

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17190] Mark REST API dependencies as mandatory in PerlDependencies.pm

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17190

Nick Clemens  changed:

   What|Removed |Added

  Attachment #61772|0   |1
is obsolete||

--- Comment #5 from Nick Clemens  ---
Created attachment 62946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62946=edit
Bug 17190 - Marked REST API as mandatory (require = 1) in PerlDependencies.pm

For testing I went in Staff client to Home > About Koha > tab  Perl modules
and verified that both Mojolicious (6.0) and Swagger2 (0.59) are marked
as mandatory.
Signed-off-by: Marc Véron 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18344] Allow overdue fines cap at replacement price, and cap by amount to work together

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18344

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18505] OPAC Search History page does not respect OpacPublic syspref

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18505] OPAC Search History page does not respect OpacPublic syspref

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505

Nick Clemens  changed:

   What|Removed |Added

  Attachment #62925|0   |1
is obsolete||

--- Comment #9 from Nick Clemens  ---
Created attachment 62945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62945=edit
BUG 18505: opac-search-history does not respect opacPublic

The opac-search-history page was available regardless of the opacPublic
setting, this
patch corrects that.

Test plan, set opacPublic to 'No', test whether opac-search-history page is
available
when not logged in, note that it is.
Apply patch, test whether opac-search-history is still available when not
logged in,
note that you should be redirected to the login page.

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18405] Self checkout: Fix broken silent printing

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18405

Nick Clemens  changed:

   What|Removed |Added

  Attachment #62187|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 62944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62944=edit
Bug 18405: Self checkout: Fix broken silent printing

Fix broken 'silent printing' (without printer dialog) in self checkout.

To reproduce:
Set up silent printing to slip printers as described in:
https://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently

Verify that it works for check-outs in staff client.
Verify that it does not work in Self checkout.

To test:
Apply patch
Verify that silent printing works on SCO

Signed-off-by: Alex Buckley 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18405] Self checkout: Fix broken silent printing

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18405

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|alex.sassmannshausen@ptfs-e |testo...@bugs.koha-communit
   |urope.com   |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18436] Add home library to the SIP2 patron info response 64

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18436

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion
 CC||n...@bywatersolutions.com

--- Comment #4 from Nick Clemens  ---
Why not use the existing functionality to send patron's homebranch in the AF
field?

send_patron_home_library_in_af="1"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16696] Rename "Publisher" to "Published" on detail and result lists

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16696

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #4 from Nick Clemens  ---
"Publication details" or  maybe break the field into 3 and label each?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17600] Standardize the EXPORT

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

--- Comment #38 from Martin Renvoize  ---
I have now ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17600] Standardize the EXPORT

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #62212|0   |1
is obsolete||

--- Comment #37 from Martin Renvoize  ---
Created attachment 62943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62943=edit
Bug 17600: Explicitly export the subroutines used

This patch is generated using the export.pl script

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17600] Standardize the EXPORT

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #62211|0   |1
is obsolete||

--- Comment #36 from Martin Renvoize  ---
Created attachment 62942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62942=edit
Bug 17600: continue replace of EXPORT with EXPORT_OK

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17600] Standardize the EXPORT

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #62209|0   |1
is obsolete||

--- Comment #34 from Martin Renvoize  ---
Created attachment 62940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62940=edit
Bug 17600: Standardize our EXPORT_OK

On bug 17591 we discovered that there was something weird going on with
the way we export and use subroutines/modules.
This patch tries to standardize our EXPORT to use EXPORT_OK only.

That way we will need to explicitely define the subroutine we want to
use from a module.
There are still a lot of things to do, it would be good to write
a script to do what's need to be done.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17600] Standardize the EXPORT

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #62210|0   |1
is obsolete||

--- Comment #35 from Martin Renvoize  ---
Created attachment 62941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62941=edit
Bug 17600: Remove useless extra spaces

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17554] Move GetBorrowersWithEmail to Koha::Patron

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554

--- Comment #6 from Martin Renvoize  ---
Looks like a solid change to me, but I can't get it to apply :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17554] Move GetBorrowersWithEmail to Koha::Patron

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #27 from Alex Sassmannshausen 
 ---
(In reply to Magnus Enger from comment #24)
> I think I foud a problem in Koha/Illrequest.pm, about line 646. In this
> block of code: 
> 
> # Almost there, but category code didn't quite work.
> my ( $branch_limit, $brw_limit )
> = ( $branch_rules->{count}, $brw_rules->{count} );
> my ( $branch_count, $brw_count ) = (
> $self->_limit_counter(
> $branch_rules->{method}, { branch_id => $branchcode }
> ),
> $self->_limit_counter(
> $brw_rules->{method}, { borrower_id => $patron->borrowernumber }
> ),
> );
> 
> branch_id should be branchcode, and borrower_id should be borrowernumber, I
> think?

You are absolutely right!  I have committed a fix in my dev branch and hope to
push the new additions later today.

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8000] Test mode for notices

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

--- Comment #123 from Katrin Fischer  ---
It's a valid point then, but not sure we should make it part of this bug -
maybe better to get foundations in and then add to it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances.

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361

--- Comment #8 from Katrin Fischer  ---
Comment on attachment 60952
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60952
Bug 11361 - Add a Z39.50 search page in the OPAC to let members search for
records on remote Koha instances

Review of attachment 60952:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11361=60952)
-

Hi Blou,

did a first code review. Additionally to the comments I made I noticed that the
changes to kohastructure.sql are misssing for the column.

::: C4/Auth.pm
@@ +523,4 @@
>  OPACURLOpenInNewWindow=> "" . 
> C4::Context->preference("OPACURLOpenInNewWindow"),
>  OPACUserCSS   => "" . 
> C4::Context->preference("OPACUserCSS"),
>  OpacAuthorities   => 
> C4::Context->preference("OpacAuthorities"),
> +OpacZ3950 => 
> C4::Context->preference("OpacZ3950"),

It's better to use the newer TT plugin method to check system preferences.
I think this is done below, so this can possibly be reoved.

::: admin/z3950servers.pl
@@ +66,4 @@
>  $id = 0;
>  } elsif ( $op eq 'add_validated' ) {
>  my @fields=qw/host port db userid password rank syntax encoding timeout
> +recordtype checked servername servertype sru_options sru_fields 
> attributes opac

attributes is added by another patch on bug 11297, so should be marked as a
dependency or removed here.

::: installer/data/mysql/sysprefs.sql
@@ +569,5 @@
>  ('XSLTListsDisplay','default','','Enable XSLT stylesheet control over lists 
> pages display on intranet','Free'),
>  ('XSLTResultsDisplay','default','','Enable XSL stylesheet control over 
> results page display on intranet','Free'),
>  ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields 
> for Personal Name Authorities to fill biblio.author','free'),
> +('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will 
> replace authors in biblio.author','YesNo'),
> +('OPACZ3950','0','','Allow patrons to search for bibliographic records in 
> other libraries via Z39.50.','YesNo')

The list in sysprefs.sql should be sorted alphabetically to minimize conflicts.

::: installer/data/mysql/updatedatabase.pl
@@ +13959,4 @@
>  print "Upgrade to $DBversion done (Bug 16530 - Add a circ sidebar 
> navigation menu)\n";
>  }
>  
> +$DBversion = "XXX";

This should be an atomicupdate in a separate file now instead of an entry in
updatedatabase.

@@ +13960,5 @@
>  }
>  
> +$DBversion = "XXX";
> +if( CheckVersion( $DBversion ) ) {
> +$dbh->do("ALTER TABLE z3950servers ADD COLUMN opac TINYINT(1);");

Please specify where the new column should be added using AFTER/BEFORE column.

@@ +13962,5 @@
> +$DBversion = "XXX";
> +if( CheckVersion( $DBversion ) ) {
> +$dbh->do("ALTER TABLE z3950servers ADD COLUMN opac TINYINT(1);");
> +$dbh->do("INSERT IGNORE INTO systempreferences 
> (variable,value,options,explanation,type) VALUES('OPACZ3950','0','','Allow 
> patrons to search for bibliographic records in other libraries via 
> Z39.50.','YesNo')");
> +print "Add opac column to z3950servers table.\nAdd OPACZ3950 
> preference.\n";

I am not sure if the \n work nicely in the HTML output of the web installer,
maybe remove them.

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt
@@ +235,4 @@
>  You searched for [% searchfield %]
>  [% END %]
>  
> +
> TargetHostname/PortDatabaseUseridPasswordPreselectedRankSyntaxEncodingTimeoutRecord
>  typeAttributesOPACOptions

Attributes are from bug 11297 - see above.

::: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
@@ +273,4 @@
>  [% IF ( Koha.Preference( 
> 'UseCourseReserves' ) == 1 ) %] href="/cgi-bin/koha/opac-course-reserves.pl">Course reserves[% END %]
>  [% IF Koha.Preference( 'OpacBrowser' ) 
> == 1 %]Browse by 
> hierarchy[% END %]
>  [% IF Koha.Preference( 'OpacAuthorities' 
> ) == 1 %]Authority 
> search[% END %]
> +[% IF Koha.Preference( 'OpacZ3950' ) 
> %]Z39.50 
> Search[% END %]

Not sure patrons will know what Z39.50 means, maybe we could find another label
- "search other catalogs" maybe?

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-z3950-search.tt
@@ +52,5 @@
> +{ label => "Keyword (any)", prop => 'srchany' },
> +{ label => "LC call number", prop => 'lccall' },
> +{ label => "Control no.", prop => 'controlnumber' },
> +{ label => "Dewey", prop => 'dewey' },
> +{ label => "Standard ID", prop => 'stdid' }

Not sure if this syntax is translatable - needs testing.

@@ +64,5 @@
> +
> + />
> +
> +
> +Search Parameters

Should

[Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances.

2017-05-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

< 1 2 3

201 - 243 of 243 matches

Mail list logo