[Koha-bugs] [Bug 18383] items.onloan schema comment seems to be incorrect.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18383

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
Version|16.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18383] items.onloan schema comment seems to be incorrect.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18383

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
Hi Pongtawat, thx for the patch! Please remember to switch the status from NEW
to "Needs Sign-off" after attaching a patch, otherwise this will not show up in
people's searches and can get be overlooked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055

Marcel de Rooy  changed:

   What|Removed |Added

   Severity|normal  |enhancement
 CC||m.de.r...@rijksmuseum.nl

--- Comment #25 from Marcel de Rooy  ---
Marking this as an enhancement rather than a bugfix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18204] Authority searches are not saved in Search history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204

Katrin Fischer  changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #5 from Katrin Fischer  ---
Hi, thx for the patch! Is this a first? I have noticed the author line reads:
From: LeireDiez 
Is this how you want it? The names will show up on the dashboard and in the
release notes :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18204] Authority searches are not saved in Search history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #63387|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 63398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63398=edit
[SIGNED OFF] Bug 18204 - Authority searches are not saved in Search history

When you search an authority in Authority search, this search is not saved in
Search history.

EnableOpacSearchHistory is enabled

Steps to test:
 1- Login your account (opac)
 2- Search an authority in Authority search
 3- Go to Search history -> Authority
 4- It says "Your authority search history is empty"

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18204] Authority searches are not saved in Search history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18204] Authority searches are not saved in Search history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
  Attachment #60809|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18400] Noisy warns in opac-search.pl during itemtype sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #5 from Katrin Fischer  ---
Looks like Marc actually signed off, but status wasn't switched!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18400] Noisy warns in opac-search.pl during itemtype sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |n...@bywatersolutions.com
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #16 from Katrin Fischer  ---
I am worried about the atomicupdate - it looks like only checks for the
authorised value code, but not for the category, so this might lead to wrong
warning messages. Some of those codes look like classifications we might have
as collections in our databases for example.


+my $number_cc = $schema->resultset('AuthorisedValue')->search(
+{
+authorised_value => 'CC'
+}
+)->count;
+if ( $number_cc > 1 ) {

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

--- Comment #9 from Marcel de Rooy  ---
Created attachment 63397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63397=edit
Bug 18579: Make EmbedItemsAvailability handle control fields correctly

This patch makes the EmbedItemsAvailability filter handle the
biblio.biblionumber > control field mapping gracefully.
Right now, it was assuming a regular data field was used, and such is not the
case for UNIMARC (001).

To test:
- Apply the tests patch
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t
=> FAIL: Tests fail to run
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t
=> SUCCESS: Tests pass!
- Sign off :-D

Sponsored-by: ByWater Solutions

Signed-off-by: Katrin Fischer 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #63394|0   |1
is obsolete||
  Attachment #63395|0   |1
is obsolete||

--- Comment #8 from Marcel de Rooy  ---
Created attachment 63396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63396=edit
Bug 18579: Regression tests

This patch makes sure the tests have the biblio.biblionumber mapping mocked
so we test the case where the mapping is to a control field instead of just
regular data fields (in the case of UNIMARC).

To test:
- Apply the patch
- Run:
  $ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t
=> FAIL: Tests fail due to an attemp to access a subfield on a control field.

Sponsored-by: ByWater Solutions

Signed-off-by: Katrin Fischer 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18326] Add Mojolicious as a required dependency

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18326

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Needs Signoff   |RESOLVED
 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
I think this patch might be obsolete - it's already marked required on master:

},
'Mojolicious' => {
'usage'=> 'REST API',
'required' => '1',
'min_ver'  => '6.0',
},

Not sure which status... choosing to close, please reopen if I am mistaken.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #63389|0   |1
is obsolete||
  Attachment #63390|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 63394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63394=edit
[SIGNED OFF] Bug 18579: Regression tests

This patch makes sure the tests have the biblio.biblionumber mapping mocked
so we test the case where the mapping is to a control field instead of just
regular data fields (in the case of UNIMARC).

To test:
- Apply the patch
- Run:
  $ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t
=> FAIL: Tests fail due to an attemp to access a subfield on a control field.

Sponsored-by: ByWater Solutions

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

--- Comment #7 from Katrin Fischer  ---
Created attachment 63395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63395=edit
[SIGNED OFF] Bug 18579: Make EmbedItemsAvailability handle control fields
correctly

This patch makes the EmbedItemsAvailability filter handle the
biblio.biblionumber > control field mapping gracefully.
Right now, it was assuming a regular data field was used, and such is not the
case for UNIMARC (001).

To test:
- Apply the tests patch
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t
=> FAIL: Tests fail to run
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t
=> SUCCESS: Tests pass!
- Sign off :-D

Sponsored-by: ByWater Solutions

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18585] Connect to RDF triplestore

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585

David Cook  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18585] Connect to RDF triplestore

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585

--- Comment #1 from David Cook  ---
Created attachment 63393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63393=edit
Bug 18585 - Connect to RDF triplestore

This commit adds a 'triplestore' method to C4::Context, which
returns a RDF::Trine::Model object if triplestore.yaml is
properly configured.

(At the moment, it just supports RDF::Trine::Store::SPARQL,
but it would be trivial to add support for RDF::Trine::Store::DBI too.)

This code will provide a base from which people can use RDF::Trine
for querying and updating a RDF triplestore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18585] New: Connect to RDF triplestore

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585

Bug ID: 18585
   Summary: Connect to RDF triplestore
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

In order to store RDF data, we need to be able to connect to a triplestore.
This enhancement simply allows us to connect to a separate triplestore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18585] Connect to RDF triplestore

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=10787

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10787] Linked Data/RDF Omnibus

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10787

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18585

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #62250|0   |1
is obsolete||

--- Comment #16 from Srdjan Jankovic  ---
Created attachment 63392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63392=edit
Bug 17602 Add Oneclickdigital integration to Koha

Add OneClickdigital to the users page in the public interface

To Test:
1/ Apply all 3 patches
2/ Set the sysprefs to valid values (you will need a test account with
Oneclickdigital)
3/ Try a search
4/ Login to the OPAC, try to place a hold, or check an item out
5/ Check the opac-user page, see if your items are showing on the
oneclickdigital tab

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18342] Set memcached as 'enabled' by default

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

--- Comment #3 from Jacek Ablewicz  ---
(In reply to Jonathan Druart from comment #2)
> (In reply to Marcel de Rooy from comment #1)
> > And remove the other cache types: Cache::Memory etc.

IMO at least fastmmap definitely should be removed, it's long overdue.

> 
> Not Cache::Memory, it should be kept as a fallback way in case memcached is
> not reachable

Cache::Memory does't  work all that well as a fallback mechanism.. Under normal
circumstances it's just slowing things out (values are stored there, but never
retrieved back). And under more unusual circumstances (e.g. if we want to flush
L1 cache in daemon scripts periodically) it's pretty much the same - while
Cache::Memory supports expiration, currently we don't use it (properly), and
the final result is once again 100% waste of CPU cycles, without any gains at
all.

I wonder if a better fallback for memcached L2 cache could rather be: no L2
cache, or maybe some kind of dummy L2 cache. It does mater only in case of
daemon scripts - if it's not a daemon script etc., Cache::Memory will always be
a waste of time anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
Summary|Removing trailing-space |Our legacy code contains
   |from our codebase   |trailing-spaces

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18514] Allow library to search their Koha and Overdrive collections using ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514

Nick Clemens  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com,
   ||n...@bywatersolutions.com,
   ||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18582] Hide empty rows in detailed suggestion view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18582

--- Comment #1 from Owen Leonard  ---
Created attachment 63391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63391=edit
Bug 18582 - Hide empty rows in detailed suggestion view

This patch adds a check for the existence of various template variables
before showing the row containing that data. This will prevent the
display of rows containing labels but no data in the suggestions
detailed view.

To test, apply the patch and go to Acquisitions -> Suggestions.

View the detail page of various suggestions and confirm that only fields
with data are displaying.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18582] Hide empty rows in detailed suggestion view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18582

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18584] New: Removing trailing-space from our codebase

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584

Bug ID: 18584
   Summary: Removing trailing-space from our codebase
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

This bug report is opened for didactic purpose.

If you already contributed to Koha you must not contribute here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15404] CanBookBeReserved: No count of biblio level holds if ReservesControlBranch is item' s home library

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15404

Fiona Borthwick  changed:

   What|Removed |Added

 CC||fiona.borthwick@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

Fiona Borthwick  changed:

   What|Removed |Added

 CC||fiona.borthwick@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

--- Comment #5 from Tomás Cohen Arazi  ---
Hi, please test on your UNIMARC test environment! I provided a fix for the
tests so they actually cover the control field case, and the patch correctly
makes it work as expected (thanks marcelr for the pointer).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 63390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63390=edit
Bug 18579: Make EmbedItemsAvailability handle control fields correctly

This patch makes the EmbedItemsAvailability filter handle the
biblio.biblionumber > control field mapping gracefully.
Right now, it was assuming a regular data field was used, and such is not the
case for UNIMARC (001).

To test:
- Apply the tests patch
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t
=> FAIL: Tests fail to run
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t
=> SUCCESS: Tests pass!
- Sign off :-D

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 63389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63389=edit
Bug 18579: Regression tests

This patch makes sure the tests have the biblio.biblionumber mapping mocked
so we test the case where the mapping is to a control field instead of just
regular data fields (in the case of UNIMARC).

To test:
- Apply the patch
- Run:
  $ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t
=> FAIL: Tests fail due to an attemp to access a subfield on a control field.

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560

--- Comment #11 from M. Tompsett  ---
(In reply to Katrin Fischer from comment #7)
> We are a bit sparse with information in the RSS feed, for example if the
> entry is an article record, you would like to show the source as well. But
> this definitely fixes a bug.

Actually, that's the other thing I did notice. RSS feeds are not consistent in
what they output. This one needs improvement, but that is beyond the scope of
this specific bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #3 from Jonathan Druart  
---
Please provide tests!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #7 from Jonathan Druart  
---
Any chances to see tests covering this change?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18583] Add the ability to merge multiple authorities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18583

Nick Clemens  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18153] UNIMARC bib records exported with invalid 'a' char in label pos.9

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18153

Jonathan Druart  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #10 from Jonathan Druart  
---
I have asked Julian to take a look.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18583] New: Add the ability to merge multiple authorities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18583

Bug ID: 18583
   Summary: Add the ability to merge multiple authorities
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Since bug 8064 it is possible to merge multiple bibliographic records at once,
it would be nice to be able to do the same thing with authority records.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18576] MARC Bibliographic framework test does not check for framework created

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18576

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
Version|16.11   |unspecified

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18577] Importing a batch using a framework not fully set up causes and endless loop

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
Version|16.11   |unspecified

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370

--- Comment #11 from Jonathan Druart  
---
Created attachment 63388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63388=edit
Bug 18370: Use splice instead of splice

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18204] Authority searches are not saved in Search history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204

le...@scanbit.net changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18204] Authority searches are not saved in Search history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204

--- Comment #3 from le...@scanbit.net ---
Created attachment 63387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63387=edit
Bug 18204 - Authority searches are not saved in Search history

When you search an authority in Authority search, this search is not saved in
Search history.

EnableOpacSearchHistory is enabled

Steps to test:
 1- Login your account (opac)
 2- Search an authority in Authority search
 3- Go to Search history -> Authority
 4- It says "Your authority search history is empty"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18580] Account-pay does not apply credits / clear old fines as did recordpayment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18580

Colin Campbell  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe.
   |ity.org |com
 Status|NEW |Needs Signoff

--- Comment #1 from Colin Campbell  ---
Created attachment 63386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63386=edit
proposed patch

This is a minimal patch which restores the previous behaviour which some
operations relied on.

Its a bit of a code smell that this is handled as a side-effect of a payment,
but as Accounts never explicitly handled credit amounts it would require a bit
of a rethink to the Accounts api

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18399] Reason is missing in suggestion management part

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399

Owen Leonard  changed:

   What|Removed |Added

  Attachment #63384|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18399] Reason is missing in suggestion management part

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18582] New: Hide empty rows in detailed suggestion view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18582

Bug ID: 18582
   Summary: Hide empty rows in detailed suggestion view
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/suggestion/suggestion.pl
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

In the suggestion detailed view, every field is displayed even if it is empty.
This view should hide rows which contain no data.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18581] Add standard edit and delete buttons to suggestions list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18581

--- Comment #1 from Owen Leonard  ---
Created attachment 63385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63385=edit
Bug 18581 - Add standard edit and delete buttons to suggestions list

This patch modifies the table of suggestions in the staff client, moving
the edit link to the standard last column and styling it correctly. A
delete button is added as well.

Unrelated change: I removed the column containing suggestionid because I
don't think it's human-relevant information.

To test, apply the patch and go to Acquisitions -> Suggestions.

- In each tab, the table of suggestions should have an unsorted last
  column containing "edit" and "delete" links which should be styled
  correctly and working correctly.
- On the detailed view of a suggestion, the "delete" button in the
  toolbar should still work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18581] Add standard edit and delete buttons to suggestions list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18581

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #28 from Jonathan Druart  
---
Please add a reference to the DB changes in the commit message.

You also have to provide the same changes for kohastructure!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18581] New: Add standard edit and delete buttons to suggestions list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18581

Bug ID: 18581
   Summary: Add standard edit and delete buttons to suggestions
list
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/suggestion/suggestion.pl
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

Right now the list of suggestions in the staff client has an "[edit]" link but
no corresponding delete button, although there is a delete button on the
detailed view. I propose to add the standard pair of edit and delete buttons to
the table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18580] New: Account-pay does not apply credits / clear old fines as did recordpayment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18580

Bug ID: 18580
   Summary: Account-pay does not apply credits / clear old fines
as did recordpayment
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: colin.campb...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

the recordpayment routine in C4::Accounts cleared old paid fines and applied
credit amounts as part of its pay routine. The behaviour was implicit and not
signalled or commented in the code. The pay routine in Koha::Account which is
now called by paycollect.pl instead of the old routine does not leaving these
on the users fine display although they owe 0. Staff cannot manually remove
these.

For example a user has the following accountlines
+---+-+---+
| amount| accounttype | amountoutstanding |
+---+-+---+
| -1.30 | C   | -1.30 |
|  0.65 | Res |  0.65 |
|  0.65 | Res |  0.65 |
|  0.65 | Res |  0.65 |
+---+-+---+

after recordpayment has been called with an amount of 0.65 the lines are
+---+-+---+
| amount| accounttype | amountoutstanding |
+---+-+---+
| -1.30 | C   |  0.00 |
|  0.65 | Res |  0.00 |
|  0.65 | Res |  0.00 |
|  0.65 | Res |  0.00 |
| -0.65 | Pay |  0.00 |
+---+-+---+
However now calling Account->pay for the same amount results in 
+---+-+---+
| amount| accounttype | amountoutstanding |
+---+-+---+
| -1.30 | C   | -1.30 |
|  0.65 | Res |  0.00 |
|  0.65 | Res |  0.65 |
|  0.65 | Res |  0.65 |
| -0.65 | Pay |  0.00 |
+---+-+---+

leaving the credit and two fines with an amountoutstanding although the user
has nothing to pay (the amountoutstanding columns sum to 0) and leading to
misleading displays.

The difference is driven by the line where @outstanding_fines is retrieved the
selection is amountoutstanding > 0. In recordpayment it was amountoutstanding
<> 0 so that negative amounts were included and processed as part of the
payment, rather than ignored. The fact that this implicit behaviour was not
commented made it easy to miss.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16784] Export suggestions from OPAC as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784

--- Comment #1 from Owen Leonard  ---
Wouldn't this make more sense as a feature in the staff client?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18399] Reason is missing in suggestion management part

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399

--- Comment #1 from Owen Leonard  ---
Created attachment 63384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63384=edit
Bug 18399 - Reason is missing in suggestion management part

This patch adds a form field for suggestion status "reason" to the
suggestion edit form.

To test, edit an existing suggestion and try entering a suggestion
status explanation in the new form field. Your changes should be saved
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18399] Reason is missing in suggestion management part

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18342] Set memcached as 'enabled' by default

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #1)
> And remove the other cache types: Cache::Memory etc.

Not Cache::Memory, it should be kept as a fallback way in case memcached is not
reachable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18574] Clean Patron Records tool doesn' t limit to the selected library

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #63374|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17083] Remove more event attributes from tools templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18574


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574
[Bug 18574] Clean Patron Records tool doesn't limit to the selected library
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18574] Clean Patron Records tool doesn' t limit to the selected library

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17083


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083
[Bug 17083] Remove more event attributes from tools templates
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442

Jonathan Druart  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18153] UNIMARC bib records exported with invalid 'a' char in label pos.9

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18153

--- Comment #9 from stephane.dela...@biblibre.com ---
(In reply to Jonathan Druart from comment #8)
> The question is:
> Should not we call SetMarcUnicodeFlag from ModBiblioMarc to replace the
> whole "if ( $encoding eq "UNIMARC" ) {" block?
> 
> (read s/encoding/marcflavour ...)

The purpose of this patch is not to fix the wrong call of
«MARC::Record->encoding('utf-8')» to import (it's the goal of bug 18152), nor
even everywhere (it's the goal of bug 18533) ; the goal is to fix exported
records. Indeed, a lot of existing unimarc records in a lot of Koha are
erroneous because of this bug, the goal is that they do not remain erroneous
when exported. I don't see the relationship with ModBiblioMarc who has been
corrected to not add the bad character, not to delete it (and export don't call
ModBiblioMarc)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

Tomás Cohen Arazi  changed:

   What|Removed |Added

Version|unspecified |master
   Assignee|gmcha...@gmail.com  |tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] Problème with :Filter::MARC:: EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

Marcel de Rooy  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Problème with   |Problem with
   |:Filter::MARC::EmbedItemsAv |:Filter::MARC::EmbedItemsAv
   |ailability  |ailability

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] Problème with :Filter::MARC:: EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

--- Comment #2 from Marcel de Rooy  ---
(In reply to Koha Team Lyon 3 from comment #0)
> This is a real bug, in
> Koha::Filter::MARC::EmbedItemsAvailability::_processrecord,
> $biblionumber_field
> should be corrected to allow controlfield like 001.

Good catch!
Should use logic as in Koha/SearchEngine/Search.pm (extract_biblionumber).

Ping Tomas

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] Problème with :Filter::MARC:: EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

Julian Maurice  changed:

   What|Removed |Added

   Severity|enhancement |critical
 CC||julian.maur...@biblibre.com

--- Comment #1 from Julian Maurice  ---
Upgrading severity to critical, this prevents reindexing zebra:

$ misc/migration_tools/rebuild_zebra.pl -r -b -v
Zebra configuration information

Zebra biblio directory  = /home/koha/env/master/var/lib/zebradb/biblios
Zebra authorities directory = /home/koha/env/master/var/lib/zebradb/authorities
Koha directory  = /home/koha/env/master/src
Lockfile=
/home/koha/env/master/var/lock/zebradb/rebuild/rebuild..LCK
BIBLIONUMBER in : 001$@
BIBLIOITEMNUMBER in : 090$a

skipping authorities

exporting biblio

1Control fields (generally, just tags below 010) do not have subfields, use
data() at /home/koha/env/master/src/Koha/Filter/MARC/EmbedItemsAvailability.pm
line 75.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] Problème with :Filter::MARC:: EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

Koha Team Lyon 3  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m, k...@univ-lyon3.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18579] New: Problème with :Filter::MARC:: EmbedItemsAvailability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579

Bug ID: 18579
   Summary: Problème with :Filter::MARC::EmbedItemsAvailability
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: k...@univ-lyon3.fr
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

This is a real bug, in
Koha::Filter::MARC::EmbedItemsAvailability::_processrecord, $biblionumber_field
should be corrected to allow controlfield like 001.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18504] Amount owed on fines tab should be formatted as price if < 10 or credit

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18504

--- Comment #3 from Julian Maurice  ---
Created attachment 63383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63383=edit
Bug 18504 - Amount owed on fines tab should be formatted as price if <10 or
credit

To test:
1 - Give a patron a fine of 1
2 - View opac fines tab, it shows as '1'
3 - Give patron a credit of '1'
4 - View opac fines tab, it shows as '1'
5 - Apply patch
6 - Both now show as '1.00'

Signed-off-by: Lisa Gugliotti 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18504] Amount owed on fines tab should be formatted as price if < 10 or credit

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18504

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||julian.maur...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370

--- Comment #10 from Julian Maurice  ---
Comment on attachment 61870
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61870
Bug 18370: Columns visibility on patron search - Hide the correct column

Review of attachment 61870:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18370=61870)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
@@ +163,5 @@
>  // Apply DataTables on the results table
>  var columns_settings = [% ColumnsSettings.GetColumns( 'members', 
> 'member', 'memberresultst', 'json' ) %];
> +[% UNLESS CAN_user_tools_manage_patron_lists %]
> +[%# Remove the first column if we do not display the checkbox %]
> +columns_settings = columns_settings.slice(1, -1);

slice(1, -1) removes the first and the last elements of the array
slice(1) is what you want.
An even better solution is to use Array.splice, because it modifies directly
the array (and it's faster)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17257] Cannot create a patron under MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17257

--- Comment #10 from Julian Maurice  ---
Created attachment 63382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63382=edit
Bug 17257: Fix add/edit patrons under MySQL 5.7

If no guarantor is defined the patron won't be added/modified and an
error will be raised:

DBD::mysql::st execute failed: Incorrect integer value: '' for column
'guarantorid'

Test plan:
Using MySQL 5.7 (and/or sql_mode=STRICT_TRANS_TABLES)
Create a patron without guarantor

Signed-off-by: Srdjan 

Tested with MariaDB 10.0.30 (sql_mode='STRICT_TRANS_TABLES')
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17257] Cannot create a patron under MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17257

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

--- Comment #16 from Jacek Ablewicz  ---
(In reply to Jonathan Druart from comment #12)
> Why do you get the "syspref" cache instance?
> I guess there is no reason, I'd suggest to remove it and retrieve the
> default one.

When rebuild_zebra.pl starts, it immediately initialises all 3 instances
(config, syspref and default - in that order), so it probably doesn't matter
much which one is used for checking if memcached is in use or not in use. Bug
18250 seems to be a bigger issue (possibility that zebra_daemon gets started
before memcached is up and running). Overall, I don't think this is such a
major issue for zebra daemon right now, because by a look of it,
rebuild_zebra.pl uses very limited set of cached values, and predominantly (if
not only) such kinds of values that are never changed in the production
systems, like:

   syspref_cas* (due to BEGIN block in Auth.pm), syspref_marcflavour,
syspref_includeseefrominsearches

It fetches repeatedly MarcSubfieldStructure-* from default cache instance, but
I think it's mostly used for determining tag numbers (item tag number,
biblio/biblioitem tag number), which don't change very often (if ever) in the
production environments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Signed Off  |Passed QA

--- Comment #10 from Julian Maurice  ---
Simple patch, fixes the bug as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560

--- Comment #9 from Julian Maurice  ---
Created attachment 63381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63381=edit
Bug 18560: RSS link in opac shelves is broken

TEST PLAN
-
1) have books entered
2) log in create a list
3) add books to list
4) display list
5) click the RSS link button.
   -- bad HASH error.
6) apply patch
7) repeat steps 4&5
   -- readble junk without error messages.
8) run koha qa test tools

Signed-off-by: Katrin Fischer 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

--- Comment #36 from Alex Buckley  ---
(In reply to Marc Veron in comment 34)

Hi Marc

For some reason when I run the qa tool it only shows that all qa tests are
successful. 

However I was able to fix up the error in acqui-home.tt easily which is in the
rebased patch I have just attached to this bug report, but I am not sure how
fix up the issue with the onboardinginclude3.tt could you please suggest how
you would solve that issue?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

--- Comment #35 from Alex Buckley  ---
Created attachment 63380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63380=edit
Bug 18002 - Created a budget creation onboarding form to be displayed when the
user first visits the acquisition area

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

Alex Buckley  changed:

   What|Removed |Added

  Attachment #63151|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18573] Error when adding a suggestion in the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573

Julian Maurice  changed:

   What|Removed |Added

  Attachment #63369|0   |1
is obsolete||

--- Comment #6 from Julian Maurice  ---
Created attachment 63379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63379=edit
Bug 18573: (bug 17847 follow-up) Update av-build-dropbox.inc for OPAC

On bug 17847, av-build-dropbox.inc has been updated for the intranet,
not OPAC

There is only one call to av-build-dropbox.inc at the OPAC, from
opac-suggestion.tt

Test plan:
Create a new suggestion, anonymous or with a logged in user
=> Without this patch you got
  Template process failed: undef error - The method default is not
  covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121.
=> With this patch applied you should see the item type dropdown list
correctly filled

Reproduced without patch, OK with patch
Signed-off-by: Marc Véron 

Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18573] Error when adding a suggestion in the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18573] Error when adding a suggestion in the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #5 from Julian Maurice  ---
QAing this now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18574] Clean Patron Records tool doesn' t limit to the selected library

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #7 from Julian Maurice  ---
Passed QA

For reference, this bug was introduced by bug 17083

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18574] Clean Patron Records tool doesn' t limit to the selected library

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574

--- Comment #6 from Julian Maurice  ---
Created attachment 63378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63378=edit
Bug 18574 - Clean Patron Records tool doesn't limit to the selected library

The library selector simply does nothing because at some point the
javascript that powers it was removed. This is very bad because
the librarian may batch delete patrons assuming it is limiting by
branch correctly and instead delete patrons for all the libraries!

Test Plan:
1) Note that the library pulldown on tools/cleanborrowers.pl does nothing
2) Apply this patch
3) Note that chaning the value in the pulldown now refreshed the page and sets
the library correctly!

Signed-off-by: Katrin Fischer 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18574] Clean Patron Records tool doesn' t limit to the selected library

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #5 from Julian Maurice  ---
QAing this now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

Alex Buckley  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #13 from Alex Buckley  ---
I have just squashed the two previous patches into 1 and attached it to this
bug report, and as Jonathan suggested in comment 11 I have implemented the
following logic in the renew.tt file:

IT NOT A AND B
OR A AND NOT B:
  Do the stuff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

Alex Buckley  changed:

   What|Removed |Added

  Attachment #63293|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

--- Comment #12 from Alex Buckley  ---
Created attachment 63377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63377=edit
Bug 18450 - Implemented check if either AllowRenewLimitOverride or
AllowRenewalIfOtherItemsAvaliable were set to allow, so the user is only
blocked if both of these sysprefs are set to 'Dont allow'

Test plan:
1. In More->Administration->Global system preferences
ensure that both the AllowRenewalLimitOverride and
AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont
allow'.
2. Place a hold on an item from a patron
3. Checkout the item out to a different patron
4. Renew the item and notice the 'Cannot renew: The item is on hold for
another patron' warning
5. Click the 'Override and renew' button and notice that you
can bypass the hold
6. Apply patch
7. Renew the item again and notice that the message does not have a
'Override and renew' button it just has the 'Ignore and continue' button
8. Go back to More->Administration->Global system preferences and set
AllowRenewalLimitOverride to 'Allow'
9. Try renewing the same item again and notice that the 'Override and
renew' button is displayed
10. In systems preferences now set the
AllowRenewalIfOtherItemsAvailable syspref to 'Allow' and
AllowRenewalLimitOverride to 'Dont allow' and notice the 'Override and
renew' button is displayed
11. Now set both these sysprefs to 'Allow' and notice the 'Override and renew'
button is displayed
because you will not be violating these preferences.

Note: Checking if the renewal exceeds the renewal level, if auto renew
is set up, or if renewal is to soon is checked earlier in this
conditional
if statement earlier and so the check in this patch does not need to
check the renewal level, auto renewal, if renewal is too soon.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

Alex Buckley  changed:

   What|Removed |Added

  Attachment #63292|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18250] koha-common should start after memcached

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/