[Koha-bugs] [Bug 18640] New: Addition of installation page to Koha manual covering web installer and onboarding tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18640

Bug ID: 18640
   Summary: Addition of installation page to Koha manual covering
web installer and onboarding tool
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Documentation
  Assignee: alexbuck...@catalyst.net.nz
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

The Koha installation process has changed quite a lot for Koha 17.05 with the
addition of the onboarding tool and installer bootstrap styling and so the
installation process should be covered in the Koha manual.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1985] Email notification of new OPAC comments

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

M. Tompsett  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |mtomp...@hotmail.com

--- Comment #48 from M. Tompsett  ---
I'm close to a resurrection of this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11210] Allow partial writeoff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #2 from Christopher Brannon  ---
I am glad to see this happen.  It makes sense.  Maybe this would be a good time
to change this grouping of buttons in to an action button, defaulting to Pay
all.  Just a thought, since the number of buttons is growing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

--- Comment #6 from Marc Véron  ---
Hi Blou
I just did a git pull and then wanted to apply and sign off your patch.
But now it seems that already without your patch the last line 826 has
vanished.
Maybe it was fixed by another patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #58955|0   |1
is obsolete||

--- Comment #9 from Tomás Cohen Arazi  ---
Created attachment 63582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63582=edit
Bug 17898: Automagically convert SQL reports

Bug 17196 move the marcxml out of the biblioitems table.
That will break SQL reports using it.
It would be handy to propose an automagically way to convert the SQL
reports.

We do not want to update the reports automatically without user inputs,
it will be too hasardous.
However we can lead the user to convert them.

In this patchset I suggest to warn the user if a report is subject to be
updated.

TODO: Add a way to mark this job done (using a pref?) to remove the
check and not to display false positives.

Test plan:
- Create some SQL reports (see
https://wiki.koha-community.org/wiki/SQL_Reports_Library)
- Go on the report list page (/reports/guided_reports.pl?phase=Use saved)
- For the reports using biblioitems.marcxml you will see a new column
warning you that it is obsolete
- Click on update link
=> that will open a modal with the converted SQL query
- Click on the update button
=> you will be informed that the query has been updated

If all the reports are updated, the new column "Update" will no longer
be displayed.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #58961|0   |1
is obsolete||

--- Comment #10 from Tomás Cohen Arazi  ---
Created attachment 63583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63583=edit
Bug 17898: Followup - udpate templates for bootstrap 3

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898

--- Comment #8 from Tomás Cohen Arazi  ---
(In reply to Tomás Cohen Arazi from comment #7)
> I've been trying to make up my mind before commenting. My conclusion is that
> this is a really hard task to achieve, and thus the current behaviour (i.e.
> propose a translated SQL, no magic stuff) is the way to go. I'd put it in a
> modal, and probably add a legend stating that they should contact someone
> who knows SQL to check before overwriting the old report (or the list).
> 
> This is an example that won't work with this simplistic algorithm, but we
> could go forward without fixing it anyway, as reports are now broken for
> everyone anyway:
> 
> $sql = q|
> SELECT biblionumber,
>marcxml,
>biblioitems.issn AS issn
> FROM biblioitems
> INNER JOIN biblio USING (biblionumber)
> WHERE biblionumber = 14|;
> 
> $expected_converted_sql = q|
> SELECT biblionumber,
>metadata,
>biblioitems.issn AS issn
> FROM biblioitems
> INNER JOIN biblio USING (biblionumber)
> INNER JOIN biblio_metadata USING (biblionumber)
> WHERE biblionumber = 14|;
> 
> so the algorithm works basically only if the query uses marcxml exclusively.

I'm sorry for the first part of my comment, it is already a modal, and has an
'Update' button. I just messed up with the rebase.

I'd still add a note.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #7 from Tomás Cohen Arazi  ---
I've been trying to make up my mind before commenting. My conclusion is that
this is a really hard task to achieve, and thus the current behaviour (i.e.
propose a translated SQL, no magic stuff) is the way to go. I'd put it in a
modal, and probably add a legend stating that they should contact someone who
knows SQL to check before overwriting the old report (or the list).

This is an example that won't work with this simplistic algorithm, but we could
go forward without fixing it anyway, as reports are now broken for everyone
anyway:

$sql = q|
SELECT biblionumber,
   marcxml,
   biblioitems.issn AS issn
FROM biblioitems
INNER JOIN biblio USING (biblionumber)
WHERE biblionumber = 14|;

$expected_converted_sql = q|
SELECT biblionumber,
   metadata,
   biblioitems.issn AS issn
FROM biblioitems
INNER JOIN biblio USING (biblionumber)
INNER JOIN biblio_metadata USING (biblionumber)
WHERE biblionumber = 14|;

so the algorithm works basically only if the query uses marcxml exclusively.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #63495|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  
---
Created attachment 63581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63581=edit
Bug 18548: Print usage when missing instance name in koha-create script

Test plan:
1. Run: debian/scripts/koha-create --request-db
-> Without patch you see the getent error message
-> With patch you see usage and "Missing instance name" message

Signed-off-by: Dilan Johnpulle 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18569] Quick add patron will not copy over details from cities and towns pull down into patron details

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18569

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18569] Quick add patron will not copy over details from cities and towns pull down into patron details

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18569

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #63494|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 63580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63580=edit
Bug 18569 - Quick add patron will not copy over details from cities and towns
pull down into patron details

Followed test plan and the city value updates in the quick add form correctly.
Signed-off-by: Dilan Johnpulle 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18440] tmp_holdsqueue should have a timestamp

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18440

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2954] Holds queue report should show date/time of last update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2954

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18066] Hea - Version 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066

Kyle M Hall  changed:

   What|Removed |Added

   Severity|enhancement |new feature
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Kyle M Hall  changed:

   What|Removed |Added

  Text to go in the|This development moves  |This development moves
  release notes|marcxml out of the  |marcxml out of the
   |biblioitems and |biblioitems and
   |deletedbiblioitems tables   |deletedbiblioitems tables
   |and moves it to two new |and moves it to two new
   |tables: biblio_metadata and |tables: biblio_metadata and
   |deletedbiblio_metadata. SQL |deletedbiblio_metadata. SQL
   |queries on the marcxml data |queries using the
   |will get a performance  |biblioitems table but not
   |boost. Storing the marcxml  |the marcxml column will get
   |in a specific table will|a performance boost.
   |allow us to store several   |Storing the marcxml in a
   |metadata formats (USMARC,   |specific table will allow
   |MARCXML, MIJ, etc.).|us to store several
   |ATTENTION: all reports that |metadata formats (USMARC,
   |use ExtractValue to |MARCXML, MIJ, etc.).
   |retrieve MARC tags from |ATTENTION: all reports that
   |biblioitems.marcxml need to |use ExtractValue to
   |be updated/rewritten.   |retrieve MARC tags from
   ||biblioitems.marcxml need to
   ||be updated/rewritten.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #20 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Frido, Josef!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18578] Use subdirectory in / tmp for session storage during installation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18578

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #6 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Josef!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18597] Quick add form does not transfer patron attributes values when switching forms /saving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #7 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17665] SIP2 Item Information Response returns incorrect circulation status of ' 08' ( waiting on hold shelf ) if record has any holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17665

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #7 from Kyle M Hall  ---
Pushed to master for 17.05!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16568] Talking Tech generates phone notifications for all overdue actions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #6 from Kyle M Hall  ---
Pushed to master for 17.05!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #29 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Alex!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625

--- Comment #17 from Oliver Bock  ---
Great news! Hope this gets backported to 16.x as well.

Thanks guys!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18376] authority framework creation fails under Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #10 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Frido, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #16 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Oliver!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18482] False duplicates detected on adding a batch from a stage file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482

--- Comment #9 from Koha Team Lyon 3  ---
Created attachment 63579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63579=edit
Bug 18482 False duplicates detected on adding a batch [16.11.x]

add specific patch for 16.11.x. Just remove the biblio_count line that seems to
been added more lately

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18639] New: Separate replacement cost and retail price fields in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

Bug ID: 18639
   Summary: Separate replacement cost and retail price fields in
acquisitions
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Work to be done:

1 - Add a field 'replacementprice' to the aqorders table
2 - Display this field as 'Replacement price' when ordering
3 - Rename current 'Replacement price' field for orders to 'Retail price'
3a - 'Retail price' field will only be editable during initial ordering
3b - If 'Retail price' field is update, dependent fields will also be updated
(currently they are only updated on change of 'lsit price')
4 - Allow for replacementprice to be populated via ItemFieldsToOrder
preferences
5 - Adjust EDI scripts to allow for use of 'replacementprice' field
6 - Pass 'replacementprice' in aqorders through as 'items.replacementprice'
when creating items
7 - aqorders.replacementprice should be editable throughout entire acquisitions
workflow

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

--- Comment #5 from Blou  ---
For me, I enter "paypal" in the system preferences search and get 6 entries
under Payment in English.  I get nothing in French.
Adding the empty line fixes it.

Now, is it useless and senseless?  I agree.  I looked at circulation.pref for
comfort before commiting, and saw the "semi-emtpy" line.

I looked at fr-CA-pref.po for weirdness, could not find any.  The # OPAC >
Payments where right in the middle, all happy and comfy.

If ONE wouldn't show up, I'd get it.  But all six?  It really points to
opac.prefs, but I have no idea why (beside this dummy end line).

:(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18638] Bad display of prediction pattern with planified irregularities : translation issue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18638

Koha Team Lyon 3  changed:

   What|Removed |Added

   Priority|P5 - low|P3
 CC||k...@univ-lyon3.fr
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18638] New: Bad display of prediction pattern with planified irregularities : translation issue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18638

Bug ID: 18638
   Summary: Bad display of prediction pattern with planified
irregularities : translation issue
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@univ-lyon3.fr
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

The problem occurs in french interface.
Due to nested double quotes in French translation of a javascript message, the
message is broken, both pages of prediction pattern are displayed at the same
time and it's not possible to modify anything.

=
In the po file we have this :
#. SCRIPT
#: intranet-tmpl/prog/en/modules/serials/subscription-add.tt:13
msgid ""
"Warning! Present pattern has planned irregularities. Click on 'Test "
"prediction pattern' to check if it's still valid"
msgstr ""
"Attention ! Le modèle présent a planifié des irrégularités.Cliquez sur "
"\"Tester le prévisionnel de bulletinage\" pour vérifier s'il est toujours "
"valable"
==
In susbscription-add.tt we have :
English
   alert(_("Warning! Present pattern has planned irregularities. Click on 'Test
prediction pattern' to check if it's still valid"));
French
   alert(_("Attention ! Le modèle présent a planifié des irrégularités.Cliquez
sur "Tester le prévisionnel de bulletinage" pour vérifier s'il est toujours
valable"));

I suppose the double quotes are automatically escaped through po file creation
but to get a correct rendering double quotes should be escaped by a double
backslash.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18637] New: Handle Free Text vendor notes on Edifact Quotes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18637

Bug ID: 18637
   Summary: Handle Free Text vendor notes on Edifact Quotes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: colin.campb...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

At present we store servicing instructions from the GIR segment of the quote in
vendornote field of the order. We dont process the FTX segment (segment 25) of
the quote. Some vendors (Ebsco) do use this for important information so we
need to expand handling to handle Servicng instructions in GIR segment (both
coded and free text) and vendor notes in FTX (both free text and coded ) and be
able to include these in the generated orders

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18613] Deleting a Letter from a library as superlibrarian deletes the " All libraries" rule

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18613

Baptiste  changed:

   What|Removed |Added

  Attachment #63486|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18613] Deleting a Letter from a library as superlibrarian deletes the " All libraries" rule

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18613

Baptiste  changed:

   What|Removed |Added

 CC||baptiste.wojtkowski@biblibr
   ||e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18613] Deleting a Letter from a library as superlibrarian deletes the " All libraries" rule

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18613

--- Comment #4 from Baptiste  ---
Created attachment 63578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63578=edit
Bug 18613: Correct the behaviour

TEST PLAN

(reproducing bug)
1 - Set 'IndependantBranches' to enable
2 - Log in as Superlibrarian.
3 - Create 3 rules
- 1 for all librairies (1)
- 1 for the library of the superlibrarian (2)
- 1 for another library (3)
4 - Try to delete them and see them and see that (3) isn't the good one

(checking patch)
5 - Apply patch
6 - Try again 3-
7 - Connect as not superlibrarian
8 - Try again 3-

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552

--- Comment #4 from Marcel de Rooy  ---
Created attachment 63577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63577=edit
Bug 18552: [QA Follow-up] Resolve warnings

Like:
Problem = a value of AutoResumeSuspendedHolds has been passed to param without
key at /usr/share/koha/masterclone/C4/Templates.pm line 137.
Problem = a value of relatives_borrowernumbers has been passed to param without
key at /usr/share/koha/masterclone/C4/Templates.pm line 137.

Problem is functions returning undef in list context (in this case
housebound_role).
No need to call Patrons::find a second time.

Note: The call of GetDebarments in the first patch suffered from this too.
It is in a fine place now too. But strictly speaking, should not have been
moved.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #63557|0   |1
is obsolete||

--- Comment #3 from Marcel de Rooy  ---
Created attachment 63576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63576=edit
Bug 18552: Borrower debarments not showing on member detail page

To test:
1) Go to a borrowers details page and create a manual restriction
2) Notice the restriction shows at the top of the page but the
restriction tab says the member is currently unrestricted
3) Apply patch and refresh page
4) Restrictions tab should now correctly show debarments and correct
number is shown
5) Confirming deleting and adding restrictions still works as expected

Sponsored-by: Catalyst IT

Followed test plan, works as expected
Signed-off-by: Marc Véron 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18629] Web installer 17.05 not properly translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Marc Véron  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #3 from Marc Véron  ---
Setting to 'Needs Signoff' for the changes in step1.tt

To test:
- Create po files
- Verify that title and button text are picked by translator and appear in po
file

For other issues: Could it be that there were string changes since latest
translations were uploaded to translate.koha-community.com ?

BTW: Will bi back in about 8 hours

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342

Colin Campbell  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #19 from Colin Campbell  ---
Although the patch was applied patch code no longer there the bug has been
reinstated and is being reported - marking as reopened

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18447] Datepicker only shows -10/+10 years for date of birth

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447
Bug 18447 depends on bug 12342, which changed state.

Bug 12342 Summary: Patron registration datepicker dropdown shows only 10 years
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA

--- Comment #8 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #7)
> Any chances to see tests covering this change?

Changing status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18538] OPAC database user login internal server error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18538

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536

--- Comment #4 from Marcel de Rooy  ---
Created attachment 63574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63574=edit
Bug 18536: Generating CSV using profile in serials late issues doesn't work as
described

Description on editing csv profiles says:

"You can also use your own headers (instead of the ones from Koha) by
prefixing the field name with an header, followed by the equal sign."

So the header should be optional, but in fact it's mandatory. Also the
regular expression to cut table name from beginning of db column is not
right.

Test plan:

0. Don't apply the patch
1. Make two CSV profiles for exporting late issues
a)
SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSUENUMBER=serial.serialseq|LATE
SINCE=serial.planneddate
b) aqbooksellers.name|TITLE=subscription.title|ISSUE
NUMBER=serial.serialseq|LATE SINCE=serial.planneddate
2. Export late issues, profile a) works as expected, profile b) doesn't
3. Apply the patch
4. Both profiles should work

Signed-off-by: Katrin Fischer 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #63373|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536

--- Comment #5 from Marcel de Rooy  ---
Created attachment 63575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63575=edit
Bug 18536: [QA Follow-up] Tiny regex simplification

Simplify regex for removing table name.
No need to escape a dot between the square brackets. No need to specify a
number of 1 between parentheses.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18629] Web installer 17.05 not properly translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

--- Comment #2 from Marc Véron  ---
Created attachment 63573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63573=edit
Bug 18629 - Web installer 17.05 not properly translatable

Fix for step1.tt

Work in progress. Comments welcome.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |josef.mora...@gmail.com
   |ity.org |
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #17 from Marcel de Rooy  ---
String changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13913] Renewal error message in OPAC is confusing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13913

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

--- Comment #6 from Marcel de Rooy  ---
Looks good to me.

Cannot pass this in string freeze. The string is now in the po file with a lot
of %s's. And with html tags in between they will become separate translations.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18125] Edit button can duplicate some circulation rule

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18125

--- Comment #16 from Marcel de Rooy  ---
(In reply to Baptiste from comment #15)
> (In reply to Marcel de Rooy from comment #14)
> > (In reply to Jonathan Druart from comment #13)
> > > I am not sure this is acceptable, it will become hard to copy rules.
> > > Maybe we need an additional "Copy" action button?
> > 
> > Indeed. I am not so sure if the advantage of this oneliner outweights the
> > disadvantage of no longer being able to copy a rule.
> > It should not be that hard to add a copy button?
> 
> Hum.. the problem with a copy button it that the working of this button
> wouldn't be intuitive.
> 
> I mean if we create an copy button (like the old edit), this will not copy a
> rule if you don't modify the 2 first fields.

Yeah, you may need to lift some check first and make sure it is applied later..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18125] Edit button can duplicate some circulation rule

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18125

--- Comment #15 from Baptiste  ---
(In reply to Marcel de Rooy from comment #14)
> (In reply to Jonathan Druart from comment #13)
> > I am not sure this is acceptable, it will become hard to copy rules.
> > Maybe we need an additional "Copy" action button?
> 
> Indeed. I am not so sure if the advantage of this oneliner outweights the
> disadvantage of no longer being able to copy a rule.
> It should not be that hard to add a copy button?

Hum.. the problem with a copy button it that the working of this button
wouldn't be intuitive.

I mean if we create an copy button (like the old edit), this will not copy a
rule if you don't modify the 2 first fields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #56 from Marcel de Rooy  ---
String changes. Return after freeze.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18125] Edit button can duplicate some circulation rule

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18125

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA

--- Comment #14 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #13)
> I am not sure this is acceptable, it will become hard to copy rules.
> Maybe we need an additional "Copy" action button?

Indeed. I am not so sure if the advantage of this oneliner outweights the
disadvantage of no longer being able to copy a rule.
It should not be that hard to add a copy button?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #63260|0   |1
is obsolete||

--- Comment #4 from Marcel de Rooy  ---
Created attachment 63572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63572=edit
Bug 18534 - When IndependentBranches is enabled the pickup location displayed
incorrectly on request.pl

To recreate:
1 - Place a hold for pickup at Midway
2 - Enable independentbranches
3 - Login to staff interface as admin without superlibrarian status from
a different branch
4 - View the holds for the title you placed a hold on
5 - The hold placed in step 1 should show a dropdown with current branch
as pickup location, current branch is the only in that dropdown
6 - Verify it displays correctly for superlibrarian
7 - Apply patch
8 - The correct pickup location should show and not be editable
9 - Verify it is a dropdown

Signed-off-by: Alex Buckley 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17282] Ability to create charts for SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #62529|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17282] Ability to create charts for SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282

--- Comment #30 from Alex Arnaud  ---
Created attachment 63571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63571=edit
Bug 17282 - Fix QA comments - Add a loading message, - prevent JS error when
report fails, - fix (bootstrap 3 ?) displaying problems

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17282] Ability to create charts for SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #55605|0   |1
is obsolete||

--- Comment #25 from Alex Arnaud  ---
Created attachment 63566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63566=edit
Bug 17282: (follow-up) Use drop-down menu for download chart instead

To Test
1) Execute a report
2) Click in drop-down menu "Download" shows only three options
3) Draw a chart
4) Click again in drop-down menu "Download" shows a new option "Download chart"

Signed-off-by: Alex Arnaud 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17282] Ability to create charts for SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #55869|0   |1
is obsolete||

--- Comment #29 from Alex Arnaud  ---
Created attachment 63570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63570=edit
Bug 17282: Remove use of onclick

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17282] Ability to create charts for SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #55868|0   |1
is obsolete||

--- Comment #28 from Alex Arnaud  ---
Created attachment 63569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63569=edit
Bug 17282: Use fieldset.rows

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17282] Ability to create charts for SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #55606|0   |1
is obsolete||

--- Comment #26 from Alex Arnaud  ---
Created attachment 63567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63567=edit
Bug 17282 - Fix QA comments:

- Don't scroll to the top when deleting a column,
  - prevents to delete all columns,
  - better handling of headers/results deleting

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17282] Ability to create charts for SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #55607|0   |1
is obsolete||

--- Comment #27 from Alex Arnaud  ---
Created attachment 63568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63568=edit
Bug 17282 - Ability to exclude the last line in report results

This patch add a checkbox (exclude last line). This is useful
when this last is the result of a sql rollup which is the sum
of each column and make the chart not consistent

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17282] Ability to create charts for SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #55604|0   |1
is obsolete||

--- Comment #24 from Alex Arnaud  ---
Created attachment 63565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63565=edit
Bug 17282: Ability to create charts for SQL reports

Add a form under report's result that allow to configure and draw a
chart (pie, bar, line and combination).

Pie: Usefull only for a two-column report's result

bar: Horizontal: Can be horizontal or vertical (check/uncheck
horizontal checkbox),
 Group: allows to group columns (stacked bar chart),
 Line: show some columns as line in a bar chart (combination)

line: line chart :)

This patch adds 2 new js libraries: d3js and c3js:
  - c3.min.css
  - c3.min.js
  - d3.min.js

Test plan:
 - Apply this patch,
 - make reports,
 - draw charts,
 - that's all

Signed-off-by: Hector Castro 
Works as advertised

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #3 from Marcel de Rooy  ---
QA: Looking here now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18629] Web installer 17.05 not properly translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

--- Comment #1 from Marc Véron  ---
For the titles, we have (e.g step1.tt):

Koha  Web installer 
[% UNLESS ( language ) %] Choose your language [% END %]
[% IF ( language ) %]
[% UNLESS ( checkmodule ) %]
[% IF ( missing_modules ) %]
Perl modules missing
[% END %]
[% IF ( problems ) %]
Perl version obsolete
[% END %]
[% END %]
Check Perl dependencies
[% END %]


We are inside HTMLtags, that's wrong:
https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolkit_markup_inside_HTML

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16568] Talking Tech generates phone notifications for all overdue actions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568

--- Comment #5 from Marcel de Rooy  ---
Looks good to me (trivial change).
Another point is moving these larger queries out of the scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16568] Talking Tech generates phone notifications for all overdue actions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16568] Talking Tech generates phone notifications for all overdue actions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #63529|0   |1
is obsolete||

--- Comment #4 from Marcel de Rooy  ---
Created attachment 63564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63564=edit
Bug 16568 - Talking Tech generates phone notifications for all overdue actions

Regardless of whether the phone transport has been selected for a given
overdue action or not, the Talking Tech outbound script generates and
sends a line for that action.

Test Plan:
1) Enable Talking Tech
2) Create one or more overdue actions without a phone transport selected
   and one or more with the phone transport selected
3) Generate the overdues csv file to send to Itive
4) Note the csv file has lines for actions that do not have the phone
   transport selected
5) Apply this patch
6) Repeat step 3
7) Note the csv file now only has lines for actions that have the phone
   transport selected

Signed-off-by: Jonathan Field 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16568] Talking Tech generates phone notifications for all overdue actions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

--- Comment #10 from Baptiste  ---
I don't quite understand what is supposed to be done.
Shall we move the whole fonction in which this code is added toward
Koha::Calendar ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA

--- Comment #9 from Marcel de Rooy  ---
Code looks good at first glance.

But we are missing unit tests here. Sub process_invoice is changed in this
patch set and sub update_price_from_invoice is added. Although it seems to be a
private sub and could have been marked as such with an underscore.

Apart from missing tests for the complete Koha/EDI.pm module, the patches do
not have any test plans.

I understand that it takes time to write unit tests, but if we keep passing by
exception, they will not be written.

Minor detail: The four titles "Proposed patch" do not really convey much
information. We miss signoff lines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18630] Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630

--- Comment #3 from Marc Véron  ---
(In reply to dilan from comment #2)
> Created attachment 63563 [details]
> Patch fails to apply with fatal sha1 error
> 
> Patch fails to apply with the attached error message being displayed.

Tested on current master:

git bz apply 18630

Applies cleanly here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18630] Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630

di...@calyx.net.au changed:

   What|Removed |Added

 CC||di...@calyx.net.au

--- Comment #2 from di...@calyx.net.au ---
Created attachment 63563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63563=edit
Patch fails to apply with fatal sha1 error

Patch fails to apply with the attached error message being displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17665] SIP2 Item Information Response returns incorrect circulation status of ' 08' ( waiting on hold shelf ) if record has any holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17665

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
   Patch complexity|Trivial patch   |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17665] SIP2 Item Information Response returns incorrect circulation status of ' 08' ( waiting on hold shelf ) if record has any holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17665

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #62059|0   |1
is obsolete||

--- Comment #6 from Marcel de Rooy  ---
Created attachment 63562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63562=edit
Bug 17665 - SIP2 Item Information Response returns incorrect circulation status
of '08' ( waiting on hold shelf ) if record has any holds

If a record has any holds on it, the SIP2 item information response will
return a value of 08 "waiting on hold shelf" even if the item is not
actually a waiting hold. This is clearly a bug.

Test Plan:
1) Find an item that is not a waiting hold, but whose record has one or
   more holds.
2) Issue a SIP2 item information request
3) Note in the response, the circulation status field is '08'
4) Apply this patch
5) Repeat the item informationr request
6) Note the code is now '03' ( available )
7) Check the item in to fill the hold
8) Repeat the item information request
9) Verify the circulation status is now '08'

Followed test plan, works as expected
Signed-off-by: Marc Véron 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17665] SIP2 Item Information Response returns incorrect circulation status of ' 08' ( waiting on hold shelf ) if record has any holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17665

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8361] Issuing rule if no rule is defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8361

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|In the previous versions if |In the previous versions if
  release notes|no issuing rule is defined, |no circulation rule was
   |Koha always grantd issuing. |defined, Koha always
   |Now, with this develop, |allowed to check out. Now,
   |Koha refuses any check-out  |with this development, Koha
   |if no rule is found.|refuses check-out if no
   ||rule is found.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18629] Web installer 17.05 not properly translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Katrin Fischer  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com,
   ||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17665] SIP2 Item Information Response returns incorrect circulation status of ' 08' ( waiting on hold shelf ) if record has any holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17665

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #5 from Marcel de Rooy  ---
QA: Looking here now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|The db field opac_news.new  |The database column
  release notes|is renamed  |opac_news.new is renamed to
   |opac_news.content.
 |opac_news.content. The
   |So if   |notice templates using that
   |you are using opac_news.new |placeholder should have
   |in your notice templates,   |been updated automatically
   |you should update it to |(bug 18121).
   |opac_news.content.  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|This develop adds the   |It's now possible to
  release notes|ability to translate|translate notice templates
   |notices in different|into different languages.
   |languages. That way, if a   |There is a new 'preferred
   |library has patrons from|language' setting available
   |different countries, they   |in the user account, that
   |will not have to send the   |controls which template
   |notices in only one |will be used when
   |language but they will be   |generating notices.
   |able to translate them.
|
   |In  |
   |patron's details page you   |
   |can see a new "prefered |
   |language" entry, you select |
   |a language to use it in |
   |letters.|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #31 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #30)
> I do not like the way this bug is fixed (especially the drop of the FK).

Agree. Why not keep the FK and do not use 'UNCHANGED' etc. ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|'Persona' never really took |'Persona' never really took
  release notes|off, and although many  |off, and although many
   |browsers currently support  |browsers currently support
   |it, very few services   |it, very few services
   |actually implement it. This |actually implement it. This
   |has lead to it's founders,  |has lead its founders,
   |Mozilla, to end the |Mozilla, to end the
   |project. On November 30th,  |project. On November 30th,
   |2016, Mozilla closed the|2016, Mozilla closed the
   |persona.org services. Now   |persona.org services. Now
   |the feature is deleted from |the feature is deleted from
   |Koha.   |Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|This patch adds 008 |This patch adds a 008
  release notes|cataloguing value builder   |cataloguing value builder
   |for MARC21 classifications  |for MARC21 classifications
   |records (LCC, DDC/Dewey,|records (LCC, DDC/Dewey,
   |UDC and so on).
|UDC and so on).
   |In fact now |This is a
   |Koha doesn't really support |starting point for
   |classification records, |supporting classification
   |this is a starting point.   |records in Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #63542|0   |1
is obsolete||

--- Comment #4 from Marcel de Rooy  ---
Created attachment 63561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63561=edit
Bug 18627 - Items created via MarcItemFieldsToOrder are not linked to orders

If using MarcItemFieldsToOrder with AcqCreateItem = Create,
the order and the items will be created, but they will not be linked via
aqorders_items!

Test Plan:
1) Enable creation of items when ordering
2) Set up MarcItemFieldsToOrder
3) Upload an order record that uses the fields in step 2
4) Create a basket and add the records from the file
5) Note the order and items are created, but no rows in aqorders_items are
created
6) Apply this patch
7) Repeat steps 3-4
8) Note the rows in aqorders_items are created!

Signed-off-by: Kyle M Hall 
Signed-off-by: Marci Chen 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15879] Allow multiple plugin directories to be defined in koha-conf.xml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15879

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|Now is possible to define   |It's now possible to define
  release notes|multiple plugin directories |multiple plugin directories
   |in the Koha conf file. This |in the Koha conf file. This
   |would allow for ease of |allows for ease of plugin
   |plugin development so that  |development so that each
   |each plugin installed can   |plugin installed can live
   |live in its own git |in its own git repository.
   |repository. For |For compatibility, the
   |compatibility, the first|first plugindir instance
   |plugindir instance defined  |defined is used for
   |is used for uploading   |uploading plugins via the
   |plugins via the web |web interface.
   |interface.  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/