[Koha-bugs] [Bug 18852] New: Installation is inoperative even after fresh install

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18852

Bug ID: 18852
   Summary: Installation is inoperative even after fresh install
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: Macintosh
OS: Linux
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Database
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: c...@cjshayward.com
QA Contact: testo...@bugs.koha-community.org

As of 17.05.01, I was told there were reports of successful installations.
However, I have not been able to reproduce such.

I had earlier made a couple of attempts to add Koha to a multipurpose
appliance, and that remains my end goal. However, when I tried to back up, I
saw the same issue verbatim.

What I have done today was:

Download a fresh Linux Mint 18.1 ISO.

Build a VirtualBox VM with the ISO, with mostly default features and with
third-party addons, and also enabling auto-login, but in general intended to be
a plain vanilla install.

Rebooted; installed Chrome and touched /etc/sudoers, ran "aptitude update"; ran
"aptitude upgrade", installed MariaDB, and rebooted again.

Followed the steps, including a couple of a2enmod enablings, and created a
virtual site.

I was able to edit passwords in /etc/koha/.../koha-conf.xml, and enter the web
setup wizard.

However, I experienced identical output from the installer: at a certain point,
it says:

> Software error:
> 
> DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: Access 
> denied for user 'root'@'localhost' at 
> /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1492. at 
> /usr/share/koha/lib/Koha/Database.pm line 100
For help, please send mail to the webmaster ([no address given]), giving this
error message and the time and date of the error.

I am having difficulties with MariaDB and my difficulties may be contributing
to the problem.

My understanding, as inherited from MySQL, is that "mysql -uroot -p", for any
account that will run it, will check a password and, if you have root's
password set, will let you into the MySQL root command line if and only if you
type the password exactly.

The behavior I have observed is that as root "mysql -uroot" does not prompt for
a password, but just logs you in, and "mysql -uroot -p" prompts for a password,
but will accept any password, the empty password included. However, from an
unprivileged account, "mysql -uroot -p" prompts for a password, but none of the
passwords I've tried have worked; I've tried and used values as set in my
customized koha-conf.xml, and every single password is rejected.

I believe that this command line behavior is a symptom of the same problem
quoted above: permission is being denied for user 'root'@'localhost' where the
action in question would be permitted for any account with UID 0 and no account
with any other UID.

Again, this is after the 17.05.01 release, where it was reported to me that
some people have had success. The system setup shows a couple of my personal
idiosyncracies, but is meant to be awfully close to a procedure of "Step 1:
Create a new Linux Mint VM. Step 2: Install Koha." The behavior is the same
between the fresh new VM running 17.05.01, and an "everything but the kitchen
sink" multitool of an appliance.

C.J.S. Hayward
https://CJSHayward.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Mirko Tietgen  changed:

   What|Removed |Added

 Blocks||18851


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851
[Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18266] Internal Server Error when paying fine for lost item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266

Mirko Tietgen  changed:

   What|Removed |Added

 Blocks|18851   |
   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=18851   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851
[Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Mirko Tietgen  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=18266   |
 Depends on|18266   |18226


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226
[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code
duplication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266
[Bug 18266] Internal Server Error when paying fine for lost item
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #1 from Mirko Tietgen  ---
Bug 18226 introduces a regression for a problem fixed in Bug 15150.

Test::DBIx::Class is not mandatory because it is not available in Debian,
packaging of Koha is broken because of the use in t/00-load.t.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Mirko Tietgen  changed:

   What|Removed |Added

 Depends on||18266
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18266,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15150


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266
[Bug 18266] Internal Server Error when paying fine for lost item
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18266] Internal Server Error when paying fine for lost item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266

Mirko Tietgen  changed:

   What|Removed |Added

 Blocks||18851
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18851


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851
[Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15150] t/ tests should pass if Test::DBIx::Class is not available

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15150

Mirko Tietgen  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18851

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] New: use Test::DBIx::Class in 00-load.t breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Bug ID: 18851
   Summary: use Test::DBIx::Class in 00-load.t breaks packaging
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: mi...@abunchofthings.net
QA Contact: testo...@bugs.koha-community.org

Bug 18266 introduces a regression for a problem fixed in Bug 15150.

Test::DBIx::Class is not mandatory because it is not available in Debian,
packaging of Koha is broken because of the use in t/00-load.t.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616

Nick Clemens  changed:

   What|Removed |Added

  Attachment #64066|0   |1
is obsolete||

--- Comment #11 from Nick Clemens  ---
Created attachment 64608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64608=edit
Bug 18616 - The "Add forgot password link to OPAC" should allow patrons to use
their library card number in addition to username

Allow patrons to enter either their library card number or user name in the
"Log in" box for password recovery.

Most patrons at our library use their card number to log in and are unaware of
what their userid is. However there are some who have set a

customized userid and would prefer to use that. This patch would allow either
to be entered for password recovery.

To test:
1. Enable the password recovery feature.
2. In the OPAC, click on "Forgot you password?" link and enter a valid library
card number.
3. The error message "No account found with the provided information" appears.
4. Apply the patch.
5. Repeat step 2. The recovery email is now sent.

Note: Moved patch from 16711 back here and re-tested.
Signed-off-by: Marc Véron 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465

Nick Clemens  changed:

   What|Removed |Added

  Attachment #63046|0   |1
is obsolete||
  Attachment #64601|0   |1
is obsolete||

--- Comment #21 from Nick Clemens  ---
Created attachment 64606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64606=edit
Bug 18465 - Patron card creator: Print on duplex card printer

Card printers with duplex functionality need as input a PDF file where odd
pages contain
the front side and even pages the back side of the cards.

This patch adds such functionality.

To prepare test:
- In Patron card creator > Templates, prepare a 1 up template (1 column / 1
row) that
  fits to a single card. Give it a name like 'Duplex card template'
  (Attention, Card with and Card height seem to have wrong labels, that will go
  to a separate bug).
- In Patron card creator > Layouts create a layout for the front side and one
for
  the back side. Give them names to easily remember (Card front layout, Card
back layout)
- Go to Patron card creator > Batches and test both layouts together with the
  1 up template. Save and keepp both test files as reference.

To test:
- Apply patch. Restart memcached and plack.
- Go to Patron card creator > Batches
- Click "Export" for a batch
- In the following screen, note the new field "Select a layout for the back
side"
  with a hint what it is used for
- Leave it on 'Back side layout not used', export and compare output with test
ooutput
  from preparation. It should be the same
- Select the layout you prepared for the back side.
- Export - this file should contain 2 PDF pages per patron, one first with the
  front side, second with the back side.

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465

--- Comment #22 from Nick Clemens  ---
Created attachment 64607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64607=edit
Bug 18465: (followup) Fix issue with patron lists an do not use clone

This followup fixes duplex printing with patron lists.

Additionaly, it uses simple copy instead of clone and removes a
superfluous line, see comments #15 - #17

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

--- Comment #17 from Nick Clemens  ---
Created attachment 64605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64605=edit
Bug 16711: (QA-followup) Use count directly

See comment # 13

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Nick Clemens  changed:

   What|Removed |Added

  Attachment #63600|0   |1
is obsolete||
  Attachment #64598|0   |1
is obsolete||

--- Comment #16 from Nick Clemens  ---
Created attachment 64604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64604=edit
Bug 16711: OPAC Password recovery: Handling if multiple accounts have the same
mail address

To reproduce:
- Create 3 Accounts, login names are test01, test02, test03, Email is the same
for all.
- Go to OPAC -> Password recovery and indicate E-Mail only
- You will get an email for only one of the accounts above.

To test:
- Apply patch, restart memcached and plack
- Go to db, delete from borrower_password_recovery;
- Try steps above to reproduce. You will get an error message:
Account identification with this email address only is ambiguous.
Please use the field 'Login' as well.
- Verify that other cases work as before (provide valid / invalid login only,
  provide valid email for an existing account, provide unknown email, provide
  both login and email with all combinations of valid / invalid)

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18845] Encoding problem with subjects of list emails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18845

--- Comment #4 from Katrin Fischer  ---
Thx for checking Marc, when I get time I will try to git bisect it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685

--- Comment #13 from Danielle Elder  ---
The library I have am working with has to do 2,000 at time, any more and it
times out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13178] cardnumber field length is too short

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||ve...@veron.ch

--- Comment #8 from Marc Véron  ---
(In reply to Baptiste from comment #7)
> Created attachment 64487 [details] [review]
> Bug 13178: increase max value of CardnumberLength
> 
> testplan
> 1 - Apply patch
> 2 - Run updatedatabase.pl
> 3 - set the value of CardnumberLength to a value between 16 and 20
> 4 - Check you can enter a propper cardnumber
> (modify to 32 instead 20)

I tested by setting CardnumberLength to 20,32
for min 20 and max 32

However in cgi-bin/koha/members/memberentry.pl I get:
"Card number must be between 16 and 32 characters."
...and I can enter an card number inside this range, e.g. a length of 18.

Expected: Correct validation (card number length between 20 and 32).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18617] starting plack on reboot can fail on non-standard apache configs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18617

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #3 from M. Tompsett  ---
(In reply to Liz Rea from comment #2)
> Bump, we'll need this if we want to ever split up the apache configuration
> files as we should.

I vaguely recall that LetsEncrypt does not like split config files.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Signed Off  |Patch doesn't apply

--- Comment #8 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #7)
> Remote branch has been rebased.

It doesn't apply due to updatedatabase.pl conflicts...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17893] Move JavaScript to the footer on staff client catalog pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17893] Move JavaScript to the footer on staff client catalog pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893

--- Comment #1 from Owen Leonard  ---
Created attachment 64603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64603=edit
Bug 17893 - Move JavaScript to the footer on staff client catalog pages

This patch modifies multiple catalog-related pages in order to move
embedded JavaScript to the footer.

The JavaScript previously embedded in cat-toolbar.inc is moved to a
separate file (catalog.js).

To test, apply the patch and test JavaScript-driven interactions on all
modified pages, including JS which isn't page-specific (menus, help,
etc). The functionality of the catalog toolbar should be tested on each
page.

- Bibliographic detail pages (standard, MARC, labeled MARC, ISBD).
- Advanced search page
- Local cover image viewer
- Item search page
- Item detail page
- Search history page
- Checkout history page

https://bugs.koha-community.org/show_bug.cgi?id=17839

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17839] 'Print summary' totals charges and fines, but only shows charges

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17839

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17839] 'Print summary' totals charges and fines, but only shows charges

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17839

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17839] 'Print summary' totals charges and fines, but only shows charges

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17839

Owen Leonard  changed:

   What|Removed |Added

  Attachment #64602|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Comment on attachment 64602
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64602
Bug 17893 - Move JavaScript to the footer on staff client catalog pages

Sorry, wrong bug number

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18836] Patron login is erroring out after failing to find table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18836

M. Tompsett  changed:

   What|Removed |Added

 CC|mtomp...@hotmail.com|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17348] OpacLangSelectorMode and opaclanguagesdisplay should be combined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17348

Owen Leonard  changed:

   What|Removed |Added

Version|unspecified |master
   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org
 CC||gmcha...@gmail.com
  Component|OPAC|System Administration

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18836] Patron login is erroring out after failing to find table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18836

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #10 from M. Tompsett  ---
(In reply to C.J.S. Hayward from comment #7)
> I'm using MySQL on a Mint 18.1 VM running under VirtualBox on a Mac.
> Would it make sense to erase all traces of Koha installations and
> reinstall from scratch?

No, it makes more sense to restart the VirtualBox image from scratch. Clean is
important.

I successfully installed Koha 17.05 on Linux Mint 18 (I used
https://linuxmint.com/edition.php?id=217).

I generally followed:
https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages

I have updated the instructions to highlight the community's preference for
MariaDB.

Your use of specialized port suggests that you should read
https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages#Appendix_A:_Named-based_vs._IP-based_installations
My test was a Name Based installation, as does following the dotted blue boxes
(at least they are on my screen).

DISCLAIMER: I make no claims about overall functionality, nor do I recommend
the use of Linux Mint. Debian has the ability to add a Desktop. It makes no
sense to me using Linux Mint, when you could choose GNOME, XFCE, or a couple
others as part of the Debian installation.

Any problems you are encountering are likely related to
https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages#Ubuntu_16.04_and_MySQL_5.7
Particularly, the second option without the MySQL configuration tweak.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17839] 'Print summary' totals charges and fines, but only shows charges

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17839

--- Comment #1 from Owen Leonard  ---
Created attachment 64602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64602=edit
Bug 17893 - Move JavaScript to the footer on staff client catalog pages

This patch modifies multiple catalog-related pages in order to move
embedded JavaScript to the footer.

The JavaScript previously embedded in cat-toolbar.inc is moved to a
separate file (catalog.js).

To test, apply the patch and test JavaScript-driven interactions on all
modified pages, including JS which isn't page-specific (menus, help,
etc). The functionality of the catalog toolbar should be tested on each
page.

- Bibliographic detail pages (standard, MARC, labeled MARC, ISBD).
- Advanced search page
- Local cover image viewer
- Item search page
- Item detail page
- Search history page
- Checkout history page

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17839] 'Print summary' totals charges and fines, but only shows charges

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17839

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18845] Encoding problem with subjects of list emails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18845

--- Comment #3 from Marc Véron  ---
(In reply to Katrin Fischer from comment #2)
> Hm interesting, wonder if it could be a difference in setup/mail client? Or
> something really different between master and 16.11.

I tested with Thunderbird on PC and with my Fairphone - mails displayed as
expected.

Not sure, wasn't there a bug regarding double quotes in list titles? - Hmm, can
not find it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465

--- Comment #20 from Marc Véron  ---
Created attachment 64601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64601=edit
Bug 18465: (followup) Fix issue with patron lists an do not use clone

This followup fixes duplex printing with patron lists.

Additionaly, it uses simple copy instead of clone and removes a
superfluous line, see comments #15 - #17

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465

Marc Véron  changed:

   What|Removed |Added

  Attachment #64600|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465

--- Comment #19 from Marc Véron  ---
Created attachment 64600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64600=edit
Bug 18465: (followup) Fix issue with patron lists an ddo notuse clone

This followup fixes duplex printing with patron lists.

Additionaly, it uses simple copy instead of clone and removes a
superfluous line, see comments #15 - #17

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465

Marc Véron  changed:

   What|Removed |Added

  Attachment #64599|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465

Marc Véron  changed:

   What|Removed |Added

  Attachment #64599|1   |0
   is patch||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18845] Encoding problem with subjects of list emails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18845

--- Comment #2 from Katrin Fischer  ---
Hm interesting, wonder if it could be a difference in setup/mail client? Or
something really different between master and 16.11.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18850] New: Clone as dependency?

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18850

Bug ID: 18850
   Summary: Clone as dependency?
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org

Clone is used by Koha but does not appear on the dependencies list 
(Home > About Koha >Perl modules)

$ git grep 'use Clone'

C4/SIP/t/02patron_info.t:use Clone qw(clone);
C4/SIP/t/03checkout.t:use Clone qw(clone);
C4/SIP/t/04patron_status.t:use Clone qw(clone);
C4/SIP/t/05block_patron.t:use Clone qw(clone);
C4/SIP/t/06patron_enable.t:use Clone qw(clone);
C4/SIP/t/07hold.t:use Clone qw(clone);
C4/SIP/t/08checkin.t:use Clone qw(clone);
C4/SIP/t/09renew.t:use Clone qw(clone);
C4/SIP/t/10renew_all.t:use Clone qw(clone);
C4/SIP/t/11item_info.t:use Clone qw(clone);

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465

--- Comment #18 from Marc Véron  ---
Created attachment 64599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64599=edit
Bug 18465: (followup) Do not use clone

Use simple copy instead of clone, see comments #15 - #17

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465

--- Comment #17 from Marc Véron  ---
Ok, I tested without clone, it seems to work. Followup follows.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465

--- Comment #16 from Marc Véron  ---
(In reply to Nick Clemens from comment #15)
> create-pdf.pl
> 
> 135   #my $print_layout_xml = $layout_back_xml;
> 
> 136   my $print_layout_xml = (( ($cardscount % 2  == 1) && ( $layout_back_id
> ) ) ?
> 
> 137   clone($layout_back_xml) : clone($layout_xml) );
> 
> Fist line looks like debug, is Clone being added as a dependency here? can
> we just make a copy?
> 
> Otherwise worked well in testing

- Yes, #135 is a reminder of my tests and superfluous. As far as I remember it
was not possible to have a simple copy like in line 135, that's why I used
clone for a deep copy.

- Clone is used at other places as well (git grep 'use Clone'). Should it be
added to the dependencies? I would propose to do that in a separate bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

--- Comment #14 from Marc Véron  ---
Created attachment 64598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64598=edit
Bug 16711: (QA-followup) Use count directly

See comment # 13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Marc Véron  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #15 from Marc Véron  ---
Hope it's OK to set back to SO.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Signed Off  |Failed QA

--- Comment #13 from Nick Clemens  ---
opac-password-recovery.pl:
$search_results = [ Koha::Patrons->search( { -or => { email => $email, emailpro
=> $email, B_email  => $email } } ) ];
$resultCount = Koha::Patrons->search( { -or => { email => $email, emailpro =>
$email, B_email  => $email } } ) -> count;

It seems we could just not get the results as an array and use count directly,
casting scalar seems unnecessary as well here

i.e.
$search_results = Koha::Patrons->search( { -or => { email => $email, emailpro
=> $email, B_email  => $email } } );
...
if ( not $search_results ) {
...
elsif ( $username && $search_results->count > 1)
...
etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18845] Encoding problem with subjects of list emails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18845

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #1 from Marc Véron  ---
I tested on current master, both sending a list with title "Jugendbücher" from
staff client and from OPAC.
No problems with mails received, in both mails the subject reads: 
"Your list: Jugendbücher"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18563] Force koha.ics to only show up on first day of created calendar appointment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18563

--- Comment #3 from Marc Véron  ---
Specs:
https://tools.ietf.org/html/rfc5545#section-3.6.1

The "DTSTART" property for a "VEVENT" specifies the inclusive
start of the event.  For recurring events, it also specifies the
very first instance in the recurrence set.  The "DTEND" property
for a "VEVENT" calendar component specifies the non-inclusive end
of the event.  For cases where a "VEVENT" calendar component
specifies a "DTSTART" property with a DATE value type but no
"DTEND" nor "DURATION" property, the event's duration is taken to
be one day.  For cases where a "VEVENT" calendar component
specifies a "DTSTART" property with a DATE-TIME value type but no
"DTEND" property, the event ends on the same calendar date and
time of day specified by the "DTSTART" property.

This is an ics output from Koha / current master:

BEGIN:VCALENDAR
VERSION:2.0
PRODID:Data::ICal 0.21
BEGIN:VEVENT
DESCRIPTION:Your copy of Testtitle (barcode 12345) is due back at
  the library today
DTSTAMP:20170623T143352Z
DTSTART:20170704T215900Z
SUMMARY:Testtitle is due
UID:issue-2@192.168.1.27
END:VEVENT
END:VCALENDAR

I'm in Switzerland, so DTSTART defined in UTC time is 23.59 local time (+2,
daylight saving time)

Import in Thunderbird calendar displays OK, it shows 04.07.2017 23:59 for Begin
and for End. The event does not span to the next day.

Test on https://icalendar.org/validator.html passes OK.

Could it be that Outlook does not behave as expected? (see spec above: "...the
event ends on the same calendar date and time of day specified by the "DTSTART"
property.")

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #15 from Nick Clemens  ---
create-pdf.pl

135 #my $print_layout_xml = $layout_back_xml;

136 my $print_layout_xml = (( ($cardscount % 2  == 1) && ( $layout_back_id
) ) ?

137 clone($layout_back_xml) : clone($layout_xml) );

Fist line looks like debug, is Clone being added as a dependency here? can we
just make a copy?

Otherwise worked well in testing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572

Nick Clemens  changed:

   What|Removed |Added

   Assignee|k...@bywatersolutions.com   |n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18577] Importing a batch using a framework not fully set up causes and endless loop

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577

Nick Clemens  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |n...@bywatersolutions.com
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18577] Importing a batch using a framework not fully set up causes and endless loop

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18577] Importing a batch using a framework not fully set up causes and endless loop

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577

--- Comment #1 from Nick Clemens  ---
Created attachment 64597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64597=edit
Bug 18577 - Importing a batch using a framework not fully set up causes and
endless loop

To test:
1 - Create a new framework - don't set it up
2 - Stage some records for import
3 - Manage the import, note your new framwork is in the list
4 - Apply patch
5 - Reload the page
6 - Note the framework is no longer an option

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15686] Rename "item level holds" circ rule column to " OPAC item level holds"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686

delaye  changed:

   What|Removed |Added

 CC||stephane.del...@biblibre.co
   ||m

--- Comment #2 from delaye  ---
In the Circulation Rule, "Item level holds" works only in 'All location'..In
the OPAC don't works in th erule of a location.For me it's logic but for the
librian, this column in the table is disturbing.
I prefer before with the systeme preference

why this change?...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18563] Force koha.ics to only show up on first day of created calendar appointment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18563

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |ASSIGNED

--- Comment #2 from Marc Véron  ---
No related patch here, try to reset to "New"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18563] Force koha.ics to only show up on first day of created calendar appointment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18563

Marc Véron  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Chris Kirby  changed:

   What|Removed |Added

 CC||chris.kirby@ilsleypubliclib
   ||rary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17348] OpacLangSelectorMode and opaclanguagesdisplay should be combined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17348

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18710] Wrong subfield modified in batch item modification

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710

--- Comment #14 from Nick Clemens  ---
Paul, can you share your test plan?

I tried 
1 - Find an item with copynumber,URI, replacementprice defined (subs t,u,v)
2 - Select item fro modification
3 - Set copynumber = "NEWCOP" URI-checked to delete replacementprice="32"
4 - Modification succeeds as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13920] API authentication system - proposal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #31 from Tomás Cohen Arazi  ---
This patchset cannot depend on bug 14539... that's too much for such a simple
feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab and scripts for Koha)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618

Baptiste  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13178] cardnumber field length is too short

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178

Baptiste  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572

--- Comment #1 from Nick Clemens  ---
Created attachment 64596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64596=edit
Bug 18572 - Improper branchcode set during OPAC renewal

To test:
1 - Set 'OpacRenewalBranch' to various settings
2 - Renew an item for a ptron under each setting
3 - Confirm action_log entries reflect the correct branch for each
secnario
4 - prove t/db_dependent/Circulation/issue.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15336] Script for merging vendors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336

--- Comment #27 from Alex Arnaud  ---
Created attachment 64595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64595=edit
Bug 15336 - Fix a QA issue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15336] Script for merging vendors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18836] Patron login is erroring out after failing to find table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18836

--- Comment #9 from Katrin Fischer  ---
Ok, first thing: Don't use Mysql 5.7 - it won't work well with Koha, there are
known problems with it. It's recommended to use MariaDB instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Alex Arnaud  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #61580|0   |1
is obsolete||

--- Comment #53 from Alex Arnaud  ---
Created attachment 64594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64594=edit
Bug 15565: Alert librarian that maximum holds per record is reached

Signed-off-by: Dani Elder 

Signed-off-by: Danielle Elder 

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #61579|0   |1
is obsolete||

--- Comment #52 from Alex Arnaud  ---
Created attachment 64593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64593=edit
Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off

Signed-off-by: Danielle Elder 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #61577|0   |1
is obsolete||

--- Comment #50 from Alex Arnaud  ---
Created attachment 64591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64591=edit
Bz 15565 - CSS changes

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #61578|0   |1
is obsolete||

--- Comment #51 from Alex Arnaud  ---
Created attachment 64592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64592=edit
Bug 15565: Use item's biblionumber only on item-level request

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #61576|0   |1
is obsolete||

--- Comment #49 from Alex Arnaud  ---
Created attachment 64590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64590=edit
Bz 15565 - Place multiple holds at once for the same record on staff and OPAC.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18836] Patron login is erroring out after failing to find table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18836

--- Comment #8 from C.J.S. Hayward  ---
linux-tools monasterylibrary # mysql --version
mysql  Ver 14.14 Distrib 5.7.18, for Linux (x86_64) using  EditLine wrapper

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18836] Patron login is erroring out after failing to find table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18836

--- Comment #7 from C.J.S. Hayward  ---
I'm using MySQL on a Mint 18.1 VM running under VirtualBox on a Mac.

Would it make sense to erase all traces of Koha installations and reinstall
from scratch?

If so, what do I need to do so Koha sees a clean slate?


TIA,
C.J.S. Hayward
https://CJSHayward.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Alan  changed:

   What|Removed |Added

 CC|aschr...@eunc.edu   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18710] Wrong subfield modified in batch item modification

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710

--- Comment #13 from Lee Jamison  ---
(In reply to Nick Clemens from comment #12)
> Paul, can you share your test plan?
> 
> I tried 
> 1 - Find a patron with city, state, and zip defined
> 2 - Select patron for batch modification
> 3 - Set city = "NEWCITY" STATE-checked to delete ZIP="NEWZIP"
> 4 - Modification succeeds as expected

I haven't been able to reproduce the bug myself so I'd love to know Paul's test
plan as well. Though I believe I'm reading it correctly that the bug occurs in
batch item modification instead of batch patron modification :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18710] Wrong subfield modified in batch item modification

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18710] Wrong subfield modified in batch item modification

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #12 from Nick Clemens  ---
Paul, can you share your test plan?

I tried 
1 - Find a patron with city, state, and zip defined
2 - Select patron for batch modification
3 - Set city = "NEWCITY" STATE-checked to delete ZIP="NEWZIP"
4 - Modification succeeds as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756

--- Comment #7 from Nick Clemens  ---
Created attachment 64589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64589=edit
Bug 18756 - add Unit Test

Signed-off-by: Lee Jamison 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756

Nick Clemens  changed:

   What|Removed |Added

  Attachment #64179|0   |1
is obsolete||
  Attachment #64403|0   |1
is obsolete||

--- Comment #6 from Nick Clemens  ---
Created attachment 64588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64588=edit
Bug 18756: Users can view aq.baskets even if they are not allowed

Due to bad use of grep syntax if there is one or more Basket Users the result
of grep is not equal to 0 and the borrower is allowed.

Test plan :
1- select system preference 'AcqViewBaskets' on 'user'
2- create 2 borrowers (A, B) with only permissions on acquisition :
group_manage
order_manage
order_receive
staff
3- login with A and create a basket
4- add a basquet manager other than B
5- relog with account B
6- you can see the basket

Apply the patch.
The basket is no longer visible.
1- relog with A
2- add basquet manager B
3- relog with B
5- you must see the basket

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18672] Creation Date and Modification Date are the same for a list in the Lists Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672

--- Comment #9 from Marcel de Rooy  ---
Created attachment 64586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64586=edit
Bug 18672: Test for fixing overwriting creation date

Use this test to highlight issue:
prove -v t/db_dependent/Virtualshelves.t

After applying patch for Koha/Virtualshelf.pm it should turn green

Signed-off-by: Lee Jamison 
Works correctly according to test case. Passes QA Tools and the
indicated t/db_dependent/Virtualshelves.t unit test.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18672] Creation Date and Modification Date are the same for a list in the Lists Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672

--- Comment #10 from Marcel de Rooy  ---
Created attachment 64587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64587=edit
Bug 18672: [QA Follow-up] Simplify without sleep

Set the creation date one hour back, store and check again.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18672] Creation Date and Modification Date are the same for a list in the Lists Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|Trivial patch   |Small patch
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18672] Creation Date and Modification Date are the same for a list in the Lists Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #63781|0   |1
is obsolete||
  Attachment #64063|0   |1
is obsolete||

--- Comment #8 from Marcel de Rooy  ---
Created attachment 64585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64585=edit
Bug 18672: Fix overwriting creation date with modification date when editing
list

To reproduce:
- In staff client, create a new list (if you have not already one)
- In db, update virtualshelves and set field created_on to an earlier date,
  something like:
  update virtualshelves set created_on = '2017-04-01 02:09:12' where
shelfnumber = 1;
- Go to Home > Lists > Your lists
- Verify that the modified creation date for this list appears in staff client
- Edit list in staff client, save
- Verify that creation date is overwritten by modification date (wrong)

To test:
- Apply patch
- Repeat steps above, verify that creation date no longer is overwritten
  by modification date

Signed-off-by: Lee Jamison 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18672] Creation Date and Modification Date are the same for a list in the Lists Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Signed Off  |Failed QA

--- Comment #10 from Nick Clemens  ---
GetBudgets returns a reference, not an array, try:
my $funds = GetBudgets({ budget_period_id => $budgetperiod->{budget_period_id}
}); 
$budgetperiod->{count} = scalar @$funds;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18672] Creation Date and Modification Date are the same for a list in the Lists Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #63781|1   |0
is obsolete||

--- Comment #7 from Marcel de Rooy  ---
Comment on attachment 63781
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63781
Bug 18672 - Fix overwriting creation date with modification date when editing
list

Incorrectly obsoleted as it seems

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12027] Shibboleth authentication for staff client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA

--- Comment #25 from Marcel de Rooy  ---
(In reply to Martin Renvoize from comment #24)
> (In reply to M. Tompsett from comment #23)

> Hmm, I must admit I'd lost track fo the StaffBaseURL preference and whether
> it allowed specifying a protocol or not now; I best check up on that one.

Unfortunately for you Mark only fixed OPACBaseURL iirc. Which means that your
assumption that StaffBaseURL includes the protocol is not correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||n...@bywatersolutions.com

--- Comment #18 from Nick Clemens  ---
Two things here:
1 - 'AllowRenewalIfOtherItemsAvailable' - we need to check if other items are
available - a record with 1 item with a hold and checked out should not be
renewable (it is currently)
2 - As Jonathan mentioned in comment #11 - if we are doing the same stuff we
can do "IF A OR B OR C { stuff }" - no need for if/elsif

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA

--- Comment #7 from Marcel de Rooy  ---
Have the impression that we should not hide labels with a syspref but resolve
this with custom css. Please convince me that I am wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843

--- Comment #13 from Marcel de Rooy  ---
Created attachment 64584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64584=edit
Bug 17843: [QA Follow-up] Some polishing

Resolve warning from members/summary-print.pl:
"my" variable $itemtype masks earlier declaration in same scope

Test if find returns a Koha object in GetDescription.
Test if find returns a Koha object too in shelves.pl. While testing, I had
a crash on a biblioitem with itemtype NULL (bad record, but these things
tend to happen somehow.)
Can't call method "imageurl" on an undefined value at virtualshelves/shelves.pl
line 253.
Same for opac/opac-shelves.pl.

Note: Did not add tests everywhere but generally, I have the impression that
we do not sufficiently test on the results of Koha::Object->find. Mostly we
just assume that it will find a record. Several reports include fixes to
resolve that wrong assumption.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #64401|0   |1
is obsolete||

--- Comment #12 from Marcel de Rooy  ---
Created attachment 64583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64583=edit
Bug 17843: Remove C4::Koha::getitemtypeinfo

At this point there should not be any calls to this subroutine.

Signed-off-by: Lari Taskula 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #64400|0   |1
is obsolete||

--- Comment #11 from Marcel de Rooy  ---
Created attachment 64582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64582=edit
Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes

The C4::Koha::getitemtypeinfo subroutine did the almost same job as
GetItemTypes. On top of that it returned the imageurl value processed by
C4::Koha::getitemtypeimagelocation.
This value is only used from the 2 [opac-]shelves.pl scripts. Then it's
better not retrieve it only when we need it.

Test plan:
Play with the different scripts touched by this patch and focus on item
types. The same description as prior to this patch must be displayed.
Note that sometimes it is not the translated description which is
displayed, but that should be fixed on another bug report. Indeed we do
not expect this patch to change any behaviors.

Signed-off-by: Lari Taskula 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843

--- Comment #10 from Marcel de Rooy  ---
QA: Looking here now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18104] allow SIP2 field AE (personal name ) to be customized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18104

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #64580|0   |1
is obsolete||

--- Comment #5 from Marcel de Rooy  ---
Created attachment 64581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64581=edit
Bug 18104: [QA Follow-up] Add a test for customized name in AE

Test plan:
Run t/db_dependent/SIP/Message.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/