[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

--- Comment #7 from Marc Véron  ---
(In reply to M. Tompsett from comment #5)
> (In reply to Marc Véron from comment #4)
> > To have translated item descriptions you can go to 
> > Home > Administration > Item types > Modify item type 'BK' 
> > 
> > There you have a link 'Translate into other languages' to create 
> > translations
> > To test, you can even 'translate' for English to overwrite the original
> > description.
> 
> But that is by overwriting the actual description. Not by just changing the
> language selected. I think the comment was about having a way to po-i-size
> it. Patch is okay, but it's really a commentary on having DB translations,
> not just templates, I think.

Maybe there is a misunderstanding.

- Item types are defined by the library (or loaded together with the example
values, in the language choosen for installation).
- When defining an item type, the library can define translations for other
(installed) languages as well. E.g. in Switzerland a library could define an
item type with code 'BUCH' and the description "Buch" for German and the
translated descriptions "Livre" for French and "Libro" for Italian
- The (translated) description appears (is overlayed) depending on the language
selected by the user.
- You can not po-i-size that because the library defines the item types.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
Did you check the description Marc gave? The value will change with switching
the language if you have configured it.

It doesn't make sense to have po files for configurable values that are
different for each library. The new way to save the translations in a separate
table works better, as every library can change it any time. I think Marc's
patch is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10540] Saving interesting code (unit tests) from the deleted KohaTest suite

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10540

Marcel de Rooy  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10540] Saving interesting code (unit tests) from the deleted KohaTest suite

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10540

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18605] Remove TRUNCATE from C4/HoldsQueue.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18605

--- Comment #3 from Marcel de Rooy  ---
(In reply to M. Tompsett from comment #2)
> Signed-off-by: Mark Tompsett 

Thx

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #1 from Alex Buckley  ---
Created attachment 64742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64742=edit
bug 18743 - Partially working filter of suggestions by libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Alex Buckley  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz
   |ity.org |
 CC||alexbuck...@catalyst.net.nz
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18884] New: Advanced search on staff client, Availability limit not properly limiting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18884

Bug ID: 18884
   Summary: Advanced search on staff client, Availability limit
not properly limiting
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mich...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Created attachment 64741
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64741=edit
limit here is limit=BN, not limit=holdingbranch%3ABN, which causes an item not
from this library (Bison) showing in search results

On the advanced search area, when you limit to a specific library in the
availability limits, the resultant search string is:

/cgi-bin/koha/catalogue/search.pl?idx=au=janet=and=kw=and=kw=E_by=relevance

where the limit is: limit=E for holding branch...the limit should be

/cgi-bin/koha/catalogue/search.pl?idx=au=evanovich+janet=and=kw=and=kw=holdingbranch%3ABN_by=relevance

limit=holdingbranch%3ABN

This means that currently a limit for a specific library will return books not
in that library.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18605] Remove TRUNCATE from C4/HoldsQueue.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18605

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18605] Remove TRUNCATE from C4/HoldsQueue.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18605

M. Tompsett  changed:

   What|Removed |Added

  Attachment #63462|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 64740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64740=edit
[SIGNED-OFF] Bug 18605: Remove TRUNCATE from C4/HoldsQueue.pm

Replaces TRUNCATE by DELETE, since truncate implicitly commits. We don't
need to do that here. (Would complicate testing it too.)
Fixes typo disablig.
Add a simple test to HoldsQueue.t.

Test plan:
Run t/db_dependent/HoldsQueue.t

Signed-off-by: Marcel de Rooy 
Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18782] Remove unused C4::Serials::getsupplierbyserialid

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18782

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64194|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 64739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64739=edit
[SIGNED-OFF] Bug 18782: Remove unused C4::Serials::getsupplierbyserialid

TEST PLAN
--
git grep -i getsupplierby
-- only the code removed and the test tweaked
git bz apply 18782
sudo koha-shell -c bash kohadev
prove -v t/db_dependent/Serials.t
qa -v 2 c 1
exit
-- sign off

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18782] Remove unused C4::Serials::getsupplierbyserialid

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18782

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18781] Translatability: Get rid of exposed tt directives in openlibrary-readapi.inc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18781

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64192|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 64738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64738=edit
[SIGNED-OFF] Bug 18781: Translatability: Get rid of exposed tt directives in
openlibrary-readapi.inc

The file koha-tmpl/opac-tmpl/bootstrap/en/includes/openlibrary-readapi.inc
exposes template directives to translation. The only string that should
appear in .po from this file is "Open Library: "

To test:
- Apply patch
- Verify that code changes make sense
- Bonus test: create a new language 'aa-AA', verify in aa-AA-opac-bootstrap.po
  that there is only the following string for openlibrary-readapi.inc:
msgid "Open Library: "
msgstr ""

NOTE: Followed a test plan similar to bug 18776 comment 3

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18781] Translatability: Get rid of exposed tt directives in openlibrary-readapi.inc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18781

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18780] Translatability: Get rid of exposed tt directive in masthead-langmenu.inc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18780

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18780] Translatability: Get rid of exposed tt directive in masthead-langmenu.inc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18780

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64191|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 64737
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64737=edit
[SIGNED-OFF] Bug 18780: Translatability: Get rid of exposed tt directive in
masthead-langmenu.inc

The file opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc exposes
following tt directive to translators:

"[%% IF ( ( opaclanguagesdisplay ) && ( ! one_language_enabled ) && "
"( languages_loop ) && ( OpacLangSelectorMode == 'both' || "
"OpacLangSelectorMode == 'top') ) %%] "

This patch fixes it.

To test:
- Apply patch
- Verify that language selector in OPAC (top of the page) works as expected
- Bonus test: create a new language 'aa-AA', verify that line above does not
show up in aa-AA-opac-bootstrap.po

NOTE: Followed a test plan similar to bug 18776 comment 3

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18778] Translatability: Get rid of tt directive in translation for item-status.inc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18778

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18778] Translatability: Get rid of tt directive in translation for item-status.inc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18778

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64189|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 64736
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64736=edit
[SIGNED-OFF] Bug 18778 - Translatability: Get rid of tt directive in
translation for item-status.inc

The file opac-tmpl/bootstrap/en/includes/item-status.inc exposes a template
directive where translators should not be confronted with.

"%s %s [%%#- This include takes two parameters: an item structure and an "
"optional loan (issue) structure. The issue structure is used by course "
"reserves pages, which do not use an API to fetch items that populates item."
"datedue. -%%] %s %s %s %s "

This patch fixes new lines inside a tt directive (comment).
It is merely a string patch.

To test:
Verify that the code changes make sense.
(Bonus test: create a new language 'aa-AA', verify that line above does not
show up in aa-AA-opac-bootstrap.po)

NOTE: Followed test plan similar to bug 18776 comment 3.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18777] Translatability: Get rid of exposed tt directives in opac-memberentry.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18777

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64182|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 64735
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64735=edit
[SIGNED-OFF] Bug 18777: Translatability: Get rid of exposed tt directives in
opac-memberentry.tt

The file opac-memberentry.tt exposes template directives to translation where
translators should not be confronted with.

Example from po file:
"%s [%% UNLESS hidden.defined('B_address') && hidden.defined('B_address2') && "
"hidden.defined('B_city') && hidden.defined('B_state') && hidden."
"defined('B_zipcode') && hidden.defined('B_country') && hidden."
"defined('B_phone') && hidden.defined('B_email') && hidden."
"defined('contactnote') %%] "

To test:
- Apply patch
- Verify that advanced search in OPAC the page 'your personal details'
  behaves as before
- Verify that you can change values and submit an update request
- Create a new translation for a 'language' aa-AA (perl translate create aa-AA)
- Verify that template directives ar no longer exposed in
aa-AA-opac-bootstrap.p

NOTE: Followed test plan similar to bug 18776 comment 3.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18777] Translatability: Get rid of exposed tt directives in opac-memberentry.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18777

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18883] New: koha-http.conf designed for Apache 2.2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18883

Bug ID: 18883
   Summary: koha-http.conf designed for Apache 2.2
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

I was installing a Koha site from source and got a syntax error from the
"Order" directive since I am using Apache 2.4 and koha-http.conf is designed
for Apache 2.2.

It's an easy enough change to use "Require all denied" instead of "Order
deny,allow\n Deny from all", but I wonder if we should update the file to use
Apache 2.4 just to keep non-package installs more in-line with package installs
(although I suppose there are quite a few differences between the Apache
configuration files anyway).

I was planning to submit a patch using mod_version, but that's an extension
module, so I think it might be a bit much to expect people to install that just
to run Koha out of the box. I notice openSUSE doesn't even have mod_version in
the 42.2 repositories, so I'm just going to update my file to 2.4 sytnax, but
thought I'd raise it here in any case.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18776] Translatability: Get rid of exposed tt directives in opac-advsearch.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18776

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #3 from M. Tompsett  ---
TEST PLAN ON KOHADEVBOX
---
sudo koha-shell -c bash kohadev
echo $PERL5LIB
-- notice that misc/translator is missing
export PERL5LIB=$PERL5LIB:/home/vagrant/kohaclone/misc/translator
cd /home/vagrant/kohaclone/misc/translator
perl translate create aa-AA
exit
git bz apply 18776
sudo koha-shell -c bash kohadev
export PERL5LIB=$PERL5LIB:/home/vagrant/kohaclone/misc/translator
cd /home/vagrant/kohaclone/misc/translator
perl translate create aa-AB
diff po/aa-AA-opac-bootstrap.po po/aa-AB-opac-bootstrap.po
-- notice that only AA has differences, except for a generation date.
-- be confused that 3 weren't in AA in the first place, even though
   they have the same line breaks, and formatting.
qa -v 2 -c 1
cd po
rm -f aa-A*
exit
-- sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18776] Translatability: Get rid of exposed tt directives in opac-advsearch.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18776

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64181|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 64734
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64734=edit
[SIGNED-OFF] Bug 18776: Translatability: Get rid of exposed tt directives in
opac-advsearch.tt

The file opac-advsearch.tt exposes template directives to translation where
translators should not be confronted with.
Example in po file:
"[%% IF ( ( OpacAdvSearchOptions and OpacAdvSearchOptions.grep('itemtype')."
"size > 0 and not expanded_options ) or ( OpacAdvSearchMoreOptions and "
"OpacAdvSearchMoreOptions.grep('itemtype').size > 0 and expanded_options ) ) "
"%%] "

To test:
- Apply patch
- Verify that advanced search in OPAC behaves as before
- Create a new translation for a 'language' aa-AA (perl translate create aa-AA)
- Verify that template directives ar no longer exposed in
aa-AA-opac-bootstrap.po

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18776] Translatability: Get rid of exposed tt directives in opac-advsearch.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18776

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060

Alex Buckley  changed:

   What|Removed |Added

  Attachment #63589|0   |1
is obsolete||
  Attachment #63589|1   |0
   is patch||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060

--- Comment #9 from Alex Buckley  ---
Created attachment 64733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64733=edit
Bug 18060 - Label onboarding tool to be displayed when no labels or templates
exist

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060

Alex Buckley  changed:

   What|Removed |Added

  Attachment #63588|0   |1
is obsolete||
  Attachment #63588|1   |0
   is patch||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060

Alex Buckley  changed:

   What|Removed |Added

  Attachment #63229|1   |0
   is patch||
  Attachment #63229|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060

Alex Buckley  changed:

   What|Removed |Added

  Attachment #63587|1   |0
   is patch||
  Attachment #63587|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

--- Comment #40 from Alex Buckley  ---
Created attachment 64732
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64732=edit
Bug 18002 - Created an acquisition onboarding tool to be displayed when no
currency, budget, or fund exists

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

Alex Buckley  changed:

   What|Removed |Added

  Attachment #63456|0   |1
is obsolete||
  Attachment #63456|1   |0
   is patch||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18640] Addition of installation page to Koha manual covering web installer and onboarding tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18640

Alex Buckley  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #1 from Alex Buckley  ---
This has been implemented into the Koha 17.05 manual:
https://koha-community.org/manual/17.05/html/01_installation.html#web-installer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18817] Screenshots not appearing in the manual linked to the Help tab

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18817] Screenshots not appearing in the manual linked to the Help tab

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64427|0   |1
is obsolete||

--- Comment #9 from M. Tompsett  ---
Created attachment 64731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64731=edit
[SIGNED-OFF] Bug 18817 Correct Manual URL

Corrected the manual url in the help screen for 17.05 onward.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18771] CGI.pm: Subroutine multi_param redefined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18771

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64729|1   |0
is obsolete||

--- Comment #7 from M. Tompsett  ---
Comment on attachment 64729
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64729
Bug 18771: CGI.pm: Subroutine multi_param redefined

Needed to make the second patch apply. Patches were split so testing could be
done to prove why the final result is the final result.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

--- Comment #5 from M. Tompsett  ---
(In reply to Marc Véron from comment #4)
> To have translated item descriptions you can go to 
> Home > Administration > Item types > Modify item type 'BK' 
> 
> There you have a link 'Translate into other languages' to create translations
> To test, you can even 'translate' for English to overwrite the original
> description.

But that is by overwriting the actual description. Not by just changing the
language selected. I think the comment was about having a way to po-i-size it.
Patch is okay, but it's really a commentary on having DB translations, not just
templates, I think.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18771] CGI.pm: Subroutine multi_param redefined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18771

Lee Jamison  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18771] CGI.pm: Subroutine multi_param redefined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18771

Lee Jamison  changed:

   What|Removed |Added

  Attachment #64729|0   |1
is obsolete||

--- Comment #6 from Lee Jamison  ---
Created attachment 64730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64730=edit
Bug 18771: CGI.pm: Subroutine multi_param redefined

TEST PLAN
-
Follow the test plan on the first patch.

Notice that with both patches applied, it is just a require CGI;
and comment added.

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18771] CGI.pm: Subroutine multi_param redefined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18771

Lee Jamison  changed:

   What|Removed |Added

  Attachment #64165|0   |1
is obsolete||
  Attachment #64166|0   |1
is obsolete||

--- Comment #5 from Lee Jamison  ---
Created attachment 64729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64729=edit
Bug 18771: CGI.pm: Subroutine multi_param redefined

The commands in the test plan are examples, and may need varying
depending on your installation. This was created as a result
of attempting to clean the installation process up. However,
I believe the redefine might exist normally too. I just didn't
check. This is tested on a Debian 8 box sudo apt-get update'd
fully.

TEST PLAN
-
empty error log
$ echo > ~/koha-dev/var/log/koha-error_log

drop and recreate and empty db
> drop database koha_library;
> create database koha_library;
> quit

run the web installer, but DO NOT LOG IN!
*opening chrome to Staff Client URL*

check the error log
$ less ~/koha-dev/var/log/koha-error_log
...
[Fri Jun 09 13:08:52.793627 2017] [cgi:error] [pid 5802] [client
192.168.71.101:58169] AH01215: [Fri Jun  9 13:08:52 2017] CGI.pm: Subroutine
multi_param redefined at /usr/share/perl5/CGI.pm line 419.
...

apply first patch

empty error log
$ echo > ~/koha-dev/var/log/koha-error_log

refresh the installation login page

recheck the error log
$ less ~/koha-dev/var/log/koha-error_log

[Fri Jun 09 12:59:06.705954 2017] [cgi:error] [pid 5692] [client
192.168.71.101:57887] AH01215: Low version
[Fri Jun 09 12:59:06.723323 2017] [cgi:error] [pid 5692] [client
192.168.71.101:57887] AH01215: Is actually: 4.09
...

notice that 4.09 is bigger than the 4.08 condition, and that
the code was triggered because $CGI::VERSION is undefined,
since there was no require to set the VERSION value.

apply second patch

empty error log
$ echo > ~/koha-dev/var/log/koha-error_log

refresh the installation login page

recheck the error log
$ less ~/koha-dev/var/log/koha-error_log

notice no reference to "Subroutine multi_param redefined"

run koha qa test tools

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18800] Patron card images: Add some more explanation to upload page and fix small translatability issue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18800

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.10.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18697] Fix date calculations for day/week frequencies in Serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18697

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #23 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.10.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18607] Fix date calculations for monthly frequencies in Serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #13 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.10.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #17 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.10.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #16 from M. Tompsett  ---
The icons should ALWAYS display, regardless of the item-itype system
preference, should they not?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

--- Comment #15 from M. Tompsett  ---
Comment on attachment 64279
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64279
Bug 18799: Display icons on results.tt

Review of attachment 64279:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18799=64279)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
@@ +532,5 @@
>   [% IF ( SEARCH_RESULT.XSLTResultsRecord ) %]
>  [% SEARCH_RESULT.result_number %].
> +[% IF !noItemTypeImages && 
> SEARCH_RESULT.imageurl %]
> + title="[% SEARCH_RESULT.description %]" style="float: left; margin: .1em;" 
> alt="[% SEARCH_RESULT.description %]" />
> +[% END %]

Now after testing, I get it. This will always display for XSLT records
regardless of the item-itype system preference setting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64279|0   |1
is obsolete||

--- Comment #14 from M. Tompsett  ---
Comment on attachment 64279
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64279
Bug 18799: Display icons on results.tt

Owen's patch is better, in my opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

--- Comment #13 from M. Tompsett  ---
I hope Fridolin doesn't mind, but I really believe Owen's patch is better.
Style inlined is really bad HTML, not to mention Owen actually optimizes the
UNLESS code into one spot and brings code consistency. It's beautiful, Owen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 Status|In Discussion   |Needs Signoff

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64327|0   |1
is obsolete||
 CC||mtomp...@hotmail.com

--- Comment #10 from Owen Leonard  ---
I think this bug can be fixed in a different way which will be acceptable to
all. I'm preparing an alternate patch.

--- Comment #11 from Owen Leonard  ---
Created attachment 64327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64327=edit
Alternate patch which preserves status quo on biblio vs. item-level itemtypes

Bug 18799 [ Alternate ] XSLTresultsdisplay hides the icons

If item-level_itypes is turned off and  XSLTResultsDisplay is turned on,
biblio-level itemtype images are not shown in staff client search
results. This patch corrects the problem.

This patch also adds some markup and CSS to the itemtype image to make
it look a litte cleaner and work better in result sets in which some
titles have images and some don't.

To test, apply the patch and view the staff client search results page
with various settings:

- XSLT turned on and off
- item-level_itypes turned on and off
- noItemTypeImages turned on and off

Confirm that item type images are shown or not shown correctly according
to each setting.

The difference between this patch and the other patch currently on this
bug is that this patch continues the practice of hiding biblio-level
itemtype information when item-level_itypes is ON.

--- Comment #12 from M. Tompsett  ---
Created attachment 64728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64728=edit
Alternate patch which preserves status quo on biblio vs. item-level itemtypes

Hopefully this makes Owen's patch a nice patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18816] Make CataloguingLog work in production by preventing circulation from spamming the log

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18816

--- Comment #4 from M. Tompsett  ---
Patch does not apply because of bug 16534. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18816] Make CataloguingLog work in production by preventing circulation from spamming the log

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18816

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #3 from M. Tompsett  ---
Patch does not apply because of bug 16354. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18882] Add location code to statistics table for checkouts and renewals

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18882

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |In Discussion

--- Comment #2 from M. Tompsett  ---
The code puts '' if there is no location key. But if the location key is NULL,
because I hadn't set my shelving location, there is NULL. Do we want NULL's? If
so, I'll sign this off. If not, could you tweak that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18869] Patron clubs and templates tables look strange when empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |In Discussion

--- Comment #2 from M. Tompsett  ---
It looks good.

REPRODUCE OUTPUT QUESTION:
Add a template
Add a club
Delete a club

Just quick question. If there are no templates or clubs, should it not revert
to this new style of nothing? Or is this okay?

If it is okay, then I'll sign off. If it should revert to the initial nothing
style, then this needs a tweak.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

--- Comment #4 from Marc Véron  ---
(In reply to M. Tompsett from comment #3)
> (In reply to Marc Véron from comment #1)
> > (In reply to Marc Véron from comment #0)
> > > Translated itemtype description is not used in display of Holds queue
> >  
> > Translated itemtype descriptions display OK, but there is a superfluous
> > comment in circ/view_holdsqueue.pl
> 
> It is because your description is translated in the first place, or does
> switching languages actually give a valid translation for each language?

To have translated item descriptions you can go to 
Home > Administration > Item types > Modify item type 'BK' 

There you have a link 'Translate into other languages' to create translations
To test, you can even 'translate' for English to overwrite the original
description.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18882] Add location code to statistics table for checkouts and renewals

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18882

--- Comment #1 from Kyle M Hall  ---
Created attachment 64727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64727=edit
Bug 18882 - Add location code to statistics table for checkouts and renewals

Some libraries wish to track what the current location of items was at the time
they were checked out. This will help libraries track which physical locations
in the library patrons are more likely to check out a given book from.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Check out an item that has a location set
4) Renew that item
5) View the checkout and renewal in the statistics table,
   verify each has the location column populated correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18882] Add location code to statistics table for checkouts and renewals

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18882

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #3 from M. Tompsett  ---
(In reply to Marc Véron from comment #1)
> (In reply to Marc Véron from comment #0)
> > Translated itemtype description is not used in display of Holds queue
>  
> Translated itemtype descriptions display OK, but there is a superfluous
> comment in circ/view_holdsqueue.pl

It is because your description is translated in the first place, or does
switching languages actually give a valid translation for each language?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18882] Add location code to statistics table for checkouts and renewals

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18882

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18882] New: Add location code to statistics table for checkouts and renewals

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18882

Bug ID: 18882
   Summary: Add location code to statistics table for checkouts
and renewals
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Some libraries wish to track what the current location of items was at the time
they were checked out. This will help libraries track which physical locations
in the library patrons are more likely to check out a given book from.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

Marc Véron  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |
 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch
   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

--- Comment #2 from Marc Véron  ---
Created attachment 64726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64726=edit
Bug 18881:  Remove comment about translated itemtype description in
circ/view_holdsqueue.pl

This patch removes a superfluous FIXME comment.

To test:
Compare code, verify that comment correctly is removed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

Marc Véron  changed:

   What|Removed |Added

Summary|Remove comment about|Remove comment about
   |translated description in   |translated itemtype
   |itemtype|description in
   |circ/view_holdsqueue.pl |circ/view_holdsqueue.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated description in itemtype circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

--- Comment #1 from Marc Véron  ---
(In reply to Marc Véron from comment #0)
> Translated itemtype description is not used in display of Holds queue

Translated itemtype descriptions display OK, but there is a superfluous comment
in circ/view_holdsqueue.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated description in itemtype circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

Marc Véron  changed:

   What|Removed |Added

Summary|Use translated description  |Remove comment about
   |in itemtype |translated description in
   |circ/view_holdsqueue.pl |itemtype
   ||circ/view_holdsqueue.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Use translated description in itemtype circ/view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

Marc Véron  changed:

   What|Removed |Added

 Depends on||18859


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859
[Bug 18859] Warns when accessing Circulation -> Holds Queue
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18859] Warns when accessing Circulation -> Holds Queue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859

Marc Véron  changed:

   What|Removed |Added

 Blocks||18881


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881
[Bug 18881] Use translated description in itemtype circ/view_holdsqueue.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] New: Use translated description in itemtype circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

Bug ID: 18881
   Summary: Use translated description in itemtype
circ/view_holdsqueue.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Translated itemtype description is not used in display of Holds queue

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18859] Warns when accessing Circulation -> Holds Queue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18859] Warns when accessing Circulation -> Holds Queue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859

Marc Véron  changed:

   What|Removed |Added

  Attachment #64666|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 64725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64725=edit
Bug 18859: Prevent warns when viewing holds queue

The code was using $itemtypes->description instead of
$itemtype->description.

To test:
1) View the intranet log
2) Go to Circulation -> Holds queue
3) Notice the warns
4) Apply patch and refresh page
5) Warns should not appear and item types should still display as
expected

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18878] Improve item form display / labels too far from input fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18878

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16485] Collection column in Item search is always empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485

Marc Véron  changed:

   What|Removed |Added

Summary|collection column in Item   |Collection column in Item
   |search is always empty  |search is always empty

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16485] collection column in Item search is always empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18654

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16485

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18633] Logs are full of CGI:: param called in list context - itemsearch.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16485

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16485] collection column in Item search is always empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18633

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18735] Print Barcode as soon as adding an item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18735

--- Comment #1 from DEVINIM  ---
Created attachment 64724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64724=edit
Bug-18735 Print Barcode as soon as adding an item

For testing
1) Look for any records.
2) Go to the material edit page.
3) Under Actions you will see Print label under Duplicate.
4) When you click Print Label, the relevant material will be redirected to the
Label Creator module in the Tools menu.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16485] collection column in Item search is always empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485

Marc Véron  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654

Marc Véron  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654

--- Comment #6 from Marc Véron  ---
Created attachment 64723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64723=edit
Bug 18654 - Translatability: Get rid of tt directives starting with [%% in
translation for itemsearch.tt

This patch removes entries like the following in translations of itemsearch.tt:
"[%% INCLUDE form_field_select name=\"homebranch\" options = branches "
"empty_option = \"All libraries\" %%] [%% INCLUDE form_field_select name="
"\"holdingbranch\" options = branches empty_option = \"All libraries\" %%] %s "
"[%% INCLUDE form_field_select name=\"location\" options = locations "
"empty_option = \"All locations\" %%] %s "

New patch on top of Bug 18633 that resolves parts of initial comment.

To test:
- Verify that in itemsearch.tt no tt directives are splitted by new lines
  (search for [% INCLUDE )
- Verify that itemsearch.tt works as before

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654

Marc Véron  changed:

   What|Removed |Added

  Attachment #64177|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654

Marc Véron  changed:

   What|Removed |Added

 Depends on||18633


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633
[Bug 18633] Logs are full of CGI::param called in list context - itemsearch.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18633] Logs are full of CGI:: param called in list context - itemsearch.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633

Marc Véron  changed:

   What|Removed |Added

 Blocks||18654


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654
[Bug 18654] Translatability: Get rid of tt directives starting with [%% in
translation for itemsearch.tt
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18633] Logs are full of CGI:: param called in list context - itemsearch.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18633] Logs are full of CGI:: param called in list context - itemsearch.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633

Marc Véron  changed:

   What|Removed |Added

  Attachment #64710|0   |1
is obsolete||

--- Comment #12 from Marc Véron  ---
Created attachment 64722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64722=edit
Bug 18633: Remove remaining use of CGI.param in template

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18633] Logs are full of CGI:: param called in list context - itemsearch.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633

Marc Véron  changed:

   What|Removed |Added

  Attachment #64709|0   |1
is obsolete||

--- Comment #11 from Marc Véron  ---
Created attachment 64721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64721=edit
Bug 18633: Remove useless use of CGI TT plugin

The form is sent using AJAX so there is never a query string in
the URL (no POST parameters either)

Tested both patches together, item search behaves as before, log
entries are gone
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18149] Move CountUsage calls to Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149

--- Comment #1 from Marcel de Rooy  ---
Created attachment 64720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64720=edit
Bug 18149: Move CountUsage calls to Koha namespace

After the introduction of Koha::Authorities->get_usage_count with bug
9988, we can now replace the remaining occurrences of CountUsage.

At the same time we remove CountUsageChildren. This was an empty sub.
The typo get_count_usage in a subtest title is adjusted.

Test plan:
[1] Run t/db_dependent/Koha/Authorities.t
[2] Perform a search on authorities-home.pl and verify that you see
plausible numbers for 'used in xx records'.
[3] Click on Details for one authority. See the same number?
[4] Do the same as in 2/3 for Authority search on OPAC.
[5] Remember the authid and enter this in the record numbers box on
tools/batch_delete_records.pl. Select Authorities and click
Continue. The next form shows a column "Used in". Do you see
the same count again?
[6] Git grep CountUsage.
You should see just one hit in a comment that can be kept in
Koha/Authorities.pm.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18149] Move CountUsage calls to Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #20 from Magnus Enger  ---
(In reply to Jonathan Druart from comment #18)
> Fridolin, It's not obvious that what you described in the bug description is
> a bug.
> The sentence is "XXX suggestions waiting. Manage suggestions.", it implies
> all suggestions.

One of my customers reported this as a bug. When they see "Suggestions pending
approval: 2" and click on that text they find it confusing that they are shown
zero suggestions. I have explained the workaround to show all waiting
suggestions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18314] Account lockout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314

Oliver Bock  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18880

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18880] New: Regression breaks local authentication fallback for all external authentications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880

Bug ID: 18880
   Summary: Regression breaks local authentication fallback for
all external authentications
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Authentication
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oliver.b...@aei.mpg.de
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

Created attachment 64719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64719=edit
Proposed patch

A regression in commit cfc484b17 / bug #18314 breaks the local authentication
fallback for all external authentications like LDAP, CAS and Shibboleth. The
severity is critical for us as we, while using LDAP authentication, use the
self-service checkout which requires a local user account. Also non-LDAP staff
can't log into the staff pages anymore.

The regression itself is a logical error as "@return = (0)" is considered to be
"false" when checked with "unless". That's wrong as "unless" tests the number
of elements in a list. Thus the "falsy" condition has to established with
"@return = ()" instead.

Please find attached a proposed patch against "17.05.x". Also, please make sure
the fallback workflow gets test coverage.

Thanks,
Oliver

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880

Oliver Bock  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18314

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18879] Sending notices via Facebook messenger

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18879

Mike  changed:

   What|Removed |Added

 CC||blac...@gmail.com,
   ||josef.mora...@gmail.com,
   ||r...@rbit.cz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18879] New: Sending notices via Facebook messenger

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18879

Bug ID: 18879
   Summary: Sending notices via Facebook messenger
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: blac...@gmail.com
QA Contact: testo...@bugs.koha-community.org

I saw some services that use FB Messenger for sending customer notices. What do
you thing about it guys? Maybe its "cooler way" for younģer patrons. Its free
for library, it can turn into interactive talk with two real people, so it can
help to make better relationship between library and patrons.
Description of API:
https://developers.facebook.com/docs/messenger-platform

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18400] Noisy warns in opac-search.pl during itemtype sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400

--- Comment #13 from Pongtawat  ---
Created attachment 64718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64718=edit
Bug 18400 - [16.11]  Noisy warns in opac-search.pl during itemtype sorting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18400] Noisy warns in opac-search.pl during itemtype sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400

Pongtawat  changed:

   What|Removed |Added

 CC||pongta...@punsarn.asia

--- Comment #12 from Pongtawat  ---
We also encounter this problem in 16.11. My teammate found out the reason for
$itemtype corruption was line 291:

searchcategory => $itemtypes->{$thisitemtype}->{'searchcategory'},

This automatically add a hash ->{'searchcategory'} to $itemtypes.

The correct code should likely be:

searchcategory => $thisitemtype->{'searchcategory'},

I attached a patch for 16.11. We tested this on our 16.11 installation and it
also fix the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12431] Relevance does not work properly when using QueryParser

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12431

Eric Vantillard  changed:

   What|Removed |Added

 CC||eric.vantill...@evaxion.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18878] Improve item form display / labels too far from input fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18878

--- Comment #1 from Katrin Fischer  ---
Created attachment 64717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64717=edit
item form after suggested change

In IntranetUserCss:

#cataloguing_additem_newitem fieldset.rows label, #cataloguing_additem_newitem
fieldset.rows span.label {
text-align: right;
}

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12310] Accept different monetary formats as input

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

--- Comment #33 from Baptiste  ---
> Hi Babtiste
> 
> - Functionality works OK

Owww yeah ! :p

> 
> - In syspref DigitSeparator I have . and , defined as separators, however
> the message says:
> Please use any of the following character(s) "," as separator : ex "XX,XX".
> Edit Separator 
> I would expect:
> Please use any of the following character(s) ".," as separator : ex "XX,XX".
> Edit Separator 
> (BTW: the space before : (French style) is not necessary in English)

hum ok, I'll do it 

> 
> - In 'Create manual credit", the message says:
> Example: 5.00 Please use any of the following character(s) "," as separator
> : ex "XX,XX". Edit Separator 
> The first part 'Example: 5.00' is superfluous, or maybe better: Reword your
> hint message to:
> Please use any of the following character(s) "," as separator. Example: 5,00
> Edit Separator 

This isn't so easy to do since the general message is now in an include: this
is not splittable, I think I can just remove the old message and use only the
common message for this one too.

> 
> - In aqbudgets.pl (Administration > Budgets > Funds > Modify fund we have 3
> fields with decimal separator, but only 'Amount' and 'Warning at (amount)'
> trigger. 'Warning at (%)' does not trigger. - Additionally I think it would
> be enough to display the hint message only once (with the first field).
> 
> - There are more input fields with decimal separator, e.g. in acquisitions
> when ordering, receiving... Do you plan to implement the decimal separator
> here as well (maybe in a bug that depends on this one)?

Initially, this was designed to allow cc/paste of monetary sums (with $ or €
symbol eventually). At the moment I don't think I will extend this to other
fields if they are not monetary: I'm living Biblibre in two weeks and I'm not
sure I will have enough time, but if someone wants to open a new ticket (or
continue this one) please feel free.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18878] Improve item form display / labels too far from input fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18878

Katrin Fischer  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/