[Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab and scripts for Koha)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #65066|0   |1
is obsolete||

--- Comment #7 from Brendan Gallagher  ---
Created attachment 65067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65067=edit
Bug 18618: Mana - Add scripts to send readings

- There are 2 differents scripts:
misc/cronjobs/mana_send_pairs.pl -> please use it if Mana is installed
misc/cronjobs/mana_send_pairs_without_mana.pl -> designed to work if mana isn't
enabled

- Both of scripts anonymize the datas and send them to mana.

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab and scripts for Koha)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #64531|0   |1
is obsolete||

--- Comment #9 from Brendan Gallagher  ---
Created attachment 65069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65069=edit
Bug 18618: Add a pagination for suggestions

*** Suggestions are now sent from Mana as follows

- Koha requests the first 20 suggestions
- It processes them and estimates how much it will need to get all suggestions
- It requests Mana the number of suggestions needed
- It repeats the 3 first steps until
(1) Mana doesn't have suggestions anymore
(2) It got 10 suggestions to display

*** Koha interface is a bit more verbose while searching (just a bit).

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab and scripts for Koha)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #63497|0   |1
is obsolete||

--- Comment #8 from Brendan Gallagher  ---
Created attachment 65068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65068=edit
Bug 18618: Mana - Add reading suggestion

There is now a module to get suggestions from Mana.

- It is activated by default on Mana.
- When you browse on a notice, there is now a tab called "Suggestions"
- On click on the tab, it will check in the database if it has suggestions.
- Else, it will ask to Mana for suggestions and will store in the database.

- The suggestions are stored in the NEW table reading_pairs
- Implement new dbix objets: Reading_suggestion and Reading_suggestions

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab and scripts for Koha)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #64960|0   |1
is obsolete||

--- Comment #10 from Brendan Gallagher  ---
Created attachment 65070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65070=edit
Bug 18618: Correct Plack issues

Split one command line into two in order to be accepted by Plack

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab and scripts for Koha)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #63496|0   |1
is obsolete||

--- Comment #6 from Brendan Gallagher  ---
Created attachment 65066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65066=edit
Bug 18618: Mana - Add scripts to send readings

- There are 2 differents scripts:
misc/cronjobs/mana_send_pairs.pl -> please use it if Mana is installed
misc/cronjobs/mana_send_pairs_without_mana.pl -> designed to work if mana isn't
enabled

- Both of scripts anonymize the datas and send them to mana.

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab and scripts for Koha)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18941] C4:: Budgets GetBudgetByCode should return active budgets over inactive budgets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18941

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #3 from M. Tompsett  ---
I have two problems.
1) this adds a lot of fields because of the JOIN.
   -- should change the * to aqbudget.* at least
2) if I apply the unit tests but not the fix, I expected a failure.
   They still passed. How do I know the condition is fixed?

Marking Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

Barton Chittenden  changed:

   What|Removed |Added

 CC||bar...@bywatersolutions.com
Summary|Allow deletion of   |Authorised value categories
   |authorised value categories |cannot be deleted
   Severity|enhancement |normal

--- Comment #2 from Barton Chittenden  ---
*** Bug 18813 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #64653|0   |1
is obsolete||

--- Comment #130 from Brendan Gallagher  ---
Created attachment 65063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65063=edit
Bug 17047: Correct encoding issues

Modify the function manaRequest in order to set the right encoding format
(UTF-8).

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #64706|0   |1
is obsolete||
  Attachment #64962|0   |1
is obsolete||

--- Comment #131 from Brendan Gallagher  ---
Created attachment 65064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65064=edit
Bug 17047: Minor changes

- search on reports module is now also validated by pressing enter.
- AutoShare now initialized with nothing autmaticaly shared.
- To create a report you now have to click on New report => New report from
Mana.
- Error messages are displayed in case of fail
- Correct the display of sql reports containing "'"

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #64652|0   |1
is obsolete||

--- Comment #129 from Brendan Gallagher  ---
Created attachment 65062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65062=edit
Bug 17047 security token agst flooding for Mana-KB

Rework messages from Mana-KB.

- Add A syspref contains an authentication token. The token will be used to
prevent anaonymous flooding of Mana-KB
- To get an Authentication token, you have to fill a form and validate your
e-mail address
- Messages return codes are now correctly displayed and there shouldn't be any
crash when Mana-KB webservices return a wrong answer or doesn't answer

Test plan:
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in
../etc/koha-conf.xml (after  for example)


https://mana-kb.koha-community.org
3 - Check Mana syspref and AutoShareWithMana syspref are not activated
4 - Search the syspref ManaToken and follow the instructions
5 - subscriptions
  - Try create a new subscription for a first serial  => Mana-KB shouldn't
show you anything (except if the base hase been filled)
  - Share this serial with Mana-KB (on the serial individual's page there
must be a Share button)
  - Try to create a new subscription for serial nr1 => a message should
appear when you click on "next", click on "use", the fields should automaticaly
appear
  - Activate AutoShareWithMana => Subscriptions
  - Create a new subscription for a second serial
  - There shouldn't be any Share button
  - Create a second subscription => the message should appear, click again
on use

6 - SQL Report
  - Create a new SQL report, without notes.
  - On the table with all report (reports > use saved), there should be the
action "Share"
  - If you click on share, you have an error message
  - Create a new report, with a title and notes longer than 20 characters
  - You  can share it with mana => you will have a success message
  - On (report > use saved), there must be a message inviting you to search
on Mana-KB for more results, enter a few word from title, notes, type of  the
report you shared, it should appear. You can use it, it will load it into your
report list.

7 - Report mistakes.
  - On any table containing Mana-KB search results, you can report a
mistake and add a comment.

8 - For each previous test, try to send wrong data, to delete the security
token, to send nothing: it should show a correct warning message.

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #132 from Brendan Gallagher  ---
Created attachment 65065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65065=edit
Bug 17047: Minor changes

- Importing a report from Mana now opens the edit page
- You don't get message after a successful import from mana (you simply get
redirected)

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #64651|0   |1
is obsolete||

--- Comment #128 from Brendan Gallagher  ---
Created attachment 65061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65061=edit
Bug 17047 SQL reports management with Mana-KB

Includes:

* code factorization
Some code from subscription & Mana-KB has been factorized in order to speed-up
next developments

* SytemPreferences:
Mana Activation:
- add a value "no, let me think about it", that is the default value.
- as long as this value is selected, messages ask if user want to activate
it ( in Administration and Add-subscription(page 2) )
AutoShareWithMana
- Add the syspref AutoShareWithMana: user can automatically share infos
with Mana-KB (not set by default)

* Interface :
- On mana-search, rows are now sorted by date of last import, then by
number of users
- Windows redesigned to improve the user experience

* New Feature : report a mistake.
- people can now report an invalid data (wrong, obsolete,...)
- if a data is reported as invalid many time, it will appear differently
- Added few tooltip (to explain the fields last import, nb of users, to
explain the new feature)
- When reporting a data as invalid, a comment can also be added. Koha will
then display comments related to data in result lists

* API (svc/mana)
- add svc/mana/addvaluetofield: allows to ask mana incrementing a field of
a resource
- no hardcoding for resources in the code of api (api needs to be called
with a ressourcename)

* New feature : SQL report sharing
- Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
- New feature: share reports with Mana-KB
- New feature: search report in Mana-KB with keywords
- New feature: load reports from Mana-KB

=
Test plan
=
(see BibLibre complete documentation, attached to this patch)
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in
../etc/koha-conf.xml
3 - Check Mana syspref and AutoShareWithMana syspref are not activated

4 - subscriptions
- Try create a new subscription for a first serial  => Koha shouldn't show you
anything (except if the base hase been filled)
- Share this serial on Mana-KB (on the subscription detail page there must be a
Share button)
- Try to create a new subscription for serial #1 => a message should appear
when you click on "next", click on "use", the fields should automaticaly appear
- Activate AutoShareWithMana => Subscriptions
- Create a new subscription for a second serial
- There shouldn't be any Share button
- Create a second subscription => the message should appear, click again on use

5 - SQL Report
- Create a new report, without notes.
- On the table with all report (reports > use saved), there should be the
action "Share"
- If you click on share, you have an error message
- Create a new report, with a title and notes longer than 20 characters
- You can share it on Mana-KB => you will have a success message
- On (report > use saved), there must be a message inviting you to search on
mana-KB for more results, enter a few word from title, notes, type of the
report you shared, it should appear. You can use it, it will load it into your
report list.

6 - Comments.
- On any table containing mana search results, you can report a mistake &
comment why you report: click on report mistake. You only can chose "other"
because there's no comment in Mana-KB [if there are comments, you'll get other
values].
- If you click other, a new textbox appears. Enter a short comment.
- Reload the whole page, the comment should appear in the menu and in the
comment column.
- If you select a comment and reload the whole page, there should be one more
comment with this name
- If you select a comment and click on cancel just after, there shouldn't be
any change when you reload.

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #64649|0   |1
is obsolete||

--- Comment #126 from Brendan Gallagher  ---
Created attachment 65059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65059=edit
Bug 17047 subscriptions management with Mana-KB

- add a class SharedContent.pm to communicate with Mana-KB server
- add a link in serials-menu.inc to serials_search.pl to open
a mana-subscription research form
- modify the research form in serials-search.tt to show the right fields
for Mana-KB
- create datatable in mana-subscription-search-result.inc to show
results from a research on Mana-KB
- modify serials-search.pl to manage research on Mana-KB

- add a mana_id to subscription table
- add a share button on serials-toolbar.inc and a modal to ask
the language of the share and to alert if the subscription is
already link to a Mana-KB subscription model
- add function in C4/Serials to get all the info for a subscription
sharing
- modify subscription-detail.pl to manage sharing to Mana-KB

- modify subscription-add.tt and subscription.pl to manage a
import from Mana-KB during a subscription creation
- add 2 script in svc for ajax calling from subscription-add.tt
to communicate with Mana-KB server during a asubscription creation
- add a function in Subscription.pm to have all the info for a Mana-KB research
from a biblionumber
- modify functions used by subscription-add.pl in C4/Serials to manage a
frequency which came from Mana-KB server and not already created on the
koha database, and modify the tests of the said functions

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #64650|0   |1
is obsolete||

--- Comment #127 from Brendan Gallagher  ---
Created attachment 65060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65060=edit
Bug 17047 Mana-KB, Add unit tests

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #64648|0   |1
is obsolete||

--- Comment #125 from Brendan Gallagher  ---
Created attachment 65058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65058=edit
Bug 17047 add Mana-KB syspref

Add the system preference to enable or disable Mana-KB webservice on koha.

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18564] koha-common.cnf parsing is too restrictive

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18564

M. Tompsett  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16690] Installing DB on remote server fails without *.* permissions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690

M. Tompsett  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18908] Warning "Compatibility levels before 9 are deprecated"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18908

M. Tompsett  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18907] Warning "dpkg-source: warning: relation < is deprecated: use < < or <="

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18907

M. Tompsett  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9409] koha-create --request-db should be able to accept a dbhost option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9409

M. Tompsett  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18877] Outdated explanation of use when two patches applied

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18877

M. Tompsett  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533

M. Tompsett  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18938] opac/svc/patron_notes and opac/ opac-issue-note.pl use GetMember

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18938

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #2 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18901] Sysprefs translation: translate only *.pref files (not *.pref* )

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18901

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #35 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18748] Noisy t/db_dependent/AuthorisedValues.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #9 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #19 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #8 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18938] opac/svc/patron_notes and opac/ opac-issue-note.pl use GetMember

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18938

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18938] opac/svc/patron_notes and opac/ opac-issue-note.pl use GetMember

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18938

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18938] opac/svc/patron_notes and opac/ opac-issue-note.pl use GetMember

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18938

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18938] opac/svc/patron_notes and opac/ opac-issue-note.pl use GetMember

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18938

--- Comment #1 from Jonathan Druart  
---
Created attachment 65057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65057=edit
Bug 18938: (bug 17829 follow-up) Replace 2 occurrences of GetMember left behind

Between patch submission and push, 2 new occurrences appeared in the
codebase.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18942] CanUserUseBudget.t and CanUserModifyBudget.t missing system user test cases

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

Lee Jamison  changed:

   What|Removed |Added

  Attachment #65052|0   |1
is obsolete||

--- Comment #6 from Lee Jamison  ---
Created attachment 65056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65056=edit
Bug 18942: Internal Server Error symptomatic of using system user

TEST PLAN
-
1) sudo koha-shell -c bash kohadev
2) prove -v t/Budgets/CanUserUseBudget.t
   -- works
3) prove -v t/Budgets/CanUserModifyBudget.t
   -- works
4) exit
5) git bz apply 18942
   -- interactive just the test patch
6) repeat steps 1-4
   -- prove fails (similar message with 919 in comment #0)
7) git bz apply 18942
   -- interactive just the actual fix
8) repeat steps 1-4
   -- works
9) run koha qa test tools

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18942] CanUserUseBudget.t and CanUserModifyBudget.t missing system user test cases

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

Lee Jamison  changed:

   What|Removed |Added

  Attachment #65051|0   |1
is obsolete||

--- Comment #5 from Lee Jamison  ---
Created attachment 65055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65055=edit
Bug 18942: Add test case to prove change

Signed-off-by: Lee Jamison 
Works as directed following test plan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18942] CanUserUseBudget.t and CanUserModifyBudget.t missing system user test cases

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

Lee Jamison  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18938
   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=18938   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18938
[Bug 18938] opac/svc/patron_notes and opac/opac-issue-note.pl use GetMember
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18938] opac/svc/patron_notes and opac/ opac-issue-note.pl use GetMember

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18938

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17829
   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=17829   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829
[Bug 17829] Move GetMember to Koha::Patron
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #65037|0   |1
is obsolete||
  Attachment #65038|0   |1
is obsolete||

--- Comment #33 from Jonathan Druart  
---
Created attachment 65053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65053=edit
Bug 18880: Fix authentication fallback for external authentications

A regression in commit cfc484b17 / bug #18314 breaks the local
authentication fallback for all external authentications like LDAP, CAS
and Shibboleth.

The regression itself is a logical error as "@return = (0)" is
considered to be "false" when checked with "unless" (line 1814). That's
wrong as "unless" tests the number of elements in a list.

This patch tries to simplify the logic by adding a $passwd_ok and
$check_internal_as_fallback flags to be more verbose and hopefully more
understandable.
The goal here is simply to restore back the same logic as before cfc484b17

Signed-off-by: Lee Jamison 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880

--- Comment #34 from Jonathan Druart  
---
Created attachment 65054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65054=edit
Bug 18880: [QA Follow-up] Finishing touch

Do not fill @return if retval == -1 for LDAP (see cfc484b17).
No need to call store after an DBIx update. Rearranged the if statement.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18942] CanUserUseBudget.t and CanUserModifyBudget.t missing system user test cases

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

M. Tompsett  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18942] CanUserUseBudget.t and CanUserModifyBudget.t missing system user test cases

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18942] CanUserUseBudget.t and CanUserModifyBudget.t missing system user test cases

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

--- Comment #3 from M. Tompsett  ---
Created attachment 65051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65051=edit
Bug 18942: Add test case to prove change

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18942] CanUserUseBudget.t and CanUserModifyBudget.t missing system user test cases

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

--- Comment #4 from M. Tompsett  ---
Created attachment 65052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65052=edit
Bug 18942: Internal Server Error symptomatic of using system user

TEST PLAN
-
1) sudo koha-shell -c bash kohadev
2) prove -v t/Budgets/CanUserUseBudget.t
   -- works
3) prove -v t/Budgets/CanUserModifyBudget.t
   -- works
4) exit
5) git bz apply 18942
   -- interactive just the test patch
6) repeat steps 1-4
   -- prove fails (similar message with 919 in comment #0)
7) git bz apply 18942
   -- interactive just the actual fix
8) repeat steps 1-4
   -- works
9) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18942] CanUserUseBudget.t and CanUserModifyBudget.t missing system user test cases

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

--- Comment #2 from M. Tompsett  ---
-- and expanded scope a little: same file, same tweak.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18942] CanUserUseBudget.t and CanUserModifyBudget.t missing system user test cases

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

M. Tompsett  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |mtomp...@hotmail.com
   |ity.org |
Summary|t/Budget/CanUserUseBudget.t |CanUserUseBudget.t and
   |missing system user test|CanUserModifyBudget.t
   |case|missing system user test
   ||cases

--- Comment #1 from M. Tompsett  ---
Given there is an easy way to trigger this problem. I changed the title.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18942] t/Budget/CanUserUseBudget.t missing system user test case

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

M. Tompsett  changed:

   What|Removed |Added

Summary|Acquisitions module fails   |t/Budget/CanUserUseBudget.t
   |to load with an error when  |missing system user test
   |using system user   |case

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18942] Acquisitions module fails to load with an error when using system user

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
Summary|Acquisitions module fails   |Acquisitions module fails
   |to load with an error when  |to load with an error when
   |hash created on empty   |using system user
   |values  |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18942] New: Acquisitions module fails to load with an error when hash created on empty values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

Bug ID: 18942
   Summary: Acquisitions module fails to load with an error when
hash created on empty values
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ldjami...@marywood.edu
QA Contact: testo...@bugs.koha-community.org

Under certain circumstances, the Acquisitions module fails to load at
CanUserUseBudget in C4::Budgets.

To replicate (assuming using kohadevbox):
1. Login as koha_kohadev
2. Attempt to load the Acquisitions module
3. Notice Internal Server Error
4. Check plack log which shows Can't call method "unblessed" on an undefined
value at /home/vagrant/kohaclone/C4/Budgets.pm line 919.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18527] Add a system preference to exclude renewals from the quick slip

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #9 from Katrin Fischer  ---
Can we document how this would work with TT?

Excluding the renewed ones = removing checkouts with last renewal today?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18941] C4:: Budgets GetBudgetByCode should return active budgets over inactive budgets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18941

--- Comment #2 from Nick Clemens  ---
Created attachment 65050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65050=edit
Bug 18941 - Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18941] C4:: Budgets GetBudgetByCode should return active budgets over inactive budgets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18941

--- Comment #1 from Nick Clemens  ---
Created attachment 65049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65049=edit
Bug 18941 - C4::Budgets GetBudgetByCode should return active budgets over
inactive budgets

To test:
1 - Create an active budget
2 - Create an inactive budget
3 - Ensure they each have a fund with the same code
4 - Set MarcFieldsToOrder to get the budget_code from a marc field
5 - Stage a file using the duplicated code
6 - Add to a basket from the staged file
7 - Add the items
8 - Note funds are encumbered from the inactive budget
9 - Apply patch
10 - Repeat 5-8 with a new basket
11 - Note the active budget is now used

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18941] C4:: Budgets GetBudgetByCode should return active budgets over inactive budgets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18941

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #21 from Katrin Fischer  ---
I wonder if we should treat this as a bug instead, as it causes a problem for
libraries with family accounts. What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14039] Add patron title to checkout screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #16 from Katrin Fischer  ---
Hi David, 
I think you can fix it easily - just make the id a class. If you have multiple
elements with the same id on a page, this will cause problems, for example you
will not be able to target them with jQuery in my experience. So Jonathan is
right that we might want to be careful here.
class attributes can appear many times and will work nicely here to be on the
safe side.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18941] New: C4:: Budgets GetBudgetByCode should return active budgets over inactive budgets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18941

Bug ID: 18941
   Summary: C4::Budgets GetBudgetByCode should return active
budgets over inactive budgets
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: n...@bywatersolutions.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

When closing a budget/creating new budgets at the end of the year fund codes
are duplicated.

When importing orders from a staged file we retrieve the budget using only the
fund code, this is problematic if we have multiple budgets.

When we really see the effect is a library that creates a new inactive budget
for upcoming year, this budget's fund end up being implicitly selected by DB
order.

We instead need to explicitly select active funds.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #64610|0   |1
is obsolete||

--- Comment #5 from Marcel de Rooy  ---
Created attachment 65048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65048=edit
Bug 18572 - Improper branchcode set during OPAC renewal

To test:
1 - Set 'OpacRenewalBranch' to various settings
2 - Renew an item for a ptron under each setting
3 - Confirm action_log entries reflect the correct branch for each
secnario
4 - prove t/db_dependent/Circulation/issue.t

Signed-off-by: David Kuhn 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #4 from Marcel de Rooy  ---
DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key
constraint fails (`koha_master`.`clubs`, CONSTRAINT `clubs_ibfk_2` FOREIGN KEY
(`branchcode`) REFERENCES `branches` (`branchcode`)) [for Statement "DELETE
FROM branches"] at t/db_dependent/Circulation/issue.t line 65.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18748] Noisy t/db_dependent/AuthorisedValues.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18940] New: Generate new account emails when importing patrons via tools

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18940

Bug ID: 18940
   Summary: Generate new account emails when importing patrons via
tools
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Some institutions would like the ability to send account emails in bulk when
importing new patrons (e.g. A school adding new patrons at the start of each
term)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18748] Noisy t/db_dependent/AuthorisedValues.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18748] Noisy t/db_dependent/AuthorisedValues.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #64433|0   |1
is obsolete||

--- Comment #8 from Marcel de Rooy  ---
Created attachment 65047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65047=edit
Bug 18748: Noisy t/db_dependent/AuthorisedValues.t

This noise is from a failure. This patch expands the delete
to 952$c for the ACQ framework as per comment #5.

TEST PLAN
-

insert into marc_subfield_structure (tagfield,tagsubfield,liblibrarian,
libopac, repeatable, mandatory,
kohafield,tab,authorised_value,authtypecode,value_builder,isurl,hidden,frameworkcode,seealso,link,defaultvalue,maxlength)
values (952,'c','Shelving location','Shelving
location',0,0,'items.location',10,'LOC','','',0,0,'ACQ','','',null,);
-- this makes sure you have a pre-existing 952$c ACQ record.

prove t/db_dependent/AuthorisedValues.t
-- should have ugly message like in comment #0
apply patch
prove t/db_dependent/AuthorisedValues.t
-- should be green
run koha qa test tools

Signed-off-by: Lee Jamison 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #64978|0   |1
is obsolete||

--- Comment #18 from Marcel de Rooy  ---
Created attachment 65046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65046=edit
Bug 18262: Fix test in MultiplePerRecord

The biblioitem entry must be added

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #64977|0   |1
is obsolete||

--- Comment #17 from Marcel de Rooy  ---
Created attachment 65045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65045=edit
Bug 18262: Koha::Biblio - Remove GetBiblioData - part 1

Most of the time C4::Biblio::GetBiblioData is used to retrieve the title
and/or the author of a bibliographic record.

This patch replaces the easy occurrences of GetBiblioData, the ones
where the 2 joins are needed, but only data from biblio and biblioitems
table are.

Test plan:
It will be hard to test everything, I'd suggest a QAer to review this
patch and confirm that the difference occurrences of GetBiblioData have
been correctly replaced by calling Koha::Biblios->find or
$biblio->bibioitem

Signed-off-by: Owen Leonard 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #16 from Marcel de Rooy  ---
You remove this test in Acquisition.pm:
if ($biblioitem->{isbn}
-and $order->{isbn}
-and $biblioitem->{isbn} eq $order->{isbn} )
-{
Looks fine to me, but noting it for the record.

opac-search.pl
use C4::Biblio; # Unused here?
No: I see e.g. GetMarcBiblio

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14039] Add patron title to checkout screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039

--- Comment #15 from David Roberts  ---
The only reason I added an id was because it failed QA without one. Now it's
failed QA with one! Can't win.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #65041|0   |1
is obsolete||

--- Comment #6 from Marcel de Rooy  ---
Created attachment 65043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65043=edit
Bug 18259: Koha::Biblio - Remove GetSubscriptionsId

C4::Biblio::GetSubscriptionsId can be replaced using
Koha::Biblio->subscriptions

Test plan:
Create a new order for a bibliographic record
Create a new subscription on this biblio
>From the basket (acquisition), confirm that you are not able to delete
the order with the biblio ("Can't cancel order and delete catalog record
1 subscription(s) left")
Receive the order
On the parcel page, confirm that you are not able to delete the order
with the biblio

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #65042|0   |1
is obsolete||

--- Comment #7 from Marcel de Rooy  ---
Created attachment 65044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65044=edit
Bug 18259: [QA Follow-up] Replace variable name

The variable name has_subscriptions implies that it is a boolean. In reality
we save the number of subscriptions into it. Renaming has_ to cnt_.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #64826|0   |1
is obsolete||

--- Comment #4 from Marcel de Rooy  ---
Created attachment 65041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65041=edit
Bug 18259: Koha::Biblio - Remove GetSubscriptionsId

C4::Biblio::GetSubscriptionsId can be replaced using
Koha::Biblio->subscriptions

Test plan:
Create a new order for a bibliographic record
Create a new subscription on this biblio
>From the basket (acquisition), confirm that you are not able to delete
the order with the biblio ("Can't cancel order and delete catalog record
1 subscription(s) left")
Receive the order
On the parcel page, confirm that you are not able to delete the order
with the biblio

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259

--- Comment #5 from Marcel de Rooy  ---
Created attachment 65042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65042=edit
Bug 18259: [QA Follow-up] Replace variable name

The variable name has_subscriptions implies that it is a boolean. In reality
we save the number of subscriptions into it. Renaming has_ to cnt_.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

--- Comment #54 from Mirko Tietgen  ---
Regarding packages, I found the following:

> $ apt-file search Locale::Util
> libdatetime-locale-perl: /usr/share/man/man3/DateTime::Locale::Util.3pm.gz
> libintl-perl: /usr/share/man/man3/Locale::Util.3pm.gz
> libsharyanto-utils-perl: /usr/share/man/man3/SHARYANTO::Locale::Util.3pm.gz
> 
> $ rmadison libintl-perl
> debian:
>  libintl-perl | 1.20-1| squeeze  | source, all
>  libintl-perl | 1.20-1| wheezy   | source, all
>  libintl-perl | 1.23-1| jessie-kfreebsd  | source, all
>  libintl-perl | 1.23-1+deb8u1 | jessie-kfreebsd-security | source, all
>  libintl-perl | 1.23-1+deb8u1 | jessie-security  | source, all
>  libintl-perl | 1.23-1+deb8u1 | jessie   | source, all
>  libintl-perl | 1.26-2| stretch  | source, all
>  libintl-perl | 1.26-2| buster   | source, all
>  libintl-perl | 1.26-2| sid  | source, all


If that is the correct package and the version in Jessie is ok, I don't see a
problem.

This is only about availability of the dependency, not about the other
questions Marcel brought up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA

--- Comment #53 from Marcel de Rooy  ---
This patchset includes a new perl dep: Locale::Util. You call set_locale two
times. I am not sure if it is packaged for Debian; could not find it so
quickly.
Should be added to PerlDependencies?

Also do we really need it? Can we use POSIX instead, or do without it,
construct it some other way ?? Glancing through CPAN, I note: It is not the
recommended way to set the program locale for a regular application.

Changing status to reflect need for feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

--- Comment #29 from Colin Campbell  ---
Yes this newer patch doesnt address the underlying problem identified above. So
that it returns to the random situation of manifesting in some cases and not
others

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA

--- Comment #28 from Marcel de Rooy  ---
Spent some time on this one and it is still confusing.
With and without this patch I got back in AF:
AFItem is reserved for another patron upon return.|

Also saw this in log:
Jul 14 09:52:05 master koha_sip[31568]: Blocking checkout Reason:rescardnumber
Jul 14 09:52:05 master koha_sip[31568]: Blocking checkout Reason:resbranchcode
Jul 14 09:52:05 master koha_sip[31568]: Blocking checkout Reason:ressurname
Jul 14 09:52:05 master koha_sip[31568]: Blocking checkout
Reason:resborrowernumber
Jul 14 09:52:05 master koha_sip[31568]: Blocking checkout Reason:resfirstname
Jul 14 09:52:05 master koha_sip[31568]: Blocking checkout Reason:resreservedate

My conclusion sofar: The problem is in the hash from CanBookBeIssued. The way
we loop through this hash now in sub do_checkout will not (always) resolve the
problem. It just depends on what comes first in the hash and fills screen_msg.
Instead of looping thru all entries, we should probably test for exists
RESERVED or exists RESERVED_WAITING etc. etc.

Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834

--- Comment #20 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #19)
> Marcel, I do not think we should hide "Anyone seeing this list" for private
> lists.
> 
> First, you are not allowed to select it before sharing it. That can be a bit
> annoying if you know you are going to share it after you created it.
> 
> Then imagine the following workflow:
> - Create a private list
> - Share it
> - Edit the list to let your friend adding items to this list
> - Remove the share
> => When you edit the list you do not see the correct value, "Anyone seeing
> this list" is not displayed whereas it is the value of the field.

I added it because users apparently get confused from options that are not
relevant. See bug 10865 in the past.

We could choose another approach too:
[1] Tell the user that no one else sees the list (when this applies).
[2] Replace Anyone by Owner when we delete the last share. This does not
resolve your first remark.

Any feedback ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880

--- Comment #32 from Oliver Bock  ---
Hi guys,

Now that the implementation changed significantly you might want to adjust the
commit message to reflect that. At least I'd remove the following part: "Thus
the
"falsy" condition has to established with "@return = ()" instead."

Cheers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16976] Authorities searches with double quotes gives ZOOM error 20003

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||m.de.r...@rijksmuseum.nl

--- Comment #11 from Marcel de Rooy  ---
Applying: Bug 16976 - Unit tests
fatal: sha1 information is lacking or useless (t/Search/Zebra/QueryBuilder.t).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #64909|0   |1
is obsolete||
  Attachment #65021|0   |1
is obsolete||

--- Comment #30 from Marcel de Rooy  ---
Created attachment 65037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65037=edit
Bug 18880: Fix authentication fallback for external authentications

A regression in commit cfc484b17 / bug #18314 breaks the local
authentication fallback for all external authentications like LDAP, CAS
and Shibboleth.

The regression itself is a logical error as "@return = (0)" is
considered to be "false" when checked with "unless" (line 1814). That's
wrong as "unless" tests the number of elements in a list. Thus the
"falsy" condition has to established with "@return = ()" instead.

This patch tries to simplify the logic by adding a $passwd_ok and
$check_internal_as_fallback flags to be more verbose and hopefully more
understandable.
The goal here is simply to restore back the same logic as before cfc484b17

Signed-off-by: Lee Jamison 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880

--- Comment #31 from Marcel de Rooy  ---
Created attachment 65038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65038=edit
Bug 18880: [QA Follow-up] Finishing touch

Do not fill @return if retval == -1 for LDAP (see cfc484b17).
No need to call store after an DBIx update. Rearranged the if statement.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/