[Koha-bugs] [Bug 19040] Refactor C4::Biblio::GetMarcBiblio

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040

--- Comment #1 from M. Tompsett  ---
Created attachment 65531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65531=edit
Bug 19040: Refactor GetMarcBiblio parameters

Change parameters to a hashref.
Test plan to come later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18973] Auto focus the ISBN field

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18973

--- Comment #1 from Father Vlasie  ---
Created attachment 65530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65530=edit
patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691

--- Comment #14 from Aleisha Amohia  ---
There we go, merge conflicts fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #65527|0   |1
is obsolete||

--- Comment #13 from Aleisha Amohia  ---
Created attachment 65529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65529=edit
Bug 12691: Use Koha.Preference in Self-Checkout

For calls to SCOUserJS, SCOUserCSS, OPACUserCSS, AllowSelfCheckReturns,
OpacFavicon, ShowPatronImageInWebBasedSelfCheck, SelfCheckoutByLogin

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer 

https://bugs.koha-community.org/show_bug.cgi?id=12601

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #63903|0   |1
is obsolete||

--- Comment #12 from Aleisha Amohia  ---
Created attachment 65528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65528=edit
Bug 12691: [FOLLOW-UP] Follow-up patch

This patch fixes merge conflicts and fixes the problems in Comment 7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #62993|0   |1
is obsolete||

--- Comment #11 from Aleisha Amohia  ---
Created attachment 65527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65527=edit
Bug 12691: Use Koha.Preference in Self-Checkout

For calls to SCOUserJS, SCOUserCSS, OPACUserCSS, AllowSelfCheckReturns,
OpacFavicon, ShowPatronImageInWebBasedSelfCheck, SelfCheckoutByLogin

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer 

https://bugs.koha-community.org/show_bug.cgi?id=12601

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19037] Circulation and fine rules test tool

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19037

--- Comment #7 from Lari Taskula  ---
Testing this tool requires Bug 18137. It has some Perl dependencies, please see
the patch called "List Mojolicious::Plugin::OpenAPI and JSON::Validator as
dependencies" for versions of dependencies that are confirmed to work. Make
sure to install those versions or otherwise the endpoint (and the tool) may not
work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19037] Circulation and fine rules test tool

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19037

Lari Taskula  changed:

   What|Removed |Added

  Attachment #65525|0   |1
is obsolete||

--- Comment #6 from Lari Taskula  ---
Created attachment 65526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65526=edit
Bug 19037: Issuing rules test tool - GUI for test tool

To test:
1. Go to INTRANET/cgi-bin/koha/admin/smart-rules.pl
2. You should see a button below circulation rules matrix
   "Circulation and fine rules test tool"
3. Click it
4. You should see options for inputting test patron, item and branch
5. Play with the tester and make sure it returns correct issuing rules
   (CircControl and HomeOrHoldingBranch system preferences affects the result)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19037] Circulation and fine rules test tool

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19037

Lari Taskula  changed:

   What|Removed |Added

  Attachment #65524|0   |1
is obsolete||

--- Comment #5 from Lari Taskula  ---
Created attachment 65525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65525=edit
Bug 19037: Issuing rules test tool - GUI for test tool

To test:
1. Go to INTRANET/cgi-bin/koha/admin/smart-rules.pl
2. You should see a button below circulation rules matrix
   "Circulation and fine rules test tool"
3. Click it
4. You should see options for inputting test patron, item and branch
5. Play with the tester and make sure it returns correct issuing rules
   (CircControl and HomeOrHoldingBranch system preferences affects the result)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19037] Circulation and fine rules test tool

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19037

Lari Taskula  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19037] Circulation and fine rules test tool

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19037

--- Comment #3 from Lari Taskula  ---
Created attachment 65523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65523=edit
Bug 19037: Issuing rules test tool - REST API endpoint for effective issuing
rule

To test:
1. prove t/db_dependent/api/v1/issuingrules.t
2. Send GET requests to /api/v1/issuingrules/effective with different
parameters
   as defined in the path's Swagger spec
3. Make sure it returns the correct issuing rules (don't forget that system
prefs
   like CircControl and HomeOrHoldingBranch affects the result)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19037] Circulation and fine rules test tool

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19037

--- Comment #4 from Lari Taskula  ---
Created attachment 65524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65524=edit
KD-2316: Issuing rules test tool - GUI for test tool

To test:
1. Go to INTRANET/cgi-bin/koha/admin/smart-rules.pl
2. You should see a button below circulation rules matrix
   "Circulation and fine rules test tool"
3. Click it
4. You should see options for inputting test patron, item and branch
5. Play with the tester and make sure it returns correct issuing rules
   (CircControl and HomeOrHoldingBranch system preferences affects the result)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19037] Circulation and fine rules test tool

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19037

Lari Taskula  changed:

   What|Removed |Added

 Depends on||18137


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137
[Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to
Mojolicious::Plugin::OpenAPI
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Lari Taskula  changed:

   What|Removed |Added

 Blocks||19037


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19037
[Bug 19037] Circulation and fine rules test tool
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18714] tracklinks.pl redirects failing under https

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18714

Nick Clemens  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #1 from Nick Clemens  ---
This was an error in proxy configuration and not Koha related

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15741] Incorrect rounding in total fines calculations

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15741

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17140

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15741

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19046] New: IntranetCatalogSearchPulldown doesn' t retain last selection

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046

Bug ID: 19046
   Summary: IntranetCatalogSearchPulldown doesn't retain last
selection
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

On the OPAC if you have the pulldown enabled and perform a 'Title' search, this
selection carries over. On the staff client the default is always 'Keyword'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

--- Comment #13 from Marc Véron  ---
Independently of the discussion above: Typo in C4/Budgets.pm line 224

SELECT SUM(ROUD(ecost_tax_included, 2)) FROM aqorders

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18974] Adding further selenium tests

2017-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974

--- Comment #4 from Alex Buckley  ---
Created attachment 65522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65522=edit
Bug 18974 - Selenium test for purchase workflow

This test covers the creation of purchase suggestion in the OPAC,
creation of vendor, basket and the creation of the order from the
suggested item

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/