date:20170820

[Koha-bugs] [Bug 19159] SPAM

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19159

Katrin Fischer  changed:

   What|Removed |Added

Summary|cc  |SPAM
 CC||katrin.fisc...@bsz-bw.de
 Resolution|--- |INVALID
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19159] New: cc

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19159

Bug ID: 19159
   Summary: cc
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: About
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: w4hy0...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 66262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66262=edit
cc

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

--- Comment #52 from Srdjan Jankovic  ---
Katrin is correct. And we can make an even stronger statement:
It does not show correct charges per item in general - does not take renewals
in account.

In that spirit, I've added a small follow-up to update Fines & Charges tab as
well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

--- Comment #51 from Srdjan Jankovic  ---
Created attachment 66261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66261=edit
Bug 14803 follow-up: outstanding-fees-amount is a class, not id

Multiple outstanding-fees-amount displays on the page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #11 from Aleisha Amohia  ---
Patch did not apply:

$ git bz apply 18789
Bug 18789 - Send a Koha::Patron object to the templates

64211 - Bug 18789: Send Koha::Patron object to the templates
64212 - Bug 18789: Pass a Koha::Patron object from returns.pl
64213 - Bug 18789: Use Koha::Patron->image from the templates
64214 - Bug 18789: add tests for is_adult and is_child
64215 - Bug 18789: Use Koha::Patron->is_child where needed
64216 - Bug 18789: Use Koha::Patron->is_adult where needed
64218 - Bug 18789: Remove useless IS_ADULT variable
64219 - Bug 18789: Remove adultborrower from the pay* scripts
64221 - Bug 18789: Update other occurences where is->child should be used
64229 - Bug 18789: (follow-up)Send Koha::Patron object to the templates

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 18789: Send Koha::Patron object to the templates
fatal: sha1 information is lacking or useless (acqui/booksellers.pl).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 18789: Send Koha::Patron object to the templates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19126] Fix Members.t with IndependentBranches set

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19126

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #66064|0   |1
is obsolete||

--- Comment #2 from Aleisha Amohia  ---
Created attachment 66259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66259=edit
[SIGNED-OFF] Bug 19126: Fix Members.t with IndependentBranches set

If you enabled that pref, Members.t fails with:
t/db_dependent/Members.t .. 63/63 # Looks like you failed 15 tests of 63.

The first one is:
t/db_dependent/Members.t .. 32/63
   Failed test 'Staff patron not deleted from list'
   at t/db_dependent/Members.t line 304.

Bottle neck is GetBorrowersToExpunge. The results of that sub depend on the
state of this preference.
Trivially fixing it here by disabling the pref before the first call.

Test plan:
[1] Do not apply this patch yet. Enable IndependentBranches.
[2] Run Members.t and observe that it fails.
[3] Apply this patch. And run Members.t again. It should pass now.

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19126] Fix Members.t with IndependentBranches set

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19126

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19129] Clean up templates for organisation patrons in staff

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19129

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #66156|0   |1
is obsolete||

--- Comment #7 from Aleisha Amohia  ---
Created attachment 66258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66258=edit
[SIGNED-OFF] Bug 19129 - Follow-up - Add changes to patron duplicate warning

Adds logic from the previous fix to the brief patron summary
shown when checking a possible patron duplicate.

Bonus: Also fixes missing patron category description there.

To Test:
- Add 2 patrons
- Add a patron with the same surname and firstname as an
  existing patron in order to trigger the duplicate message
- Click "View existing patron"
- Verify display is correct when existing patron is
  - an organisation
  - not an organisation
- Verify that the patron category description shows

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19129] Clean up templates for organisation patrons in staff

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19129

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19129] Clean up templates for organisation patrons in staff

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19129

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #66155|0   |1
is obsolete||

--- Comment #6 from Aleisha Amohia  ---
Created attachment 66257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66257=edit
[SIGNED-OFF] Bug 19129 - Clean up Details tab for Organisation patrons

Problem: A patron category "I" would cause display problems
on the details in the intranet. This is because the templates
confused patron category "I" with patron type "I" (organisation).

Patch:
- Cleans up variable confusion between categorycode and
  categorytype.
- The template contained code to change the labels below
  the address to 'Organisational phone:" etc., I have removed
  this part as it does not match the edit form anymore.
- Initials, date of birth and gender are still hidden for
  organisation - matching the edit form.

Bonus:
- The patron category description was missing on the
  right and left side of the details tab. Now it displays.
- Fixes some html issues:
  - doubled up class attribute in a tag
  - doubled up 

To test:
- Create 3 patrons
  - patron category code doesn't matter, but category type organisation
  - patron category code 'I', category type NOT organisation
  - patron category code NOT I, category type NOT organisaton
- Check details tab in patron account in staff for all 3
  - Verify patron category description shows correctly
  - Verify information added to the account displays correctly
(phone numbers, emails, ...)

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19134] C4::SMS does not handle drivers with more than two names well

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19134

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #66151|0   |1
is obsolete||

--- Comment #2 from Aleisha Amohia  ---
Created attachment 66256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66256=edit
[SIGNED-OFF] Bug 19134: C4::SMS falils on long driver name

Code in C4::SMS takes the part of the SMS::Send-driver that comes after
SMS::Send and tries to turn it into part of a path to a YAML file
that can contain additional parameters to SMS::Send. The current
code works for e.g. SMS::Send::A::B, but if there is one or more
extra names, it fails to turn :: into /. So we have:
SMS::Send::A::B-> SMS/Send/A/B
SMS::Send::A::B::C -> SMS/Send/A/B::C
This patch makes sure all occurrences of :: are turned into /, by
adding a "g" modifier at the end of the regex.

Testing:
Testing this preperly would take a whole lot of setup for a very
small change. I would suggest that the following two oneliners
are enough to demonstrate that the change makes sense:
$ perl -e '$x = "a::b::c"; $x =~ s|::|/|; print $x, "\n";'
$ perl -e '$x = "a::b::c"; $x =~ s|::|/|g; print $x, "\n";'

So:
- Check that the output of these oneliners make sense
- Check that the patch changes the code in a similar way to the
  change from the first oneliner to the second.

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19134] C4::SMS does not handle drivers with more than two names well

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19134

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15326] Add CMS feature

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

--- Comment #20 from Aleisha Amohia  ---
Created attachment 66255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66255=edit
Bug 15326: [FOLLOW-UP] Fixing library field in form, opac publishing

Fixes issues from Comment 19, please test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15326] Add CMS feature

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18046] Problem with redirect on logout with CAS

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046

--- Comment #4 from Chris Cormack  ---
Created attachment 66254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66254=edit
Bug 18046 CAS logout infinite redirect

To test (You need a CAS server and CAS configured in Koha)

1/ Login using CAS in Koha
2/ Logout in Koha
3/ Notice you get redirected again and again
4/ Apply patch
5/ Login with CAS, then logout
6/ Notice logout works, but no longer infinitely redirected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18046] Problem with redirect on logout with CAS

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046

Chris Cormack  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #12 from Aleisha Amohia  ---
Forgot to change status - this is ready to test

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #65871|0   |1
is obsolete||

--- Comment #11 from Aleisha Amohia  ---
Created attachment 66253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66253=edit
Bug 4461: [FOLLOW-UP] Problem Report feature

This patch:
 - uses a pull down menu to switch the recipient instead of tabs
 - if the library has no email or the administrator has no email, this
 error message has been moved to be down by the Submit button
 - includes use of branchreplyto and ReplytoDefault for branch email
 - disables use of the feature if the user is not logged in
 - adds a syspref to hide or show the feature
 - provides support for if JS is disabled

Additional testing:
 - using the message_queue table, check that the correct recipient
 receives a problem report when switching in the drop down menu
 - check appropriate error message shows next to the submit button if an
 email is not provided. this should dynamically change as you select a
 different recipient from the drop down menu
 - check that when the library is the recipient, the feature sends the
 report to the branchreplyto, then the ReplytoDefault, then the branch
 email in that priority order
 - log out of the OPAC and confirm that you can't submit a report
 without logging in. the submit button should be disabled
 - disable the OPACReportProblem syspref. the Report a Problem link in
 the footer should be gone. if you force the URL
 (/cgi-bin/koha/opac-reportproblem.pl) the form should be hidden and
 replaced with an error message.
 - disable JS in your browser. confirm that you are still able to send
 problem reports to library and administrator. remove the administrator
 email address. confirm the error message shows next to the submit
 button and that clicking the submit button returns an error. check in
 the message_queue that the email was never sent.

After this feature is passed:
 - i would like to add a staff-side feature where staff can see the
 problem reports and mark them as 'read'. i'll work on that once this
 gets through :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691

--- Comment #17 from Aleisha Amohia  ---
Created attachment 66252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66252=edit
Bug 12691: [FOLLOW-UP] Missing bracket

Patch adds bracket to template file (Comment 16)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093

--- Comment #12 from Aleisha Amohia  ---
patches apply without conflicts, ready to test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896

--- Comment #7 from Aleisha Amohia  ---
patches apply without conflict - ready to test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #64271|0   |1
is obsolete||

--- Comment #6 from Aleisha Amohia  ---
Created attachment 66251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66251=edit
Bug 17896: [FOLLOW-UP] Make opac-readingrecord.pl use module

Also fix template to use Koha.Preference instead of passing it from the
pl file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8628] Add digital signs to the OPAC

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628

--- Comment #21 from Aleisha Amohia  ---
Sorry about all that - looks like the patches apply without conflicts now.
Ready to test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8628] Add digital signs to the OPAC

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #58604|0   |1
is obsolete||

--- Comment #18 from Aleisha Amohia  ---
Created attachment 66248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66248=edit
Bug 8628: Add digital signs to the OPAC

See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details.

To test:
1. Apply this patch and the database updates patch
2. Run updatedatabase.pl
3. In staff client, go to Tools/Additional Tools/Digital signs
4. You should be warned about OPACDigitalSigns not being enabled, you can
ignore
   this for now.
5. Add a new sign by clicking the "+ New sign" button
6. Enter a name and optionally numbers for automatic page turing
7. Your new sign should appear in the Signs list
8. Add a new stream by clicking the "+ New stream" button
9. Unless you already have reports in the report group with code SIG, you
should
   be warned that there are no reports in the group with code SIG and given a
   link for creating a new report. Follow the link and create a new report with
   report group code SIG. En example SQL command for the report could be:

   SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY)
10. Go back to the "new stream" page, and reload. You should no longer see a
warning message, and your newly created report should appear in the list of
reports.
11. Select the report and click Submit. Your newly created stream should now
appear in the list of streams.
12. In the list of signs, press "edit streams" for the sign you previously
created.
13. Choose a stream to attach and click Submit. Your sign is now ready for
OPAC.
14. In OPAC, visit /cgi-bin/koha/opac-signs.pl
15. You should be told that Digital signs are not enabled. Enable with new
system preference OPACDigitalSigns and reload the page.
15. You should see a list of available signs, click on a sign that you wish to
display.
16. You should now see a list of all books matching the SQL query in the report
that you attached to your stream.
17. If you have OPACLocalCoverImages enabled, all books with local covers
attached should be presented using this cover.
If no local cover is available and the book has a ISBN with a cover in
openlibrary.org, the cover image from openlibrary.org should be shown.
If all of the above fails, a cover matching the theme of the page should be
seen, showing the book title and author.
18. Clicking a book should bring you to a detailed view of the book where you
can see the books availability. You should also see the two next books and
the two previous books in the stream (unless you're at the beginning or end
of the stream)
19. Swiping (if no touch screen, click and hold left mouse button and drag)
left/right should bring you to next/previous book. Clicking on the
next/previous books (right/left of the active one) should bring you to the
detailed view of the clicked book.
20. Leaving the page idle (i.e no user interaction) for the amount of time
specified in step 6. should result in the page automatically switching to
the next book in the stream.

Sponsored-by: Regionbibliotek Halland / County library of Halland
Signed-off-by: Chris Cormack 

In theory this could/should be rewritten to use Koha::Schema instead
of direct sql, but this predates the switch, so would be unfair to
reject it on that basis (plus until we fix the speed straight sql is
way faster anyway)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8628] Add digital signs to the OPAC

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #64249|0   |1
is obsolete||

--- Comment #19 from Aleisha Amohia  ---
Created attachment 66249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66249=edit
Bug 8628: [FOLLOW-UP] More fixes

This patch fixes qa tool issues, problems in comment 13, merge
conflicts, other issues with patches

Same test plan applies

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8628] Add digital signs to the OPAC

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #66246|0   |1
is obsolete||

--- Comment #20 from Aleisha Amohia  ---
Created attachment 66250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66250=edit
Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC

This patch rewrites all modules from the original patch to be object
oriented.

Follows above test plan.

Sponsored-by: Region Halland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8628] Add digital signs to the OPAC

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #58603|0   |1
is obsolete||

--- Comment #17 from Aleisha Amohia  ---
Created attachment 66247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66247=edit
Bug 8628: Add digital signs to the OPAC, dbchanges

Database changes for bug 8628

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8628] Add digital signs to the OPAC

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8628] Add digital signs to the OPAC

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #62338|0   |1
is obsolete||

--- Comment #16 from Aleisha Amohia  ---
Created attachment 66246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66246=edit
Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC

This patch rewrites all modules from the original patch to be object
oriented.

Follows above test plan.

Sponsored-by: Region Halland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #62983|0   |1
is obsolete||

--- Comment #11 from Aleisha Amohia  ---
Created attachment 66245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66245=edit
Bug 2093 [Compiled CSS] Add OPAC dashboard for logged-in users

This patch contains the CSS file compiled from LESS.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19156] SPAM

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19156

Jonathan Druart  changed:

   What|Removed |Added

  Group|Koha security   |
 QA Contact||testo...@bugs.koha-communit
   ||y.org
Product|Koha security   |Koha
 Resolution|--- |INVALID
Summary|1   |SPAM
 Status|NEW |RESOLVED
   Assignee|ch...@bigballofwax.co.nz|koha-b...@lists.koha-commun
   ||ity.org
  Component|Koha|Architecture, internals,
   ||and plumbing

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19138] SPAM

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19138

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|koha-b...@lists.koha-commun
   ||ity.org
Product|Koha security   |Koha
 QA Contact||testo...@bugs.koha-communit
   ||y.org
  Component|Koha|Architecture, internals,
   ||and plumbing
  Group|Koha security   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19142] SPAM

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19142

Jonathan Druart  changed:

   What|Removed |Added

Product|Koha security   |Koha
  Component|Koha|Architecture, internals,
   ||and plumbing
  Group|Koha security   |
 QA Contact||testo...@bugs.koha-communit
   ||y.org
   Assignee|ch...@bigballofwax.co.nz|koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19148] SPAM

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19148

Jonathan Druart  changed:

   What|Removed |Added

Product|Koha security   |Koha
   Assignee|ch...@bigballofwax.co.nz|koha-b...@lists.koha-commun
   ||ity.org
 Resolution|--- |INVALID
 Status|NEW |RESOLVED
 QA Contact||testo...@bugs.koha-communit
   ||y.org
  Group|Koha security   |
Summary|-   |SPAM
  Component|Koha|Architecture, internals,
   ||and plumbing

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19143] SPAM

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19143

Jonathan Druart  changed:

   What|Removed |Added

Product|Koha security   |Koha
  Component|Koha|Architecture, internals,
   ||and plumbing
 Status|NEW |RESOLVED
  Group|Koha security   |
 Resolution|--- |INVALID
Summary|http://sman1palangkaraya.sc |SPAM
   |h.id/   |
 QA Contact||testo...@bugs.koha-communit
   ||y.org
   Assignee|ch...@bigballofwax.co.nz|koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused checkin for data corruption

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #33 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18927] koha-rebuild-zebra -f -v koha

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Severity|enhancement |critical

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19155] zhul

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19155

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19155] SPAM

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19155

Katrin Fischer  changed:

   What|Removed |Added

Summary|zhul|SPAM
 Resolution|--- |INVALID
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19154] SPAM

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19154

Katrin Fischer  changed:

   What|Removed |Added

Summary|Koha|SPAM
 Resolution|--- |INVALID
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19154] Koha

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19154

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19153] SPAM

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19153

Katrin Fischer  changed:

   What|Removed |Added

Summary|Koha|SPAM
 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19153] Koha

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19153

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #36 from Josef Moravec  ---
Created attachment 66240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66240=edit
Bug 18606: Add test to t/db_dependent/Koha/Items.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #32 from Josef Moravec  ---
Created attachment 66236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66236=edit
Bug 18606: Get rid of isItemInThisCollection

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #37 from Josef Moravec  ---
Created attachment 66241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66241=edit
Bug 18606: Unify handling of success/error messages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #30 from Josef Moravec  ---
Created attachment 66234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66234=edit
Bug 18606: Get rid of RemoveItemFromCollection

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #34 from Josef Moravec  ---
Created attachment 66238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66238=edit
Bug 18606: Remove lefover of C4::RotatingCollections

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #28 from Josef Moravec  ---
Created attachment 66232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66232=edit
Bug 18606: Get rid of GetCollectionItemBranches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #27 from Josef Moravec  ---
Created attachment 66231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66231=edit
Bug 18606: Get rid of GetItemsInCollection

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #33 from Josef Moravec  ---
Created attachment 66237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66237=edit
Bug 18606: Get rid of isItemInAnyCollection

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #25 from Josef Moravec  ---
Created attachment 66229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66229=edit
Bug 18606: Database changes - Add foreign keys to collections_tracking

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #26 from Josef Moravec  ---
Created attachment 66230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66230=edit
Bug 18606: Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #35 from Josef Moravec  ---
Created attachment 66239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66239=edit
Bug 18606: Rework tests for rotating collections

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #29 from Josef Moravec  ---
Created attachment 66233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66233=edit
Bug 18606: Get rid of AddItemToCollection

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #31 from Josef Moravec  ---
Created attachment 66235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66235=edit
Bug 18606: Get rid of TransferCollection

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #24 from Josef Moravec  ---
Created attachment 66228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66228=edit
Bug 18606: Easy ones - CRUD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

Josef Moravec  changed:

   What|Removed |Added

  Attachment #63508|0   |1
is obsolete||
  Attachment #63509|0   |1
is obsolete||
  Attachment #63510|0   |1
is obsolete||
  Attachment #63511|0   |1
is obsolete||
  Attachment #63512|0   |1
is obsolete||
  Attachment #63513|0   |1
is obsolete||
  Attachment #63514|0   |1
is obsolete||
  Attachment #63515|0   |1
is obsolete||
  Attachment #63516|0   |1
is obsolete||
  Attachment #63517|0   |1
is obsolete||
  Attachment #63518|0   |1
is obsolete||
  Attachment #63519|0   |1
is obsolete||
  Attachment #63520|0   |1
is obsolete||
  Attachment #63521|0   |1
is obsolete||
  Attachment #63522|0   |1
is obsolete||
  Attachment #63523|0   |1
is obsolete||
  Attachment #63524|0   |1
is obsolete||
  Attachment #63525|0   |1
is obsolete||
  Attachment #63526|0   |1
is obsolete||
  Attachment #63527|0   |1
is obsolete||
  Attachment #63528|0   |1
is obsolete||

--- Comment #23 from Josef Moravec  ---
Created attachment 66227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66227=edit
Bug 18606: Add RotationCollections object classes

Test plan:
1) Apply the patch
2) Update database
3) Go to tools -> Rotating collections and play with trying to break it:
3a) Add some collections
3b) Edit them
3c) Add some items to collections
3d) Remove some items
3e) Transfer some collections
3f) Try to remove collection without items
3g) Try to remove collection with items
4) Go to returns and:
4a) Try to return item from untransferred collection
4b) Try to return item from transferred collection
5) prove t/db_dependent/Koha/RotatingCollections.t
t/db_dependent/Koha/Items.t t/db_dependent/Circulation.t
t/db_dependent/Circulation/Returns.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14316] Clarify meaning of record number in Batch record deletion tool

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14316

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14316] Clarify meaning of record number in Batch record deletion tool

2017-08-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14316

Marc Véron  changed:

   What|Removed |Added

  Attachment #66217|0   |1
is obsolete||

--- Comment #11 from Marc Véron  ---
Created attachment 66226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66226=edit
Bug 14316: Clarify meaning of record number in Batch record modification tool

Same change as the first patch, but for the batch record
modification tool.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

64 matches

Mail list logo