[Koha-bugs] [Bug 19168] New: Non-Debian koha-httpd.conf prevents oai.pl from working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19168

Bug ID: 19168
   Summary: Non-Debian koha-httpd.conf prevents oai.pl from
working
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

The following block in koha-httpd.conf prevents oai.pl from working in a web
browser:

# Secure internal stuff
   
  Order deny,allow
  Deny from all
   

You get a 403 for /opac-tmpl/xslt/OAI.xslt which prevents the HTML from
displaying.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #112 from M. Tompsett  ---
back up database
git bz apply 19040
git bz apply 14385
sudo koha-shell -c bash kohadev
./installer/data/misc/updatedatabase.pl
-- this proves the atomic update

drop the database
create an empty one
run a web install
-- this proves the sysprefs changes

restore database
./installer/data/misc/updatedatabase.pl
-- This gives non-fresh install DB to actually test on.

log into the staff client
go to the OPAC system preferences (Home -> Koha administration -> Global System
Preferences -> OPAC)
scroll down to the policy section
-- there should be a new OpacHiddenItemsExpceptions system preference setting.
Set a value for the OpacHiddenItemsExceptions, and click save.
-- it should save.
Click 'Home' in the bread crumbs.
Navigate back to the OPAC system preferences
-- the value you set should be saved correctly.
-- This confirms the opac.pref file

sudo koha-shell -c bash kohadev
prove t/db_dependent/Authorities/Merge.t
-- This proves the C4/AuthoritiesMarc.pm change

prove t/db_dependent/HoldsQueue.t
-- This proves the C4/HoldsQueue.pm change

prove t/db_dependent/ILSDI_Services.t
-- This proves the C4/ILSDI/Services.pm change

prove t/db_dependent/Reserves.t t/db_dependent/Items.t
-- This prove the C4/Items.pm changes

prove t/db_dependent/Labels/t_Label.t
-- This proves the C4/Labels/Label.pm changes

prove t/db_dependent/Record/marcrecord2csv.t
-- This proves the C4/Record.pm changes

prove t/db_dependent/Serials.t
-- This proves the C4/Serials.pm change

prove t/db_dependent/ShelfBrowser.t
-- This proves the C4/ShelfBrowser.pm change

prove t/db_dependent/Koha/BiblioUtils.t
-- This proves the Koha/Biblio.pm change

prove t/db_dependent/Koha/BiblioUtils/Iterator.t
-- This proves the Koha/BiblioUtils/Iterator.pm change

prove t/db_dependent/Exporter/Record.t
-- This proves the Koha/Exporter/Record.pm changes

prove t/db_dependent/OAI/Server.t
-- This proves the Koha/OAI/Server/Repository.pm change

prove `git diff origin/master | grep ^diff | grep [.]t$ | cut -f4 -d' ' | sed
-e "s#^..##"`
-- This proves all the test file changes.

./misc/migration_tools/build_oai_sets.pl -i
-- This proves this file change.

prove t/db_dependent/Search.t
-- This triggers searchResults tweaks in this file.

- Catalog any new item in the staff client. I did a new from Z39.50.
-- This will trigger any remaining EmbedItemsInMarcBiblio
   calls in the staff client.

1) Make two borrowers, one in a category that should see everything (ie Staff
[S]), and another in a category that should only see certain things (ie Patron
[PT])
2) Add the borrower that can see everything (the Staff) to
OpacHiddenItemsExceptions
3) To the OpacHiddenItems syspref, add an item type (ensure that you have some
records that fall under this type in your library).
4) Log in as the borrower that should only see certain things (Patron)
5) Do a search, filtered to show records which are the item type that you
specified in the OpacHiddenItems syspref.
   -- No records should show for this borrower as this item type is hidden to
them.
6) Log out, and repeat the search
   -- No records should show
7) Log in as the borrower that should see everything (Staff)
8) Do the same search.
   -- There should be results from this search, as this borrower category has
been specified as an exception to the hidden items

prove -v t/db_dependent/Items.t
C4::Biblio changes (EmbedItemsInMarcBiblio) tested
C4::Items changes (GetHiddentItemnumbers) tested
the Items.t is tested itself too.

perldoc C4::Items
/PERLDOC
-- finds changes

installer/data/mysql/atomicupdate/bug_14385-add_OpacHiddenItemsExceptions_syspref.sql
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
-- run an upgrade
-- log in to staff client
-- home -> koha administration -> global system preferences -> opac
-- should be an added OpacHiddenItemsExceptions under OpacHiddenItems
   in the Policy section.
-- should be able to save various values.

installer/data/mysql/sysprefs.sql
-- drop the db
-- create the db
-- fresh install
-- log in to staff client
-- home -> koha administration -> global system preferences -> opac
-- should be an added OpacHiddenItemsExceptions under OpacHiddenItems
   in the Policy section.
-- should be able to save various values.

opac/opac-search.pl
-- set the OpacHiddenItems to "itype: [BK]"
-- set the OpacHiddenItemsExceptions to "S"
-- make sure to catalogue at least two books, since you dropped everything.
-- Adding from Z39.50 is easiest.
-- do a full reindex
-- in the OPAC, search for "itype:BK"
-- there should be nothing found.
-- log in as the superlibrarian (which you probably set to S for staff)
-- in the OPAC, search for "itype:BK"
-- there should be two entries
-- change OpacHiddenItemsExceptions to "PT"
   (because your superlibrarian is probably S and not PT)
-- in the OPAC, search for "itype:BK"
-- there should be nothing found.

[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

--- Comment #69 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #68)
> I suggest you discuss tuits in koha-devel. 

Good idea, Tomás. While I don't have the tuits, maybe someone else would find
it interesting.

> BTW, Koha uses Starman listening on a Unix socket and it sets apache to use
> that.

According to
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/plack/plackup.sh;h=2c7f5990852107408c10b096c24cdf6df8277abc;hb=HEAD,
it appears to be using TCP sockets to me. 

Ah, you must be meaning
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=debian/scripts/koha-plack;h=5e1fc9cf65534628514f1b37db7192af7076c26d;hb=HEAD.
That's cool.

> On Debian.
> We still didn't find someone to make it work on OpenSuSE.

I don't 100% understand what you  mean here. I don't think the Koha community
ever tries to make Koha work outside of Debian (and Ubuntu). If it did, I think
the debian/scripts folder would look a lot different. I certainly don't recall
anyone speaking about openSUSE or any other non-Debian based distro. (I figure
I'll just end up writing my own service when we get around to implementing
Plack anyway.)

In this case, are you referring to this particular service script or packaging
in general?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14835] Add custom navbar to modules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14835

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
  Attachment #66402|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14835] Add custom navbar to modules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14835

--- Comment #1 from M. Tompsett  ---
Created attachment 66402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66402=edit
Bug 14835: Fix ILSDI_Services test when clubs with branch exist

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #111 from M. Tompsett  ---
Created attachment 66403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66403=edit
Bug 14385: Fix ILSDI_Services test when clubs with branch exist

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

   Patch complexity|Medium patch|Large patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #110 from M. Tompsett  ---
Created attachment 66401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66401=edit
Bug 14385: Fix breaking issues constraint in ITerator test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

--- Comment #68 from Tomás Cohen Arazi  ---
I suggest you discuss tuits in koha-devel. 
BTW, Koha uses Starman listening on a Unix socket and it sets apache to use
that.
On Debian.
We still didn't find someone to make it work on OpenSuSE.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11251] Be able to configure HTML Opac preferences per library

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11251

verolencinas  changed:

   What|Removed |Added

 CC||verolenci...@yahoo.com.ar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

--- Comment #52 from David Cook  ---
Just wanted to cheer for this one some more... looking forward to its addition
to Koha!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

--- Comment #67 from David Cook  ---
(In reply to Srdjan Jankovic from comment #66)
> That was exactly my point with Context. There should be no references to
> *anything* external (db, cache etc handles) outside Context. Now because we
> are still in this CGI frame of mind, we have all this horrible singletons.
> Once we are able to instantiate contexts and keep them in app containers,
> and pass them to request handlers we will be safe.

Agreed!

Even if these patches don't go in, I figure it's worthwhile getting rid of the
singletons even for the sake of testing and flexibility. 

(On an unrelated note, I just noticed Starman can listen on Unix sockets, and I
recall Nginx being able to reverse proxy to Unix sockets. Apparently Apache
2.4.7+ can as well. I wonder what kind of performance boost that would give.
Actually, say the OPAC was separate but still server-side and using an API,
calls to a Koha API over a Unix socket would probably be rather fast. I wonder
if you could have a single Koha API process which needs the most resources and
then have separate smaller processes for the OPAC (and perhaps staff client).
Or not even have an OPAC and just let other services access the API. Although I
suppose as a project we'd want to have a default OPAC app for an all-in-one
solution. I suppose the architecture depends on the scale needed for Koha too.
Probably easier to scale up by having lighter clients connecting to APIs and
have it all service based. But then also more complicated to set up and
maintain. Actually, I was also pondering having a single persistent Koha API
process and then serving the OPAC (and staff client) via CGI. If they're
lightweight and most of the heavy lifting is done by the API, maybe that would
be a reasonable way to have a large multitenant system. But maybe that just
sounds better in theory than it would be in practice. For things like record
uploads, that's probably not feasible and would just involve double-handling
and double-parsing. Oh well. I'll stop rambling now...)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

--- Comment #7 from Nick Clemens  ---
Created attachment 66400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66400=edit
Bug 17374 - QA Followup

Skip invlid field names
Add fields to sidebar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

Nick Clemens  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19167] Add is_from_today to Checkouts, so we can use it in TT notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19167

Liz Rea  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15283

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283

Liz Rea  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19167

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19167] New: Add is_from_today to Checkouts, so we can use it in TT notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19167

Bug ID: 19167
   Summary: Add is_from_today to Checkouts, so we can use it in TT
notices
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: l...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

Since the rewrites of the quickslips to TT are hung up, having this wee sub in
Checkouts (rescued from 15283) will help people who want to make up a quickslip
using TT syntax before the default one is ready.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093

--- Comment #14 from Aleisha Amohia  ---
(In reply to Hugo Agud from comment #13)
> patch tested and it works fine!
> 
> but test fail
> 
> Test Summary Report
> ---
> t/Creators.t  (Wstat: 6400 Tests: 39 Failed: 0)
>   Non-zero exit status: 25
>   Parse errors: Bad plan.  You planned 41 tests but ran 39.
> Files=98, Tests=7437, 238 wallclock secs ( 1.18 usr  0.18 sys + 217.40 cusr 
> 4.47 csys = 223.23 CPU)
> Result: FAIL

Hi Hugo

all tests pass before and after this patch for me. 

aleisha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149

Nick Clemens  changed:

   What|Removed |Added

  Attachment #63455|0   |1
is obsolete||

--- Comment #7 from Nick Clemens  ---
Created attachment 66399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66399=edit
Bug 16149 - Unit tests

To test:
prove -v t/db_dependent/Reports/Guided.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149

Nick Clemens  changed:

   What|Removed |Added

  Attachment #63454|0   |1
is obsolete||

--- Comment #6 from Nick Clemens  ---
Created attachment 66398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66398=edit
Bug 16149 - Generate and send custom notices based on report output

Ths patch add an EmailReport function to C4::Reports::Guided

It accepts a notice (module, code, branch) and a report and attempts to
email notices to patron, generating content using report content.

Notice must be in template toolkit syntax, only columns in report are
available for notice.

To test:
1 - Specify various options
2 - Ensure errors are returned if options are incomplete or incorrect
3 - Pass a report containing 'from' and 'email' and 'borrowernumber'
columns and ensure message queue populated as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

--- Comment #100 from Tomás Cohen Arazi  ---
(In reply to Martin Renvoize from comment #99)
> Comment on attachment 65107 [details] [review]
> Bug 18137: Migrate from Swagger2 to Mojolicious::Plugin::OpenAPI
> 
> Review of attachment 65107 [details] [review]:
> -
> 
> ::: Koha/REST/V1/Auth.pm
> @@ +57,5 @@
> > +json => { error => 'Something went wrong, check the logs.' 
> > }
> > +);
> > +}
> > +if ($_->isa('Koha::Exceptions::UnderMaintenance')) {
> > +return $c->render(status => 503, json => { error => $_->error 
> > });
> 
> Should these calls to render not all be 'openapi => { error => $_->error }`
> as aposed to `json => { error => $_->error }`.. else none of these responses
> are getting validated.

That's because the auth check is done using ->under, and as the check itself is
calling ->render, it is breaking the dispatch chain (not breaking like in 'stop
working' but like short-circuiting to another way of returning the error.
Clarifying to avoid possible idiomatic issues).

I think we should leave it as-is and deal with this problem on a separate bug,
or leave it. Because it could involve a big re-engineering to make the check
let the chain continue while propagating the exception.

I can't even imagine how to do it without adding irrelevant checks and
repetitive code to controller classes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #9 from Liz Rea  ---
Also we really need bits of this, specifically "is_from_today" in Checkout.pm
independent of this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10260] way to enter a note when writing off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10260

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

--- Comment #1 from Lisette  ---
Still valid? It does let you put a note in.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2786] Allow waiting holds to be diverted to different branch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2786

--- Comment #4 from Lisette  ---
This would be great. We have 7 branches and still in 16.05 often have this
problem, especially with new items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9228] log of messages left

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9228

--- Comment #2 from Lisette  ---
Is this still valid? It does show up in the patron modification log on my
system, at least if they were deleted in the last 3 months.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18206] REST API: Default exception handling

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206

--- Comment #7 from Tomás Cohen Arazi  ---
Lari, do you think we could call the method 'rethrow'?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19040] Change prototype of C4::Biblio::GetMarcBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040

M. Tompsett  changed:

   What|Removed |Added

Summary|Refactor|Change prototype of
   |C4::Biblio::GetMarcBiblio   |C4::Biblio::GetMarcBiblio

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #91 from Tomás Cohen Arazi  ---
This patch set is actually pretty simple and is not changing any behaviour
(besides the side effect of recording the account offsets on each operation
that involves charges/payments).

It passes the usual QA tests, and opens the door for really cool and missing
features in Koha (see the blocked bugs and it becomes obvious).

My only observation would be that the 'type' column values should somehow be
better controlled (possibly an ENUM, or better a FK to a separate table). This
would set a clearer path for eventual added flexibility and avoiding
migration/upgrades nightmares.

Congrats Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65652|0   |1
is obsolete||

--- Comment #90 from Tomás Cohen Arazi  ---
Created attachment 66397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66397=edit
Bug 14826 [QA Followup] - Only use plural modules in other modules

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65650|0   |1
is obsolete||

--- Comment #88 from Tomás Cohen Arazi  ---
Created attachment 66395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66395=edit
Bug 14826 - Update existing schema files

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65651|0   |1
is obsolete||

--- Comment #89 from Tomás Cohen Arazi  ---
Created attachment 66396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66396=edit
Bug 14826 [QA Followup] - Fix minor issues with unit tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65648|0   |1
is obsolete||

--- Comment #86 from Tomás Cohen Arazi  ---
Created attachment 66393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66393=edit
Bug 14826 - Add offset for rental fees

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65649|0   |1
is obsolete||

--- Comment #87 from Tomás Cohen Arazi  ---
Created attachment 66394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66394=edit
Bug 14826 - Add unit tests for _FixAccountForLostAndReturned and
_FixOverduesOnReturn

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65647|0   |1
is obsolete||

--- Comment #85 from Tomás Cohen Arazi  ---
Created attachment 66392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66392=edit
Bug 14826 - Add new offset table schema file

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65646|0   |1
is obsolete||

--- Comment #84 from Tomás Cohen Arazi  ---
Created attachment 66391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66391=edit
Bug 14826 - Remove old offset table schema file

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65645|0   |1
is obsolete||

--- Comment #83 from Tomás Cohen Arazi  ---
Created attachment 66390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66390=edit
Bug 14826 - Unit Tests

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65644|0   |1
is obsolete||

--- Comment #82 from Tomás Cohen Arazi  ---
Created attachment 66389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66389=edit
Bug 14826 - Resurrect account offsets table

The account offsets table should be used to track increments and
decrements of fines via payments and credits, as well as fine accruals.
It should be able to match fees to payments and visa versa, so we can
know which fee was paid by a given payment, and which payments applied
to a given fee.

Test Plan:
1) Apply this patch
2) Run updatedatabase
3) Note the table accountoffsets has been renamed to account_offsets
4) Ensure fine generation creates offsets
5) Ensure creating a manual invoice creates an offset
6) Ensure a lost item charge creates an offset
7) Ensure Reverse Payment creates an offset
8) Ensure a payment creates an offset
9) Ensure a payment for multiple fees creates an offset for each
10) Ensure writeoffs create offsets

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65643|0   |1
is obsolete||

--- Comment #81 from Tomás Cohen Arazi  ---
Created attachment 66388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66388=edit
Bug 14826 - Add Koha modules for offsets

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65642|0   |1
is obsolete||

--- Comment #80 from Tomás Cohen Arazi  ---
Created attachment 66387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66387=edit
Bug 14826 - Update database

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814

John Sterbenz  changed:

   What|Removed |Added

 CC||jster...@umich.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don' t work as expected

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032

John Sterbenz  changed:

   What|Removed |Added

 CC||jster...@umich.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15239] Add multiple items fail on barcode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15239

Ruben Norori  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #11 from Ruben Norori  ---
Hi Tomás.

Thank for your suggestion, try the long way because I didn't know another
solution, but I will try your recomendation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19080] Handle non existing patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19080

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19080] Handle non existing patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19080

--- Comment #11 from Julian Maurice  ---
Created attachment 66384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66384=edit
Bug 19080: Handle non-existing patrons gratefully

This is a recurrent bug we have over the last years. When a script is
called with non-existent borrowernumber it will crashes.
We need to handle this gracefully instead of letting the script crashes.

On bug 18403 a new subroutine is added to the codebase
(output_and_exit_if_error) to handle this kind of errors correctly.
Since it is not pushed yet, I propose to just redirect to a script that
handle it correctly (circulation.pl) instead of adding this message to
all these scripts.

Test plan:
Hit different scripts from the members module and pass a non-existent
borrowernumber.
You must be redirected to circulation.pl with a friendly message.

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19080] Handle non existing patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19080

--- Comment #12 from Julian Maurice  ---
Created attachment 66385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66385=edit
Bug 19080: Fix member vs borrowernumber in delmember

Signed-off-by: Josef Moravec 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19080] Handle non existing patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19080

Julian Maurice  changed:

   What|Removed |Added

  Attachment #66383|0   |1
is obsolete||

--- Comment #13 from Julian Maurice  ---
Created attachment 66386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66386=edit
Bug 19080: Fix perlcritic in routing-lists.pl

Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19080] Handle non existing patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19080

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19080] Handle non existing patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19080

--- Comment #10 from Jonathan Druart  
---
(In reply to Julian Maurice from comment #8)
> QA comment:
> 
> 1) $ perlcritic members/routing-lists.pl
> Variable declared in conditional statement at line 51, column 1.  Declare
> variables outside of the condition.  (Severity: 5)
> 
> This error is not detected by koha-qa, I'm not sure why.

Fixed, thanks! (not sure koha-qa does not catch it)

> 2) If borrowernumber is 0, empty or not defined, the error message is not
> displayed in circ/circulation.pl

Yes it's the existing behaviour, I do not think we should change it here (if we
really want to change it)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19080] Handle non existing patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19080

--- Comment #9 from Jonathan Druart  
---
Created attachment 66383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66383=edit
Bug 19080: Fix perlcritic in routing-lists.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18817] Update links in the help files for the new 17.11 manual

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817

Katrin Fischer  changed:

   What|Removed |Added

Summary|Screenshots not appearing   |Update links in the help
   |in the manual linked to the |files for the new 17.11
   |Help tab|manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18537] Update Ukrainian installer sample files for 17.05

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537

Serhij Dubyk  changed:

   What|Removed |Added

  Attachment #65179|0   |1
is obsolete||

--- Comment #12 from Serhij Dubyk  ---
Created attachment 66382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66382=edit
new patch

I tried to remove the trailing whitespace everywhere.

Perhaps there is still some problem in the patch preparation itself. I did the
following:

git clone git://git.koha-community.org/koha.git kohaclone
git checkout -b my_master origin/master
git fetch
git rebase origin/master
replace folder kohaclone/installer/data/mysql/uk-UA with new content from
https://www.dropbox.com/sh/nybt54x8yhh7frq/AACfsG32sJnBgNh1CdivXDjYa?dl=0%27
(folder SQL_Koha_17_05.01/uk-UA or uk-UA_SQL_Koha_17_05.01.zip)
git commit -a
git log
git format-patch origin/master
attach 0001-Bug-18537-Update-Ukr~ler-sample-files-fo.patch to Bugzilla

Do I need to execute a command "git rm file" for all deleted or renamed files?

I hope that there will be no problems with this version of the patch.

To test:
- Start with an empty database
- Install uk-UA
- Run the web installer in uk-UA/Ukrainian
- Verify all files load without any problems.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make Default authoritative

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19121] Prevent XSS in the Staff Client and the OPAC - bis

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19121

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19080] Handle non existing patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19080

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||julian.maur...@biblibre.com

--- Comment #8 from Julian Maurice  ---
QA comment:

1) $ perlcritic members/routing-lists.pl
Variable declared in conditional statement at line 51, column 1.  Declare
variables outside of the condition.  (Severity: 5)

This error is not detected by koha-qa, I'm not sure why.

2) If borrowernumber is 0, empty or not defined, the error message is not
displayed in circ/circulation.pl

Failing QA for 1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #152 from Alex Sassmannshausen 
 ---
Hi Tomás,

(In reply to Tomás Cohen Arazi from comment #150)
> Hi guys, I've been looking at this patchset without trying it yet.
> Everything looks as expected :-D
> The only thing I would like to mention is that the auth chain added a check
> for maintenance mode (usually on upgrades) that requires some more error
> codes to be added to the spec. Can you please take a look at (say)
> patrons.json from bug 18137? It's pretty straightforward.

I believe I have added a patch now that implements what you requested.  Feel
free to let me know if you think I missed something!

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #151 from Alex Sassmannshausen 
 ---
Created attachment 66381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66381=edit
Bug 11897: Follow up: Add more error conditions.

* api/v1/swagger/paths/rotas.json: Add 401, 500 & 503 error
  conditions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Alex Sassmannshausen  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19163] Critical typo in stage-marc-import process

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19163

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #8 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19166] New: Add the ability to add adjustments to an invoice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Bug ID: 19166
   Summary: Add the ability to add adjustments to an invoice
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: n...@bywatersolutions.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The goal of this enhancement is to allow libraries to make adjustments to
invoices based on feedback form a vendor (credit for returned books, damaged
books, or fees for extra charges etc.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

--- Comment #99 from Martin Renvoize  ---
Comment on attachment 65107
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65107
Bug 18137: Migrate from Swagger2 to Mojolicious::Plugin::OpenAPI

Review of attachment 65107:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18137=65107)
-

::: Koha/REST/V1/Auth.pm
@@ +57,5 @@
> +json => { error => 'Something went wrong, check the logs.' }
> +);
> +}
> +if ($_->isa('Koha::Exceptions::UnderMaintenance')) {
> +return $c->render(status => 503, json => { error => $_->error });

Should these calls to render not all be 'openapi => { error => $_->error }` as
aposed to `json => { error => $_->error }`.. else none of these responses are
getting validated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15239] Add multiple items fail on barcode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15239

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #10 from Tomás Cohen Arazi  ---
Hi Ruben,

(In reply to Ruben Norori from comment #9)
> I have the definitive solution:
> First we must add two new procedures, functions, methods, which consult in
> the database the registry homebranch.

I didn't go deep into the problem you're trying to solve, but I suggest you
don't introduce new subs, but use the current api instead.

We have a (sort of) DAO class called Koha::Items that exposes a ->search
method, which returns Koha::Item objects. So you can simply do something like
this:

  use Koha::Items;

  my $item = Koha::Items->find( $barcode );

->find gets an id column to find the row and create the object. 'barcode' is a
unique key, so this works.

Now you have a Koha::Item object, representing the item with the passed
barcode. You can then use it like:

  my $homebranch = $item->homebranch;

Hope it clarifies! This conversations are easier on the koha-devel list or on
the IRC channel.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18468] When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468

Christophe Croullebois  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19165

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19165] When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165

Christophe Croullebois  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18468

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19165] When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165

Christophe Croullebois  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||christophe.croullebois@bibl
   ||ibre.com
   Assignee|koha-b...@lists.koha-commun |christophe.croullebois@bibl
   |ity.org |ibre.com

--- Comment #1 from Christophe Croullebois 
 ---
Created attachment 66380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66380=edit
Discounts are not stored in $orderinfo before passing to populate prices

This patch is the same than Bug 18468, just for 16.11.

To test:
1 - Setup a vendor with a discount
2 - Stage a file
3 - Create a basket
4 - Order from staged file
5 - Add a price but no discount
6 - Save order
7 - Note ecost is not discounted
8 - Apply patch
9 - Repeate 2-6
10 - Note ecost is discounted

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19163] Critical typo in stage-marc-import process

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19163

--- Comment #7 from Marcel de Rooy  ---
Thanks Tomas and Liz for follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979

Mason James  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18947

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP authentication failure mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=6979

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Hugo Agud  changed:

   What|Removed |Added

 CC||ha...@orex.es

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] Allow using MARC modification templates in bulkmarcimport.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

--- Comment #18 from Jon Knight  ---
Test for this additional patch is to use the UI to create two MARC modification
templates with exactly the same name, and then try to use that name with the
bulkmarcimport.pl script.  It should fail with an error message suggesting that
the templates are renamed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] Allow using MARC modification templates in bulkmarcimport.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

Jon Knight  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] Allow using MARC modification templates in bulkmarcimport.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

--- Comment #17 from Jon Knight  ---
Created attachment 66379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66379=edit
Added error if there are multiple MARC templates with the same name.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19164] Allow MARC modification templates to be used in staged MARC imports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164

--- Comment #5 from Jon Knight  ---
Ah, just realised I was referencing the wrong Bug ID for the other bug - is
actually 18389. Too many browser tabs open!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19164] Allow MARC modification templates to be used in staged MARC imports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164

--- Comment #4 from Jon Knight  ---
Yes, I'm just doing the same thing in bug 18690 now. If folk like what I do
there, I'll pop the same code in here too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] Allow using MARC modification templates in bulkmarcimport.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

--- Comment #16 from Jon Knight  ---
I'd prefer to not expose the database ID to the end user as I don't think
that's terribly user friendly, nor portable. Recently I've been writing Koha
SQL reports for use with an external system and having the IDs change between
our dev box and the (hosted) live Koha is a bit of a pain there (I'm tempted to
suggest a bug enhancement to allow SQL reports to be selected by name rather
than ID!).

Should being able to generate MARC modification templates with identical names
be viewed as a bug in the UI perhaps? Its going to be confusing there too.

I'll put a check in to detect multiple MARC modification templates with the
same name and refuse to run until they are renamed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149

Hugo Agud  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||ha...@orex.es

--- Comment #5 from Hugo Agud  ---
Bug 16149 - Generate and send custom notices based on report output

63454 - Bug 16149 - Generate and send custom notices based on report output
63455 - Bug 16149 - Unit tests

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 16149 - Generate and send custom notices based on report output
Using index info to reconstruct a base tree...
M   C4/Reports/Guided.pm
Falling back to patching base and 3-way merge...
Auto-merging C4/Reports/Guided.pm
Applying: Bug 16149 - Unit tests
Using index info to reconstruct a base tree...
M   t/db_dependent/Reports/Guided.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Reports/Guided.t
CONFLICT (content): Merge conflict in t/db_dependent/Reports/Guided.t  
   
  6d20h 1.30 2x2.8GHz 3.7G85% 2017-08-23 08:09:18
Failed to merge in the changes.
Patch failed at 0001 Bug 16149 - Unit tests
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-16149---Unit-tests-IoVGvi.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18580] Account-pay does not apply credits / clear old fines as did recordpayment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18580

Colin Campbell  changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high
   Severity|enhancement |major

--- Comment #2 from Colin Campbell  ---
Upped priority as we are finding sites on upgrade to 16.11 and beyond
repeatedly enocountering inability to pay off fines as a result of this

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18946] Change language from external web fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18946

Hugo Agud  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #3 from Hugo Agud  ---
Sorry for the delay, the patch it works fine!

thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19165] New: When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165

Bug ID: 19165
   Summary: When adding from a staged file order discounts are not
passed into
C4::Acquisitions::populate_order_with_prices
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: christophe.croulleb...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Discounts are not stored in $orderinfo before passing to populate prices

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/