[Koha-bugs] [Bug 19194] Internal server error when receiving an order with no itemtype

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Resolution|--- |FIXED
 Status|Pushed to Stable|RESOLVED

--- Comment #9 from Katrin Fischer  ---
Depending bug is not in 16.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19067] clubs/ is not correctly mapped in Makefile.PL

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Katrin Fischer  ---
No patron clubs in 16.11.x, so not needed there.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18900] wrong number format in receiving order

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900

--- Comment #15 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.12.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18906] Superlibrarian and budget_manage_all users should always see all funds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18906

--- Comment #8 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.12.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18898] Some permissions for Reports can be bypassed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18898

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #9 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.12.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17827] Untranslatable "by" in MARC21slim2intranetResults.xsl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827

--- Comment #12 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.12.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18778] Translatability: Get rid of tt directive in translation for item-status.inc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18778

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.12.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18660] Translatability: Get rid of template directives [ %% in translation for patroncards-errors.inc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #12 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.12.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18652] Translatability: Get rid of tt directive in translation for uncertainprice.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652

--- Comment #14 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.12.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #36 from Katrin Fischer  ---
Onboarding is not in 16.11.x, so patch didn't apply cleanly. I've fixed the
conflict.

This patch has been pushed to 16.11.x and will be in 16.11.12.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18921] Resolve a few warnings in C4/XSLT.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18921

--- Comment #9 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.12.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused checkin for data corruption

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996

--- Comment #45 from Katrin Fischer  ---
Hi Jonathan, thx, tests all work now. Pushing.

These patches have been pushed to 16.11.x and will be in 16.11.12.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19205] Pay selected fine generates 500 error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19205

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Katrin Fischer  ---
I can't reproduce the error in 16.11.x and bug 15908 this depends on is not in
16.11.x.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19208] Pay select option doesn't pay the selected fine

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19208
Bug 19208 depends on bug 19205, which changed state.

Bug 19205 Summary: Pay selected fine generates 500 error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19205

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18046] Problem with redirect on logout with CAS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046

--- Comment #9 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.12.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16293] Patron Card Batches documentation is incomplete

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16293

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19326] Report editor in guided_reports.pl truncates reports longer than 64 KiB

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19326

--- Comment #5 from Katrin Fischer  ---
Not opposed to make the field bigger, was just wondering.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19326] Report editor in guided_reports.pl truncates reports longer than 64 KiB

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19326

--- Comment #4 from Katrin Fischer  ---
It just killed my editor... kind of makes me worry if it's wise to recommend it
for use with Koha :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19326] Report editor in guided_reports.pl truncates reports longer than 64 KiB

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19326

--- Comment #3 from Barton Chittenden  ---
(In reply to Katrin Fischer from comment #2)
> Can you give an example of a report (that would be wise to run) that is that
> long? I think major is too much here, we probably have a lot of fields if
> not all that cut off data if too long.

Cait,

See the attached file.

It poses no danger when run because it's syntactically incorrect when imported.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19326] Report editor in guided_reports.pl truncates reports longer than 64 KiB

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19326

Katrin Fischer  changed:

   What|Removed |Added

   Severity|major   |normal
 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
Can you give an example of a report (that would be wise to run) that is that
long? I think major is too much here, we probably have a lot of fields if not
all that cut off data if too long.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX )

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

--- Comment #44 from Katrin Fischer  ---
(In reply to Bouzid from comment #43)
> Hi katrin,
>  - For the first problem, I changed icon for $9 when create authority
>  - For the second problem, the workflow is the same in cataloguing authority
> plugin  
>   - Add MARC record
>   - Write any information in for example 700$a and click Tag editor
>   - You have cataloguing authority plugin window
>   - If you click Create new authority, you have the same page when
> you  click create authority added in this patch
>   - Import authority form LOC and save
>   - After saving, the window doesn't close and the information is
> not reported in the cataloguing authority plugin.
>   - If you need found this authority, you should reindex zebra and
> click search 
> 
>- The workflow in this patch is the same, when create authority, you
> should reindex and reclick Link authorities automatickly and you have the
> authid in $9.

I think if this is the case (could not verify on master yet) - it's a
regression/bug. I just tested on 16.11.10 as this was available to me:

- Open default framework
- Click on plugin on 100$a
- Use create authority from plugin window
- Enter 100$a with a name
- Save authority
- Window closes and data is filled in

If there is a bug, we will need to fix that first.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19314] Tag "" is not a valid tag

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19314

Katrin Fischer  changed:

   What|Removed |Added

Summary|1   |Tag "" is not a valid tag
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Manual
 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
Hi Chris, I agree about the use cases. I am tagging this with keyword "Manual"
in hope someone will submit a patch to the manual. Instructions can be found
here:
https://wiki.koha-community.org/wiki/Editing_the_Koha_Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19328] New: Internal server error because of missing currency

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19328

Bug ID: 19328
   Summary: Internal server error because of missing currency
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m...@adminkuhn.ch
QA Contact: testo...@bugs.koha-community.org

When clicking "Budgets" or "Funds" in Koha menu "Administration > Acquisition
parameters" just a blank page does appear, saying "Internal server error".

When clicking "Budgets" the log file "plack-error.log" says:

Can't call method "symbol" on an undefined value at
/usr/share/koha/intranet/cgi-bin/admin/aqbudgetperiods.pl line 94.

When clicking "Funds" it says:

Can't call method "symbol" on an undefined value at
/usr/share/koha/intranet/cgi-bin/admin/aqbudgets.pl line 53.

For example, line 94 of script "aqbudgetperiods.pl" says:

$template->param( symbol => $active_currency->symbol,
  currency => $active_currency->currency 

So this happens when no activated currency exists (for example when no example
currency was loaded). Instead of showing "Internal Server Error" Koha should
tell about the missing activated currency.

This was experienced in Koha 16.11.1 as well as in Koha 17.05.1.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208

David Bourgault  changed:

   What|Removed |Added

  Attachment #66738|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208

David Bourgault  changed:

   What|Removed |Added

  Attachment #66831|0   |1
is obsolete||

--- Comment #30 from David Bourgault  ---
Created attachment 67171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67171=edit
Bug 13208: [FOLLOW-UP] Tests for Koha::Acquisition::Baskets

To test:
prove -v t/db_dependent/Koha/Acquisition/Baskets.t

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208

David Bourgault  changed:

   What|Removed |Added

  Attachment #66740|0   |1
is obsolete||

--- Comment #28 from David Bourgault  ---
Created attachment 67169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67169=edit
Bug 13208: [FOLLOW-UP] Perl documentation for modules

Signed-off-by: Katrin Fischer 

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208

David Bourgault  changed:

   What|Removed |Added

  Attachment #66741|0   |1
is obsolete||

--- Comment #29 from David Bourgault  ---
Created attachment 67170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67170=edit
Bug 13208: (QA follow-up) Remove blank breadcrumbs on successful deletion

After order is deleted we don't have a vendor or basket so we get blank
breadcrumbs, this removes them

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208

David Bourgault  changed:

   What|Removed |Added

  Attachment #66739|0   |1
is obsolete||

--- Comment #27 from David Bourgault  ---
Created attachment 67168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67168=edit
Bug 13208: [FOLLOW-UP] Creating and implementing new
Koha::Acquisition::Basket[s] modules

Test plan remains the same.

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19195] Noisy warns when creating or editing a basket

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19195

--- Comment #3 from Dominic Pichette  ---
signed-off by : Dominic Pichette

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208

--- Comment #26 from David Bourgault  ---
Created attachment 67167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67167=edit
Bug 13208: Improving breadcrumbs for when cancelling an order

To test:
1) Go to Acquisitions -> Find a vendor -> View a basket with orders in
it (or make a new basket and add an order)
2) Click Cancel order
3) Notice incomplete breadcrumbs, and 'Acquisition' typo
4) Apply patch and refresh page
5) Breadcrumbs should be fixed. Confirm links to vendor and basket work
as expected

Sponsored-by: Catalyst IT

Signed-off-by: severine.queune 

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Bouzid  changed:

   What|Removed |Added

 Status|BLOCKED |Needs Signoff

--- Comment #18 from Bouzid  ---
Hi katrin,
I change status for this patch, because 11299 it's needs signoff.
Thanks.
Bouzid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19195] Noisy warns when creating or editing a basket

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19195

Dominic Pichette  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||dominic.piche...@inlibro.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19195] Noisy warns when creating or editing a basket

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19195

Dominic Pichette  changed:

   What|Removed |Added

  Attachment #66574|0   |1
is obsolete||

--- Comment #2 from Dominic Pichette  ---
Created attachment 67166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67166=edit
Bug 19195: Preventing noisy warns when creating or editing a basket

To test:
1) Open the koha intranet error log
2) Go to Acquisitions -> Find or create a vendor
3) Create a new basket, filling all fields
4) Notice warns in error log
5) Edit this basket
6) Notice warns in error log
7) Apply patch
8) Create another basket, confirm warns do not show
9) Edit this basket, confirm warns do not show

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

--- Comment #17 from Bouzid  ---
Rebase patch because it have conflict

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Bouzid  changed:

   What|Removed |Added

  Attachment #60999|0   |1
is obsolete||

--- Comment #16 from Bouzid  ---
Created attachment 67165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67165=edit
Bug 11300 - Add a new authority linker which searches for authority links on a
Z39.50 server.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX )

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Bouzid  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #43 from Bouzid  ---
Hi katrin,
 - For the first problem, I changed icon for $9 when create authority
 - For the second problem, the workflow is the same in cataloguing authority
plugin  
  - Add MARC record
  - Write any information in for example 700$a and click Tag editor
  - You have cataloguing authority plugin window
  - If you click Create new authority, you have the same page when you 
click create authority added in this patch
  - Import authority form LOC and save
  - After saving, the window doesn't close and the information is not
reported in the cataloguing authority plugin.
  - If you need found this authority, you should reindex zebra and
click search 

   - The workflow in this patch is the same, when create authority, you should
reindex and reclick Link authorities automatickly and you have the authid in
$9.

I think this is the workflow of koha.

Thanks.
Bouzid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19327] New: Typo in UNIMARC field 128a plugin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19327

Bug ID: 19327
   Summary: Typo in UNIMARC field 128a plugin
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: du...@ukr.net
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Small typo:

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_128a.tt;h=88d7f8c7a6d06bfe1da8cb1bd4f7e6bba5d0869c;hb=refs/heads/master#l259

Need to replace 

259  partsong

with

259  partsong

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19315] Routing preview may use wrong biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19315

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Attachment #67134|0   |1
is obsolete||

--- Comment #4 from Caroline Cyr La Rose  ---
Created attachment 67164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67164=edit
Bug 19315 - Use bibnum instead of biblionumber in routing-preview.pl and add
item check

To test:
 1 - Create a serial subscription attached to a record
 2 - Receive some issues
 3 - Edit the subscription
 4 - Go to serails collection
 5 - Try to print a routing list
 6 - You may or may not get the right serial
 7 - Additionally create a subscription attached to a bib with no items
 8 - Try to print a routing list for this serial
 9 - You will get 'Internal server error'
10 - Apply patch
11 - Print routing list for first serial
12 - You will always get the correct bib
13 - Print routing list for second serial
14 - You should no longer get an error

Signed-off-by: Caroline Cyr La Rose 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19307] t/db_dependent/Circulation/ NoIssuesChargeGuarantees.t fails if AllowFineOverride set to allow

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307

--- Comment #3 from Caroline Cyr La Rose  ---
Oops, sorry. I signed off this one by error while trying to sign off another
bug (new to git, linux and koha, does it show? haha!)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19307] t/db_dependent/Circulation/ NoIssuesChargeGuarantees.t fails if AllowFineOverride set to allow

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Attachment #67114|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19307] t/db_dependent/Circulation/ NoIssuesChargeGuarantees.t fails if AllowFineOverride set to allow

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com
  Attachment #67163|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584

David Bourgault  changed:

   What|Removed |Added

  Attachment #67158|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584

David Bourgault  changed:

   What|Removed |Added

  Attachment #67159|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584

--- Comment #16 from David Bourgault  ---
Sorry, I attached to the wrong bug...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584

David Bourgault  changed:

   What|Removed |Added

  Attachment #67160|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584

David Bourgault  changed:

   What|Removed |Added

  Attachment #67161|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19307] t/db_dependent/Circulation/ NoIssuesChargeGuarantees.t fails if AllowFineOverride set to allow

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Attachment #67114|0   |1
is obsolete||

--- Comment #2 from Caroline Cyr La Rose  ---
Created attachment 67163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67163=edit
Bug 19307 - Mock the AllowFineOverride preference to ensure expected result

To test:
 1 - Set 'AllowFineOverride' to allow
 2 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
 3 - 1 test fails
 4 - Apply patch
 5 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
 6 - All tests pass
 7 - Set 'AllowFineOverride' to 'Don't allow'
 8 - Tests should still pass

Signed-off-by: Caroline Cyr La Rose 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584

David Bourgault  changed:

   What|Removed |Added

 CC||david.bourga...@inlibro.com
  Attachment #67157|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19315] Routing preview may use wrong biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19315

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #3 from Caroline Cyr La Rose  ---
At step 9, I get a software error :"Can't call method "store" on an undefined
value at /inlibro/git/koha-master-dev-inlibro/C4/Reserves.pm line 907."

After applying the patch, everything/both routing lists works! yay! 

It's hard to know if I would've gotten the right info on the first routing list
(steps 1-6)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX )

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

--- Comment #42 from Bouzid  ---
Created attachment 67162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67162=edit
Bug 11299 - Change icon for create authority

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18933] Unable to set SMS number in OPAC messaging preferences to empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18933

Dominic Pichette  changed:

   What|Removed |Added

 CC||dominic.piche...@inlibro.co
   ||m

--- Comment #2 from Dominic Pichette  ---
Hey,

I can't manage to recreate the bug. after doing steps 1) to 4), I enter a
number, save it, refresh the page again(F5), delete the number, refresh it
again(F5) but the field for the number is indeed empty.

Please tell me if there is any information not specified in the test plan I
should be aware of.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19315] Routing preview may use wrong biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19315

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #2 from Caroline Cyr La Rose  ---
At step 5, I'm getting the error message : "Can't call method "branchname" on
an undefined value at
/inlibro/git/koha-master-dev-inlibro/serials/routing-preview.pl line 72." Is it
something I'm doing wrong?

I didn't apply the patch yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584

--- Comment #14 from David Bourgault  ---
Created attachment 67160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67160=edit
Bug 13208: (QA follow-up) Remove blank breadcrumbs on successful deletion

After order is deleted we don't have a vendor or basket so we get blank
breadcrumbs, this removes them

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584

--- Comment #12 from David Bourgault  ---
Created attachment 67158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67158=edit
Bug 13208: [FOLLOW-UP] Creating and implementing new
Koha::Acquisition::Basket[s] modules

Test plan remains the same.

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584

--- Comment #15 from David Bourgault  ---
Created attachment 67161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67161=edit
Bug 13208: [FOLLOW-UP] Tests for Koha::Acquisition::Baskets

To test:
prove -v t/db_dependent/Koha/Acquisition/Baskets.t

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584

--- Comment #13 from David Bourgault  ---
Created attachment 67159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67159=edit
Bug 13208: [FOLLOW-UP] Perl documentation for modules

Signed-off-by: Katrin Fischer 

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584

--- Comment #11 from David Bourgault  ---
Created attachment 67157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67157=edit
Bug 13208: Improving breadcrumbs for when cancelling an order

To test:
1) Go to Acquisitions -> Find a vendor -> View a basket with orders in
it (or make a new basket and add an order)
2) Click Cancel order
3) Notice incomplete breadcrumbs, and 'Acquisition' typo
4) Apply patch and refresh page
5) Breadcrumbs should be fixed. Confirm links to vendor and basket work
as expected

Sponsored-by: Catalyst IT

Signed-off-by: severine.queune 

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19180] Vendor name is missing from breadcrumbs when closing an order

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Attachment #67032|0   |1
is obsolete||

--- Comment #12 from Caroline Cyr La Rose  ---
Created attachment 67156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67156=edit
Bug 19180: [FOLLOW-UP] Renaming all instances of 'name' variable to
'booksellername'

... when referring to the name of the vendor.

To test:
1) Confirm vendor shows on webpage title (tab name)
2) Confirm vendor shows in breadcrumbs
3) Confirm vendor shows in heading when viewing basket ('Basket x (1) for
vendor')

Sponsored-by: Catalyst IT

Signed-off-by: Mark Tompsett 
Signed-off-by: Caroline Cyr La Rose 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8000] Test mode for notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

--- Comment #125 from David Bourgault  ---
Forgot to mention :

Step 1.5) Run updatedatabase.pl
Step 7) Run prove t/db_dependent/Letters.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8000] Test mode for notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

David Bourgault  changed:

   What|Removed |Added

 CC||david.bourga...@inlibro.com
  Attachment #62863|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8000] Test mode for notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

--- Comment #124 from David Bourgault  ---
Created attachment 67155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67155=edit
Bug 8000 - Redirect all emails to SendAllEmailsTo

Koha/Email.pm

Test plan:

1) Apply path
2) Clear all SendAllEmailsTo system preference
3) Send mail to a patron of your choosing, email will go to patron's
   email address as usual.
4) Set SendAllEmailsTo to a test email address
5) Send mail to the patron, email will be redirected to the email set
   in the systempreference.

It does not affect messages in the message_queue.

This patch obsoletes previous patches, because it achieves the same
functionality in a much more centralized way. (4 lines of code!)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19193] When displaying the fines of the guarantee on the guarantor account, price is not in correct format.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19193

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #5 from Caroline Cyr La Rose  ---
Yes! It worked!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19193] When displaying the fines of the guarantee on the guarantor account, price is not in correct format.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19193

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Attachment #66560|0   |1
is obsolete||

--- Comment #4 from Caroline Cyr La Rose  ---
Created attachment 67154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67154=edit
Bug 19193 - When displaying the fines of the guarantee on the guarantor
account, price is not in correct format

1 - Have a patron with guarantees
2 - Charge some fines to the guarantees
3 - View the patron
4 - Fines are displayed unformatted
5 - Apply patch
6 - Refresh
7 - Fines should now be formatted correctly

Signed-off-by: Caroline Cyr La Rose 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19323] subscription edit permission issue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19323

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #3 from Caroline Cyr La Rose  ---
Worked!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19323] subscription edit permission issue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19323

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Attachment #67141|0   |1
is obsolete||

--- Comment #2 from Caroline Cyr La Rose  ---
Created attachment 67153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67153=edit
Bug 19323: subscription edit permission issue

If a librarian has edit_subscription but not create_subscription :
When trying to edit a subscription, after saving permission is denied.

This is because permissions in serials/subscription-add.pl depends on arg 'op'
and on edit this arg starts with 'modify' but changes to 'modsubscription' when
saving.

Test plan :
- Create a user with staff access
- Define its permissions on serials : only edit_subscription
- Edit a subscription
- Click 'Next'
- Click 'Test prediction pattern'
- Click 'Save subscription'
=> Without patch you get to page serials/subscription-add.pl with permission
denied
=> With patch subscription is saved and you get to subscription details page

Signed-off-by: Caroline Cyr La Rose 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Lisa  changed:

   What|Removed |Added

 CC||l...@hchlibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13983] Title shows doubled up in fine description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13983

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14438] RTF / CSV /ODS format in Download cart option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14438

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

--- Comment #36 from Jonathan Druart  
---
Created attachment 67152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67152=edit
Bug 17981: Remove uneeded module JS var

As we only support CHECKIN and CHECKOUT for now, we do not need this
module variable. It may be useful to re-add it later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

--- Comment #35 from Jonathan Druart  
---
(In reply to Owen Leonard from comment #34)
> While rebasing Bug 18007 I noticed something in this update:
> 
> In the JavaScript there are couple of instances of a "module" variable which
> doesn't appear to ever be initialized. Is it superfluous, or should it be
> created somewhere?

Yes you are right, it could be removed for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

--- Comment #4 from Chris Nighswonger  ---
I'm sure it would help Nicole with the documentation of it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

--- Comment #3 from Chris Nighswonger  ---
Perhaps a description of a use case or two might be beneficial to the end user.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14140] Reversed payments don't generate entry in statistics

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14140

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17098] Validation problems with form field type "number" ( decimal separator)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17098

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19326] Report editor in guided_reports.pl truncates reports longer than 64 KiB

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19326

Barton Chittenden  changed:

   What|Removed |Added

   Severity|enhancement |major

--- Comment #1 from Barton Chittenden  ---
Set to MAJOR because of data loss.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19326] New: Report editor in guided_reports.pl truncates reports longer than 64 KiB

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19326

Bug ID: 19326
   Summary: Report editor in guided_reports.pl truncates reports
longer than 64 KiB
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 67151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67151=edit
A query longer than 65535; this will be truncated when saved.

The field saved_sql.savedsql is type 'text', which is 65535 characters long.

mysql> select table_name, column_name, data_type from
information_schema.columns where column_name = 'savedsql';
++-+---+
| table_name | column_name | data_type |
++-+---+
| saved_sql  | savedsql| text  |
++-+---+

The query editor in  guided_reports.pl does not check the size of the report
being saved, causing the report to be truncated if its more than 65535
characters long.

I would suggest changing the data type of savedsql to LONGTEXT, then limiting
the query length to something fairly large, but less than 4,294,967,295
characters, with a warning (to avoid denial of service by filling the hard
drive).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8016] Items are not tie to the transaction using "global" action.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8016

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16113] Specify due date for batch check out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16113

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

David Bourgault  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

David Bourgault  changed:

   What|Removed |Added

  Attachment #67149|0   |1
is obsolete||

--- Comment #2 from David Bourgault  ---
Created attachment 67150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67150=edit
Bug 19325 - Adds an option to pad barcode length

Inserts a small change to C4::Label::barcode()

Test case:

1) Apply patch
2) Run updatedatabase.pl
3) Print some barcodes to PDF. They should look as usual.
4) Go in systempreferences and enable "BarcodePaddingEnable". Set the a
   length and a character.
5) Print some barcodes to PDF. They should now be of fixed length.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

--- Comment #1 from David Bourgault  ---
Created attachment 67149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67149=edit
Bug 19325 - Add an option to pad barcode length

Inserts a small change to C4::Label::barcode()

Test case:

1) Apply patch
2) Run updatedatabase.pl
3) Print some barcodes to PDF. They should look as usual.
4) Go in systempreferences and enable "BarcodePaddingEnable". Set the a
   length and a character.
5) Print some barcodes to PDF. They should now be of fixed length.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16112] Specify due date for batch renew

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15533] Allow patrons and librarians to select itemtype when placing hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] New: Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

Bug ID: 19325
   Summary: Enable padding of printed barcodes
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Label/patron card printing
  Assignee: cnighswon...@foundations.edu
  Reporter: david.bourga...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

Small enhancement which would provide an option to pad the length of barcodes
printed to PDF with a custom character.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

--- Comment #34 from Owen Leonard  ---
While rebasing Bug 18007 I noticed something in this update:

In the JavaScript there are couple of instances of a "module" variable which
doesn't appear to ever be initialized. Is it superfluous, or should it be
created somewhere?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9313] add fine amounts to overdue with fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9313

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

--- Comment #31 from Jonathan Druart  
---
Created attachment 67146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67146=edit
Bug 17981: Add a preview mode for notice templates

This patch is a first step to provide a preview mode for notice
templates.

CHECKIN, CHECKOUT and HOLD_SLIP are supported so far.
Maybe more, but I have not tested yet and the interface will not allow
you to generate the preview.

The idea is to provide an idea of how will render the messages generated
from a notice template.

A new "Preview" button is added close to each textarea on the editing
notice templates view.
For each notice template code (letter_code), we will need some input
data to produce the preview.

For instance, for CHECKIN we need an barcode. From the barcode we
can guess all the other data.
For CHECKOUT we will need the borrowernumber and the barcode.
Note that the way to enter the data for the preview is not really
user-friendly, for CHECKOUT you will have to fill
'borrowernumber|barcode', but the placeholder will help you to know how
and what to fill.
In the modal window, you will see 4 blocks:
1/ the content of the letter (with the placeholds << >>)
2/ the generated message (with the data filled)
3/ if the letter contained historical syntax markers, the screen will
try to generate a notice template using the TT syntax
4/ the generated message from this TT syntax
=> You will be able to compare the 2 generated messages.

What is the goal of this first patchset:
- Show this first POC and get feedback from other developpers
- Add a way to easily visualise the differences between the 2 syntaxes
- Confort users with the TT syntax and the migration step from the
historical syntax.

I'd like to get opinions before going further.

The possibilities:
- Mock data to get fully working generated messages for any notice
templates. For instance, for CHECKIN and CHECKOUT, the item is not
checked in/out yet. So we cannot access the issue's information.
(I have no idea how to do that)
- Browse the data to get the ones we want to use for the preview (big).

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

--- Comment #33 from Jonathan Druart  
---
Created attachment 67148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67148=edit
Bug 17981: Move the divs to the top of the modal

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #65701|0   |1
is obsolete||
  Attachment #65702|0   |1
is obsolete||
  Attachment #65703|0   |1
is obsolete||
  Attachment #65704|0   |1
is obsolete||
  Attachment #65705|0   |1
is obsolete||

--- Comment #29 from Jonathan Druart  
---
Created attachment 67144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67144=edit
Bug 17981: Move svc/letters to svc/letters/get

To allow another script under svc/letters

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

--- Comment #32 from Jonathan Druart  
---
Created attachment 67147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67147=edit
Bug 17981: Better error handling

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

--- Comment #30 from Jonathan Druart  
---
Created attachment 67145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67145=edit
Bug 17981: Add a 'letter' param to GetPreparedLetter

This will allow us to call GetPreparedLetter with a letter content that
does not exist in the DB

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19324] New Inventory workflow eliminates "mark item seen" and doesn' t show data in table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19324

Jessie Zairo  changed:

   What|Removed |Added

Summary|New Inventory workflow  |New Inventory workflow
   |eliminates "mark item seen" |eliminates "mark item seen"
   ||and doesn't show data in
   ||table

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19324] New Inventory workflow eliminates "mark item seen" and doesn' t show data in table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19324

Jessie Zairo  changed:

   What|Removed |Added

   Priority|P5 - low|P3
   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19324] New Inventory workflow eliminates "mark item seen" and doesn' t show data in table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19324

Jessie Zairo  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19324] New: New Inventory workflow eliminates "mark item seen"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19324

Bug ID: 19324
   Summary: New Inventory workflow eliminates "mark item seen"
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jza...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

With recent updates to 16.11.09 and the master release, there seem to be 2
functionality changes. The first is the workflow for marking items seen in the
inventory tool seems to disappear. The second is Koha is not bringing back
results (No data available in table) when you don't compare to a list.

Steps to recreate comparing barcodes against a list of results in 16.11.09 and
master
1) Upload a file of barcodes with same shelving location
2) Choose option compare barcodes to list of results
3) Filter by library, call number or shelving location 
4) Click submit
5) you will be presented with a 2 boxes letting you know the number of items
modified : datelastseen set to xx/xx/xxx and the Number of potential barcodes
read: xxx
6) No option to mark the results "Mark seen and quit" or "Mark seen and
continue" or  "Continue without marking"

Steps to recreate NOT comparing barcodes against a list of results in 16.11.09
and master
1) Upload a file of barcodes with same shelving location
2) Filter by library, call number or shelving location 
3) Click submit
4) you will be presented with a 2 boxes letting you know the number of items
modified : datelastseen set to xx/xx/xxx and the Number of potential barcodes
read: xxx
5) No data available in table 
6) Koha no longer brings back results of the other filtered locations

We believe this is where the functionality changes from bug 14399
Fix inventory.pl part two (following 12913)

Steps to recreate NOT comparing barcodes against a list of results (16.11.04 &
16.11.07)
1) Upload a file of barcodes with same shelving location
2) Filter by library, call number or shelving location 
3) Click submit
5) you will be presented with a 2 boxes letting you know the number of items
modified : datelastseen set to xx/xx/xxx and the Number of potential barcodes
read: xxx
6) There is an option to mark the results "Mark seen and quit" or "Mark seen
and continue" or  "Continue without marking"

Steps to recreate NOT comparing barcodes against a list of results (16.11.04 &
16.11.07)
1) Upload a file of barcodes with same shelving location
2) Filter by library, call number or shelving location 
3) Click submit
5) you will be presented with a 2 boxes letting you know the number of items
modified : datelastseen set to xx/xx/xxx and the Number of potential barcodes
read: xxx
6) We do not get an option to mark the results "Mark seen and quit" or "Mark
seen and continue" or  "Continue without marking"
7) This does have a list of results in the table

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16260] Moderate the impact of AllowHoldsOnPatronsPossessions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16260

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/