[Koha-bugs] [Bug 7468] Add label to batch by barcode range

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5620] Capture Mode of payment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

--- Comment #28 from Katrin Fischer  ---
Maybe it's excluded on purpose like the SIP payment methods as you are not
supposed to set it manually? That would make sense to me.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #30 from Katrin Fischer  ---
Glad to see this one moving!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

--- Comment #7 from Katrin Fischer  ---
I think with the patch both methods would be used at the same time - anti-the
and the new perl based method. 

Note: Example content of the pref should at least also contain English
articles!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
I feel like this is trying to achieve something for one table, that we need a
more general solution for. At the moment we already do something like this for
other tables using a translatable string:

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc;h=72be3f10e834e9b478e1e66bbb60c3a9c39c91d4;hb=a1bf319829c9d44991daa2fcf2593420f8445c5b
var CONFIG_EXCLUDE_ARTICLES_FROM_SORT = _("a an the");

Maybe we should just move this string to be a system preference and then use it
for serials too?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19338] Dates sorting incorrectly in opac-account.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18008] Use templates for generating pagination in intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008

--- Comment #7 from Josef Moravec  ---
(In reply to Alex Buckley from comment #5)
> Hi Josef
> 
> When I apply this patch on an up to date clean branch I get the following
> error:
> 

Thanks for testing, I've just rebased on master, should be OK now...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18008] Use templates for generating pagination in intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008

Josef Moravec  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18008] Use templates for generating pagination in intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008

Josef Moravec  changed:

   What|Removed |Added

  Attachment #63023|0   |1
is obsolete||

--- Comment #6 from Josef Moravec  ---
Created attachment 67588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67588=edit
Bug 18008: Make pagination generated in templates

It generates pagination in bootstrap style (as bug 18005 also do)

Modified pages:
acqui/neworderbiblio.pl
authorities/authorities-home.pl
cataloguing/addbooks.pl
cataloguing/value_builder/marc21_linking_section.pl
cataloguing/value_builder/unimarc_field_210c.pl
cataloguing/value_builder/unimarc_field_4XX.pl
reports/guided_reports.pl
reviews/reviewswaiting.pl
tags/review.pl
virtualshelves/shelves.pl

Test plan:
0) Apply the patch
1) go through pages from the list above/use cataloguing plugins, and
make the data to be big enough for pagination
2) confirm that pagination looks nice and behave correctly
3) git grep pagination_bar
  should return just C4/Output.pm and opac templates (I'll deal with it
  on another bugs)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14723] Additional delivery notes to messages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||alexbuck...@catalyst.net.nz

--- Comment #26 from Alex Buckley  ---
Hi Lari  

When applying your patch I got the following merge error on Letters.t file,
(note: as I am using an up to date master branch patch 18413 is already applied
(I double checked to make sure)): 

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 14723: Additional delivery notes to messages
Using index info to reconstruct a base tree...
M   C4/Letters.pm
M   installer/data/mysql/kohastructure.sql
M   koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt
M   t/db_dependent/Letters.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Letters.t
CONFLICT (content): Merge conflict in t/db_dependent/Letters.t
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt
Auto-merging installer/data/mysql/kohastructure.sql
Auto-merging C4/Letters.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 14723: Additional delivery notes to messages
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-14723-Additional-delivery-notes-to-messages-Zqwu8p.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930

--- Comment #3 from Alex Buckley  ---
Actually one of the dependencies further down the stream (this patch depends on
18928, and that in turn depends on 18925, and that in turn depends on 18887) of
this patch is bug 18887 and when applying that it would not apply successfully. 

So until that is rebased against master then testing this patch will not be
possible.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add a column for note, order number ans ISBN in late order page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67354|0   |1
is obsolete||

--- Comment #6 from Alex Buckley  ---
Created attachment 67587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67587=edit
Bug 12502 - Add ordernumber and ISBN to late order

Adds ordernumber as 2nd column and ISBN as last

Followed test plan and patch worked as described. Also ran QA test tools
and all modified files passed

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add a column for note, order number ans ISBN in late order page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add a column for note, order number ans ISBN in late order page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67349|0   |1
is obsolete||

--- Comment #5 from Alex Buckley  ---
Created attachment 67586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67586=edit
Bug 12502 - Add vendor and internal note to late orders page

Followed test plan and patch worked as described. Also ran QA test tools
and all modified files passed.

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16820] add possibility to edit fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16820] add possibility to edit fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67313|0   |1
is obsolete||

--- Comment #2 from Alex Buckley  ---
Created attachment 67585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67585=edit
Bug 16820 - Edit accountlines from borrower's profile

Adds the option to edit an accountline from a borrower's profile page in the
intranet.

Test plan :
0) Try to edit an accountline, you can't
1) Apply patch
2) Try to edit an accountline, you can

Also solves Bug 2193

Followed test plan, patch worked as described. Also ran QA test tools
and all 3 modified files passed

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67558|0   |1
is obsolete||

--- Comment #29 from Alex Buckley  ---
Created attachment 67584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67584=edit
Bug 4319 - [OPAC] allow to holds waiting items

Test plan:

 - Checkout an item
 - Place hold on this item,
 - Return the item
 - Make sure the hold is waiting (found W) and AllowOnShelfHolds is
   not to 'Allow'
 - Check that the button "Place hold" appears in opac detail page of
   the biblio

Followed test plan (see below note), patch worked as described. Also ran QA
test tool and
both altered files passed.

Just a note about the test plan: AllowOnShelfHolds is no longer a syspref, but
it exists in
the circulation matrix, i.e. it is available on the Administrator->Circulation
and
fine rules, to test this patch I set it to 'If any unavailable'.

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||alexbuck...@catalyst.net.nz

--- Comment #91 from Alex Buckley  ---
Hi Philippe

Sorry but when applying your patch I got the following merge errors (see
below), the issues are in moremember.tt and moremember.pl. Can you please
rebase against master and then I will be more than happy to test again:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 11879: Add the "Main contact method" field in borrower
informations.
Using index info to reconstruct a base tree...
M   installer/data/mysql/kohastructure.sql
M   installer/data/mysql/updatedatabase.pl
M   koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
M   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
M   members/memberentry.pl
M   members/moremember.pl
M   opac/opac-memberentry.pl
Falling back to patching base and 3-way merge...
Auto-merging opac/opac-memberentry.pl
Auto-merging members/moremember.pl
CONFLICT (content): Merge conflict in members/moremember.pl
Auto-merging members/memberentry.pl
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
Auto-merging installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/kohastructure.sql
Failed to merge in the changes.
Patch failed at 0001 Bug 11879: Add the "Main contact method" field in borrower
informations.
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-11879-Add-the-Main-contact-method-field-in-bor-uOjbTv.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19278] Add a configurable default page size for endpoints

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #5 from Alex Buckley  ---
Hi Tomas

Sorry but when applying your patch I got the following merge error, (note: I
did apply patch 19196 beforehand):

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 19278: Add RESTdefaultPageSize syspref
Applying: Bug 19278: Unit tests
Using index info to reconstruct a base tree...
M   t/Koha/REST/Plugin/Pagination.t
Falling back to patching base and 3-way merge...
Auto-merging t/Koha/REST/Plugin/Pagination.t
Applying: Bug 19278: Make the pagination plugin use RESTdefaultPageSize
fatal: sha1 information is lacking or useless (Koha/REST/Plugin/Pagination.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 19278: Make the pagination plugin use
RESTdefaultPageSize
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-19278-Make-the-pagination-plugin-use-RESTdefau-NPNcVH.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Hugh Rundle  changed:

   What|Removed |Added

 CC||hu...@brimbank.vic.gov.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz
 Status|Needs Signoff   |Failed QA

--- Comment #3 from Alex Buckley  ---
Hi Julian

When performing step 2 (creating a new subscription for supplier S1) I found
that a software error was thrown (see below). You will need to add the
aqbooksellerid to the Koha::Schema::Result::Serial

Software error:

DBIx::Class::Row::store_column(): No such column 'aqbooksellerid' on
Koha::Schema::Result::Serial at /home/vagrant/kohaclone/Koha/Object.pm line 72

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #59 from Liz Rea  ---
This still applies, could we get a QA to look at it please? Really good
feature.

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18008] Use templates for generating pagination in intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||alexbuck...@catalyst.net.nz

--- Comment #5 from Alex Buckley  ---
Hi Josef

When I apply this patch on an up to date clean branch I get the following
error:

Applying: Bug 18008: Make pagination generated in templates
Using index info to reconstruct a base tree...
M   acqui/neworderbiblio.pl
M   cataloguing/value_builder/marc21_linking_section.pl
M   cataloguing/value_builder/unimarc_field_4XX.pl
M   koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
M   reports/guided_reports.pl
M   reviews/reviewswaiting.pl
M   tags/review.pl
M   virtualshelves/shelves.pl
Falling back to patching base and 3-way merge...
Auto-merging virtualshelves/shelves.pl
Auto-merging tags/review.pl
Auto-merging reviews/reviewswaiting.pl
CONFLICT (content): Merge conflict in reviews/reviewswaiting.pl
Auto-merging reports/guided_reports.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt
Auto-merging cataloguing/value_builder/unimarc_field_4XX.pl
Auto-merging cataloguing/value_builder/marc21_linking_section.pl
Auto-merging acqui/neworderbiblio.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 18008: Make pagination generated in templates
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-18008-Make-pagination-generated-in-templates-1W76fJ.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12227] remove demo user functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz

--- Comment #3 from Alex Buckley  ---
What is the demo setting in koha-conf.xml that needs to be enabled? I cannot
find the string 'demo' in the aforementioned file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11210] Allow partial writeoff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67345|0   |1
is obsolete||

--- Comment #4 from Alex Buckley  ---
Created attachment 67583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67583=edit
Bug 11210 - Writeoff partial amounts

Minor changes to pay.pl and paycollect.tt to allow writing off a partial amount
of a fine.

Test plan:
0) Go to the Fines tab of a test patron's profile
1) Create a fine if there are none (under the Manual invoice tab)
2) Go to the "Pay fines" tab
3) Press the write off button on the corresponding account line

Without patch, you'll be asked to confirm, but will not be able to edit the
amount
With patch, you'll be able to edit the amount.

Followed test plan, patch worked as described. Also ran QA test tool and
modified files passed

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11210] Allow partial writeoff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5620] Capture Mode of payment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #27 from Alex Buckley  ---
Hi David 

This patch looks really good but one point that needs to be fixed is that on
the paycollect.tt page there is no 'PayPal' option in the dropdown box however
you have got a case statement for displaying 'Payment, thanks (PayPal)' in the
boraccount.tt and opac-account.tt. Can you please add the 'PayPal' option in
the paycollect.tt dropdown input. Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18993] Bump libtest-simple-perl to 1.302075

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993

--- Comment #15 from Mason James  ---
(In reply to Jonathan Druart from comment #14)
> So, moving on now?

yes, looks good :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5620] Capture Mode of payment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

Alex Buckley  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19338] Dates sorting incorrectly in opac-account.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338

Liz Rea  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7468] Add label to batch by barcode range

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19338] Dates sorting incorrectly in opac-account.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338

Liz Rea  changed:

   What|Removed |Added

  Attachment #67195|0   |1
is obsolete||
  Attachment #67196|0   |1
is obsolete||

--- Comment #4 from Liz Rea  ---
Created attachment 67582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67582=edit
Bug 19338 - Dates sorting incorrectly in opac-account.tt

To test:
Find an account with lots of fines/payments
load up the borrower's account in the OPAC
note that the sort on the dates sorts by day, and not by date.
apply this patch
reload the page, note that the sort on the dates is now correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5620] Capture Mode of payment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||alexbuck...@catalyst.net.nz

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7468] Add label to batch by barcode range

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz

--- Comment #5 from Alex Buckley  ---
Hi David

Whilst testing this patch I notice after writing in a range of valid, existing
barcodes and then click the 'Print range' button all I get is a message 'false'
on the loaded page.

The URL of this printed page is 'javascript:print()'. I assume this is not what
is wanted.

No Javascript error is thrown although there is a Javascript warning that there
is unreachable code after the return statement in label-edit-range.pl on line
163 (which is actually line 14 in the label-edit-range.tt file)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19406] New: REST API: Add route for checkins

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19406

Bug ID: 19406
   Summary: REST API: Add route for checkins
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: REST api
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au

I don't have plans to work on this at the moment, but it would be great to have
a route for checkins. 

I notice that there is already a bug for checkouts at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895. 

This could replace svc/checkin. I haven't tried the REST API yet but it's
probably better performance than svc/checkin anyway. 

Plus, this would allow other apps to checkin for Koha.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67447|0   |1
is obsolete||

--- Comment #5 from Alex Buckley  ---
Created attachment 67581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67581=edit
Bug 19368 - Correction on QA feedback

* I removed the IGNORE in the atomicupdate SQL. There is currently no other
systempreference by that name in Master so that should work fine
- Removed leftover test values from syspref.sql
- Removed extra $ in serial-search.tt
- Removed leftover warn in serial-search.pl

Passes QA test tool
Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67373|0   |1
is obsolete||

--- Comment #4 from Alex Buckley  ---
Created attachment 67580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67580=edit
Bug 19368 - Ignore words when sorting serial search

This adds the 'SerialSortIgnoreWords' system preference.
It is empty by default, since words to ignore are very much language-specific.

The functionality is achieved by adding a hidden column to the table, and
sorting by this column by default. The downfall of this solution is that if the
user sorts by another column, they cannot go back to this sorting without
refreshing the page.

To test:
0) Apply patch
1) Run updatedatabase.pl
2) Add test subscriptions if you have none.
Make sure to have subscriptions starting with "The An A" or similar
3) Go to system preferences and edit the SerialSortIgnoreWords pref
Add the words "The An A" or the ones you used in your subscriptions
4) Go to Serials
5) Search serials (empty field will return all serials)
6) Result table should be sorted ignoring leading "The An A..."

Followed test plan, patch works as described
Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13895] REST API: Add API routes for checkouts retrieval and renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #51 from David Cook  ---
What does "issues retrieval" mean?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17385] Add custom export notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67357|0   |1
is obsolete||

--- Comment #15 from Alex Buckley  ---
Created attachment 67579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67579=edit
Bug 17385 - Add custom export XSLT

Patch was corrected and rebased after QA feedback. Previous patches where
combined into this one.

- Empty READMEs have been deleted
- Whitespaces changes to unrelated code have been undone
* CustomXSLTExportList now uses LibXML to figure out the title and output
* The custom export XSLT's title should be an attribute to the root node,
otherwise it will default to filename
- Duplicate $xslFile param was removed from XSLTParse4Display
* Improvment to code structure in XSLTParse4Display
* Some fixes to calls to AddBiblio()

Test case:
  - Apply patch
  - Visit an item's detail page in the OPAC or the staff interface
  - Click save and you found Simple Export.
  - Click Simple Export and you have a file.html, it contain informations
returned by the xslt file.
  - It work correctly in basket and lists.

The patch comes with sample XSLT files
  for Intranet the xsl file is :
koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl
  for opac the xsl file is :
koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl

Followed test plan, patch works as described. Also ran QA test tools and
modified files pass

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17385] Add custom export notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make Default authoritative

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #23 from David Cook  ---
It would be great to have a single test plan in a comment. I'm not entirely
sure what I need to test here... 

I'll do my best to find all the relevant test plans but we'll see.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #44 from Alex Buckley  ---
When applying these patches this error is thrown:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 15261: Verify if checkouts/reserves requests periods overlap...
Applying: Bug 15261 - Check reserves while renewing an issue
fatal: sha1 information is lacking or useless (C4/Circulation.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 15261 - Check reserves while renewing an issue
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-15261---Check-reserves-while-renewing-an-issue-b3aCiG.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18760] printable checkin alerts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||alexbuck...@catalyst.net.nz

--- Comment #6 from Alex Buckley  ---
Hi Alex

Following the first test plan in comment 4 I notice that when you click to edit
an item the checkin alert input is empty even if you have entered a checkn
alert. And then when you checkout and then checkin an item no alert modal box
is displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19405] t/db_dependent/api/v1/holds.t fails randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19405

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #2 from Jonathan Druart  
---
Pushed to master for 17.11.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19405] t/db_dependent/api/v1/holds.t fails randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19405

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19405] t/db_dependent/api/v1/holds.t fails randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19405

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19405] t/db_dependent/api/v1/holds.t fails randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19405

--- Comment #1 from Jonathan Druart  
---
Created attachment 67578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67578=edit
Bug 19405: Prevent api/v1/holds.t to fail randomly

DBD::mysql::st execute failed: Duplicate entry
'cEMggO40gdPLhcVXbpry8x0izO8lHr8NafFIBJwm0D1HgiXA57YR0a0VVxhQBzvn' for key
'userid' [for Statement "INSERT INTO `borrowers` ( `branchcode`,
`categorycode`, `flags`, `surname`, `userid`) VALUES ( ?, ?, ?, ?, ? )" with
ParamValues: 0='N2ElsY9', 1='Kk8G', 2=80, 3='Test Surname',
4='cEMggO40gdPLhcVXbpry8x0izO8lHr8NafFIBJwm0D1HgiXA57YR0a0VVxhQBzvnnbgezJqmxqwz']
at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.
DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry
'cEMggO40gdPLhcVXbpry8x0izO8lHr8NafFIBJwm0D1HgiXA57YR0a0VVxhQBzvn' for key
'userid' at /kohadevbox/koha/Koha/Object.pm line 121
[18:52:19] t/db_dependent/api/v1/holds.t

Reading the code I guess it happens if TestBuilder generates a userid with the
size of borrowers.userid (75 chars). In that case the following lines are
wrong:

$borrower->userid($nopermission->{ userid }."z");
$borrower2->userid($nopermission->{ userid }."x");
$borrower3->userid($nopermission->{ userid }."y");

The 3 patrons will have the same userid.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19405] t/db_dependent/api/v1/holds.t fails randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19405

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19405] New: t/db_dependent/api/v1/holds.t fails randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19405

Bug ID: 19405
   Summary: t/db_dependent/api/v1/holds.t fails randomly
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 14868

DBD::mysql::st execute failed: Duplicate entry
'cEMggO40gdPLhcVXbpry8x0izO8lHr8NafFIBJwm0D1HgiXA57YR0a0VVxhQBzvn' for key
'userid' [for Statement "INSERT INTO `borrowers` ( `branchcode`,
`categorycode`, `flags`, `surname`, `userid`) VALUES ( ?, ?, ?, ?, ? )" with
ParamValues: 0='N2ElsY9', 1='Kk8G', 2=80, 3='Test Surname',
4='cEMggO40gdPLhcVXbpry8x0izO8lHr8NafFIBJwm0D1HgiXA57YR0a0VVxhQBzvnnbgezJqmxqwz']
at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.
DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry
'cEMggO40gdPLhcVXbpry8x0izO8lHr8NafFIBJwm0D1HgiXA57YR0a0VVxhQBzvn' for key
'userid' at /kohadevbox/koha/Koha/Object.pm line 121
# Looks like your test exited with 255 before it could output anything.
[18:52:19] t/db_dependent/api/v1/holds.t

Reading the code I guess it happens if TestBuilder generates a userid with the
size of borrowers.userid (75 chars). In that case the following lines are
wrong:

$borrower->userid($nopermission->{ userid }."z");
$borrower2->userid($nopermission->{ userid }."x");
$borrower3->userid($nopermission->{ userid }."y");

The 3 patrons will have the same userid.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868
[Bug 14868] REST API: Swagger2-driven permission checking
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission checking

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19405


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19405
[Bug 19405] t/db_dependent/api/v1/holds.t fails randomly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz
 Status|Needs Signoff   |In Discussion

--- Comment #2 from Alex Buckley  ---
Hi David

After checking out an item out with a due date set to be over 30 days ago and
then running this cronjob I have found that the following error is thrown in
the cronjob output:

kohadev-koha@kohadevbox:/home/vagrant/kohaclone/misc/cronjobs$ ./fines.pl
--maxfinesdays 30
DateTime::Duration does not overload comparison.  See the documentation on the
compare() method for details. at ./fines.pl line 129.

And no maximum fine is added to the accountlines table

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67427|0   |1
is obsolete||

--- Comment #2 from Alex Buckley  ---
Created attachment 67577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67577=edit
Bug 19380: Add transfer informations in ILS-DI GetRecords response

Test plan:
1. Put an item into a 'transfer' state
  a. Place a hold on an item in branch A for a patron of branch B
  b. Check in this item in branch A and confirm transfer
2. Go to http://opac/cgi-bin/koha/ilsdi.pl?service=GetRecords=XXX
   where XXX is the biblionumber of the biblio the item belongs to.
3. Verify you have a new  element inside //record/items/item
   that contains ,  and 
4. Check in the same item in branch B, so that the item is not flagged
   as being transferred
5. Repeat 2
6. Verify that the  element is not there.
7. prove t/db_dependent/ILSDI_Services.t

Followed test plan, patch worked as described. Also ran QA test tools
and modified files passed

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19349] Allow to store biblio record' s creator and last modifier in MARC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19349

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||alexbuck...@catalyst.net.nz

--- Comment #2 from Alex Buckley  ---
Hi Julian

I have set the four sysprefs with the values 942$w, 942$x, 942$y, and 942$z
however when I go to create a new biblio these four fields are not displayed in
the '9' tab of the new biblio page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19400] Reminder to unset gone no address flag after patron makes a modification request

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19400

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19400] Reminder to unset gone no address flag after patron makes a modification request

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19400

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67524|0   |1
is obsolete||

--- Comment #2 from Alex Buckley  ---
Created attachment 67575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67575=edit
Bug 19400: Reminder to unset gone no address flag after patron makes a
modification request

Our librarians requested a reminder to unset "gone no address" flag from
patron's
record once the patron has made a modification request to update their address.

I propose adding a message box under patron modification request to notify
librarians about patrons that have gone no address flag on, and an option to
unset the flag without the need of having to navigate into patron's details.

To test:
1. Apply patch
2. Set "Gone no address" flag for your test patron. You can do this by going
   to patron modification screen in staff client.
3. Go to OPAC with your test patron
4. Make a modification request for your personal details
5. Go to staff client and see pending modification requests
6. Open the request you just created
7. Observe a message dialog that says this patron has gone no address flag set
8. Check the checkbox to unset the flag and approve the modification request
9. Click Submit
10. Observe your test patron no longer has gone no address flag set
11. Repeat steps 2-7
12. Do not check the checkbox, but approve the modification request
13. Observe your test patron still has gone no address flag set
14. Remove the gone no address flag from your test patron
15. Repeat steps 3-6
16. Observe there is no message dialog for gone no address

Followed test plan, patch worked as described. Also ran QA test tools
and all modified files passed

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19370] Add a helper function for translating order_by params into SQL ::Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 67576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67576=edit
Bug 19370: Remove undefined variable warning

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19402] Date of birth datepicker year range depending on current value

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19402

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||alexbuck...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19402] Date of birth datepicker year range depending on current value

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19402

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67543|0   |1
is obsolete||

--- Comment #3 from Alex Buckley  ---
Created attachment 67574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67574=edit
Bug 19402: Date of birth datepicker year range not depending on current value

Bug 18447 sets for date of birth a year range "c-100:c" meaning current year
and 100 years earlier.
This is good when imput is empty.
But when input already contains a date, say "01/01/1950", years range is 1850
to 1950.

This patch sets for date of birth a year range "-120:+0" to not be dependent on
current value.
Some people may have more than 100 years (maybe more often in the future) so i
choose to propose maximum 120 years old.

To test :
1) Go to intranet
2) Create a new patron
3) Click on date picker on "Date of birth" input
4) Look at available years in combobox, you see from 1897 to 2017
5) Edit an existing patron with for example date of birth in 1950
6) Repeat 3) and 4)
7) Go to OPAC
8) Login with a patron with for example date of birth in 1950
9) Go to "your personal details"
10) Repeate 3) and 4)

Followed test plan, patch worked as described. Also ran QA test tools
and that passed the files modified in this patch
Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19198] Renewal as issue causes too many error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #67569|0   |1
is obsolete||

--- Comment #16 from Tomás Cohen Arazi  ---
Created attachment 67573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67573=edit
Bug 19198: (QA followup) Fix typo in conditions

'&' should be '&&'

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19198] Renewal as issue causes too many error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #67567|0   |1
is obsolete||

--- Comment #14 from Tomás Cohen Arazi  ---
Created attachment 67571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67571=edit
Bug 19198: Unit tests

Signed-off-by: Lee Jamison 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19198] Renewal as issue causes too many error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #67568|0   |1
is obsolete||

--- Comment #15 from Tomás Cohen Arazi  ---
Created attachment 67572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67572=edit
Bug 19198: Renewal as issue causes too many error

This patch moves some code and prevents checking for too many checkouts
when performing a renewal via checkout

To test:
1 - Set a rule to limit checkouts to a single issue, allowing renewal
2 - Issue an item to a patron
3 - Issue the same item
4 - In staff client you get a confirm to renew and a notice of Too Many
checkouts, don't confirm
5 - VIA Sip - you get a renewal response, but in logs the renewal fails
as a 'too
6 - Apply patch
7 - Via staff client you shoudl get renewal confirm with no too many
error
8 - SIP checkout should renew

Signed-off-by: Lee Jamison 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19404] SPAM

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19404

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID
Summary|koznae  |SPAM
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19350] Holds without link in 773 trigger SQL::Abstract::puke

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19350

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #7 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19350] Holds without link in 773 trigger SQL::Abstract::puke

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19350

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Elastic related tests do not skip when ES modules are not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

--- Comment #28 from M. Tompsett  ---
(In reply to Tomás Cohen Arazi from comment #25)
> The patches work as expected. I wouldn't recommend them for the master
> branch, though.

I agree. If you push these to master, making sure the right dependencies are
pulled for 17.11 and later will be missed. And as ES is maturing, and needs to
be used and tested in 17.11, errors will force people to make sure the
dependencies are right. Pushing these to master will give nice skipping
messages and people may forget more easily.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19404] New: koznae

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19404

Bug ID: 19404
   Summary: koznae
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: HP
OS: Other
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Authentication
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ramshel1...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

Created attachment 67570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67570=edit
ramadnahdak

zzuhahahaha

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19135] AllowHoldsOnPatronsPossessions is not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135

--- Comment #7 from Jonathan Druart  
---
My remarks should not block QA, I can edit the commit message later if the
author of the patch does not do it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19198] Renewal as issue causes too many error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198

--- Comment #13 from Nick Clemens  ---
Created attachment 67569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67569=edit
Bug 19198 (QA Followup) Fix typo in conditions

'&' should be '&&'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19198] Renewal as issue causes too many error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198

Nick Clemens  changed:

   What|Removed |Added

  Attachment #67111|0   |1
is obsolete||
  Attachment #67112|0   |1
is obsolete||
  Attachment #67113|0   |1
is obsolete||

--- Comment #11 from Nick Clemens  ---
Created attachment 67567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67567=edit
Bug 19198 - Unit tests

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19198] Renewal as issue causes too many error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19198] Renewal as issue causes too many error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198

--- Comment #12 from Nick Clemens  ---
Created attachment 67568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67568=edit
Bug 19198 - Renewal as issue causes too many error

This patch moves some code and prevents checking for too many checkouts
when performing a renewal via checkout

To test:
1 - Set a rule to limit checkouts to a single issue, allowing renewal
2 - Issue an item to a patron
3 - Issue the same item
4 - In staff client you get a confirm to renew and a notice of Too Many
checkouts, don't confirm
5 - VIA Sip - you get a renewal response, but in logs the renewal fails
as a 'too
6 - Apply patch
7 - Via staff client you shoudl get renewal confirm with no too many
error
8 - SIP checkout should renew

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19403] Again and again, Circulation.t is failing randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19403

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19403] Again and again, Circulation.t is failing randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19403

--- Comment #3 from Jonathan Druart  
---
Pushed to master for 17.11.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19403] Again and again, Circulation.t is failing randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19403

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19403] Again and again, Circulation.t is failing randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19403

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19403] Again and again, Circulation.t is failing randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19403

--- Comment #1 from Jonathan Druart  
---
Created attachment 67565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67565=edit
Bug 19403: Add some default values when building patrons for test

To avoid some tests to fail randomly

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19403] Again and again, Circulation.t is failing randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19403

--- Comment #2 from Jonathan Druart  
---
Created attachment 67566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67566=edit
Bug 19403: Prevent Circulation.t to fail randomly

Due to the number of test cases handle by CanBookBeIssued, Circulation.t
fails randomly. To prevent that it is better to set some values.
For instance if the patron is a statistical patron (category_type=X),
the subroutine will return a STATS flag.

This patch also adds a subroutine to the test file to display the keys
of $error, $question and $alert set by CanBookBeIssued.
It will be easier to track other random failures.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19403] Again and again, Circulation.t is failing randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19403

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19198] Renewal as issue causes too many error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Signed Off  |Patch doesn't apply

--- Comment #10 from Tomás Cohen Arazi  ---
Sorry Nick, can you rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19122] IncludeSeeFromInSearches is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #67536|0   |1
is obsolete||

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 67564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67564=edit
Bug 19122: (bug 18098 follow-up) Fix IncludeSeeFromInSearches behaviour

The IncludeSeeFromInSearches system preference is designed so that 'See from'
headings from the authorities are included when you search in the catalog.
That means that you could find an author not only by the name printed on the
book, but for example also by their pseudonym or a different spelling of their
name.

It was added by bug 7417.

This regression has been introduced by
  commit 5ef1b6710e7520b844e145e248da0d707fde
  Bug 18098: Add an index with the count of not onloan items

-} elsif ($record_type eq 'biblio' &&
C4::Context->preference('IncludeSeeFromInSearches')) {
-my $normalizer = Koha::RecordProcessor->new( { filters =>
'EmbedSeeFromHeadings' } );
[...]
+push @filters, 'IncludeSeeFromInSearches'
+if C4::Context->preference('IncludeSeeFromInSearches');

Test plan:
- Activate IncludeSeeFromInSearches
- Catalog an authority for a person
  - main heading in 100
  - see from headings in 400
- Catalog a bibliographic record and link it to the authority
- Make sure the record is indexed
- Verify that the record can be found searching for the main heading
- Verify that the record can be found searching for the see from headings

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 
Yet another reason to get rid of all this functions from this script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19122] IncludeSeeFromInSearches is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19403] New: Again and again, Circulation.t is failing randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19403

Bug ID: 19403
   Summary: Again and again, Circulation.t is failing randomly
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 19009

#   Failed test 'No error or alert should be raised'
#   at t/db_dependent/Circulation.t line 1553.
#  got: '1'
# expected: '0'

#   Failed test 'BIBLIO_ALREADY_ISSUED question flag should be set if
AllowMultipleIssuesOnABiblio=0 and issue already exists'
#   at t/db_dependent/Circulation.t line 1554.
#  got: undef
# expected: '1'

#   Failed test 'No BIBLIO_ALREADY_ISSUED flag should be set if
AllowMultipleIssuesOnABiblio=1'
#   at t/db_dependent/Circulation.t line 1558.
#  got: '1'
# expected: '0'

#   Failed test 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a
subscription'
#   at t/db_dependent/Circulation.t line 1565.
#  got: '1'
# expected: '0'

#   Failed test 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a
subscription'
#   at t/db_dependent/Circulation.t line 1569.
#  got: '1'
# expected: '0'
# Looks like you failed 5 tests of 5.

#   Failed test 'CanBookBeIssued + AllowMultipleIssuesOnABiblio'
#   at t/db_dependent/Circulation.t line 1570.
# Looks like you failed 1 test of 102.
[15:00:27] t/db_dependent/Circulation.t ...


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19009
[Bug 19009] Circulation.t is still failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19009] Circulation.t is still failing randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19009

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19403


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19403
[Bug 19403] Again and again, Circulation.t is failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18993] Bump libtest-simple-perl to 1.302075

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

--- Comment #14 from Jonathan Druart  
---
So, moving on now?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18993] Bump libtest-simple-perl to 1.302075

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993

--- Comment #13 from Jonathan Druart  
---
Created attachment 67563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67563=edit
Bug 18993: Bump Test::More to 1.302075

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19350] Holds without link in 773 trigger SQL::Abstract::puke

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19350

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #6 from Jonathan Druart  
---
(In reply to Dobrica Pavlinusic from comment #4)
> Unfortunately, my rapidly progressing cataract don't allow me to spend
> sufficient time to learn how to write code tests for this bug. I was hoping
> that test scenario will be enough. Sorry.

Thanks for your patches Dobrica, good to know you are still around :)
Take care.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19350] Holds without link in 773 trigger SQL::Abstract::puke

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19350

--- Comment #5 from Jonathan Druart  
---
Created attachment 67562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67562=edit
Bug 19350: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19350] Holds without link in 773 trigger SQL::Abstract::puke

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19350

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19343] Private lists displayed in search results list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #9 from Jonathan Druart  
---
Upping severity a bit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19343] Private lists displayed in search results list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
Version|17.05   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19343] Private lists displayed in search results list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #8 from Jonathan Druart  
---
Signed off on all patches (lazy to re-upload them with the signed-off-by line)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Elastic related tests do not skip when ES modules are not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

--- Comment #27 from Fridolin SOMERS  ---
Thanks everyone for your job, Jenkins is about to turn green ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19343] Private lists displayed in search results list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343

--- Comment #7 from Jonathan Druart  
---
Created attachment 67561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67561=edit
Bug 19343: [16.11.X] Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Elastic related tests do not skip when ES modules are not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Passed QA   |Pushed to Stable

--- Comment #26 from Fridolin SOMERS  ---
Pushed to 17.05.x, will be in 17.05.05.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19343] Private lists displayed in search results list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343

--- Comment #6 from Jonathan Druart  
---
Created attachment 67560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67560=edit
Bug 19343: [17.05.X] Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19343] Private lists displayed in search results list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343

--- Comment #5 from Jonathan Druart  
---
Created attachment 67559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67559=edit
Bug 19343: Add tests - do not display a list when private

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/